Re: [webkit-dev] Changing the implementation of KURL

2012-01-28 Thread Adam Barth
On Fri, Jan 27, 2012 at 9:44 PM, Darin Fisher da...@chromium.org wrote: On Fri, Jan 27, 2012 at 2:39 AM, Adam Barth aba...@webkit.org wrote: On Fri, Jan 27, 2012 at 1:49 AM, Maciej Stachowiak m...@apple.com wrote: That said, this plan was based on the premise that Chromium folks were willing

Re: [webkit-dev] Changing the implementation of KURL

2012-01-28 Thread Joe Mason
-Original Message- From: webkit-dev-boun...@lists.webkit.org [mailto:webkit-dev- boun...@lists.webkit.org] On Behalf Of Adam Barth Sent: Saturday, January 28, 2012 3:20 AM To: Darin Fisher Cc: Benjamin Poulain; WebKit Development Subject: Re: [webkit-dev] Changing the implementation

Re: [webkit-dev] Changing the implementation of KURL

2012-01-28 Thread Brett Wilson
On Sat, Jan 28, 2012 at 12:19 AM, Adam Barth aba...@webkit.org wrote: On Fri, Jan 27, 2012 at 9:44 PM, Darin Fisher da...@chromium.org wrote: On Fri, Jan 27, 2012 at 2:39 AM, Adam Barth aba...@webkit.org wrote: On Fri, Jan 27, 2012 at 1:49 AM, Maciej Stachowiak m...@apple.com wrote: That

Re: [webkit-dev] Changing the implementation of KURL

2012-01-28 Thread Maciej Stachowiak
On Jan 28, 2012, at 9:24 AM, Brett Wilson wrote: On Sat, Jan 28, 2012 at 12:19 AM, Adam Barth aba...@webkit.org wrote: On Fri, Jan 27, 2012 at 9:44 PM, Darin Fisher da...@chromium.org wrote: On Fri, Jan 27, 2012 at 2:39 AM, Adam Barth aba...@webkit.org wrote: On Fri, Jan 27, 2012 at 1:49 AM,

Re: [webkit-dev] Changing the implementation of KURL

2012-01-28 Thread Brett Wilson
On Sat, Jan 28, 2012 at 4:07 PM, Maciej Stachowiak m...@apple.com wrote: On Jan 28, 2012, at 9:24 AM, Brett Wilson wrote: On Sat, Jan 28, 2012 at 12:19 AM, Adam Barth aba...@webkit.org wrote: On Fri, Jan 27, 2012 at 9:44 PM, Darin Fisher da...@chromium.org wrote: On Fri, Jan 27, 2012 at 2:39

Re: [webkit-dev] Changing the implementation of KURL

2012-01-28 Thread Brett Wilson
On Sat, Jan 28, 2012 at 4:48 PM, Brett Wilson bre...@chromium.org wrote: On Sat, Jan 28, 2012 at 4:07 PM, Maciej Stachowiak m...@apple.com wrote: On Jan 28, 2012, at 9:24 AM, Brett Wilson wrote: On Sat, Jan 28, 2012 at 12:19 AM, Adam Barth aba...@webkit.org wrote: On Fri, Jan 27, 2012 at

Re: [webkit-dev] Changing the implementation of KURL

2012-01-28 Thread Joe Mason
-Original Message- From: webkit-dev-boun...@lists.webkit.org [mailto:webkit-dev- boun...@lists.webkit.org] On Behalf Of Maciej Stachowiak Sent: Saturday, January 28, 2012 7:08 PM To: Brett Wilson Cc: Benjamin Poulain; WebKit Development Subject: Re: [webkit-dev] Changing the

Re: [webkit-dev] Changing the implementation of KURL

2012-01-28 Thread Brett Wilson
On Sat, Jan 28, 2012 at 5:28 PM, Joe Mason jma...@rim.com wrote: -Original Message- From: webkit-dev-boun...@lists.webkit.org [mailto:webkit-dev- boun...@lists.webkit.org] On Behalf Of Maciej Stachowiak Sent: Saturday, January 28, 2012 7:08 PM To: Brett Wilson Cc: Benjamin Poulain;

Re: [webkit-dev] Changing the implementation of KURL

2012-01-28 Thread Benjamin Poulain
On Sat, Jan 28, 2012 at 4:59 PM, Brett Wilson bre...@chromium.org wrote: So to clarify, I think we need to keep the current architecture. Obviously WebKit needs a URL class that uses its String class, so WTFURL would probably be a wrapper around some core library for WebKit to use. Chromium

Re: [webkit-dev] Changing the implementation of KURL

2012-01-28 Thread Darin Fisher
The other concern I have is about the stability of the API to the URL guts that GURL living in the chromium repository would depend on. Anyone changing the URL guts would need to be careful not to break that contract. This seems like it might be annoying for those who do not work on chromium. On

Re: [webkit-dev] Changing the implementation of KURL

2012-01-28 Thread Adam Barth
On Sat, Jan 28, 2012 at 5:51 PM, Benjamin Poulain benja...@webkit.org wrote: On Sat, Jan 28, 2012 at 4:59 PM, Brett Wilson bre...@chromium.org wrote: So to clarify, I think we need to keep the current architecture. Obviously WebKit needs a URL class that uses its String class, so WTFURL would

Re: [webkit-dev] Changing the implementation of KURL

2012-01-28 Thread Darin Fisher
On Sat, Jan 28, 2012 at 6:01 PM, Adam Barth aba...@webkit.org wrote: On Sat, Jan 28, 2012 at 5:51 PM, Benjamin Poulain benja...@webkit.org wrote: On Sat, Jan 28, 2012 at 4:59 PM, Brett Wilson bre...@chromium.org wrote: So to clarify, I think we need to keep the current architecture.

Re: [webkit-dev] Changing the implementation of KURL

2012-01-28 Thread Benjamin Poulain
On Sat, Jan 28, 2012 at 8:01 PM, Darin Fisher da...@chromium.org wrote: If CFNetwork exposed an API to its URL parser, then it would be super wise for any port of WebKit using CFNetwork to reuse the same URL parser. That is an interesting idea. I always considered it would be beneficial to