On Jan 28, 2012, at 8:01 PM, Darin Fisher wrote:
Right. In Firefox, the problem was that the cookie code used some hand-rolled
string parsing code instead of reusing the URL parsing code. That resulted in
a subtle bug that could be exploited to steal cookies. In Safari's case, I
On Fri, Jan 27, 2012 at 9:44 PM, Darin Fisher da...@chromium.org wrote:
On Fri, Jan 27, 2012 at 2:39 AM, Adam Barth aba...@webkit.org wrote:
On Fri, Jan 27, 2012 at 1:49 AM, Maciej Stachowiak m...@apple.com wrote:
That said, this plan was based on the premise that Chromium folks were
willing
-Original Message-
From: webkit-dev-boun...@lists.webkit.org [mailto:webkit-dev-
boun...@lists.webkit.org] On Behalf Of Adam Barth
Sent: Saturday, January 28, 2012 3:20 AM
To: Darin Fisher
Cc: Benjamin Poulain; WebKit Development
Subject: Re: [webkit-dev] Changing the implementation
On Sat, Jan 28, 2012 at 12:19 AM, Adam Barth aba...@webkit.org wrote:
On Fri, Jan 27, 2012 at 9:44 PM, Darin Fisher da...@chromium.org wrote:
On Fri, Jan 27, 2012 at 2:39 AM, Adam Barth aba...@webkit.org wrote:
On Fri, Jan 27, 2012 at 1:49 AM, Maciej Stachowiak m...@apple.com wrote:
That
On Jan 28, 2012, at 9:24 AM, Brett Wilson wrote:
On Sat, Jan 28, 2012 at 12:19 AM, Adam Barth aba...@webkit.org wrote:
On Fri, Jan 27, 2012 at 9:44 PM, Darin Fisher da...@chromium.org wrote:
On Fri, Jan 27, 2012 at 2:39 AM, Adam Barth aba...@webkit.org wrote:
On Fri, Jan 27, 2012 at 1:49 AM,
On Sat, Jan 28, 2012 at 4:07 PM, Maciej Stachowiak m...@apple.com wrote:
On Jan 28, 2012, at 9:24 AM, Brett Wilson wrote:
On Sat, Jan 28, 2012 at 12:19 AM, Adam Barth aba...@webkit.org wrote:
On Fri, Jan 27, 2012 at 9:44 PM, Darin Fisher da...@chromium.org wrote:
On Fri, Jan 27, 2012 at 2:39
On Sat, Jan 28, 2012 at 4:48 PM, Brett Wilson bre...@chromium.org wrote:
On Sat, Jan 28, 2012 at 4:07 PM, Maciej Stachowiak m...@apple.com wrote:
On Jan 28, 2012, at 9:24 AM, Brett Wilson wrote:
On Sat, Jan 28, 2012 at 12:19 AM, Adam Barth aba...@webkit.org wrote:
On Fri, Jan 27, 2012 at
-Original Message-
From: webkit-dev-boun...@lists.webkit.org [mailto:webkit-dev-
boun...@lists.webkit.org] On Behalf Of Maciej Stachowiak
Sent: Saturday, January 28, 2012 7:08 PM
To: Brett Wilson
Cc: Benjamin Poulain; WebKit Development
Subject: Re: [webkit-dev] Changing
; WebKit Development
Subject: Re: [webkit-dev] Changing the implementation of KURL
Let's take some specific examples. Would using WTF::Vector inside the
implementation (not necessarily at the API boundary, just internally)
be acceptable? Or would it be required to use C arrays or std::vector
On Sat, Jan 28, 2012 at 4:59 PM, Brett Wilson bre...@chromium.org wrote:
So to clarify, I think we need to keep the current architecture.
Obviously WebKit needs a URL class that uses its String class, so
WTFURL would probably be a wrapper around some core library for WebKit
to use. Chromium
, January 28, 2012 7:08 PM
To: Brett Wilson
Cc: Benjamin Poulain; WebKit Development
Subject: Re: [webkit-dev] Changing the implementation of KURL
Let's take some specific examples. Would using WTF::Vector inside the
implementation (not necessarily at the API boundary, just internally
On Sat, Jan 28, 2012 at 5:51 PM, Benjamin Poulain benja...@webkit.org wrote:
On Sat, Jan 28, 2012 at 4:59 PM, Brett Wilson bre...@chromium.org wrote:
So to clarify, I think we need to keep the current architecture.
Obviously WebKit needs a URL class that uses its String class, so
WTFURL would
On Sat, Jan 28, 2012 at 6:01 PM, Adam Barth aba...@webkit.org wrote:
On Sat, Jan 28, 2012 at 5:51 PM, Benjamin Poulain benja...@webkit.org
wrote:
On Sat, Jan 28, 2012 at 4:59 PM, Brett Wilson bre...@chromium.org
wrote:
So to clarify, I think we need to keep the current architecture.
On Sat, Jan 28, 2012 at 8:01 PM, Darin Fisher da...@chromium.org wrote:
If CFNetwork exposed an API to its URL parser, then it would be super wise
for
any port of WebKit using CFNetwork to reuse the same URL parser.
That is an interesting idea.
I always considered it would be beneficial to
On Thu, Jan 26, 2012 at 11:17 PM, Darin Fisher da...@chromium.org wrote:
Instead of doing all of this work, have you considered just treating
GoogleURL in much the same way as WebKit treats ANGLE? You could perhaps
just commit a copy of GoogleURL into Source/ThirdParty, and then WebKit as a
On Fri, Jan 27, 2012 at 12:03 AM, Benjamin Poulain benja...@webkit.orgwrote:
On Thu, Jan 26, 2012 at 11:17 PM, Darin Fisher da...@chromium.org wrote:
Instead of doing all of this work, have you considered just treating
GoogleURL in much the same way as WebKit treats ANGLE? You could perhaps
As one data point, GoogleURL is quite stable. If you look at the
changes http://code.google.com/p/google-url/source/list, there's
only about one commit a month.
Adam
On Fri, Jan 27, 2012 at 12:22 AM, Darin Fisher da...@chromium.org wrote:
On Fri, Jan 27, 2012 at 12:03 AM, Benjamin Poulain
On Jan 27, 2012, at 12:22 AM, Darin Fisher wrote:
On Fri, Jan 27, 2012 at 12:03 AM, Benjamin Poulain benja...@webkit.org
wrote:
On Thu, Jan 26, 2012 at 11:17 PM, Darin Fisher da...@chromium.org wrote:
Instead of doing all of this work, have you considered just treating
GoogleURL in much
On Fri, Jan 27, 2012 at 1:49 AM, Maciej Stachowiak m...@apple.com wrote:
That said, this plan was based on the premise that Chromium folks were
willing to cooperate with the unforking effort, and would be happy to use a
WebKit-integrated URL library based on GoogleURL. If that is no longer the
On Jan 27, 2012, at 2:39 AM, Adam Barth wrote:
On Fri, Jan 27, 2012 at 1:49 AM, Maciej Stachowiak m...@apple.com wrote:
That said, this plan was based on the premise that Chromium folks were
willing to cooperate with the unforking effort, and would be happy to use a
WebKit-integrated URL
On Fri, Jan 27, 2012 at 2:39 AM, Adam Barth aba...@webkit.org wrote:
On Fri, Jan 27, 2012 at 1:49 AM, Maciej Stachowiak m...@apple.com wrote:
That said, this plan was based on the premise that Chromium folks were
willing to cooperate with the unforking effort, and would be happy to
use a
Hello,
I would like to give another shot at the URL implementation Adam
started some times ago.
There are a few problems with the current KURL:
-there are two implementations: WebKit and Google URL
-some stuff are just plain incorrect :)
-the WebKit implementation has some bugs which makes it
On Thu, Jan 26, 2012 at 6:11 PM, Benjamin Poulain benja...@webkit.orgwrote:
Hello,
I would like to give another shot at the URL implementation Adam
started some times ago.
There are a few problems with the current KURL:
-there are two implementations: WebKit and Google URL
-some stuff are
23 matches
Mail list logo
