Re: [webkit-dev] Compile times and class-scoped enums

> On Jan 23, 2023, at 11:05 AM, Geoffrey Garen wrote: > >>> However, this change requires moving class-scoped enums out into the >>> namespace scope. >> >> Seems worthwhile. Doesn’t seem to me like it would have far reaching effects. > > I agree. > >> +using Type = DOMAudioSessionType;

Re: [webkit-dev] Compile times and class-scoped enums

>> However, this change requires moving class-scoped enums out into the >> namespace scope. > > Seems worthwhile. Doesn’t seem to me like it would have far reaching effects. I agree. > +using Type = DOMAudioSessionType; Did you do this to make the patch smaller, or do you prefer this

Re: [webkit-dev] Compile times and class-scoped enums

> On Jan 20, 2023, at 9:50 AM, Jer Noble via webkit-dev > wrote: > > I attempted to address this in , > which (on this machine) reduces the total compile time of Document.h in the > WebCore project from about 1000s to about 200s. That’s good. >

Re: [webkit-dev] Compile times and class-scoped enums

On Fri, Jan 20 2023 at 09:50:05 AM -0800, Jer Noble via webkit-dev wrote: However, this requires a significant coding style change, both to existing code and new code, and as such, it should probably be discussed here. So, what do people think? Is the change in coding style (moving