Re: [webkit-dev] Smart Pointers Usage Guidelines

2023-08-21 Thread Ryosuke Niwa via webkit-dev
> On Aug 21, 2023, at 4:51 PM, Ryosuke Niwa via webkit-dev > wrote: > >> On Aug 21, 2023, at 4:50 PM, Tim Horton wrote: >> >>> On Aug 21, 2023, at 4:42 PM, Ryosuke Niwa wrote: >>> On Aug 21, 2023, at 4:41 PM, Darin Adler wrote: > On Aug 21, 2023, at 4:39 PM, Ryosuke Niwa

Re: [webkit-dev] Smart Pointers Usage Guidelines

2023-08-21 Thread Ryosuke Niwa via webkit-dev
> On Aug 21, 2023, at 4:50 PM, Tim Horton wrote: > > > >> On Aug 21, 2023, at 4:42 PM, Ryosuke Niwa wrote: >> >> >> >>> On Aug 21, 2023, at 4:41 PM, Darin Adler wrote: >>> On Aug 21, 2023, at 4:39 PM, Ryosuke Niwa wrote: Alternatively, we could add a new member

Re: [webkit-dev] Smart Pointers Usage Guidelines

2023-08-21 Thread Ryosuke Niwa via webkit-dev
> On Aug 21, 2023, at 4:41 PM, Darin Adler wrote: > >> On Aug 21, 2023, at 4:39 PM, Ryosuke Niwa wrote: >> >> Alternatively, we could add a new member function which returns CheckedPtr >> like `pageChecked()`. > > Yes, I think that would be a good approach that would complement the static

Re: [webkit-dev] Smart Pointers Usage Guidelines

2023-08-21 Thread Darin Adler via webkit-dev
> On Aug 21, 2023, at 4:39 PM, Ryosuke Niwa wrote: > > Alternatively, we could add a new member function which returns CheckedPtr > like `pageChecked()`. Yes, I think that would be a good approach that would complement the static checker. —

Re: [webkit-dev] Smart Pointers Usage Guidelines

2023-08-21 Thread Tim Horton via webkit-dev
> On Aug 21, 2023, at 4:39 PM, Ryosuke Niwa wrote: > > >> On Aug 21, 2023, at 4:34 PM, Darin Adler wrote: >> >> >>> On Aug 21, 2023, at 4:31 PM, Tim Horton via webkit-dev >>> wrote: >>> One subtle thing is that even when a member variable is already Ref / RefPtr / CheckedRef

Re: [webkit-dev] Smart Pointers Usage Guidelines

2023-08-21 Thread Ryosuke Niwa via webkit-dev
> On Aug 21, 2023, at 4:34 PM, Darin Adler wrote: > > >> On Aug 21, 2023, at 4:31 PM, Tim Horton via webkit-dev >> wrote: >> >>> One subtle thing is that even when a member variable is already Ref / >>> RefPtr / CheckedRef / CheckedPtr, we must create another one in stack as >>> seen

Re: [webkit-dev] Smart Pointers Usage Guidelines

2023-08-21 Thread Tim Horton via webkit-dev
> On Aug 21, 2023, at 4:34 PM, Darin Adler wrote: > > >> On Aug 21, 2023, at 4:31 PM, Tim Horton via webkit-dev >> wrote: >> >>> One subtle thing is that even when a member variable is already Ref / >>> RefPtr / CheckedRef / CheckedPtr, we must create another one in stack as >>> seen

Re: [webkit-dev] Smart Pointers Usage Guidelines

2023-08-21 Thread Darin Adler via webkit-dev
> On Aug 21, 2023, at 4:31 PM, Tim Horton via webkit-dev > wrote: > >> One subtle thing is that even when a member variable is already Ref / RefPtr >> / CheckedRef / CheckedPtr, we must create another one in stack as seen here: >> https://commits.webkit.org/267108@main > > (I asked rniwa to

Re: [webkit-dev] Smart Pointers Usage Guidelines

2023-08-21 Thread Tim Horton via webkit-dev
> On Aug 21, 2023, at 4:25 PM, Ryosuke Niwa via webkit-dev > wrote: > > Hi all, > > It has been a while since I last announced the plan to adopt smart pointers > using clang static analyzer: > https://lists.webkit.org/pipermail/webkit-dev/2020-September/031386.html > > Here are some