Re: [webkit-dev] Stop Using Raw Pointers & References in New Code

2023-01-20 Thread Ryosuke Niwa via webkit-dev
> On Jan 13, 2023, at 11:06 AM, Ryosuke Niwa via webkit-dev > wrote: > >> On Jan 13, 2023, at 6:39 AM, Darin Adler wrote: >> >> I don’t think I can notice these patterns. I would be able to program this >> way if I had an analysis tool, but otherwise this simply seems too >> complicated. >

Re: [webkit-dev] Compile times and class-scoped enums

2023-01-20 Thread Darin Adler via webkit-dev
> On Jan 20, 2023, at 9:50 AM, Jer Noble via webkit-dev > wrote: > > I attempted to address this in , > which (on this machine) reduces the total compile time of Document.h in the > WebCore project from about 1000s to about 200s. That’s good. >

[webkit-dev] Compile times and class-scoped enums

2023-01-20 Thread Jer Noble via webkit-dev
Hi all! I’ve noticed that compile times for the WebKit project have started creeping up again, so I and a few other WebKit contributors started looking into possible compile time improvements using the tools listed in . One cause of long

Re: [webkit-dev] Compile times and class-scoped enums

2023-01-20 Thread Michael Catanzaro via webkit-dev
On Fri, Jan 20 2023 at 09:50:05 AM -0800, Jer Noble via webkit-dev wrote: However, this requires a significant coding style change, both to existing code and new code, and as such, it should probably be discussed here. So, what do people think? Is the change in coding style (moving