Re: [whatwg] Comment Syntax and Parsing

2006-01-24 Thread Ian Hickson
On Tue, 24 Jan 2006, Lachlan Hunt wrote: As for how to parse it, I'll use these test cases to demonstrate what I consider to be the most sane way to handle comments. (Assume EOF at the end of each one) Test Case | Comment Content | Output

Re: [whatwg] Comment Syntax and Parsing

2006-01-24 Thread Lachlan Hunt
Ian Hickson wrote: On Tue, 24 Jan 2006, Lachlan Hunt wrote: PA!- !--SS -- | - ! | PASS -- Comment should be - !-- IMHO. It's still a bogus comment (in HTML5 nomenclature), the -- part is irrelevant. Ok, so if a comment only starts with '!' then it ends at

Re: [whatwg] Comment Syntax and Parsing

2006-01-24 Thread Ian Hickson
On Wed, 25 Jan 2006, Lachlan Hunt wrote: Ian Hickson wrote: On Tue, 24 Jan 2006, Lachlan Hunt wrote: PA!- !--SS -- | - ! | PASS -- Comment should be - !-- IMHO. It's still a bogus comment (in HTML5 nomenclature), the -- part is irrelevant. Ok, so

Re: [whatwg] Comment Syntax and Parsing

2006-01-24 Thread Lachlan Hunt
Ian Hickson wrote: On Wed, 25 Jan 2006, Lachlan Hunt wrote: Ian Hickson wrote: On Tue, 24 Jan 2006, Lachlan Hunt wrote: PA!-- FAIL -- SS | FAIL| PASS Disagree. The terminator should be --, not -- S* . I don't see any good reason to have -- S* . I was working

Re: [whatwg] Comment Syntax and Parsing

2006-01-24 Thread Lachlan Hunt
Ian Hickson wrote: On Wed, 25 Jan 2006, Lachlan Hunt wrote: I tested the following in the live dom viewer using Firefox 1.5.0.1 Win and Mac, Opera 8.5/Mac, Opera 9 Win and Mac, Safari 2.0.3, IE6, OmniWeb 5.1.2 and iCab 3.0.1. !DOCTYPE html PA!-- FAIL -- SS This triggers SGML comment

Re: [whatwg] Comment Syntax and Parsing

2006-01-24 Thread Ian Hickson
On Wed, 25 Jan 2006, Lachlan Hunt wrote: Ian Hickson wrote: On Wed, 25 Jan 2006, Lachlan Hunt wrote: I tested the following in the live dom viewer using Firefox 1.5.0.1 Win and Mac, Opera 8.5/Mac, Opera 9 Win and Mac, Safari 2.0.3, IE6, OmniWeb 5.1.2 and iCab 3.0.1. !DOCTYPE

Re: [whatwg] Comment Syntax and Parsing

2006-01-24 Thread Anne van Kesteren
Quoting Lachlan Hunt [EMAIL PROTECTED]: This entire discussion started from the developers of all the browsers who implemented the SGML comment mode coming to me and telling me I was stupid for even suggesting that this is how comments should be parsed. The whole point of all this is to

Re: [whatwg] Comment Syntax and Parsing

2006-01-24 Thread HÃ¥kon Wium Lie
Also sprach Ian Hickson: This triggers SGML comment parsing mode (which you don't want to be testing) in a number of browsers. Why? The closer we can define the behaviour to be compatible with existing standards mode behaviours, the better it will be for backwards

Re: [whatwg] Comment Syntax and Parsing

2006-01-23 Thread Henri Sivonen
On Jan 23, 2006, at 05:23, Ian Hickson wrote: Probably the same as XML. Or maybe just !-- followed by zero or more characters other than U+, followed by --. Of those two choices, I prefer the former. I don't like the idea of expanding the set of conforming comments, because I think

Re: [whatwg] Comment Syntax and Parsing

2006-01-23 Thread Anne van Kesteren
Quoting Henri Sivonen [EMAIL PROTECTED]: I think allowing paired double hyphens with whitespace in between and allowing whitespace between the ending -- and would make sense. This would improve the source-level upgradeability of valid HTML 4 to conforming HTML 5. However, it would have the

Re: [whatwg] Comment Syntax and Parsing

2006-01-23 Thread Ian Hickson
On Mon, 23 Jan 2006, Lachlan Hunt wrote: Well that depends on the implementation and how SGML defines that such erroneous comments be handled. Indeed, there is that too. Whatever behaviour we require will be, to some extent, new behaviour. (Without a copy of IS0O-8879 handy, it's

Re: [whatwg] Comment Syntax and Parsing

2006-01-23 Thread Henri Sivonen
On Jan 23, 2006, at 11:39, Anne van Kesteren wrote: I guess the XML style is the simplest thing that could work. :-/ You are talking about conformance, but what do you want the parser to do? I talked about conformance, because I'd prefer document conformance be defined in such a way

Re: [whatwg] Comment Syntax and Parsing

2006-01-22 Thread Ian Hickson
On Mon, 23 Jan 2006, Lachlan Hunt wrote: Well, for what it's worth, I still don't think you were being stupid, I think you were right all along and had this been implemented by more than just Mozilla 7 years ago, the result may have been different. Authors find the -- thing unbelievably

Re: [whatwg] Comment Syntax and Parsing

2006-01-22 Thread Lachlan Hunt
Ian Hickson wrote: On Mon, 23 Jan 2006, Lachlan Hunt wrote: Well, for what it's worth, I still don't think you were being stupid, I think you were right all along and had this been implemented by more than just Mozilla 7 years ago, the result may have been different. Authors find the -- thing