Re: svn commit: r523920 - /incubator/wicket/branches/wicket-1.x/jdk-1.4/wicket/src/main/java/wicket/Component.java

2007-03-30 Thread Eelco Hillenius
It seemed a bit odd to me to punish our users with multiple calls because of something we didn't design well in the first place. Typical case of where we should have provided an empty template method. It would have my preference to fix that rather than doing the isEnabled call twice. Eelco On

Bean properties

2007-03-30 Thread Petr Sakar
Can be of some use for wicket ? http://www.theserverside.com/news/thread.tss?thread_id=44804 https://bean-properties.dev.java.net/ saki

Re: Bean properties

2007-03-30 Thread Erik van Oosten
Petr, In what way do you think it might be useful? Personally, I think that interoperability between bean-properties and existing code would be more cumbersome then staying with getters/setters. Regards, Erik. Petr Sakar wrote: Can be of some use for wicket ?

Re: [proposal] message to ipmc to ratify the release

2007-03-30 Thread Martijn Dashorst
Given that the US is sound asleep (at least I hope), I'll post now. All continents had their share of time to review and no serious concerns were raised. Martijn On 3/29/07, Martijn Dashorst [EMAIL PROTECTED] wrote: Tried that but couldn't find the link. Thx... I'll update the link. Martijn

Re: svn commit: r523920 - /incubator/wicket/branches/wicket-1.x/jdk-1.4/wicket/src/main/java/wicket/Component.java

2007-03-30 Thread Eelco Hillenius
On 3/30/07, Igor Vaynberg [EMAIL PROTECTED] wrote: well, however you fix it, imho the way it is now is broken. No that's reversing it. It was truly broken, as it wasn't called at all (in fact I committed the check on isEnabled just a couple of days ago). Your concern is that it still not may

Vote: A few small changes

2007-03-30 Thread Jonathan Locke
Please vote +1/-1 all or per-item if you disagree with some but not others: - make getRootModel(IModel) protected - i don't care much about this, it just seems like harmless functionality to inherit - make a public getRootModel() method that returns getRootModel(getModel()) - this one is

Re: Vote: A few small changes

2007-03-30 Thread Eelco Hillenius
Can we also take the items outlined here into account? https://issues.apache.org/jira/browse/WICKET-435 I'm pro those changes, but I'd like to look at the issues stated there before putting my vote. Eelco On 3/30/07, Jonathan Locke [EMAIL PROTECTED] wrote: Please vote +1/-1 all or per-item

Re: Vote: A few small changes

2007-03-30 Thread Jonathan Locke
i think you should propose a new merged vote then. ;-) Eelco Hillenius wrote: Can we also take the items outlined here into account? https://issues.apache.org/jira/browse/WICKET-435 I'm pro those changes, but I'd like to look at the issues stated there before putting my vote. Eelco

ajaxsubmitbutton and html button tag

2007-03-30 Thread Alexei Sokolov
Hello, At the moment it is not possible to attach AjaxSubmitButton to button HTML tag. Can somebody fix it? Alex

VOTE accept fix to WICKET-432 into 1.2.x

2007-03-30 Thread Igor Vaynberg
the subject says it all. i kinda jumped the gun on this one and committed already by mistake :( my appologies. if the vote doesnt pass i will revert it. -igor

Re: VOTE accept fix to WICKET-432 into 1.2.x

2007-03-30 Thread Igor Vaynberg
+1 -igor On 3/30/07, Igor Vaynberg [EMAIL PROTECTED] wrote: the subject says it all. i kinda jumped the gun on this one and committed already by mistake :( my appologies. if the vote doesnt pass i will revert it. -igor

Re: ajaxsubmitbutton and html button tag

2007-03-30 Thread Igor Vaynberg
fixed in 1.x branch -igor On 3/30/07, Alexei Sokolov [EMAIL PROTECTED] wrote: Hello, At the moment it is not possible to attach AjaxSubmitButton to button HTML tag. Can somebody fix it? Alex