Re: Commits on 1.2.x?

2007-02-12 Thread Erik van Oosten
Hi, Is there a JIRA issue already? I released a Wicket app based on a pre-1.2.5 release 2 weeks ago. I would like to know whether we need to create an update after 1.2.6 is out. Regards, Erik. Johan Compagner wrote: Yesterday i just fixed the AccessStackPageMap in 1.3 (that is the one

Re: Commits on 1.2.x?

2007-02-11 Thread Johan Compagner
Yesterday i just fixed the AccessStackPageMap in 1.3 (that is the one used in 1.2) there is a bug in it that it leaks pages into the session under specific circumstances so maybe a 1.2.6? johan On 2/10/07, Eelco Hillenius [EMAIL PROTECTED] wrote: Sure. So we have this release, which is

Re: Commits on 1.2.x?

2007-02-09 Thread Eelco Hillenius
On 2/9/07, Martijn Dashorst [EMAIL PROTECTED] wrote: Why are there commits on 1.2.x *after* the 1.2.5 release has happened? We wouldn't maintain 1.2.x for things other than showstopper bugs which need a vote to be held. Ugh, I forgot (honestly!) about voting. Re *after* the release... well, I

Re: Commits on 1.2.x?

2007-02-09 Thread Igor Vaynberg
at this point lets just rebuild 1.2.5 (since there were problems with it anyways?) and call it a day. whats done is done. -igor On 2/9/07, Eelco Hillenius [EMAIL PROTECTED] wrote: On 2/9/07, Martijn Dashorst [EMAIL PROTECTED] wrote: Why are there commits on 1.2.x *after* the 1.2.5 release

Re: Commits on 1.2.x?

2007-02-09 Thread Martijn Dashorst
, Martijn Dashorst [EMAIL PROTECTED] wrote: Why are there commits on 1.2.x *after* the 1.2.5 release has happened? We wouldn't maintain 1.2.x for things other than showstopper bugs which need a vote to be held. Ugh, I forgot (honestly!) about voting. Re *after* the release... well, I thought

Commits on 1.2.x?

2007-02-09 Thread Martijn Dashorst
Why are there commits on 1.2.x *after* the 1.2.5 release has happened? We wouldn't maintain 1.2.x for things other than showstopper bugs which need a vote to be held. Now we have to release 1.2.6! Martijn -- Vote for Wicket at the http://www.thebeststuffintheworld.com/vote_for/wicket Wicket

Re: Commits on 1.2.x?

2007-02-09 Thread Eelco Hillenius
On 2/9/07, Martijn Dashorst [EMAIL PROTECTED] wrote: Then why didn't you flag the 1.2.5 as non-ok? The release was fine, and having bugs worth applying doesn't mean we can't make a release. I fixed those bugs today. I *JUST* fucking uploaded the release to sf.net. If this was communicated,

Re: Commits on 1.2.x?

2007-02-09 Thread Martijn Dashorst
I'm not angry at you personally, just at the situation. Martijn On 2/10/07, Eelco Hillenius [EMAIL PROTECTED] wrote: On 2/9/07, Martijn Dashorst [EMAIL PROTECTED] wrote: Then why didn't you flag the 1.2.5 as non-ok? The release was fine, and having bugs worth applying doesn't mean we can't

Re: Commits on 1.2.x?

2007-02-09 Thread Eelco Hillenius
Sure. So we have this release, which is great and let's leave it with that. We can make a new 1.2.x release in a few months if there is demand for it and if there are more bugs that have to go into it. Meanwhile if people run into issues they can find out they were reported and fixed and build