Re: Last change required for reloading classes

2006-12-21 Thread Jean-Baptiste Quenot
* Igor Vaynberg: if it doesnt work 100% of the time then imho it shouldnt be in the core, i think it should go into a separate module or extensions. Could you please decide where this feature goes and close https://issues.apache.org/jira/browse/WICKET-126 So that it is included in

Re: Last change required for reloading classes

2006-12-21 Thread Erik van Oosten
The ssl certificate of Jira has expired :) Erik. Jean-Baptiste Quenot wrote: Could you please decide where this feature goes and close https://issues.apache.org/jira/browse/WICKET-126 -- Erik van Oosten http://day-to-day-stuff.blogspot.com/

Re: Last change required for reloading classes

2006-12-13 Thread Jean-Baptiste Quenot
* Filippo Diotalevi: BTW, is the reloading filter portable to Wicket-2.0? do you see any problem in using it with w-2.0? Yes the patch is compatible with wicket trunk. Nothing prevents to do the porting AFAICT. -- Jean-Baptiste Quenot aka John Banana Qwerty http://caraldi.com/jbq/

Last change required for reloading classes

2006-12-11 Thread Jean-Baptiste Quenot
Hi, The code to reload classes is already in Wicket branch 1.x, but there's a (hopefully) last fix to apply. Could one of you please have a look at: https://issues.apache.org/jira/secure/attachment/12346428/20061205-wicket-1.x-ReloadingClassLoader * Use ArrayList instead of HashSet for the

Re: Last change required for reloading classes

2006-12-11 Thread Eelco Hillenius
Sure, done. The issue is still open. I'm still not convinced we should ship the reloading filter tbh. As it only works with quite a few ifs and buts, I'd rather see the reloading filter (and class locator) to be part of wicket-extensions or maybe as a WIKI article or such. Though I'm fine with

Re: Last change required for reloading classes

2006-12-11 Thread Jean-Baptiste Quenot
* Eelco Hillenius: As it only works with quite a few ifs and buts, It works great with the wicket-examples and all Wicket applications, but it's true that things get more complicated when using a component manager like Spring, because then you need to have proper separation

Re: Last change required for reloading classes

2006-12-11 Thread Filippo Diotalevi
On 12/11/06, Eelco Hillenius [EMAIL PROTECTED] wrote: Sure, done. The issue is still open. I'm still not convinced we should ship the reloading filter tbh. As it only works with quite a few ifs and buts, I'd rather see the reloading filter (and class locator) to be part of wicket-extensions or

Re: Last change required for reloading classes

2006-12-11 Thread Igor Vaynberg
if it doesnt work 100% of the time then imho it shouldnt be in the core, i think it should go into a separate module or extensions. -igor On 12/11/06, Eelco Hillenius [EMAIL PROTECTED] wrote: Sure, done. The issue is still open. I'm still not convinced we should ship the reloading filter

Re: Last change required for reloading classes

2006-12-11 Thread Eelco Hillenius
BTW, is the reloading filter portable to Wicket-2.0? do you see any problem in using it with w-2.0? I first wanted the implementation stable enough before we port the changes to 2.0. There need to be a couple of tweaks before that filter can be used, but not big things. Eelco