AnneT closed subtask T309239: Add Field component to Codex as
Resolved.
TASK DETAIL
https://phabricator.wikimedia.org/T307319
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: DAbad, AnneT
Cc: Sarai-WMDE, AOdit_WMF, elal, Michael, Abbe98, ItamarWMDE
AnneT closed subtask T309246: Label: Add Label component to Codex as
Resolved.
TASK DETAIL
https://phabricator.wikimedia.org/T307319
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: DAbad, AnneT
Cc: Sarai-WMDE, AOdit_WMF, elal, Michael, Abbe98
AnneT added a subscriber: Jdlrobson.
AnneT added a comment.
Hi @noarave! I think this will require a change in that Vector code that you
linked, so that it first checks if `highlightQuery` is set in the
`VectorWvuiSearchOptions` config variable. If so, it should respect that value
AnneT changed the status of subtask T309246: Label: Add Label component or
composable to Codex from Open to In Progress.
TASK DETAIL
https://phabricator.wikimedia.org/T307319
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: DAbad, AnneT
Cc: Sarai
AnneT changed the status of subtask T309239: Add Field component to Codex from
Open to In Progress.
TASK DETAIL
https://phabricator.wikimedia.org/T307319
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: DAbad, AnneT
Cc: Sarai-WMDE, AOdit_WMF, elal
AnneT added a comment.
Search query highlighting behavior can be turned off via the `highlightQuery`
prop, which is a boolean prop of both CdxTypeaheadSearch and the Vector search
app. Currently, in Vector, `highlightQuery` is set to `true` or `false` based
on the UI language and whether
AnneT moved this task from Design Sign-Off to QTE Sign-off on the
Design-Systems-Team (Design-Systems-Sprint) board.
AnneT reassigned this task from Volker_E to EUdoh-WMF.
TASK DETAIL
https://phabricator.wikimedia.org/T306932
WORKBOARD
https://phabricator.wikimedia.org/project/board/5859
AnneT added a comment.
@Lucas_Werkmeister_WMDE FYI we've just merged the new release of Codex into
core, which includes your change
<https://gerrit.wikimedia.org/r/c/design/codex/+/854049> and will ride the
train next week!
TASK DETAIL
https://phabricator.wikimedia.org/T317682
AnneT added a comment.
@Lucas_Werkmeister_WMDE our next scheduled Codex release is Tuesday, November
22nd, so it would ride the train the following week. Is that acceptable, or is
this needed sooner?
TASK DETAIL
https://phabricator.wikimedia.org/T317682
EMAIL PREFERENCES
https
AnneT added a comment.
@Volker_E can we move forward with this patch
<https://gerrit.wikimedia.org/r/c/design/codex/+/850261> and accept that we
will not make a similar change in OOUI, per the previous comments?
TASK DETAIL
https://phabricator.wikimedia.org/T306932
EMAIL PREFE
AnneT added a comment.
Could we accept such a slight divergence between Codex and OOUI? I would hate
to hold back Codex because of the old system, and I'm not convinced that both
versions must be completely in sync, especially when it comes to a single-pixel
difference.
TASK DETAIL
https
AnneT added a comment.
cc @Sarai-WMDE on the message above ^ if you have a second, could you please
confirm if this is the correct style now, especially for TypeaheadSearch? I had
thought there was supposed to be a -1px margin-top on the menu, but it seems
like that's not indicated
AnneT added a comment.
@EUdoh-WMF @bmartinezcalvo I've opened a patch that I think should resolve
all of those things, although the bug that happens in Chrome at 175% zoom is
still a bit of an issue. Check it out here
<https://850261--wikimedia-codex.netlify.app/components/demos/menu.h
AnneT updated the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T306932
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Sarai-WMDE, AnneT
Cc: EUdoh-WMF, NHillard-WMF, Catrope, DAbad, ldelench_wmf, Sarai-WMDE,
Erdinc_Ciftci_WMDE
AnneT added a subscriber: EUdoh-WMF.
AnneT added a comment.
@Sarai-WMDE and @EUdoh-WMF, you can test this new functionality via the "menu
with scroll enabled" demo
<https://doc.wikimedia.org/codex/main/components/demos/menu.html#menu-with-scrolling-enabled>
on the docs site
AnneT added a comment.
In T306932#8256431 <https://phabricator.wikimedia.org/T306932#8256431>,
@Sarai-WMDE wrote:
> Tiniest nitpick about the demo, but the width of the input to enter the
number of visible items should be increased, so it can take two digits:
> On the othe
AnneT moved this task from Code Review to Design Sign-Off on the
Design-Systems-Team (Design-Systems-Sprint) board.
AnneT assigned this task to Sarai-WMDE.
TASK DETAIL
https://phabricator.wikimedia.org/T306932
WORKBOARD
https://phabricator.wikimedia.org/project/board/5859/
EMAIL
AnneT added a comment.
> tracking these as a submit event instead of a click also seems a bug
+1, thanks for weighing in!
TASK DETAIL
https://phabricator.wikimedia.org/T317682
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: AnneT
Cc: dcau
AnneT added a comment.
We could potentially fix this by updating the `onSubmit()` handler in
CdxTypeaheadSearch to check if there is a currently highlighted item and, if
so, do the following:
- `preventDefault()` on the submit event
- run the `onSearchResultClick()` method to emit
AnneT added subscribers: Jdlrobson, AnneT.
AnneT added a comment.
@Jdlrobson Could you provide some background on why the URL for a search
result goes through Special:Search, rather than linking directly to the page?
If we could make linking directly to the page the default behavior
AnneT moved this task from Ready for Design to In Development on the
Design-Systems-Team (Design-Systems-Sprint) board.
AnneT changed the task status from "Open" to "In Progress".
TASK DETAIL
https://phabricator.wikimedia.org/T306932
WORKBOARD
https://phabricator.wikimed
AnneT removed AnneT as the assignee of this task.
TASK DETAIL
https://phabricator.wikimedia.org/T305091
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: AnneT
Cc: Ladsgroup, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Catrope, Mooeypoo,
bmartinezcalvo
AnneT updated the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T305091
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: AnneT
Cc: Ladsgroup, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Catrope, Mooeypoo,
bmartinezcalvo, Sarai-WMDE
AnneT added a comment.
Thanks, everyone, for your thoughtful comments, examples, and suggestions!
I think we should move forward with keeping all menu items justified
according to the interface direction, given the feedback here. We can always
reevaluate if we get more feedback from RTL
AnneT added a comment.
Thank you, @Sarai-WMDE, for your thorough response! It's really helpful to
learn from your experience with design tokens in WiKit so far.
I have some remaining questions/thoughts about one topic, but everything else
seems clear to me.
> This all sounds ab
AnneT added a comment.
Another practical question: when does a variable become a design token? This
is the process I've been following:
1. Is it a simple keyword, like `display: flex`? If so, probably don't use a
token, unless it's something that gets repeated a lot like the value
AnneT added subscribers: Tonina_Zhelyazkova_WMDE, Catrope, egardner.
AnneT added a comment.
Some thoughts post-Designer summit:
Designer-developer handoff
--
This could use stronger definition. Is the designer creating tokens for some
values in Figma
AnneT added a comment.
Quick comment that's probably obvious, but from a developer standpoint, one
thing I would prioritize is ease of use/visibility during development. Two
concerns:
- In MediaWiki extensions, we use a pretty manual process to include and
update Wikimedia UI base
AnneT renamed this task from "Evaluate (and implement) variables aka tokens
abstraction" to "Evaluate variables aka tokens abstraction".
TASK DETAIL
https://phabricator.wikimedia.org/T266688
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailprefer
AnneT added a parent task: T286951: Decide on CSS Architecture for shared
component library.
TASK DETAIL
https://phabricator.wikimedia.org/T266688
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: AnneT
Cc: Jakob_WMDE, Michael, AnneT, Pginer-WMF
AnneT added a comment.
Thanks for your review, @Etonkovidova!
(1) I think this task was created before the Other tab was a thing. I figured
since it's a media tab, the license filter applies, but we should confirm this
(@Ramsey-WMF?)
(2) A patch to fix this was merged last week
AnneT added a comment.
I've tested the UI patch and confirmed it's working when pointing to
production API endpoints. It's now ready for code review.
TASK DETAIL
https://phabricator.wikimedia.org/T257938
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences
AnneT added a comment.
Also wondering if we've missed some...I'm testing my patch locally and an
image with the license Creative Commons Attribution-Share Alike 3.0 it
<https://creativecommons.org/licenses/by-sa/3.0/it/deed.en> is popping up under
"other" instead of share w
AnneT removed Cparle as the assignee of this task.
AnneT added a subscriber: Cparle.
AnneT added a comment.
I've updated the UI patch but will keep it labeled WIP until the license
mapping config is in place.
TASK DETAIL
https://phabricator.wikimedia.org/T257938
EMAIL PREFERENCES
https
AnneT added a comment.
@matthiasmullie any thoughts on getting around the search string character
limit here? Now that I've rebased this patch onto the one that swaps out the
search modules, I'm hitting the default limit of 300 characters for the cc-by
and cc-by-sa filter options
AnneT claimed this task.
TASK DETAIL
https://phabricator.wikimedia.org/T257938
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: AnneT
Cc: Multichill, EBernhardson, matthiasmullie, mwilliams, Aklapper, CBogen,
Akuckartz, darthmon_wmde, Nandana, JKSTNK
AnneT updated the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T257938
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: AnneT
Cc: Multichill, EBernhardson, matthiasmullie, mwilliams, Aklapper, CBogen,
Akuckartz, darthmon_wmde
AnneT added a parent task: T256160: [L] Additional Filters for Media Search.
TASK DETAIL
https://phabricator.wikimedia.org/T257938
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: AnneT
Cc: Multichill, EBernhardson, matthiasmullie, mwilliams, Aklapper
AnneT added a comment.
Oops, the patch I referred to isn't on production yet. EntityLookupElement
was refactored to EntityInputWidget, which is live on prod at the moment with
the failing `onMousedown` method.
Stephen suggested this might be an issue related to the way events
AnneT added a comment.
Hey @Niedzielski, that component was refactored into
`EntityAutocompleteInputWidget` in a later patch, see here
<https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/WikibaseMediaInfo/+/refs/heads/master/resources/statements/inp
AnneT updated the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T239163
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: AnneT
Cc: Jheald, Lucas_Werkmeister_WMDE, WMDE-leszek, Aklapper, PDrouin-WMF,
Multichill, egardner
AnneT updated the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T239163
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: AnneT
Cc: Jheald, Lucas_Werkmeister_WMDE, WMDE-leszek, Aklapper, PDrouin-WMF,
Multichill, egardner
42 matches
Mail list logo
