[Wikidata-bugs] [Maniphest] [Retitled] T125434: Research on right to left languages layout in ArticlePlaceholder

Amire80 renamed this task from "Research on right to left languages layout" to "Research on right to left languages layout in ArticlePlaceholder". TASK DETAILhttps://phabricator.wikimedia.org/T125434EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucie,

[Wikidata-bugs] [Maniphest] [Closed] T187855: Undefined index in WikibaseClient $this->getRepositoryDefinitions()->getDatabaseNames()['']

Tgr closed this task as "Resolved".Tgr claimed this task.Tgr added a comment. Fixed by the vagrant patch, although it could use the eye of someone who actually knows how Wikibase config variables are used.TASK DETAILhttps://phabricator.wikimedia.org/T187855EMAIL

[Wikidata-bugs] [Maniphest] [Updated] T188276: Update StructureTest to find non-fully qualified PHPUnit\Framework\TestCase

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)). TASK DETAILhttps://phabricator.wikimedia.org/T188276EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: ReleaseTaggerBotCc: Umherirrender, Aklapper, thiemowmde,

[Wikidata-bugs] [Maniphest] [Commented On] T188276: Update StructureTest to find non-fully qualified PHPUnit\Framework\TestCase

gerritbot added a comment. Change 414717 merged by jenkins-bot: [mediawiki/core@master] Accept non-fully qualified TestCase in StructureTest https://gerrit.wikimedia.org/r/414717TASK DETAILhttps://phabricator.wikimedia.org/T188276EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T187855: Undefined index in WikibaseClient $this->getRepositoryDefinitions()->getDatabaseNames()['']

gerritbot added a comment. Change 414635 merged by jenkins-bot: [mediawiki/vagrant@master] Unbreak wikidata role https://gerrit.wikimedia.org/r/414635TASK DETAILhttps://phabricator.wikimedia.org/T187855EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:

[Wikidata-bugs] [Maniphest] [Closed] T185984: Migrate WDQS code to use Instant to store timestamps

Smalyshev closed this task as "Resolved".Smalyshev claimed this task. TASK DETAILhttps://phabricator.wikimedia.org/T185984EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: gerritbot, Aklapper, Gehel, Smalyshev, Giuliamocci, Adrian1985, Cpaulf30,

[Wikidata-bugs] [Maniphest] [Updated] T181549: [epic] Subcategory searching

Smalyshev added a subtask: T188350: Produce search error if deepcat search returns too many categories. TASK DETAILhttps://phabricator.wikimedia.org/T181549EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: Aklapper, Addshore, Lea_WMDE, Smalyshev,

[Wikidata-bugs] [Maniphest] [Closed] T165982: Investigate using blazegraph for deep category searching / returning of results

Smalyshev closed this task as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T165982EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: Lea_Lacroix_WMDE, Abit, Ramsey-WMF, Bmueller, PokestarFan, gerritbot, schana, Tgr, Multichill, Deskana,

[Wikidata-bugs] [Maniphest] [Unblock] T181549: [epic] Subcategory searching

Smalyshev closed subtask T165982: Investigate using blazegraph for deep category searching / returning of results as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T181549EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: Aklapper,

[Wikidata-bugs] [Maniphest] [Commented On] T188345: Wireframe Multilingual Captions on File Page

PDrouin-WMF added a comment. Clickable wireframe prototype for performing two user tasks: add an initial caption (in French) and add a second caption (in Spanish): https://wikimedia.invisionapp.com/share/KXG1ZPY3VFZ#/281285446_13_-_PublishTASK DETAILhttps://phabricator.wikimedia.org/T188345EMAIL

[Wikidata-bugs] [Maniphest] [Created] T188345: Wireframe Multilingual Captions on File Page

PDrouin-WMF created this task.PDrouin-WMF added projects: Multimedia-Team-Working-Board, Structured-Data-Commons.Herald added a subscriber: Aklapper.Herald added projects: Wikidata, Multimedia. TASK DESCRIPTIONMake a clickable wireframe prototype showing how to add multilingual captions to a File

[Wikidata-bugs] [Maniphest] [Updated] T168222: Editing wikidata with paws/pywikibot fails when user is not registered for commons

zhuyifei1999 added a comment. This should be fixed by T94885 AFAICT.TASK DETAILhttps://phabricator.wikimedia.org/T168222EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: zhuyifei1999Cc: zhuyifei1999, Chicocvenancio, Knuthuehne, Lahi, aborrero, Gq86, R96340,

[Wikidata-bugs] [Maniphest] [Commented On] T184812: Enable constraint result caching on Wikidata

Ladsgroup added a comment. Sent to ops-lTASK DETAILhttps://phabricator.wikimedia.org/T184812EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, LadsgroupCc: Bawolff, greg, Ladsgroup, jcrespo, Marostegui, TerraCodes, Stashbot,

[Wikidata-bugs] [Maniphest] [Commented On] T184812: Enable constraint result caching on Wikidata

Ladsgroup added a comment. Well, it seems wikitech is completely down now.TASK DETAILhttps://phabricator.wikimedia.org/T184812EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, LadsgroupCc: Bawolff, greg, Ladsgroup, jcrespo, Marostegui,

[Wikidata-bugs] [Maniphest] [Commented On] T168222: Editing wikidata with paws/pywikibot fails when user is not registered for commons

Chicocvenancio added a comment. @Knuthuehne Sorry for moving it around the workboard without more context. I started writing here but never submitted. In order of importance, the information we need to start working on this is: Does it still happen? Is it exclusive to PAWS, as in, if we tried

[Wikidata-bugs] [Maniphest] [Commented On] T184812: Enable constraint result caching on Wikidata

Lucas_Werkmeister_WMDE added a comment. Wikitech is writable again, here’s the report: https://wikitech.wikimedia.org/wiki/Incident_documentation/20180226-WikibaseQualityConstraints I’ll ask @Ladsgroup to send out the email to ops@ tomorrow (AFAIK I don’t have the required permissions

[Wikidata-bugs] [Maniphest] [Edited] T188312: Don’t pass overly long entity ID lists to WikiPageEntityDataAccessor

Lucas_Werkmeister_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTIONThis was a possible suspected cause of the incident (see parent ticket or [incident documentation](https://wikitech.wikimedia.org/wiki/Incident_documentation/20180226-WikibaseQualityConstraints

[Wikidata-bugs] [Maniphest] [Edited] T188313: Fix safeguard for empty condition list in WikiPageEntityMetaDataLookup

]`?) Part of https://wikitech.wikimedia.org/wiki/Incident_documentation/20180226-WikibaseQualityConstraints.TASK DETAILhttps://phabricator.wikimedia.org/T188313EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE

[Wikidata-bugs] [Maniphest] [Edited] T188311: Don’t pass empty entity ID lists to WikiPageMetaDataAccessor

no point asking the `WikiPageMetaDataAccessor` for revision IDs in that case, at the risk of it issuing some empty query. Just short-circuit in `getLatestRevisionIds` instead. Part of https://wikitech.wikimedia.org/wiki/Incident_documentation/20180226-WikibaseQualityConstraints.TASK DETAILhttps

[Wikidata-bugs] [Maniphest] [Edited] T187438: Implement searching of multilingual captions on commons

Ramsey-WMF updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...This is the master ticket for the work [[ https://docs.google.com/presentation/d/1X2MUdw7CC05k7Syo34y8kfkFvjNuSYqv89GbkVuEgFQ/edit?ts=59c1af27=1#slide=id.g1fe9f2d8a8_0_0 | This is the User Story (saga) ]] for

[Wikidata-bugs] [Maniphest] [Commented On] T184812: Enable constraint result caching on Wikidata

Bawolff added a comment. Php considering "0" to be false strikes again!TASK DETAILhttps://phabricator.wikimedia.org/T184812EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, BawolffCc: Bawolff, greg, Ladsgroup, jcrespo, Marostegui,

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T168222: Editing wikidata with paws/pywikibot fails when user is not registered for commons

Knuthuehne added a subscriber: Chicocvenancio.Knuthuehne added a comment. @Chicocvenancio is there any more info that you need from my site?TASK DETAILhttps://phabricator.wikimedia.org/T168222EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KnuthuehneCc:

[Wikidata-bugs] [Maniphest] [Updated] T185697: mwext-phpunit-coverage-publish for WikibaseQualityExternalValidation fails

Legoktm added a comment. It's failing because of T185609: Invalid callback WikibaseQuality\ExternalValidation\WikibaseQualityExternalValidationHooks::onCreateSchema - which is an issue with the extension and needs to be fixed, regardless of the deployment state.TASK

[Wikidata-bugs] [Maniphest] [Updated] T185697: mwext-phpunit-coverage-publish for WikibaseQualityExternalValidation fails

gerritbot added a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T185697EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, greg, Lucas_Werkmeister_WMDE, Aklapper, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86,

[Wikidata-bugs] [Maniphest] [Commented On] T185697: mwext-phpunit-coverage-publish for WikibaseQualityExternalValidation fails

gerritbot added a comment. Change 414774 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [integration/config@master] Disable coverage builds for WBQEV https://gerrit.wikimedia.org/r/414774TASK DETAILhttps://phabricator.wikimedia.org/T185697EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T188293: Categories download is broken

Smalyshev added a comment. Could probably use SPARQL for monitoring: Minimal change date: https://query.wikidata.org/bigdata/namespace/categories/sparql?format=json=SELECT%20(min(?date)%20as%20?mindate)%20{%20?wiki%20schema:dateModified%20?date%20} Change dates for all wikis:

[Wikidata-bugs] [Maniphest] [Commented On] T174032: Make relevant API modules aware of MCR

Anomie added a comment. That name could work.TASK DETAILhttps://phabricator.wikimedia.org/T174032EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AnomieCc: gerritbot, Aklapper, daniel, Giuliamocci, Adrian1985, Cpaulf30, Lahi, PDrouin-WMF, Gq86, Baloch007,

[Wikidata-bugs] [Maniphest] [Closed] T188285: Running mvn on wikidata/query/rdf fails with: /bin/sh: 1: npm: not found

hashar closed this task as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T188285EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hasharCc: Smalyshev, Gehel, Aklapper, zeljkofilipin, MarcoAurelio, gerritbot, hashar, Giuliamocci, Adrian1985, Cpaulf30,

[Wikidata-bugs] [Maniphest] [Commented On] T184812: Enable constraint result caching on Wikidata

Lucas_Werkmeister_WMDE added a comment. I’ve started writing up an incident report, but I can’t currently save it since wikitech is read-only due to a database migration. If it’s not back to read-write by the time I leave the office, I’ll dump it in an Etherpad or something.TASK

[Wikidata-bugs] [Maniphest] [Commented On] T188285: Running mvn on wikidata/query/rdf fails with: /bin/sh: 1: npm: not found

gerritbot added a comment. Change 414772 merged by jenkins-bot: [integration/config@master] Migrate wikidata-query-rdf-maven job to Docker https://gerrit.wikimedia.org/r/414772TASK DETAILhttps://phabricator.wikimedia.org/T188285EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T188285: Running mvn on wikidata/query/rdf fails with: /bin/sh: 1: npm: not found

gerritbot added a comment. Change 414772 had a related patch set uploaded (by Hashar; owner: Hashar): [integration/config@master] Migrate wikidata-query-rdf-maven job to Docker https://gerrit.wikimedia.org/r/414772TASK DETAILhttps://phabricator.wikimedia.org/T188285EMAIL

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T188285: Running mvn on wikidata/query/rdf fails with: /bin/sh: 1: npm: not found

hashar added subscribers: Gehel, Smalyshev.hashar added a comment. I went for dinner and magically @Gehel and @Smalyshev reviewed the change \o/TASK DETAILhttps://phabricator.wikimedia.org/T188285EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hasharCc:

[Wikidata-bugs] [Maniphest] [Created] T188313: Fix safeguard for empty condition list in WikiPageEntityMetaDataLookup

Lucas_Werkmeister_WMDE created this task.Lucas_Werkmeister_WMDE added projects: Wikidata, Wikimedia-Incident.Herald added a subscriber: Aklapper. TASK DESCRIPTIONWikiPageEntityMetaDataLookup::getWhere has a special guard against an empty condition list for the query: if ( empty( $where ) ) {

[Wikidata-bugs] [Maniphest] [Created] T188312: Don’t pass overly long entity ID lists to WikiPageEntityDataAccessor

Lucas_Werkmeister_WMDE created this task.Lucas_Werkmeister_WMDE triaged this task as "High" priority.Lucas_Werkmeister_WMDE added projects: Wikidata, Wikibase-Quality-Constraints, Wikibase-Quality, Wikimedia-Incident.Herald added a subscriber: Aklapper. TASK DESCRIPTIONThis was a possible

[Wikidata-bugs] [Maniphest] [Created] T188311: Don’t pass empty entity ID lists to WikiPageMetaDataAccessor

Lucas_Werkmeister_WMDE created this task.Lucas_Werkmeister_WMDE triaged this task as "High" priority.Lucas_Werkmeister_WMDE added projects: Wikidata, Wikibase-Quality-Constraints, Wikibase-Quality, Wikimedia-Incident.Herald added a subscriber: Aklapper. TASK DESCRIPTIONIf the list of depended

[Wikidata-bugs] [Maniphest] [Commented On] T188276: Update StructureTest to find non-fully qualified PHPUnit\Framework\TestCase

Umherirrender added a comment. DumpTestCase is also namespaced since https://gerrit.wikimedia.org/r/#/c/404512/ The backslash could be moved before the regex to fix all that casesTASK DETAILhttps://phabricator.wikimedia.org/T188276EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T188293: Categories download is broken

gerritbot added a comment. Change 414756 merged by jenkins-bot: [wikidata/query/rdf@master] Update URL and make curl fail if URL is wrong https://gerrit.wikimedia.org/r/414756TASK DETAILhttps://phabricator.wikimedia.org/T188293EMAIL

[Wikidata-bugs] [Maniphest] [Unblock] T183927: Add parameter to only get violations from wbcheckconstraints (days: 1)

Lucas_Werkmeister_WMDE closed subtask T184937: Change wbcheckconstraints’ status parameter’s default value to cacheable value as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T183927EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:

[Wikidata-bugs] [Maniphest] [Closed] T184937: Change wbcheckconstraints’ status parameter’s default value to cacheable value

Lucas_Werkmeister_WMDE closed this task as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T184937EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Stashbot, gerritbot, Liuxinyu970226, Ladsgroup, Lucas_Werkmeister_WMDE,

[Wikidata-bugs] [Maniphest] [Commented On] T188293: Categories download is broken

Smalyshev added a comment. Looks like there's no config that specifies dblists path, so we will have to keep hardcoding it.TASK DETAILhttps://phabricator.wikimedia.org/T188293EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: gerritbot, Aklapper,

[Wikidata-bugs] [Maniphest] [Edited] T188293: Categories download is broken

Smalyshev updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...[x] Try to figure out if we can find the correct URL from puppet config instead of hardcoding it. TASK DETAILhttps://phabricator.wikimedia.org/T188293EMAIL

[Wikidata-bugs] [Maniphest] [Edited] T188293: Categories download is broken

Smalyshev updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...[x] Fix the scripts so that they can deal properly with bad URL...TASK DETAILhttps://phabricator.wikimedia.org/T188293EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:

[Wikidata-bugs] [Maniphest] [Edited] T188293: Categories download is broken

Smalyshev updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...[x] Fix the scripts to use new URL and re-index...TASK DETAILhttps://phabricator.wikimedia.org/T188293EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: gerritbot,

[Wikidata-bugs] [Maniphest] [Commented On] T165982: Investigate using blazegraph for deep category searching / returning of results

Smalyshev added a comment. @Lea_WMDE seems to work now, 569 results.TASK DETAILhttps://phabricator.wikimedia.org/T165982EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: Lea_Lacroix_WMDE, Abit, Ramsey-WMF, Bmueller, PokestarFan, gerritbot, schana,

[Wikidata-bugs] [Maniphest] [Updated] T188293: Categories download is broken

gerritbot added a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T188293EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Smalyshev, gerritbotCc: gerritbot, Aklapper, Gehel, Smalyshev, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86,

[Wikidata-bugs] [Maniphest] [Edited] T188293: Categories download is broken

Smalyshev updated the task description. (Show Details) CHANGES TO TASK DESCRIPTIONRight now categories download scripts for WDQS are broken because https://noc.wikimedia.org/conf/categories-rdf.dblist has been moved to https://noc.wikimedia.org/conf/dblists/categories-rdf.dblist. Things to fix

[Wikidata-bugs] [Maniphest] [Commented On] T188293: Categories download is broken

gerritbot added a comment. Change 414756 had a related patch set uploaded (by Smalyshev; owner: Smalyshev): [wikidata/query/rdf@master] Update URL and make curl fail if URL is wrong https://gerrit.wikimedia.org/r/414756TASK DETAILhttps://phabricator.wikimedia.org/T188293EMAIL

[Wikidata-bugs] [Maniphest] [Updated] T184937: Change wbcheckconstraints’ status parameter’s default value to cacheable value

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)); removed MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)). TASK DETAILhttps://phabricator.wikimedia.org/T184937EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T188285: Running mvn on wikidata/query/rdf fails with: /bin/sh: 1: npm: not found

gerritbot added a comment. Change 414731 merged by jenkins-bot: [wikidata/query/rdf@master] Set npm version for frontend-maven-plugin https://gerrit.wikimedia.org/r/414731TASK DETAILhttps://phabricator.wikimedia.org/T188285EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T184937: Change wbcheckconstraints’ status parameter’s default value to cacheable value

Stashbot added a comment. Mentioned in SAL (#wikimedia-operations) [2018-02-26T19:46:39Z] Synchronized php-1.31.0-wmf.22/extensions/WikibaseQualityConstraints/: T184937 (duration: 01m 03s)TASK DETAILhttps://phabricator.wikimedia.org/T184937EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T184937: Change wbcheckconstraints’ status parameter’s default value to cacheable value

gerritbot added a comment. Change 414714 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@wmf/1.31.0-wmf.22] Change status parameter default to cacheable value https://gerrit.wikimedia.org/r/414714TASK DETAILhttps://phabricator.wikimedia.org/T184937EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T179879: Provide a 5-minute timeout in WDQS for trusted users using OAuth

doctaxon added a comment. Maybe 120s limit? I think, we have to test it, but how?TASK DETAILhttps://phabricator.wikimedia.org/T179879EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: doctaxonCc: chasemp, Lydia_Pintscher, Magnus, MichaelSchoenitzer_WMDE,

[Wikidata-bugs] [Maniphest] [Updated] T184812: Enable constraint result caching on Wikidata

Ladsgroup removed a project: Security.Ladsgroup changed the visibility from "Custom Policy" to "Public (No Login Required)".Herald added a project: Security. TASK DETAILhttps://phabricator.wikimedia.org/T184812EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:

[Wikidata-bugs] [Maniphest] [Updated] T179879: Provide a 5-minute timeout in WDQS for trusted users using OAuth

Smalyshev added a comment. 30 seconds is an arbitrary limit that was set a while ago. Ah yes, also minor point, but we've been on 60s limit for a year now. Once T178492: Create a more controlled WDQS cluster is done, and production services use that endpoint, we could talk about bumping the limit

[Wikidata-bugs] [Maniphest] [Commented On] T184812: Enable constraint result caching on Wikidata

Ladsgroup added a comment. In T184812#4002850, @jcrespo wrote: SELECT $startOpts $vars $from $useIndex $ignoreIndex " . "WHERE $conds $preLimitTail"; That looks like a recipe for an sql injection, how did this pass security review? Why this is public?TASK

[Wikidata-bugs] [Maniphest] [Updated] T184812: Enable constraint result caching on Wikidata

jcrespo removed a project: Security.jcrespo added a comment. ok, sorry, for a second I thought you were executing that- on that code is guaranteed to be sanitized.TASK DETAILhttps://phabricator.wikimedia.org/T184812EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T184812: Enable constraint result caching on Wikidata

Lucas_Werkmeister_WMDE added a comment. That looks like a recipe for an sql injection, how did this pass security review? I should’ve been clearer – this is in Database::selectSQLText. That’s the one place where code like this would be expected, right? (Assuming that all the variables have been

[Wikidata-bugs] [Maniphest] [Updated] T184812: Enable constraint result caching on Wikidata

jcrespo added a project: Security.jcrespo added a comment. SELECT $startOpts $vars $from $useIndex $ignoreIndex " . "WHERE $conds $preLimitTail"; That looks like a recipe for an sql injection, how did this pass security review?TASK DETAILhttps://phabricator.wikimedia.org/T184812EMAIL

[Wikidata-bugs] [Maniphest] [Lowered Priority] T184812: Enable constraint result caching on Wikidata

Lucas_Werkmeister_WMDE lowered the priority of this task from "Unbreak Now!" to "High". TASK DETAILhttps://phabricator.wikimedia.org/T184812EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: greg, Ladsgroup, jcrespo, Marostegui,

[Wikidata-bugs] [Maniphest] [Commented On] T184812: Enable constraint result caching on Wikidata

Lucas_Werkmeister_WMDE added a comment. Okay, so it’s actually the opposite. We’re somehow asking for the latest revision IDs of an empty array of entity IDs. And WikiPageEntityMetaDataLookup has a special safeguard for this: if ( empty( $where ) ) { // If we skipped all entity IDs, select

[Wikidata-bugs] [Maniphest] [Updated] T179879: Provide a 5-minute timeout in WDQS for trusted users using OAuth

Smalyshev added a comment. Species without image times out I run this one: http://tinyurl.com/yaak4f5n and it worked in 50s, which is close to the limit, but still under it. It produced 1874294 results. I would call a query that produces almost 2M result an outlier, though I'll discard "extreme"

[Wikidata-bugs] [Maniphest] [Claimed] T188293: Categories download is broken

Smalyshev claimed this task.Smalyshev triaged this task as "High" priority. TASK DETAILhttps://phabricator.wikimedia.org/T188293EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: Aklapper, Gehel, Smalyshev, Lahi, Gq86, Darkminds3113,

[Wikidata-bugs] [Maniphest] [Updated] T188293: Categories download is broken

Smalyshev added a project: Discovery-Wikidata-Query-Service-Sprint. TASK DETAILhttps://phabricator.wikimedia.org/T188293EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: Aklapper, Gehel, Smalyshev, Lahi, Gq86, Darkminds3113, Lucas_Werkmeister_WMDE,

[Wikidata-bugs] [Maniphest] [Commented On] T187966: Request mw.wikibase to be enabled for thwikt

Lydia_Pintscher added a comment. Ok it seems like this is about arbitrary access indeed then. Thank you! As @Framawiki said it'd be great if you could point to a community discussion for it.TASK DETAILhttps://phabricator.wikimedia.org/T187966EMAIL

[Wikidata-bugs] [Maniphest] [Created] T188293: Categories download is broken

Smalyshev created this task.Smalyshev added a project: Wikidata-Query-Service.Herald added a subscriber: Aklapper.Herald added projects: Wikidata, Discovery. TASK DESCRIPTIONRight now categories download scripts for WDQS are broken because https://noc.wikimedia.org/conf/categories-rdf.dblist has

[Wikidata-bugs] [Maniphest] [Commented On] T179879: Provide a 5-minute timeout in WDQS for trusted users using OAuth

doctaxon added a comment. @Smalyshev @Magnus Thank you, Magnus, this was my opinion, but my English is not so good like yours, so ... Let's discuss about Magnus' suggestion, it sounds really good.TASK DETAILhttps://phabricator.wikimedia.org/T179879EMAIL

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T165982: Investigate using blazegraph for deep category searching / returning of results

Smalyshev added a subscriber: Lea_Lacroix_WMDE.Smalyshev added a comment. @Lea_Lacroix_WMDE I think the category download is broken now, due to some URL changes that happened without my knowledge and broke some scripts. I'll fix it and re-test.TASK

[Wikidata-bugs] [Maniphest] [Claimed] T188045: wdqs1004 broken

Gehel claimed this task.Gehel added a comment. Hardware diagnostic is running, I'll report back with the results when completed.TASK DETAILhttps://phabricator.wikimedia.org/T188045EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: GehelCc: Gehel, Cmjohnson,

[Wikidata-bugs] [Maniphest] [Updated] T185697: mwext-phpunit-coverage-publish for WikibaseQualityExternalValidation fails

greg removed a project: Release-Engineering-Team.greg added a comment. it’s not deployed and not really under active developmentTASK DETAILhttps://phabricator.wikimedia.org/T185697EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gregCc: greg,

[Wikidata-bugs] [Maniphest] [Retitled] T188291: Display results of a SPARQL query on a map in Wikipedia

Ayack renamed this task from "Display results of a SPARQL query on a map" to "Display results of a SPARQL query on a map in Wikipedia". TASK DETAILhttps://phabricator.wikimedia.org/T188291EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AyackCc: Aklapper,

[Wikidata-bugs] [Maniphest] [Commented On] T188285: Running mvn on wikidata/query/rdf fails with: /bin/sh: 1: npm: not found

hashar added a comment. Testing out my theory on https://gerrit.wikimedia.org/r/#/c/414731/ . Output to be looked at: https://integration.wikimedia.org/ci/job/wikidata-query-rdf-maven-java8-docker/7/consoleTASK DETAILhttps://phabricator.wikimedia.org/T188285EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T188285: Running mvn on wikidata/query/rdf fails with: /bin/sh: 1: npm: not found

gerritbot added a comment. Change 414731 had a related patch set uploaded (by Hashar; owner: Hashar): [wikidata/query/rdf@master] Set npm version for frontend-maven-plugin https://gerrit.wikimedia.org/r/414731TASK DETAILhttps://phabricator.wikimedia.org/T188285EMAIL

[Wikidata-bugs] [Maniphest] [Created] T188291: Display results of a SPARQL query on a map

Ayack created this task.Ayack added projects: Maps (Kartographer), Wikidata-Query-Service.Herald added a subscriber: Aklapper.Herald added projects: Wikidata, Discovery. TASK DESCRIPTIONOn https://query.wikidata.org/, you can easily display the result of a query on a dynamic map (see the Venues in

[Wikidata-bugs] [Maniphest] [Commented On] T179879: Provide a 5-minute timeout in WDQS for trusted users using OAuth

Magnus added a comment. Semantics and drama aside, I think the point is that some useful queries are already creaking, or failing entirely. Species without image times out, and I'm not even requesting taxon name (and we all know to stay away from the SERVICE labels for long queries by now).

[Wikidata-bugs] [Maniphest] [Commented On] T184812: Enable constraint result caching on Wikidata

Lucas_Werkmeister_WMDE added a comment. The WHERE would have something like one Q1234=page_title AND 0=page_namespace per entity ID. An alternative way to confirm this would be to check the latestRevisionIds in a cached value… perhaps someone can look at the cached value for

[Wikidata-bugs] [Maniphest] [Commented On] T184812: Enable constraint result caching on Wikidata

Lucas_Werkmeister_WMDE added a comment. Okay, then it’s almost certainly caused by this change, yes :( and I’m going to guess that the most likely reason for this query to become so slow would be that we’re asking for way too many revision IDs. Can you perhaps confirm this? The WHERE would have

[Wikidata-bugs] [Maniphest] [Commented On] T188285: Running mvn on wikidata/query/rdf fails with: /bin/sh: 1: npm: not found

gerritbot added a comment. Change 410169 merged by jenkins-bot: [integration/config@master] Experimental docker job wikidata-query-rdf-maven https://gerrit.wikimedia.org/r/410169TASK DETAILhttps://phabricator.wikimedia.org/T188285EMAIL

[Wikidata-bugs] [Maniphest] [Edited] T188285: Running mvn on wikidata/query/rdf fails with: /bin/sh: 1: npm: not found

hashar updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...A way to reproduce is to usesend a patch to Gerrit and comment `check experimental`. That will trigger the job: https://integration.wikimedia.org/ci/job/wikidata-query-rdf-maven-java8-docker/ --- Under the hood,

[Wikidata-bugs] [Maniphest] [Commented On] T181549: [epic] Subcategory searching

Smalyshev added a comment. What is the error that is returned, if the category limit is hit? The error is not implemented yet. Right now it just cuts the list off. I'll add the error message in the query soon. Can you do multiple deepcategory searches in the same query? You can use multiple

[Wikidata-bugs] [Maniphest] [Commented On] T184812: Enable constraint result caching on Wikidata

Marostegui added a comment. Something like: SELECT /* Wikibase\Lib\Store\Sql\WikiPageEntityMetaDataLookup::selectRevisionInformationMultiple */ rev_id, rev_content_format, rev_timestamp, page_latest, page_is_redirect, old_id, old_text, old_flags, page_title FROM `page` INNER JOIN `revision` ON

[Wikidata-bugs] [Maniphest] [Commented On] T184812: Enable constraint result caching on Wikidata

Lucas_Werkmeister_WMDE added a comment. Because I can’t think of anything SQL-related in that change… it shouldn’t result in any new SQL queries Okay, that was wrong. There are new SQL queries: for each wbcheckconstraints request, one or two queries to get the latest revision ID for a set of

[Wikidata-bugs] [Maniphest] [Commented On] T184812: Enable constraint result caching on Wikidata

jcrespo added a comment. F14034462: Screenshot_20180226_185900.pngTASK DETAILhttps://phabricator.wikimedia.org/T184812EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, jcrespoCc: greg, Ladsgroup, jcrespo, Marostegui, TerraCodes,

[Wikidata-bugs] [Maniphest] [Updated] T184812: Enable constraint result caching on Wikidata

greg added a project: Wikimedia-Incident. TASK DETAILhttps://phabricator.wikimedia.org/T184812EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gregCc: greg, Ladsgroup, jcrespo, Marostegui, TerraCodes, Stashbot, Liuxinyu970226, Jonas,

[Wikidata-bugs] [Maniphest] [Updated] T188285: Running mvn on wikidata/query/rdf fails with: /bin/sh: 1: npm: not found

gerritbot added a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T188285EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hashar, gerritbotCc: Aklapper, zeljkofilipin, MarcoAurelio, gerritbot, hashar, Giuliamocci, Adrian1985, Cpaulf30,

[Wikidata-bugs] [Maniphest] [Commented On] T184812: Enable constraint result caching on Wikidata

greg added a comment. This deserves an incident report.TASK DETAILhttps://phabricator.wikimedia.org/T184812EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gregCc: greg, Ladsgroup, jcrespo, Marostegui, TerraCodes, Stashbot,

[Wikidata-bugs] [Maniphest] [Commented On] T188285: Running mvn on wikidata/query/rdf fails with: /bin/sh: 1: npm: not found

gerritbot added a comment. Change 410169 had a related patch set uploaded (by Hashar; owner: Hashar): [integration/config@master] Experimental docker job wikidata-query-rdf-maven https://gerrit.wikimedia.org/r/410169TASK DETAILhttps://phabricator.wikimedia.org/T188285EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T179879: Provide a 5-minute timeout in WDQS for trusted users using OAuth

Smalyshev added a comment. but you didn't explain the reason why not. Because it is a shared service, and running queries with no limit on execution time will deny other users opportunity to use this service. if we stand still, then SPARQL will be useless in near future I do not think running

[Wikidata-bugs] [Maniphest] [Commented On] T184812: Enable constraint result caching on Wikidata

Lucas_Werkmeister_WMDE added a comment. To clarify – SQL queries? Because I can’t think of anything SQL-related in that change… it shouldn’t result in any new SQL queries, and should indirectly have reduced the number of SQL queries (because some Wikidata items would no longer need to be loaded).

[Wikidata-bugs] [Maniphest] [Commented On] T184812: Enable constraint result caching on Wikidata

Marostegui added a comment. And looks like everything is back to normal: https://grafana.wikimedia.org/dashboard/file/server-board.json?panelId=10=1=db1109=eth0=now-1h=now=1m We also killed queries (and they are not coming back after the revert)TASK

[Wikidata-bugs] [Maniphest] [Commented On] T184812: Enable constraint result caching on Wikidata

Marostegui added a comment. We have reverted the changeTASK DETAILhttps://phabricator.wikimedia.org/T184812EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, MarosteguiCc: Ladsgroup, jcrespo, Marostegui, TerraCodes, Stashbot,

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T184812: Enable constraint result caching on Wikidata

Lucas_Werkmeister_WMDE added a subscriber: Ladsgroup.Lucas_Werkmeister_WMDE added a comment. @Ladsgroup will be back in an hour, but he recommends that you first revert my (Lucas’) change (above), and if that doesn’t help, it might be his change https://gerrit.wikimedia.org/r/414667. HTHTASK

[Wikidata-bugs] [Maniphest] [Commented On] T188285: Running mvn on wikidata/query/rdf fails with: /bin/sh: 1: npm: not found

hashar added a comment. From some paste research, that seems to be an issue with the plugin: https://github.com/eirslett/frontend-maven-plugin/issues/560 Seems the pom.xml would need to configure the plugin with some ?TASK DETAILhttps://phabricator.wikimedia.org/T188285EMAIL

[Wikidata-bugs] [Maniphest] [Created] T188285: Running mvn on wikidata/query/rdf fails with: /bin/sh: 1: npm: not found

hashar created this task.hashar added projects: Continuous-Integration-Infrastructure (shipyard), Release-Engineering-Team (Kanban), Wikidata Query UI. TASK DESCRIPTIONI am trying to migrate`wikidata/query/rdf` CI jobs to use a Docker container having just java8/maven. It eventually fails when and

[Wikidata-bugs] [Maniphest] [Commented On] T184812: Enable constraint result caching on Wikidata

Lucas_Werkmeister_WMDE added a comment. Ouch. Please feel free to revert the config change https://gerrit.wikimedia.org/r/413724 – even if it turns out to be unrelated, it won’t hurt our users too much.TASK DETAILhttps://phabricator.wikimedia.org/T184812EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T184812: Enable constraint result caching on Wikidata

jcrespo added a comment. https://grafana.wikimedia.org/dashboard/file/server-board.json?refresh=1m=10=1=db1109=eth0=1519578882341=1519665282341TASK DETAILhttps://phabricator.wikimedia.org/T184812EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:

[Wikidata-bugs] [Maniphest] [Commented On] T184812: Enable constraint result caching on Wikidata

Marostegui added a comment. We are investigating if this has caused a massive spike on wikidata replicas: https://grafana.wikimedia.org/dashboard/file/server-board.json?refresh=1m=10=1=db1109=eth0=1519578882341=1519665282341 As per https://wikitech.wikimedia.org/wiki/Server_Admin_Log the time

[Wikidata-bugs] [Maniphest] [Reopened] T184812: Enable constraint result caching on Wikidata

jcrespo reopened this task as "Open".jcrespo raised the priority of this task from "Normal" to "Unbreak Now!".Herald added a subscriber: TerraCodes. TASK DETAILhttps://phabricator.wikimedia.org/T184812EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:

[Wikidata-bugs] [Maniphest] [Block] T181060: Cache constraint check results per-entity in ObjectCache (L) (days: 2)

jcrespo reopened subtask T184812: Enable constraint result caching on Wikidata as "Open". TASK DETAILhttps://phabricator.wikimedia.org/T181060EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, jcrespoCc: gerritbot, Aklapper, Jonas,

[Wikidata-bugs] [Maniphest] [Commented On] T188276: Update StructureTest to find non-fully qualified PHPUnit\Framework\TestCase

Lucas_Werkmeister_WMDE added a comment. We might want to just check for a suffix of TestCase to support extension TestCases as well? Sounds reasonable – this would also make a few other list elements (MediaWikiTestCase, MediaWikiLangTestCase, …) obsolete. (Side note: IIUC, StructureTest

[Wikidata-bugs] [Maniphest] [Edited] T188279: Investigate optimzing wb_terms

Lucas_Werkmeister_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION... - Normalize `term_type` (label=0, etc.)...TASK DETAILhttps://phabricator.wikimedia.org/T188279EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:

  1   2   >