[Wikidata-bugs] [Maniphest] [Updated] T189745: Index Lexemes and Forms

2018-03-19 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T189745EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, dcausse, Lydia_Pintscher, daniel, Aklapper, Smalyshev, Versusxo, Majesticalreaper22,

[Wikidata-bugs] [Maniphest] [Commented On] T189745: Index Lexemes and Forms

2018-03-19 Thread gerritbot
gerritbot added a comment. Change 420637 had a related patch set uploaded (by Smalyshev; owner: Smalyshev): [mediawiki/extensions/WikibaseLexeme@master] [WIP] Index Lexemes and Forms https://gerrit.wikimedia.org/r/420637TASK DETAILhttps://phabricator.wikimedia.org/T189745EMAIL

[Wikidata-bugs] [Maniphest] [Updated] T189745: Index Lexemes and Forms

2018-03-19 Thread Smalyshev
Smalyshev added projects: User-Smalyshev, Discovery-Search (Current work). TASK DETAILhttps://phabricator.wikimedia.org/T189745EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: dcausse, Lydia_Pintscher, daniel, Aklapper, Smalyshev, Lahi, Gq86,

[Wikidata-bugs] [Maniphest] [Closed] T182271: Wikidata fulltext search should handle search syntax properly

2018-03-19 Thread Smalyshev
Smalyshev closed this task as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T182271EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: Abit, gerritbot, Lydia_Pintscher, Aklapper, dcausse, EBernhardson, daniel, debt, Smalyshev, Versusxo,

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T185589: Repeating blank node ids in Wikidata entity RDF dumps

2018-03-19 Thread Smalyshev
Smalyshev added a subscriber: thiemowmde.Smalyshev added a comment. Next step I guess would be to create v1.0.7 for purtle and update version in Wikibase. I don't own the packagist module so I assume it's either @daniel or @thiemowmde.TASK DETAILhttps://phabricator.wikimedia.org/T185589EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T185589: Repeating blank node ids in Wikidata entity RDF dumps

2018-03-19 Thread gerritbot
gerritbot added a comment. Change 420636 had a related patch set uploaded (by Smalyshev; owner: Smalyshev): [purtle@master] Update release notes https://gerrit.wikimedia.org/r/420636TASK DETAILhttps://phabricator.wikimedia.org/T185589EMAIL

[Wikidata-bugs] [Maniphest] [Unblock] T178851: Use label & description index for fulltext search

2018-03-19 Thread Smalyshev
Smalyshev closed subtask T182271: Wikidata fulltext search should handle search syntax properly as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T178851EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: Abit, Realworldobject, debt,

[Wikidata-bugs] [Maniphest] [Closed] T155043: "Don't initialize MWServices super early" causes test failure on .7

2018-03-19 Thread Krinkle
Krinkle closed this task as "Resolved".Krinkle added a project: Wikimedia-log-errors (Jenkins Failure).Krinkle claimed this task.Krinkle added a comment. Seems resolved. Re-open if it pops back.TASK DETAILhttps://phabricator.wikimedia.org/T155043EMAIL

[Wikidata-bugs] [Maniphest] [Merged] T189329: jquery.wikibase.edittoolbar and other qunit tests are flaky

2018-03-19 Thread Krinkle
Krinkle added a subscriber: Tgr.Krinkle merged a task: T186286: Wikibase selenium test is flaky. TASK DETAILhttps://phabricator.wikimedia.org/T189329EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Tgr, hashar, gerritbot, Reedy, Krinkle, dcausse,

[Wikidata-bugs] [Maniphest] [Updated] T186286: Wikibase selenium test is flaky

2018-03-19 Thread Krinkle
Krinkle added a project: Wikimedia-log-errors (Jenkins Failure). TASK DETAILhttps://phabricator.wikimedia.org/T186286EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Aklapper, Tgr, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs,

[Wikidata-bugs] [Maniphest] [Updated] T186286: Wikibase selenium test is flaky

2018-03-19 Thread Krinkle
Krinkle closed this task as a duplicate of T189329: jquery.wikibase.edittoolbar and other qunit tests are flaky. TASK DETAILhttps://phabricator.wikimedia.org/T186286EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Aklapper, Tgr, Lahi, Gq86,

[Wikidata-bugs] [Maniphest] [Created] T190121: Empty statement box is shown when only statement is deprecated

2018-03-19 Thread hoo
hoo created this task.hoo added projects: ArticlePlaceholder, Wikidata.Herald added a subscriber: Aklapper. TASK DESCRIPTIONFor example on https://bn.wikipedia.org/wiki/%E0%A6%AC%E0%A6%BF%E0%A6%B6%E0%A7%87%E0%A6%B7:AboutTopic/Q53 the "OSM tag or key" statement box is empty, as the statement is

[Wikidata-bugs] [Maniphest] [Updated] T189329: jquery.wikibase.edittoolbar and other qunit tests are flaky

2018-03-19 Thread Krinkle
Krinkle added a project: Wikimedia-log-errors (Jenkins Failure). TASK DETAILhttps://phabricator.wikimedia.org/T189329EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: hashar, gerritbot, Reedy, Krinkle, dcausse, Smalyshev, Jdlrobson, hoo, Mbch331,

[Wikidata-bugs] [Maniphest] [Commented On] T185589: Repeating blank node ids in Wikidata entity RDF dumps

2018-03-19 Thread gerritbot
gerritbot added a comment. Change 413288 merged by jenkins-bot: [purtle@master] Add ability to set bnode labeler to writer & factory https://gerrit.wikimedia.org/r/413288TASK DETAILhttps://phabricator.wikimedia.org/T185589EMAIL

[Wikidata-bugs] [Maniphest] [Updated] T177550: Only dump up entities in a certain page_id range in each maintenance script run (days: 1)

2018-03-19 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T177550EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: Lucas_Werkmeister_WMDE, gerritbot, Lydia_Pintscher, daniel, ArielGlenn, Aklapper, hoo, Versusxo,

[Wikidata-bugs] [Maniphest] [Commented On] T177550: Only dump up entities in a certain page_id range in each maintenance script run (days: 1)

2018-03-19 Thread gerritbot
gerritbot added a comment. Change 420629 had a related patch set uploaded (by Hoo man; owner: Hoo man): [mediawiki/extensions/Wikibase@master] DumpEntities: Allow dumping a specific range of page ids https://gerrit.wikimedia.org/r/420629TASK DETAILhttps://phabricator.wikimedia.org/T177550EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T184000: Magic word on English WP to override display of Wikidata short description

2018-03-19 Thread Tgr
Tgr added a comment. This is now in testwiki (also beta enwiki) and seems to be working well. Just from testing some large API queries, it seems on par with pageterms on performance (both are fairly fast even for thousands of pages). I think it could go to enwiki later this week, but I won't be

[Wikidata-bugs] [Maniphest] [Commented On] T184000: Magic word on English WP to override display of Wikidata short description

2018-03-19 Thread gerritbot
gerritbot added a comment. Change 418843 merged by jenkins-bot: [operations/mediawiki-config@master] Enable Wikidata description override on testwiki https://gerrit.wikimedia.org/r/418843TASK DETAILhttps://phabricator.wikimedia.org/T184000EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T183020: Investigate the possibility to release Wikidata queries

2018-03-19 Thread leila
leila added a comment. I did one pass and left a couple of comments at https://meta.wikimedia.org/wiki/User_talk:Markus_Kr%C3%B6tzsch/Wikidata_queriesTASK DETAILhttps://phabricator.wikimedia.org/T183020EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: leilaCc:

[Wikidata-bugs] [Maniphest] [Commented On] T174038: Implement MCR page update interface

2018-03-19 Thread gerritbot
gerritbot added a comment. Change 406388 abandoned by Daniel Kinzler: [MCR] Prepare PreparedEdit for MCR Reason: merged this into If610c68f4912e89af616cdcac1d35a1be3946afa https://gerrit.wikimedia.org/r/406388TASK DETAILhttps://phabricator.wikimedia.org/T174038EMAIL

[Wikidata-bugs] [Maniphest] [Changed Project Column] T189538: Reduce complexity of Wikibase JS module registration

2018-03-19 Thread Krinkle
Krinkle moved this task from Inbox to Radar on the Performance-Team board.Krinkle edited projects, added Performance-Team (Radar); removed Performance-Team. TASK DETAILhttps://phabricator.wikimedia.org/T189538WORKBOARDhttps://phabricator.wikimedia.org/project/board/1212/EMAIL

[Wikidata-bugs] [Maniphest] [Updated] T182271: Wikidata fulltext search should handle search syntax properly

2018-03-19 Thread ReleaseTaggerBot
ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-03-20 (1.31.0-wmf.26)). TASK DETAILhttps://phabricator.wikimedia.org/T182271EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Smalyshev, ReleaseTaggerBotCc: Abit, gerritbot,

[Wikidata-bugs] [Maniphest] [Commented On] T190033: Should lemmas of a lexeme, and representations of a form be only allowed to defined one per language/variant code?

2018-03-19 Thread daniel
daniel added a comment. My 2c, just for the record: I disagree with the decision, but I don't think it's particularly bad. It means we (and client libraries) can't re-use code that was written for lemmas (e.g. lemmans and representations can't be represented as a JSON object, but will have to be

[Wikidata-bugs] [Maniphest] [Commented On] T190066: Expose all slots to the search interface

2018-03-19 Thread EBernhardson
EBernhardson added a comment. At least for cirrus, it pretty much needs to be one document if we want any kind of interaction between fields of multiple content types. I think, again only wrt cirrus, this is going to depend heavily on how those fields get into the queries issued. The current

[Wikidata-bugs] [Maniphest] [Commented On] T190066: Expose all slots to the search interface

2018-03-19 Thread daniel
daniel added a comment. In T190066#4062068, @Smalyshev wrote: If the answer is one document, how to reconcile slots with potential intersections? I.e., if both slots want to put something in opening_text, what happens? Etc. For now, I'd blindly concatenate. That's the baseline. We have to

[Wikidata-bugs] [Maniphest] [Edited] T187198: Disable Senses in the API for the initial version of the WikibaseLexeme extension

2018-03-19 Thread WMDE-leszek
WMDE-leszek updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...- wbremoveclaims ... TODO: more?Possible also: - wbgetentities - wbgetclaims Should use the existing LexemeEnableSenses feature toggleTASK DETAILhttps://phabricator.wikimedia.org/T187198EMAIL

[Wikidata-bugs] [Maniphest] [Updated] T190033: Should lemmas of a lexeme, and representations of a form be only allowed to defined one per language/variant code?

2018-03-19 Thread WMDE-leszek
WMDE-leszek added a comment. Decision: change the internal data structure to something that does not make the assumption on the one-per-language code element. See T190057 and T190060 for relevant tasks. @Lydia_Pintscher: For any user-facing changes (i.e. what behaviour UI should have if having a

[Wikidata-bugs] [Maniphest] [Closed] T190033: Should lemmas of a lexeme, and representations of a form be only allowed to defined one per language/variant code?

2018-03-19 Thread WMDE-leszek
WMDE-leszek closed this task as "Resolved".WMDE-leszek claimed this task. TASK DETAILhttps://phabricator.wikimedia.org/T190033EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: Lydia_Pintscher, WMDE-leszek, Aklapper, daniel, Lahi, Gq86,

[Wikidata-bugs] [Maniphest] [Updated] T190066: Expose all slots to the search interface

2018-03-19 Thread Smalyshev
Smalyshev added subscribers: dcausse, EBernhardson.Smalyshev added a project: CirrusSearch.Smalyshev added a comment.Herald added a project: Discovery. Two big questions here are: One document or multiple documents? (I think the trend is for now for one document) If the answer is one document,

[Wikidata-bugs] [Maniphest] [Commented On] T182271: Wikidata fulltext search should handle search syntax properly

2018-03-19 Thread gerritbot
gerritbot added a comment. Change 395894 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Redirect queries with advanced syntax to the old search https://gerrit.wikimedia.org/r/395894TASK DETAILhttps://phabricator.wikimedia.org/T182271EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T189762: selenium test for Wikibase is unstable

2018-03-19 Thread Smalyshev
Smalyshev added a comment. Seems to be still happening. See: https://integration.wikimedia.org/ci/job/mwext-mw-selenium-composer-jessie/9226/consoleTASK DETAILhttps://phabricator.wikimedia.org/T189762EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:

[Wikidata-bugs] [Maniphest] [Commented On] T189593: (De)serialize CheckResults in CachingResultsBuilder

2018-03-19 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. Oh, and we need a place where we actually do the conversion of CheckResults to arrays and store them all in the giant result structure, since ResultsSource doesn’t do that anymore. (This is also the step where ViolationMessages are rendered.) Is that a

[Wikidata-bugs] [Maniphest] [Commented On] T189593: (De)serialize CheckResults in CachingResultsBuilder

2018-03-19 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. I suppose it could be just a ResultsSource. Very generic, but matches ResultsBuilder. CheckingResultsSource and CachingResultsSource don’t sound too bad to me.TASK DETAILhttps://phabricator.wikimedia.org/T189593EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T189593: (De)serialize CheckResults in CachingResultsBuilder

2018-03-19 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. Perhaps a CheckResultsSource? But that doesn’t really yield any good names for the implementation (a CheckingCheckResultsSource?).TASK DETAILhttps://phabricator.wikimedia.org/T189593EMAIL

[Wikidata-bugs] [Maniphest] [Updated] T188551: Facilitate conversation on Commons about the future of file titles

2018-03-19 Thread Keegan
Keegan edited projects, added Community-Liaisons (Apr-Jun-2018); removed Community-Liaisons (Jan-Mar-2018). TASK DETAILhttps://phabricator.wikimedia.org/T188551EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KeeganCc: Aklapper, Keegan, Lahi, PDrouin-WMF,

[Wikidata-bugs] [Maniphest] [Closed] T186237: Document liaison communication strategy for Structured Data on Commons

2018-03-19 Thread Keegan
Keegan closed this task as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T186237EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KeeganCc: Aklapper, Keegan, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, SandraF_WMF, GoranSMilovanovic,

[Wikidata-bugs] [Maniphest] [Unblock] T182672: [Epic] Facilitate community conversations and feedback about prototypes and designs for Structured Data on Wikimedia Commons

2018-03-19 Thread Keegan
Keegan closed subtask T186237: Document liaison communication strategy for Structured Data on Commons as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T182672EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KeeganCc: Keegan, Ramsey-WMF, Abit,

[Wikidata-bugs] [Maniphest] [Claimed] T189593: (De)serialize CheckResults in CachingResultsBuilder

2018-03-19 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE claimed this task.Lucas_Werkmeister_WMDE moved this task from Tasks to In Progress on the Wikidata-Ministry-Of-Magic board. TASK DETAILhttps://phabricator.wikimedia.org/T189593WORKBOARDhttps://phabricator.wikimedia.org/project/board/3273/EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T189593: (De)serialize CheckResults in CachingResultsBuilder

2018-03-19 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. So what do we have instead? CachedCheckResults: wrapper around CheckResult[] + Metadata. (Note: since the results may be filtered, the overall metadata may be more than the merge of the individual CheckResult metadatas!) something which takes the same

[Wikidata-bugs] [Maniphest] [Created] T190066: Expose all slots to the search interface

2018-03-19 Thread daniel
daniel created this task.daniel triaged this task as "Normal" priority.daniel added projects: Wikidata, Epic, Structured-Data-Commons, Multi-Content-Revisions, Discovery-Search. TASK DESCRIPTIONSearch engines such as Cirrus should examine the content of all slots when updating the search

[Wikidata-bugs] [Maniphest] [Updated] T174038: Implement MCR page update interface

2018-03-19 Thread daniel
daniel added a subtask: T190063: Tracking dependencies for multiple Content objects per page (MCR). TASK DETAILhttps://phabricator.wikimedia.org/T174038EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: gerritbot, Aklapper, daniel, Versusxo,

[Wikidata-bugs] [Maniphest] [Triaged] T190057: Allow to store multiple lemmas using the same language code

2018-03-19 Thread WMDE-leszek
WMDE-leszek triaged this task as "High" priority.WMDE-leszek updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...For the existing data stored in the database of the demo system, and possible other development instances, the conversion of the data could be provided by adding

[Wikidata-bugs] [Maniphest] [Triaged] T190060: Allow to store multiple form representations using the same language code

2018-03-19 Thread WMDE-leszek
WMDE-leszek triaged this task as "High" priority.WMDE-leszek updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...For the existing data stored in the database of the demo system, and possible other development instances, the conversion of the data could be provided by adding

[Wikidata-bugs] [Maniphest] [Created] T190060: Allow to store multiple form representations using the same language code

2018-03-19 Thread WMDE-leszek
WMDE-leszek created this task.WMDE-leszek added projects: Wikidata, Lexicographical data.Herald added a subscriber: Aklapper. TASK DESCRIPTIONTODO: define the behaviour in the UI Note that as of 2018-03-19, the data structure used for internal storage of the lexeme data is assuming there only a

[Wikidata-bugs] [Maniphest] [Edited] T184745: Handle config variables of lexeme in production before the first release

2018-03-19 Thread WMDE-leszek
WMDE-leszek updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...Variables to set: - TODO: the one above check the name and value- $wgWBClientSettings['disabledAccessEntityTypes'] = [ 'lexeme', 'form', 'sense' ]; - language code property: name:

[Wikidata-bugs] [Maniphest] [Edited] T184745: Handle config variables of lexeme in production before the first release

2018-03-19 Thread Jakob_WMDE
Jakob_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...- language code property: TODO: name andname: `$wgLexemeLanguageCodePropertyId` value: "P219" (?) - LexemeEnableSenses: false...TASK DETAILhttps://phabricator.wikimedia.org/T184745EMAIL

[Wikidata-bugs] [Maniphest] [Created] T190057: Allow to store multiple lemmas using the same language code

2018-03-19 Thread WMDE-leszek
WMDE-leszek created this task.WMDE-leszek added projects: Lexicographical data, Wikidata.Herald added a subscriber: Aklapper. TASK DESCRIPTIONTODO: define the behaviour in the UI Note that as of 2018-03-19, the data structure used for internal storage of the lexeme data is assuming there only a

[Wikidata-bugs] [Maniphest] [Commented On] T189593: (De)serialize CheckResults in CachingResultsBuilder

2018-03-19 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. Hm, we don’t need a hybrid phase, but this is still a big change – and it pretty much invalidates the current interface of CachedCheckConstraintsResponse and ResultsBuilder, so perhaps it would be better to build up a new interface with new implementations

[Wikidata-bugs] [Maniphest] [Commented On] T185549: "Limit" button is not translated

2018-03-19 Thread gerritbot
gerritbot added a comment. Change 420363 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [wikidata/query/gui@master] Extract generation of i18n spans into function https://gerrit.wikimedia.org/r/420363TASK

[Wikidata-bugs] [Maniphest] [Updated] T189538: Reduce complexity of Wikibase JS module registration

2018-03-19 Thread ReleaseTaggerBot
ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-03-20 (1.31.0-wmf.26)). TASK DETAILhttps://phabricator.wikimedia.org/T189538EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: ReleaseTaggerBotCc: Lydia_Pintscher, gerritbot, thiemowmde,

[Wikidata-bugs] [Maniphest] [Edited] T184745: Handle config variables of lexeme in production before the first release

2018-03-19 Thread WMDE-leszek
WMDE-leszek updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...- TODO: the one above check the name and value - language code property: TODO: name and value - LexemeEnableSenses: false...TASK DETAILhttps://phabricator.wikimedia.org/T184745EMAIL

[Wikidata-bugs] [Maniphest] [Edited] T184745: Handle config variables of lexeme in production before the first release

2018-03-19 Thread WMDE-leszek
WMDE-leszek updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION... - {T182660} Variables to set: - TODO: the one above check the name and value - LexemeEnableSenses: false - more?TASK DETAILhttps://phabricator.wikimedia.org/T184745EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T189875: Migrate “exception” check results to ViolationMessage

2018-03-19 Thread gerritbot
gerritbot added a comment. Change 420356 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Use ViolationMessage for constraint exceptions https://gerrit.wikimedia.org/r/420356TASK

[Wikidata-bugs] [Maniphest] [Updated] T189875: Migrate “exception” check results to ViolationMessage

2018-03-19 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T189875EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: Aklapper, gerritbot, Lucas_Werkmeister_WMDE, Versusxo, Majesticalreaper22,

[Wikidata-bugs] [Maniphest] [Edited] T165579: New data type to allow linking to Forms

2018-03-19 Thread WMDE-leszek
WMDE-leszek updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...**And** I put an ID of the form in the value fieldd **Then** the entered ID is shown in the suggester **ThenAnd** I see the save button enabled ...**And** The representation to the reference frod form is

[Wikidata-bugs] [Maniphest] [Changed Project Column] T189875: Migrate “exception” check results to ViolationMessage

2018-03-19 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE moved this task from Tasks to In Progress on the Wikidata-Ministry-Of-Magic board.Lucas_Werkmeister_WMDE added a comment. How much effort is it to rename a message? translatewiki:FAQ#Is it possible to rename message keys? says I should just do the rename and not worry about

[Wikidata-bugs] [Maniphest] [Edited] T165579: New data type to allow linking to Forms

2018-03-19 Thread WMDE-leszek
WMDE-leszek updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...**And** The edit is recorded in the edit history. TODO: specify summary TASK DETAILhttps://phabricator.wikimedia.org/T165579EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:

[Wikidata-bugs] [Maniphest] [Edited] T165579: New data type to allow linking to Forms

2018-03-19 Thread RazShuty
RazShuty updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...**When** I save a new statement with a data type form...TASK DETAILhttps://phabricator.wikimedia.org/T165579EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: RazShutyCc:

[Wikidata-bugs] [Maniphest] [Edited] T165579: New data type to allow linking to Forms

2018-03-19 Thread RazShuty
RazShuty updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...* {T175030} **//`BDD Happy Path:`//** **Given** I am on the Lexeme Page **When** I make a new statement **And** I put an ID in the value field **Then** I see the save button enabled **And** The value border is

[Wikidata-bugs] [Maniphest] [Changed Project Column] T188728: Replace claim with violation message in Special:ConstraintReport

2018-03-19 Thread Charlie_WMDE
Charlie_WMDE moved this task from Incoming to WMDE-Design-Workboard Doing on the WMDE-Design board.Charlie_WMDE edited projects, added WMDE-Design (WMDE-Design-Workboard Doing); removed WMDE-Design. TASK

[Wikidata-bugs] [Maniphest] [Triaged] T189604: Create icon for “exception for constraint” status

2018-03-19 Thread Jan_Dittrich
Jan_Dittrich triaged this task as "Low" priority.Jan_Dittrich updated the task description. (Show Details) CHANGES TO TASK DESCRIPTIONStory: As a user I want that the same elements in the UI mean the same things. Suggestion: Since we’re going to show “exception” results on the

[Wikidata-bugs] [Maniphest] [Edited] T165579: New data type to allow linking to Forms

2018-03-19 Thread WMDE-leszek
WMDE-leszek updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...* I can select the Form via an entity selector that shows me a derived label forby entering the ID of the referenced FormNeeds to be broken down into: * Defining the data type (S) * Adding a new statement

[Wikidata-bugs] [Maniphest] [Commented On] T169333: Update license information on Wikidata to make Lexeme namespace CC-0

2018-03-19 Thread Addshore
Addshore added a comment. This message is provided by the WikimediaMessages extension (apparently). "wikidata-copyright": "All structured data from the main and property namespace is available under the https://creativecommons.org/publicdomain/zero/1.0/\" title=\"Definition of the Creative

[Wikidata-bugs] [Maniphest] [Edited] T169333: Update license information on Wikidata to make Lexeme namespace CC-0

2018-03-19 Thread WMDE-leszek
WMDE-leszek updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...must be updated to include the lexeme namespace in the structured data / CC0 namespace list. Update the XXX message in WikimediaMessages extensionTASK DETAILhttps://phabricator.wikimedia.org/T169333EMAIL

[Wikidata-bugs] [Maniphest] [Retitled] T189777: Disable reading from term_search_key from wb_terms table in wikidata

2018-03-19 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE renamed this task from "Enable reading from term_search_key from wb_terms table in wikidata" to "Disable reading from term_search_key from wb_terms table in wikidata". TASK DETAILhttps://phabricator.wikimedia.org/T189777EMAIL

[Wikidata-bugs] [Maniphest] [Retitled] T187198: Disable Senses in the API for the initial version of the WikibaseLexeme extension

2018-03-19 Thread WMDE-leszek
WMDE-leszek renamed this task from "Disable Senses in the API for the initial version of the WikibaseLexeme extension [M]" to "Disable Senses in the API for the initial version of the WikibaseLexeme extension". TASK DETAILhttps://phabricator.wikimedia.org/T187198EMAIL

[Wikidata-bugs] [Maniphest] [Edited] T187198: Disable Senses in the API for the initial version of the WikibaseLexeme extension [M]

2018-03-19 Thread WMDE-leszek
WMDE-leszek updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION.. TODO: more? Should use the existing LexemeEnableSenses feature toggle. Acceptance criteria:...TASK DETAILhttps://phabricator.wikimedia.org/T187198EMAIL

[Wikidata-bugs] [Maniphest] [Edited] T187198: Disable Senses in the API for the initial version of the WikibaseLexeme extension [M]

2018-03-19 Thread WMDE-leszek
WMDE-leszek updated the task description. (Show Details) CHANGES TO TASK DESCRIPTIONAPI actions should not handle any requests related to senses. API actions involved: - wbeditentity - wbsetclaim - wbremoveclaims ... TODO: more? Acceptance criteria:...* If the API input contains senses, the API

[Wikidata-bugs] [Maniphest] [Changed Project Column] T189776: Disable reading from term_search_key from wb_terms table in beta cluster and testwikidata

2018-03-19 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE moved this task from In Progress to Needs Review on the Wikidata-Ministry-Of-Magic board.Lucas_Werkmeister_WMDE added a comment. Meh, implemented the testwikidata part myself, so back to “needs review” we go :)TASK

[Wikidata-bugs] [Maniphest] [Commented On] T189776: Disable reading from term_search_key from wb_terms table in beta cluster and testwikidata

2018-03-19 Thread gerritbot
gerritbot added a comment. Change 420336 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [operations/mediawiki-config@master] Disable reading wb_terms search fields on testwikidata https://gerrit.wikimedia.org/r/420336TASK

[Wikidata-bugs] [Maniphest] [Commented On] T189538: Reduce complexity of Wikibase JS module registration

2018-03-19 Thread gerritbot
gerritbot added a comment. Change 419489 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Inline WikibaseView resource files directly accessing global vars https://gerrit.wikimedia.org/r/419489TASK DETAILhttps://phabricator.wikimedia.org/T189538EMAIL

[Wikidata-bugs] [Maniphest] [Closed] T186726: Security review WikibaseLexeme extension

2018-03-19 Thread Bawolff
Bawolff closed this task as "Resolved".Bawolff added a comment. Yep, you are good.TASK DETAILhttps://phabricator.wikimedia.org/T186726EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: BawolffCc: Jakob_WMDE, Jonas, gerritbot, Aklapper, Lucas_Werkmeister_WMDE,

[Wikidata-bugs] [Maniphest] [Unblock] T168260: Deploy WikibaseLexeme extension on Wikimedia cluster

2018-03-19 Thread Bawolff
Bawolff closed subtask T186726: Security review WikibaseLexeme extension as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T168260EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: BawolffCc: Addshore, Aklapper, daniel, Lahi, Gq86, Cinemantique,

[Wikidata-bugs] [Maniphest] [Claimed] T189186: label not shown for grammatical feature in diff of a Form

2018-03-19 Thread Jakob_WMDE
Jakob_WMDE claimed this task.Jakob_WMDE moved this task from ToDo to Doing on the Wikidata-Turtles-18.03.14 board. TASK DETAILhttps://phabricator.wikimedia.org/T189186WORKBOARDhttps://phabricator.wikimedia.org/project/board/3292/EMAIL

[Wikidata-bugs] [Maniphest] [Edited] T189842: Undefined index error in CachingResultsBuilder when checking constraints on empty entity

2018-03-19 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...Not sure what the best solution for this will be… probably some kind of `NullContextCursor` (only entity ID, no statement etc.) that we can plug into the `NullResult` we already have from T178160?

[Wikidata-bugs] [Maniphest] [Commented On] T189842: Undefined index error in CachingResultsBuilder when checking constraints on empty entity

2018-03-19 Thread gerritbot
gerritbot added a comment. Change 420321 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Ensure that result is populated even for empty entities https://gerrit.wikimedia.org/r/420321TASK

[Wikidata-bugs] [Maniphest] [Commented On] T189842: Undefined index error in CachingResultsBuilder when checking constraints on empty entity

2018-03-19 Thread gerritbot
gerritbot added a comment. Change 420319 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Replace NullResult’s Context with ContextCursor https://gerrit.wikimedia.org/r/420319TASK

[Wikidata-bugs] [Maniphest] [Commented On] T189842: Undefined index error in CachingResultsBuilder when checking constraints on empty entity

2018-03-19 Thread gerritbot
gerritbot added a comment. Change 420320 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Add EntityContextCursor https://gerrit.wikimedia.org/r/420320TASK

[Wikidata-bugs] [Maniphest] [Edited] T190039: CirrusSearch smoke selenium tests cause failures of mediawiki-core-qunit-selenium-jessie job for extensions

2018-03-19 Thread WMDE-leszek
WMDE-leszek updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...Our extension installs CirrusSearch as a part of the test environment, and apparently said job does not compute together with the way CirrusSearch structures its selenium tests, see the test failure:

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T190039: CirrusSearch smoke selenium tests cause failures of mediawiki-core-qunit-selenium-jessie job for extensions

2018-03-19 Thread hashar
hashar added subscribers: zeljkofilipin, Browser-Tests.hashar added a comment. I guess @zeljkofilipin can look into it and offer some recommendation :]TASK DETAILhttps://phabricator.wikimedia.org/T190039EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:

[Wikidata-bugs] [Maniphest] [Commented On] T189842: Undefined index error in CachingResultsBuilder when checking constraints on empty entity

2018-03-19 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. This is already a violation of the wbcheckconstraints API, I think (consumers should probably be able to expect the entity ID and an empty claims array, at least) Well, not quite… we actually work around this in CheckConstraints.php itself, so the API

[Wikidata-bugs] [Maniphest] [Created] T190039: CirrusSearch smoke selenium tests cause failures of mediawiki-core-qunit-selenium-jessie job for extensions

2018-03-19 Thread WMDE-leszek
WMDE-leszek created this task.WMDE-leszek added projects: Wikidata, Lexicographical data, Continuous-Integration-Infrastructure.Herald added a subscriber: Aklapper. TASK DESCRIPTIONBackground: discovered when adding a node selenium test to WikibaseLexeme extension. In order to run node selenium

[Wikidata-bugs] [Maniphest] [Updated] T189842: Undefined index error in CachingResultsBuilder when checking constraints on empty entity

2018-03-19 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a project: Wikidata-Ministry-Of-Magic. TASK DETAILhttps://phabricator.wikimedia.org/T189842EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: gerritbot, Lucas_Werkmeister_WMDE, Aklapper, Reedy, Versusxo,

[Wikidata-bugs] [Maniphest] [Claimed] T189842: Undefined index error in CachingResultsBuilder when checking constraints on empty entity

2018-03-19 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE moved this task from Tasks to In Progress on the Wikidata-Ministry-Of-Magic board.Lucas_Werkmeister_WMDE claimed this task. TASK DETAILhttps://phabricator.wikimedia.org/T189842WORKBOARDhttps://phabricator.wikimedia.org/project/board/3273/EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T178047: Investigate why wikidata abstracts dumps are so large

2018-03-19 Thread ArielGlenn
ArielGlenn added a comment. Does anyone know where the schema for these xml files lives? I've grepped around in mw core and in the abstract extension repos and found nothing.TASK DETAILhttps://phabricator.wikimedia.org/T178047EMAIL

[Wikidata-bugs] [Maniphest] [Closed] T189143: "Grammatical features" string on a Form of a Lexeme is not translatable

2018-03-19 Thread Lydia_Pintscher
Lydia_Pintscher closed this task as "Resolved".Lydia_Pintscher added a comment. \o/TASK DETAILhttps://phabricator.wikimedia.org/T189143EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDE, Lydia_PintscherCc: Pablo-WMDE, Jakob_WMDE, gerritbot, Aklapper,

[Wikidata-bugs] [Maniphest] [Commented On] T189937: Allow to show linebreaks in results of wikidata query UI

2018-03-19 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. An alternative solution would be to wrap results optionally in a element (e. g., if the string has a certain language code, like qqx-code), which would give you support not only for \n but also for \t. Do you think that would be useful? (Downside: it would

[Wikidata-bugs] [Maniphest] [Commented On] T189143: "Grammatical features" string on a Form of a Lexeme is not translatable

2018-03-19 Thread Jakob_WMDE
Jakob_WMDE added a comment. @Lydia_Pintscher product review: https://wikidata-lexeme.wmflabs.org/index.php/Lexeme:L15?uselang=qqx previously hardcoded "Grammatical features" now says "(wikibaselexeme-form-grammatical-features)"TASK DETAILhttps://phabricator.wikimedia.org/T189143EMAIL

[Wikidata-bugs] [Maniphest] [Updated] T173774: Create script to dump recently changed categories

2018-03-19 Thread Lea_WMDE
Lea_WMDE added a project: Advanced-Search.Herald added a project: TCB-Team. TASK DETAILhttps://phabricator.wikimedia.org/T173774EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Smalyshev, Lea_WMDECc: Charlie_WMDE, Lea_WMDE, EBernhardson, ArielGlenn, gerritbot,

[Wikidata-bugs] [Maniphest] [Commented On] T189677: Set up the "Hello World" JS browser test

2018-03-19 Thread gerritbot
gerritbot added a comment. Change 419479 merged by jenkins-bot: [integration/config@master] Run node selenium tests as part of WikibaseLexeme CI build https://gerrit.wikimedia.org/r/419479TASK DETAILhttps://phabricator.wikimedia.org/T189677EMAIL

[Wikidata-bugs] [Maniphest] [Created] T190033: Should lemmas of a lexeme, and representations of a form be only allowed to defined one per language/variant code?

2018-03-19 Thread WMDE-leszek
WMDE-leszek created this task.WMDE-leszek added projects: Wikidata, Lexicographical data.Herald added a subscriber: Aklapper. TASK DESCRIPTIONCurrently users are only allowed to store a single lemma, or form representation for a given language/language variant code. In other words, I could have a

[Wikidata-bugs] [Maniphest] [Closed] T184173: WD Feature Evaluation Plans

2018-03-19 Thread Jan_Dittrich
Jan_Dittrich closed this task as "Invalid".Jan_Dittrich added a comment. Yes, I think we should close it and open particular ones for each feature.TASK DETAILhttps://phabricator.wikimedia.org/T184173EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:

[Wikidata-bugs] [Maniphest] [Commented On] T189143: "Grammatical features" string on a Form of a Lexeme is not translatable

2018-03-19 Thread gerritbot
gerritbot added a comment. Change 419444 merged by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@master] Make grammatical features translatable. https://gerrit.wikimedia.org/r/419444TASK DETAILhttps://phabricator.wikimedia.org/T189143EMAIL

[Wikidata-bugs] [Maniphest] [Created] T190022: Separate the CirrusSearch/Elastic-specific code from Wikibase code base

2018-03-19 Thread WMDE-leszek
WMDE-leszek created this task.WMDE-leszek added a project: Wikidata.Herald added a subscriber: Aklapper. TASK DESCRIPTIONIt does not seem desired to have knowledge on CirrusSearch/Elastic encoded in Wikibase. It definitely is valuable to allow Elastic/Cirrus-powered search in Wikibase, but

[Wikidata-bugs] [Maniphest] [Closed] T185761: Make i18n keys in WikibaseLexeme consistent

2018-03-19 Thread WMDE-leszek
WMDE-leszek closed this task as "Resolved".WMDE-leszek added a comment. It seems the migration has happened in https://gerrit.wikimedia.org/r/#/c/408921/. This in my eyes concludes the work on this task. Thanks all!TASK DETAILhttps://phabricator.wikimedia.org/T185761EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T186726: Security review WikibaseLexeme extension

2018-03-19 Thread WMDE-leszek
WMDE-leszek added a comment. Hi @Bawolff, it's me again. With https://gerrit.wikimedia.org/r/418715 would you be able to claim the security review was done?TASK DETAILhttps://phabricator.wikimedia.org/T186726EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: