BPirkle triaged this task as "Low" priority.
BPirkle moved this task from Incoming (Needs Triage) to Backlog (Triaged and
Ready) on the MW-Interfaces-Team board.
TASK DETAIL
https://phabricator.wikimedia.org/T353199
WORKBOARD
https://phabricator.wikimedia.org/project/board/69
BPirkle added subscribers: Tgr, BPirkle.
BPirkle added a comment.
The old image suggestions api (mediawiki/services/image-suggestion-api
<https://gerrit.wikimedia.org/g/mediawiki/services/image-suggestion-api>) is
unlikely to receive further development. The Jan 2023 update
BPirkle added a comment.
I was not previously familiar with mw-oauth-proxy. Here are some related
links for any other subscribers that may have a similar knowledge gap:
- https://gerrit.wikimedia.org/r/c/wikidata/query/rdf/+/605922
-
https://codesearch.wmcloud.org/search/?q=mw-oauth
BPirkle removed a project: Platform Engineering.
TASK DETAIL
https://phabricator.wikimedia.org/T284981
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: BPirkle
Cc: Ladsgroup, Addshore, Aklapper, Marostegui, joanna_borun, the0001,
Invadibot
BPirkle removed BPirkle as the assignee of this task.
BPirkle added a comment.
Removing myself as assignee because I am not currently working on this, and
am not scheduled to in the near future. I would not object to working on it on
the future if plans and priorities allow, but I do
BPirkle added subscribers: AMooney, BPirkle.
BPirkle removed a project: Platform Engineering.
BPirkle added a comment.
@AMooney to assign a reviewer
TASK DETAIL
https://phabricator.wikimedia.org/T45283
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences
BPirkle triaged this task as "Medium" priority.
BPirkle edited projects, added Platform Engineering Roadmap Decision Making;
removed Platform Engineering.
TASK DETAIL
https://phabricator.wikimedia.org/T270710
EMAIL PREFERENCES
https://phabricator.wikimedia.org/sett
BPirkle edited projects, added Platform Engineering; removed Platform Team
Workboards.
TASK DETAIL
https://phabricator.wikimedia.org/T275251
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: BPirkle
Cc: ovasileva, Addshore, Lydia_Pintscher, Aklapper
BPirkle moved this task from Inbox to Tracking/Watching on the Platform
Engineering board.
BPirkle added a comment.
No objections from Platform Team.
TASK DETAIL
https://phabricator.wikimedia.org/T276551
WORKBOARD
https://phabricator.wikimedia.org/project/board/3654/
EMAIL PREFERENCES
BPirkle moved this task from Discussing to Later on the Platform Team
Workboards (Clinic Duty Team) board.
BPirkle triaged this task as "Medium" priority.
TASK DETAIL
https://phabricator.wikimedia.org/T245989
WORKBOARD
https://phabricator.wikimedia.org/project/board/4149/
EMAIL P
BPirkle renamed this task from "RecetChanges query API fails with timeout when
asking for 5 RC redirects in on Wikidata" to "RecentChanges query API fails
with timeout when asking for 5 RC redirects in on Wikidata".
TASK DETAIL
https://phabricator.wikimedia.org/T24598
BPirkle created this task.
BPirkle added projects: Wikimedia-production-error, Wikidata-Campsite,
MediaWiki-extensions-WikibaseClient.
Restricted Application added a subscriber: Aklapper.
Restricted Application added a project: Wikidata.
TASK DESCRIPTION
Error
-
`MediaWiki version
BPirkle created this task.
BPirkle added projects: Wikimedia-production-error, Cognate, Wikidata-Campsite.
Restricted Application added a subscriber: Aklapper.
Restricted Application added a project: Wikidata.
TASK DESCRIPTION
Error
-
`MediaWiki version:` **`1.36.0-wmf.10
BPirkle created this task.
BPirkle added projects: Wikimedia-production-error, Wikidata-Campsite.
Restricted Application added a subscriber: Aklapper.
Restricted Application added a project: Wikidata.
TASK DESCRIPTION
name=Error message
[19f50cc3-e17e-41cb-9040-57dbd593711b]
/wiki
BPirkle triaged this task as "Medium" priority.
BPirkle edited projects, added Platform Team Workboards (Clinic Duty Team);
removed Platform Engineering.
TASK DETAIL
https://phabricator.wikimedia.org/T260179
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailp
BPirkle added a comment.
6 occurrences seen in logstash on 2020-07-29.
TASK DETAIL
https://phabricator.wikimedia.org/T93273
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: BPirkle
Cc: BPirkle, gerritbot, PokestarFan, Krinkle, mmodell, Addshore
BPirkle removed a project: Core Platform Team.
BPirkle added a comment.
Untagging CPT as this may not actually be an issue. Retag us if needed.
TASK DETAIL
https://phabricator.wikimedia.org/T255804
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences
BPirkle added a comment.
I've uploaded patches for all issues identified in this task. In an effort to
keep this task focused on ar_text_id and rev_text_id, I created several related
tasks for things that deserve attention and which are related to MCR, but not
directly to rev_text_id
BPirkle added a comment.
Unless I'm missing something, @Anomie already did the bulk of the work for
the first two (ApiQueryAllDeletedRevisions and ApiQueryDeletedRevisions) in
commit 07842be3
<https://phabricator.wikimedia.org/rMW07842be379ca3d4d0bc0608c217dd0e8cd7cbe4b>
as part of T
BPirkle added a comment.
I'm also seeing three few ungated ar_text_id references in core:
- ApiQueryAllDeletedRevisions::run()
- ApiQueryDeletedRevisions::run()
- ApiQueryDeletedrevs::execute()
These all use ar_text_id to load content by joining the text table. I'll
refactor
BPirkle added a comment.
In T198342#5118274 <https://phabricator.wikimedia.org/T198342#5118274>,
@daniel wrote:
> Ooops, too fast, there is an open patch needing review:
https://gerrit.wikimedia.org/r/c/mediawiki/core/+/500755
That patch is for T1983
BPirkle added a comment.
Per discussion in this task, I created new task T220450
<https://phabricator.wikimedia.org/T220450> for the additional Postgres changes
(searchindex table).
TASK DETAIL
https://phabricator.wikimedia.org/T198341
EMAIL PREFERENCES
BPirkle added a comment.
Usages found:
- includes/api/ApiQueryAllRevisions.php, line 85, in function run()
- includes/api/ApiQueryRevisions.php, line 162, in function run() (if
$this->fetchContent is true)
- maintenance/testCompression.php line 51
- tests/phpunit/inclu
BPirkle added a comment.
In T198341#5024626 <https://phabricator.wikimedia.org/T198341#5024626>,
@Anomie wrote:
> In T198341#5022412 <https://phabricator.wikimedia.org/T198341#5022412>,
@daniel wrote:
>
> > In T198341#5021347 <https://phabricator.wi
BPirkle added a comment.
In T198341#5025536 <https://phabricator.wikimedia.org/T198341#5025536>,
@daniel wrote:
> In T198341#5024626 <https://phabricator.wikimedia.org/T198341#5024626>,
@Anomie wrote:
>
> > Here's one place where Daniel and I differ: I'd
BPirkle added a comment.
In T198341#5022332 <https://phabricator.wikimedia.org/T198341#5022332>,
@daniel wrote:
> > includes/Revision/RevisionStore.php (I'll touch only getQueryInfo(). All
other references are either gated directly, or are in private functions with
all
BPirkle added a comment.
Thanks.
MessageCache.php was not listed in my previous comment, because I've already
incorporated Daniel's patch from June into my local codebase, but that'll be
part of the final change as well.
TASK DETAIL
https://phabricator.wikimedia.org/T198341
EMAIL
BPirkle added a subscriber: tstarling.
BPirkle added a comment.
Thank you. With that in mind, here's my current understanding. The list
below applies only to rev_text_id, not ar_text_id or text.old_id. When touching
code for rev_text_id, I'll also remove any references to the other two
BPirkle added a comment.
Thank you. Will ping Tim on that one when it is daylight for him.
One more question: rev_text_id is referenced in
tests/phpunit/includes/ActorMigrationTest.php function provideInsertRoundTrip,
which is a data provider for function testInsertRoundTrip
BPirkle added a comment.
Question on one occurrence of these fields: is the maintenance script
fixT22757.php still relevant?
TASK DETAIL
https://phabricator.wikimedia.org/T198341
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: BPirkle
Cc
BPirkle added a comment.
Task description refers to "RevisionStore::newRevisionRecordFromRow()". Should that be "RevisionStore::newRevisionFromRow()"?TASK DETAILhttps://phabricator.wikimedia.org/T198341EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/pa
BPirkle claimed this task.
TASK DETAILhttps://phabricator.wikimedia.org/T198341EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: BPirkleCc: gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, Aklapper, daniel, EvanProdromou, CucyNoiD, Nandana, NebulousIris
BPirkle added a comment.
I was, however, able to claim T198341. I'll start there.TASK DETAILhttps://phabricator.wikimedia.org/T198557EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: BPirkleCc: BPirkle, Fjalapeno, CCicalese_WMF, Aklapper, daniel, holger.knust
BPirkle added a comment.
I'm happy to, but it appears that I cannot edit or claim the task.TASK DETAILhttps://phabricator.wikimedia.org/T198557EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: BPirkleCc: BPirkle, Fjalapeno, CCicalese_WMF, Aklapper, daniel
BPirkle added a comment.
This looks more promising:
if ( is_array( $postData ) ) {
$this->guzzleOptions['form_params'] = $postData;
} else {
$this->guzzleOptions['body'] = $postData;
}
Per http://docs.guzzlephp.org/en/stable/quickstart.html, Guzzle will automatical
BPirkle added a comment.
Reproduced the exception locally using trivial test data:
$params = [ 'foo' => 'bar' ];
$response = Http::post(
'http://www.example.net',
[ 'postData' => $params ]
);
Then confirmed the exception disappeared per the suggestion from stack overflow, by
BPirkle added a comment.
GuzzleHttpRequest.php line 94, we are indeed setting the 'body' field and trusting that $postData was happily passed to the constructor by calling code. Fiddling...TASK DETAILhttps://phabricator.wikimedia.org/T211806EMAIL PREFERENCEShttps://phabricator.wikimedia.org
BPirkle added a comment.
Guzzle has been added to the codebase and made available through the new GuzzleHttpRequest class, per T202110.TASK DETAILhttps://phabricator.wikimedia.org/T110022EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: BPirkleCc: MGChecker
BPirkle closed subtask T203424: Replace the WikiExporter backup dump streaming mode with batched queries as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T198706EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: daniel, BPirkleCc:
BPirkle added a comment.
I’m also a soft lean to Guzzle. It seems more active recently than most of the alternatives, suitable to our needs, and generally popular. I hate to overweigh “popularity” as a metric, but in the case of open source, momentum doesn’t hurt. It is also much easier
BPirkle added a comment.
Localization questions aside, it seemed that in 2016 (on T139169), @Krinkle preferred Requests, while @Tgr preferred Guzzle. Do each of you still feel the same, and are there any additional possibilities that you've become aware of since then?TASK DETAILhttps
BPirkle added a comment.
I wish we could map by exception class, but it seems challenging to do that in a useful way. Looking at the two libraries that have been mentioned:
Guzzle tends to throw generic exception classes. The most popular appear to be:
InvalidArgumentException (49 occurrences
BPirkle added a comment.
If we do care about localization, there's also the possibility of wrapping an external library in custom code that does support localization. Current http-* entries in en.json are fairly generic and could continue to be so. The external library would handle the details
BPirkle added a comment.
This task has been around for awhile, and related discussion and action has since occurred elsewhere. To summarize from this task and from T139169, T137926, and T139170:
we would like to make curl optional (with a suitable warning)
we made MultiHttpClient work
BPirkle closed subtask T139169: Add non-parallel MultiHttpClient fallback for environments that don't have curl available as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T110022EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: BPirkleCc:
45 matches
Mail list logo
