gerritbot added a comment.
Change 475254 merged by Smalyshev:
[wikidata/query/gui-deploy@production] Merging from b1b825c40771891b8cb47dc6a3ca838d182efa70:
https://gerrit.wikimedia.org/r/475254TASK DETAILhttps://phabricator.wikimedia.org/T168655EMAIL
gerritbot added a comment.
Change 472141 merged by jenkins-bot:
[wikidata/query/gui@master] Refactor editor placeholder translation setup
https://gerrit.wikimedia.org/r/472141TASK DETAILhttps://phabricator.wikimedia.org/T168655EMAIL
gerritbot added a comment.
Change 472141 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[wikidata/query/gui@master] Refactor editor placeholder translation setup
https://gerrit.wikimedia.org/r/472141TASK
gerritbot added a comment.
Change 422141 abandoned by Rammanojpotla:
Fix translation of placeholder in Query Service UI
Reason:
solved at https://gerrit.wikimedia.org/r/#/c/422167/
https://gerrit.wikimedia.org/r/422141TASK DETAILhttps://phabricator.wikimedia.org/T168655EMAIL
gerritbot added a comment.
Change 422364 merged by Smalyshev:
[wikidata/query/gui-deploy@production] Merging from a558b244c967f143f6bf7b89625ee57f8a9fdf39:
https://gerrit.wikimedia.org/r/422364TASK DETAILhttps://phabricator.wikimedia.org/T168655EMAIL
gerritbot added a comment.
Change 422167 merged by jenkins-bot:
[wikidata/query/gui@master] Set placeholder in CodeMirror options
https://gerrit.wikimedia.org/r/422167TASK DETAILhttps://phabricator.wikimedia.org/T168655EMAIL
gerritbot added a comment.
Change 422167 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[wikidata/query/gui@master] Set placeholder in CodeMirror options
https://gerrit.wikimedia.org/r/422167TASK
Lucas_Werkmeister_WMDE added a comment.
Locally seTiemout() is translating to other languages but if I click my mouse pointer at any other position except the text-editor the language is getting reverted back to english (whatever language presently chosen )
Okay, but that’s a different problem –
Rammanojpotla added a comment.
I guess the problem here is there is no translation of placeholder to other languages. And as per your above comment
for this task is to replace the hacky setTimeout( …, 1000 ) with a proper hook where jquery.i18n informs us when it’s done internationalizing
Lucas_Werkmeister_WMDE added a comment.
Sorry, I’m not sure what problem you’re trying to solve now… the problem described by this task should be resolved now. It’s not a nice solution, but as far as I understand a nicer solution is only possible with some changes to jquery.i18n. But if I set the
gerritbot added a comment.
Change 422141 had a related patch set uploaded (by Rammanojpotla; owner: Rammanoj):
[wikidata/query/gui@master] Fix translation of placeholder in Query Service UI
https://gerrit.wikimedia.org/r/422141TASK DETAILhttps://phabricator.wikimedia.org/T168655EMAIL
Rammanojpotla added a comment.
Yes, using setIntravel( ) instead of setTimeout( ) worked fine on my localhost. I guess this should work right?TASK DETAILhttps://phabricator.wikimedia.org/T168655EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: RammanojpotlaCc:
Lucas_Werkmeister_WMDE added a comment.
No, the code that you’re quoting is actually supposed to solve this issue :) I guess we forgot to link Ib296d9065f to this task.
So as far as I can tell, the only thing missing for this task is to replace the hacky setTimeout( …, 1000 ) with a proper hook
Rammanojpotla added a comment.
@Lucas_Werkmeister_WMDE the code in the tag is getting updated whenever language is changed but it is being added a style of display: none so it is not getting displayed as per the picture below
F14920171: quer.png
I think the problem is at the following code in
Lucas_Werkmeister_WMDE added a comment.
Do you think it would be a good idea to add an event to jquery.i18n that is triggered whenever an element’s text or attribute is changed? That might allow us to fix this by propagating the change to CodeMirror when it happens.TASK
Jonas added a comment.
Yes, can confirm!
It seems i18n changes the text, but CodeMirror doesn't update:
placeholder="(Escribe una consulta SPARQL o elige una consulta de ejemplo)"TASK DETAILhttps://phabricator.wikimedia.org/T168655EMAIL
16 matches
Mail list logo
