gerritbot added a comment.
Change 420236 merged by jenkins-bot:
[wikidata/query/gui@master] Fix text and image name truncation in image grid
https://gerrit.wikimedia.org/r/420236TASK DETAILhttps://phabricator.wikimedia.org/T189146EMAIL
Rammanojpotla added a comment.
Thanks @Lucas_Werkmeister_WMDE The present change works fine locally. Please specify if there is any issue with the change at https://gerrit.wikimedia.org/r/#/c/420236/ ?TASK DETAILhttps://phabricator.wikimedia.org/T189146EMAIL
Lucas_Werkmeister_WMDE added a comment.
Oh, I didn’t realize we already included the text for some kinds of values (see FormatterHelper.formatValue). In that case, I guess that function should be edited to add the text in more cases (e. g. for plain text datatypes, not just if xml:lang is set but
Rammanojpotla added a comment.
@Lucas_Werkmeister_WMDE But in some cases such as
Douglas Noel Adams
this has to be ignored, as appending to the title gives the following result in title
birthName: Douglas Noel Adams@en-gb:Douglas Noel Adams
This lead to repetition of text two times. So this
Lucas_Werkmeister_WMDE added a comment.
After a short discussion with Jonas – the easiest solution would probably be to integrate this into the title attribute. Currently, we set the title to just the variable name; instead, we could also append the text content of the variable after the variable
Lucas_Werkmeister_WMDE added a comment.
Sorry, I’m still not quite happy with this… why is the text now hidden behind this “view text” link? I don’t think that’s necessary – by default, it should still show the text (truncated if it’s too long, as before), but with the popover added when the link
Rammanojpotla added a comment.
@Lucas_Werkmeister_WMDE Presently, In the above change I am trying to display the text inform of a list in a popover. So, whenever a "View list" is hovered pop over displays. Is there any more changes to be done here?TASK
Rammanojpotla added a comment.
@Lucas_Werkmeister_WMDE made few changes locally finally used popover instead of the tooltip for better appearance of text. For single text item, it looks the following way on hover
F15983578: one(1).png
For multi-text items, it looks the following way on hover
gerritbot added a comment.
Change 420247 abandoned by Rammanojpotla:
Fix text truncation in image grid
https://gerrit.wikimedia.org/r/420247TASK DETAILhttps://phabricator.wikimedia.org/T189146EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc:
gerritbot added a comment.
Change 420247 had a related patch set uploaded (by Rammanojpotla; owner: Rammanoj):
[wikidata/query/gui@master] Fix text truncation in image grid
https://gerrit.wikimedia.org/r/420247TASK DETAILhttps://phabricator.wikimedia.org/T189146EMAIL
gerritbot added a comment.
Change 420236 had a related patch set uploaded (by Rammanojpotla; owner: Rammanoj):
[wikidata/query/gui@master] Fix text truncation in image grid
https://gerrit.wikimedia.org/r/420236TASK DETAILhttps://phabricator.wikimedia.org/T189146EMAIL
11 matches
Mail list logo
