[Wikidata-bugs] [Maniphest] T317682: Make new Vector search navigate to search result URL when selecting search result using keyboard

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.12; 2022-11-28); removed MW-1.40-notes (1.40.0-wmf.10; 2022-11-14). TASK DETAIL https://phabricator.wikimedia.org/T317682 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] T317682: Make new Vector search navigate to search result URL when selecting search result using keyboard

Lucas_Werkmeister_WMDE closed this task as "Resolved". Lucas_Werkmeister_WMDE moved this task from Parents/Waiting to Our work done on the Wikidata Dev Team (Sprint-∞) board. Lucas_Werkmeister_WMDE claimed this task. Lucas_Werkmeister_WMDE added a comment. Thanks! I think we can close this

[Wikidata-bugs] [Maniphest] T317682: Make new Vector search navigate to search result URL when selecting search result using keyboard

gerritbot added a comment. Change 855597 **merged** by jenkins-bot: [mediawiki/core@master] Treat search result suggestions like clicks (v2) https://gerrit.wikimedia.org/r/855597 TASK DETAIL https://phabricator.wikimedia.org/T317682 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T317682: Make new Vector search navigate to search result URL when selecting search result using keyboard

AnneT added a comment. @Lucas_Werkmeister_WMDE FYI we've just merged the new release of Codex into core, which includes your change and will ride the train next week! TASK DETAIL https://phabricator.wikimedia.org/T317682 EMAIL

[Wikidata-bugs] [Maniphest] T317682: Make new Vector search navigate to search result URL when selecting search result using keyboard

gerritbot added a comment. Change 859597 **merged** by jenkins-bot: [mediawiki/core@master] Update Codex from v0.2.2 to v0.3.0 https://gerrit.wikimedia.org/r/859597 TASK DETAIL https://phabricator.wikimedia.org/T317682 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T317682: Make new Vector search navigate to search result URL when selecting search result using keyboard

gerritbot added a comment. Change 859597 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich): [mediawiki/core@master] Update Codex from v0.2.2 to v0.3.0 https://gerrit.wikimedia.org/r/859597 TASK DETAIL https://phabricator.wikimedia.org/T317682 EMAIL

[Wikidata-bugs] [Maniphest] T317682: Make new Vector search navigate to search result URL when selecting search result using keyboard

Lucas_Werkmeister_WMDE added a comment. The revert is at https://gerrit.wikimedia.org/r/c/mediawiki/core/+/855596 (already merged) – I forgot to include the task ID in the commit message. The revert-revert is also uploaded (“v2” just above). TASK DETAIL

[Wikidata-bugs] [Maniphest] T317682: Make new Vector search navigate to search result URL when selecting search result using keyboard

gerritbot added a comment. Change 855597 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/core@master] Treat search result suggestions like clicks (v2) https://gerrit.wikimedia.org/r/855597 TASK DETAIL

[Wikidata-bugs] [Maniphest] T317682: Make new Vector search navigate to search result URL when selecting search result using keyboard

Lucas_Werkmeister_WMDE added a comment. Alright, let’s do that then :) TASK DETAIL https://phabricator.wikimedia.org/T317682 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: mpopov, cchen, EBernhardson, ItamarWMDE,

[Wikidata-bugs] [Maniphest] T317682: Make new Vector search navigate to search result URL when selecting search result using keyboard

phuedx added a comment. In T317682#8386885 , @Lucas_Werkmeister_WMDE wrote: > I think that’s a question for @phuedx – is it okay if the tracking is out of sync for two trains? > > If not, I guess we can revert the core change for

[Wikidata-bugs] [Maniphest] T317682: Make new Vector search navigate to search result URL when selecting search result using keyboard

Lucas_Werkmeister_WMDE added a comment. I think that’s a question for @phuedx – is it okay if the tracking is out of sync for two trains? If not, I guess we can revert the core change for now, and reapply it later. (I think this would be a case where self-merging

[Wikidata-bugs] [Maniphest] T317682: Make new Vector search navigate to search result URL when selecting search result using keyboard

AnneT added a comment. @Lucas_Werkmeister_WMDE our next scheduled Codex release is Tuesday, November 22nd, so it would ride the train the following week. Is that acceptable, or is this needed sooner? TASK DETAIL https://phabricator.wikimedia.org/T317682 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T317682: Make new Vector search navigate to search result URL when selecting search result using keyboard

Lucas_Werkmeister_WMDE added a comment. Hm, does that mean we need a new Codex release before the branch cut on Monday now? TASK DETAIL https://phabricator.wikimedia.org/T317682 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] T317682: Make new Vector search navigate to search result URL when selecting search result using keyboard

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.10; 2022-11-14); removed MW-1.40-notes (1.40.0-wmf.8; 2022-10-31). TASK DETAIL https://phabricator.wikimedia.org/T317682 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] T317682: Make new Vector search navigate to search result URL when selecting search result using keyboard

gerritbot added a comment. Change 854532 **merged** by jenkins-bot: [mediawiki/core@master] Treat search result suggestions like clicks https://gerrit.wikimedia.org/r/854532 TASK DETAIL https://phabricator.wikimedia.org/T317682 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T317682: Make new Vector search navigate to search result URL when selecting search result using keyboard

Lucas_Werkmeister_WMDE added a comment. With the Codex change merged (thanks!), I guess we will want to update to the next Codex release (whenever that happens) during the same train cycle where we also merge the MediaWiki core change, to keep the tracking in sync between the two kinds of

[Wikidata-bugs] [Maniphest] T317682: Make new Vector search navigate to search result URL when selecting search result using keyboard

gerritbot added a comment. Change 854049 **merged** by jenkins-bot: [design/codex@main] Treat submits with selected search result like clicks https://gerrit.wikimedia.org/r/854049 TASK DETAIL https://phabricator.wikimedia.org/T317682 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T317682: Make new Vector search navigate to search result URL when selecting search result using keyboard

phuedx added a comment. In T317682#8379405 , @Lucas_Werkmeister_WMDE wrote: > If I understand @phuedx in T317682#8254889 correctly, the part that needs to change is the code that

[Wikidata-bugs] [Maniphest] T317682: Make new Vector search navigate to search result URL when selecting search result using keyboard

Lucas_Werkmeister_WMDE added a comment. Uploaded a change for `mediawiki.searchSuggest` above; I went with actually following the URL after all, since that seemed easier to implement than submitting the form but not tracking a form submit, given how the code is arranged. TASK DETAIL

[Wikidata-bugs] [Maniphest] T317682: Make new Vector search navigate to search result URL when selecting search result using keyboard

gerritbot added a comment. Change 854532 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/core@master] Treat search result suggestions like clicks https://gerrit.wikimedia.org/r/854532 TASK DETAIL

[Wikidata-bugs] [Maniphest] T317682: Make new Vector search navigate to search result URL when selecting search result using keyboard

Lucas_Werkmeister_WMDE added a comment. In T317682#8329113 , @Lucas_Werkmeister_WMDE wrote: > If I’m not mistaken, the “old search” side of this tracking happens in this code

[Wikidata-bugs] [Maniphest] T317682: Make new Vector search navigate to search result URL when selecting search result using keyboard

Lucas_Werkmeister_WMDE added a comment. In T317682#8249254 , @AnneT wrote: > We could potentially fix this by updating the `onSubmit()` handler in CdxTypeaheadSearch to check if there is a currently highlighted item and, if so, do the

[Wikidata-bugs] [Maniphest] T317682: Make new Vector search navigate to search result URL when selecting search result using keyboard

gerritbot added a comment. Change 854049 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [design/codex@main] Treat submits with selected search result like clicks https://gerrit.wikimedia.org/r/854049 TASK DETAIL

[Wikidata-bugs] [Maniphest] T317682: Make new Vector search navigate to search result URL when selecting search result using keyboard

Lucas_Werkmeister_WMDE changed the task status from "Stalled" to "Open". Lucas_Werkmeister_WMDE added a comment. Unstalling because I think we can continue working on this, though we’ll need to coordinate merging / deployment with @cchen according to T317682#8332450

[Wikidata-bugs] [Maniphest] T317682: Make new Vector search navigate to search result URL when selecting search result using keyboard

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.8; 2022-10-31); removed MW-1.40-notes (1.40.0-wmf.7; 2022-10-24). TASK DETAIL https://phabricator.wikimedia.org/T317682 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] T317682: Make new Vector search navigate to search result URL when selecting search result using keyboard

gerritbot added a comment. Change 845463 **merged** by jenkins-bot: [mediawiki/skins/Vector@master] search: Make wprov value match non-Vue behavior https://gerrit.wikimedia.org/r/845463 TASK DETAIL https://phabricator.wikimedia.org/T317682 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T317682: Make new Vector search navigate to search result URL when selecting search result using keyboard

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.7; 2022-10-24). TASK DETAIL https://phabricator.wikimedia.org/T317682 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ReleaseTaggerBot Cc: mpopov, cchen, EBernhardson, ItamarWMDE, dcausse,

[Wikidata-bugs] [Maniphest] T317682: Make new Vector search navigate to search result URL when selecting search result using keyboard

gerritbot added a comment. Change 837133 **merged** by jenkins-bot: [mediawiki/skins/Vector@master] search: Add wprov to result URLs https://gerrit.wikimedia.org/r/837133 TASK DETAIL https://phabricator.wikimedia.org/T317682 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T317682: Make new Vector search navigate to search result URL when selecting search result using keyboard

gerritbot added a comment. Change 845463 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/skins/Vector@master] search: Make wprov value match non-Vue behavior https://gerrit.wikimedia.org/r/845463 TASK DETAIL

[Wikidata-bugs] [Maniphest] T317682: Make new Vector search navigate to search result URL when selecting search result using keyboard

EBernhardson added a comment. Poking over the history and the related tests. There are tests in `tests/browser/SearchSatisfactionTests.php` that expect to log a -1 as the position when the user submits their own query and not something provided by the autocomplete. This seems to have been

[Wikidata-bugs] [Maniphest] T317682: Make new Vector search navigate to search result URL when selecting search result using keyboard

Lucas_Werkmeister_WMDE added a comment. In T317682#8332450 , @phuedx wrote: >> I also notice that the old-style search generates URLs like `=acrw1_0`, `=acrw1_1`, etc., while the new search generates `=acrw10`, `=acrw11`, etc. – is the

[Wikidata-bugs] [Maniphest] T317682: Make new Vector search navigate to search result URL when selecting search result using keyboard

phuedx added subscribers: cchen, mpopov. phuedx added a comment. In T317682#8329113 , @Lucas_Werkmeister_WMDE wrote: > @phuedx can you maybe reach out to those teams (and maybe also ask about decommissioning)? I don’t think I’m in the

[Wikidata-bugs] [Maniphest] T317682: Make new Vector search navigate to search result URL when selecting search result using keyboard

Lucas_Werkmeister_WMDE added a comment. In T317682#8285551 , @phuedx wrote: > In T317682#8285303 , @Jdlrobson wrote: > >>> Are we also changing MediaWiki searchSuggest behavior

[Wikidata-bugs] [Maniphest] T317682: Make new Vector search navigate to search result URL when selecting search result using keyboard

Lucas_Werkmeister_WMDE merged a task: T317681: Make new Vector search navigate to item search results on Wikidata. Lucas_Werkmeister_WMDE added a subscriber: EBernhardson. TASK DETAIL https://phabricator.wikimedia.org/T317682 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T317682: Make new Vector search navigate to search result URL when selecting search result using keyboard

Michael added a comment. > There's just one reference to any of the instrument's provenance parameters outside of the instrument (see https://codesearch.wmcloud.org/search/?q=(srpw1%7Cacrw1%7Cdym1%7Cdymr1%7Cdymo1) ), which is in the WD/WikidataAdHocAnalytics repo I looked into this,

[Wikidata-bugs] [Maniphest] T317682: Make new Vector search navigate to search result URL when selecting search result using keyboard

karapayneWMDE edited projects, added Wikidata Dev Team (Sprint-∞); removed Wikidata Dev Team. TASK DETAIL https://phabricator.wikimedia.org/T317682 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: karapayneWMDE Cc: ItamarWMDE, dcausse, Gehel,

[Wikidata-bugs] [Maniphest] T317682: Make new Vector search navigate to search result URL when selecting search result using keyboard

phuedx added a comment. In T317682#8285303 , @Jdlrobson wrote: >> Are we also changing MediaWiki searchSuggest behavior (“legacy search”) to do the same thing? > > I don't know who would be the right person to ask. I think legacy

[Wikidata-bugs] [Maniphest] T317682: Make new Vector search navigate to search result URL when selecting search result using keyboard

Jdlrobson added a comment. > Are we changing Codex TypeaheadSearch behavior to navigate to the result’s URL on Enter, as outlined in T317682#8249254 ? (I assume yes, but I don’t think we’ve had a clear statement on this yet.) I think

[Wikidata-bugs] [Maniphest] T317682: Make new Vector search navigate to search result URL when selecting search result using keyboard

Lucas_Werkmeister_WMDE changed the task status from "Open" to "Stalled". Lucas_Werkmeister_WMDE added a comment. Marking this task stalled for further work, at least from the WMDE side, until we’ve decided: - Are we changing Codex TypeaheadSearch behavior to navigate to the result’s URL

[Wikidata-bugs] [Maniphest] T317682: Make new Vector search navigate to search result URL when selecting search result using keyboard

karapayneWMDE moved this task from Sprint-∞ to Unified prioritized backlog on the Wikidata Dev Team board. karapayneWMDE edited projects, added Wikidata Dev Team; removed Wikidata Dev Team (Sprint-∞). TASK DETAIL https://phabricator.wikimedia.org/T317682 WORKBOARD

[Wikidata-bugs] [Maniphest] T317682: Make new Vector search navigate to search result URL when selecting search result using keyboard

Lucas_Werkmeister_WMDE added a comment. In T317682#8251384 , @Jdlrobson wrote: > I think the lack of wprov on keyboard is likely a bug. I uploaded a change to fix that, as a start for working on this task. (For the rest, I’m still

[Wikidata-bugs] [Maniphest] T317682: Make new Vector search navigate to search result URL when selecting search result using keyboard

gerritbot added a comment. Change 837133 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/skins/Vector@master] search: Add wprov to result URLs https://gerrit.wikimedia.org/r/837133 TASK DETAIL

[Wikidata-bugs] [Maniphest] T317682: Make new Vector search navigate to search result URL when selecting search result using keyboard

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T317682 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: ItamarWMDE, dcausse, Gehel, Jdlrobson, Catrope, AnneT, jhsoby, Aklapper, Michael,

[Wikidata-bugs] [Maniphest] T317682: Make new Vector search navigate to search result URL when selecting search result using keyboard

Lucas_Werkmeister_WMDE added a project: Wikidata Dev Team (Sprint-∞). TASK DETAIL https://phabricator.wikimedia.org/T317682 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: ItamarWMDE, dcausse, Gehel, Jdlrobson, Catrope,

[Wikidata-bugs] [Maniphest] T317682: Make new Vector search navigate to search result URL when selecting search result using keyboard

Lucas_Werkmeister_WMDE added a comment. I also notice that the old-style search generates URLs like `=acrw1_0`, `=acrw1_1`, etc., while the new search generates `=acrw10`, `=acrw11`, etc. – is the difference intentional? TASK DETAIL https://phabricator.wikimedia.org/T317682 EMAIL

[Wikidata-bugs] [Maniphest] T317682: Make new Vector search navigate to search result URL when selecting search result using keyboard

ItamarWMDE removed a project: Wikidata Dev Team. TASK DETAIL https://phabricator.wikimedia.org/T317682 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ItamarWMDE Cc: ItamarWMDE, dcausse, Gehel, Jdlrobson, Catrope, AnneT, jhsoby, Aklapper, Michael,

[Wikidata-bugs] [Maniphest] T317682: Make new Vector search navigate to search result URL when selecting search result using keyboard

Lucas_Werkmeister_WMDE added a comment. Hm, but the old-style search (`resources/src/mediaWiki.searchSuggest/searchSuggest.js` in MediaWiki core) has the same behavior of submitting the form on Enter but following the link on click. Does that mean we’re changing the behavior there as well,

[Wikidata-bugs] [Maniphest] T317682: Make new Vector search navigate to search result URL when selecting search result using keyboard

phuedx added a comment. In T317682#8251384 , @Jdlrobson wrote: > Regarding the instrumentation, tracking these as a submit event instead of a click also seems a bug, so that sounds fine to me. Seconded! However, it is consistent

[Wikidata-bugs] [Maniphest] T317682: Make new Vector search navigate to search result URL when selecting search result using keyboard

AnneT added a comment. > tracking these as a submit event instead of a click also seems a bug +1, thanks for weighing in! TASK DETAIL https://phabricator.wikimedia.org/T317682 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AnneT Cc:

[Wikidata-bugs] [Maniphest] T317682: Make new Vector search navigate to search result URL when selecting search result using keyboard

Jdlrobson added a comment. I think the lack of wprov on keyboard is likely a bug. I think it's fine for these behaviours to be consistent and the conditional behaviour of onSubmit handler seems fine. Regarding the instrumentation, tracking these as a submit event instead of a click also

[Wikidata-bugs] [Maniphest] T317682: Make new Vector search navigate to search result URL when selecting search result using keyboard

AnneT added a comment. We could potentially fix this by updating the `onSubmit()` handler in CdxTypeaheadSearch to check if there is a currently highlighted item and, if so, do the following: - `preventDefault()` on the submit event - run the `onSearchResultClick()` method to emit the

[Wikidata-bugs] [Maniphest] T317682: Make new Vector search navigate to search result URL when selecting search result using keyboard

Lucas_Werkmeister_WMDE added a comment. In T317682#8241142 , @Jdlrobson wrote: > Perhaps one of the existing events could be used to modify the input value? https://doc.wikimedia.org/codex/main/components/typeahead-search.html#events

[Wikidata-bugs] [Maniphest] T317682: Make new Vector search navigate to search result URL when selecting search result using keyboard

Jdlrobson added projects: Design-Systems-Team, Codex. Jdlrobson added a comment. Thanks for explaining. This is likely an issue with Codex then. Tagging appropriately. I don't have any concerns with the modification you are provided - we could even make it configurable if needed.

[Wikidata-bugs] [Maniphest] T317682: Make new Vector search navigate to search result URL when selecting search result using keyboard

Lucas_Werkmeister_WMDE added a comment. I don’t think `wgVectorSearchUrlGenerator` solves our problem. The URL generator is used to generate URLs in the default `restSearchClient`, but we’re overriding the whole `wgVectorSearchClient`, so we can put whatever URLs we want into the search

[Wikidata-bugs] [Maniphest] T317682: Make new Vector search navigate to search result URL when selecting search result using keyboard

Jdlrobson added a comment. > However, this would make a big difference on Wikidata. We would configure the Wikidata search client (wgVectorSearchClient override) to directly return item page URLs, bypassing Special:Search – because searching for the label of an item will not redirect to

[Wikidata-bugs] [Maniphest] T317682: Make new Vector search navigate to search result URL when selecting search result using keyboard

Lucas_Werkmeister_WMDE added a project: Discovery-Search. Lucas_Werkmeister_WMDE added subscribers: Gehel, dcausse. Lucas_Werkmeister_WMDE added a comment. (Feel free to unsubscribe if I misjudged any of the CCs, my brain is a bit fried from trying to understand all this ) TASK DETAIL

[Wikidata-bugs] [Maniphest] T317682: Make new Vector search navigate to search result URL when selecting search result using keyboard

Lucas_Werkmeister_WMDE created this task. Lucas_Werkmeister_WMDE added projects: Wikidata, wmde-wikidata-tech, Wikidata Dev Team, MediaWiki-Interface (autocomplete search), Desktop Improvements. TASK DESCRIPTION This task proposes a possible solution for the Wikidata-specific task T317681