[Wikidata-bugs] [Maniphest] T327062: Show entity labels in parsed edit summaries in API requests as well

Lucas_Werkmeister_WMDE closed subtask T335107: Remove temporary feature flag for Entity Labels in parsed edit summaries in API requests again as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T327062 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T327062: Show entity labels in parsed edit summaries in API requests as well

Lucas_Werkmeister_WMDE changed the status of subtask T335107: Remove temporary feature flag for Entity Labels in parsed edit summaries in API requests again from Stalled to Open. TASK DETAIL https://phabricator.wikimedia.org/T327062 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T327062: Show entity labels in parsed edit summaries in API requests as well

Arian_Bozorg closed this task as "Resolved". Arian_Bozorg moved this task from Product Verification to Our work done on the Wikidata Dev Team (Sprint-∞) board. Arian_Bozorg added a comment. Looks good! Thanks everyone :) TASK DETAIL https://phabricator.wikimedia.org/T327062 WORKBOARD

[Wikidata-bugs] [Maniphest] T327062: Show entity labels in parsed edit summaries in API requests as well

Arian_Bozorg closed subtask T335099: Wikidata: enable entity labels in parsed edit summaries in API requests as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T327062 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael, Arian_Bozorg Cc:

[Wikidata-bugs] [Maniphest] T327062: Show entity labels in parsed edit summaries in API requests as well

Lucas_Werkmeister_WMDE changed the status of subtask T335107: Remove temporary feature flag for Entity Labels in parsed edit summaries in API requests again from Open to Stalled. TASK DETAIL https://phabricator.wikimedia.org/T327062 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T327062: Show entity labels in parsed edit summaries in API requests as well

Lucas_Werkmeister_WMDE changed the status of subtask T335107: Remove temporary feature flag for Entity Labels in parsed edit summaries in API requests again from Stalled to Open. TASK DETAIL https://phabricator.wikimedia.org/T327062 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T327062: Show entity labels in parsed edit summaries in API requests as well

Lucas_Werkmeister_WMDE added a comment. Seems to work fine in SpeedPatrolling , for example: F37070417: image.png TASK DETAIL https://phabricator.wikimedia.org/T327062 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T327062: Show entity labels in parsed edit summaries in API requests as well

hoo moved this task from Peer Review to Product Verification on the Wikidata Dev Team (Sprint-∞) board. hoo added a comment. AFAICT this is done (and the remaining open subtask is also in verification already). TASK DETAIL https://phabricator.wikimedia.org/T327062 WORKBOARD

[Wikidata-bugs] [Maniphest] T327062: Show entity labels in parsed edit summaries in API requests as well

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.10; 2023-05-23); removed MW-1.41-notes (1.41.0-wmf.9; 2023-05-15). TASK DETAIL https://phabricator.wikimedia.org/T327062 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael,

[Wikidata-bugs] [Maniphest] T327062: Show entity labels in parsed edit summaries in API requests as well

karapayneWMDE closed subtask T335098: Testwikidata: enable entity labels in parsed edit summaries in API requests as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T327062 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael,

[Wikidata-bugs] [Maniphest] T327062: Show entity labels in parsed edit summaries in API requests as well

ItamarWMDE changed the status of subtask T335099: Wikidata: enable entity labels in parsed edit summaries in API requests from Stalled to Open. TASK DETAIL https://phabricator.wikimedia.org/T327062 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] T327062: Show entity labels in parsed edit summaries in API requests as well

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.9; 2023-05-15). TASK DETAIL https://phabricator.wikimedia.org/T327062 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael, ReleaseTaggerBot Cc: Arian_Bozorg, Pintoch, Bene, ItamarWMDE,

[Wikidata-bugs] [Maniphest] T327062: Show entity labels in parsed edit summaries in API requests as well

Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T327062 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael, Maintenance_bot Cc: Arian_Bozorg, Pintoch, Bene, ItamarWMDE, HasanAkgun_WMDE,

[Wikidata-bugs] [Maniphest] T327062: Show entity labels in parsed edit summaries in API requests as well

gerritbot added a comment. Change 916420 **merged** by jenkins-bot: [mediawiki/core@master] Fix missing Entity Labels in list=recentchanges https://gerrit.wikimedia.org/r/916420 TASK DETAIL https://phabricator.wikimedia.org/T327062 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T327062: Show entity labels in parsed edit summaries in API requests as well

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T327062 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael, gerritbot Cc: Arian_Bozorg, Pintoch, Bene, ItamarWMDE, HasanAkgun_WMDE, Lydia_Pintscher,

[Wikidata-bugs] [Maniphest] T327062: Show entity labels in parsed edit summaries in API requests as well

gerritbot added a comment. Change 916420 had a related patch set uploaded (by Michael Große; author: Michael Große): [mediawiki/core@master] Fix missing Entity Labels in list=recentchanges https://gerrit.wikimedia.org/r/916420 TASK DETAIL https://phabricator.wikimedia.org/T327062

[Wikidata-bugs] [Maniphest] T327062: Show entity labels in parsed edit summaries in API requests as well

Michael moved this task from Peer Review to Doing on the Wikidata Dev Team (Sprint-∞) board. Michael added a comment. Let's see if that is as straight-forward to fix as I assume that it is. TASK DETAIL https://phabricator.wikimedia.org/T327062 WORKBOARD

[Wikidata-bugs] [Maniphest] T327062: Show entity labels in parsed edit summaries in API requests as well

Lydia_Pintscher added a comment. Let's do it. TASK DETAIL https://phabricator.wikimedia.org/T327062 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael, Lydia_Pintscher Cc: Arian_Bozorg, Pintoch, Bene, ItamarWMDE, HasanAkgun_WMDE,

[Wikidata-bugs] [Maniphest] T327062: Show entity labels in parsed edit summaries in API requests as well

Lucas_Werkmeister_WMDE added a comment. Thanks for checking! In that case I agree it sounds like a bug (probably my fault, when I introduced `renderForComment` and missed one of the comment formatter services?) that we should probably fix. (But also happy to have a product opinion on this.)

[Wikidata-bugs] [Maniphest] T327062: Show entity labels in parsed edit summaries in API requests as well

Pintoch added a comment. If it's not too difficult, it would be helpful to have that behavior in `list=recentchanges` too, typically for tools which do recent changes polling. (EditGroups sadly uses the EventStreams service

[Wikidata-bugs] [Maniphest] T327062: Show entity labels in parsed edit summaries in API requests as well

Michael added a comment. I looked into it a tiny bit, and it turns out the cause is that there are two different services in play. `prop=revisions` uses `CommentFormatter` in https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/refs/heads/master/includes/ServiceWiring.php#413

[Wikidata-bugs] [Maniphest] T327062: Show entity labels in parsed edit summaries in API requests as well

Michael added a subscriber: Arian_Bozorg. Michael added a comment. Happy to make a difference  --- About this not working with `list=recentchanges`, strange indeed, but maybe also good, because `list=recentchanges` was not mentioned in the announcement? Or is the behavior actually

[Wikidata-bugs] [Maniphest] T327062: Show entity labels in parsed edit summaries in API requests as well

Pintoch added a comment. Thank you both, this should simplify the EditGroups tool quite a bit! Here is an example of page where I had to render entity links manually, with some Javascript post-processing code: https://editgroups.toolforge.org/b/CB/3683873dde8d/. (I guess I will keep this

[Wikidata-bugs] [Maniphest] T327062: Show entity labels in parsed edit summaries in API requests as well

Lucas_Werkmeister_WMDE added a comment. One strange thing that we should maybe look into: while this works in `prop=revisions` as in Michael’s URL above, it doesn’t seem to work in `list=recentchanges` and I have no idea why:

[Wikidata-bugs] [Maniphest] T327062: Show entity labels in parsed edit summaries in API requests as well

Michael added a comment. This can be now verified on beta with this example API request: https://wikidata.beta.wmflabs.org/w/api.php?action=query=json=revisions=1340833=2=comment|parsedcomment TASK DETAIL https://phabricator.wikimedia.org/T327062 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T327062: Show entity labels in parsed edit summaries in API requests as well

Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T327062 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael, Maintenance_bot Cc: Bene, ItamarWMDE, HasanAkgun_WMDE, Lydia_Pintscher, Lectrician1,

[Wikidata-bugs] [Maniphest] T327062: Show entity labels in parsed edit summaries in API requests as well

Stashbot added a comment. Mentioned in SAL (#wikimedia-operations) [2023-04-26T07:28:40Z] Finished scap: Backport for [[gerrit:911311|Beta-Wikidata: Enable Labels in Wikidata edit summaries (T327062 )]] (duration: 07m 48s) TASK DETAIL

[Wikidata-bugs] [Maniphest] T327062: Show entity labels in parsed edit summaries in API requests as well

Stashbot added a comment. Mentioned in SAL (#wikimedia-operations) [2023-04-26T07:22:19Z] taavi and migr: Backport for [[gerrit:911311|Beta-Wikidata: Enable Labels in Wikidata edit summaries (T327062 )]] synced to the testservers:

[Wikidata-bugs] [Maniphest] T327062: Show entity labels in parsed edit summaries in API requests as well

Stashbot added a comment. Mentioned in SAL (#wikimedia-operations) [2023-04-26T07:20:51Z] Started scap: Backport for [[gerrit:911311|Beta-Wikidata: Enable Labels in Wikidata edit summaries (T327062 )]] TASK DETAIL

[Wikidata-bugs] [Maniphest] T327062: Show entity labels in parsed edit summaries in API requests as well

gerritbot added a comment. Change 911311 **merged** by jenkins-bot: [operations/mediawiki-config@master] Beta-Wikidata: Enable Labels in Wikidata edit summaries https://gerrit.wikimedia.org/r/911311 TASK DETAIL https://phabricator.wikimedia.org/T327062 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T327062: Show entity labels in parsed edit summaries in API requests as well

Lectrician1 added a comment. @Michael yes! The hook for that purpose is what I'm requesting here: T334803: Create HtmlPageTitle hook TASK DETAIL https://phabricator.wikimedia.org/T327062 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T327062: Show entity labels in parsed edit summaries in API requests as well

Michael added a comment. The change to beta should make this sufficiently testable for the API endpoint. However, this is //not// going to affect the Echo notifications (as requested in the AC), because for that those plain titles would have to change to actual links, and that, as I

[Wikidata-bugs] [Maniphest] T327062: Show entity labels in parsed edit summaries in API requests as well

Michael changed the status of subtask T335107: Remove temporary feature flag for Entity Labels in parsed edit summaries in API requests again from Open to Stalled. TASK DETAIL https://phabricator.wikimedia.org/T327062 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T327062: Show entity labels in parsed edit summaries in API requests as well

Michael changed the status of subtask T335099: Wikidata: enable entity labels in parsed edit summaries in API requests from Open to Stalled. TASK DETAIL https://phabricator.wikimedia.org/T327062 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] T327062: Show entity labels in parsed edit summaries in API requests as well

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T327062 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael, gerritbot Cc: Bene, ItamarWMDE, HasanAkgun_WMDE, Lydia_Pintscher, Lectrician1, Michael,

[Wikidata-bugs] [Maniphest] T327062: Show entity labels in parsed edit summaries in API requests as well

gerritbot added a comment. Change 911311 had a related patch set uploaded (by Michael Große; author: Michael Große): [operations/mediawiki-config@master] Beta-Wikidata: Enable Labels in Wikidata edit summaries https://gerrit.wikimedia.org/r/911311 TASK DETAIL

[Wikidata-bugs] [Maniphest] T327062: Show entity labels in parsed edit summaries in API requests as well

Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T327062 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael, Maintenance_bot Cc: Bene, ItamarWMDE, HasanAkgun_WMDE, Lydia_Pintscher, Lectrician1,

[Wikidata-bugs] [Maniphest] T327062: Show entity labels in parsed edit summaries in API requests as well

gerritbot added a comment. Change 910432 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Show entity labels in parsed edit summaries in API requests https://gerrit.wikimedia.org/r/910432 TASK DETAIL https://phabricator.wikimedia.org/T327062 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T327062: Show entity labels in parsed edit summaries in API requests as well

gerritbot added a comment. Change 910553 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Add regression test for parser cache pollution (T111346) https://gerrit.wikimedia.org/r/910553 TASK DETAIL https://phabricator.wikimedia.org/T327062 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T327062: Show entity labels in parsed edit summaries in API requests as well

gerritbot added a comment. Change 910432 had a related patch set uploaded (by Michael Große; author: Michael Große): [mediawiki/extensions/Wikibase@master] Show entity labels in parsed edit summaries in API requests https://gerrit.wikimedia.org/r/910432 TASK DETAIL

[Wikidata-bugs] [Maniphest] T327062: Show entity labels in parsed edit summaries in API requests as well

Michael added a comment. In T327062#8796630 , @Lucas_Werkmeister_WMDE wrote: > What if we change the special page condition to `$currentTitle->isSpecialPage() && !$currentTitle->isSpecial( 'Badtitle' )`, i.e. treat Special:Badtitle

[Wikidata-bugs] [Maniphest] T327062: Show entity labels in parsed edit summaries in API requests as well

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T327062 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael, gerritbot Cc: Bene, ItamarWMDE, HasanAkgun_WMDE, Lydia_Pintscher, Lectrician1, Michael,

[Wikidata-bugs] [Maniphest] T327062: Show entity labels in parsed edit summaries in API requests as well

gerritbot added a comment. Change 910553 had a related patch set uploaded (by Michael Große; author: Michael Große): [mediawiki/extensions/Wikibase@master] Add regression test for parser cache pollution (T111346) https://gerrit.wikimedia.org/r/910553 TASK DETAIL

[Wikidata-bugs] [Maniphest] T327062: Show entity labels in parsed edit summaries in API requests as well

Lucas_Werkmeister_WMDE added a comment. By the way, one interesting consequence of the current conditions is that the links transcluded from `Special:AllPages` into a wikitext page – e.g. `{{Special:AllPages/Item:Q216155}}` – will be shown with labels. But at least when I test this on my

[Wikidata-bugs] [Maniphest] T327062: Show entity labels in parsed edit summaries in API requests as well

Lucas_Werkmeister_WMDE added a comment. What if we change the special page condition to `$currentTitle->isSpecialPage() && !$currentTitle->isSpecial( 'Badtitle' )`, i.e. treat Special:Badtitle like a non-special page? It’s not like we ever expect users to see real links on that title when

[Wikidata-bugs] [Maniphest] T327062: Show entity labels in parsed edit summaries in API requests as well

Michael added a comment. The current logic is: "Add Labels iff `(!$this->isApiRequest()) && ($linkRenderer->isForComment() || $currentTitle->isSpecialPage())`" Dropping the check for the API Request doesn't work, because it introduces the bug: "Add Labels iff

[Wikidata-bugs] [Maniphest] T327062: Show entity labels in parsed edit summaries in API requests as well

Michael added a subscriber: Bene. Michael added a comment. Just disabling the check would reintroduce T111346 for the same reason it origially worked: > The hook got run because when editing a wiki page and focusing the > summary field

[Wikidata-bugs] [Maniphest] T327062: Show entity labels in parsed edit summaries in API requests as well

Michael claimed this task. Michael moved this task from Todo/Backlog to Doing on the Wikidata Dev Team (Sprint-∞) board. Restricted Application added a project: User-Michael. TASK DETAIL https://phabricator.wikimedia.org/T327062 WORKBOARD

[Wikidata-bugs] [Maniphest] T327062: Show entity labels in parsed edit summaries in API requests as well

HasanAkgun_WMDE added subscribers: HasanAkgun_WMDE, ItamarWMDE. HasanAkgun_WMDE added a comment. Restricted Application added a project: User-ItamarWMDE. **Task Breakdown Notes** - One code change will affect all related API requests including Echo API, no need to create sub-tasks for

[Wikidata-bugs] [Maniphest] T327062: Show entity labels in parsed edit summaries in API requests as well

Sarai-WMDE moved this task from Unified prioritized backlog to Sprint-∞ on the Wikidata Dev Team board. Sarai-WMDE edited projects, added Wikidata Dev Team (Sprint-∞); removed Wikidata Dev Team. TASK DETAIL https://phabricator.wikimedia.org/T327062 WORKBOARD

[Wikidata-bugs] [Maniphest] T327062: Show entity labels in parsed edit summaries in API requests as well

Lydia_Pintscher updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T327062 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Lydia_Pintscher, Lectrician1, Michael, karapayneWMDE, Lucas_Werkmeister_WMDE,

[Wikidata-bugs] [Maniphest] T327062: Show entity labels in parsed edit summaries in API requests as well

karapayneWMDE set the point value for this task to "5". TASK DETAIL https://phabricator.wikimedia.org/T327062 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: karapayneWMDE Cc: Lydia_Pintscher, Lectrician1, Michael, karapayneWMDE,

[Wikidata-bugs] [Maniphest] T327062: Show entity labels in parsed edit summaries in API requests as well

Lydia_Pintscher added a parent task: T330130: API changes. TASK DETAIL https://phabricator.wikimedia.org/T327062 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Lydia_Pintscher, Lectrician1, Michael, karapayneWMDE,

[Wikidata-bugs] [Maniphest] T327062: Show entity labels in parsed edit summaries in API requests as well

Lucas_Werkmeister_WMDE created this task. Lucas_Werkmeister_WMDE added projects: Wikidata, MediaWiki-extensions-WikibaseRepository, Wikidata Dev Team. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION As a Wikidata editor, I want to see “nice” edit summaries when edits are