[Wikidata-bugs] [Maniphest] T328543: [QB] [WDQS-GUI] Move build scripts from CI to the repository

hashar added a comment. One of the issue we have encountered is the `git push` to Gerrit failed due to the ssh host key not being present on the Jenkins instances. That got solved by https://gerrit.wikimedia.org/r/c/operations/puppet/+/965122 TASK DETAIL

[Wikidata-bugs] [Maniphest] T328543: [QB] [WDQS-GUI] Move build scripts from CI to the repository

gerritbot added a comment. Change 965122 **merged** by Jbond: [operations/puppet@production] gerrit: make gerrit ssh key more DRY https://gerrit.wikimedia.org/r/965122 TASK DETAIL https://phabricator.wikimedia.org/T328543 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T328543: [QB] [WDQS-GUI] Move build scripts from CI to the repository

gerritbot added a comment. Change 961025 **abandoned** by Hashar: [operations/puppet@production] ci: add Gerrit ssh key to ssh_known_hosts Reason: In favor of shorter/cleaner AND working https://gerrit.wikimedia.org/r/c/operations/puppet/+/965122

[Wikidata-bugs] [Maniphest] T328543: [QB] [WDQS-GUI] Move build scripts from CI to the repository

ItamarWMDE closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T328543 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: noarave, ItamarWMDE Cc: Lucas_Werkmeister_WMDE, noarave, hashar, ItamarWMDE, Aklapper, Michael,

[Wikidata-bugs] [Maniphest] T328543: [QB] [WDQS-GUI] Move build scripts from CI to the repository

ItamarWMDE added a comment. Build scripts are now indeed in the repository and not in operations. Thank you @noarave and @hashar ! TASK DETAIL https://phabricator.wikimedia.org/T328543 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: noarave,

[Wikidata-bugs] [Maniphest] T328543: [QB] [WDQS-GUI] Move build scripts from CI to the repository

noarave moved this task from Peer Review to Tech Verification on the Wikidata Dev Team (Quality Tools "Sprint") board. noarave added a comment. I think this is done on the Wikidata side. TASK DETAIL https://phabricator.wikimedia.org/T328543 WORKBOARD

[Wikidata-bugs] [Maniphest] T328543: [QB] [WDQS-GUI] Move build scripts from CI to the repository

gerritbot added a comment. Change 965122 had a related patch set uploaded (by Jbond; author: jbond): [operations/puppet@production] gerrit: make gerrit ssh key more DRY https://gerrit.wikimedia.org/r/965122 TASK DETAIL https://phabricator.wikimedia.org/T328543 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T328543: [QB] [WDQS-GUI] Move build scripts from CI to the repository

gerritbot added a comment. Change 953558 **merged** by jenkins-bot: [wikidata/query-builder@master] Query Builder: move scripts from jenkins into repository https://gerrit.wikimedia.org/r/953558 TASK DETAIL https://phabricator.wikimedia.org/T328543 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T328543: [QB] [WDQS-GUI] Move build scripts from CI to the repository

gerritbot added a comment. Change 963196 had a related patch set uploaded (by WDQSGuiBuilder; author: WDQSGuiBuilder): [wikidata/query-builder/deploy@production] Merging from 472864b6e92537d079ad719b070ba95f205a81f9 https://gerrit.wikimedia.org/r/963196 TASK DETAIL

[Wikidata-bugs] [Maniphest] T328543: [QB] [WDQS-GUI] Move build scripts from CI to the repository

noarave moved this task from Doing to Peer Review on the Wikidata Dev Team (Quality Tools "Sprint") board. noarave added a comment. This is the last open patch of the task and I believe it is now finally ready to be reviewed https://gerrit.wikimedia.org/r/c/wikidata/query-builder/+/953558/

[Wikidata-bugs] [Maniphest] T328543: [QB] [WDQS-GUI] Move build scripts from CI to the repository

gerritbot added a comment. Change 961991 **abandoned** by Noa wmde: [wikidata/query-builder/deploy@production] Merging from 176678c2db83f44d868e808d3da83df11d19c1a2 Reason: This was a side effect of a success Jenkins job run test https://gerrit.wikimedia.org/r/961991 TASK

[Wikidata-bugs] [Maniphest] T328543: [QB] [WDQS-GUI] Move build scripts from CI to the repository

gerritbot added a comment. Change 961991 had a related patch set uploaded (by WDQSGuiBuilder; author: WDQSGuiBuilder): [wikidata/query-builder/deploy@production] Merging from 176678c2db83f44d868e808d3da83df11d19c1a2 https://gerrit.wikimedia.org/r/961991 TASK DETAIL

[Wikidata-bugs] [Maniphest] T328543: [QB] [WDQS-GUI] Move build scripts from CI to the repository

gerritbot added a comment. Change 961075 **merged** by jenkins-bot: [integration/config@master] Fix wrong deploy dir for wikidata-query-builder-build https://gerrit.wikimedia.org/r/961075 TASK DETAIL https://phabricator.wikimedia.org/T328543 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T328543: [QB] [WDQS-GUI] Move build scripts from CI to the repository

gerritbot added a comment. Change 961075 had a related patch set uploaded (by Noa wmde; author: Noa wmde): [integration/config@master] Fix wrong deploy dir for wikidata-query-builder-build https://gerrit.wikimedia.org/r/961075 TASK DETAIL

[Wikidata-bugs] [Maniphest] T328543: [QB] [WDQS-GUI] Move build scripts from CI to the repository

noarave changed the task status from "Stalled" to "Open". noarave moved this task from Stalled to Doing on the Wikidata Dev Team (Quality Tools "Sprint") board. TASK DETAIL https://phabricator.wikimedia.org/T328543 WORKBOARD https://phabricator.wikimedia.org/project/board/6750/ EMAIL

[Wikidata-bugs] [Maniphest] T328543: [QB] [WDQS-GUI] Move build scripts from CI to the repository

gerritbot added a comment. Change 961056 **merged** by jenkins-bot: [integration/config@master] wikidata-query-builder-builder: use wdqsguibuilder https://gerrit.wikimedia.org/r/961056 TASK DETAIL https://phabricator.wikimedia.org/T328543 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T328543: [QB] [WDQS-GUI] Move build scripts from CI to the repository

gerritbot added a comment. Change 961056 had a related patch set uploaded (by Hashar; author: Hashar): [integration/config@master] wikidata-query-builder-builder: use wdqsguibuilder https://gerrit.wikimedia.org/r/961056 TASK DETAIL https://phabricator.wikimedia.org/T328543 EMAIL

[Wikidata-bugs] [Maniphest] T328543: [QB] [WDQS-GUI] Move build scripts from CI to the repository

gerritbot added a comment. Change 953559 **merged** by jenkins-bot: [integration/config@master] wikidata-query-builder-build: run shell scripts in a container https://gerrit.wikimedia.org/r/953559 TASK DETAIL https://phabricator.wikimedia.org/T328543 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T328543: [QB] [WDQS-GUI] Move build scripts from CI to the repository

hashar added a comment. I have cherry picked https://gerrit.wikimedia.org/r/c/operations/puppet/+/961025 on the integration Puppet master: Notice: /Stage[main]/Profile::Ci::Slave::Labs::Common/Sshkey[gerrit]/ensure: created Which made the key available globally: cat

[Wikidata-bugs] [Maniphest] T328543: [QB] [WDQS-GUI] Move build scripts from CI to the repository

gerritbot added a comment. Change 961025 had a related patch set uploaded (by Hashar; author: Hashar): [operations/puppet@production] ci: add Gerrit ssh key to ssh_known_hosts https://gerrit.wikimedia.org/r/961025 TASK DETAIL https://phabricator.wikimedia.org/T328543 EMAIL

[Wikidata-bugs] [Maniphest] T328543: [QB] [WDQS-GUI] Move build scripts from CI to the repository

Stashbot added a comment. Mentioned in SAL (#wikimedia-releng) [2023-09-26T07:39:44Z] integration: `sudo cumin --force 'name:docker' 'rm -f /mnt/home/jenkins-deploy/.ssh/config'` # T328543#9198204 TASK DETAIL

[Wikidata-bugs] [Maniphest] T328543: [QB] [WDQS-GUI] Move build scripts from CI to the repository

hashar added a comment. On an agent that executed a successful build: hashar@integration-agent-docker-1055:~$ sudo su - jenkins-deploy jenkins-deploy@integration-agent-docker-1055:~$ ssh -p 29418 gerrit.wikimedia.org wdqsguibuil...@gerrit.wikimedia.org: Permission denied

[Wikidata-bugs] [Maniphest] T328543: [QB] [WDQS-GUI] Move build scripts from CI to the repository

hashar added a comment. The Jenkins job clones `wikidata/query/gui` and shells out to `scripts/set-up-git.sh` which: git clone "https://gerrit.wikimedia.org/r/wikidata/query/gui-deploy; ./build git -C ./build \ remote set-url --push origin \

[Wikidata-bugs] [Maniphest] T328543: [QB] [WDQS-GUI] Move build scripts from CI to the repository

Lucas_Werkmeister_WMDE added a comment. In T328543#9195403 , @gerritbot wrote: > Duplicate of Icdd62c98ac – the query-gui-build job is currently fetching PS14 of change 949833, rather than master. Correction: that’s just because I

[Wikidata-bugs] [Maniphest] T328543: [QB] [WDQS-GUI] Move build scripts from CI to the repository

gerritbot added a comment. Change 960620 **abandoned** by Lucas Werkmeister (WMDE): [wikidata/query/gui-deploy@production] Merging from 43dcb29b6d5f57c5297188a743a6e7406174f344 Reason: Duplicate of Icdd62c98ac – the query-gui-build job is currently fetching PS14 of change

[Wikidata-bugs] [Maniphest] T328543: [QB] [WDQS-GUI] Move build scripts from CI to the repository

gerritbot added a comment. Change 960620 had a related patch set uploaded (by WDQSGuiBuilder; author: WDQSGuiBuilder): [wikidata/query/gui-deploy@production] Merging from 43dcb29b6d5f57c5297188a743a6e7406174f344 https://gerrit.wikimedia.org/r/960620 TASK DETAIL

[Wikidata-bugs] [Maniphest] T328543: [QB] [WDQS-GUI] Move build scripts from CI to the repository

karapayneWMDE moved this task from Sprint-∞ to Quality Tools "Sprint" on the Wikidata Dev Team board. karapayneWMDE edited projects, added Wikidata Dev Team (Quality Tools "Sprint"); removed Wikidata Dev Team (Sprint-∞). TASK DETAIL https://phabricator.wikimedia.org/T328543 WORKBOARD

[Wikidata-bugs] [Maniphest] T328543: [QB] [WDQS-GUI] Move build scripts from CI to the repository

ItamarWMDE changed the task status from "Open" to "Stalled". ItamarWMDE added a comment. @hashar sorry to ping you, but I think we need you for the review of this PR. I will mark this ticket as stalled until we have a response. TASK DETAIL https://phabricator.wikimedia.org/T328543

[Wikidata-bugs] [Maniphest] T328543: [QB] [WDQS-GUI] Move build scripts from CI to the repository

noarave added a comment. @hashar we would appreciate any feedback on the open patches. thank you! TASK DETAIL https://phabricator.wikimedia.org/T328543 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: noarave Cc: noarave, hashar, ItamarWMDE,

[Wikidata-bugs] [Maniphest] T328543: [QB] [WDQS-GUI] Move build scripts from CI to the repository

gerritbot added a comment. Change 953559 had a related patch set uploaded (by Noa wmde; author: Noa wmde): [integration/config@master] wikidata-query-builder-build: run shell scripts in a container https://gerrit.wikimedia.org/r/953559 TASK DETAIL

[Wikidata-bugs] [Maniphest] T328543: [QB] [WDQS-GUI] Move build scripts from CI to the repository

gerritbot added a comment. Change 953558 had a related patch set uploaded (by Noa wmde; author: Noa wmde): [wikidata/query-builder@master] Query Builder: move scripts from jenkins into repository https://gerrit.wikimedia.org/r/953558 TASK DETAIL

[Wikidata-bugs] [Maniphest] T328543: [QB] [WDQS-GUI] Move build scripts from CI to the repository

noarave added a comment. I see, for some reason I thought a manual deployment is necessary. I'm starting to work on the `wikidata-query-builder-build` part of this task so a similar patch should reach your way soon. TASK DETAIL https://phabricator.wikimedia.org/T328543 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T328543: [QB] [WDQS-GUI] Move build scripts from CI to the repository

hashar added a comment. The change made to integration/config are immediately deployed after they get merged. It is done manually by running the `./fab` script at the root of the repository and is outside scap. That is done outside of the MediaWiki backport & config windows.

[Wikidata-bugs] [Maniphest] T328543: [QB] [WDQS-GUI] Move build scripts from CI to the repository

noarave added a comment. @hashar thank you for all the help! Do the config patches regarding `wikidata-query-gui-build` require deployment in a backport window? if so, should I schedule one or does Release Engineering schedule deployments for integration/config? TASK DETAIL

[Wikidata-bugs] [Maniphest] T328543: [QB] [WDQS-GUI] Move build scripts from CI to the repository

gerritbot added a comment. Change 949833 **merged** by jenkins-bot: [wikidata/query/gui@master] Move build scripts from Jenkins job into the repository https://gerrit.wikimedia.org/r/949833 TASK DETAIL https://phabricator.wikimedia.org/T328543 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T328543: [QB] [WDQS-GUI] Move build scripts from CI to the repository

hashar added a comment. There were a few gotchas here and there due to how we run the CI jobs and some trouble passing the ssh agent inside the container (I went to push from the Jenkins job as a workaround). @noarave thank you so much for doing this work! I am a huge fan of moving

[Wikidata-bugs] [Maniphest] T328543: [QB] [WDQS-GUI] Move build scripts from CI to the repository

gerritbot added a comment. Change 952451 **merged** by jenkins-bot: [integration/config@master] jjb: wikidata-query-gui-build push to git from Jenkins https://gerrit.wikimedia.org/r/952451 TASK DETAIL https://phabricator.wikimedia.org/T328543 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T328543: [QB] [WDQS-GUI] Move build scripts from CI to the repository

gerritbot added a comment. Change 952465 had a related patch set uploaded (by WDQSGuiBuilder; author: WDQSGuiBuilder): [wikidata/query/gui-deploy@production] Merging from 43dcb29b6d5f57c5297188a743a6e7406174f344 https://gerrit.wikimedia.org/r/952465 TASK DETAIL

[Wikidata-bugs] [Maniphest] T328543: [QB] [WDQS-GUI] Move build scripts from CI to the repository

gerritbot added a comment. Change 952463 **abandoned** by Hashar: [wikidata/query/gui-deploy@production] Merging from 472449b750ff7e26994a172d693a4f0fd6724286 Reason: https://gerrit.wikimedia.org/r/952463 TASK DETAIL https://phabricator.wikimedia.org/T328543 EMAIL

[Wikidata-bugs] [Maniphest] T328543: [QB] [WDQS-GUI] Move build scripts from CI to the repository

gerritbot added a comment. Change 952463 had a related patch set uploaded (by WDQSGuiBuilder; author: WDQSGuiBuilder): [wikidata/query/gui-deploy@production] Merging from 472449b750ff7e26994a172d693a4f0fd6724286 https://gerrit.wikimedia.org/r/952463 TASK DETAIL

[Wikidata-bugs] [Maniphest] T328543: [QB] [WDQS-GUI] Move build scripts from CI to the repository

gerritbot added a comment. Change 952451 had a related patch set uploaded (by Hashar; author: Hashar): [integration/config@master] jjb: wikidata-query-gui-build push to git from Jenkins https://gerrit.wikimedia.org/r/952451 TASK DETAIL https://phabricator.wikimedia.org/T328543

[Wikidata-bugs] [Maniphest] T328543: [QB] [WDQS-GUI] Move build scripts from CI to the repository

gerritbot added a comment. Change 952395 **merged** by jenkins-bot: [integration/config@master] jjb: use image with ssh client for wikidata-query-gui-build https://gerrit.wikimedia.org/r/952395 TASK DETAIL https://phabricator.wikimedia.org/T328543 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T328543: [QB] [WDQS-GUI] Move build scripts from CI to the repository

Stashbot added a comment. Mentioned in SAL (#wikimedia-releng) [2023-08-25T12:48:56Z] Building Docker images for https://gerrit.wikimedia.org/r/c/integration/config/+/952393 # T328543 TASK DETAIL https://phabricator.wikimedia.org/T328543 EMAIL

[Wikidata-bugs] [Maniphest] T328543: [QB] [WDQS-GUI] Move build scripts from CI to the repository

gerritbot added a comment. Change 952395 had a related patch set uploaded (by Hashar; author: Hashar): [integration/config@master] jjb: use image with ssh client for wikidata-query-gui-build https://gerrit.wikimedia.org/r/952395 TASK DETAIL

[Wikidata-bugs] [Maniphest] T328543: [QB] [WDQS-GUI] Move build scripts from CI to the repository

gerritbot added a comment. Change 952393 **merged** by jenkins-bot: [integration/config@master] Dockerfiles: add openssh-client to node test images https://gerrit.wikimedia.org/r/952393 TASK DETAIL https://phabricator.wikimedia.org/T328543 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T328543: [QB] [WDQS-GUI] Move build scripts from CI to the repository

gerritbot added a comment. Change 952393 had a related patch set uploaded (by Hashar; author: Hashar): [integration/config@master] Dockerfiles: add openssh-client to node test images https://gerrit.wikimedia.org/r/952393 TASK DETAIL https://phabricator.wikimedia.org/T328543

[Wikidata-bugs] [Maniphest] T328543: [QB] [WDQS-GUI] Move build scripts from CI to the repository

gerritbot added a comment. Change 951066 **merged** by jenkins-bot: [integration/config@master] wikidata-query-gui-build: run shell scripts in a container https://gerrit.wikimedia.org/r/951066 TASK DETAIL https://phabricator.wikimedia.org/T328543 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T328543: [QB] [WDQS-GUI] Move build scripts from CI to the repository

gerritbot added a comment. Change 952317 **merged** by jenkins-bot: [wikidata/query/gui@master] Adding an empty commit to test build job https://gerrit.wikimedia.org/r/952317 TASK DETAIL https://phabricator.wikimedia.org/T328543 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T328543: [QB] [WDQS-GUI] Move build scripts from CI to the repository

gerritbot added a comment. Change 952317 had a related patch set uploaded (by Noa wmde; author: Noa wmde): [wikidata/query/gui@master] Adding an empty commit to test build job https://gerrit.wikimedia.org/r/952317 TASK DETAIL https://phabricator.wikimedia.org/T328543 EMAIL

[Wikidata-bugs] [Maniphest] T328543: [QB] [WDQS-GUI] Move build scripts from CI to the repository

gerritbot added a comment. Change 951066 had a related patch set uploaded (by Noa wmde; author: Noa wmde): [integration/config@master] wikidata-query-gui-build: run shell scripts in a container https://gerrit.wikimedia.org/r/951066 TASK DETAIL

[Wikidata-bugs] [Maniphest] T328543: [QB] [WDQS-GUI] Move build scripts from CI to the repository

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T328543 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: noarave, gerritbot Cc: noarave, hashar, ItamarWMDE, Aklapper, Michael, Danny_Benjafield_WMDE,

[Wikidata-bugs] [Maniphest] T328543: [QB] [WDQS-GUI] Move build scripts from CI to the repository

gerritbot added a comment. Change 949833 had a related patch set uploaded (by Noa wmde; author: Noa wmde): [wikidata/query/gui@master] Move build scripts from jenkins job into the repository https://gerrit.wikimedia.org/r/949833 TASK DETAIL

[Wikidata-bugs] [Maniphest] T328543: [QB] [WDQS-GUI] Move build scripts from CI to the repository

noarave moved this task from Todo/Backlog to Doing on the Wikidata Dev Team (Sprint-∞) board. noarave claimed this task. noarave added a comment. Restricted Application added a project: User-Noarave. I'm going to pick this up and start with QS GUI. Relevant jenkins jobs are here:

[Wikidata-bugs] [Maniphest] T328543: [QB] [WDQS-GUI] Move build scripts from CI to the repository

Michael added a subscriber: hashar. Michael added a comment. It has been a long while since I last looked into this, and I'm not fully sure what @hashar had mind, but my understanding would be that the rough process would look like: 1. look at the shell commands and such in the jobs

[Wikidata-bugs] [Maniphest] T328543: [QB] [WDQS-GUI] Move build scripts from CI to the repository

karapayneWMDE moved this task from Unified prioritized backlog to Sprint-∞ on the Wikidata Dev Team board. karapayneWMDE edited projects, added Wikidata Dev Team (Sprint-∞); removed Wikidata Dev Team. TASK DETAIL https://phabricator.wikimedia.org/T328543 WORKBOARD

[Wikidata-bugs] [Maniphest] T328543: [QB] [WDQS-GUI] Move build scripts from CI to the repository

karapayneWMDE set the point value for this task to "5". TASK DETAIL https://phabricator.wikimedia.org/T328543 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: karapayneWMDE Cc: ItamarWMDE, Aklapper, Michael, Danny_Benjafield_WMDE, Astuthiodit_1,

[Wikidata-bugs] [Maniphest] T328543: [QB] [WDQS-GUI] Move build scripts from CI to the repository

ItamarWMDE renamed this task from "Move build scripts from CI to the repository" to "[QB] [WDQS-GUI] Move build scripts from CI to the repository". TASK DETAIL https://phabricator.wikimedia.org/T328543 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: