[Wikidata-bugs] [Maniphest] T326082: Regression: Wikibase no longer reports pages as unlinked on a client when linked item deleted from a repo

Arian_Bozorg closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T326082 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo, Arian_Bozorg Cc: jon_amar-WMDE, Lucas_Werkmeister_WMDE, ItamarWMDE, Michael, Lydia_Pintscher,

[Wikidata-bugs] [Maniphest] T326082: Regression: Wikibase no longer reports pages as unlinked on a client when linked item deleted from a repo

ItamarWMDE moved this task from Tech Verification to Our work done on the Wikidata Dev Team (Sprint-∞) board. ItamarWMDE added a subscriber: jon_amar-WMDE. ItamarWMDE added a comment. To me this seems complete, so I'll move it to done on our board, but not resolve this. Pending news from

[Wikidata-bugs] [Maniphest] T326082: Regression: Wikibase no longer reports pages as unlinked on a client when linked item deleted from a repo

Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T326082 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo, Maintenance_bot Cc: Lucas_Werkmeister_WMDE, ItamarWMDE, Michael, Lydia_Pintscher,

[Wikidata-bugs] [Maniphest] T326082: Regression: Wikibase no longer reports pages as unlinked on a client when linked item deleted from a repo

gerritbot added a comment. Change 878193 **abandoned** by Michael Große: [mediawiki/extensions/Wikibase@master] Add browser test for Change Dispatching Reason: This is not providing value over the api-testing test (If4a281bc) and still would have significant hurdles to overcome

[Wikidata-bugs] [Maniphest] T326082: Regression: Wikibase no longer reports pages as unlinked on a client when linked item deleted from a repo

Lucas_Werkmeister_WMDE moved this task from Peer Review to Tech Verification on the Wikidata Dev Team (Sprint-∞) board. Lucas_Werkmeister_WMDE added a comment. This should be fixed now – @Addshore is it possible to verify this using the release pipeline tests? (By backporting the fix

[Wikidata-bugs] [Maniphest] T326082: Regression: Wikibase no longer reports pages as unlinked on a client when linked item deleted from a repo

gerritbot added a comment. Change 880537 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Remove (JobQueue)ChangeNotificationSender https://gerrit.wikimedia.org/r/880537 TASK DETAIL https://phabricator.wikimedia.org/T326082 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T326082: Regression: Wikibase no longer reports pages as unlinked on a client when linked item deleted from a repo

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.21; 2023-01-30). TASK DETAIL https://phabricator.wikimedia.org/T326082 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo, ReleaseTaggerBot Cc: Lucas_Werkmeister_WMDE, ItamarWMDE, Michael,

[Wikidata-bugs] [Maniphest] T326082: Regression: Wikibase no longer reports pages as unlinked on a client when linked item deleted from a repo

gerritbot added a comment. Change 878965 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Add API integration test for change dispatching https://gerrit.wikimedia.org/r/878965 TASK DETAIL https://phabricator.wikimedia.org/T326082 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T326082: Regression: Wikibase no longer reports pages as unlinked on a client when linked item deleted from a repo

gerritbot added a comment. Change 883165 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] RecentChangeSaveHookHandler: Handle (un)deletions https://gerrit.wikimedia.org/r/883165 TASK DETAIL https://phabricator.wikimedia.org/T326082 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T326082: Regression: Wikibase no longer reports pages as unlinked on a client when linked item deleted from a repo

gerritbot added a comment. Change 883165 had a related patch set uploaded (by Hoo man; author: Hoo man): [mediawiki/extensions/Wikibase@master] RecentChangeSaveHookHandler: Handle (un)deletions https://gerrit.wikimedia.org/r/883165 TASK DETAIL

[Wikidata-bugs] [Maniphest] T326082: Regression: Wikibase no longer reports pages as unlinked on a client when linked item deleted from a repo

hoo added a comment. I have not fully finished this yet, but one thing to note: The return if rc_this_oldid is <= 0 is no longer needed. This was added back when changes were saved to `wb_changes` and later loaded by revision id (used to be `ChangeLookup::loadByRevisionId`), but nowadays

[Wikidata-bugs] [Maniphest] T326082: Regression: Wikibase no longer reports pages as unlinked on a client when linked item deleted from a repo

gerritbot added a comment. Change 880537 had a related patch set uploaded (by Hoo man; author: Hoo man): [mediawiki/extensions/Wikibase@master] Remove (JobQueue)ChangeNotificationSender https://gerrit.wikimedia.org/r/880537 TASK DETAIL https://phabricator.wikimedia.org/T326082

[Wikidata-bugs] [Maniphest] T326082: Regression: Wikibase no longer reports pages as unlinked on a client when linked item deleted from a repo

Michael added a comment. The browser test I added does pass locally with the changes suggested by @Lucas_Werkmeister_WMDE. However, that does only deal with a single change, and we should probably double check that ChangeRunCoalescer does still a sensible thing if there a multiple changes

[Wikidata-bugs] [Maniphest] T326082: Regression: Wikibase no longer reports pages as unlinked on a client when linked item deleted from a repo

hoo claimed this task. hoo moved this task from Todo/Backlog to Doing on the Wikidata Dev Team (Sprint-∞) board. TASK DETAIL https://phabricator.wikimedia.org/T326082 WORKBOARD https://phabricator.wikimedia.org/project/board/6017/ EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T326082: Regression: Wikibase no longer reports pages as unlinked on a client when linked item deleted from a repo

Michael added a comment. As far as I can see, that revision ID is mainly used in `\Wikibase\Client\Changes\ChangeRunCoalescer` - a part that wasn't touched in the rework. In theory, that `ChangeRunCoalescer` says that it handles delete actions correctly, though I did not see that in code.

[Wikidata-bugs] [Maniphest] T326082: Regression: Wikibase no longer reports pages as unlinked on a client when linked item deleted from a repo

Michael added a comment. That revision Id is used in `\Wikibase\Repo\Hooks\RecentChangeSaveHookHandler::setChangeMetaData`. So we probably need to track down how exactly it is being used further down in process. It could be that this is just a left-over from the previous change dispatching

[Wikidata-bugs] [Maniphest] T326082: Regression: Wikibase no longer reports pages as unlinked on a client when linked item deleted from a repo

Lucas_Werkmeister_WMDE added a comment. I think there’s one more condition in `onRecentChange_save()` that filters out the deletion – if I disable that, then most of my API integration tests (see Gerrit change above) actually work: diff --git

[Wikidata-bugs] [Maniphest] T326082: Regression: Wikibase no longer reports pages as unlinked on a client when linked item deleted from a repo

Addshore added a comment. > That looks like it would explain the issue – but that condition is almost eight years old (Set Change timestamp based on RC timestamp), so that doesn’t explain why this would be a regression with the new change dispatching code… As far as I found in my

[Wikidata-bugs] [Maniphest] T326082: Regression: Wikibase no longer reports pages as unlinked on a client when linked item deleted from a repo

Lucas_Werkmeister_WMDE added a comment. What I’ve found in the code so far: - `RepoHooks::onArticleDeleteComplete()` calls `ChangeNotifier::notifyOnPageDeleted()` - which calls `ChangeFactory::newForPageDeleted()` and transmits the resulting change -

[Wikidata-bugs] [Maniphest] T326082: Regression: Wikibase no longer reports pages as unlinked on a client when linked item deleted from a repo

gerritbot added a comment. Change 878965 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] Add API integration test for change dispatching https://gerrit.wikimedia.org/r/878965 TASK DETAIL

[Wikidata-bugs] [Maniphest] T326082: Regression: Wikibase no longer reports pages as unlinked on a client when linked item deleted from a repo

gerritbot added a comment. Change 878954 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@REL1_38] RELNOTES 1.38, Note about regression https://gerrit.wikimedia.org/r/878954 TASK DETAIL https://phabricator.wikimedia.org/T326082 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T326082: Regression: Wikibase no longer reports pages as unlinked on a client when linked item deleted from a repo

gerritbot added a comment. Change 878954 had a related patch set uploaded (by Addshore; author: Addshore): [mediawiki/extensions/Wikibase@REL1_38] RELNOTES 1.38, Note about regression https://gerrit.wikimedia.org/r/878954 TASK DETAIL https://phabricator.wikimedia.org/T326082

[Wikidata-bugs] [Maniphest] T326082: Regression: Wikibase no longer reports pages as unlinked on a client when linked item deleted from a repo

Addshore added a comment. Restricted Application added a project: User-ItamarWMDE. In T326082#8512537 , @ItamarWMDE wrote: > **Task Breakdown Notes**: > > - Calrification: This involves the following steps: > 1. Creating an item

[Wikidata-bugs] [Maniphest] T326082: Regression: Wikibase no longer reports pages as unlinked on a client when linked item deleted from a repo

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T326082 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: ItamarWMDE, Michael, Lydia_Pintscher, WMDE-leszek, Jon.b.amar, Addshore, Aklapper,

[Wikidata-bugs] [Maniphest] T326082: Regression: Wikibase no longer reports pages as unlinked on a client when linked item deleted from a repo

gerritbot added a comment. Change 878193 had a related patch set uploaded (by Michael Große; author: Michael Große): [mediawiki/extensions/Wikibase@master] Add browser test for Change Dispatching https://gerrit.wikimedia.org/r/878193 TASK DETAIL

[Wikidata-bugs] [Maniphest] T326082: Regression: Wikibase no longer reports pages as unlinked on a client when linked item deleted from a repo

ItamarWMDE added a comment. Task Breakdown Notes: - Calrification: This involves the following steps: 1. Creating an item in a wikibase instance 2. Linking that item into a client wiki 3. Linking the item into another client wiki 4. Deleting the wikidata item does not

[Wikidata-bugs] [Maniphest] T326082: Regression: Wikibase no longer reports pages as unlinked on a client when linked item deleted from a repo

Lucas_Werkmeister_WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T326082 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Michael, Lydia_Pintscher, WMDE-leszek, Jon.b.amar, Addshore,

[Wikidata-bugs] [Maniphest] T326082: Regression: Wikibase no longer reports pages as unlinked on a client when linked item deleted from a repo

Lydia_Pintscher updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T326082 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Michael, Lydia_Pintscher, WMDE-leszek, Jon.b.amar, Addshore, Aklapper,

[Wikidata-bugs] [Maniphest] T326082: Regression: Wikibase no longer reports pages as unlinked on a client when linked item deleted from a repo

karapayneWMDE moved this task from Product Backlog to Sprint-∞ on the Wikidata Dev Team board. karapayneWMDE edited projects, added Wikidata Dev Team (Sprint-∞); removed Wikidata Dev Team. TASK DETAIL https://phabricator.wikimedia.org/T326082 WORKBOARD

[Wikidata-bugs] [Maniphest] T326082: Regression: Wikibase no longer reports pages as unlinked on a client when linked item deleted from a repo

karapayneWMDE updated the task description. karapayneWMDE set the point value for this task to "8". TASK DETAIL https://phabricator.wikimedia.org/T326082 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: karapayneWMDE Cc: Michael, Lydia_Pintscher,

[Wikidata-bugs] [Maniphest] T326082: Regression: Wikibase no longer reports pages as unlinked on a client when linked item deleted from a repo

karapayneWMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T326082 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: karapayneWMDE Cc: Michael, Lydia_Pintscher, WMDE-leszek, Jon.b.amar, Addshore, Aklapper, Astuthiodit_1,

[Wikidata-bugs] [Maniphest] T326082: Regression: Wikibase no longer reports pages as unlinked on a client when linked item deleted from a repo

Lydia_Pintscher triaged this task as "High" priority. TASK DETAIL https://phabricator.wikimedia.org/T326082 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Michael, Lydia_Pintscher, WMDE-leszek, Jon.b.amar, Addshore, Aklapper,

[Wikidata-bugs] [Maniphest] T326082: Regression: Wikibase no longer reports pages as unlinked on a client when linked item deleted from a repo

WMDE-leszek added a comment. Indeed, the authors of the tests have suggested it when they were created, see e.g. T282479 TASK DETAIL https://phabricator.wikimedia.org/T326082 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T326082: Regression: Wikibase no longer reports pages as unlinked on a client when linked item deleted from a repo

Michael added a comment. In general, it would be great if we could somehow upstream these tests into Wikibase proper. Learning about such regressions over a year after the fact isn't exactly ideal. TASK DETAIL https://phabricator.wikimedia.org/T326082 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T326082: Regression: Wikibase no longer reports pages as unlinked on a client when linked item deleted from a repo

Michael added a project: Wikibase change dispatching scripts to jobs. TASK DETAIL https://phabricator.wikimedia.org/T326082 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: Michael, Lydia_Pintscher, WMDE-leszek, Jon.b.amar, Addshore,

[Wikidata-bugs] [Maniphest] T326082: Regression: Wikibase no longer reports pages as unlinked on a client when linked item deleted from a repo

Addshore added a parent task: T322407: Publish Wikibase Suite release compatible with MediaWiki 1.38. TASK DETAIL https://phabricator.wikimedia.org/T326082 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore Cc: Lydia_Pintscher, WMDE-leszek,

[Wikidata-bugs] [Maniphest] T326082: Regression: Wikibase no longer reports pages as unlinked on a client when linked item deleted from a repo

Addshore created this task. Addshore added projects: Wikibase Suite, Wikidata Dev Team, Wikibase (3rd party installations), Regression, Wikidata. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION This was detected as part of T322407: Publish Wikibase Suite release