Re: [Wikitech-l] [Ops] Changes to SWAT deployment policies, effective Monday April 30th

2018-04-27 Thread Tyler Cipriani
On 18-04-27 21:00:35, Gergo Tisza wrote: On Fri, Apr 27, 2018 at 7:05 PM, Niharika Kohli wrote: Also, I think dropping the limit to 4 patches per window is extreme, especially if we are asking people to start splitting their patches now. Very often we can +2 multiple

Re: [Wikitech-l] [Ops] Changes to SWAT deployment policies, effective Monday April 30th

2018-04-27 Thread Greg Grossmeier
> ie. if the new policy was introduced at the start of the year, it would > have caused at least a two-week delay in all three SWAT windows at one > point at least, and it would have caused an ever-growing backlog of patches > for EU mid-day. 2 week delays aren't possible as all SWATs are

Re: [Wikitech-l] Introducing Quibble, a test runner for MediaWiki

2018-04-27 Thread Antoine Musso
On 19/04/2018 23:43, Antoine Musso wrote: > Hello, > > Running all tests for MediaWiki and matching what CI/Jenkins is running > has been a constant challenge for everyone, myself included. Today I am > introducing Quibble, a python script that clone MediaWiki, set it up and > run test commands.

Re: [Wikitech-l] [Ops] Changes to SWAT deployment policies, effective Monday April 30th

2018-04-27 Thread Chad
On Fri, Apr 27, 2018 at 12:42 PM Stas Malyshev wrote: > Hi! > > > The new policy asks the folks submitting patches to split up patches to > > avoid bad intermediate states ahead of time. > > Thank you Tyler for the explanation! Which means this patch needs to be > split

Re: [Wikitech-l] [Ops] Changes to SWAT deployment policies, effective Monday April 30th

2018-04-27 Thread Stas Malyshev
Hi! > The new policy asks the folks submitting patches to split up patches to > avoid bad intermediate states ahead of time. Thank you Tyler for the explanation! Which means this patch needs to be split into several patches? Giving the lower limit of the patches, this becomes kinda challenging -

Re: [Wikitech-l] [Ops] Changes to SWAT deployment policies, effective Monday April 30th

2018-04-27 Thread Tyler Cipriani
On 18-04-27 10:49:28, Stas Malyshev wrote: Hi! First, we now disallow multi-sync patch deployments. See T187761[0]. This means that the sync order of files is determined by git commit parent relationships (or Gerrit's "depends-on"). This is to prevent SWAT deployers from accidentally syncing

Re: [Wikitech-l] [Ops] Changes to SWAT deployment policies, effective Monday April 30th

2018-04-27 Thread Gergo Tisza
On Fri, Apr 27, 2018 at 7:05 PM, Niharika Kohli wrote: > Also, I think dropping the limit to 4 patches per window is extreme, > especially if we are asking people to start splitting their patches now. > Very often we can +2 multiple patches in one go if they don't affect

Re: [Wikitech-l] [Ops] Changes to SWAT deployment policies, effective Monday April 30th

2018-04-27 Thread Stas Malyshev
Hi! > First, we now disallow multi-sync patch deployments. See T187761[0]. > This means that the sync order of files is determined by git commit > parent relationships (or Gerrit's "depends-on"). This is to prevent SWAT > deployers from accidentally syncing two patches in the wrong order.

Re: [Wikitech-l] [Ops] Changes to SWAT deployment policies, effective Monday April 30th

2018-04-27 Thread Niharika Kohli
On Fri, Apr 27, 2018 at 8:51 AM, Roan Kattouw wrote: > Will multi-file, single-directory syncs still be allowed? In other words, > can I deploy a change to the Foo extension that touches many files with > scap sync-dir extension/Foo ? > According to the task description,

[Wikitech-l] Code of Conduct for Wikimedia technical spaces - Code of Conduct Committee - 2018.II members

2018-04-27 Thread Sébastien Santoro
Hello all, The candidate slates has been deemed finalized. Thanks to the new candidates joining the committee to support this important mission, sustaining our code of conduct. We didn't receive a lot of candidatures this session, so we'd like to ask you to think for the next months if you

Re: [Wikitech-l] [Ops] Changes to SWAT deployment policies, effective Monday April 30th

2018-04-27 Thread Roan Kattouw
Will multi-file, single-directory syncs still be allowed? In other words, can I deploy a change to the Foo extension that touches many files with scap sync-dir extension/Foo ? On Thu, Apr 26, 2018, 15:15 Greg Grossmeier wrote: > Hello, > > I have made two changes to SWAT

Re: [Wikitech-l] [Ops] Changes to SWAT deployment policies, effective Monday April 30th

2018-04-27 Thread Brad Jorsch (Anomie)
On Thu, Apr 26, 2018 at 6:14 PM, Greg Grossmeier wrote: > First, we now disallow multi-sync patch deployments. See T187761[0]. > This means that the sync order of files is determined by git commit > parent relationships (or Gerrit's "depends-on"). This is to prevent SWAT >

Re: [Wikitech-l] "PHP test coverage decreased" - really?

2018-04-27 Thread Daniel Kinzler
Thank you Brad, the missing @covers line is indeed what threw me off. Also, as Trey noted, it's easy to miss negative cases. Testing every guard statement is certainly good, but does not feel as natural or as critical as testing the "happy path"... -- daniel Am 26.04.2018 um 23:13 schrieb Brad

[Wikitech-l] GSoC 2018 Introduction (Yashdeep Thorat)

2018-04-27 Thread Yashdeep Thorat
Hello everyone! I am Yashdeep Thorat, I am an undergraduate student at BITS Pilani Hyderabad Campus, India. I will be working on adding a spreadsheet interface to the Page Forms extension which will allow administrators of a wiki to edit multiple pages at once.