Re: [Wikitech-l] [Ops] Canary Deploys for MediaWiki

2016-07-25 Thread Roan Kattouw
On Jul 25, 2016 16:12, "Bryan Davis" wrote: > > I think Alex is "more right" here. If you are introducing a new $wmgX > var you really should always sync-file the changed InitialiseSettings > file first and then the CommonSettings that uses it. There's no really > good reason

Re: [Wikitech-l] [Ops] Canary Deploys for MediaWiki

2016-07-25 Thread Legoktm
Hi, On 07/25/2016 04:12 PM, Bryan Davis wrote: > On Mon, Jul 25, 2016 at 3:07 PM, Alex Monk wrote: >> On 25 July 2016 at 21:54, Roan Kattouw wrote: > I think Alex is "more right" here. If you are introducing a new $wmgX > var > And to continue

Re: [Wikitech-l] [Ops] Canary Deploys for MediaWiki

2016-07-25 Thread Bryan Davis
On Mon, Jul 25, 2016 at 3:07 PM, Alex Monk wrote: > On 25 July 2016 at 21:54, Roan Kattouw wrote: >> >> Note to deployers: when syncing certain config changes (e.g. adding a new >> variable) that touch both InitialiseSettings and CommonSettings, you

Re: [Wikitech-l] [Ops] Canary Deploys for MediaWiki

2016-07-25 Thread Alex Monk
If the intermediate state throws notices/errors, wouldn't it be a better idea to sync-file in the correct order to prevent such notices/errors? On 25 July 2016 at 21:54, Roan Kattouw wrote: > Note to deployers: when syncing certain config changes (e.g. adding a new >

Re: [Wikitech-l] [Ops] Canary Deploys for MediaWiki

2016-07-25 Thread Roan Kattouw
Note to deployers: when syncing certain config changes (e.g. adding a new variable) that touch both InitialiseSettings and CommonSettings, you will now need to use sync-dir wmf-config, because individual sync-files will likely fail if the intermediate state throws notices/errors. (It was a good