Re: [Wikitech-l] First step for MCR merged: Deprecate and gut the Revision class

It seems like this patch broke running `php tests/parser/parserTests.php` directly? See: https://phabricator.wikimedia.org/T184122 --scott On Sat, Dec 23, 2017 at 4:29 AM, Addshore wrote: > So, the patches that would need to be reverted can be found on wikitech >

Re: [Wikitech-l] First step for MCR merged: Deprecate and gut the Revision class

So, the patches that would need to be reverted can be found on wikitech https://wikitech.wikimedia.org/wiki/User:Addshore/MCR_Revert I have also created a patch with a switch wrapping the refactoring https://gerrit.wikimedia.org/r/#/c/399881/ I'm going to continue testing this code on beta over

Re: [Wikitech-l] First step for MCR merged: Deprecate and gut the Revision class

Am 23.12.2017 um 00:03 schrieb C. Scott Ananian: > I think a simple revert would be simplest. Adding a feature flag adds new > possibilities of overlooked bugs, especially since this is "just" a > refactoring and so *in theory* shouldn't be changing anything. > > Maybe we could just cherry-pick

Re: [Wikitech-l] First step for MCR merged: Deprecate and gut the Revision class

On Dec 22, 2017 3:03 PM, "C. Scott Ananian" wrote: I think a simple revert would be simplest. Adding a feature flag adds new possibilities of overlooked bugs, especially since this is "just" a refactoring and so *in theory* shouldn't be changing anything. Agreed, it's

Re: [Wikitech-l] First step for MCR merged: Deprecate and gut the Revision class

I think a simple revert would be simplest. Adding a feature flag adds new possibilities of overlooked bugs, especially since this is "just" a refactoring and so *in theory* shouldn't be changing anything. Maybe we could just cherry-pick a revert onto the Jan 2 branch, rather than revert on

Re: [Wikitech-l] First step for MCR merged: Deprecate and gut the Revision class

Woohoo! The pieces fall in place... :) -- brion On Dec 22, 2017 2:27 AM, "Daniel Kinzler" wrote: > Hello all! > > Addshore last night merged the patch[1] that is the first major step > towards > Multi-Content-Revisions[2]: it completely guts the Revision class and

Re: [Wikitech-l] First step for MCR merged: Deprecate and gut the Revision class

Am 22.12.2017 um 17:37 schrieb Chad: > Considering the code just landed last night and a good number of us are > going to be gone for vacation--is rolling this out with the Jan 2nd deploy > a little aggressive? I'd love to see this sit on beta (with eyes on it) for > a little longer. Or a way to

Re: [Wikitech-l] First step for MCR merged: Deprecate and gut the Revision class

Thanks! Context for those who don't want to read a couple hundred lines of IRC logs: I was cooped up in the house all day and noticed it was about to get dark, so I really did take a walk (relatively abruptly) after dealing with the worst of the issue. During this walk I thought things over and

Re: [Wikitech-l] First step for MCR merged: Deprecate and gut the Revision class

So the plan going forward will be to create a feature flag for the MCR Revision gutting. I'll crack on with that this evening. If that turns out to be too messy then we can revert the MCR patches for the next wmf branch. I'm currently keeping track of this @

Re: [Wikitech-l] First step for MCR merged: Deprecate and gut the Revision class

Fantastic news! Great work handling this behemoth of a technical challenge. On Fri, Dec 22, 2017 at 2:26 AM, Daniel Kinzler wrote: > Hello all! > > Addshore last night merged the patch[1] that is the first major step > towards > Multi-Content-Revisions[2]: it

Re: [Wikitech-l] First step for MCR merged: Deprecate and gut the Revision class

+1 too for Chad's concerns, especially knowing that there is still a bug opened that breaks Revision::newFromId()~[1], which is used throughout the EventBus system to create events. That said, really big congrats are in order for the MCR project. It will undoubtedly move Mediawiki and the

Re: [Wikitech-l] First step for MCR merged: Deprecate and gut the Revision class

+1 to what Chad said reg deploy and what Toby, Chad & Scott said with their kudos and appreciation :)  -Subbu. On 12/22/2017 11:00 AM, C. Scott Ananian wrote: Having just read through T183252, I feel Roan deserves a big hand for his "I take a walk and become Sherlock Holmes" detective work

Re: [Wikitech-l] First step for MCR merged: Deprecate and gut the Revision class

Having just read through T183252, I feel Roan deserves a big hand for his "I take a walk and become Sherlock Holmes" detective work and "I'm just like Indiana Jones, except with code not tombs and bugs not snakes" code archaeology. I love working with smart folks. --scott On Fri, Dec 22, 2017

Re: [Wikitech-l] First step for MCR merged: Deprecate and gut the Revision class

Congratulations Daniel and everyone who worked on this -- it's a big milestone for the structured data and the MediaWiki in general! The post-mortem is an epic read -- another round of thanks to everyone who pitched in. -Toby On Fri, Dec 22, 2017 at 2:26 AM, Daniel Kinzler

Re: [Wikitech-l] First step for MCR merged: Deprecate and gut the Revision class

Considering the code just landed last night and a good number of us are going to be gone for vacation--is rolling this out with the Jan 2nd deploy a little aggressive? I'd love to see this sit on beta (with eyes on it) for a little longer. Or a way to deploy to testwiki etc independent of major

[Wikitech-l] First step for MCR merged: Deprecate and gut the Revision class

Hello all! Addshore last night merged the patch[1] that is the first major step towards Multi-Content-Revisions[2]: it completely guts the Revision class and turns it into a thin proxy for the new RevisionStore service. The new code is now live on beta. This is our second attempt: The first one,