it were me doing this, I'd sync either in
vmx_vcpu_destroy() or in complete_domain_destroy(). But (for what it's
worth) I'm fine with it happening in rcu_do_batch().
Regards,
Dario
--
<> (Raistlin Majere)
-
t will have, at
least potentially, an impact on performance (as other solutions
envisioned in the thread). Any idea how big the hit could be?
Regards,
Dario
--
<> (Raistlin Majere)
-
Dario Faggioli, Ph.D, http://about.
On Thu, 2017-11-09 at 07:49 -0700, Jan Beulich wrote:
> See the code comment being added for why we need this.
>
> Reported-by: Igor Druzhinin <igor.druzhi...@citrix.com>
> Signed-off-by: Jan Beulich <jbeul...@suse.com>
>
Reviewed-by: Dario Faggioli <rais
t about the effect on performance, though?
I mean, assuming that lazy context switch does a good job, with respect
to that, by avoiding synching in enough case where it is actually not
necessary, how do things change if we start to sync at any softirq,
even when the handler would have not required that?
Regards
e general, as in, without even the need to
consider a second pCPU:
pCPU1
=
current == vCPU1
context_switch(next == idle)
!! __context_switch() is skipped
vcpu_migrate(vCPU1)
anything_that_uses_or_touches_context()
So, it must be anything_that_use
ning == 1 ? That should not be possible.
>
> That's not what Igor's diagram says - it's indicating the fact that
> is_running is being set to 1 in the process of context switching
> into vCPUx.
>
Ah, ok. So I was right: I indeed was misunderstanding something, i.e.,
the diagram its
considered to treat that in a special way.
But it looks to me that something very similar may, at least in theory,
happen any time a lazy context switch occurs, no matter whether the
pCPU has become idle because the previously running vCPU wants to move,
or because it blocked for whatever other re
unqueue and switch to it _only_ if it has gone through vcpu_wake(),
which must actually have woken up it, which happens if _VPF_migrating
has been cleared, which means is_running was 0 already.
Dario
--
<> (Raistlin Majere)
-
As soft-affinity and caps will be available in Xen 4.10.
Signed-off-by: Dario Faggioli <raist...@linux.it>
---
Cc: George Dunlap <george.dun...@citrix.com>
Cc: Julien Grall <julien.gr...@arm.com>
Cc: Lars Kurth <lars.ku...@xen.org>
---
Julien, doc change, so no ris
On Wed, 2017-10-11 at 14:02 -0400, Meng Xu wrote:
> Change repl_budget event output for xentrace formats and xenalyze
>
> Signed-off-by: Meng Xu <men...@cis.upenn.edu>
>
I'd say:
Reviewed-by: Dario Faggioli <raist...@linux.it>
However...
> diff --git a/tools/
On Tue, 2017-10-17 at 09:26 +0200, Dario Faggioli wrote:
> On Thu, 2017-10-12 at 10:34 -0400, Meng Xu wrote:
> > On Thu, Oct 12, 2017 at 5:02 AM, Wei Liu <wei.l...@citrix.com>
> > wrote:
> > >
> > > FYI all patches except the xentrace one were committed
it myself.
Thanks and Regards,
Dario
--
<> (Raistlin Majere)
-----
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
signature.asc
Description: This is a digitally signed message part
", budget = %"PRIu64"\n",
> + ri->dump_header, r->domid, r->vcpuid,
> + r->priority_level, r->cur_dl, r->cur_bg);
> }
> break;
> case TRC_SCHED_CLASS_
On Tue, 2017-10-10 at 19:17 -0400, Meng Xu wrote:
> Modify libxl_vcpu_sched_params_get/set and sched_rtds_vcpu_get/set
> functions to support per-VCPU extratime flag
>
> Signed-off-by: Meng Xu <men...@cis.upenn.edu>
>
Reviewed-by: Dario Faggioli <raist...@l
> Depleted queue holds VCPUs which have extratime flag cleared and
> depleted budget.
> Replenished queue is not modified.
>
> Distribution of spare bandwidth
> Spare bandwidth is distributed among all VCPUs with extratime flag
> set,
> proportional to these VCPUs utiliza
On Tue, 2017-10-10 at 19:17 -0400, Meng Xu wrote:
> Revise xl tool use case by adding -e option
> Remove work-conserving from TODO list
>
> Signed-off-by: Meng Xu <men...@cis.upenn.edu>
>
Reviewed-by: Dario Faggioli <raist...@linux.it>
Regards,
Da
On Tue, 2017-10-10 at 19:17 -0400, Meng Xu wrote:
> Change main_sched_rtds and related output functions to support
> per-VCPU extratime flag.
>
> Signed-off-by: Meng Xu <men...@cis.upenn.edu>
>
Reviewed-by: Dario Faggioli <raist...@linux.it>
Regards,
Da
On Mon, 2017-10-09 at 12:13 -0400, Meng Xu wrote:
> On Wed, Sep 13, 2017 at 8:51 PM, Dario Faggioli
> <dario.faggi...@citrix.com> wrote:
> >
> > On Fri, 2017-09-01 at 11:58 -0400, Meng Xu wrote:
> > > diff --git a/tools/xl/xl_cmdtable.c b/tools/xl/xl_cmdtable.c
&g
le committing,
> should no other reason arise for sending v4.
>
Which, AFAICS, you've done, and checked in the series.
Thanks!
Dario
--
<> (Raistlin Majere)
-----
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
si
On Thu, 2017-10-05 at 13:19 -0400, Meng Xu wrote:
> On Thu, Oct 5, 2017 at 10:28 AM, Dario Faggioli <raist...@linux.it>
> wrote:
> >
> > Soon I won't have access to dario.faggi...@citrix.com email
> > address.
>
> It's sad to hear this. :(
>
Things change.
Replace, in the 'M:' fields of the components I co-maintain
('CPU POOLS', 'SCHEDULING' and 'RTDS SCHEDULER'), the Citrix
email, to which I don't have access any longer, with my
personal email.
Signed-off-by: Dario Faggioli <raist...@linux.it>
---
Cc: Andrew Cooper <andrew.coop...@citri
'.
Regards,
Dario
---
Dario Faggioli (1):
MAINTAINERS: update entries to new email address.
MAINTAINERS |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
--
<< ... ... ... >>
----
Dario Faggioli, Ph.D, http://about.me/da
On Wed, 2017-10-04 at 14:23 +0100, George Dunlap wrote:
> On 09/15/2017 06:35 PM, Dario Faggioli wrote:
> >
> > diff --git a/xen/common/sched_credit.c b/xen/common/sched_credit.c
> > index 3efbfc8..35d0c98 100644
> > --- a/xen/common/sched_credit.c
> >
ebugging-a-flaky-cpu-steal-time-counter-on-a-parav
irtualized-xen-guest/
What's the version of your guest kernel?
Dario
--
<> (Raistlin Majere)
-----
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer,
This is kind of similar with what Linux does with scheduling classes,
but even more flexible.
I am not working on implementing this right now, because I'm busy with
other things, but I would like to do that at some point. And if you're
up for helping, that would be great! :-)
Dario
--
<> (Ra
the c2rqd() helper,
making the code more uniform and easier to read;
* requires the hook csched2_{alloc,free}_pdata to be
defined for Credit2;
* requires the assignment of new values to 'scheduler'
and 'schedule_data.sched_priv' per-cpu variables
to be moved up a bit, in csched2_switch_sched().
S
On Thu, 2017-09-28 at 18:01 +0200, Dario Faggioli wrote:
> On Thu, 2017-09-28 at 12:18 +0300, Andrii Anisov wrote:
> > > >
> The GP scheduler --like Credit1 or Credit2, if you are on Xen-- will
> give you fairness, but without any precise temporal guarantee. This
> means
header);
---
--
<> (Raistlin Majere)
-----
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R Ltd., Cambridge (UK)
signature.asc
Description: This is a digitally signed messa
And now take 3.
v1:
https://lists.xen.org/archives/html/xen-devel/2017-09/msg01855.html
v2:
https://lists.xen.org/archives/html/xen-devel/2017-09/msg03515.html
I've just took care of Jan's comments to v2. Details in single patches.
Thanks and Regards,
Dario
---
Dario Faggioli (3):
xen
the TIMER_SOFTIRQ
(which will perform the timer deactivation and run its handler).
Signed-off-by: Dario Faggioli <dario.faggi...@citrix.com>
---
Cc: Andrew Cooper <andrew.coop...@citrix.com>
Cc: George Dunlap <george.dun...@eu.citrix.com>
Cc: Jan Beulich <jbeul...@suse.com>
).
The goal is to let the period timer sefl-adjust to a
number of 'misses', of the order of 1%.
Signed-off-by: Dario Faggioli <dario.faggi...@citrix.com>
Suggested-by: George Dunlap <george.dun...@citrix.com>
Reviewed-by: Jan Beulich <jbeul...@suse.com>
---
Cc: Julien Grall <jul
) are 10, 4 or 1 ms. Default valus (used
when this parameter is not specified) is 10ms. Maximum is
100ms.
Signed-off-by: Dario Faggioli <dario.faggi...@citrix.com>
---
Cc: Jan Beulich <jbeul...@suse.com>
Cc: Julien Grall <julien.gr...@arm.com>
Cc: Andrew Cooper <andrew.coop...@c
tter to drop the 'close-loop' reference, and explain how MBA can be
useful in another way.
Regards,
Dario
--
<> (Raistlin Majere)
-
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R Ltd., Cambridge (UK)
signature.asc
Description: This
the ones which was part of that
effort, and that plans to get back to finish it at some point). You're
the maintainer, your rules. :-P :-D
Regards,
Dario
--
<> (Raistlin Majere)
-
Dario Faggioli, Ph.D, http://about.me/d
y, will result in a schedulable system, even
though you have 2 CPUs, and 2/10+2/10+80/100+80/100=2 (for Meng, I'm
talking in general, about the fact that, under gEDF, with M CPUs, U> (Raistlin Majere)
-
Dario Faggioli, Ph.D, http://abou
_timer_period_ms now isn't
> really needed outside of this function. I'd prefer if you moved it
> and the integer_param() into this function, to limit their scopes
> as much as possible.
>
Ok. idle_timer_period_ms still wants to go into __initdata, right?
Regards,
Dario
--
<> (Rai
ere you pass it a
cached value of NOW().
But I don't feel like arguing too much about this (especially now that
this is patch is the only use case).
If the problem is "just" the parameter (or maybe both the parameter's
and the function's) name(s), I 'd be happy to change the parameter name
t
---
Dario Faggioli (3):
xen: RCU: let the RCU idle timer handler run
xen: RCU: make the period of the idle timer configurable.
xen: RCU: make the period of the idle timer adaptive.
docs/misc/xen-command-line.markdown | 10 +
xen/common/rcupdate.c | 64
) are 10, 4 or 1 ms. Default valus (used
when this parameter is not specified) is 10ms. Maximum is
100ms.
Signed-off-by: Dario Faggioli <dario.faggi...@citrix.com>
---
Cc: Jan Beulich <jbeul...@suse.com>
Cc: Julien Grall <julien.gr...@arm.com>
Cc: Andrew Cooper <andrew.coop...@c
).
The goal is to let the period timer sefl-adjust to a
number of 'misses', of the order of 1%.
Signed-off-by: Dario Faggioli <dario.faggi...@citrix.com>
Suggested-by: George Dunlap <george.dun...@citrix.com>
---
Cc: Jan Beulich <jbeul...@suse.com>
Cc: Julien Grall <julien.gr..
the TIMER_SOFTIRQ
(which will perform the timer deactivation and run its handler).
Signed-off-by: Dario Faggioli <dario.faggi...@citrix.com>
---
Cc: Andrew Cooper <andrew.coop...@citrix.com>
Cc: George Dunlap <george.dun...@eu.citrix.com>
Cc: Jan Beulich <jbeul...@suse.com>
On Wed, 2017-09-27 at 15:39 +0200, Dario Faggioli wrote:
> On Wed, 2017-09-27 at 04:30 -0600, Jan Beulich wrote:
> > Or wait -
> > wouldn't all you need be to avoid calling stop_timer() in the
> > call tree above, if the timer's expiry has passed (suitably
> > explaine
t that these CPUs
are slow-- Dom0 is slow in dealing with the backends, to the point that
OSSTest times out.
Then, after the "load spike", everything goes back to normal, the
system is responsive, the logs (like the runqueue dump you posted)
depicts a normal semi-idle system.
Regards,
Dario
On Wed, 2017-09-27 at 08:57 -0400, Robert VanVossen wrote:
> On 9/26/2017 3:12 AM, Dario Faggioli wrote:
> > [Cc-list modified by removing someone and adding someone else]
> >
> > Actually, the best candidate for gaining security support, is IMO
> > ARINC. Code is als
ment)?
>
Yes. For the reason stated above, I addressed the problem at the
generic code level. If that doesn't fly, I'll do like this. I had
thought about that, and although I haven't tried, I think it works for
this case.
Thanks and Regards,
Dario
--
<> (Raistlin Majere)
-
more often that I would want
to. :-(
I'll try to be more careful.
> Signed-off-by: Wei Liu <wei.l...@citrix.com>
> ---
> Cc: George Dunlap <george.dun...@eu.citrix.com>
> Cc: Dario Faggioli <dario.faggi...@citrix.com>
> Cc: Marek Marczykowski-Górecki <marma.
redit2.c
> +++ b/xen/common/sched_credit2.c
> @@ -2831,6 +2831,7 @@ csched2_dom_cntl(
> if ( op->u.credit2.cap > 100 * sdom->nr_vcpus )
> {
> rc = -EINVAL;
> +write_unlock_irqrestore(>lock, flags);
>
Indeed...
ed on
the CPU wake-up-from-idle path).
It is important (in the new version of this patch) for deactivation to
be skipped only in stop_timer(), and not, e.g., in kill_timer(). As, if
someone, in future, will want to kill and free the timer during the
window, then in that case the handler *must* not ru
On Tue, 2017-09-26 at 18:28 +0100, Julien Grall wrote:
> On 09/26/2017 08:33 AM, Dario Faggioli wrote:
> > >
> > Here's the logs:
> > http://logs.test-lab.xenproject.org/osstest/logs/113816/test-armhf-
> > armhf-xl-rtds/info.html
>
> It does not seem to be sim
t
we missed handling a timer interrupt, we should run it then.
Unfortunately, for achieving this, e.g., in the set_timer() case, I
don't see much alternatives to call execute_timer() right in there. But
that would violate the current invariant that execute_timer() only run
from the TIMER_SOFTIRQ handler
_DECR);
> > +}
>
> Pointless braces. And do you really need min_t()/max_t() here,
> rather than just min()/max()?
>
I probably can. This must be a leftover from a version when the time of
idle_timer_period, and of the IDLE_TIMER_PERIOD_{MIN,MAX} constants
wasn't mat
y zero would be
> a rather bad choice?
>
Indeed I should enforce a meaningful min too (I'll take it from patch 3
and put it here).
> Also can you please switch to - as the separator in the command
> line argument name?
>
Ah, ok.
Thanks and Regards,
Dario
--
<> (
On Mon, 2017-09-25 at 17:23 +0100, Julien Grall wrote:
> On 09/25/2017 03:07 PM, Dario Faggioli wrote:
> > I don't see much in the logs, TBH, but both `xl vcpu-list' and the
> > 'r'
> > debug key seem to suggest that vCPU 0 is running, while the other
> > vCPUs
, is IMO
ARINC. Code is also rather simple and "stable" (hasn't changed in the
last... years!) and it's used by DornerWorks' people for some of their
projects (I think?). It's also not tested in OSSTest, though, and
considering how special purpose it is, I think we're not totally
comfor
On Mon, 2017-09-25 at 17:23 +0100, Julien Grall wrote:
> On 09/25/2017 03:07 PM, Dario Faggioli wrote:
> > Hey,
>
> Hi Dario,
>
Hi!
> > I don't see much in the logs, TBH, but both `xl vcpu-list' and the
> > 'r'
> > debug key seem to suggest that vCPU 0 i
is is just
> routine catch up, or to bring in any specific changes we need?
>
What we have right now, does not build, e.g., with gcc 7.2:
https://pastebin.com/xgeJHkdL
Which, I agree, should be mentioned/hinted at in the changelog.
Regards,
Dario
--
<> (Raistlin Majere)
-
eople? Does this ring any bell? Is this something known, or
easy to explain? What can I do for help?
Regards,
Dario
--
<> (Raistlin Majere)
-----
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citri
when IRQs are enabled.
Signed-off-by: Dario Faggioli <dario.faggi...@citrix.com>
---
Cc: osstest service owner <osstest-ad...@xenproject.org>
Cc: George Dunlap <george.dun...@eu.citrix.com>
Cc: Wei Liu <wei.l...@citrix.com>
Cc: Roger Pau Monné <roger@citrix.co
t
Thanks and Regards,
Dario
--
<> (Raistlin Majere)
-----
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R Ltd., Cambridge (UK)
signature.asc
D
r to need to walk the domain
> list, but should that change, this would be a bear of a bug to find.
>
Indeed it's rather unlikely for the replenishment handler to have to
use sdom_elem to go through the list of domains.
IAC, if you're concerned about that, I'd much rather put both
kill_time
On Fri, 2017-09-15 at 12:01 -0400, Meng Xu wrote:
> On Wed, Sep 13, 2017 at 8:16 PM, Dario Faggioli
> <dario.faggi...@citrix.com> wrote:
> >
> > > I'm ok with what it is in this patch, although I feel that we can
> > > k
owledge to update it, then fine.
But, technically, the Wiki can be updated and, if possible, it should
be.
Regards,
Dario
--
<> (Raistlin Majere)
-
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engine
On Mon, 2017-09-18 at 20:42 +0100, Anshul Makkar wrote:
>
> On 9/15/17 6:35 PM, Dario Faggioli wrote:
> > Hello,
> >
> > Dario Faggioli (4):
> > xen: sched: introduce 'adjust_affinity' hook.
> > xen: sched: optimize exclusive pinning case
when IRQs are enabled.
Signed-off-by: Dario Faggioli <dario.faggi...@citrix.com>
---
Cc: osstest service owner <osstest-ad...@xenproject.org>
Cc: George Dunlap <george.dun...@eu.citrix.com>
Cc: Wei Liu <wei.l...@citrix.com>
---
This was spotted by OSSTest's flight 113562:
h
() being inside the critical section (which
> disables
> irqs); there's actually an xfree() right in that function outside the
> critical section.
>
So, during the afternoon, there was an glitch here, in the local
network/NAS of my home office.
It took me a bit to fix it, and that delay
. to timers stopped during the wakeup
from idle (e.g., C-states, on x86) path.
To fix that, don't deactivate a timer, while stopping it,
if it has expired. On the contrary, when that happens,
(re-)raise the timer softirq, to make sure the handler is
invoked.
Signed-off-by: Dario Faggioli <dario.fa
) are 10, 4 or 1 ms. Default valus (used
when this parameter is not specified) is 10ms. Maximum is
100ms.
Signed-off-by: Dario Faggioli <dario.faggi...@citrix.com>
---
Cc: Jan Beulich <jbeul...@suse.com>
Cc: Julien Grall <julien.gr...@arm.com>
Cc: Andrew Cooper <andrew.coop...@c
for this series, as, without it, the RCU idle timer
handler is never run (and hence, George's algorithm can't work :-/).
Regards,
Dario
---
Dario Faggioli (3):
xen: timers: don't miss a timer event because of stop_timer()
xen: RCU: make the period of the idle timer configurable.
xen: RCU
).
The goal is to let the period timer sefl-adjust to a
number of 'misses', of the order of 1%.
Signed-off-by: Dario Faggioli <dario.faggi...@citrix.com>
Suggested-by: George Dunlap <george.dun...@citrix.com>
---
Cc: Jan Beulich <jbeul...@suse.com>
Cc: Julien Grall <julien.gr..
and/or of what pCPUs are part
of the cpupool where the vCPU lives, and that's rather
impractical to store in a per-vCPU flag. Still the
overhead is reduced to "just" one cpumask_subset() (and
only if the newly introduced flag is 'true')!
Signed-off-by: Dario Faggioli <dario.faggi.
enough, so go
for it.
Signed-off-by: Dario Faggioli <dario.faggi...@citrix.com>
---
Cc: George Dunlap <george.dun...@citrix.com>
Cc: Anshul Makkar <anshulmak...@gmail.com>
---
Changes from v1:
- use a flag during runtime, as suggested during review;
- make use of the af
conditions that, despite the fact
that they rarely change, are right now checked very
frequently, even in hot paths.
Note also that this, in future, may turn out as a useful
mean for, e.g., having the schedulers vet, ack or nack
the changes themselves.
Signed-off-by: Dario Faggioli <dario.faggi...@citri
are
necessary to make the other twos possible.
Regards,
Dario
---
Dario Faggioli (4):
xen: sched: introduce 'adjust_affinity' hook.
xen: sched: optimize exclusive pinning case (Credit1 & 2)
xen: sched: improve checking soft-affinity
xen: sched: simplify (and speedup) chec
exception _csched_cpu_pick()
(in Credit1 code).
Signed-off-by: Dario Faggioli <dario.faggi...@citrix.com>
---
Cc: George Dunlap <george.dun...@citrix.com>
Cc: Anshul Makkar <anshulmak...@gmail.com>
---
xen/common/sched_credit.c | 79 +-
le {
> -unsigned ratelimit_us;
> -};
> -typedef struct xen_sysctl_credit2_schedule
> xen_sysctl_credit2_schedule_t;
> -DEFINE_XEN_GUEST_HANDLE(xen_sysctl_credit2_schedule_t);
> -
>
You're mixing moving and changing code. This is something we prefer to
that the series won't
compile with this patch at the front), this patch looks fine to me.
Regards,
Dario
--
<> (Raistlin Majere)
-----
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Sy
am_t param;
> >
> > static char *kwd_list[] = { "pool", "sched", NULL };
>
> [..]
> Another possibility would be to drop the cpupool python bindings
> completely (which I would prefer, TBH).
>
+1
Regards,
Dario
--
<> (Rais
ine bool has_extratime(const struct rt_vcpu *svc)
> +{
> +return (svc->flags & RTDS_extratime) ? 1 : 0;
> +}
> +
'true' and 'false'. But I think
return svc->flags & RTDS_extratime
is just fine already, without any need for the ?: operator.
The rest of the patch lo
On Fri, 2017-09-01 at 11:58 -0400, Meng Xu wrote:
> Revise xl tool use case by adding -e option
> Remove work-conserving from TODO list
>
> Signed-off-by: Meng Xu <men...@cis.upenn.edu>
>
Reviewed-by: Dario Faggioli <dario.faggi...@citrix.com>
Regards,
Da
tools/xl/xl_sched.c| 56 ++
>
>
Oh, and this patch must update docs/man/xl.pod.1.in as well.
Dario
--
<> (Raistlin Majere)
-----
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Enginee
dline =
> 0x%(4)08x%(3)08x, cur_budget = 0x%(6)08x%(5)08x ]
>
Why 0x%(2)08d, and not just %(2)d ?
Have you tested it? What does it print?
Dario
--
<> (Raistlin Majere)
-
Dario Faggioli, Ph.D, http://about.me/dario.faggio
c, char **argv)
> xmalloc(sizeof(libxl_sched_params));
> scinfo.vcpus[0].period = periods[0];
> scinfo.vcpus[0].budget = budgets[0];
> +scinfo.vcpus[0].extratime = extratimes[0] ? 1 : 0;
>
But does these two hunks mean that if I pass `-e 10`, that is
considered a legal wa
u say 'But') is that a problem?
> I'm ok with what it is in this patch, although I feel that we can
> kill the
> if (scinfo->extratime != LIBXL_DOMAIN_SCHED_PARAM_EXTRATIME_DEFAULT)
> because LIBXL_DOMAIN_SCHED_PARAM_EXTRATIME_DEFAULT is -1.
>
No, sorry, I don't understand what you mean here...
Dario
--
&
OMCTL_SCHEDRT_extra
? 1 : 0
or:
scinfo->vcpus[i].extratime = !!(vcpus[i].u.rtds.flags &
XEN_DOMCTL_SCHEDRT_extra);
Regards,
Dario
--
<> (Raistlin Majere)
-
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software
The patch introduces yet another runqueue arrangement option
for Credit2. In fact, it allows the user to specify, explicitly
and precisely, what pCPUs should belong to which runqueue.
Signed-off-by: Dario Faggioli <dario.faggi...@citrix.com>
Signed-off-by: Praveen Kumar <kpraveen.l...@
rio. Most of the code looks
> mechanical.
>
Yes, this is on my radar. I'll be able to look at it shortly.
Dario
--
<> (Raistlin Majere)
-
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software
p, even on a totally
idle system, while ARM doesn't. But this should not be a problem as, in
both cases, if there's pages to scrub, the CPU just won't go to sleep.
If frequent wakeups is what causes the scrubbing to work ok on the x86,
and not on ARM, it IMO means that there's something like
pe,
> - make x86's paging_domctl() and descendants take a properly typed
> handle,
> - add const in a few places.
>
> Signed-off-by: Jan Beulich <jbeul...@suse.com>
>
Acked-by: Dario Faggioli <dario.faggi...@citrix
On Tue, 2017-09-12 at 09:10 -0600, Jan Beulich wrote:
> By virtue of the struct xen_sysctl container structure, most of them
> are really just cluttering the name space.
>
> Signed-off-by: Jan Beulich <jbeul...@suse.com>
>
Acked-by: Dario Faggioli <dario.faggi...@cit
dding it to OSSTest, at which point, we can start
to think about calling it supported.
Dario
--
<> (Raistlin Majere)
-
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R Ltd., Cambridge (UK)
signature.asc
Description: This is a digital
hile trying to help you, is that
I can't see what you are doing, and how you're changing the code.
Regards,
Dario
--
<> (Raistlin Majere)
-
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R Ltd., Camb
;
> I think, literally, the 'Faulting linear address' is key point
> because I heard that it represents bad address that I should never
> access.
>
It is, but the only way of understanding why you hit such an access
violation, is understand what the code is doing when it happens.
Regards,
D
On Wed, 2017-09-06 at 12:29 -0700, Stefano Stabellini wrote:
> On Wed, 6 Sep 2017, Dario Faggioli wrote:
> >
> > Or, in general, make sense out of the fact that the stack pointer
> > register changes in such a way that, when we get back in
> > do_softirq(),
> >
On Tue, 2017-08-29 at 17:30 +0100, George Dunlap wrote:
> On 08/18/2017 07:04 PM, Dario Faggioli wrote:
> >
> > What we're trying to avoid is one of those idle CPUs to
> > wake up, only to discover that the grace period is still
> > running, and that it hence
On Tue, 2017-09-05 at 15:06 -0700, Stefano Stabellini wrote:
> On Tue, 5 Sep 2017, Dario Faggioli wrote:
> >
> > Re-checking things now, I actually do see that context_switch() on
> > ARM
> > is not 'terminal'. It call schedule_tail(), which on x86 does not
> >
On Fri, 2017-06-09 at 18:41 +0200, Dario Faggioli wrote:
> Hey Praveen,
>
Hey, hello again!
> Here we are, sorry for the delay.
>
So, about this patch... I haven't seen a new version (or did I perhaps
miss it?).
I'm asking because I do have it half done myself, and it would not t
On Thu, 2017-08-24 at 20:42 +0100, Anshul Makkar wrote:
> On 8/18/17 4:50 PM, Dario Faggioli wrote:
> >
> > @@ -1515,7 +1633,16 @@ static void reset_credit(const struct
> > scheduler *ops, int cpu, s_time_t now,
> > * that the credit it has
le.
> > > > + */
> > > > +#define RCU_IDLE_TIMER_PERIOD MILLISECS(10)
> > >
> > > With you even mentioning that the original Linux code has ways
> > > to use different values, wouldn't it be worth allowing this to be
> > > command line c
not
getting at all how continue_new_vcpu() works (e.g., when/how is it
invoked?).
Thanks and Regards,
Dario
--
<> (Raistlin Majere)
-
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems
Il 29 Ago 2017 4:03 PM, George Dunlap <george.dun...@eu.citrix.com> ha scritto:
On Wed, Aug 16, 2017 at 5:45 PM, Dario Faggioli
<dario.faggi...@citrix.com> wrote:
> In fact, right now, we read it at every iteration of the loop.
> The reason it's done like this is how context
1 - 100 of 2173 matches
Mail list logo
