[Xen-devel] [PATCH] sg-run-job: guest-start/repeat: Run 30 times, not 10

2017-11-22 Thread Ian Jackson
We are experiencing intermittent failures right now with the ARM credit2 tests. I suspect the failure probability is low. CC: Julien Grall <julien.gr...@arm.com> Signed-off-by: Ian Jackson <ian.jack...@eu.citrix.com> --- sg-run-job |2 +- 1 file changed, 1 insertion(+), 1 delet

Re: [Xen-devel] [PATCH 10/16] SUPPORT.md: Add Debugging, analysis, crash post-portem

2017-11-21 Thread Ian Jackson
George Dunlap writes ("Re: [PATCH 10/16] SUPPORT.md: Add Debugging, analysis, crash post-portem"): > gdbsx security support: Someone may want to debug an untrusted guest, > so I think we should say 'yes' here. I think running gdb on an potentially hostile program is foolish. > I don't have a

Re: [Xen-devel] [PATCH 03/16] SUPPORT.md: Add some x86 features

2017-11-21 Thread Ian Jackson
Jan Beulich writes ("Re: [PATCH 03/16] SUPPORT.md: Add some x86 features"): > Much depends on whether you think "guest" == "DomU". To me > Dom0 is a guest, too. Not to me. I'm with George. (As far as I can make out his message, which I think was sent with HTML-style quoting which some Citrix

Re: [Xen-devel] [xen-4.6-testing test] 116250: regressions - FAIL

2017-11-20 Thread Ian Jackson
osstest service owner writes ("[xen-4.6-testing test] 116250: regressions - FAIL"): > flight 116250 xen-4.6-testing real [real] > http://logs.test-lab.xenproject.org/osstest/logs/116250/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which could not be

Re: [Xen-devel] [xen-4.5-testing test] 116245: regressions - FAIL

2017-11-20 Thread Ian Jackson
osstest service owner writes ("[xen-4.5-testing test] 116245: regressions - FAIL"): > flight 116245 xen-4.5-testing real [real] > http://logs.test-lab.xenproject.org/osstest/logs/116245/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which could not be

Re: [Xen-devel] [xen-4.6-testing test] 116222: regressions - FAIL

2017-11-17 Thread Ian Jackson
osstest service owner writes ("[xen-4.6-testing test] 116222: regressions - FAIL"): > flight 116222 xen-4.6-testing real [real] > http://logs.test-lab.xenproject.org/osstest/logs/116222/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which could not be

Re: [Xen-devel] [xen-4.8-testing test] 116221: regressions - FAIL

2017-11-17 Thread Ian Jackson
osstest service owner writes ("[xen-4.8-testing test] 116221: regressions - FAIL"): > flight 116221 xen-4.8-testing real [real] > http://logs.test-lab.xenproject.org/osstest/logs/116221/ > > Regressions :-( ... > version targeted for testing: > xen

Re: [Xen-devel] [BUG] Error applying XSA240 update 5 on 4.8 and 4.9 (patch 3 references CONFIG_PV_LINEAR_PT, 3285e75dea89, x86/mm: Make PV linear pagetables optional)

2017-11-16 Thread Ian Jackson
George Dunlap writes ("Re: [BUG] Error applying XSA240 update 5 on 4.8 and 4.9 (patch 3 references CONFIG_PV_LINEAR_PT, 3285e75dea89, x86/mm: Make PV linear pagetables optional)"): > These are two different things. Steve's reluctance to backport a > potentially arbitrary number of

Re: [Xen-devel] [OSSTEST PATCH] ts-xen-build-prep: Install libelf-dev for benefit of linux.git

2017-11-15 Thread Ian Jackson
Juergen Gross writes ("Re: [OSSTEST PATCH] ts-xen-build-prep: Install libelf-dev for benefit of linux.git"): > The kernel now is using objtool to create unwind information. This needs > libelf to work. Advantage is that this approach no longer depends on > assembler sources being heavily

[Xen-devel] [OSSTEST PATCH] ts-xen-build-prep: Install libelf-dev for benefit of linux.git

2017-11-15 Thread Ian Jackson
rnel.org> CC: Boris Ostrovsky <boris.ostrov...@oracle.com> CC: Juergen Gross <jgr...@suse.com> CC: Paul Durrant <paul.durr...@citrix.com> CC: Wei Liu <wei.l...@citrix.com> Signed-off-by: Ian Jackson <ian.jack...@eu.citrix.com> --- ts-xen-build-prep | 1 + 1 file changed,

Re: [Xen-devel] [PATCH] tools: xentoolcore_restrict_all: Do deregistration before close

2017-11-14 Thread Ian Jackson
Ross Lagerwall writes ("Re: [PATCH] tools: xentoolcore_restrict_all: Do deregistration before close"): > On 11/14/2017 12:15 PM, Ian Jackson wrote: > > + * Note for multi-threaded programs: If xentoolcore_restrict_all is > > + * called concurrently with a function whi

Re: [Xen-devel] [PATCH for-4.10] tools: xentoolcore_restrict_all: Do deregistration before close

2017-11-14 Thread Ian Jackson
Julien Grall writes ("Re: [PATCH] tools: xentoolcore_restrict_all: Do deregistration before close"): > I think this is 4.10 material, xentoolcore was introduced in this > release and it would be good to have it right from now. I want to > confirm that you are both happy with that? Yes,

[Xen-devel] [PATCH] tools: xentoolcore_restrict_all: Do deregistration before close

2017-11-14 Thread Ian Jackson
/null", thing->fd); pthread_mutex_lock(_lock); thing->fd = -1; pthread_mutex_unlock(_lock); close(fd); which would be terribly tedious. Signed-off-by: Ian Jackson <ian.jack...@eu.citrix.com> --- tools/libs/call/core.c | 4 ++-- tools/l

Re: [Xen-devel] [PATCH for-4.10] libs/evtchn: Remove active handler on clean-up or failure

2017-11-14 Thread Ian Jackson
Ross Lagerwall writes ("Re: [PATCH for-4.10] libs/evtchn: Remove active handler on clean-up or failure"): > Now that I look at it, a similar scenario can happen during open. Since > the handle is registered before it is actually opened, a concurrent > xentoolcore_restrict_all() will try to

Re: [Xen-devel] [PATCH for-4.10] libs/evtchn: Remove active handler on clean-up or failure

2017-11-14 Thread Ian Jackson
sh the application later one. Sorry for not spotting this during review. The fix is correct as far as it goes, so: Acked-by: Ian Jackson <ian.jack...@eu.citrix.com> > > The call to xentoolcore_deregister_active_handle is done at the same > > place as for the grants. But I am not co

Re: [Xen-devel] [PATCH v1] tools/hotplug: convert proc-xen.mount to proc-xen.service

2017-11-09 Thread Ian Jackson
Olaf Hering writes ("Re: [Xen-devel] [PATCH v1] tools/hotplug: convert proc-xen.mount to proc-xen.service"): > On Wed, Nov 08, Wei Liu wrote: > > But is there really no way to ask nicely to see if systemd would accept > > a change in behaviour? That is, to make proc-xen.mount (or any attempt > >

Re: [Xen-devel] Bringing up OSS test framework on moonshot(aarch64) systems

2017-11-08 Thread Ian Jackson
Julien Grall writes ("Re: Bringing up OSS test framework on moonshot(aarch64) systems"): > On 08/11/17 11:39, Ian Jackson wrote: > > I'm not familiar with the referent of "moonshot" in this context. IME > > "moonshot" is a project name chosen multiple

Re: [Xen-devel] [linux-linus test] 115643: regressions - FAIL

2017-11-08 Thread Ian Jackson
osstest service owner writes ("[linux-linus test] 115643: regressions - FAIL"): > flight 115643 linux-linus real [real] > http://logs.test-lab.xenproject.org/osstest/logs/115643/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which could not be run: >

Re: [Xen-devel] [linux-4.9 test] 115504: regressions - FAIL

2017-11-08 Thread Ian Jackson
Roger Pau Monné writes ("Re: [Xen-devel] [linux-4.9 test] 115504: regressions - FAIL"): > On Fri, Nov 03, 2017 at 08:21:31PM +, osstest service owner wrote: > > flight 115504 linux-4.9 real [real] > > http://logs.test-lab.xenproject.org/osstest/logs/115504/ > > > > Regressions :-( > > > >

Re: [Xen-devel] Bringing up OSS test framework on moonshot(aarch64) systems

2017-11-08 Thread Ian Jackson
Bhupinder Thakur writes ("Bringing up OSS test framework on moonshot(aarch64) systems"): > While going through [1], I have some queries/doubts on the configuration. > > 1. The following configuration: > > DnsDomain uk.xensource.com > NetNameservers 10.80.248.2 10.80.16.28 10.80.16.67 >

Re: [Xen-devel] [Qemu-devel] [PATCH 7/8] os-posix: Provide new -runasid option

2017-11-08 Thread Ian Jackson
Markus Armbruster writes ("Re: [Qemu-devel] [PATCH 7/8] os-posix: Provide new -runasid option"): > Ian Jackson <ian.jack...@eu.citrix.com> writes: > > qemu_strtoul fails (returns an error) if the delimiter (that is, the > > first character which is no

[Xen-devel] [OSSTEST PATCH 1/2] mg-force-push: New script

2017-11-06 Thread Ian Jackson
This does some safety checks and reduces the risk of c mistakes. It has to be run as osst...@osstest.test-lab (or equivalent). Signed-off-by: Ian Jackson <ian.jack...@eu.citrix.com> --- mg-force-push | 121 ++ 1 file changed, 121 inse

[Xen-devel] [OSSTEST PATCH 2/2] ap-push: turn off set -x

2017-11-06 Thread Ian Jackson
This makes the output of mg-force-push quite unpleasant, amongst other things. Signed-off-by: Ian Jackson <ian.jack...@eu.citrix.com> --- ap-push | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ap-push b/ap-push index a27ccc2..6c95b1f 100755 --- a/ap-push +++ b/a

Re: [Xen-devel] [linux-4.9 test] 115538: regressions - FAIL

2017-11-06 Thread Ian Jackson
osstest service owner writes ("[linux-4.9 test] 115538: regressions - FAIL"): > flight 115538 linux-4.9 real [real] > http://logs.test-lab.xenproject.org/osstest/logs/115538/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which could not be run: >

Re: [Xen-devel] [Qemu-devel] [PATCH 7/8] os-posix: Provide new -runasid option

2017-11-06 Thread Ian Jackson
Hi. Thanks for the (re)-review. Markus Armbruster writes ("Re: [Qemu-devel] [PATCH 7/8] os-posix: Provide new -runasid option"): > Ian Jackson <ian.jack...@eu.citrix.com> writes: > > +case QEMU_OPTION_runasid: > > +errno = 0; > > +

Re: [Xen-devel] [PATCH for-next 1/9] gcov: return ENOSYS for unimplemented gcov domctl

2017-11-06 Thread Ian Jackson
Jan Beulich writes ("Re: [PATCH for-next 1/9] gcov: return ENOSYS for unimplemented gcov domctl"): > On 26.10.17 at 11:19, wrote: > > --- a/xen/common/gcov/gcov.c > > +++ b/xen/common/gcov/gcov.c > > @@ -239,7 +239,7 @@ int sysctl_gcov_op(struct xen_sysctl_gcov_op *op) > >

Re: [Xen-devel] [OSSTEST PATCH 2/2] make-flight: guest should use jessie to test pvgrub

2017-11-03 Thread Ian Jackson
Wei Liu writes ("[OSSTEST PATCH 2/2] make-flight: guest should use jessie to test pvgrub"): > Stretch has 64bit feature enabled for ext4, which pvgrub can't cope. > We want to continue to test pvgrub, so specify jessie in the guest > suite field. I'm not entirely comfortable with the hardcoding

Re: [Xen-devel] Commit moratorium to staging

2017-11-03 Thread Ian Jackson
George Dunlap writes ("Re: [Xen-devel] Commit moratorium to staging"): > Well, with a looping xen-build going on in the guest, I've done 40 local > migrates with no problems yet. > > But Roger -- is this on emulated devices only, no PV drivers? Yes. None of our Windows tests have PV drivers.

Re: [Xen-devel] [PATCH v2] osstest: fix rm to use '-f' in ts-freebsd-host-install

2017-11-03 Thread Ian Jackson
Roger Pau Monne writes ("[PATCH v2] osstest: fix rm to use '-f' in ts-freebsd-host-install"): > It's perfectly valid for the .tmp file to not exists, and the script > shouldn't fail in that case. Acked-by: Ian Jackson <ian.ja

Re: [Xen-devel] [PATCH] osstest: remove unneeded rm in ts-freebsd-host-install

2017-11-03 Thread Ian Jackson
Roger Pau Monne writes ("[PATCH] osstest: remove unneeded rm in ts-freebsd-host-install"): > The usage of `rm` here is wrong for two reasons: > > - It will fail if $sharedpath.tmp doesn't exist and report and error >(ie: -f should be used). > - It's not needed because dd will truncate

Re: [Xen-devel] [OSSTEST PATCH 1/2] ts-debian-di-install: use gho to pick d-i

2017-11-03 Thread Ian Jackson
Wei Liu writes ("[OSSTEST PATCH 1/2] ts-debian-di-install: use gho to pick d-i"): > The original code used ho which gave us the host suite, but we wanted > the guest suite. Acked-by: Ian Jackson <ian.jack...@eu.citrix.com> ___

[Xen-devel] [OSSTEST PATCH] migrations: Do x10 migration 20x instead

2017-11-03 Thread Ian Jackson
We want to keep the old testid or some new failures will be "never pass". Roger reports that this change makes the existing host-specific Windows migration failures fail everywhere, so so things may need force pushing. CC: Roger Pau Monné <roger@citrix.com> Signed-off

Re: [Xen-devel] Commit moratorium to staging [and 1 more messages]

2017-11-02 Thread Ian Jackson
Julien Grall writes ("Re: Commit moratorium to staging"): > Thank you for the explanation. I agree with the force push to unblock > master (and other tree I mentioned). I will force push all the affected trees, but in a reactive way because I base each force push on a test report - so it won't

Re: [Xen-devel] Commit moratorium to staging

2017-11-02 Thread Ian Jackson
Roger Pau Monné writes ("Re: [Xen-devel] Commit moratorium to staging"): > Is there anyway to get that from windows in an automatic way? If not I > could test that with a Debian guest. In fact it might even be a good > thing for Linux based guest to be added to the regular migration tests > in

Re: [Xen-devel] Commit moratorium to staging

2017-11-01 Thread Ian Jackson
Julien Grall writes ("Re: Commit moratorium to staging"): > Hi Ian, > > Thank you for the detailed e-mail. > > On 11/01/2017 02:07 PM, Ian Jackson wrote: > > Furthermore, the test is not intermittent, so a force push will be > > effective in the following

Re: [Xen-devel] Commit moratorium to staging

2017-11-01 Thread Ian Jackson
So, investigations (mostly by Roger, and also a bit of archaeology in the osstest db by me) have determined: * This bug is 100% reproducible on affected hosts. The repro is to boot the Windows guest, save/restore it, then migrate it, then shut down. (This is from an IRL conversation with

Re: [Xen-devel] [PATCH v3 for-4.10] scripts: introduce a script for build test

2017-10-30 Thread Ian Jackson
Wei Liu writes ("[PATCH v3 for-4.10] scripts: introduce a script for build test"): > Signed-off-by: Ian Jackson <ian.jack...@eu.citrix.com> > Signed-off-by: Wei Liu <wei.l...@citrix.com> ... ... > +trap "echo Restoring original HEAD ; git checkout $ORIG_BRA

Re: [Xen-devel] [PATCH for-4.10] tools/hotplug: create XEN_LOG_DIR at runtime

2017-10-30 Thread Ian Jackson
.@citrix.com> > > Julien I think we should apply this for 4.10. I agree. Subject line tag added. Acked-by: Ian Jackson <ian.jack...@eu.citrix.com> Ian. ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 12/16] osstest: add script to install build dependencies on FreeBSD

2017-10-27 Thread Ian Jackson
Roger Pau Monne writes ("[PATCH 12/16] osstest: add script to install build dependencies on FreeBSD"): > Since at the moment osstest only builds FreeBSD on FreeBSD, there are > no dependencies to install. Just mark the host as ready to share. Acked-by: Ian Jackson <ian.ja

Re: [Xen-devel] [PATCH 14/16] osstest: add support for FreeBSD buildjobs to sg-run-job

2017-10-27 Thread Ian Jackson
Roger Pau Monne writes ("[PATCH 14/16] osstest: add support for FreeBSD buildjobs to sg-run-job"): > Add support and introduce a FreeBSD build job to sg-run-job. Acked-by: Ian Jackson <ian.jack...@eu.citrix.com> ___ Xen-devel mai

Re: [Xen-devel] [PATCH 04/16] osstest: introduce host_shared_mark_ready

2017-10-27 Thread Ian Jackson
--- > Changes since v13: > - s/resource_shared_mark_ready/host_shared_mark_ready/. > - First argument of jobdb_resource_shared_mark_ready must be 'host'. Although it would be good to mention that you are fixing a bug here, to wit the $ho->{Ident} to 'host' change. Acked-by: Ian Jacks

[Xen-devel] [OSSTEST PATCH 1/2] resource_shared_mark_ready: Fix for non-`host' idents; fix $sharetype

2017-10-27 Thread Ian Jackson
lso `$resource' here is the wrong variable name. This is actually the $sharetype (as is evident from jobdb_resource_shared_mark_ready and what is now executive_resource_shared_mark_ready). CC: Roger Pau Monné <roger@citrix.com> Signed-off-by: Ian Jackson <ian.jack...@eu.citrix.com&g

[Xen-devel] [OSSTEST PATCH 2/2] host_shared_mark_ready: rename from resource_shared_mark_ready

2017-10-27 Thread Ian Jackson
This function only works on resource of restype `host'. Ie, hosts. Signed-off-by: Ian Jackson <ian.jack...@eu.citrix.com> CC: Roger Pau Monné <roger@citrix.com> --- Osstest/TestSupport.pm | 4 ++-- ts-freebsd-host-install | 4 ++-- ts-xen-build-prep | 2 +- 3 file

Re: [Xen-devel] [PATCH for-4.10] tools/xenstored: Check number of strings passed to do_control()

2017-10-27 Thread Ian Jackson
from within dom0 (there > is a check in do_control() rejecting all non-dom0 requests with > an EACCES). Acked-by: Ian Jackson <ian.jack...@eu.citrix.com> (Added the for-4.10 tag to the Subject.) Ian. ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v6 07/20] osstest: introduce resource_shared_mark_ready

2017-10-27 Thread Ian Jackson
Roger Pau Monne writes ("[PATCH v6 07/20] osstest: introduce resource_shared_mark_ready"): > That allows marking a host as ready to be shared. Replace the current > caller that open-codes it. ... > -$mjobdb->jobdb_resource_shared_mark_ready > - ($ho->{Ident}, $ho->{Name},

Re: [Xen-devel] [PATCH for-4.10 1/9] gcov: return ENOSYS for unimplemented gcov domctl

2017-10-27 Thread Ian Jackson
Roger Pau Monne writes ("[PATCH for-next 1/9] gcov: return ENOSYS for unimplemented gcov domctl"): > Signed-off-by: Roger Pau Monné <roger@citrix.com> ... > default: > -ret = -EINVAL; > +ret = -ENOSYS; > break; > }

Re: [Xen-devel] [PATCH v5.1 8/8] configure: do_compiler: Dump some extra info under bash

2017-10-27 Thread Ian Jackson
Stefano Stabellini writes ("Re: [PATCH v5.1 8/8] configure: do_compiler: Dump some extra info under bash"): > CC'ing the maintainers for this. Thanks, but scripts/get_maintainer.pl seems to print different information for me... (see my other mail) Ian.

Re: [Xen-devel] [PATCH v5.1 7/8] os-posix: Provide new -runas : facility

2017-10-27 Thread Ian Jackson
inting recent contributors. get_maintainer.pl: Do not blindly cc: them on patches! Use common sense. Anthony PERARD <anthony.per...@citrix.com> (commit_signer:1/2=50%) Paolo Bonzini <pbonz...@redhat.com> (commit_signer:1/2=50%,commit_signer:11/57=19%) Ian Jackson <ian.jack...@eu.

Re: [Xen-devel] [PATCH v5.1 2/8] xen: restrict: use xentoolcore_restrict_all

2017-10-27 Thread Ian Jackson
Stefano Stabellini writes ("Re: [PATCH v5.1 2/8] xen: restrict: use xentoolcore_restrict_all"): > On Fri, 20 Oct 2017, Ian Jackson wrote: ... > > Drop individual use of xendevicemodel_restrict and > > xenforeignmemory_restrict. These are not actually effective in

Re: [Xen-devel] [PATCH v5.1 6/8] xen: destroy_hvm_domain: Try xendevicemodel_shutdown

2017-10-27 Thread Ian Jackson
Stefano Stabellini writes ("Re: [PATCH v5.1 6/8] xen: destroy_hvm_domain: Try xendevicemodel_shutdown"): > On Fri, 20 Oct 2017, Ian Jackson wrote: > > xc_interface_open etc. is not going to work if we have dropped > > privilege, but xendevicemodel_shutdown will if eve

Re: [Xen-devel] [PATCH v5.1 1/8] xen: link against xentoolcore

2017-10-27 Thread Ian Jackson
Stefano Stabellini writes ("Re: [PATCH v5.1 1/8] xen: link against xentoolcore"): > On Fri, 20 Oct 2017, Ian Jackson wrote: > >then > > - xen_stable_libs="-lxendevicemodel $xen_stable_libs" > > + xen_stable_libs="-

Re: [Xen-devel] [PATCH v2] scripts: introduce a script for build test

2017-10-25 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH v2] scripts: introduce a script for build test"): > On Wed, Oct 25, 2017 at 04:25:21PM +0100, Ian Jackson wrote: > > If you are worried about this you should check that there are no > > uncommitted files before starting. > > This is alrea

Re: [Xen-devel] [PATCH v2] scripts: introduce a script for build test

2017-10-25 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH v2] scripts: introduce a script for build test"): > On Tue, Oct 24, 2017 at 02:38:39PM +0100, Ian Jackson wrote: > > Anthony PERARD writes ("Re: [PATCH v2] scripts: introduce a script for > > build test"): > > > That feel

Re: [Xen-devel] [PATCH for-4.10 1/2] tools/libxc: Fix precopy_policy() to not pass a structure by value

2017-10-25 Thread Ian Jackson
stances such as the struct growing significantly) we can just change it. Of course it's better to get it right first time so if there is a good reason. > On 19/10/17 16:17, Ian Jackson wrote: > > Andrew Cooper writes ("Re: [PATCH for-4.10 1/2] tools/libxc: Fix > > precopy_poli

Re: [Xen-devel] [PATCH v5.1 7/8] os-posix: Provide new -runas : facility

2017-10-24 Thread Ian Jackson
Anthony PERARD writes ("Re: [PATCH v5.1 7/8] os-posix: Provide new -runas : facility"): > On Fri, Oct 20, 2017 at 02:38:21PM +0100, Ian Jackson wrote: > > +static bool os_parse_runas_uid_gid(const char *optarg) ... > > +errno = 0; > > +lv = strtoul(opta

Re: [Xen-devel] [PATCH v2] scripts: introduce a script for build test

2017-10-24 Thread Ian Jackson
Anthony PERARD writes ("Re: [PATCH v2] scripts: introduce a script for build test"): > That feels wrong. How do I run the same exact command at the default > one, but with -j8 instead of -j4? .../build-test sh -ec make -j4 distclean && ./configure && make -j4 But I think Anthony has a point.

Re: [Xen-devel] [PATCH v12 00/33] osstest: FreeBSD host support

2017-10-24 Thread Ian Jackson
Roger Pau Monné writes ("Re: [PATCH v12 00/33] osstest: FreeBSD host support"): > Sorry for the delay, had to cherry-pick some commits from the FreeBSD > host install series in order for the examine one to work. I've pushed > this to the following branch: > >

Re: [Xen-devel] [PATCH] mg-hosts: Fix usage of showprops

2017-10-24 Thread Ian Jackson
..@citrix.com> Signed-off-by: Ian Jackson <ian.jack...@eu.citrix.com> --- mg-hosts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mg-hosts b/mg-hosts index a000f2d..d91a965 100755 --- a/mg-hosts +++ b/mg-hosts @@ -54,8 +54,8 @@ # old tasks might s

Re: [Xen-devel] [PATCH v2] scripts: introduce a script for build test

2017-10-24 Thread Ian Jackson
Wei Liu writes ("[PATCH v2] scripts: introduce a script for build test"): ... > +if git branch | grep -q '^\*.\+detached at'; then You mean some rune involving git-symbolic-ref. git-symbolic-ref -q HEAD exits with status 1 if HEAD is detached, 0 if HEAD is a branch, or some other status in case

Re: [Xen-devel] [PATCH for-4.10] scripts: add a script for build testing

2017-10-23 Thread Ian Jackson
Wei Liu writes ("Re: [Xen-devel] [PATCH for-4.10] scripts: add a script for build testing"): > On Mon, Oct 23, 2017 at 03:50:31PM +0100, Anthony PERARD wrote: > > FIY, I do like to put script and other files in my checkouts, the git > > clean will remove them. > > I changed that to make

Re: [Xen-devel] [xen-unstable test] 115037: regressions - FAIL

2017-10-23 Thread Ian Jackson
Julien Grall writes ("Re: [Xen-devel] [xen-unstable test] 115037: regressions - FAIL"): > Would it be possible of a platform specific bug? The last two flights > are failing on merlot1. The merlots are a highly unusual AMD machines which have NUMA nodes with no memory and seem to sometimes have

Re: [Xen-devel] [PATCH for-4.10] libxl: annotate s to be nonnull in libxl__enum_from_string

2017-10-23 Thread Ian Jackson
Wei Liu writes ("Re: [Xen-devel] [PATCH for-4.10] libxl: annotate s to be nonnull in libxl__enum_from_string"): > On Mon, Oct 23, 2017 at 01:32:50PM +0100, Julien Grall wrote: > > I would be ok with that. Wei do you have any opinion? > > Sure this is a simple enough patch. We should preferably

Re: [Xen-devel] [PATCH for-4.10] scripts: add a script for build testing

2017-10-23 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH for-4.10] scripts: add a script for build testing"): > On Mon, Oct 23, 2017 at 02:24:40AM -0600, Jan Beulich wrote: > > On 20.10.17 at 19:32, wrote: > > > +git rebase $BASE $TIP -x "$CMD" > > > > Is this quoting on $CMD really going to work right

Re: [Xen-devel] [PATCH for-4.10] scripts: add a script for build testing

2017-10-23 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH for-4.10] scripts: add a script for build testing"): > On Mon, Oct 23, 2017 at 01:02:00PM +0100, Ian Jackson wrote: > > In particular, if you: > > * check that the tree is not dirty > > * detach HEAD > > I think these two che

Re: [Xen-devel] [PATCH for-4.10] scripts: add a script for build testing

2017-10-23 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH for-4.10] scripts: add a script for build testing"): > On Mon, Oct 23, 2017 at 02:24:40AM -0600, Jan Beulich wrote: > > What is this startup delay intended for? > > To give user a chance to check the command -- git-rebase can be > destructive after all. I can't resist

Re: [Xen-devel] [PATCH v2 4/5] tools: libxendevicemodel: Provide xendevicemodel_add_to_physmap

2017-10-23 Thread Ian Jackson
Ross Lagerwall writes ("[PATCH v2 4/5] tools: libxendevicemodel: Provide xendevicemodel_add_to_physmap"): > Signed-off-by: Ross Lagerwall <ross.lagerw...@citrix.com> Assuming the hypervisor parts go in: Acked-by: Ian Jackson <ian

[Xen-devel] [PATCH v5.1 8/8] configure: do_compiler: Dump some extra info under bash [and 1 more messages]

2017-10-23 Thread Ian Jackson
Ian Jackson writes ("[PATCH v5.1 8/8] configure: do_compiler: Dump some extra info under bash"): > This makes it much easier to find a particular thing in config.log. > > The information may be lacking in other shells, resulting in harmless > empty output. (This is why w

Re: [Xen-devel] linux-arm-xen branch, commit access, etc.

2017-10-20 Thread Ian Jackson
Stefano Stabellini writes ("Re: [Xen-devel] linux-arm-xen branch, commit access, etc."): > On Fri, 20 Oct 2017, Konrad Rzeszutek Wilk wrote: > > 3. Use upstream released kernels. Follow them when they are released. > > I agree with Konrad. The reason why that branch is there is that > initially

Re: [Xen-devel] [PATCH for-4.10] docs: update coverage.markdown

2017-10-20 Thread Ian Jackson
Wei Liu writes ("[PATCH for-4.10] docs: update coverage.markdown"): > The coverage support in hypervisor is redone. Update the document. Acked-by: Ian Jackson <ian.jack...@eu.citrix.com> ___ Xen-devel mailing list Xen-devel@

Re: [Xen-devel] [PATCH v12 00/33] osstest: FreeBSD host support

2017-10-20 Thread Ian Jackson
We have decided: We will push the anoint and examine parts of this series to osstest pretest. (You're going to give me a suitable branch on Monday.) This should work because we have anointed FreeBSD builds already. If this works (passes pretest) we will then run a special invocation of the

Re: [Xen-devel] [OSSTEST PATCH 11/16] ts-debian-fixup: use correct resume device

2017-10-20 Thread Ian Jackson
Wei Liu writes ("Re: [OSSTEST PATCH 11/16] ts-debian-fixup: use correct resume device"): > On Fri, Oct 20, 2017 at 02:42:53PM +0100, Ian Jackson wrote: > > Wei Liu writes ("Re: [OSSTEST PATCH 11/16] ts-debian-fixup: use correct > > resume device"): >

Re: [Xen-devel] [PATCH v12 31/33] ts-examine-hostprops-save: introduce a script to save properties

2017-10-20 Thread Ian Jackson
Roger Pau Monne writes ("[PATCH v12 31/33] ts-examine-hostprops-save: introduce a script to save properties"): > This script turns the properties stored in the runvars using the > format hostprop/$ident/$prop=$val into host properties stored in the > database. Acked-by: Ia

Re: [Xen-devel] [PATCH v12 33/33] sg-run-job: hook the memdisk test into examine

2017-10-20 Thread Ian Jackson
Changes since v2: > - Do not pass a host ident to ts-examine-hostprops-save. > - Use .- for ts-memdisk-try-append so that the rest of the job will > run even if this step fails. Acked-by: Ian Jackson <ian.jack...@eu.citrix.com> ___ Xen

Re: [Xen-devel] [PATCH v12 29/33] ts-freebsd-host-install: add arguments to test memdisk append options

2017-10-20 Thread Ian Jackson
Roger Pau Monne writes ("[PATCH v12 29/33] ts-freebsd-host-install: add arguments to test memdisk append options"): > This is needed in order to figure out which memdisk options should be > used to boot the images on each specific box. > > Note that when passed the --recordappend argument upon

Re: [Xen-devel] [PATCH v12 26/33] HostDB: introduce set_property

2017-10-20 Thread Ian Jackson
ed blessing" in the commit message and error message, since there is also a current blessing etc. With that changed, Acked-by: Ian Jackson <ian.jack...@eu.citrix.com> Ian. ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

[Xen-devel] linux-arm-xen branch, commit access, etc.

2017-10-20 Thread Ian Jackson
Currently we are running our ARM tests in osstest off a branch in Stefano's personal Linux tree. This is a bit unsatisfactory. We would like to switch to a branch that Julien can push to too, and that is in a more official place. There are two options: 1. Create an ARM-specific Xen tree.

Re: [Xen-devel] [OSSTEST PATCH 11/16] ts-debian-fixup: use correct resume device

2017-10-20 Thread Ian Jackson
Wei Liu writes ("Re: [OSSTEST PATCH 11/16] ts-debian-fixup: use correct resume device"): > On Fri, Oct 20, 2017 at 02:20:29PM +0100, Ian Jackson wrote: > > I don't think the guest booting "eventually" after some timeout is > > correct. > > The OS is h

[Xen-devel] [PATCH v5.1 1/8] xen: link against xentoolcore

2017-10-20 Thread Ian Jackson
From: Anthony PERARD <anthony.per...@citrix.com> Xen libraries in 4.10 include a new xentoolcore library. This contains the xentoolcore_restrict_all function which we are about to want to use. Signed-off-by: Ian Jackson <ian.jack...@eu.citrix.com> --- v5: More truthful co

[Xen-devel] [PATCH v5.1 3/8] xen: defer call to xen_restrict until just before os_setup_post

2017-10-20 Thread Ian Jackson
that this is not a regression in this patch, because previously the -xen-restrict-domid call was, in fact, simply ineffective!) We will revisit this in the Xen 4.11 release cycle. Signed-off-by: Ian Jackson <ian.jack...@eu.citrix.com> Reviewed-by: Anthony PERARD <anthony.per...@citrix.com> ---

[Xen-devel] [PATCH v5.1 5/8] xen: move xc_interface compatibility fallback further up the file

2017-10-20 Thread Ian Jackson
ers would be at the bottom of the file, so that they can naturally benefit from the compatibility layers for earlier version. But that's rather too much for this series.) No functional change. Signed-off-by: Ian Jackson <ian.jack...@eu.citrix.com> Acked-by: Anthony PERARD <anthony.per..

[Xen-devel] [PATCH v5.1 4/8] xen: destroy_hvm_domain: Move reason into a variable

2017-10-20 Thread Ian Jackson
We are going to want to reuse this. No functional change. Signed-off-by: Ian Jackson <ian.jack...@eu.citrix.com> Reviewed-by: Anthony PERARD <anthony.per...@citrix.com> --- hw/i386/xen/xen-hvm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/i386/xen/xe

[Xen-devel] [PATCH v5.1 8/8] configure: do_compiler: Dump some extra info under bash

2017-10-20 Thread Ian Jackson
if configure is run with bash. The something), it is necessary to say bash ./configure to get the extra debug info in the log. Signed-off-by: Ian Jackson <ian.jack...@eu.citrix.com> --- v4: No longer tag this patch RFC. --- configure | 4 1 file changed, 4 insertions(+) diff --git a/confi

[Xen-devel] [PATCH v5.1 2/8] xen: restrict: use xentoolcore_restrict_all

2017-10-20 Thread Ian Jackson
, because the restriction needs to be done very late - after qemu has opened all of its control fds. xentoolcore_restrict_all and xentoolcore.h are available in Xen 4.10 and later, only. Provide a compatibility stub. And drop the compatibility stubs for the old functions. Signed-off-by: Ian Jackson

[Xen-devel] [PATCH v5.1 6/8] xen: destroy_hvm_domain: Try xendevicemodel_shutdown

2017-10-20 Thread Ian Jackson
xc_interface_open etc. is not going to work if we have dropped privilege, but xendevicemodel_shutdown will if everything is new enough. xendevicemodel_shutdown is only availabe in Xen 4.10 and later, so provide a stub for earlier versions. Signed-off-by: Ian Jackson <ian.jack...@eu.citrix.

[Xen-devel] [PATCH v5.1 7/8] os-posix: Provide new -runas : facility

2017-10-20 Thread Ian Jackson
what gid we ought to use (since uids may eppear in multiple passwd file entries with different gids). Signed-off-by: Ian Jackson <ian.jack...@eu.citrix.com> --- v5: Use : rather than . to separate uid from gid v4: Changed to reuse option -runas v3: Error messages fixed. Thanks to Peter M

Re: [Xen-devel] [PATCH v5 0/8] xen: xen-domid-restrict improvements

2017-10-20 Thread Ian Jackson
Anthony PERARD writes ("Re: [PATCH v5 0/8] xen: xen-domid-restrict improvements"): > The patches in this v5 appear to be the same the one from the patch > series v4. Erk, so they are. I'll post a v5.1 in reply to this email. Ian. ___ Xen-devel

Re: [Xen-devel] [OSSTEST PATCH 11/16] ts-debian-fixup: use correct resume device

2017-10-20 Thread Ian Jackson
Wei Liu writes ("Re: [OSSTEST PATCH 11/16] ts-debian-fixup: use correct resume device"): > I wouldn't call this behaviour a bug. Most people won't notice it > because the guest will boot eventually. It is not like this will cause > the guest to crash. I don't think the guest booting

Re: [Xen-devel] [OSSTEST PATCH 10/16] ts-debian-fixup: remove extra= before appending our own

2017-10-20 Thread Ian Jackson
Wei Liu writes ("Re: [OSSTEST PATCH 10/16] ts-debian-fixup: remove extra= before appending our own"): > On Fri, Oct 20, 2017 at 12:03:24PM +0100, Ian Jackson wrote: > > Wei Liu writes ("[OSSTEST PATCH 10/16] ts-debian-fixup: remove extra= > > before appending our o

Re: [Xen-devel] [OSSTEST PATCH 11/16] ts-debian-fixup: use correct resume device

2017-10-20 Thread Ian Jackson
Wei Liu writes ("Re: [OSSTEST PATCH 11/16] ts-debian-fixup: use correct resume device"): > On Fri, Oct 20, 2017 at 12:05:55PM +0100, Ian Jackson wrote: > > Wei Liu writes ("[OSSTEST PATCH 11/16] ts-debian-fixup: use correct resume > > device"): >

Re: [Xen-devel] [OSSTEST PATCH 16/16] ts-guests-nbd-mirror: make it work with stretch

2017-10-20 Thread Ian Jackson
Wei Liu writes ("[OSSTEST PATCH 16/16] ts-guests-nbd-mirror: make it work with stretch"): > On the server side, only add oldstyle= and port= on jessie. Stretch > doesn't support or need those anymore. See my earlier comments about old vs new Debian suite names. > Prune check for older versions

Re: [Xen-devel] [OSSTEST PATCH 11/16] ts-debian-fixup: use correct resume device

2017-10-20 Thread Ian Jackson
Wei Liu writes ("[OSSTEST PATCH 11/16] ts-debian-fixup: use correct resume device"): > See code comment for explanation. ... > +# There might be stale entries in /etc/initramfs-tools/conf.d/resume > +# which get stored in the initramfs. That introduces delay in guest > booting > +#

Re: [Xen-devel] [OSSTEST PATCH 10/16] ts-debian-fixup: remove extra= before appending our own

2017-10-20 Thread Ian Jackson
Wei Liu writes ("[OSSTEST PATCH 10/16] ts-debian-fixup: remove extra= before appending our own"): > The original extra= was not removed, so there were two extra= in the > resulting config file. What is the original extra= ? Why should we not combine them ? > It wasn't a problem for xl because

Re: [Xen-devel] [OSSTEST PATCH 13/16] ts-debian-hvm-install: disable new nic naming scheme

2017-10-20 Thread Ian Jackson
Wei Liu writes ("[OSSTEST PATCH 13/16] ts-debian-hvm-install: disable new nic naming scheme"): > This is required to fix nested hvm test. The L1 host is installed by > this script. We want the L1 host to not use the new nic naming scheme. The principle is fine. > +# Do not use "Predictable

Re: [Xen-devel] [OSSTEST PATCH 09/16] ts-host-install: don't use the new nic naming scheme

2017-10-20 Thread Ian Jackson
Wei Liu writes ("[OSSTEST PATCH 09/16] ts-host-install: don't use the new nic naming scheme"): > Signed-off-by: Wei Liu <wei.l...@citrix.com> Acked-by: Ian Jackson <ian.jack...@eu.citrix.com> ___ Xen-devel mailing list Xen-

Re: [Xen-devel] [OSSTEST PATCH 07/16] Debian.pm: use sysvinit-core on stretch

2017-10-20 Thread Ian Jackson
Wei Liu writes ("[OSSTEST PATCH 07/16] Debian.pm: use sysvinit-core on stretch"): ... > diff --git a/Osstest/Debian.pm b/Osstest/Debian.pm > index 845027a..24bc260 100644 > --- a/Osstest/Debian.pm > +++ b/Osstest/Debian.pm > @@ -827,7 +827,7 @@ sub preseed_base ($$$;@) { > > # Systemd

Re: [Xen-devel] [OSSTEST PATCH 08/16] ts-leak-check: suppress systemd-shim, which leaks in stretch

2017-10-20 Thread Ian Jackson
Wei Liu writes ("[OSSTEST PATCH 08/16] ts-leak-check: suppress systemd-shim, which leaks in stretch"): > Signed-off-by: Wei Liu <wei.l...@citrix.com> Acked-by: Ian Jackson <ian.jack...@eu.citrix.com> ___ Xen-devel mailing lis

Re: [Xen-devel] [OSSTEST PATCH 05/16] mg-debian-installer-update-all: put quotes around arguments

2017-10-20 Thread Ian Jackson
Wei Liu writes ("[OSSTEST PATCH 05/16] mg-debian-installer-update-all: put quotes around arguments"): > Signed-off-by: Wei Liu ... > suite=$1 > arch=$2 > -packages="$3" > +packages=$3 Not sure why this needless style change, but if you did it deliberately I don't really

Re: [Xen-devel] [OSSTEST PATCH 01/16] XXX add a stretch config based on production-config

2017-10-20 Thread Ian Jackson
Wei Liu writes ("[OSSTEST PATCH 01/16] XXX add a stretch config based on production-config"): > diff -ub production-config production-config-stretch The changes LGTM but obviously this ought to go straight into `production-config'. Ian. ___ Xen-devel

[Xen-devel] [OSSTEST PATCH 02/16] gitignore: ignore vim swap file

2017-10-20 Thread Ian Jackson
Wei Liu writes ("[OSSTEST PATCH 02/16] gitignore: ignore vim swap file"): > Signed-off-by: Wei Liu <wei.l...@citrix.com> Acked-by: Ian Jackson <ian.jack...@eu.citrix.com> Although, you may find your life improved by putting this in your ~

Re: [Xen-devel] [OSSTEST PATCH 04/16] ts-xen-build-prep: install packages for stretch

2017-10-20 Thread Ian Jackson
Wei Liu writes ("[OSSTEST PATCH 04/16] ts-xen-build-prep: install packages for stretch"): > Stubdom build needs texinfo. Same comment as my previous patch. You should only mention old release names in these kind of tests, unless you know that the requirement is specific to only stretch and not

  1   2   3   4   5   6   7   8   9   10   >