[Xen-devel] Xen 4.7.4 released

2017-11-22 Thread Jan Beulich
All, I am pleased to announce the release of Xen 4.7.4. This is available immediately from its git repository http://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=refs/heads/stable-4.7 (tag RELEASE-4.7.4) or from the XenProject download page

[Xen-devel] Xen 4.9.1 released

2017-11-22 Thread Jan Beulich
All, I am pleased to announce the release of Xen 4.9.1. This is available immediately from its git repository http://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=refs/heads/stable-4.9 (tag RELEASE-4.9.1) or from the XenProject download page

Re: [Xen-devel] Linux as 32-bit Dom0?

2017-11-22 Thread Jan Beulich
>>> On 22.11.17 at 15:40, <jgr...@suse.com> wrote: > On 22/11/17 15:05, Jan Beulich wrote: >> Jürgen, Boris, >> >> am I trying something that's not allowed, but selectable via Kconfig? >> On system with multiple IO-APICs (I assume that's what triggers

[Xen-devel] Linux as 32-bit Dom0?

2017-11-22 Thread Jan Beulich
Jürgen, Boris, am I trying something that's not allowed, but selectable via Kconfig? On system with multiple IO-APICs (I assume that's what triggers the problem) I get Kernel panic - not syncing: Max apic_id exceeded! CPU: 0 PID: 0 Comm: swapper Not tainted 4.14.1-2017-11-21-xen0 #6 Hardware

Re: [Xen-devel] [PATCH v2] sync CPU state upon final domain destruction

2017-11-22 Thread Jan Beulich
rther down the call stack, e.g. in vmx_vcpu_destroy()) and the > intention to limit the performance impact (otherwise it could also go > into rcu_do_batch(), paralleling the use in do_tasklet_work()). > > Reported-by: Igor Druzhinin <igor.druzhi...@citrix.com> > Signed-off-by: Jan Beulich &

[Xen-devel] [PATCH v2] sync CPU state upon final domain destruction

2017-11-22 Thread Jan Beulich
(otherwise it could also go into rcu_do_batch(), paralleling the use in do_tasklet_work()). Reported-by: Igor Druzhinin <igor.druzhi...@citrix.com> Signed-off-by: Jan Beulich <jbeul...@suse.com> --- v2: Move from vmx_vcpu_destroy() to complete_domain_destroy(). --- a/xen/common/domain

Re: [Xen-devel] [PATCH 10/16] SUPPORT.md: Add Debugging, analysis, crash post-portem

2017-11-22 Thread Jan Beulich
>>> On 21.11.17 at 19:19, wrote: > xentrace I would argue for security support; I've asked customers to > send me xentrace data as part of analysis before. I also know enough > about it that I'm reasonably confident the risk of an attack vector is > pretty low. Knowing

Re: [Xen-devel] [PATCH 08/16] SUPPORT.md: Add x86-specific virtual hardware

2017-11-22 Thread Jan Beulich
>>> On 21.11.17 at 19:02, <george.dun...@citrix.com> wrote: > On 11/21/2017 08:39 AM, Jan Beulich wrote: >>>>> On 13.11.17 at 16:41, <george.dun...@citrix.com> wrote: >>> +### x86/Nested PV >>> + >>> +Status, x86 HVM: Tech Pr

Re: [Xen-devel] [PATCH 07/16] SUPPORT.md: Add virtual devices common to ARM and x86

2017-11-22 Thread Jan Beulich
>>> On 21.11.17 at 18:35, <george.dun...@citrix.com> wrote: > On 11/21/2017 08:29 AM, Jan Beulich wrote: >>> +### QEMU backend hotplugging for xl >>> + >>> +Status: Supported >> >> Wouldn't this more appropriately be >> &

Re: [Xen-devel] [PATCH 07/16] SUPPORT.md: Add virtual devices common to ARM and x86

2017-11-22 Thread Jan Beulich
>>> On 21.11.17 at 18:20, <george.dun...@citrix.com> wrote: > On 11/21/2017 11:41 AM, Jan Beulich wrote: >>>>> On 21.11.17 at 11:56, <george.dun...@citrix.com> wrote: >>> On 11/21/2017 08:29 AM, Jan Beulich wrote: >>>>>>> On 1

Re: [Xen-devel] [PATCH v2 3/5] xen: Provide XEN_DMOP_pin_memory_cacheattr

2017-11-22 Thread Jan Beulich
>>> On 23.10.17 at 11:05, <ross.lagerw...@citrix.com> wrote: > --- a/xen/arch/x86/hvm/dm.c > +++ b/xen/arch/x86/hvm/dm.c > @@ -21,6 +21,7 @@ > > #include > #include > +#include > #include With this addition moved up a line to result in a prope

Re: [Xen-devel] Ping: [PATCH] VMX: sync CPU state upon vCPU destruction

2017-11-21 Thread Jan Beulich
>>> On 21.11.17 at 18:00, <sergey.dya...@citrix.com> wrote: > On Tue, 2017-11-21 at 08:29 -0700, Jan Beulich wrote: >> > > > On 21.11.17 at 15:07, <igor.druzhi...@citrix.com> wrote: >> > >> > On 21/11/17 13:22, Jan Beulich wrote: >

Re: [Xen-devel] [PATCH v2 2/5] xen: Provide XEN_DMOP_add_to_physmap

2017-11-21 Thread Jan Beulich
>>> On 23.10.17 at 11:05, wrote: First of all, instead of xen: please consider using something more specific, like x86/hvm:. > --- a/xen/include/public/hvm/dm_op.h > +++ b/xen/include/public/hvm/dm_op.h > @@ -368,6 +368,22 @@ struct xen_dm_op_remote_shutdown { >

Re: [Xen-devel] [PATCH v2 1/5] xen/mm: Make xenmem_add_to_physmap global

2017-11-21 Thread Jan Beulich
; Misplaced tag. I'd prefer if the function was made non-static in the patch which needs it so, but anyway Acked-by: Jan Beulich <jbeul...@suse.com> Jan ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] Ping: [PATCH] VMX: sync CPU state upon vCPU destruction

2017-11-21 Thread Jan Beulich
>>> On 21.11.17 at 15:07, <igor.druzhi...@citrix.com> wrote: > On 21/11/17 13:22, Jan Beulich wrote: >>>>> On 09.11.17 at 15:49, <jbeul...@suse.com> wrote: >>> See the code comment being added for why we need this. >>> >>> Repo

[Xen-devel] Ping#2: [PATCH] x86emul: keep compiler from using {x, y, z}mm registers itself

2017-11-21 Thread Jan Beulich
>>> On 06.11.17 at 16:04, <george.dun...@citrix.com> wrote: > On 11/06/2017 11:59 AM, Jan Beulich wrote: >>>>> On 16.10.17 at 14:42, wrote: >>>>>> On 16.10.17 at 14:37, <andrew.coop...@citrix.com> wrote: >>>> On 16/10/17 13:32,

[Xen-devel] Ping: [PATCH] VMX: sync CPU state upon vCPU destruction

2017-11-21 Thread Jan Beulich
>>> On 09.11.17 at 15:49, <jbeul...@suse.com> wrote: > See the code comment being added for why we need this. > > Reported-by: Igor Druzhinin <igor.druzhi...@citrix.com> > Signed-off-by: Jan Beulich <jbeul...@suse.com> I realize we aren't settled yet on whe

Re: [Xen-devel] [PATCH 04/16] SUPPORT.md: Add core ARM features

2017-11-21 Thread Jan Beulich
>>> On 21.11.17 at 13:39, wrote: > What about something like this? > > ### IOMMU > > Status, AMD IOMMU: Supported > Status, Intel VT-d: Supported > Status, ARM SMMUv1: Supported > Status, ARM SMMUv2: Supported Fine with me, as it makes things explicit.

Re: [Xen-devel] [PATCH 03/16] SUPPORT.md: Add some x86 features

2017-11-21 Thread Jan Beulich
>>> On 21.11.17 at 13:24, <george.dun...@citrix.com> wrote: >> On Nov 21, 2017, at 11:35 AM, Jan Beulich >> Much depends on whether you think "guest" == "DomU". To me >> Dom0 is a guest, too. > > That’s not how I’ve ever understood th

Re: [Xen-devel] [PATCH v2] tools/libxl: mark special pages as reserved in e820 map for PVH

2017-11-21 Thread Jan Beulich
>>> On 21.11.17 at 12:48, <jgr...@suse.com> wrote: > On 21/11/17 12:27, Jan Beulich wrote: >>>>> On 21.11.17 at 12:06, <jgr...@suse.com> wrote: >>> The "special pages" for PVH guests include the frames for console and >&

Re: [Xen-devel] [PATCH 07/16] SUPPORT.md: Add virtual devices common to ARM and x86

2017-11-21 Thread Jan Beulich
>>> On 21.11.17 at 11:56, <george.dun...@citrix.com> wrote: > On 11/21/2017 08:29 AM, Jan Beulich wrote: >>>>> On 13.11.17 at 16:41, <george.dun...@citrix.com> wrote: >>> +### PV USB support for xl >>> + >>> +Status: Supported

Re: [Xen-devel] [PATCH 04/16] SUPPORT.md: Add core ARM features

2017-11-21 Thread Jan Beulich
>>> On 21.11.17 at 11:45, <george.dun...@citrix.com> wrote: > On 11/21/2017 08:11 AM, Jan Beulich wrote: >>>>> On 13.11.17 at 16:41, <george.dun...@citrix.com> wrote: >>> +### ARM/SMMUv1 >>> + >>> +Status: Supported &g

Re: [Xen-devel] [PATCH 03/16] SUPPORT.md: Add some x86 features

2017-11-21 Thread Jan Beulich
>>> On 21.11.17 at 11:42, <george.dun...@citrix.com> wrote: > On 11/21/2017 08:09 AM, Jan Beulich wrote: >>>>> On 13.11.17 at 16:41, <george.dun...@citrix.com> wrote: >>> +### x86/PVH guest >>> + >>> +Status: Supported >&

Re: [Xen-devel] [PATCH 02/16] SUPPORT.md: Add core functionality

2017-11-21 Thread Jan Beulich
>>> On 21.11.17 at 11:36, <george.dun...@citrix.com> wrote: > On 11/21/2017 08:03 AM, Jan Beulich wrote: >>>>> On 13.11.17 at 16:41, <george.dun...@citrix.com> wrote: >>> --- a/SUPPORT.md >>> +++ b/SUPPORT.md >>> @@ -1

Re: [Xen-devel] [PATCH v2] tools/libxl: mark special pages as reserved in e820 map for PVH

2017-11-21 Thread Jan Beulich
>>> On 21.11.17 at 12:06, wrote: > The "special pages" for PVH guests include the frames for console and > Xenstore ring buffers. Those have to be marked as "Reserved" in the > guest's E820 map, as otherwise conflicts might arise later e.g. when > hotplugging memory into the

Re: [Xen-devel] [PATCH 16/16] SUPPORT.md: Add limits RFC

2017-11-21 Thread Jan Beulich
>>> On 13.11.17 at 16:41, wrote: > +### Virtual CPUs > + > +Limit, x86 PV: 8192 > +Limit-security, x86 PV: 32 > +Limit, x86 HVM: 128 > +Limit-security, x86 HVM: 32 Personally I consider the "Limit-security" numbers too low here, but I have no proof that

Re: [Xen-devel] [PATCH 14/16] SUPPORT.md: Add statement on PCI passthrough

2017-11-21 Thread Jan Beulich
these adjustments (or substantially similar ones) Acked-by: Jan Beulich <jbeul...@suse.com> Jan ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 13/16] SUPPORT.md: Add secondary memory management features

2017-11-21 Thread Jan Beulich
>>> On 13.11.17 at 16:41, <george.dun...@citrix.com> wrote: > Signed-off-by: George Dunlap <george.dun...@citrix.com> Wouldn't PoD belong here too? With that added as supported on x86 HVM Acked-by: Jan Beulich <jbeul...@suse.com> Jan ___

Re: [Xen-devel] [PATCH 12/16] SUPPORT.md: Add Security-releated features

2017-11-21 Thread Jan Beulich
>>> On 13.11.17 at 16:41, wrote: > With the exception of driver domains, which depend on PCI passthrough, > and will be introduced later. > > Signed-off-by: George Dunlap Shouldn't we also explicitly exclude tool stack disaggregation here,

Re: [Xen-devel] [PATCH 11/16] SUPPORT.md: Add 'easy' HA / FT features

2017-11-21 Thread Jan Beulich
>>> On 13.11.17 at 16:41, <george.dun...@citrix.com> wrote: > +### x86/vMCE > + > +Status: Supported > + > +Forward Machine Check Exceptions to Appropriate guests Acked-by: Jan Beulich <jbeul...@suse.com> perhaps with

Re: [Xen-devel] [PATCH 10/16] SUPPORT.md: Add Debugging, analysis, crash post-portem

2017-11-21 Thread Jan Beulich
>>> On 13.11.17 at 16:41, wrote: > --- a/SUPPORT.md > +++ b/SUPPORT.md > @@ -152,6 +152,35 @@ Output of information in machine-parseable JSON format > > Status: Supported, Security support external > > +## Debugging, analysis, and crash post-mortem > + > +###

Re: [Xen-devel] [PATCH for-4.10] libxc: load acpi RSDP table at correct address

2017-11-21 Thread Jan Beulich
>>> On 21.11.17 at 09:13, <jgr...@suse.com> wrote: > On 21/11/17 08:50, Jan Beulich wrote: >>>>> On 20.11.17 at 19:28, <jgr...@suse.com> wrote: >>> On 20/11/17 17:14, Jan Beulich wrote: >>>>>>> On 20.11.17 at 16:24, <jgr...

Re: [Xen-devel] [PATCH 08/16] SUPPORT.md: Add x86-specific virtual hardware

2017-11-21 Thread Jan Beulich
>>> On 13.11.17 at 16:41, wrote: > +### x86/Nested PV > + > +Status, x86 HVM: Tech Preview > + > +This means running a Xen hypervisor inside an HVM domain, > +with support for PV L2 guests only > +(i.e., hardware virtualization extensions not provided > +to the

Re: [Xen-devel] [PATCH 07/16] SUPPORT.md: Add virtual devices common to ARM and x86

2017-11-21 Thread Jan Beulich
>>> On 13.11.17 at 16:41, wrote: > +### PV USB support for xl > + > +Status: Supported > + > +### PV 9pfs support for xl > + > +Status: Tech Preview Why are these two being called out, but xl support for other device types isn't? > +### QEMU backend hotplugging

Re: [Xen-devel] [PATCH 06/16] SUPPORT.md: Add scalability features

2017-11-21 Thread Jan Beulich
>>> On 13.11.17 at 16:41, wrote: > --- a/SUPPORT.md > +++ b/SUPPORT.md > @@ -195,6 +195,27 @@ on embedded platforms. > > Enables NUMA aware scheduling in Xen > > +## Scalability > + > +### 1GB/2MB super page support > + > +Status, x86 HVM/PVH: : Supported On

Re: [Xen-devel] [PATCH 04/16] SUPPORT.md: Add core ARM features

2017-11-21 Thread Jan Beulich
>>> On 13.11.17 at 16:41, wrote: > +### ARM/SMMUv1 > + > +Status: Supported > + > +### ARM/SMMUv2 > + > +Status: Supported Do these belong here, when IOMMU isn't part of the corresponding x86 patch? Jan ___

Re: [Xen-devel] [PATCH 03/16] SUPPORT.md: Add some x86 features

2017-11-21 Thread Jan Beulich
>>> On 13.11.17 at 16:41, wrote: > +### Host ACPI (via Domain 0) > + > +Status, x86 PV: Supported > +Status, x86 PVH: Tech preview Are we this far already? Preview implies functional completeness, but I'm not sure about all ACPI related parts actually having

Re: [Xen-devel] [PATCH 02/16] SUPPORT.md: Add core functionality

2017-11-21 Thread Jan Beulich
ry Ballooning > + > +Status: Supported Is this a proper feature in the context we're talking about? To me it's meaningful in guest OS context only. I also wouldn't really consider it "core", but placement within the series clearly is a minor aspect. I'd prefer this to be dropped altogether

Re: [Xen-devel] [PATCH for-4.10] libxc: load acpi RSDP table at correct address

2017-11-20 Thread Jan Beulich
>>> On 20.11.17 at 19:28, <jgr...@suse.com> wrote: > On 20/11/17 17:14, Jan Beulich wrote: >>>>> On 20.11.17 at 16:24, <jgr...@suse.com> wrote: >>> On 20/11/17 15:20, Jan Beulich wrote: >>>>>>> On 20.11.17 at 15:14, &l

Re: [Xen-devel] [PATCH for-4.10] libxc: load acpi RSDP table at correct address

2017-11-20 Thread Jan Beulich
>>> On 20.11.17 at 17:59, <boris.ostrov...@oracle.com> wrote: > On 11/20/2017 11:43 AM, Jan Beulich wrote: >>>>> On 20.11.17 at 17:28, <boris.ostrov...@oracle.com> wrote: >>> On 11/20/2017 11:26 AM, Jan Beulich wrote: >>>>>>>

Re: [Xen-devel] [PATCH 01/16] Introduce skeleton SUPPORT.md

2017-11-20 Thread Jan Beulich
d be formatted using "semantic newlines" [1], to make > changes easier. > > Begin with the basic framework. > > Signed-off-by: Ian Jackson <ian.jack...@citrix.com> > Signed-off-by: George Dunlap <george.dun...@citrix.com> Acked-by: Jan Beulich <jbeul...@s

Re: [Xen-devel] [PATCH for-4.10] libxc: load acpi RSDP table at correct address

2017-11-20 Thread Jan Beulich
>>> On 20.11.17 at 17:28, <boris.ostrov...@oracle.com> wrote: > On 11/20/2017 11:26 AM, Jan Beulich wrote: >>>>> On 20.11.17 at 17:14, <boris.ostrov...@oracle.com> wrote: >>> What could cause grub2 to fail to find space for the pointer in the &g

Re: [Xen-devel] [PATCH for-4.10] libxc: load acpi RSDP table at correct address

2017-11-20 Thread Jan Beulich
>>> On 20.11.17 at 17:14, wrote: > What could cause grub2 to fail to find space for the pointer in the > first page? Will we ever have anything in EBDA (which is one of the > possible RSDP locations)? Well, the EBDA (see the B in its name) is again something that's

Re: [Xen-devel] [PATCH for-4.10] libxc: load acpi RSDP table at correct address

2017-11-20 Thread Jan Beulich
>>> On 20.11.17 at 16:24, <jgr...@suse.com> wrote: > On 20/11/17 15:20, Jan Beulich wrote: >>>>> On 20.11.17 at 15:14, <jgr...@suse.com> wrote: >>> On 20/11/17 14:56, Boris Ostrovsky wrote: >>>> On 11/20/2017 06:50 AM, Jan Beulich w

Re: [Xen-devel] [PATCH for-4.10] x86/hvm: Don't ignore unknown MSRs in the migration stream

2017-11-20 Thread Jan Beulich
>>> On 20.11.17 at 15:10, <andrew.coop...@citrix.com> wrote: > On 17/11/17 12:10, Jan Beulich wrote: >>>>> On 16.11.17 at 20:15, <andrew.coop...@citrix.com> wrote: >>> Doing so amounts to silent state corruption, and must be avoided. >&

Re: [Xen-devel] [PATCH for-4.10] libxc: load acpi RSDP table at correct address

2017-11-20 Thread Jan Beulich
>>> On 20.11.17 at 15:14, <jgr...@suse.com> wrote: > On 20/11/17 14:56, Boris Ostrovsky wrote: >> On 11/20/2017 06:50 AM, Jan Beulich wrote: >>>>>> On 20.11.17 at 12:20, <jgr...@suse.com> wrote: >>>> Which restriction? I'm loading the RSD

Re: [Xen-devel] [PATCH for-4.10] libxc: load acpi RSDP table at correct address

2017-11-20 Thread Jan Beulich
>>> On 20.11.17 at 14:56, <boris.ostrov...@oracle.com> wrote: > On 11/20/2017 06:50 AM, Jan Beulich wrote: >>>>> On 20.11.17 at 12:20, <jgr...@suse.com> wrote: >>> Which restriction? I'm loading the RSDP table to its architectural >>>

Re: [Xen-devel] [PATCH for-next] x86/vmx: Drop more PVHv1 remenants

2017-11-20 Thread Jan Beulich
>>> On 20.11.17 at 14:19, <andrew.coop...@citrix.com> wrote: > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> Reviewed-by: Jan Beulich <jbeul...@suse.com> ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH for-4.10] libxc: load acpi RSDP table at correct address

2017-11-20 Thread Jan Beulich
>>> On 20.11.17 at 12:20, wrote: > Which restriction? I'm loading the RSDP table to its architectural > correct addres if possible, otherwise it will be loaded to the same > address as without my patch. So I'm not adding a restriction, but > removing one. What is

Re: [Xen-devel] [PATCH v8] x86/altp2m: support for setting restrictions for an array of pages

2017-11-20 Thread Jan Beulich
>>> On 20.11.17 at 10:35, wrote: > On Ma, 2017-10-24 at 13:19 +0300, Petre Pircalabu wrote: >> From: Razvan Cojocaru >> >> For the default EPT view we have xc_set_mem_access_multi(), which >> is able to set an array of pages to an array of

Re: [Xen-devel] [PATCH for-4.10] tools/libxl: mark hvm mmio area as reserved in e820 map

2017-11-17 Thread Jan Beulich
>>> On 17.11.17 at 12:47, wrote: > Make sure the HVM mmio area (especially console and Xenstore pages) is > marked as "reserved" in the guest's E820 map, as otherwise conflicts > might arise later, e.g. when hotplugging memory into the guest. This is very certainly wrong. Have

Re: [Xen-devel] [PATCH for-4.10] x86/hvm: Don't corrupt the HVM context stream when writing the MSR record

2017-11-17 Thread Jan Beulich
gt; (XEN) HVM4 restore: failed to load entry 20/0 > > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> Reviewed-by: Jan Beulich <jbeul...@suse.com> > --- a/xen/arch/x86/hvm/hvm.c > +++ b/xen/arch/x86/hvm/hvm.c > @@ -1330,6 +1330,7 @@ static int

Re: [Xen-devel] [PATCH for-4.10] tools/libxc: Fix restoration of PV MSRs after migrate

2017-11-17 Thread Jan Beulich
ny contemporary PV guests. > > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> Reviewed-by: Jan Beulich <jbeul...@suse.com> ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH for-4.10] x86/hvm: Don't ignore unknown MSRs in the migration stream

2017-11-17 Thread Jan Beulich
>>> On 16.11.17 at 20:15, wrote: > Doing so amounts to silent state corruption, and must be avoided. I think a little more explanation is needed on why the current code is insufficient. Note specifically this for ( i = 0; !err && i < ctxt->count; ++i ) {

Re: [Xen-devel] XSA 243 v5 is missing the second patch for xen 4.8

2017-11-17 Thread Jan Beulich
>>> On 16.11.17 at 21:01, wrote: > Hello, > Looking at > https://xenbits.xen.org/xsa/advisory-243.html, > I cannot find the second patch for xen 4.8, xsa243-4.8-2.patch. > The text of the advisory leads me to believe that it should be there, so > it seems to be missing. The text

Re: [Xen-devel] [BUG] Error applying XSA240 update 5 on 4.8 and 4.9 (patch 3 references CONFIG_PV_LINEAR_PT, 3285e75dea89, x86/mm: Make PV linear pagetables optional)

2017-11-16 Thread Jan Beulich
>>> On 16.11.17 at 13:30, <net...@crc.id.au> wrote: > On Thursday, 16 November 2017 8:30:39 PM AEDT Jan Beulich wrote: >> >>> On 15.11.17 at 23:48, <li...@johnthomson.fastmail.com.au> wrote: >> > I am having trouble applying the patch 3 from

Re: [Xen-devel] [BUG] Error applying XSA240 update 5 on 4.8 and 4.9 (patch 3 references CONFIG_PV_LINEAR_PT, 3285e75dea89, x86/mm: Make PV linear pagetables optional)

2017-11-16 Thread Jan Beulich
>>> On 15.11.17 at 23:48, wrote: > Hi, > > I am having trouble applying the patch 3 from XSA240 update 5 for xen > stable 4.8 and 4.9 > xsa240 0003 contains: > > CONFIG_PV_LINEAR_PT > > from: > > x86/mm: Make PV linear pagetables optional >

Re: [Xen-devel] [PATCH v2] x86/hvm: Fix altp2m_vcpu_enable_notify error handling

2017-11-15 Thread Jan Beulich
t;a...@bitdefender.com> > Reviewed-by: Andrew Cooper <andrew.coop...@citrix.com> Reviewed-by: Jan Beulich <jbeul...@suse.com> Jan ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH] x86/hvm: Fix rcu_unlock_domain call bypass

2017-11-14 Thread Jan Beulich
>>> On 14.11.17 at 16:11, wrote: > rcu_lock_current_domain is called at the beginning of do_altp2m_op, but > the altp2m_vcpu_enable_notify subop handler might skip calling > rcu_unlock_domain, possibly hanging the domain altogether. I fully agree with the change, but the

Re: [Xen-devel] [PATCH v3 for-4.10 2/2] x86/mm: fix a potential race condition in modify_xen_mappings().

2017-11-14 Thread Jan Beulich
GE_PRESENT and _PAGE_PSE flags need be > checked after the lock is obtained. > > Signed-off-by: Yu Zhang <yu.c.zh...@linux.intel.com> Reviewed-by: Jan Beulich <jbeul...@suse.com> ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v3 for-4.10 1/2] x86/mm: fix potential race conditions in map_pages_to_xen().

2017-11-14 Thread Jan Beulich
;min...@intel.com> > Signed-off-by: Yi Zhang <yi.z.zh...@intel.com> > Signed-off-by: Yu Zhang <yu.c.zh...@linux.intel.com> Reviewed-by: Jan Beulich <jbeul...@suse.com> ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v2 1/2] x86/mm: fix a potential race condition in map_pages_to_xen().

2017-11-13 Thread Jan Beulich
>>> On 13.11.17 at 11:34, wrote: > Our debug showed the concerned page->count_info was already(and > unexpectedly) > cleared in free_xenheap_pages(), and the call trace should be like this: > > free_xenheap_pages() > ^ > | > free_xen_pagetable() > ^ >

Re: [Xen-devel] [PATCH net-next v1] xen-netback: make copy batch size configurable

2017-11-13 Thread Jan Beulich
>>> On 13.11.17 at 11:33, wrote: >> From: Joao Martins [mailto:joao.m.mart...@oracle.com] >> Sent: 10 November 2017 19:35 >> --- a/drivers/net/xen-netback/netback.c >> +++ b/drivers/net/xen-netback/netback.c >> @@ -96,6 +96,11 @@ unsigned int xenvif_hash_cache_size = >>

Re: [Xen-devel] [PATCH for-4.10] docs: update hvmlite.markdown

2017-11-13 Thread Jan Beulich
. > - This being stale, wouldn't it then be better to rename the doc to pvh.markdown at the same time? Either way Acked-by: Jan Beulich <jbeul...@suse.com> Jan ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH] VMX: sync CPU state upon vCPU destruction

2017-11-13 Thread Jan Beulich
>>> On 10.11.17 at 15:46, <igor.druzhi...@citrix.com> wrote: > On 10/11/17 10:30, Jan Beulich wrote: >>>>> On 10.11.17 at 09:41, <sergey.dya...@citrix.com> wrote: >>>2. Drop v->is_running check inside vmx_ctxt_switch_from(

Re: [Xen-devel] [PATCH v2 2/2] x86/mm: fix a potential race condition in modify_xen_mappings().

2017-11-13 Thread Jan Beulich
>>> On 10.11.17 at 15:02, <yu.c.zh...@linux.intel.com> wrote: > On 11/10/2017 5:57 PM, Jan Beulich wrote: >>>>> On 10.11.17 at 08:18, <yu.c.zh...@linux.intel.com> wrote: >>> --- a/xen/arch/x86/mm.c >>> +++ b/xen/arch/x86/mm.c >>&

Re: [Xen-devel] [PATCH v2 1/2] x86/mm: fix a potential race condition in map_pages_to_xen().

2017-11-13 Thread Jan Beulich
>>> On 10.11.17 at 15:05, <yu.c.zh...@linux.intel.com> wrote: > On 11/10/2017 5:49 PM, Jan Beulich wrote: >> I'm not certain this is important enough a fix to consider for 4.10, >> and you seem to think it's good enough if this gets applied only >> after the t

Re: [Xen-devel] [PATCH v3 4/4] x86/cpuid: Enable new SSE/AVX/AVX512 cpu features

2017-11-10 Thread Jan Beulich
t; https://software.intel.com/sites/default/files/managed/c5/15/\ > architecture-instruction-set-extensions-programming-reference.pdf > > Signed-off-by: Yang Zhong <yang.zh...@intel.com> Non-toolstack parts Acked-by: Jan Beulich <jbeul...@suse.com&g

Re: [Xen-devel] [PATCH v3 0/4] x86/cpuid: enable new cpu features

2017-11-10 Thread Jan Beulich
>>> On 10.11.17 at 11:36, wrote: > The new cpu features in intel icelake: AVX512VBMI2/GFNI/VAES/ > AVX512VNNI/AVX512BITALG/VPCLMULQDQ. > > > v2: adjust the patches sequence from Jan I'm sorry, but please be a little more patient with sending new versions. Allow for at

Re: [Xen-devel] [PATCH v2 1/4] x86/cpuid: Enable new SSE/AVX/AVX512 cpu features

2017-11-10 Thread Jan Beulich
t; https://software.intel.com/sites/default/files/managed/c5/15/\ > architecture-instruction-set-extensions-programming-reference.pdf > > Signed-off-by: Yang Zhong <yang.zh...@intel.com> Properly placed last in the series, the non-toolstack parts here Acked-by: Jan Beulich <jb

Re: [Xen-devel] [PATCH] VMX: sync CPU state upon vCPU destruction

2017-11-10 Thread Jan Beulich
>>> On 10.11.17 at 09:41, <sergey.dya...@citrix.com> wrote: > On Thu, 2017-11-09 at 07:49 -0700, Jan Beulich wrote: >> --- a/xen/arch/x86/hvm/vmx/vmx.c >> +++ b/xen/arch/x86/hvm/vmx/vmx.c >> @@ -479,7 +479,13 @@ static void vmx_vcpu_destroy(struct vcpu >&

Re: [Xen-devel] [xen-unstable test] 115555: regressions - FAIL

2017-11-10 Thread Jan Beulich
>>> On 10.11.17 at 10:50, wrote: > On 10/11/17 10:33, Roger Pau Monné wrote: >> On Sat, Nov 04, 2017 at 11:14:35PM +, osstest service owner wrote: >>> flight 11 xen-unstable real [real] >>> http://logs.test-lab.xenproject.org/osstest/logs/11/ >>> >>> Regressions :-(

Re: [Xen-devel] [PATCH v2 2/2] x86/mm: fix a potential race condition in modify_xen_mappings().

2017-11-10 Thread Jan Beulich
>>> On 10.11.17 at 08:18, wrote: > --- a/xen/arch/x86/mm.c > +++ b/xen/arch/x86/mm.c > @@ -5097,6 +5097,17 @@ int modify_xen_mappings(unsigned long s, unsigned long > e, unsigned int nf) > */ > if ( (nf & _PAGE_PRESENT) || ((v != e) &&

Re: [Xen-devel] [BUG] blkback reporting incorrect number of sectors, unable to boot

2017-11-10 Thread Jan Beulich
>>> On 10.11.17 at 10:40, wrote: >> Anthony PERARD >> Sent: 09 November 2017 17:50 >> The problem is that QEMU 4.10 have a lock on the disk image. When >> booting an HVM guest with a qdisk backend, the disk is open twice, but >> can only be locked once, so when the pv

Re: [Xen-devel] [PATCH v2 1/2] x86/mm: fix a potential race condition in map_pages_to_xen().

2017-11-10 Thread Jan Beulich
if ( locking ) > +spin_unlock(_pgdir_lock); > +continue; > +} > + > ol3e = *pl3e; Same here - move the if() below here and use ol3e in there. With that Reviewed-by: Jan Beulich <jbeul...@suse.com> I'm not cer

Re: [Xen-devel] [PATCH v2 0/4] x86/cpuid: Enable new SSE/AVX/AVX512 cpu features

2017-11-10 Thread Jan Beulich
>>> On 10.11.17 at 10:36, wrote: > Yang Zhong (4): > x86/cpuid: Enable new SSE/AVX/AVX512 cpu features The ordering is wrong - as said before, these ... > x86emul: Support GFNI insns > x86emul: Support vpclmulqdq > x86emul: Support vaes insns ... are supposed to

Re: [Xen-devel] [PATCH v2 1/2] VMX: fix VMCS race on context-switch paths

2017-11-09 Thread Jan Beulich
>>> On 09.11.17 at 15:16, <raist...@linux.it> wrote: > On Thu, 2017-11-09 at 06:08 -0700, Jan Beulich wrote: >> Tasklets already take care of this by >> calling sync_local_execstate() before calling the handler. But >> for softirqs this isn't really an option;

Re: [Xen-devel] [PATCH v3 for-next 0/4] xen: Convert __page_to_mfn and _mfn_to_page to use typesafe MFN

2017-11-09 Thread Jan Beulich
>>> On 09.11.17 at 16:48, <julien.gr...@linaro.org> wrote: > On 09/11/17 15:47, Jan Beulich wrote: >>>>> On 09.11.17 at 16:39, <julien.gr...@linaro.org> wrote: >>> What I meant is you would replace the 4 occurrences by >>> mfn_to_page(_mf

Re: [Xen-devel] [PATCH v2] x86/pvh: Do not add DSDT and FACS to PVH dom0 XSDT

2017-11-09 Thread Jan Beulich
>>> On 09.11.17 at 16:37, <boris.ostrov...@oracle.com> wrote: > These tables are pointed to from FADT. Adding them will > result in duplicate entries in the guest's tables. > > Signed-off-by: Boris Ostrovsky <boris.ostrov...@oracle.com> Reviewed-b

Re: [Xen-devel] [PATCH v3 for-next 0/4] xen: Convert __page_to_mfn and _mfn_to_page to use typesafe MFN

2017-11-09 Thread Jan Beulich
>>> On 09.11.17 at 16:39, <julien.gr...@linaro.org> wrote: > On 09/11/17 15:36, Jan Beulich wrote: >>>>> On 09.11.17 at 16:20, <julien.gr...@linaro.org> wrote: >>> I had a look at the files that needs to convert. It seems there are few &

Re: [Xen-devel] [PATCH v3 for-next 0/4] xen: Convert __page_to_mfn and _mfn_to_page to use typesafe MFN

2017-11-09 Thread Jan Beulich
>>> On 09.11.17 at 16:20, wrote: > I had a look at the files that needs to convert. It seems there are few > files with page_to_mfn/mfn_to_page re-defined but no callers: > - arch/x86/mm/hap/nested_hap.c > - arch/x86/mm/p2m-pt.c > - arch/x86/pv/traps.c

Re: [Xen-devel] [PATCH 1/2 v2] xen: Add support for initializing 16550 UART using ACPI

2017-11-09 Thread Jan Beulich
>>> On 09.11.17 at 16:07, <roger@citrix.com> wrote: > On Thu, Nov 09, 2017 at 06:18:21AM -0700, Jan Beulich wrote: >> >>> On 09.11.17 at 12:31, <roger@citrix.com> wrote: >> > On Thu, Nov 09, 2017 at 03:49:23PM +0530, Bhupinder Thakur wrote:

[Xen-devel] [PATCH] VMX: sync CPU state upon vCPU destruction

2017-11-09 Thread Jan Beulich
See the code comment being added for why we need this. Reported-by: Igor Druzhinin <igor.druzhi...@citrix.com> Signed-off-by: Jan Beulich <jbeul...@suse.com> --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -479,7 +479,13 @@ static void vmx_vcpu_destroy(struct vcp

Re: [Xen-devel] [PATCH v2] x86/hvm: do not register hpet mmio during s3 cycle

2017-11-09 Thread Jan Beulich
>>> On 09.11.17 at 15:42, <julien.gr...@linaro.org> wrote: > Hi, > > On 09/11/17 08:55, Jan Beulich wrote: >>>>> On 08.11.17 at 20:46, <chanud...@ainfosec.com> wrote: >>> Do it once at domain creation (hpet_init). >>> >>

Re: [Xen-devel] [PATCH v2 1/2] VMX: fix VMCS race on context-switch paths

2017-11-09 Thread Jan Beulich
>>> On 09.11.17 at 15:16, wrote: > Ah, yes, my bad! What if I take vcpu_migrate() out of the above exec- > trace (which is what I wanted to do in my email already)? > > pCPU1 > = > current == vCPU1 > context_switch(next == idle) > !! __context_switch() is skipped >

Re: [Xen-devel] [PATCH 1/2 v2] xen: Add support for initializing 16550 UART using ACPI

2017-11-09 Thread Jan Beulich
>>> On 09.11.17 at 12:31, wrote: > On Thu, Nov 09, 2017 at 03:49:23PM +0530, Bhupinder Thakur wrote: >> +static int ns16550_init_dt(struct ns16550 *uart, >> + const struct dt_device_node *dev) >> +{ >> +return -EINVAL; >> +} >> +#endif >> + >>

Re: [Xen-devel] [PATCH v2 1/2] VMX: fix VMCS race on context-switch paths

2017-11-09 Thread Jan Beulich
>>> On 09.11.17 at 12:01, wrote: > Anyway, as I was trying to explain replaying to Jan, although in this > situation the issue manifests as a consequence of vCPU migration, I > think it is indeed more general, as in, without even the need to > consider a second pCPU: > > pCPU1

Re: [Xen-devel] [PATCH v2 1/2] VMX: fix VMCS race on context-switch paths

2017-11-09 Thread Jan Beulich
>>> On 09.11.17 at 11:36, wrote: > Well, I'm afraid I only see two solutions: > 1) we get rid of lazy context switch; > 2) whatever it is that is happening at point c above, it needs to be >aware that we use lazy context switch, and make sure to sync the >context

Re: [Xen-devel] [PATCH] x86/mm: fix a potential race condition in map_pages_to_xen().

2017-11-09 Thread Jan Beulich
>>> On 09.11.17 at 11:24, <yu.c.zh...@linux.intel.com> wrote: > On 11/9/2017 5:19 PM, Jan Beulich wrote: >> 2) Is your change actually enough to take care of all forms of the >> race you describe? In particular, isn't it necessary to re-check PSE >> after having

Re: [Xen-devel] [PATCH v2 1/2] VMX: fix VMCS race on context-switch paths

2017-11-09 Thread Jan Beulich
>>> On 09.11.17 at 10:54, wrote: > On Tue, 2017-11-07 at 14:24 +, Igor Druzhinin wrote: >> Perhaps I should improve my diagram: >> >> pCPU1: vCPUx of domain X -> migrate to pCPU2 -> switch to idle >> context >> -> RCU callbacks -> vcpu_destroy(vCPUy of domain Y) -> >>

Re: [Xen-devel] [PATCH v2 1/2] VMX: fix VMCS race on context-switch paths

2017-11-09 Thread Jan Beulich
>>> On 07.11.17 at 16:52, wrote: > There is one things that I'm worrying about with this approach: > > At this place we just sync the idle context because we know that we are > going to deal with VMCS later. But what about other potential cases > (perhaps some

Re: [Xen-devel] [PATCH] x86/mm: fix a potential race condition in map_pages_to_xen().

2017-11-09 Thread Jan Beulich
>>> On 09.11.17 at 16:29, wrote: > In map_pages_to_xen(), a L2 page table entry may be reset to point to > a superpage, and its corresponding L1 page table need be freed in such > scenario, when these L1 page table entries are mapping to consecutive > page frames and

Re: [Xen-devel] [PATCH] x86/mm: fix a potential race condition in map_pages_to_xen().

2017-11-09 Thread Jan Beulich
>>> On 09.11.17 at 16:29, wrote: > --- a/xen/arch/x86/mm.c > +++ b/xen/arch/x86/mm.c > @@ -4844,9 +4844,10 @@ int map_pages_to_xen( > { > unsigned long base_mfn; > > -pl1e = l2e_to_l1e(*pl2e); > if (

Re: [Xen-devel] [PATCH] x86/pvh: Do not add DSDT and FACS to PVH dom0 XSDT

2017-11-09 Thread Jan Beulich
>>> On 08.11.17 at 21:19, wrote: > These tables are pointed to from FADT. Adding them will > result in duplicate entries in the guest's tables. Oh, indeed. Just one small adjustment request: > +static bool __init pvh_acpi_table_in_xsdt(const char *sig) > +{ > +/*

Re: [Xen-devel] [PATCH v2] x86/hvm: do not register hpet mmio during s3 cycle

2017-11-09 Thread Jan Beulich
function altogether). Static functions outside of header files should not normally be marked "inline" explicitly - it should be the compiler to make that decision. As doing the adjustment it relatively simple, I wouldn't mind doing so while committing, saving another round tri

Re: [Xen-devel] [PATCH V2] Xen/pciback: Implement PCI slot or bus reset with 'do_flr' SysFS attribute

2017-11-09 Thread Jan Beulich
>>> On 09.11.17 at 00:06, wrote: > --- a/drivers/xen/xen-pciback/pci_stub.c > +++ b/drivers/xen/xen-pciback/pci_stub.c > @@ -244,6 +244,91 @@ struct pci_dev *pcistub_get_pci_dev(struct > xen_pcibk_device *pdev, > return found_dev; > } > > +struct pcistub_args {

Re: [Xen-devel] [PATCH] Xen/pciback: Implement PCI slot or bus reset with 'do_flr' SysFS attribute

2017-11-09 Thread Jan Beulich
>>> On 08.11.17 at 16:44, <govinda.ta...@oracle.com> wrote: > On 11/7/2017 8:40 AM, Jan Beulich wrote: >>>>> On 06.11.17 at 18:48, <govinda.ta...@oracle.com> wrote: >>> --- a/Documentation/ABI/testing/sysfs-driver-pciback >>> +++ b/Documenta

Re: [Xen-devel] [BUG] xen-mceinj tool testing cause dom0 crash

2017-11-09 Thread Jan Beulich
>>> On 09.11.17 at 02:44, <haozhong.zh...@intel.com> wrote: > On 11/07/17 01:37 -0700, Jan Beulich wrote: >> I don't believe a crash is the expected outcome here. >> > > This test case injects two errors to the same dom0 page. During the > first inj

Re: [Xen-devel] [PATCH 3/3] x86/xen: use guest_late_init to detect Xen PVH guest

2017-11-08 Thread Jan Beulich
>>> On 08.11.17 at 13:45, <jgr...@suse.com> wrote: > On 08/11/17 13:31, Jan Beulich wrote: >>>>> On 08.11.17 at 12:55, <jgr...@suse.com> wrote: >>> On 08/11/17 12:18, Jan Beulich wrote: >>>>>>> On 08.11.17 at 10:07, <jgr...

Re: [Xen-devel] [PATCH for-4.10] gcov: return EOPNOTSUPP for unimplemented gcov domctl

2017-11-08 Thread Jan Beulich
>>> On 07.11.17 at 13:31, <roger@citrix.com> wrote: > ENOSYS should only be used by unimplemented top-level syscalls. Use > EOPNOTSUPP instead. > > Signed-off-by: Roger Pau Monné <roger....@citrix.com> > Reported-by: Jan Beulich <jbeul...@suse.c

  1   2   3   4   5   6   7   8   9   10   >