[Xen-devel] [PATCH 1/2] gnttab: Introduce rwlock to protect updates to grant table state

2014-12-02 Thread Christoph Egger
Rename lock to maptrack_lock and use it to protect maptrack state. The new rwlock is used to prevent readers from accessing inconsistent grant table state such as current version, partially initialized active table pages, etc. Signed-off-by: Matt Wilson m...@amazon.com [chegger: ported to

Re: [Xen-devel] [PATCH 1/2] gnttab: Introduce rwlock to protect updates to grant table state

2014-12-02 Thread Andrew Cooper
On 02/12/14 10:06, Christoph Egger wrote: Rename lock to maptrack_lock and use it to protect maptrack state. The new rwlock is used to prevent readers from accessing inconsistent grant table state such as current version, partially initialized active table pages, etc. I would suggest

Re: [Xen-devel] [PATCH 1/2] gnttab: Introduce rwlock to protect updates to grant table state

2014-12-02 Thread Julien Grall
Hi Christoph, On 02/12/14 10:06, Christoph Egger wrote: diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c index 522c43d..37c13b1 100644 --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -4565,7 +4565,7 @@ int xenmem_add_to_physmap_one( mfn = virt_to_mfn(d-shared_info);

Re: [Xen-devel] [PATCH 1/2] gnttab: Introduce rwlock to protect updates to grant table state

2014-12-02 Thread Egger, Christoph
On 2014/12/02 13:35, Julien Grall wrote: Hi Christoph, On 02/12/14 10:06, Christoph Egger wrote: diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c index 522c43d..37c13b1 100644 --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -4565,7 +4565,7 @@ int xenmem_add_to_physmap_one(

Re: [Xen-devel] [PATCH 1/2] gnttab: Introduce rwlock to protect updates to grant table state

2014-12-02 Thread Julien Grall
Hi, On 02/12/14 13:03, Egger, Christoph wrote: On 2014/12/02 13:35, Julien Grall wrote: Hi Christoph, On 02/12/14 10:06, Christoph Egger wrote: diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c index 522c43d..37c13b1 100644 --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -4565,7

Re: [Xen-devel] [PATCH 1/2] gnttab: Introduce rwlock to protect updates to grant table state

2014-12-02 Thread Egger, Christoph
On 2014/12/02 14:08, Julien Grall wrote: Hi, On 02/12/14 13:03, Egger, Christoph wrote: On 2014/12/02 13:35, Julien Grall wrote: Hi Christoph, On 02/12/14 10:06, Christoph Egger wrote: diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c index 522c43d..37c13b1 100644 ---