Re: [Xen-devel] [PATCH v2] x86/emul: Simplfy L{ES, DS, SS, FS, GS} handling

2016-12-15 Thread Jan Beulich
>>> On 15.12.16 at 18:10, wrote: > %ss, %fs and %gs can be calculated by directly masking the opcode. %es and > %ds cant, but the calculation isn't hard. > > Use seg rather than dst.val for storing the calculated segment, which is > appropriately typed. Drop the sel

[Xen-devel] [PATCH v2] x86/emul: Simplfy L{ES, DS, SS, FS, GS} handling

2016-12-15 Thread Andrew Cooper
%ss, %fs and %gs can be calculated by directly masking the opcode. %es and %ds cant, but the calculation isn't hard. Use seg rather than dst.val for storing the calculated segment, which is appropriately typed. Drop the sel local variable entirely and use dst.val instead. The mode_64bit()