Re: [Xen-devel] [PATCH v2 5/9] xen/pvh: Prevent PVH guests from using PIC, RTC and IOAPIC

2017-02-02 Thread Boris Ostrovsky
On 02/02/2017 11:40 AM, Roger Pau Monné wrote: > On Thu, Feb 02, 2017 at 11:30:19AM -0500, Boris Ostrovsky wrote: >> On 02/02/2017 10:35 AM, Roger Pau Monné wrote: >>> On Thu, Jan 26, 2017 at 02:41:28PM -0500, Boris Ostrovsky wrote: Make sure they don't use these devices since they are not

Re: [Xen-devel] [PATCH v2 5/9] xen/pvh: Prevent PVH guests from using PIC, RTC and IOAPIC

2017-02-02 Thread Roger Pau Monné
On Thu, Feb 02, 2017 at 11:30:19AM -0500, Boris Ostrovsky wrote: > On 02/02/2017 10:35 AM, Roger Pau Monné wrote: > > On Thu, Jan 26, 2017 at 02:41:28PM -0500, Boris Ostrovsky wrote: > >> Make sure they don't use these devices since they are not emulated > >> for unprivileged PVH guest. > > This

Re: [Xen-devel] [PATCH v2 5/9] xen/pvh: Prevent PVH guests from using PIC, RTC and IOAPIC

2017-02-02 Thread Boris Ostrovsky
On 02/02/2017 10:35 AM, Roger Pau Monné wrote: > On Thu, Jan 26, 2017 at 02:41:28PM -0500, Boris Ostrovsky wrote: >> Make sure they don't use these devices since they are not emulated >> for unprivileged PVH guest. > This description seems weird for what it's actually done. AFAICT you are not >

Re: [Xen-devel] [PATCH v2 5/9] xen/pvh: Prevent PVH guests from using PIC, RTC and IOAPIC

2017-02-02 Thread Roger Pau Monné
On Thu, Jan 26, 2017 at 02:41:28PM -0500, Boris Ostrovsky wrote: > Make sure they don't use these devices since they are not emulated > for unprivileged PVH guest. This description seems weird for what it's actually done. AFAICT you are not really preventing the guest from using the PIC or the IO

Re: [Xen-devel] [PATCH v2 5/9] xen/pvh: Prevent PVH guests from using PIC, RTC and IOAPIC

2017-02-02 Thread Juergen Gross
On 26/01/17 20:41, Boris Ostrovsky wrote: > Make sure they don't use these devices since they are not emulated > for unprivileged PVH guest. > > Also don't initialize hypercall page for them in init_hvm_pv_info() > since this has already been done. > > Signed-off-by: Boris Ostrovsky

[Xen-devel] [PATCH v2 5/9] xen/pvh: Prevent PVH guests from using PIC, RTC and IOAPIC

2017-01-26 Thread Boris Ostrovsky
Make sure they don't use these devices since they are not emulated for unprivileged PVH guest. Also don't initialize hypercall page for them in init_hvm_pv_info() since this has already been done. Signed-off-by: Boris Ostrovsky --- Changes in v2: * Use cpuid_ebx()