[Xen-devel] [ovmf test] 148414: all pass - PUSHED

2020-03-11 Thread osstest service owner
flight 148414 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/148414/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 6b7855209ad8e3e077a24faa40f69acdc231ff4f baseline version: ovmf

[Xen-devel] [libvirt test] 148406: regressions - FAIL

2020-03-11 Thread osstest service owner
flight 148406 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/148406/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 146182 build-i386-libvirt

[Xen-devel] [linux-4.14 test] 148371: regressions - FAIL

2020-03-11 Thread osstest service owner
flight 148371 linux-4.14 real [real] http://logs.test-lab.xenproject.org/osstest/logs/148371/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-rtds broken in 148294

[Xen-devel] [qemu-mainline bisection] complete test-amd64-i386-xl-qemuu-debianhvm-amd64

2020-03-11 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-amd64-i386-xl-qemuu-debianhvm-amd64 testid debian-hvm-install Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tree: qemu

[Xen-devel] [xen-unstable-smoke test] 148450: tolerable all pass - PUSHED

2020-03-11 Thread osstest service owner
flight 148450 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/148450/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

[Xen-devel] [PATCH] x86/vvmx: Fix deadlock with MSR bitmap merging

2020-03-11 Thread Andrew Cooper
c/s c47984aabead "nvmx: implement support for MSR bitmaps" introduced a use of map_domain_page() which may get used in the middle of context switch. This is not safe, and causes Xen to deadlock on the mapcache lock: (XEN) Xen call trace: (XEN)[] R _spin_lock+0x34/0x5e (XEN)[] F

[Xen-devel] [linux-4.19 test] 148364: regressions - FAIL

2020-03-11 Thread osstest service owner
flight 148364 linux-4.19 real [real] http://logs.test-lab.xenproject.org/osstest/logs/148364/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-multivcpu broken in 148288

[Xen-devel] nvmx deadlock with MSR bitmaps

2020-03-11 Thread Andrew Cooper
Hello, Testing has encountered this deadlock: (XEN) Watchdog timer detects that CPU0 is stuck! (XEN) [ Xen-4.14.0-9.0.4-d  x86_64  debug=y   Not tainted ] (XEN) CPU:    0 (XEN) RIP:    e008:[] _spin_lock+0x34/0x5e (XEN) RFLAGS: 0002   CONTEXT: hypervisor (d0v0) (XEN) rax:

[Xen-devel] [XEN PATCH 1/2] tools/python: Fix install-wrap

2020-03-11 Thread Anthony PERARD
This allows to use install-wrap when the source scripts is in a subdirectory. Signed-off-by: Anthony PERARD --- tools/python/install-wrap | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/python/install-wrap b/tools/python/install-wrap index 00e2014016f9..fef24e01708d

[Xen-devel] [XEN PATCH 0/2] Fix installation of python scripts

2020-03-11 Thread Anthony PERARD
Patch series available in this git branch: https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.fix-python-install-v1 Hi, A patch to make packaging of xen on centos8 easier. rpmbuild prevents unversions python shebang from been packaged. And the first patch fix a bug discovered

[Xen-devel] [XEN PATCH 2/2] tools: Use INSTALL_PYTHON_PROG

2020-03-11 Thread Anthony PERARD
Whenever python scripts are install, have the shebang be modified to use whatever PYTHON_PATH is. This is useful for system where python isn't available, or where the package build tools prevent unversioned shebang. INSTALL_PYTHON_PROG only looks for "#!/usr/bin/env python". Signed-off-by:

Re: [Xen-devel] [XEN PATCH v3 2/2] xen/arm: Configure early printk via Kconfig

2020-03-11 Thread Anthony PERARD
On Wed, Mar 11, 2020 at 05:21:24PM +, Julien Grall wrote: > On 11/03/2020 15:26, Anthony PERARD wrote: > > On Wed, Mar 11, 2020 at 02:18:20PM +, Julien Grall wrote: > > > > +config EARLY_UART_BASE_ADDRESS > > > > + depends on EARLY_PRINTK > > > > + hex "Early printk, physical

[Xen-devel] [PATCH OSSTEST v5 5/5] make-flight: add dom0 PVH test

2020-03-11 Thread Roger Pau Monne
Add a dom0 PVH test, the test to be run is launching a PV guest (test-debian). Note the PVH dom0 tests are only enabled for Xen >= 4.13. The runvar difference is: +test-amd64-amd64-dom0pvh-xl-amd all_host_di_version 2020-02-10 +test-amd64-amd64-dom0pvh-xl-intel all_host_di_version 2020-02-10

Re: [Xen-devel] [XEN PATCH v3 2/2] xen/arm: Configure early printk via Kconfig

2020-03-11 Thread Julien Grall
Hi Anthony, On 11/03/2020 15:26, Anthony PERARD wrote: On Wed, Mar 11, 2020 at 02:18:20PM +, Julien Grall wrote: diff --git a/docs/misc/arm/early-printk.txt b/docs/misc/arm/early-printk.txt index 89e081e51eaf..c61973013097 100644 --- a/docs/misc/arm/early-printk.txt +++

[Xen-devel] [PATCH OSSTEST v5 4/5] examine: detect IOMMU availability and add it as a hostflag

2020-03-11 Thread Roger Pau Monne
Introduce a new test to check for iommu availability and add it as a hostflag if found. Signed-off-by: Roger Pau Monné --- Changes since v4: - Split out code into separate patches. Changes since v3: - Fail if `xl info` command fails. Changes since v2: - Allow flags to be removed. - Fix

[Xen-devel] [PATCH OSSTEST v5 1/5] host: introduce modify_host

2020-03-11 Thread Roger Pau Monne
Abstract the set_property checks and DB call into a helper. No functional change. Signed-off-by: Roger Pau Monné --- Requested on IRC: 17:09:30 Diziet Also if it were me I would put the modify_host refactoring in its own nfc patch, but I won't insist on that... --- changes

[Xen-devel] [PATCH OSSTEST v5 2/5] host: introduce a helper to modify hostflags

2020-03-11 Thread Roger Pau Monne
Add a generic function to perform database changes related to a host flag and add a wrapper to TestSupport. Signed-off-by: Roger Pau Monné --- Changes since v4: - Move addition of hostflag_putative_record to a different patch. - Introduce a single helper in TestSupport: modify_host_flag.

[Xen-devel] [PATCH OSSTEST v5 3/5] ts-examine-hostprops-save: record hostflags also

2020-03-11 Thread Roger Pau Monne
Commit putative hotflags into the database if present on the runvars. Signed-off-by: Roger Pau Monné --- Changes since v4: - New in this version. --- Requested by Ian on IRC: 17:08:58 Diziet royger: I think your ts-examine-hostprops-save hunk in 2/ belongs in 1/ ? (Or in a

[Xen-devel] [xen-unstable-smoke test] 148436: regressions - FAIL

2020-03-11 Thread osstest service owner
flight 148436 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/148436/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-debianhvm-amd64 18 guest-start/debianhvm.repeat fail REGR. vs.

Re: [Xen-devel] [PATCH v5 2/2] x86: add accessors for scratch cpu mask

2020-03-11 Thread Jan Beulich
On 11.03.2020 16:51, Roger Pau Monné wrote: > On Wed, Mar 11, 2020 at 04:37:50PM +0100, Jan Beulich wrote: >> On 11.03.2020 16:34, Roger Pau Monné wrote: >>> On Fri, Feb 28, 2020 at 01:42:58PM +0100, Jan Beulich wrote: On 28.02.2020 13:07, Roger Pau Monne wrote: > Current usage of the

Re: [Xen-devel] [PATCH OSSTEST v4 3/3] make-flight: add dom0 PVH test

2020-03-11 Thread Ian Jackson
Roger Pau Monne writes ("[PATCH OSSTEST v4 3/3] make-flight: add dom0 PVH test"): > Add a dom0 PVH test, the test to be run is launching a PV guest > (test-debian). Note the PVH dom0 tests are only enabled for Xen >= > 4.13. Reviewed-by: Ian Jackson

[Xen-devel] [PATCH OSSTEST v4 1/3] host: introduce helpers to modify hostflags

2020-03-11 Thread Roger Pau Monne
Add a generic function to perform database changes related to a host and use it to implement set_property and and {set/remove}_flag. Signed-off-by: Roger Pau Monné --- Changes since v3: - Introduce modify_flag instead of {set/remove}_flag. - Introduce a generic modify_host helper. - Split

[Xen-devel] [PATCH OSSTEST v4 3/3] make-flight: add dom0 PVH test

2020-03-11 Thread Roger Pau Monne
Add a dom0 PVH test, the test to be run is launching a PV guest (test-debian). Note the PVH dom0 tests are only enabled for Xen >= 4.13. The runvar difference is: +test-amd64-amd64-dom0pvh-xl-amd all_host_di_version 2020-02-10 +test-amd64-amd64-dom0pvh-xl-intel all_host_di_version 2020-02-10

[Xen-devel] [PATCH OSSTEST v4 2/3] examine: detect IOMMU availability and add it as a hostflag

2020-03-11 Thread Roger Pau Monne
Introduce a new test to check for iommu availability and add it as a hostflag if found. Signed-off-by: Roger Pau Monné --- Changes since v3: - Fail if `xl info` command fails. Changes since v2: - Allow flags to be removed. - Fix set_flag addition to HostBD/Static.pm. --- sg-run-job

Re: [Xen-devel] [PATCH v5 2/2] x86: add accessors for scratch cpu mask

2020-03-11 Thread Roger Pau Monné
On Wed, Mar 11, 2020 at 04:37:50PM +0100, Jan Beulich wrote: > On 11.03.2020 16:34, Roger Pau Monné wrote: > > On Fri, Feb 28, 2020 at 01:42:58PM +0100, Jan Beulich wrote: > >> On 28.02.2020 13:07, Roger Pau Monne wrote: > >>> Current usage of the per-CPU scratch cpumask is dangerous since > >>>

Re: [Xen-devel] [PATCH v5 2/2] x86: add accessors for scratch cpu mask

2020-03-11 Thread Jan Beulich
On 11.03.2020 16:34, Roger Pau Monné wrote: > On Fri, Feb 28, 2020 at 01:42:58PM +0100, Jan Beulich wrote: >> On 28.02.2020 13:07, Roger Pau Monne wrote: >>> Current usage of the per-CPU scratch cpumask is dangerous since >>> there's no way to figure out if the mask is already being used except

Re: [Xen-devel] [PATCH v5 2/2] x86: add accessors for scratch cpu mask

2020-03-11 Thread Roger Pau Monné
On Fri, Feb 28, 2020 at 01:42:58PM +0100, Jan Beulich wrote: > On 28.02.2020 13:07, Roger Pau Monne wrote: > > Current usage of the per-CPU scratch cpumask is dangerous since > > there's no way to figure out if the mask is already being used except > > for manual code inspection of all the callers

Re: [Xen-devel] [PATCH v2 1/9] x86/HVM: reduce domain.h include dependencies

2020-03-11 Thread Andrew Cooper
On 11/03/2020 15:22, Jan Beulich wrote: > On 11.03.2020 14:09, Andrew Cooper wrote: >> On 10/03/2020 15:48, Jan Beulich wrote: >>> Drop #include-s not needed by the header itself. Put the ones needed >>> into whichever other files actually need them. >>> >>> Signed-off-by: Jan Beulich >>> --- >>>

Re: [Xen-devel] [PATCH v5 6/6] domain: use PGC_extra domheap page for shared_info

2020-03-11 Thread Paul Durrant
> -Original Message- > From: Jan Beulich > Sent: 11 March 2020 09:17 > To: p...@xen.org > Cc: xen-devel@lists.xenproject.org; 'Paul Durrant' ; > 'Stefano Stabellini' > ; 'Julien Grall' ; 'Volodymyr Babchuk' > ; 'Andrew Cooper' ; > 'George Dunlap' > ; 'Ian Jackson' ; > 'Konrad Rzeszutek

Re: [Xen-devel] [XEN PATCH v3 2/2] xen/arm: Configure early printk via Kconfig

2020-03-11 Thread Anthony PERARD
On Wed, Mar 11, 2020 at 02:18:20PM +, Julien Grall wrote: > > diff --git a/docs/misc/arm/early-printk.txt b/docs/misc/arm/early-printk.txt > > index 89e081e51eaf..c61973013097 100644 > > --- a/docs/misc/arm/early-printk.txt > > +++ b/docs/misc/arm/early-printk.txt > > @@ -1,64 +1,39 @@ > >

Re: [Xen-devel] [PATCH v2 1/9] x86/HVM: reduce domain.h include dependencies

2020-03-11 Thread Jan Beulich
On 11.03.2020 14:09, Andrew Cooper wrote: > On 10/03/2020 15:48, Jan Beulich wrote: >> Drop #include-s not needed by the header itself. Put the ones needed >> into whichever other files actually need them. >> >> Signed-off-by: Jan Beulich >> --- >> v2: Also make things build with XSM=y. > >

Re: [Xen-devel] [PATCH v4 3/3] golang/xenlight: Implement DomainCreateNew

2020-03-11 Thread George Dunlap
On 3/11/20 2:59 PM, Nick Rosbrook wrote: > Looks good, I just have two small comments: > >> diff --git a/tools/golang/xenlight/xenlight.go >> b/tools/golang/xenlight/xenlight.go >> index 56fa31fd7b..808b4a327c 100644 >> --- a/tools/golang/xenlight/xenlight.go >> +++

Re: [Xen-devel] [PATCH v4 3/3] golang/xenlight: Implement DomainCreateNew

2020-03-11 Thread Nick Rosbrook
Looks good, I just have two small comments: > diff --git a/tools/golang/xenlight/xenlight.go > b/tools/golang/xenlight/xenlight.go > index 56fa31fd7b..808b4a327c 100644 > --- a/tools/golang/xenlight/xenlight.go > +++ b/tools/golang/xenlight/xenlight.go > @@ -,3 +,24 @@ func (Ctx

Re: [Xen-devel] [PATCH v8 02/10] scripts: add coccinelle script to use auto propagated errp

2020-03-11 Thread Vladimir Sementsov-Ogievskiy
11.03.2020 17:41, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: 11.03.2020 12:38, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: 09.03.2020 12:56, Markus Armbruster wrote: Suggest scripts: Coccinelle script to use auto-propagated errp or

Re: [Xen-devel] [XEN PATCH v3 1/2] xen/arm: Rename all early printk macro

2020-03-11 Thread Anthony PERARD
On Wed, Mar 11, 2020 at 01:57:37PM +, Julien Grall wrote: > Hi Anthony, > > On 09/03/2020 17:45, Anthony PERARD wrote: > > diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S > > index e9d356f05c2b..2b593c5ef99a 100644 > > --- a/xen/arch/arm/arm32/head.S > > +++

Re: [Xen-devel] [PATCH v8 02/10] scripts: add coccinelle script to use auto propagated errp

2020-03-11 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 11.03.2020 12:38, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy writes: >> >>> 09.03.2020 12:56, Markus Armbruster wrote: Suggest scripts: Coccinelle script to use auto-propagated errp or scripts:

Re: [Xen-devel] [PATCH v4 2/3] golang/xenlight: Notify xenlight of SIGCHLD

2020-03-11 Thread Nick Rosbrook
> libxl forks external processes and waits for them to complete; it > therefore needs to be notified when children exit. > > In absence of instructions to the contrary, libxl sets up its own > SIGCHLD handlers. > > Golang always unmasks and handles SIGCHLD itself. libxl thankfully > notices this

Re: [Xen-devel] [XEN PATCH v3 2/2] xen/arm: Configure early printk via Kconfig

2020-03-11 Thread Julien Grall
Hi Anthony, On 09/03/2020 17:45, Anthony PERARD wrote: At the moment, early printk can only be configured on the make command line. It is not very handy because a user has to remove the option everytime it is using another command other than compiling the hypervisor. Furthermore, early printk

Re: [Xen-devel] [PATCH v4 1/3] golang/xenlight: Don't try to marshall zero-length arrays in fromC

2020-03-11 Thread Nicholas Rosbrook
> The current fromC array code will do the "magic" casting and > martialling even when num_foo variable is 0.  Go crashes when doing > the cast. > > Only do array marshalling if the number of elements is non-zero; > otherwise, leave the target pointer empty (nil for Go slices, NULL for > C

Re: [Xen-devel] [PATCH OSSTEST v2 2/2] make-flight: add dom0 PVH test

2020-03-11 Thread Roger Pau Monné
On Tue, Mar 10, 2020 at 03:52:56PM +, Ian Jackson wrote: > Roger Pau Monne writes ("[PATCH OSSTEST v2 2/2] make-flight: add dom0 PVH > test"): > > Add a dom0 PVH test, the test to be run is launching a PV guest > > (test-debian). Note the PVH dom0 tests are only enabled for Xen >= > > 4.13. >

Re: [Xen-devel] [PATCH v8 02/10] scripts: add coccinelle script to use auto propagated errp

2020-03-11 Thread Vladimir Sementsov-Ogievskiy
11.03.2020 12:38, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: 09.03.2020 12:56, Markus Armbruster wrote: Suggest scripts: Coccinelle script to use auto-propagated errp or scripts: Coccinelle script to use ERRP_AUTO_PROPAGATE() Vladimir Sementsov-Ogievskiy

Re: [Xen-devel] [PATCH OSSTEST v2 1/2] examine: detect IOMMU availability and add it as a hostflag

2020-03-11 Thread Ian Jackson
Roger Pau Monne writes ("Re: [PATCH OSSTEST v2 1/2] examine: detect IOMMU availability and add it as a hostflag"): > On Tue, Mar 10, 2020 at 03:51:34PM +, Ian Jackson wrote: > > Firstly, can you break this new code out into its own patch ? > > Can do, but then there will be no user of the

Re: [Xen-devel] [XEN PATCH v3 1/2] xen/arm: Rename all early printk macro

2020-03-11 Thread Julien Grall
Hi Anthony, On 09/03/2020 17:45, Anthony PERARD wrote: diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S index e9d356f05c2b..2b593c5ef99a 100644 --- a/xen/arch/arm/arm32/head.S +++ b/xen/arch/arm/arm32/head.S @@ -36,8 +36,8 @@ #define XEN_FIRST_SLOT

Re: [Xen-devel] [PATCH OSSTEST v2 1/2] examine: detect IOMMU availability and add it as a hostflag

2020-03-11 Thread Roger Pau Monné
On Tue, Mar 10, 2020 at 03:51:34PM +, Ian Jackson wrote: > Roger Pau Monne writes ("[PATCH OSSTEST v2 1/2] examine: detect IOMMU > availability and add it as a hostflag"): > > Introduce a new test to check for iommu availability and add it as a > > hostflag if found. > > Thanks. > > > +sub

[Xen-devel] [linux-5.4 test] 148356: regressions - FAIL

2020-03-11 Thread osstest service owner
flight 148356 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/148356/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-debianhvm-amd64 broken in 148282 test-amd64-amd64-xl-credit2

Re: [Xen-devel] [PATCH v2 1/9] x86/HVM: reduce domain.h include dependencies

2020-03-11 Thread Andrew Cooper
On 10/03/2020 15:48, Jan Beulich wrote: > Drop #include-s not needed by the header itself. Put the ones needed > into whichever other files actually need them. > > Signed-off-by: Jan Beulich > --- > v2: Also make things build with XSM=y. Looking better, but still got problems. xen_pv_console.c:

Re: [Xen-devel] [PATCH v3] block: refactor duplicated macros

2020-03-11 Thread Jens Axboe
On 3/10/20 6:22 PM, Matteo Croce wrote: > The macros PAGE_SECTORS, PAGE_SECTORS_SHIFT and SECTOR_MASK are defined > several times in different flavours across the whole tree. > Define them just once in a common header. > > While at it, replace replace "PAGE_SHIFT - 9" with "PAGE_SECTORS_SHIFT"

Re: [Xen-devel] [PATCH OSSTEST v3 1/2] examine: detect IOMMU availability and add it as a hostflag

2020-03-11 Thread Ian Jackson
Roger Pau Monne writes ("[PATCH OSSTEST v3 1/2] examine: detect IOMMU availability and add it as a hostflag"): > Introduce a new test to check for iommu availability and add it as a > hostflag if found. I regret to have to say that you seem to have overlooked my emailed review comments on v2.

Re: [Xen-devel] [PATCH v4 6/6] xen/rcu: add per-lock counter in debug builds

2020-03-11 Thread Jürgen Groß
On 11.03.20 13:14, Jan Beulich wrote: On 10.03.2020 08:28, Juergen Gross wrote: Add a lock specific counter to rcu read locks in debug builds. This allows to test for matching lock/unlock calls. Similar checking doesn't exist for e.g. spin locks iirc, and hence I think you want to spend the

Re: [Xen-devel] [PATCH] scripts: Use stat to check lock claim

2020-03-11 Thread Jason Andryuk
On Tue, Mar 10, 2020 at 4:06 PM Jason Andryuk wrote: > > On Tue, Mar 10, 2020 at 11:43 AM Ian Jackson wrote: > > Alternatively, if you don't mind using --printf instead of -c, > > > > $ bash -c 'x=$( stat -L --format "%D.%i " t u 2>/dev/null || : ); echo > > ${x%% *} = ${x#* }' > > fe04.844307

Re: [Xen-devel] [PATCH v4 6/6] xen/rcu: add per-lock counter in debug builds

2020-03-11 Thread Jan Beulich
On 10.03.2020 08:28, Juergen Gross wrote: > Add a lock specific counter to rcu read locks in debug builds. This > allows to test for matching lock/unlock calls. Similar checking doesn't exist for e.g. spin locks iirc, and hence I think you want to spend the word on the "why" here. Jan

Re: [Xen-devel] [PATCH v4 3/6] xen: add process_pending_softirqs_norcu() for keyhandlers

2020-03-11 Thread Jürgen Groß
On 11.03.20 12:33, Jan Beulich wrote: On 11.03.2020 10:47, Jürgen Groß wrote: On 11.03.20 10:36, Jan Beulich wrote: On 11.03.2020 10:27, Jürgen Groß wrote: On 11.03.20 10:25, Jan Beulich wrote: On 11.03.2020 07:07, Jürgen Groß wrote: On 10.03.20 18:02, Jan Beulich wrote: On 10.03.2020

Re: [Xen-devel] [PATCH v4 4/6] xen/rcu: fix rcu_lock_domain()

2020-03-11 Thread Jürgen Groß
On 11.03.20 12:35, Jan Beulich wrote: On 10.03.2020 08:28, Juergen Gross wrote: rcu_lock_domain() misuses the domain structure as rcu lock, which is working only as long as rcu_read_lock() isn't evaluating the lock. Fix that by adding a rcu lock to struct domain and use that for

Re: [Xen-devel] [PATCH v4 4/6] xen/rcu: fix rcu_lock_domain()

2020-03-11 Thread Jan Beulich
On 10.03.2020 08:28, Juergen Gross wrote: > rcu_lock_domain() misuses the domain structure as rcu lock, which is > working only as long as rcu_read_lock() isn't evaluating the lock. > > Fix that by adding a rcu lock to struct domain and use that for > rcu_lock_domain(). > > Signed-off-by:

Re: [Xen-devel] [PATCH v4 3/6] xen: add process_pending_softirqs_norcu() for keyhandlers

2020-03-11 Thread Jan Beulich
On 11.03.2020 10:47, Jürgen Groß wrote: > On 11.03.20 10:36, Jan Beulich wrote: >> On 11.03.2020 10:27, Jürgen Groß wrote: >>> On 11.03.20 10:25, Jan Beulich wrote: On 11.03.2020 07:07, Jürgen Groß wrote: > On 10.03.20 18:02, Jan Beulich wrote: >> On 10.03.2020 08:28, Juergen Gross

Re: [Xen-devel] [PATCH v3] block: refactor duplicated macros

2020-03-11 Thread Coly Li
On 2020/3/11 8:22 上午, Matteo Croce wrote: > The macros PAGE_SECTORS, PAGE_SECTORS_SHIFT and SECTOR_MASK are defined > several times in different flavours across the whole tree. > Define them just once in a common header. > > While at it, replace replace "PAGE_SHIFT - 9" with "PAGE_SECTORS_SHIFT"

[Xen-devel] [PATCH OSSTEST v3 1/2] examine: detect IOMMU availability and add it as a hostflag

2020-03-11 Thread Roger Pau Monne
Introduce a new test to check for iommu availability and add it as a hostflag if found. Signed-off-by: Roger Pau Monné --- Changes since v2: - Allow flags to be removed. - Fix set_flag addition to HostBD/Static.pm. --- Osstest/HostDB/Executive.pm | 34 ++

[Xen-devel] [PATCH OSSTEST v3 2/2] make-flight: add dom0 PVH test

2020-03-11 Thread Roger Pau Monne
Add a dom0 PVH test, the test to be run is launching a PV guest (test-debian). Note the PVH dom0 tests are only enabled for Xen >= 4.13. The runvar difference is: +test-amd64-amd64-dom0pvh-xl-amd all_host_di_version 2020-02-10 +test-amd64-amd64-dom0pvh-xl-intel all_host_di_version 2020-02-10

[Xen-devel] [xen-unstable-coverity test] 148425: all pass - PUSHED

2020-03-11 Thread osstest service owner
flight 148425 xen-unstable-coverity real [real] http://logs.test-lab.xenproject.org/osstest/logs/148425/ Perfect :-) All tests in this flight passed as required version targeted for testing: xen e19d3a942e4b6f6c5b19287a4a6f5020bdab2936 baseline version: xen

Re: [Xen-devel] [PATCH v8 02/10] scripts: add coccinelle script to use auto propagated errp

2020-03-11 Thread Vladimir Sementsov-Ogievskiy
11.03.2020 12:53, Markus Armbruster wrote: I think a v9 makes sense now. If any of the improvement ideas should turn into time sinks for you, let's talk. We don't need perfection, we only need to get to the point where we trust the script to do what we believe it does, understand its

Re: [Xen-devel] [PATCH v8 02/10] scripts: add coccinelle script to use auto propagated errp

2020-03-11 Thread Markus Armbruster
I think a v9 makes sense now. If any of the improvement ideas should turn into time sinks for you, let's talk. We don't need perfection, we only need to get to the point where we trust the script to do what we believe it does, understand its limitations, and know how to compensate for them.

Re: [Xen-devel] [PATCH v8 02/10] scripts: add coccinelle script to use auto propagated errp

2020-03-11 Thread Vladimir Sementsov-Ogievskiy
11.03.2020 12:33, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: 09.03.2020 12:56, Markus Armbruster wrote: + +// Convert error clearing functions Suggest: Ensure @local_err is cleared on free But there is no local_err after conversion True. Hmm. What about this:

Re: [Xen-devel] [PATCH v4 3/6] xen: add process_pending_softirqs_norcu() for keyhandlers

2020-03-11 Thread Jürgen Groß
On 11.03.20 10:36, Jan Beulich wrote: On 11.03.2020 10:27, Jürgen Groß wrote: On 11.03.20 10:25, Jan Beulich wrote: On 11.03.2020 07:07, Jürgen Groß wrote: On 10.03.20 18:02, Jan Beulich wrote: On 10.03.2020 08:28, Juergen Gross wrote: --- a/xen/drivers/passthrough/amd/pci_amd_iommu.c +++

Re: [Xen-devel] [PATCH v8 02/10] scripts: add coccinelle script to use auto propagated errp

2020-03-11 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 09.03.2020 12:56, Markus Armbruster wrote: >> Suggest >> >> scripts: Coccinelle script to use auto-propagated errp >> >> or >> >> scripts: Coccinelle script to use ERRP_AUTO_PROPAGATE() >> >> Vladimir Sementsov-Ogievskiy writes: [...] >>> +//

Re: [Xen-devel] [PATCH v4 3/6] xen: add process_pending_softirqs_norcu() for keyhandlers

2020-03-11 Thread Jan Beulich
On 11.03.2020 10:27, Jürgen Groß wrote: > On 11.03.20 10:25, Jan Beulich wrote: >> On 11.03.2020 07:07, Jürgen Groß wrote: >>> On 10.03.20 18:02, Jan Beulich wrote: On 10.03.2020 08:28, Juergen Gross wrote: > --- a/xen/drivers/passthrough/amd/pci_amd_iommu.c > +++

Re: [Xen-devel] [PATCH v8 02/10] scripts: add coccinelle script to use auto propagated errp

2020-03-11 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 09.03.2020 12:56, Markus Armbruster wrote: >>> + >>> +// Convert error clearing functions >> Suggest: Ensure @local_err is cleared on free > > But there is no local_err after conversion True. Hmm. What about this: // Convert calls to error_free(),

[Xen-devel] [linux-4.4 test] 148347: regressions - FAIL

2020-03-11 Thread osstest service owner
flight 148347 linux-4.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/148347/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-nested-amd broken in 148277

Re: [Xen-devel] [PATCH v4] x86/cpu: Sync any remaining RCU callbacks before CPU up/down

2020-03-11 Thread Jan Beulich
On 10.03.2020 19:06, Igor Druzhinin wrote: > During CPU down operation RCU callbacks are scheduled to finish > off some actions later as soon as CPU is fully dead (the same applies > to CPU up operation in case error path is taken). If in the same grace > period another CPU up operation is

Re: [Xen-devel] [PATCH v4 3/6] xen: add process_pending_softirqs_norcu() for keyhandlers

2020-03-11 Thread Jürgen Groß
On 11.03.20 10:25, Jan Beulich wrote: On 11.03.2020 07:07, Jürgen Groß wrote: On 10.03.20 18:02, Jan Beulich wrote: On 10.03.2020 08:28, Juergen Gross wrote: --- a/xen/drivers/passthrough/amd/pci_amd_iommu.c +++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c @@ -587,7 +587,7 @@ static void

Re: [Xen-devel] [XEN PATCH v3 13/23] xen/build: include include/config/auto.conf in main Makefile

2020-03-11 Thread Jan Beulich
On 10.03.2020 18:10, Anthony PERARD wrote: > On Wed, Mar 04, 2020 at 03:29:55PM +0100, Jan Beulich wrote: >> On 26.02.2020 12:33, Anthony PERARD wrote: >>> +# The actual configuration files used during the build are stored in >>> +# include/generated/ and include/config/. Update them if .config is

Re: [Xen-devel] [PATCH v4 3/6] xen: add process_pending_softirqs_norcu() for keyhandlers

2020-03-11 Thread Jan Beulich
On 11.03.2020 07:07, Jürgen Groß wrote: > On 10.03.20 18:02, Jan Beulich wrote: >> On 10.03.2020 08:28, Juergen Gross wrote: >>> --- a/xen/drivers/passthrough/amd/pci_amd_iommu.c >>> +++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c >>> @@ -587,7 +587,7 @@ static void

Re: [Xen-devel] [PATCH v8 02/10] scripts: add coccinelle script to use auto propagated errp

2020-03-11 Thread Vladimir Sementsov-Ogievskiy
11.03.2020 12:04, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: 10.03.2020 18:47, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: 09.03.2020 12:56, Markus Armbruster wrote: Suggest scripts: Coccinelle script to use auto-propagated errp or

Re: [Xen-devel] [PATCH v5 6/6] domain: use PGC_extra domheap page for shared_info

2020-03-11 Thread Jan Beulich
On 10.03.2020 18:33, Paul Durrant wrote: >> -Original Message- >> From: Jan Beulich >> Sent: 09 March 2020 15:56 >> >> On 09.03.2020 11:23, p...@xen.org wrote: >>> --- a/xen/common/time.c >>> +++ b/xen/common/time.c >>> @@ -99,6 +99,18 @@ void update_domain_wallclock_time(struct domain

Re: [Xen-devel] [PATCH 04/51] drm: Set final_kfree in drm_dev_alloc

2020-03-11 Thread Thomas Zimmermann
Am 02.03.20 um 23:25 schrieb Daniel Vetter: > I also did a full review of all callers, and only the xen driver > forgot to call drm_dev_put in the failure path. Fix that up too. > > v2: I noticed that xen has a drm_driver.release hook, and uses > drm_dev_alloc(). We need to remove the kfree

Re: [Xen-devel] [PATCH v8 02/10] scripts: add coccinelle script to use auto propagated errp

2020-03-11 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 10.03.2020 18:47, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy writes: >> >>> 09.03.2020 12:56, Markus Armbruster wrote: Suggest scripts: Coccinelle script to use auto-propagated errp or scripts:

[Xen-devel] [qemu-mainline test] 148340: regressions - FAIL

2020-03-11 Thread osstest service owner
flight 148340 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/148340/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 10 debian-hvm-install fail REGR. vs.

Re: [Xen-devel] [PATCH v8 02/10] scripts: add coccinelle script to use auto propagated errp

2020-03-11 Thread Vladimir Sementsov-Ogievskiy
09.03.2020 12:56, Markus Armbruster wrote: + +// Convert error clearing functions Suggest: Ensure @local_err is cleared on free But there is no local_err after conversion +( +-error_free(local_err); ++error_free_errp(errp); +| +-error_report_err(local_err); ++

Re: [Xen-devel] [PATCH v8 02/10] scripts: add coccinelle script to use auto propagated errp

2020-03-11 Thread Vladimir Sementsov-Ogievskiy
11.03.2020 9:55, Vladimir Sementsov-Ogievskiy wrote: 10.03.2020 18:47, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: 09.03.2020 12:56, Markus Armbruster wrote: Suggest   scripts: Coccinelle script to use auto-propagated errp or   scripts: Coccinelle script to use

Re: [Xen-devel] [PATCH v8 02/10] scripts: add coccinelle script to use auto propagated errp

2020-03-11 Thread Vladimir Sementsov-Ogievskiy
09.03.2020 12:56, Markus Armbruster wrote: Suggest scripts: Coccinelle script to use auto-propagated errp or scripts: Coccinelle script to use ERRP_AUTO_PROPAGATE() Vladimir Sementsov-Ogievskiy writes: Script adds ERRP_AUTO_PROPAGATE macro invocation where appropriate and does

[Xen-devel] [xen-unstable test] 148315: regressions - trouble: broken/fail/pass

2020-03-11 Thread osstest service owner
flight 148315 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/148315/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm broken

Re: [Xen-devel] [PATCH v8 02/10] scripts: add coccinelle script to use auto propagated errp

2020-03-11 Thread Vladimir Sementsov-Ogievskiy
10.03.2020 18:47, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: 09.03.2020 12:56, Markus Armbruster wrote: Suggest scripts: Coccinelle script to use auto-propagated errp or scripts: Coccinelle script to use ERRP_AUTO_PROPAGATE() Vladimir Sementsov-Ogievskiy

Re: [Xen-devel] [PATCH -next 020/491] XEN HYPERVISOR INTERFACE: Use fallthrough;

2020-03-11 Thread Jürgen Groß
On 11.03.20 05:51, Joe Perches wrote: Convert the various uses of fallthrough comments to fallthrough; Done via script Link: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe.com/ Signed-off-by: Joe Perches Reviewed-by: Juergen Gross Juergen

Re: [Xen-devel] [PATCH v4 3/6] xen: add process_pending_softirqs_norcu() for keyhandlers

2020-03-11 Thread Jürgen Groß
On 10.03.20 18:02, Jan Beulich wrote: On 10.03.2020 08:28, Juergen Gross wrote: --- a/xen/common/softirq.c +++ b/xen/common/softirq.c @@ -25,7 +25,7 @@ static softirq_handler softirq_handlers[NR_SOFTIRQS]; static DEFINE_PER_CPU(cpumask_t, batch_mask); static DEFINE_PER_CPU(unsigned int,

Re: [Xen-devel] [PATCH v4 2/6] xen/rcu: don't use stop_machine_run() for rcu_barrier()

2020-03-11 Thread Jürgen Groß
On 10.03.20 17:37, Jan Beulich wrote: On 10.03.2020 17:34, Jürgen Groß wrote: On 10.03.20 17:29, Jan Beulich wrote: On 10.03.2020 08:28, Juergen Gross wrote: +void rcu_barrier(void) { -atomic_t cpu_count = ATOMIC_INIT(0); -return stop_machine_run(rcu_barrier_action, _count,