Re: [PATCH v2 10/11] xen/arm: introduce phys/dma translations in xen_dma_sync_for_*

2020-06-08 Thread Christoph Hellwig
On Mon, Jun 08, 2020 at 10:38:02PM -0700, Christoph Hellwig wrote: > On Mon, Jun 08, 2020 at 05:38:28PM -0700, Stefano Stabellini wrote: > > Yeah, the pfn_valid check is a bit weird by definition because we are > > using it to understand whether the address belong to us or to another > > VM. To do

Re: [PATCH v2 10/11] xen/arm: introduce phys/dma translations in xen_dma_sync_for_*

2020-06-08 Thread Christoph Hellwig
On Mon, Jun 08, 2020 at 05:38:28PM -0700, Stefano Stabellini wrote: > Yeah, the pfn_valid check is a bit weird by definition because we are > using it to understand whether the address belong to us or to another > VM. To do the pfn_valid check we need to translate the dma address into > something

Re: [PATCH v2 08/11] swiotlb-xen: introduce phys_to_dma/dma_to_phys translations

2020-06-08 Thread Christoph Hellwig
On Mon, Jun 08, 2020 at 04:06:57PM -0700, Stefano Stabellini wrote: > I understand what you are suggesting about having something like: > > xen_phys_to_dma(...) > { > phys_addr_t phys = xen_phys_to_bus(dev, paddr) > return phys_to_dma(phys); > } > > I thought about it

Re: [PATCH v4 for-4.14] x86/monitor: revert default behavior when monitoring register write events

2020-06-08 Thread Razvan Cojocaru
On 6/8/20 11:44 PM, Tamas K Lengyel wrote: > On Mon, Jun 8, 2020 at 2:14 PM Razvan Cojocaru > wrote: >> >> On 6/8/20 10:54 PM, Tamas K Lengyel wrote: >>> On Mon, Jun 8, 2020 at 12:58 PM Razvan Cojocaru And last but not least, the proper sequence is: 1. unsubscribe from register write

Re: [PATCH v4 for-4.14] x86/monitor: revert default behavior when monitoring register write events

2020-06-08 Thread Razvan Cojocaru
On 6/9/20 1:50 AM, Tamas K Lengyel wrote: > On Mon, Jun 8, 2020 at 3:16 PM Razvan Cojocaru > wrote: >> 1. A security application that is unable to _prevent_ things being done >> to a system is not doing a very good job, since in that case you can >> only collect stats and not veto anything. I

Re: [PATCH v4 for-4.14] x86/monitor: revert default behavior when monitoring register write events

2020-06-08 Thread Razvan Cojocaru
On 6/8/20 6:55 PM, Jan Beulich wrote: > On 03.06.2020 17:07, Roger Pau Monné wrote: >> On Wed, Jun 03, 2020 at 06:52:37AM -0600, Tamas K Lengyel wrote: >>> For the last couple years we have received numerous reports from users of >>> monitor vm_events of spurious guest crashes when using events.

Re: [PATCH v4 for-4.14] x86/monitor: revert default behavior when monitoring register write events

2020-06-08 Thread Razvan Cojocaru
On 6/8/20 10:54 PM, Tamas K Lengyel wrote: > On Mon, Jun 8, 2020 at 12:58 PM Razvan Cojocaru >> And last but not least, the proper sequence is: 1. unsubscribe from >> register write events, 2. process all events "still in the chamber" >> (keep checking the ring buffer for a while), 3. detach from

Re: [PATCH v2 08/11] swiotlb-xen: introduce phys_to_dma/dma_to_phys translations

2020-06-08 Thread Stefano Stabellini
On Mon, 8 Jun 2020, Stefano Stabellini wrote: > On Mon, 8 Jun 2020, Christoph Hellwig wrote: > > On Wed, Jun 03, 2020 at 03:22:44PM -0700, Stefano Stabellini wrote: > > > From: Stefano Stabellini > > > > > > With some devices physical addresses are different than dma addresses. > > > To be able

Re: [PATCH v2 10/11] xen/arm: introduce phys/dma translations in xen_dma_sync_for_*

2020-06-08 Thread Stefano Stabellini
On Mon, 8 Jun 2020, Christoph Hellwig wrote: > On Wed, Jun 03, 2020 at 03:22:46PM -0700, Stefano Stabellini wrote: > > From: Stefano Stabellini > > > > xen_dma_sync_for_cpu, xen_dma_sync_for_device, xen_arch_need_swiotlb are > > getting called passing dma addresses. On some platforms dma

[linux-linus test] 150925: FAIL

2020-06-08 Thread osstest service owner
flight 150925 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/150925/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl broken in 150920

Re: [PATCH v4 for-4.14] x86/monitor: revert default behavior when monitoring register write events

2020-06-08 Thread Tamas K Lengyel
On Mon, Jun 8, 2020 at 5:14 PM Razvan Cojocaru wrote: > > On 6/9/20 1:50 AM, Tamas K Lengyel wrote: > > On Mon, Jun 8, 2020 at 3:16 PM Razvan Cojocaru > > wrote: > >> 1. A security application that is unable to _prevent_ things being done > >> to a system is not doing a very good job, since in

[PATCH AUTOSEL 5.6 042/606] x86: Fix early boot crash on gcc-10, third try

2020-06-08 Thread Sasha Levin
From: Borislav Petkov commit a9a3ed1eff3601b63aea4fb462d8b3b92c7c1e7e upstream. ... or the odyssey of trying to disable the stack protector for the function which generates the stack canary value. The whole story started with Sergei reporting a boot crash with a kernel built with gcc-10:

Re: [PATCH v2 08/11] swiotlb-xen: introduce phys_to_dma/dma_to_phys translations

2020-06-08 Thread Stefano Stabellini
On Mon, 8 Jun 2020, Christoph Hellwig wrote: > On Wed, Jun 03, 2020 at 03:22:44PM -0700, Stefano Stabellini wrote: > > From: Stefano Stabellini > > > > With some devices physical addresses are different than dma addresses. > > To be able to deal with these cases, we need to call phys_to_dma on >

Re: [PATCH v2 03/11] swiotlb-xen: add struct device* parameter to xen_phys_to_bus

2020-06-08 Thread Stefano Stabellini
On Mon, 8 Jun 2020, Christoph Hellwig wrote: > On Wed, Jun 03, 2020 at 03:22:39PM -0700, Stefano Stabellini wrote: > > From: Stefano Stabellini > > > > The parameter is unused in this patch. > > No functional changes. > > This looks weird. I'm pretty sure you are going to use it later, but >

Re: [PATCH v2 01/11] swiotlb-xen: use vmalloc_to_page on vmalloc virt addresses

2020-06-08 Thread Stefano Stabellini
Hi Christoph, Thanks you for the review. On Mon, 8 Jun 2020, Christoph Hellwig wrote: > Well, this isn't just RPi4, but basically any ARM or ARM64 system > with non-coherent DMA (which is most of them). Well... yes :-) > > + struct page *pg; > > Please spell out page. OK > > > >

Re: [PATCH v4 for-4.14] x86/monitor: revert default behavior when monitoring register write events

2020-06-08 Thread Tamas K Lengyel
On Mon, Jun 8, 2020 at 3:16 PM Razvan Cojocaru wrote: > > On 6/8/20 11:44 PM, Tamas K Lengyel wrote: > > On Mon, Jun 8, 2020 at 2:14 PM Razvan Cojocaru > > wrote: > >> > >> On 6/8/20 10:54 PM, Tamas K Lengyel wrote: > >>> On Mon, Jun 8, 2020 at 12:58 PM Razvan Cojocaru > And last but not

[xen-unstable-smoke test] 150929: tolerable all pass - PUSHED

2020-06-08 Thread osstest service owner
flight 150929 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/150929/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

[qemu-mainline test] 150923: regressions - trouble: blocked/broken/fail/pass

2020-06-08 Thread osstest service owner
flight 150923 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/150923/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-ovmf-amd64 broken test-amd64-amd64-xl-multivcpu

Re: [PATCH 03/12] x86/xen: Introduce new function to map HYPERVISOR_shared_info on Resume

2020-06-08 Thread Anchal Agarwal
On Fri, Jun 05, 2020 at 05:39:54PM -0400, Boris Ostrovsky wrote: > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unless you can confirm the sender and know the > content is safe. > > > > On 6/4/20 7:03 PM, Anchal Agarwal wrote: > >

Re: [PATCH v4 for-4.14] x86/monitor: revert default behavior when monitoring register write events

2020-06-08 Thread Tamas K Lengyel
On Mon, Jun 8, 2020 at 2:14 PM Razvan Cojocaru wrote: > > On 6/8/20 10:54 PM, Tamas K Lengyel wrote: > > On Mon, Jun 8, 2020 at 12:58 PM Razvan Cojocaru > >> And last but not least, the proper sequence is: 1. unsubscribe from > >> register write events, 2. process all events "still in the

[PATCH v1] kdd: remove zero-length arrays

2020-06-08 Thread Olaf Hering
Struct 'kdd_hdr' already has a member named 'payload[]' to easily refer to the data after the header. Remove the payload member from 'kdd_pkt' and always use 'kdd_hdr' to fix the following compile error: kdd.c: In function 'kdd_tx': kdd.c:746:30: error: array subscript 65534 is outside the

Re: Xen 4.14 RC1

2020-06-08 Thread Tamas K Lengyel
On Mon, Jun 8, 2020 at 10:41 AM Paul Durrant wrote: > > Hi all, > > Xen 4.14 RC1 is tagged. You can check that out from xen.git: > > git://xenbits.xen.org/xen.git 4.14.0-rc1 > > For your convenience there is also a tarball at: >

[PATCH for-4.14] x86/livepatch: Make livepatching compatible with CET Shadow Stacks

2020-06-08 Thread Andrew Cooper
Just like the alternatives infrastructure, the livepatch infrastructure disables CR0.WP to perform patching, which is not permitted with CET active. Modify arch_livepatch_{quiesce,revive}() to disable CET before disabling WP, and reset the dirty bits on all virtual regions before re-enabling CET.

Re: [PATCH v4 for-4.14] x86/monitor: revert default behavior when monitoring register write events

2020-06-08 Thread Tamas K Lengyel
On Mon, Jun 8, 2020 at 12:58 PM Razvan Cojocaru wrote: > > On 6/8/20 6:55 PM, Jan Beulich wrote: > > On 03.06.2020 17:07, Roger Pau Monné wrote: > >> On Wed, Jun 03, 2020 at 06:52:37AM -0600, Tamas K Lengyel wrote: > >>> For the last couple years we have received numerous reports from users of >

Re: [RFC PATCH 22/35] hw/m68k/mcf520x: Emit warning when old code is used

2020-06-08 Thread Thomas Huth
Am Mon, 8 Jun 2020 18:00:31 +0200 schrieb Philippe Mathieu-Daudé : > This code hasn't been QOM'ified yet. Warn the user. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/m68k/mcf5206.c | 5 + > hw/m68k/mcf5208.c | 3 +++ > 2 files changed, 8 insertions(+) > > diff --git

[xen-unstable-smoke test] 150926: tolerable all pass - PUSHED

2020-06-08 Thread osstest service owner
flight 150926 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/150926/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: [PATCH 03/12] x86/xen: Introduce new function to map HYPERVISOR_shared_info on Resume

2020-06-08 Thread Boris Ostrovsky
On 6/8/20 12:52 PM, Anchal Agarwal wrote: > > +void xen_hvm_map_shared_info(void) > +{ > + xen_hvm_init_shared_info(); > + if (shared_info_pfn) > + HYPERVISOR_shared_info = __va(PFN_PHYS(shared_info_pfn)); > +} > + AFAICT it is only called once

[PATCH v2] libxl__prepare_sockaddr_un

2020-06-08 Thread Olaf Hering
libxl: remove usage of strncpy from libxl__prepare_sockaddr_un The runtime check for the length of path already prevents malfunction. But gcc does not detect this runtime check and reports incorrect usage of strncpy. Remove the usage of strncpy and work directly with the calculated path length.

Re: [RFC PATCH 15/35] hw/i386/xen/xen-hvm: Emit warning when old code is used

2020-06-08 Thread Philippe Mathieu-Daudé
On 6/8/20 6:54 PM, Paul Durrant wrote: >> -Original Message- >> From: Philippe Mathieu-Daudé >> >> This code hasn't been QOM'ified yet. Warn the user. > > "Based on today's IRC chat, this is a trivial RFC series > to anotate pre-qdev/QOM devices so developers using them > without knowing

Re: [PATCH for-4.14] xen/arm: mm: Access a PT entry before the table is unmapped

2020-06-08 Thread Stefano Stabellini
On Sun, 7 Jun 2020, Julien Grall wrote: > From: Julien Grall > > xen_pt_next_level() will retrieve the MFN from the entry right after the > page-table has been unmapped. > > After calling xen_unmap_table(), there is no guarantee the mapping will > still be valid. Depending on the

[PATCH for-4.14] docs: Minor build improvements

2020-06-08 Thread Andrew Cooper
Don't use "set -x" for the figs rule. It doesn't take effect in the recursive make environment. Turn the HTML manpage comments into makefile comments, not shell comments. This saves 3x shell invocations per manpage. Signed-off-by: Andrew Cooper --- CC: George Dunlap CC: Ian Jackson CC: Jan

RE: [RFC PATCH 15/35] hw/i386/xen/xen-hvm: Emit warning when old code is used

2020-06-08 Thread Paul Durrant
> -Original Message- > From: Philippe Mathieu-Daudé > Sent: 08 June 2020 17:00 > To: qemu-de...@nongnu.org > Cc: qemu-...@nongnu.org; Markus Armbruster ; Max Filippov > ; > Marcel Apfelbaum ; Peter Maydell > ; Michael Walle > ; Edgar E. Iglesias ; Aurelien > Jarno > ; Gerd Hoffmann ;

Xen 4.14 RC1

2020-06-08 Thread Paul Durrant
Hi all, Xen 4.14 RC1 is tagged. You can check that out from xen.git: git://xenbits.xen.org/xen.git 4.14.0-rc1 For your convenience there is also a tarball at: https://downloads.xenproject.org/release/xen/4.14.0-rc1/xen-4.14.0-rc1.tar.gz And the signature is at:

RE: [PATCH for-4.14 v4] x86/rtc: provide mediated access to RTC for PVH dom0

2020-06-08 Thread Paul Durrant
> -Original Message- > From: Xen-devel On Behalf Of Roger > Pau Monne > Sent: 08 June 2020 17:14 > To: xen-devel@lists.xenproject.org > Cc: Andrew Cooper ; Roger Pau Monne > ; Wei Liu > ; Jan Beulich ; p...@xen.org > Subject: [PATCH for-4.14 v4] x86/rtc: provide mediated access to RTC

[xen-unstable test] 150918: trouble: broken/fail/pass

2020-06-08 Thread osstest service owner
flight 150918 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/150918/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-rtds broken Tests which are

Re: [RFC PATCH 00/35] hw/qdev: Warn when using pre-qdev/QOM devices

2020-06-08 Thread Philippe Mathieu-Daudé
On 6/8/20 6:14 PM, Peter Maydell wrote: > On Mon, 8 Jun 2020 at 17:00, Philippe Mathieu-Daudé wrote: >> >> Based on today's IRC chat, this is a trivial RFC series >> to anotate pre-qdev/QOM devices so developers using them >> without knowing they are not QOM'ified yet can realize >> it and

Re: Keystone Issue

2020-06-08 Thread Stefano Stabellini
On Mon, 8 Jun 2020, CodeWiz2280 wrote: > It actually shows only 1 interrupt for any of the devices in that list > (e.g. spi, ttyS0, ethernet) so you're probably right on the money with > it being an interrupt acknowledge issue. Any help you can provide is > greatly appreciated. > > On Mon,

[PATCH for-4.14 v4] x86/rtc: provide mediated access to RTC for PVH dom0

2020-06-08 Thread Roger Pau Monne
Mediated access to the RTC was provided for PVHv1 dom0 using the PV code paths (guest_io_{write/read}), but those accesses where never implemented for PVHv2 dom0. This patch provides such mediated accesses to the RTC for PVH dom0, just like it's provided for a classic PV dom0. Pull out some of

Re: [RFC PATCH 00/35] hw/qdev: Warn when using pre-qdev/QOM devices

2020-06-08 Thread Peter Maydell
On Mon, 8 Jun 2020 at 17:00, Philippe Mathieu-Daudé wrote: > > Based on today's IRC chat, this is a trivial RFC series > to anotate pre-qdev/QOM devices so developers using them > without knowing they are not QOM'ified yet can realize > it and convert them if they have time. What mechanism did

[RFC PATCH 35/35] hw/xtensa/xtfpga: Emit warning when old code is used

2020-06-08 Thread Philippe Mathieu-Daudé
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/xtensa/xtfpga.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/xtensa/xtfpga.c b/hw/xtensa/xtfpga.c index 60ccc74f5f..a3c82dc81a 100644 --- a/hw/xtensa/xtfpga.c +++ b/hw/xtensa/xtfpga.c

[RFC PATCH 34/35] hw/usb/hcd-musb: Emit warning when old code is used

2020-06-08 Thread Philippe Mathieu-Daudé
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/usb/hcd-musb.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/usb/hcd-musb.c b/hw/usb/hcd-musb.c index c29fbef6fc..9b3cf1ca8f 100644 --- a/hw/usb/hcd-musb.c +++ b/hw/usb/hcd-musb.c @@

[RFC PATCH 33/35] hw/timer/slavio_timer: Emit warning when old code is used

2020-06-08 Thread Philippe Mathieu-Daudé
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/timer/slavio_timer.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/timer/slavio_timer.c b/hw/timer/slavio_timer.c index 4c5d65e391..16f21669bf 100644 --- a/hw/timer/slavio_timer.c +++

[RFC PATCH 32/35] hw/riscv: Emit warning when old code is used

2020-06-08 Thread Philippe Mathieu-Daudé
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/riscv/riscv_htif.c | 4 hw/riscv/sifive_uart.c | 4 2 files changed, 8 insertions(+) diff --git a/hw/riscv/riscv_htif.c b/hw/riscv/riscv_htif.c index ca87a5cf9f..bd080dbefb 100644 ---

[RFC PATCH 30/35] hw/ppc/virtex_ml507: Emit warning when old code is used

2020-06-08 Thread Philippe Mathieu-Daudé
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/ppc/virtex_ml507.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/ppc/virtex_ml507.c b/hw/ppc/virtex_ml507.c index 0dacfcd236..17b8036c38 100644 ---

[RFC PATCH 24/35] hw/misc/cbus: Emit warning when old code is used

2020-06-08 Thread Philippe Mathieu-Daudé
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/misc/cbus.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/misc/cbus.c b/hw/misc/cbus.c index 3c3721ad2d..24e197684f 100644 --- a/hw/misc/cbus.c +++ b/hw/misc/cbus.c @@ -25,6 +25,7 @@

[RFC PATCH 31/35] hw/sh4: Emit warning when old code is used

2020-06-08 Thread Philippe Mathieu-Daudé
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/char/sh_serial.c | 3 +++ hw/intc/sh_intc.c | 3 +++ hw/sh4/r2d.c| 3 +++ hw/sh4/sh7750.c | 4 hw/timer/sh_timer.c | 5 + 5 files changed, 18 insertions(+) diff --git

[RFC PATCH 23/35] hw/misc/applesmc: Emit warning when old code is used

2020-06-08 Thread Philippe Mathieu-Daudé
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/misc/applesmc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/misc/applesmc.c b/hw/misc/applesmc.c index 1c4addb201..d63f19038d 100644 --- a/hw/misc/applesmc.c +++ b/hw/misc/applesmc.c

[RFC PATCH 20/35] hw/intc/i8259: Emit warning when old code is used

2020-06-08 Thread Philippe Mathieu-Daudé
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/intc/i8259.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/intc/i8259.c b/hw/intc/i8259.c index 51b27f6a34..9d9609cdab 100644 --- a/hw/intc/i8259.c +++ b/hw/intc/i8259.c @@ -30,6 +30,7

Re: [PATCH for-4.14 v3] x86/rtc: provide mediated access to RTC for PVH dom0

2020-06-08 Thread Jan Beulich
On 08.06.2020 17:56, Roger Pau Monné wrote: > On Mon, Jun 08, 2020 at 01:47:26PM +0200, Jan Beulich wrote: >> On 08.06.2020 12:29, Roger Pau Monne wrote: >>> Mediated access to the RTC was provided for PVHv1 dom0 using the PV >>> code paths (guest_io_{write/read}), but those accesses where never

[RFC PATCH 28/35] hw/ppc/ppc4xx: Emit warning when old code is used

2020-06-08 Thread Philippe Mathieu-Daudé
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/ppc/ppc405_boards.c | 5 + hw/ppc/ppc405_uc.c | 21 + hw/ppc/ppc4xx_devs.c | 7 +++ 3 files changed, 33 insertions(+) diff --git a/hw/ppc/ppc405_boards.c

[RFC PATCH 26/35] hw/openrisc/cputimer: Emit warning when old code is used

2020-06-08 Thread Philippe Mathieu-Daudé
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/openrisc/cputimer.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/openrisc/cputimer.c b/hw/openrisc/cputimer.c index 93268815d8..60f2c9667f 100644 --- a/hw/openrisc/cputimer.c +++

[RFC PATCH 29/35] hw/ppc/ppc_booke: Emit warning when old code is used

2020-06-08 Thread Philippe Mathieu-Daudé
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/ppc/ppc_booke.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/ppc/ppc_booke.c b/hw/ppc/ppc_booke.c index 652a21b806..a9e5e68578 100644 --- a/hw/ppc/ppc_booke.c +++

[RFC PATCH 27/35] hw/ppc/ppc: Emit warning when old code is used

2020-06-08 Thread Philippe Mathieu-Daudé
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/ppc/ppc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/ppc/ppc.c b/hw/ppc/ppc.c index 4a11fb1640..39fcf746c5 100644 --- a/hw/ppc/ppc.c +++ b/hw/ppc/ppc.c @@ -37,6 +37,7 @@ #include

[RFC PATCH 25/35] hw/nvram/eeprom93xx: Emit warning when old code is used

2020-06-08 Thread Philippe Mathieu-Daudé
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/nvram/eeprom93xx.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/nvram/eeprom93xx.c b/hw/nvram/eeprom93xx.c index ca6f591c84..56603ea42b 100644 --- a/hw/nvram/eeprom93xx.c +++

[RFC PATCH 21/35] hw/lm32/lm32_hwsetup: Emit warning when old code is used

2020-06-08 Thread Philippe Mathieu-Daudé
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/lm32/lm32_hwsetup.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/lm32/lm32_hwsetup.h b/hw/lm32/lm32_hwsetup.h index de94de177a..f4a4d8fe4b 100644 --- a/hw/lm32/lm32_hwsetup.h +++

[RFC PATCH 22/35] hw/m68k/mcf520x: Emit warning when old code is used

2020-06-08 Thread Philippe Mathieu-Daudé
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/m68k/mcf5206.c | 5 + hw/m68k/mcf5208.c | 3 +++ 2 files changed, 8 insertions(+) diff --git a/hw/m68k/mcf5206.c b/hw/m68k/mcf5206.c index a2fef04f8e..ec0d176674 100644 --- a/hw/m68k/mcf5206.c

[RFC PATCH 19/35] hw/input/tsc2005: Emit warning when old code is used

2020-06-08 Thread Philippe Mathieu-Daudé
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/input/tsc2005.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/input/tsc2005.c b/hw/input/tsc2005.c index 55d61cc843..1f97b82379 100644 --- a/hw/input/tsc2005.c +++ b/hw/input/tsc2005.c

[RFC PATCH 18/35] hw/input/ps2: Emit warning when old code is used

2020-06-08 Thread Philippe Mathieu-Daudé
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/input/ps2.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/input/ps2.c b/hw/input/ps2.c index f8746d2f52..0d84061cae 100644 --- a/hw/input/ps2.c +++ b/hw/input/ps2.c @@

[RFC PATCH 08/35] hw/display/blizzard: Emit warning when old code is used

2020-06-08 Thread Philippe Mathieu-Daudé
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/display/blizzard.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/display/blizzard.c b/hw/display/blizzard.c index 105241577d..74557b152b 100644 --- a/hw/display/blizzard.c +++

[RFC PATCH 15/35] hw/i386/xen/xen-hvm: Emit warning when old code is used

2020-06-08 Thread Philippe Mathieu-Daudé
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/xen/xen-hvm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/i386/xen/xen-hvm.c b/hw/i386/xen/xen-hvm.c index 82ece6b9e7..a1163b1529 100644 ---

[RFC PATCH 13/35] hw/dma/soc_dma: Emit warning when old code is used

2020-06-08 Thread Philippe Mathieu-Daudé
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/dma/soc_dma.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/dma/soc_dma.c b/hw/dma/soc_dma.c index 3a430057f5..22fd8c38b0 100644 --- a/hw/dma/soc_dma.c +++ b/hw/dma/soc_dma.c @@ -21,6

[RFC PATCH 09/35] hw/display/ramfb: Emit warning when old code is used

2020-06-08 Thread Philippe Mathieu-Daudé
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/display/ramfb.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/display/ramfb.c b/hw/display/ramfb.c index 79b9754a58..a4a427e5c7 100644 --- a/hw/display/ramfb.c +++ b/hw/display/ramfb.c

[RFC PATCH 12/35] hw/dma/etraxfs_dma: Emit warning when old code is used

2020-06-08 Thread Philippe Mathieu-Daudé
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/dma/etraxfs_dma.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/dma/etraxfs_dma.c b/hw/dma/etraxfs_dma.c index c4334e87bf..d2f7e7ca9d 100644 --- a/hw/dma/etraxfs_dma.c

[RFC PATCH 11/35] hw/display/vga-isa-mm: Emit warning when old code is used

2020-06-08 Thread Philippe Mathieu-Daudé
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/display/vga-isa-mm.c | 5 + hw/display/vga.c| 3 +++ 2 files changed, 8 insertions(+) diff --git a/hw/display/vga-isa-mm.c b/hw/display/vga-isa-mm.c index 7321b7a06d..3e62389b63 100644

[RFC PATCH 14/35] hw/i386/pc: Emit warning when old code is used

2020-06-08 Thread Philippe Mathieu-Daudé
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/pc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 2128f3d6fe..c71809fd28 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -94,6 +94,7 @@ #include

[RFC PATCH 10/35] hw/display/tc6393xb: Emit warning when old code is used

2020-06-08 Thread Philippe Mathieu-Daudé
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/display/tc6393xb.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/display/tc6393xb.c b/hw/display/tc6393xb.c index 49a676d1b0..e4900e9502 100644 --- a/hw/display/tc6393xb.c +++

[RFC PATCH 05/35] hw/arm/nseries: Emit warning when old code is used

2020-06-08 Thread Philippe Mathieu-Daudé
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/nseries.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/arm/nseries.c b/hw/arm/nseries.c index eae800b5c1..bd0c3f39a9 100644 --- a/hw/arm/nseries.c +++ b/hw/arm/nseries.c @@ -44,6

[RFC PATCH 17/35] hw/input/pckbd: Emit warning when old code is used

2020-06-08 Thread Philippe Mathieu-Daudé
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/input/pckbd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/input/pckbd.c b/hw/input/pckbd.c index 60a4130320..c7f42be63b 100644 --- a/hw/input/pckbd.c +++

[RFC PATCH 16/35] hw/input/lasips2: Emit warning when old code is used

2020-06-08 Thread Philippe Mathieu-Daudé
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/input/lasips2.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/input/lasips2.c b/hw/input/lasips2.c index 0786e57338..452244f037 100644 --- a/hw/input/lasips2.c +++

[RFC PATCH 07/35] hw/char/parallel: Emit warning when old code is used

2020-06-08 Thread Philippe Mathieu-Daudé
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/char/parallel.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/char/parallel.c b/hw/char/parallel.c index 8dd67d1375..0ee577d420 100644 --- a/hw/char/parallel.c +++ b/hw/char/parallel.c

[RFC PATCH 06/35] hw/timer/arm_timer: Emit warning when old code is used

2020-06-08 Thread Philippe Mathieu-Daudé
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/timer/arm_timer.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/timer/arm_timer.c b/hw/timer/arm_timer.c index 9607366d78..e23e6b4b31 100644 --- a/hw/timer/arm_timer.c +++

[RFC PATCH 03/35] hw/arm/omap: Emit warning when old code is used

2020-06-08 Thread Philippe Mathieu-Daudé
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/omap1.c| 6 ++ hw/char/omap_uart.c | 5 + hw/misc/omap_gpmc.c | 3 +++ hw/misc/omap_l4.c | 3 +++ hw/misc/omap_sdrc.c | 3 +++ hw/sd/omap_mmc.c

[RFC PATCH 02/35] hw/core/qdev: Add qdev_warn_deprecated_function_used() helper

2020-06-08 Thread Philippe Mathieu-Daudé
When built with --enable-qdev-deprecation-warning, calling qdev_warn_deprecated_function_used() will emit a warning such: $ qemu-system-arm -M verdex ... qemu-system-arm: warning: use of deprecated non-qdev/non-qom code in pxa2xx_lcdc_init() qemu-system-arm: warning: use of deprecated

[RFC PATCH 01/35] qom/object: Update documentation

2020-06-08 Thread Philippe Mathieu-Daudé
The documentation was introduced in 2f28d2ff9dc, then 0d09e41a51 and a27bd6c77 moved the headers around. Update the comment. Signed-off-by: Philippe Mathieu-Daudé --- include/qom/object.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/qom/object.h

[RFC PATCH 04/35] hw/arm/pxa2xx: Emit warning when old code is used

2020-06-08 Thread Philippe Mathieu-Daudé
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/pxa2xx.c | 3 +++ hw/display/pxa2xx_lcd.c | 3 +++ hw/input/pxa2xx_keypad.c | 3 +++ 3 files changed, 9 insertions(+) diff --git a/hw/arm/pxa2xx.c b/hw/arm/pxa2xx.c index

[RFC PATCH 00/35] hw/qdev: Warn when using pre-qdev/QOM devices

2020-06-08 Thread Philippe Mathieu-Daudé
Based on today's IRC chat, this is a trivial RFC series to anotate pre-qdev/QOM devices so developers using them without knowing they are not QOM'ified yet can realize it and convert them if they have time. qdev/QOM devices are introspectable, so easier to test or even fuzz. Philippe

Re: [PATCH v4 for-4.14] x86/monitor: revert default behavior when monitoring register write events

2020-06-08 Thread Jan Beulich
On 03.06.2020 17:07, Roger Pau Monné wrote: > On Wed, Jun 03, 2020 at 06:52:37AM -0600, Tamas K Lengyel wrote: >> For the last couple years we have received numerous reports from users of >> monitor vm_events of spurious guest crashes when using events. In particular, >> it has observed that the

Re: [PATCH for-4.14 v3] x86/rtc: provide mediated access to RTC for PVH dom0

2020-06-08 Thread Roger Pau Monné
On Mon, Jun 08, 2020 at 01:47:26PM +0200, Jan Beulich wrote: > On 08.06.2020 12:29, Roger Pau Monne wrote: > > Mediated access to the RTC was provided for PVHv1 dom0 using the PV > > code paths (guest_io_{write/read}), but those accesses where never > > implemented for PVHv2 dom0. This patch

RE: [OSSTEST PATCH v2 00/49] Switch to Debian buster (= Debian stable)

2020-06-08 Thread Paul Durrant
> -Original Message- > From: Ian Jackson > Sent: 08 June 2020 16:34 > To: p...@xen.org > Cc: xen-devel@lists.xenproject.org; committ...@xenproject.org > Subject: RE: [OSSTEST PATCH v2 00/49] Switch to Debian buster (= Debian > stable) > > Ian Jackson writes ("RE: [OSSTEST PATCH v2

RE: [OSSTEST PATCH v2 00/49] Switch to Debian buster (= Debian stable)

2020-06-08 Thread Ian Jackson
Ian Jackson writes ("RE: [OSSTEST PATCH v2 00/49] Switch to Debian buster (= Debian stable)"): > Paul Durrant writes ("RE: [OSSTEST PATCH v2 00/49] Switch to Debian buster (= > Debian stable)"): > > I assume we can revert if things go badly wrong and being able to > > commission more machines

RE: 4.14.0-rc1 blocked on goland build failure - decision needed

2020-06-08 Thread Paul Durrant
> -Original Message- > From: Xen-devel On Behalf Of George > Dunlap > Sent: 08 June 2020 16:07 > To: Ian Jackson > Cc: Xen-devel ; Nick Rosbrook > ; Wei Liu > > Subject: Re: 4.14.0-rc1 blocked on goland build failure - decision needed > > > > > On Jun 8, 2020, at 3:48 PM, Ian

Re: 4.14.0-rc1 blocked on goland build failure - decision needed [and 1 more messages]

2020-06-08 Thread Ian Jackson
Ian Jackson writes ("4.14.0-rc1 blocked on goland build failure - decision needed"): > Hi, Paul. For those on xen-devel: context is that Paul asked me to > cut 4.14.0-rc1. The checklist asks me to perform a test build. > > My 32-bit tools test build failed. I think the problem is probably >

Re: 4.14.0-rc1 blocked on goland build failure - decision needed

2020-06-08 Thread George Dunlap
> On Jun 8, 2020, at 3:48 PM, Ian Jackson wrote: > > Ian Jackson writes ("4.14.0-rc1 blocked on goland build failure - decision > needed"): >> Hi, Paul. For those on xen-devel: context is that Paul asked me to >> cut 4.14.0-rc1. The checklist asks me to perform a test build. >> >> My

RE: [PATCH for-4.14] golang/xenlight: remove call to go fmt in gengotypes.py

2020-06-08 Thread Paul Durrant
> -Original Message- > From: George Dunlap > Sent: 08 June 2020 15:16 > To: Nick Rosbrook > Cc: Xen-devel ; Nick Rosbrook > ; Ian Jackson > ; Wei Liu ; Paul Durrant > Subject: Re: [PATCH for-4.14] golang/xenlight: remove call to go fmt in > gengotypes.py > > CC’ing release manager >

Re: 4.14.0-rc1 blocked on goland build failure - decision needed

2020-06-08 Thread Ian Jackson
Ian Jackson writes ("4.14.0-rc1 blocked on goland build failure - decision needed"): > Hi, Paul. For those on xen-devel: context is that Paul asked me to > cut 4.14.0-rc1. The checklist asks me to perform a test build. > > My 32-bit tools test build failed. I think the problem is probably >

4.14.0-rc1 blocked on goland build failure - decision needed

2020-06-08 Thread Ian Jackson
Hi, Paul. For those on xen-devel: context is that Paul asked me to cut 4.14.0-rc1. The checklist asks me to perform a test build. My 32-bit tools test build failed. I think the problem is probably specific to 32-bit userland on 64-bit Linux kernel. I will send a second followup mail not CC

Re: [PATCH for-4.14] golang/xenlight: remove call to go fmt in gengotypes.py

2020-06-08 Thread George Dunlap
CC’ing release manager > On Jun 8, 2020, at 12:39 PM, George Dunlap wrote: > >> >> On Jun 6, 2020, at 5:10 PM, Nick Rosbrook wrote: >> >> Since the golang bindings are now set to be re-generated whenever a >> change is made to tools/libxl/libxl_types.idl, the call to go fmt in >>

Re: [PATCH v2 for-4.14] docs/support-matrix: unbreak docs rendering

2020-06-08 Thread Andrew Cooper
On 08/06/2020 14:48, Ian Jackson wrote: > Andrew Cooper writes ("[PATCH v2 for-4.14] docs/support-matrix: unbreak docs > rendering"): >> The cronjob which renders https://xenbits.xen.org/docs/ has been broken for a >> while. commitish_version() pulls an old version of xen/Makefile out of >>

Re: [PATCH v1] tools: fix usage of strncpy

2020-06-08 Thread Olaf Hering
Am Mon, 8 Jun 2020 08:43:50 -0400 schrieb Jason Andryuk : > I added a length check in this patch: gcc will not recognize such runtime checks and will (most likely) complain about the strncpy usage anyway, just as it does now in libxl__prepare_sockaddr_un. While the usage in

Re: [PATCH v2 1/5] libxl: Generate golang bindings in libxl Makefile

2020-06-08 Thread Nick Rosbrook
> > Out of curiosity, would it be totally out of the question to require > > having gofmt installed (not for 4.14, but in the future)? I ask because > > I haven't seen it discussed one way or the other. > > I think I’d like to try to avoid it, unless / until we have a “core > component” written

Re: [PATCH for-4.14] golang/xenlight: remove call to go fmt in gengotypes.py

2020-06-08 Thread Nick Rosbrook
On Mon, Jun 08, 2020 at 11:39:43AM +, George Dunlap wrote: > > > On Jun 6, 2020, at 5:10 PM, Nick Rosbrook wrote: > > > > Since the golang bindings are now set to be re-generated whenever a > > change is made to tools/libxl/libxl_types.idl, the call to go fmt in > > gengotypes.py results in

Re: [PATCH v2 for-4.14] docs/support-matrix: unbreak docs rendering

2020-06-08 Thread Andrew Cooper
On 08/06/2020 14:41, Jan Beulich wrote: > On 08.06.2020 15:34, Andrew Cooper wrote: >> The cronjob which renders https://xenbits.xen.org/docs/ has been broken for a >> while. commitish_version() pulls an old version of xen/Makefile out of >> history, and uses the xenversion rule. >> >> Currently,

Re: [PATCH v2 for-4.14] docs/support-matrix: unbreak docs rendering

2020-06-08 Thread Ian Jackson
Andrew Cooper writes ("[PATCH v2 for-4.14] docs/support-matrix: unbreak docs rendering"): > The cronjob which renders https://xenbits.xen.org/docs/ has been broken for a > while. commitish_version() pulls an old version of xen/Makefile out of > history, and uses the xenversion rule. > >

Re: [PATCH v2 for-4.14] docs/support-matrix: unbreak docs rendering

2020-06-08 Thread Jan Beulich
On 08.06.2020 15:34, Andrew Cooper wrote: > The cronjob which renders https://xenbits.xen.org/docs/ has been broken for a > while. commitish_version() pulls an old version of xen/Makefile out of > history, and uses the xenversion rule. > > Currently, this fails with: > >

RE: [PATCH v2 for-4.14] docs/support-matrix: unbreak docs rendering

2020-06-08 Thread Paul Durrant
> -Original Message- > From: Andrew Cooper > Sent: 08 June 2020 14:35 > To: Xen-devel > Cc: Andrew Cooper ; George Dunlap > ; Ian > Jackson ; Jan Beulich ; Konrad > Rzeszutek Wilk > ; Stefano Stabellini ; Wei > Liu ; Julien > Grall ; Anthony PERARD ; Paul > Durrant > Subject: [PATCH

[PATCH v2 for-4.14] docs/support-matrix: unbreak docs rendering

2020-06-08 Thread Andrew Cooper
The cronjob which renders https://xenbits.xen.org/docs/ has been broken for a while. commitish_version() pulls an old version of xen/Makefile out of history, and uses the xenversion rule. Currently, this fails with: tmp.support-matrix.xen.make:130: scripts/Kbuild.include: No such file or

Re: [PATCH v3 4/4] microvm: move virtio base to 0xfeb00000

2020-06-08 Thread Michael S. Tsirkin
On Fri, May 29, 2020 at 09:39:57AM +0200, Gerd Hoffmann wrote: > Place virtio-mmio devices near the other mmio regions, > next ioapic is at @ 0xfec0. > > Signed-off-by: Gerd Hoffmann > --- > include/hw/i386/microvm.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH v3 0/4] microvm: memory config tweaks

2020-06-08 Thread Michael S. Tsirkin
On Fri, May 29, 2020 at 09:39:53AM +0200, Gerd Hoffmann wrote: > With more microvm memory config tweaks split this into its owns series, > the microvm acpi patch series is already big enough ... Looks sane: Acked-by: Michael S. Tsirkin microvm things so should use that tree ... > v2: > - use

Re: [PATCH v3 0/4] microvm: memory config tweaks

2020-06-08 Thread Gerd Hoffmann
On Fri, May 29, 2020 at 09:39:53AM +0200, Gerd Hoffmann wrote: > With more microvm memory config tweaks split this into its owns series, > the microvm acpi patch series is already big enough ... > > v2: > - use 3G split. > - add patch to move virtio-mmio region. > - pick up acks & reviews. >

RE: handle_pio looping during domain shutdown, with qemu 4.2.0 in stubdom

2020-06-08 Thread Paul Durrant
> -Original Message- > From: Jan Beulich > Sent: 08 June 2020 13:47 > To: p...@xen.org > Cc: 'Jürgen Groß' ; 'Marek Marczykowski-Górecki' > ; > 'Ian Jackson' ; 'Andrew Cooper' > ; 'xen-devel' > > Subject: Re: handle_pio looping during domain shutdown, with qemu 4.2.0 in > stubdom > >

  1   2   >