[linux-linus test] 164144: regressions - FAIL

2021-08-09 Thread osstest service owner
flight 164144 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/164144/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-xsm7 xen-install fail REGR. vs. 152332

Re: [PATCH] xen-blkfront: Remove redundant assignment to variable err

2021-08-09 Thread Jens Axboe
On 8/6/21 5:06 AM, Colin King wrote: > From: Colin Ian King > > The variable err is being assigned a value that is never read, the > assignment is redundant and can be removed. Added for 5.15, thanks. -- Jens Axboe

Re: [PATCH] xen-blkfront: Remove redundant assignment to variable err

2021-08-09 Thread Boris Ostrovsky
On 8/6/21 7:06 AM, Colin King wrote: > From: Colin Ian King > > The variable err is being assigned a value that is never read, the > assignment is redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King Reviewed-by: Boris Ostrovsky

Re: [PATCH V3 03/13] x86/HV: Add new hvcall guest address host visibility support

2021-08-09 Thread Dave Hansen
On 8/9/21 10:56 AM, Tianyu Lan wrote: > From: Tianyu Lan > > Add new hvcall guest address host visibility support to mark > memory visible to host. Call it inside set_memory_decrypted > /encrypted(). Add HYPERVISOR feature check in the > hv_is_isolation_supported() to optimize in

Re: [RFC PATCH] xen/memory: Introduce a hypercall to provide unallocated space

2021-08-09 Thread Oleksandr
On 09.08.21 23:45, Julien Grall wrote: Hi Julien On 09/08/2021 19:24, Oleksandr wrote: On 09.08.21 18:42, Julien Grall wrote: Hi Oleksandr, Hi Julien. Thank you for the input. On 07/08/2021 18:03, Oleksandr wrote: On 06.08.21 03:30, Stefano Stabellini wrote: Hi Stefano On

Re: [RFC PATCH] xen/memory: Introduce a hypercall to provide unallocated space

2021-08-09 Thread Julien Grall
On 09/08/2021 19:24, Oleksandr wrote: On 09.08.21 18:42, Julien Grall wrote: Hi Oleksandr, Hi Julien. Thank you for the input. On 07/08/2021 18:03, Oleksandr wrote: On 06.08.21 03:30, Stefano Stabellini wrote: Hi Stefano On Wed, 4 Aug 2021, Julien Grall wrote: +#define

Re: NULL scheduler DoS

2021-08-09 Thread Julien Grall
On 09/08/2021 18:35, Julien Grall wrote: On 09/08/2021 17:19, Ahmed, Daniele wrote: Hi all, Hi Daniele, Thank you for the report! The NULL scheduler is affected by an issue that triggers an assertion and reboots the hypervisor. This issue arise when:   * a guest is being created

[linux-linus test] 164143: regressions - FAIL

2021-08-09 Thread osstest service owner
flight 164143 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/164143/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-xsm7 xen-install fail REGR. vs. 152332

Re: [RFC PATCH] xen/memory: Introduce a hypercall to provide unallocated space

2021-08-09 Thread Oleksandr
On 09.08.21 18:42, Julien Grall wrote: Hi Oleksandr, Hi Julien. Thank you for the input. On 07/08/2021 18:03, Oleksandr wrote: On 06.08.21 03:30, Stefano Stabellini wrote: Hi Stefano On Wed, 4 Aug 2021, Julien Grall wrote: +#define GUEST_SAFE_RANGE_BASE

Re: [PATCH v2 0/6] PCI: Drop duplicated tracking of a pci_dev's bound driver

2021-08-09 Thread Bjorn Helgaas
On Sat, Aug 07, 2021 at 11:26:45AM +0200, Uwe Kleine-König wrote: > On Fri, Aug 06, 2021 at 04:24:52PM -0500, Bjorn Helgaas wrote: > > On Fri, Aug 06, 2021 at 08:46:23AM +0200, Uwe Kleine-König wrote: > > > On Thu, Aug 05, 2021 at 06:42:34PM -0500, Bjorn Helgaas wrote: > > > > > > I looked at all

[PATCH V3 11/13] HV/IOMMU: Enable swiotlb bounce buffer for Isolation VM

2021-08-09 Thread Tianyu Lan
From: Tianyu Lan Hyper-V Isolation VM requires bounce buffer support to copy data from/to encrypted memory and so enable swiotlb force mode to use swiotlb bounce buffer for DMA transaction. In Isolation VM with AMD SEV, the bounce buffer needs to be accessed via extra address space which is

[PATCH V3 12/13] HV/Netvsc: Add Isolation VM support for netvsc driver

2021-08-09 Thread Tianyu Lan
From: Tianyu Lan In Isolation VM, all shared memory with host needs to mark visible to host via hvcall. vmbus_establish_gpadl() has already done it for netvsc rx/tx ring buffer. The page buffer used by vmbus_sendpacket_ pagebuffer() still need to handle. Use DMA API to map/umap these memory

[PATCH V3 10/13] x86/Swiotlb: Add Swiotlb bounce buffer remap function for HV IVM

2021-08-09 Thread Tianyu Lan
From: Tianyu Lan In Isolation VM with AMD SEV, bounce buffer needs to be accessed via extra address space which is above shared_gpa_boundary (E.G 39 bit address line) reported by Hyper-V CPUID ISOLATION_CONFIG. The access physical address will be original physical address + shared_gpa_boundary.

[PATCH V3 13/13] HV/Storvsc: Add Isolation VM support for storvsc driver

2021-08-09 Thread Tianyu Lan
From: Tianyu Lan In Isolation VM, all shared memory with host needs to mark visible to host via hvcall. vmbus_establish_gpadl() has already done it for storvsc rx/tx ring buffer. The page buffer used by vmbus_sendpacket_ mpb_desc() still need to handle. Use DMA API to map/umap these memory

[PATCH V3 09/13] DMA: Add dma_map_decrypted/dma_unmap_encrypted() function

2021-08-09 Thread Tianyu Lan
From: Tianyu Lan In Hyper-V Isolation VM with AMD SEV, swiotlb boucne buffer needs to be mapped into address space above vTOM and so introduce dma_map_decrypted/dma_unmap_encrypted() to map/unmap bounce buffer memory. The platform can populate man/unmap callback in the dma memory decrypted ops.

[PATCH V3 08/13] HV/Vmbus: Initialize VMbus ring buffer for Isolation VM

2021-08-09 Thread Tianyu Lan
From: Tianyu Lan VMbus ring buffer are shared with host and it's need to be accessed via extra address space of Isolation VM with SNP support. This patch is to map the ring buffer address in extra address space via ioremap(). HV host visibility hvcall smears data in the ring buffer and so reset

[PATCH V3 07/13] HV/Vmbus: Add SNP support for VMbus channel initiate message

2021-08-09 Thread Tianyu Lan
From: Tianyu Lan The monitor pages in the CHANNELMSG_INITIATE_CONTACT msg are shared with host in Isolation VM and so it's necessary to use hvcall to set them visible to host. In Isolation VM with AMD SEV SNP, the access address should be in the extra space which is above shared gpa boundary. So

[PATCH V3 06/13] HV: Add ghcb hvcall support for SNP VM

2021-08-09 Thread Tianyu Lan
From: Tianyu Lan Hyper-V provides ghcb hvcall to handle VMBus HVCALL_SIGNAL_EVENT and HVCALL_POST_MESSAGE msg in SNP Isolation VM. Add such support. Signed-off-by: Tianyu Lan --- arch/x86/hyperv/ivm.c | 43 + arch/x86/include/asm/mshyperv.h | 1 +

[PATCH V3 05/13] HV: Add Write/Read MSR registers via ghcb page

2021-08-09 Thread Tianyu Lan
From: Tianyu Lan Hyper-V provides GHCB protocol to write Synthetic Interrupt Controller MSR registers in Isolation VM with AMD SEV SNP and these registers are emulated by hypervisor directly. Hyper-V requires to write SINTx MSR registers twice. First writes MSR via GHCB page to communicate with

[PATCH V3 04/13] HV: Mark vmbus ring buffer visible to host in Isolation VM

2021-08-09 Thread Tianyu Lan
From: Tianyu Lan Mark vmbus ring buffer visible with set_memory_decrypted() when establish gpadl handle. Signed-off-by: Tianyu Lan --- drivers/hv/channel.c | 44 -- include/linux/hyperv.h | 11 +++ 2 files changed, 53 insertions(+), 2

[PATCH V3 03/13] x86/HV: Add new hvcall guest address host visibility support

2021-08-09 Thread Tianyu Lan
From: Tianyu Lan Add new hvcall guest address host visibility support to mark memory visible to host. Call it inside set_memory_decrypted /encrypted(). Add HYPERVISOR feature check in the hv_is_isolation_supported() to optimize in non-virtualization environment. Signed-off-by: Tianyu Lan ---

[PATCH V3 02/13] x86/HV: Initialize shared memory boundary in the Isolation VM.

2021-08-09 Thread Tianyu Lan
From: Tianyu Lan Hyper-V exposes shared memory boundary via cpuid HYPERV_CPUID_ISOLATION_CONFIG and store it in the shared_gpa_boundary of ms_hyperv struct. This prepares to share memory with host for SNP guest. Signed-off-by: Tianyu Lan --- arch/x86/kernel/cpu/mshyperv.c | 2 ++

[PATCH V3 00/13] x86/Hyper-V: Add Hyper-V Isolation VM support

2021-08-09 Thread Tianyu Lan
From: Tianyu Lan Hyper-V provides two kinds of Isolation VMs. VBS(Virtualization-based security) and AMD SEV-SNP unenlightened Isolation VMs. This patchset is to add support for these Isolation VM support in Linux. The memory of these vms are encrypted and host can't access guest memory

[PATCH V3 01/13] x86/HV: Initialize GHCB page in Isolation VM

2021-08-09 Thread Tianyu Lan
From: Tianyu Lan Hyper-V exposes GHCB page via SEV ES GHCB MSR for SNP guest to communicate with hypervisor. Map GHCB page for all cpus to read/write MSR register and submit hvcall request via GHCB. Signed-off-by: Tianyu Lan --- arch/x86/hyperv/hv_init.c | 66

Re: [RFC PATCH] xen/memory: Introduce a hypercall to provide unallocated space

2021-08-09 Thread Oleksandr
On 09.08.21 20:18, Julien Grall wrote: Hi Julien On 09/08/2021 18:14, Oleksandr wrote: On 09.08.21 17:51, Julien Grall wrote: Hi Julien. Hi Oleksandr, I am writing down here what we discussed on another thread and on IRC. This will be easier to track in a single thread. On

Re: NULL scheduler DoS

2021-08-09 Thread Julien Grall
On 09/08/2021 17:19, Ahmed, Daniele wrote: Hi all, Hi Daniele, Thank you for the report! The NULL scheduler is affected by an issue that triggers an assertion and reboots the hypervisor. This issue arise when: * a guest is being created with a configuration specifying a file that

Re: [RFC PATCH] xen/memory: Introduce a hypercall to provide unallocated space

2021-08-09 Thread Julien Grall
On 09/08/2021 18:14, Oleksandr wrote: On 09.08.21 17:51, Julien Grall wrote: Hi Julien. Hi Oleksandr, I am writing down here what we discussed on another thread and on IRC. This will be easier to track in a single thread. On 04/08/2021 23:00, Julien Grall wrote: On 04/08/2021 21:56,

Re: [RFC PATCH] xen/memory: Introduce a hypercall to provide unallocated space

2021-08-09 Thread Oleksandr
On 09.08.21 17:51, Julien Grall wrote: Hi, Hi Julien. I am writing down here what we discussed on another thread and on IRC. This will be easier to track in a single thread. On 04/08/2021 23:00, Julien Grall wrote: On 04/08/2021 21:56, Oleksandr wrote: Now, I am wondering, would it

Re: [PATCH v2 5/6] PCI: Adapt all code locations to not use struct pci_dev::driver directly

2021-08-09 Thread Ido Schimmel
On Tue, Aug 03, 2021 at 12:01:49PM +0200, Uwe Kleine-König wrote: > This prepares removing the driver member of struct pci_dev which holds the > same information than struct pci_dev::dev->driver. > > Signed-off-by: Uwe Kleine-König > --- > arch/powerpc/include/asm/ppc-pci.h| 3 +- >

Re: NULL scheduler DoS

2021-08-09 Thread Ahmed, Daniele
CC’ing jul...@xen.org From: "Ahmed, Daniele" Date: Monday, 9 August 2021 at 17:19 To: "xen-devel@lists.xenproject.org" Cc: Dario Faggioli , Stefano Stabellini , "Grall, Julien" , "Doebel, Bjoern" , "Pohlack, Martin" Subject: NULL scheduler DoS Hi all, The NULL scheduler is affected by an

[PATCH] PCI: Fix general code style

2021-08-09 Thread Sergio Miguéns Iglesias
The code style for most files was fixed. This means that blank lines were added when needed (normally after variable declarations), spaces before tabs were removed, some code alignment issues were solved, block comment style was fixed, every instance of "unsigned var" was replaced with "unsigned

Re: [PATCH v2 5/6] PCI: Adapt all code locations to not use struct pci_dev::driver directly

2021-08-09 Thread Andrew Donnellan
On 3/8/21 8:01 pm, Uwe Kleine-König wrote: This prepares removing the driver member of struct pci_dev which holds the same information than struct pci_dev::dev->driver. Signed-off-by: Uwe Kleine-König cxl hunks look alright. Acked-by: Andrew Donnellan # cxl -- Andrew Donnellan

NULL scheduler DoS

2021-08-09 Thread Ahmed, Daniele
Hi all, The NULL scheduler is affected by an issue that triggers an assertion and reboots the hypervisor. This issue arise when: * a guest is being created with a configuration specifying a file that does not exist * the hypervisor boots with the null scheduler 4.16 is affected and

Re: [XEN PATCH v6 25/31] build: remove unneeded deps of x86_emulate.o

2021-08-09 Thread Anthony PERARD
On Fri, Aug 06, 2021 at 06:06:37PM +0200, Jan Beulich wrote: > On 01.07.2021 16:10, Anthony PERARD wrote: > > Those two dependencies already exist so make doesn't need to know > > about them. The dependency will be generated by $(CC). > > > > Signed-off-by: Anthony PERARD > > Unless I'm

Re: [XEN PATCH v6 21/31] build: set XEN_BUILD_EFI earlier

2021-08-09 Thread Anthony PERARD
On Thu, Aug 05, 2021 at 09:27:18AM +0200, Jan Beulich wrote: > On 01.07.2021 16:10, Anthony PERARD wrote: > > We are going to need the variable XEN_BUILD_EFI earlier. > > > > This early check is using "try-run" to allow to have a temporary > > output file in case it is needed for $(CC) to build

Re: [RFC PATCH] xen/memory: Introduce a hypercall to provide unallocated space

2021-08-09 Thread Julien Grall
Hi Oleksandr, On 07/08/2021 18:03, Oleksandr wrote: On 06.08.21 03:30, Stefano Stabellini wrote: Hi Stefano On Wed, 4 Aug 2021, Julien Grall wrote: +#define GUEST_SAFE_RANGE_BASE   xen_mk_ullong(0xDE) /* 128GB */ +#define GUEST_SAFE_RANGE_SIZE   xen_mk_ullong(0x02) While

Re: [PATCH v3 00/21] .map_sg() error cleanup

2021-08-09 Thread Christoph Hellwig
Thanks, I've applied this to the dma-mapping tree with a few minor cosmetic tweaks.

[PATCH 4/4] libs/gnttab: Use XEN_PAGE_* definitions

2021-08-09 Thread Costin Lupu
These changes refine the changes in d1b32abd which added a dependency to xenctrl library. We use the XEN_PAGE_* definitions instead of the XC_PAGE_* definitions and therefore we get rid of the unnecessary dependency. Signed-off-by: Costin Lupu --- tools/libs/gnttab/freebsd.c | 20

[PATCH 3/4] libs/foreignmemory: Use XEN_PAGE_* definitions

2021-08-09 Thread Costin Lupu
These changes refine the changes in 0dbb4be7 which added a dependency to xenctrl library. We use the XEN_PAGE_* definitions instead of the XC_PAGE_* definitions and therefore we get rid of the unnecessary dependency. Signed-off-by: Costin Lupu --- tools/libs/foreignmemory/core.c| 2 +-

Re: [RFC PATCH] xen/memory: Introduce a hypercall to provide unallocated space

2021-08-09 Thread Julien Grall
Hi, I am writing down here what we discussed on another thread and on IRC. This will be easier to track in a single thread. On 04/08/2021 23:00, Julien Grall wrote: On 04/08/2021 21:56, Oleksandr wrote: Now, I am wondering, would it be possible to update/clarify the current "reg" purpose

[PATCH 1/4] public: Add page related definitions for accessing guests memory

2021-08-09 Thread Costin Lupu
These changes introduce the page related definitions needed for mapping and accessing guests memory. These values are intended to be used by any toolstack component that needs to map guests memory. Until now, the values were defined by the xenctrl.h header, therefore whenever a component had to

[PATCH 2/4] libs/ctrl: Use Xen values for XC_PAGE_* definitions

2021-08-09 Thread Costin Lupu
We use the values provided by the Xen public interface for defining the XC_PAGE_* macros. Signed-off-by: Costin Lupu --- tools/include/xenctrl.h | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h index

[PATCH 0/4] Introduce XEN_PAGE_* definitions for mapping guests memory

2021-08-09 Thread Costin Lupu
This series tries to fix a side-effect introduced by commits 0dbb4be7 and d1b32abd which added a dependency to xenctrl for foreignmemory and gnntab libraries library only because they needed to use the XC_PAGE_* values. These changes introduce the XEN_PAGE_* definitions that will be used by any

[PATCH] xen/bitmap: Make bitmap_long_to_byte() and bitmap_byte_to_long() static

2021-08-09 Thread Jane Malalane
Functions made static as there are no external callers. Suggested-by: Andrew Cooper Signed-off-by: Jane Malalane --- CC: Andrew Cooper CC: George Dunlap CC: Ian Jackson CC: Jan Beulich CC: Julien Grall CC: Stefano Stabellini CC: Wei Liu --- xen/common/bitmap.c | 8

Re: [XEN PATCH v6 20/31] build: generate "include/xen/compile.h" with filechk

2021-08-09 Thread Anthony PERARD
On Thu, Aug 05, 2021 at 09:20:10AM +0200, Jan Beulich wrote: > On 01.07.2021 16:10, Anthony PERARD wrote: > > This will always try regenerate the content of compile.h, but if it > > didn't change the file isn't updated. > > > > Also, as it's currently the case, the file isn't regenerated during >

[ovmf test] 164142: all pass - PUSHED

2021-08-09 Thread osstest service owner
flight 164142 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164142/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf d02dbb53cd78de799e6afaa237e98771fb5148db baseline version: ovmf

Re: [XEN PATCH v6 19/31] build: rework .banner generation

2021-08-09 Thread Anthony PERARD
On Thu, Aug 05, 2021 at 09:09:13AM +0200, Jan Beulich wrote: > On 01.07.2021 16:09, Anthony PERARD wrote: > > Avoid depending on Makefile but still allow to rebuild the banner when > > $(XEN_FULLVERSION) changes. > > > > Also add a dependency on tools/xen.flf, even if not expected to > > change.

Re: [XEN PATCH v6 18/31] xen: move include/asm-* to include/arch-*/asm

2021-08-09 Thread Anthony PERARD
On Thu, Aug 05, 2021 at 09:04:18AM +0200, Jan Beulich wrote: > On 01.07.2021 16:09, Anthony PERARD wrote: > > This avoid the need to create the symbolic link "include/asm". > > > > Signed-off-by: Anthony PERARD > > --- > > > > Other possible locations that I could think of: > >

[linux-linus test] 164138: regressions - FAIL

2021-08-09 Thread osstest service owner
flight 164138 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/164138/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-xsm7 xen-install fail REGR. vs. 152332

[xen-unstable test] 164137: trouble: broken/fail/pass

2021-08-09 Thread osstest service owner
flight 164137 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/164137/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl-xsm broken Tests which are

[ovmf test] 164139: all pass - PUSHED

2021-08-09 Thread osstest service owner
flight 164139 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164139/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 4de77ae9890d241271f543e9195ab3516f3abec6 baseline version: ovmf

[libvirt test] 164140: regressions - FAIL

2021-08-09 Thread osstest service owner
flight 164140 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/164140/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-arm64-libvirt