Re: Reg. Tee init fail...

2022-06-29 Thread Juergen Gross
On 30.06.22 05:32, SK, SivaSangeetha (Siva Sangeetha) wrote: [AMD Official Use Only - General] +team -Original Message- From: Stefano Stabellini Sent: Thursday, June 30, 2022 1:34 AM To: Julien Grall Cc: SK, SivaSangeetha (Siva Sangeetha) ; xen-devel@lists.xenproject.org; Stefano

[linux-linus test] 171411: regressions - FAIL

2022-06-29 Thread osstest service owner
flight 171411 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171411/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-dom0pvh-xl-intel 8 xen-bootfail REGR. vs. 171277

RE: [PATCH v3] xen/arm: avoid overflow when setting vtimer in context switch

2022-06-29 Thread Jiamei Xie
Hi, > -Original Message- > From: Jiamei Xie > Sent: 2022年6月30日 9:54 > To: xen-devel@lists.xenproject.org > Cc: Jiamei Xie ; Stefano Stabellini > ; Julien Grall ; Bertrand Marquis > ; Volodymyr Babchuk > ; Wei Chen > Subject: [PATCH v3] xen/arm: avoid overflow when setting vtimer in

RE: Reg. Tee init fail...

2022-06-29 Thread SK, SivaSangeetha (Siva Sangeetha)
[AMD Official Use Only - General] +team -Original Message- From: Stefano Stabellini Sent: Thursday, June 30, 2022 1:34 AM To: Julien Grall Cc: SK, SivaSangeetha (Siva Sangeetha) ; xen-devel@lists.xenproject.org; Stefano Stabellini ; Bertrand Marquis ; Volodymyr Babchuk ;

RE: [PATCH RESEND v10 2/2] x86/xen: Allow per-domain usage of hardware virtualized APIC

2022-06-29 Thread Tian, Kevin
> From: Jane Malalane > Sent: Wednesday, June 29, 2022 9:56 PM > > Introduce a new per-domain creation x86 specific flag to > select whether hardware assisted virtualization should be used for > x{2}APIC. > > A per-domain option is added to xl in order to select the usage of > x{2}APIC hardware

[PATCH v9 3/3] xsm: refactor flask sid alloc and domain check

2022-06-29 Thread Daniel P. Smith
The function flask_domain_alloc_security() is where a default sid should be assigned to a domain under construction. For reasons unknown, the initial domain would be assigned unlabeled_t and then fixed up under flask_domain_create().  With the introduction of xenboot_t it is now possible to

[PATCH v9 2/3] flask: implement xsm_set_system_active

2022-06-29 Thread Daniel P. Smith
This commit implements full support for starting the idle domain privileged by introducing a new flask label xenboot_t which the idle domain is labeled with at creation. It then provides the implementation for the XSM hook xsm_set_system_active to relabel the idle domain to the existing xen_t

[PATCH v9 1/3] xsm: create idle domain privileged and demote after setup

2022-06-29 Thread Daniel P. Smith
There are new capabilities, dom0less and hyperlaunch, that introduce internal hypervisor logic, which needs to make resource allocation calls that are protected by XSM access checks. The need for these resource allocations are necessary for dom0less and hyperlaunch when they are constructing the

[PATCH v9 0/3] Adds starting the idle domain privileged

2022-06-29 Thread Daniel P. Smith
This series makes it so that the idle domain is started privileged under the default policy, which the SILO policy inherits, and under the flask policy. It then introduces a new one-way XSM hook, xsm_transition_running, that is hooked by an XSM policy to transition the idle domain to its running

RE: [PATCH RESEND v10 1/2] xen+tools: Report Interrupt Controller Virtualization capabilities on x86

2022-06-29 Thread Tian, Kevin
> From: Jane Malalane > Sent: Wednesday, June 29, 2022 11:17 PM > > On 29/06/2022 15:26, Jan Beulich wrote: > > On 29.06.2022 15:55, Jane Malalane wrote: > >> Add XEN_SYSCTL_PHYSCAP_X86_ASSISTED_XAPIC and > >> XEN_SYSCTL_PHYSCAP_X86_ASSISTED_X2APIC to report accelerated xAPIC > and > >> x2APIC,

RE: [PATCH] x86/ept: fix shattering of special pages

2022-06-29 Thread Tian, Kevin
> From: Roger Pau Monné > Sent: Wednesday, June 29, 2022 5:11 PM > > On Wed, Jun 29, 2022 at 08:41:43AM +, Tian, Kevin wrote: > > > From: Roger Pau Monne > > > Sent: Monday, June 27, 2022 6:01 PM > > > > > > The current logic in epte_get_entry_emt() will split any page marked > > > as

[linux-5.4 test] 171408: regressions - FAIL

2022-06-29 Thread osstest service owner
flight 171408 linux-5.4 real [real] flight 171414 linux-5.4 real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171408/ http://logs.test-lab.xenproject.org/osstest/logs/171414/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run:

[PATCH v3] xen/arm: avoid overflow when setting vtimer in context switch

2022-06-29 Thread Jiamei Xie
virt_vtimer_save is calculating the new time for the vtimer in: "v->arch.virt_timer.cval + v->domain->arch.virt_timer_base.offset - boot_count". In this formula, "cval + offset" might cause uint64_t overflow. Changing it to "ticks_to_ns(v->domain->arch.virt_timer_base.offset - boot_count) +

Re: [PATCH V1 2/2] xen/grant-table: Use unpopulated contiguous pages instead of real RAM ones

2022-06-29 Thread Stefano Stabellini
On Mon, 20 Jun 2022, Oleksandr Tyshchenko wrote: > From: Oleksandr Tyshchenko > > Depends on CONFIG_XEN_UNPOPULATED_ALLOC. If enabled then unpopulated > contiguous pages will be allocated for grant mapping into instead of > ballooning out real RAM pages. > > Also fallback to allocate DMAable

Re: [PATCH V1 1/2] xen/unpopulated-alloc: Introduce helpers for contiguous allocations

2022-06-29 Thread Stefano Stabellini
On Mon, 20 Jun 2022, Oleksandr Tyshchenko wrote: > From: Oleksandr Tyshchenko > > Add ability to allocate unpopulated contiguous pages suitable for > grant mapping into. This is going to be used by userspace PV backends > for grant mappings in gnttab code (see gnttab_dma_alloc_pages()). > >

Re: Reg. Tee init fail...

2022-06-29 Thread Boris Ostrovsky
On 6/29/22 4:03 PM, Stefano Stabellini wrote: Adding Juergen and Boris because this is a Linux/x86 issue. As you can see from this Linux driver: https://elixir.bootlin.com/linux/latest/source/drivers/crypto/ccp/tee-dev.c#L132 Linux as dom0 on x86 is trying to communicate with firmware

[linux-linus test] 171404: regressions - FAIL

2022-06-29 Thread osstest service owner
flight 171404 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171404/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-dom0pvh-xl-intel 8 xen-bootfail REGR. vs. 171277

[xen-unstable test] 171402: tolerable FAIL - PUSHED

2022-06-29 Thread osstest service owner
flight 171402 xen-unstable real [real] flight 171409 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171402/ http://logs.test-lab.xenproject.org/osstest/logs/171409/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking):

Re: [PATCH 2/2] uboot-script-gen: do not enable direct mapping by default

2022-06-29 Thread Stefano Stabellini
On Wed, 29 Jun 2022, Ayan Kumar Halder wrote: > Hi Stefano/Xenia, > > On 29/06/2022 18:01, xenia wrote: > > Hi Stefano, > > > > On 6/29/22 03:28, Stefano Stabellini wrote: > > > On Sun, 26 Jun 2022, Xenia Ragiadakou wrote: > > > > To be inline with XEN, do not enable direct mapping automatically

Re: Reg. Tee init fail...

2022-06-29 Thread Stefano Stabellini
Adding Juergen and Boris because this is a Linux/x86 issue. As you can see from this Linux driver: https://elixir.bootlin.com/linux/latest/source/drivers/crypto/ccp/tee-dev.c#L132 Linux as dom0 on x86 is trying to communicate with firmware (TEE). Linux is calling __pa to pass a physical address

Re: [PATCH 2/2] uboot-script-gen: do not enable direct mapping by default

2022-06-29 Thread Ayan Kumar Halder
Hi Stefano/Xenia, On 29/06/2022 18:01, xenia wrote: Hi Stefano, On 6/29/22 03:28, Stefano Stabellini wrote: On Sun, 26 Jun 2022, Xenia Ragiadakou wrote: To be inline with XEN, do not enable direct mapping automatically for all statically allocated domains. Signed-off-by: Xenia Ragiadakou

[PATCH v2 1/2] x86/spec-ctrl: Only adjust MSR_SPEC_CTRL for idle with legacy IBRS

2022-06-29 Thread Andrew Cooper
Back at the time of the original Spectre-v2 fixes, it was recommended to clear MSR_SPEC_CTRL when going idle. This is because of the side effects on the sibling thread caused by the microcode IBRS and STIBP implementations which were retrofitted to existing CPUs. However, there are no relevant

[PATCH v2 2/2] x86/spec-ctrl: Knobs for STIBP and PSFD, and follow hardware STIBP hint

2022-06-29 Thread Andrew Cooper
STIBP and PSFD are slightly weird bits, because they're both implied by other bits in MSR_SPEC_CTRL. Add fine grain controls for them, and take the implications into account when setting IBRS/SSBD. Rearrange the IBPB text/variables/logic to keep all the MSR_SPEC_CTRL bits together, for

[PATCH v2 0/2] x86/spec-ctrl: Minor fixes

2022-06-29 Thread Andrew Cooper
Patch 2 has been posted before, but ages ago and has been rebased over subseqent XSAs. Patch 1 is new. Andrew Cooper (2): x86/spec-ctrl: Only adjust MSR_SPEC_CTRL for idle with legacy IBRS x86/spec-ctrl: Knobs for STIBP and PSFD, and follow hardware STIBP hint

Re: R: R: Crash when using xencov

2022-06-29 Thread Julien Grall
(moving the discussion to xen-devel) On 28/06/2022 16:32, Carmine Cesarano wrote: Hi, Hello, Please refrain to top-post and/or post images on the ML. If you need to share an image, then please upload them somewhere else. I made two further attempts, first by compiling xen and xen-tools

[linux-5.4 test] 171400: regressions - FAIL

2022-06-29 Thread osstest service owner
flight 171400 linux-5.4 real [real] flight 171406 linux-5.4 real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171400/ http://logs.test-lab.xenproject.org/osstest/logs/171406/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run:

Re: [XEN PATCH v3 25/25] tools: Remove -Werror everywhere else

2022-06-29 Thread Stefano Stabellini
On Wed, 29 Jun 2022, Luca Fancellu wrote: > + CC: Stefano Stabellini > > > On 24 Jun 2022, at 17:04, Anthony PERARD wrote: > > > > Patch "tools: Add -Werror by default to all tools/" have added > > "-Werror" to CFLAGS in tools/Rules.mk, remove it from every other > > makefiles as it is now

Re: [PATCH] xen: arm: Don't use stop_cpu() in halt_this_cpu()

2022-06-29 Thread Stefano Stabellini
On Wed, 29 Jun 2022, Julien Grall wrote: > On 28/06/2022 23:56, Stefano Stabellini wrote: > > > The advantage of the panic() is it will remind us that some needs to be > > > fixed. > > > With a warning (or WARN()) people will tend to ignore it. > > > > I know that this specific code path (cpu

Re: [PATCH v2 0/3] x86: fix brk area initialization

2022-06-29 Thread Boris Ostrovsky
On 6/29/22 10:10 AM, Juergen Gross wrote: On 23.06.22 11:46, Juergen Gross wrote: The brk area needs to be zeroed initially, like the .bss section. At the same time its memory should be covered by the ELF program headers. Juergen Gross (3):    x86/xen: use clear_bss() for Xen PV guests   

Re: [PATCH v2 3/3] x86: fix .brk attribute in linker script

2022-06-29 Thread Josh Poimboeuf
On Thu, Jun 23, 2022 at 11:46:08AM +0200, Juergen Gross wrote: > Commit e32683c6f7d2 ("x86/mm: Fix RESERVE_BRK() for older binutils") > added the "NOLOAD" attribute to the .brk section as a "failsafe" > measure. > > Unfortunately this leads to the linker no longer covering the .brk > section in a

Re: [PATCH v2 2/3] x86: fix setup of brk area

2022-06-29 Thread Josh Poimboeuf
Hi Juergen, It helps to actually Cc the person who broke it ;-) On Thu, Jun 23, 2022 at 11:46:07AM +0200, Juergen Gross wrote: > Commit e32683c6f7d2 ("x86/mm: Fix RESERVE_BRK() for older binutils") > put the brk area into the .bss..brk section (placed directly behind > .bss), Hm? It didn't

[PATCH v5] xen/pass-through: merge emulated bits correctly

2022-06-29 Thread Chuck Zmudzinski
In xen_pt_config_reg_init(), there is an error in the merging of the emulated data with the host value. With the current Qemu, instead of merging the emulated bits with the host bits as defined by emu_mask, the emulated bits are merged with the host bits as defined by the inverse of emu_mask. In

Re: [PATCH 2/2] uboot-script-gen: do not enable direct mapping by default

2022-06-29 Thread xenia
Hi Stefano, On 6/29/22 03:28, Stefano Stabellini wrote: On Sun, 26 Jun 2022, Xenia Ragiadakou wrote: To be inline with XEN, do not enable direct mapping automatically for all statically allocated domains. Signed-off-by: Xenia Ragiadakou Actually I don't know about this one. I think it is OK

Re: [PATCH 2/2] console/serial: bump buffer from 16K to 32K

2022-06-29 Thread Jan Beulich
On 29.06.2022 18:19, Roger Pau Monné wrote: > On Wed, Jun 29, 2022 at 06:03:34PM +0200, Jan Beulich wrote: >> On 29.06.2022 17:23, Roger Pau Monné wrote: >>> On Thu, Jun 23, 2022 at 03:32:30PM +0200, Jan Beulich wrote: On 23.06.2022 11:08, Roger Pau Monne wrote: > Testing on a Kaby Lake

Re: [PATCH] x86/ept: fix shattering of special pages

2022-06-29 Thread Jan Beulich
On 27.06.2022 12:01, Roger Pau Monne wrote: > The current logic in epte_get_entry_emt() will split any page marked > as special with order greater than zero, without checking whether the > super page is all special. > > Fix this by only splitting the page only if it's not all marked as > special,

Re: [PATCH 2/2] console/serial: bump buffer from 16K to 32K

2022-06-29 Thread Roger Pau Monné
On Wed, Jun 29, 2022 at 06:03:34PM +0200, Jan Beulich wrote: > On 29.06.2022 17:23, Roger Pau Monné wrote: > > On Thu, Jun 23, 2022 at 03:32:30PM +0200, Jan Beulich wrote: > >> On 23.06.2022 11:08, Roger Pau Monne wrote: > >>> Testing on a Kaby Lake box with 8 CPUs leads to the serial buffer > >>>

Re: [PATCH 2/2] console/serial: bump buffer from 16K to 32K

2022-06-29 Thread Jan Beulich
On 29.06.2022 17:23, Roger Pau Monné wrote: > On Thu, Jun 23, 2022 at 03:32:30PM +0200, Jan Beulich wrote: >> On 23.06.2022 11:08, Roger Pau Monne wrote: >>> Testing on a Kaby Lake box with 8 CPUs leads to the serial buffer >>> being filled halfway during dom0 boot, and thus a non-trivial chunk of

Re: [PATCH RESEND v10 1/2] xen+tools: Report Interrupt Controller Virtualization capabilities on x86

2022-06-29 Thread Jane Malalane
On 29/06/2022 15:49, Christian Lindig wrote: > > > On 29 Jun 2022, at 14:55, Jane Malalane > mailto:jane.malal...@citrix.com>> wrote: > > + physinfo = caml_alloc_tuple(11); > Store_field(physinfo, 0, Val_int(c_physinfo.threads_per_core)); > Store_field(physinfo, 1,

Re: [PATCH 2/2] console/serial: bump buffer from 16K to 32K

2022-06-29 Thread Roger Pau Monné
On Thu, Jun 23, 2022 at 03:32:30PM +0200, Jan Beulich wrote: > On 23.06.2022 11:08, Roger Pau Monne wrote: > > Testing on a Kaby Lake box with 8 CPUs leads to the serial buffer > > being filled halfway during dom0 boot, and thus a non-trivial chunk of > > Linux boot messages are dropped. > > > >

Re: [PATCH RESEND v10 1/2] xen+tools: Report Interrupt Controller Virtualization capabilities on x86

2022-06-29 Thread Jane Malalane
On 29/06/2022 15:26, Jan Beulich wrote: > On 29.06.2022 15:55, Jane Malalane wrote: >> Add XEN_SYSCTL_PHYSCAP_X86_ASSISTED_XAPIC and >> XEN_SYSCTL_PHYSCAP_X86_ASSISTED_X2APIC to report accelerated xAPIC and >> x2APIC, on x86 hardware. This is so that xAPIC and x2APIC virtualization >> can

Re: [PATCH] xen/arm: smmu-v3: Fix MISRA C 2012 Rule 1.3 violations

2022-06-29 Thread Julien Grall
On 29/06/2022 15:10, Bertrand Marquis wrote: Hi, Hi Bertrand, In fact the patch was committed before we started this discussion as Rahul R-b was enough. It was probably merged a bit too fast. When there are multiple maintainers responsible for the code, I tend to prefer to wait a bit

Re: [PATCH RESEND v10 1/2] xen+tools: Report Interrupt Controller Virtualization capabilities on x86

2022-06-29 Thread Christian Lindig
On 29 Jun 2022, at 14:55, Jane Malalane mailto:jane.malal...@citrix.com>> wrote: + physinfo = caml_alloc_tuple(11); Store_field(physinfo, 0, Val_int(c_physinfo.threads_per_core)); Store_field(physinfo, 1, Val_int(c_physinfo.cores_per_socket)); Store_field(physinfo, 2,

Re: [PATCH v10 0/2] xen: Report and use hardware APIC virtualization capabilities

2022-06-29 Thread Jan Beulich
On 29.06.2022 13:09, Jan Beulich wrote: > On 29.06.2022 12:43, Anthony PERARD wrote: >> On Thu, Jun 23, 2022 at 09:23:27AM +0200, Jan Beulich wrote: >>> On 13.04.2022 13:21, Jane Malalane wrote: Jane Malalane (2): xen+tools: Report Interrupt Controller Virtualization capabilities on

Re: [PATCH RESEND v10 1/2] xen+tools: Report Interrupt Controller Virtualization capabilities on x86

2022-06-29 Thread Jan Beulich
On 29.06.2022 15:55, Jane Malalane wrote: > Add XEN_SYSCTL_PHYSCAP_X86_ASSISTED_XAPIC and > XEN_SYSCTL_PHYSCAP_X86_ASSISTED_X2APIC to report accelerated xAPIC and > x2APIC, on x86 hardware. This is so that xAPIC and x2APIC virtualization > can subsequently be enabled on a per-domain basis. > No

Re: [PATCH] xen/arm: smmu-v3: Fix MISRA C 2012 Rule 1.3 violations

2022-06-29 Thread Bertrand Marquis
Hi, In fact the patch was committed before we started this discussion as Rahul R-b was enough. But I would still be interested to have other maintainers view on this. > On 29 Jun 2022, at 10:03, Bertrand Marquis wrote: > > Hi Xenia, > >> On 29 Jun 2022, at 09:55, xenia wrote: >> >> Hi

Re: [PATCH v2 0/3] x86: fix brk area initialization

2022-06-29 Thread Juergen Gross
On 23.06.22 11:46, Juergen Gross wrote: The brk area needs to be zeroed initially, like the .bss section. At the same time its memory should be covered by the ELF program headers. Juergen Gross (3): x86/xen: use clear_bss() for Xen PV guests x86: fix setup of brk area x86: fix .brk

[PATCH RESEND v10 2/2] x86/xen: Allow per-domain usage of hardware virtualized APIC

2022-06-29 Thread Jane Malalane
Introduce a new per-domain creation x86 specific flag to select whether hardware assisted virtualization should be used for x{2}APIC. A per-domain option is added to xl in order to select the usage of x{2}APIC hardware assisted virtualization, as well as a global configuration option. Having all

[PATCH RESEND v10 1/2] xen+tools: Report Interrupt Controller Virtualization capabilities on x86

2022-06-29 Thread Jane Malalane
Add XEN_SYSCTL_PHYSCAP_X86_ASSISTED_XAPIC and XEN_SYSCTL_PHYSCAP_X86_ASSISTED_X2APIC to report accelerated xAPIC and x2APIC, on x86 hardware. This is so that xAPIC and x2APIC virtualization can subsequently be enabled on a per-domain basis. No such features are currently implemented on AMD

[PATCH RESEND v10 0/2] xen: Report and use hardware APIC virtualization capabilities

2022-06-29 Thread Jane Malalane
Jane Malalane (2): xen+tools: Report Interrupt Controller Virtualization capabilities on x86 x86/xen: Allow per-domain usage of hardware virtualized APIC docs/man/xl.cfg.5.pod.in | 15 ++ docs/man/xl.conf.5.pod.in | 12 +++

[PATCH v2] docs/misra: Add instructions for cppcheck

2022-06-29 Thread Luca Fancellu
Add instructions on how to build cppcheck, the version currently used and an example to use the cppcheck integration to run the analysis on the Xen codebase Signed-off-by: Luca Fancellu --- Changes in v2: - typo fixes, removed build command line, rephrasing (Julien) --- docs/misra/cppcheck.txt

[PATCH] tools/helpers: fix snprintf argument in init-dom0less.c

2022-06-29 Thread Luca Fancellu
Fix snprintf argument in init-dom0less.c because two instances of the function are using libxl_dominfo struct members that are uint64_t types, so change "%lu" to "%"PRIu64 to handle it properly when building on arm32 and arm64. Signed-off-by: Luca Fancellu --- tools/helpers/init-dom0less.c | 5

[qemu-mainline test] 171393: tolerable FAIL - PUSHED

2022-06-29 Thread osstest service owner
flight 171393 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/171393/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stopfail like 171376 test-amd64-amd64-qemuu-nested-amd

[libvirt test] 171396: regressions - FAIL

2022-06-29 Thread osstest service owner
flight 171396 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/171396/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-amd64-libvirt

Re: [PATCH v10 0/2] xen: Report and use hardware APIC virtualization capabilities

2022-06-29 Thread Jan Beulich
On 29.06.2022 12:43, Anthony PERARD wrote: > On Thu, Jun 23, 2022 at 09:23:27AM +0200, Jan Beulich wrote: >> On 13.04.2022 13:21, Jane Malalane wrote: >>> Jane Malalane (2): >>> xen+tools: Report Interrupt Controller Virtualization capabilities on >>> x86 >>> x86/xen: Allow per-domain

Re: [PATCH 3/7] xen/common: Use unsigned int instead of plain unsigned

2022-06-29 Thread Julien Grall
Hi, On 29/06/2022 11:46, Michal Orzel wrote: On 27.06.2022 15:15, Michal Orzel wrote: This is just for the style and consistency reasons as the former is being used more often than the latter. Signed-off-by: Michal Orzel It looks like this change was forgotten when merging other patches

Re: [PATCH v7 7/9] xen/arm: unpopulate memory when domain is static

2022-06-29 Thread Julien Grall
Hi Jan, On 29/06/2022 07:19, Jan Beulich wrote: On 29.06.2022 08:08, Penny Zheng wrote: From: Jan Beulich Sent: Wednesday, June 29, 2022 1:56 PM On 29.06.2022 05:12, Penny Zheng wrote: From: Julien Grall Sent: Monday, June 27, 2022 6:19 PM On 27/06/2022 11:03, Penny Zheng wrote:

Re: [PATCH 3/7] xen/common: Use unsigned int instead of plain unsigned

2022-06-29 Thread Michal Orzel
On 27.06.2022 15:15, Michal Orzel wrote: > This is just for the style and consistency reasons as the former is > being used more often than the latter. > > Signed-off-by: Michal Orzel It looks like this change was forgotten when merging other patches from the series.

Re: [PATCH v10 0/2] xen: Report and use hardware APIC virtualization capabilities

2022-06-29 Thread Anthony PERARD
On Thu, Jun 23, 2022 at 09:23:27AM +0200, Jan Beulich wrote: > On 13.04.2022 13:21, Jane Malalane wrote: > > Jane Malalane (2): > > xen+tools: Report Interrupt Controller Virtualization capabilities on > > x86 > > x86/xen: Allow per-domain usage of hardware virtualized APIC > > > >

Re: [PATCH v5 2/8] xen/arm: allocate static shared memory to the default owner dom_io

2022-06-29 Thread Julien Grall
On 29/06/2022 08:13, Penny Zheng wrote: Hi Julien Hi Penny, -Original Message- From: Julien Grall Sent: Saturday, June 25, 2022 2:22 AM To: Penny Zheng ; xen-devel@lists.xenproject.org Cc: Wei Chen ; Stefano Stabellini ; Bertrand Marquis ; Volodymyr Babchuk ; Andrew Cooper ;

Re: [XEN PATCH v3 25/25] tools: Remove -Werror everywhere else

2022-06-29 Thread Juergen Gross
On 24.06.22 18:04, Anthony PERARD wrote: Patch "tools: Add -Werror by default to all tools/" have added "-Werror" to CFLAGS in tools/Rules.mk, remove it from every other makefiles as it is now duplicated. Signed-off-by: Anthony PERARD Reviewed-by: Juergen Gross Juergen

Re: [XEN PATCH v3 19/25] tools: Introduce $(xenlibs-ldlibs, ) macro

2022-06-29 Thread Juergen Gross
On 24.06.22 18:04, Anthony PERARD wrote: This can be used when linking against multiple in-tree Xen libraries, and avoid duplicated flags. It can be used instead of multiple $(LDLIBS_libxen*). For now, replace the open-coding in libs.mk. The macro $(xenlibs-libs, ) will be useful later when

Re: [XEN PATCH v3 18/25] tools: Introduce $(xenlibs-rpath,..) to replace $(SHDEPS_lib*)

2022-06-29 Thread Juergen Gross
On 24.06.22 18:04, Anthony PERARD wrote: This patch introduce a new macro $(xenlibs-dependencies,) to generate a list of all the xen library that a library is list against, and they are listed only once. We use the side effect of $(sort ) which remove duplicates. This is used by another macro

Re: [XEN PATCH v3 17/25] libs/libs.mk: Rework target headers.chk dependencies

2022-06-29 Thread Juergen Gross
On 24.06.22 18:04, Anthony PERARD wrote: There is no need to call the "headers.chk" target when it isn't wanted, so it never need to be .PHONY. Also, there is no more reason to separate the prerequisites from the recipe. Signed-off-by: Anthony PERARD Reviewed-by: Juergen Gross Juergen

Re: [XEN PATCH v3 16/25] libs/libs.mk: Remove the need for $(PKG_CONFIG_INST)

2022-06-29 Thread Juergen Gross
On 24.06.22 18:04, Anthony PERARD wrote: We can simply use $(PKG_CONFIG) to set the parameters, and add it to $(TARGETS) as necessary. Signed-off-by: Anthony PERARD Reviewed-by: Juergen Gross Juergen OpenPGP_0xB0DE9DD628BF132F.asc Description: OpenPGP public key OpenPGP_signature

Re: [XEN PATCH v3 15/25] libs/libs.mk: Rename $(LIB) to $(TARGETS)

2022-06-29 Thread Juergen Gross
On 24.06.22 18:04, Anthony PERARD wrote: Signed-off-by: Anthony PERARD Reviewed-by: Juergen Gross Juergen OpenPGP_0xB0DE9DD628BF132F.asc Description: OpenPGP public key OpenPGP_signature Description: OpenPGP digital signature

Re: [XEN PATCH v3 13/25] tools/libs/util: cleanup Makefile

2022-06-29 Thread Juergen Gross
On 24.06.22 18:04, Anthony PERARD wrote: Remove -I. from CFLAGS, it isn't necessary. Removed $(AUTOSRCS), it isn't used. Signed-off-by: Anthony PERARD Reviewed-by: Juergen Gross Juergen OpenPGP_0xB0DE9DD628BF132F.asc Description: OpenPGP public key OpenPGP_signature Description:

Re: [PATCH v5 1/8] xen/arm: introduce static shared memory

2022-06-29 Thread Julien Grall
On 29/06/2022 06:38, Penny Zheng wrote: Hi Julien Hi Penny, -Original Message- From: Julien Grall Sent: Saturday, June 25, 2022 1:55 AM To: Penny Zheng ; xen-devel@lists.xenproject.org Cc: Wei Chen ; Stefano Stabellini ; Bertrand Marquis ; Volodymyr Babchuk Subject: Re: [PATCH

Re: [PATCH] docs/misra: Add instructions for cppcheck

2022-06-29 Thread Luca Fancellu
> On 29 Jun 2022, at 11:16, Julien Grall wrote: > > Hi Luca, > > On 28/06/2022 16:23, Luca Fancellu wrote: >>> On 24 Jun 2022, at 18:25, Julien Grall wrote: >>> On 24/06/2022 14:34, Luca Fancellu wrote: > On 24 Jun 2022, at 13:17, Julien Grall wrote: >> Sorry for the late reply, this

Re: [PATCH] docs/misra: Add instructions for cppcheck

2022-06-29 Thread Julien Grall
Hi Luca, On 28/06/2022 16:23, Luca Fancellu wrote: On 24 Jun 2022, at 18:25, Julien Grall wrote: On 24/06/2022 14:34, Luca Fancellu wrote: On 24 Jun 2022, at 13:17, Julien Grall wrote: Sorry for the late reply, this would be my changes, would you agree on them? They LGTM. Cheers, --

Re: [XEN PATCH v3 12/25] .gitignore: Cleanup ignores of tools/libs/*/{headers.chk,*.pc}

2022-06-29 Thread Juergen Gross
On 24.06.22 18:04, Anthony PERARD wrote: Signed-off-by: Anthony PERARD Reviewed-by: Juergen Gross Juergen OpenPGP_0xB0DE9DD628BF132F.asc Description: OpenPGP public key OpenPGP_signature Description: OpenPGP digital signature

Re: [RFC PATCH 1/2] xen/memory : Add stats_table resource type

2022-06-29 Thread Matias Ezequiel Vara Larsen
On Fri, Jun 17, 2022 at 08:54:34PM +, George Dunlap wrote: > Preface: It looks like this may be one of your first hypervisor patches. So > thank you! FYI there’s a lot that needs fixing up here; please don’t read a > tone of annoyance into it, I’m just trying to tell you what needs fixing

[linux-linus test] 171389: regressions - FAIL

2022-06-29 Thread osstest service owner
flight 171389 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171389/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-dom0pvh-xl-intel 8 xen-bootfail REGR. vs. 171277

Re: [PATCH] x86/ept: fix shattering of special pages

2022-06-29 Thread Roger Pau Monné
On Wed, Jun 29, 2022 at 08:41:43AM +, Tian, Kevin wrote: > > From: Roger Pau Monne > > Sent: Monday, June 27, 2022 6:01 PM > > > > The current logic in epte_get_entry_emt() will split any page marked > > as special with order greater than zero, without checking whether the > > super page is

Re: [PATCH] xen/arm: smmu-v3: Fix MISRA C 2012 Rule 1.3 violations

2022-06-29 Thread Bertrand Marquis
Hi Xenia, > On 29 Jun 2022, at 09:55, xenia wrote: > > Hi Bertrand, > > On 6/29/22 10:24, Bertrand Marquis wrote: >> Hi Xenia, >> >>> On 28 Jun 2022, at 16:08, Xenia Ragiadakou wrote: >>> >>> The expression 1 << 31 produces undefined behaviour because the type of >>> integer >>> constant 1

Re: [XEN PATCH v3 25/25] tools: Remove -Werror everywhere else

2022-06-29 Thread Luca Fancellu
+ CC: Stefano Stabellini > On 24 Jun 2022, at 17:04, Anthony PERARD wrote: > > Patch "tools: Add -Werror by default to all tools/" have added > "-Werror" to CFLAGS in tools/Rules.mk, remove it from every other > makefiles as it is now duplicated. > > Signed-off-by: Anthony PERARD Hi

RE: [PATCH v6 02/12] IOMMU/x86: new command line option to suppress use of superpage mappings

2022-06-29 Thread Tian, Kevin
> From: Roger Pau Monné > Sent: Tuesday, June 28, 2022 8:52 PM > > On Thu, Jun 09, 2022 at 12:17:23PM +0200, Jan Beulich wrote: > > Before actually enabling their use, provide a means to suppress it in > > case of problems. Note that using the option can also affect the sharing > > of page

Re: [PATCH] xen/arm: smmu-v3: Fix MISRA C 2012 Rule 1.3 violations

2022-06-29 Thread xenia
Hi Bertrand, On 6/29/22 10:24, Bertrand Marquis wrote: Hi Xenia, On 28 Jun 2022, at 16:08, Xenia Ragiadakou wrote: The expression 1 << 31 produces undefined behaviour because the type of integer constant 1 is (signed) int and the result of shifting 1 by 31 bits is not representable in the

Re: [PATCH 1/6] x86/Kconfig: add selection of default x2APIC destination mode

2022-06-29 Thread Roger Pau Monné
On Thu, Jun 23, 2022 at 04:47:22PM +0200, Jan Beulich wrote: > On 23.06.2022 10:24, Roger Pau Monne wrote: > > Allow selecting the default x2APIC destination mode from Kconfig. > > Note the default destination mode is still Logical (Cluster) mode. > > > > Signed-off-by: Roger Pau Monné > > --- >

[xen-unstable test] 171387: tolerable FAIL - PUSHED

2022-06-29 Thread osstest service owner
flight 171387 xen-unstable real [real] flight 171401 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171387/ http://logs.test-lab.xenproject.org/osstest/logs/171401/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking):

RE: [PATCH] x86/ept: fix shattering of special pages

2022-06-29 Thread Tian, Kevin
> From: Roger Pau Monne > Sent: Monday, June 27, 2022 6:01 PM > > The current logic in epte_get_entry_emt() will split any page marked > as special with order greater than zero, without checking whether the > super page is all special. > > Fix this by only splitting the page only if it's not

RE: [PATCH v5 1/8] xen/arm: introduce static shared memory

2022-06-29 Thread Penny Zheng
Hi Julien > -Original Message- > From: Julien Grall > Sent: Saturday, June 25, 2022 3:26 AM > To: Penny Zheng ; xen-devel@lists.xenproject.org > Cc: Wei Chen ; Stefano Stabellini > ; Bertrand Marquis ; > Volodymyr Babchuk > Subject: Re: [PATCH v5 1/8] xen/arm: introduce static shared

RE: [PATCH v5 1/8] xen/arm: introduce static shared memory

2022-06-29 Thread Penny Zheng
Hi Julien > -Original Message- > From: Julien Grall > Sent: Saturday, June 25, 2022 1:55 AM > To: Penny Zheng ; xen-devel@lists.xenproject.org > Cc: Wei Chen ; Stefano Stabellini > ; Bertrand Marquis ; > Volodymyr Babchuk > Subject: Re: [PATCH v5 1/8] xen/arm: introduce static shared

Re: [PATCH] xen: arm: Don't use stop_cpu() in halt_this_cpu()

2022-06-29 Thread Julien Grall
Hi Stefano, On 28/06/2022 23:56, Stefano Stabellini wrote: The advantage of the panic() is it will remind us that some needs to be fixed. With a warning (or WARN()) people will tend to ignore it. I know that this specific code path (cpu off) is probably not super relevant for what I am about

RE: [PATCH v5 5/8] xen/arm: Add additional reference to owner domain when the owner is allocated

2022-06-29 Thread Penny Zheng
Hi Julien > -Original Message- > From: Julien Grall > Sent: Saturday, June 25, 2022 3:18 AM > To: Penny Zheng ; xen-devel@lists.xenproject.org > Cc: Wei Chen ; Stefano Stabellini > ; Bertrand Marquis ; > Volodymyr Babchuk > Subject: Re: [PATCH v5 5/8] xen/arm: Add additional reference

RE: [PATCH v5 3/8] xen/arm: allocate static shared memory to a specific owner domain

2022-06-29 Thread Penny Zheng
Hi Julien > -Original Message- > From: Julien Grall > Sent: Saturday, June 25, 2022 3:07 AM > To: Penny Zheng ; xen-devel@lists.xenproject.org > Cc: Wei Chen ; Stefano Stabellini > ; Bertrand Marquis ; > Volodymyr Babchuk > Subject: Re: [PATCH v5 3/8] xen/arm: allocate static shared

Re: [PATCH] xen/arm: smmu-v3: Fix MISRA C 2012 Rule 1.3 violations

2022-06-29 Thread Bertrand Marquis
Hi Xenia, > On 28 Jun 2022, at 16:08, Xenia Ragiadakou wrote: > > The expression 1 << 31 produces undefined behaviour because the type of > integer > constant 1 is (signed) int and the result of shifting 1 by 31 bits is not > representable in the (signed) int type. > Change the type of 1 to

RE: [PATCH v5 2/8] xen/arm: allocate static shared memory to the default owner dom_io

2022-06-29 Thread Penny Zheng
Hi Julien > -Original Message- > From: Julien Grall > Sent: Saturday, June 25, 2022 2:22 AM > To: Penny Zheng ; xen-devel@lists.xenproject.org > Cc: Wei Chen ; Stefano Stabellini > ; Bertrand Marquis ; > Volodymyr Babchuk ; Andrew Cooper > ; George Dunlap ; > Jan Beulich ; Wei Liu >

RE: [PATCH 5/5] x86/vmx: fix indentation of LBR

2022-06-29 Thread Tian, Kevin
> From: Roger Pau Monne > Sent: Friday, May 20, 2022 9:38 PM > > Properly indent the handling of LBR enable in MSR_IA32_DEBUGCTLMSR > vmx_msr_write_intercept(). > > No functional change. > > Signed-off-by: Roger Pau Monné Reviewed-by: Kevin Tian > --- > Feel free to squash onto the previous

Re: [PATCH] Fix compilation error with gcc13

2022-06-29 Thread Jan Beulich
(Cc-ing maintainers / reviewers) On 28.06.2022 18:09, Charles Arnold wrote: > From 359f490021e69220313ca8bd2981bad4fcfea0db Mon Sep 17 00:00:00 2001 > From: Charles Arnold > Date: Tue, 28 Jun 2022 09:55:28 -0600 > Subject: Fix compilation error with gcc13. > > xc_psr.c:161:5: error:

Re: [PATCH v6 2/9] xen: harmonize return types of hypercall handlers

2022-06-29 Thread Juergen Gross
On 24.03.22 15:01, Juergen Gross wrote: Today most hypercall handlers have a return type of long, while the compat ones return an int. There are a few exceptions from that rule, however. Get rid of the exceptions by letting compat handlers always return int and others always return long, with

Re: [PATCH v7 7/9] xen/arm: unpopulate memory when domain is static

2022-06-29 Thread Jan Beulich
On 29.06.2022 08:08, Penny Zheng wrote: >> From: Jan Beulich >> Sent: Wednesday, June 29, 2022 1:56 PM >> >> On 29.06.2022 05:12, Penny Zheng wrote: From: Julien Grall Sent: Monday, June 27, 2022 6:19 PM On 27/06/2022 11:03, Penny Zheng wrote: >> -Original

RE: [PATCH v7 7/9] xen/arm: unpopulate memory when domain is static

2022-06-29 Thread Penny Zheng
Hi Jan > -Original Message- > From: Jan Beulich > Sent: Wednesday, June 29, 2022 1:56 PM > To: Penny Zheng > Cc: Wei Chen ; Andrew Cooper > ; George Dunlap ; > Stefano Stabellini ; Wei Liu ; xen- > de...@lists.xenproject.org; Julien Grall > Subject: Re: [PATCH v7 7/9] xen/arm:

[PATCH v3] xen/pass-through: merge emulated bits correctly

2022-06-29 Thread Chuck Zmudzinski
In xen_pt_config_reg_init(), there is an error in the merging of the emulated data with the host value. With the current Qemu, instead of merging the emulated bits with the host bits as defined by emu_mask, the emulated bits are merged with the host bits as defined by the inverse of emu_mask. In

[PATCH v3] xen/pass-through: don't create needless register group

2022-06-29 Thread Chuck Zmudzinski
Currently we are creating a register group for the Intel IGD OpRegion for every device we pass through, but the XEN_PCI_INTEL_OPREGION register group is only valid for an Intel IGD. Add a check to make sure the device is an Intel IGD and a check that the administrator has enabled gfx_passthru in