[linux-5.4 test] 172453: regressions - trouble: blocked/broken/fail/pass

2022-08-12 Thread osstest service owner
flight 172453 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/172453/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-credit2 broken build-i386-libvirt6

[ovmf test] 172469: regressions - FAIL

2022-08-12 Thread osstest service owner
flight 172469 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172469/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 172136 build-amd64-libvirt

[xen-unstable test] 172442: tolerable FAIL - PUSHED

2022-08-12 Thread osstest service owner
flight 172442 xen-unstable real [real] flight 172465 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/172442/ http://logs.test-lab.xenproject.org/osstest/logs/172465/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking):

[linux-5.4 bisection] complete build-amd64-libvirt

2022-08-12 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job build-amd64-libvirt testid libvirt-build Tree: libvirt git://xenbits.xen.org/libvirt.git Tree: libvirt_keycodemapdb https://gitlab.com/keycodemap/keycodemapdb.git Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tree: qemu

[ovmf test] 172461: regressions - FAIL

2022-08-12 Thread osstest service owner
flight 172461 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172461/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 172136 build-amd64-libvirt

[linux-linus test] 172445: regressions - FAIL

2022-08-12 Thread osstest service owner
flight 172445 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/172445/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 172133

[PATCH v4 11/11] drivers/char: allow driving the rest of XHCI by a domain while Xen uses DbC

2022-08-12 Thread Marek Marczykowski-Górecki
That's possible, because the capability was designed specifically to allow separate driver handle it, in parallel to unmodified xhci driver (separate set of registers, pretending the port is "disconnected" for the main xhci driver etc). It works with Linux dom0, although requires an awful hack -

[PATCH v4 09/11] drivers/char: mark DMA buffers as reserved for the XHCI

2022-08-12 Thread Marek Marczykowski-Górecki
The important part is to include those buffers in IOMMU page table relevant for the USB controller. Otherwise, DbC will stop working as soon as IOMMU is enabled, regardless of to which domain device assigned (be it xen or dom0). If the device is passed through to dom0 or other domain (see later

[PATCH v4 07/11] IOMMU/VT-d: wire common device reserved memory API

2022-08-12 Thread Marek Marczykowski-Górecki
Re-use rmrr= parameter handling code to handle common device reserved memory. Signed-off-by: Marek Marczykowski-Górecki --- Changes in v3: - make MAX_USER_RMRR_PAGES applicable only to user-configured RMRR --- xen/drivers/passthrough/vtd/dmar.c | 201 +- 1 file

[PATCH v4 00/11] Add Xue - console over USB 3 Debug Capability

2022-08-12 Thread Marek Marczykowski-Górecki
This is integration of https://github.com/connojd/xue into mainline Xen. This patch series includes several patches that I made in the process, some are very loosely related. The driver developed by Connor supports console via USB3 debug capability. The capability is designed to operate mostly

[PATCH v4 01/11] drivers/char: Add support for USB3 DbC debugger

2022-08-12 Thread Marek Marczykowski-Górecki
From: Connor Davis [Connor] Xue is a cross-platform USB 3 debugger that drives the Debug Capability (DbC) of xHCI-compliant host controllers. This patch implements the operations needed for xue to initialize the host controller's DbC and communicate with it. It also implements a struct

[PATCH v4 05/11] console: support multiple serial console simultaneously

2022-08-12 Thread Marek Marczykowski-Górecki
Previously only one serial console was supported at the same time. Using console=com1,dbgp,vga silently ignored all but last serial console (in this case: only dbgp and vga were active). Fix this by storing not a single sercon_handle, but an array of them, up to MAX_SERCONS entries. The value of

[PATCH v4 04/11] drivers/char: make serial_parse_handle take const argument

2022-08-12 Thread Marek Marczykowski-Górecki
It doesn't modify it, and it will be necessary in a subsequent patch. Signed-off-by: Marek Marczykowski-Górecki --- xen/drivers/char/serial.c | 2 +- xen/include/xen/serial.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/drivers/char/serial.c

[PATCH v4 02/11] drivers/char: reset XHCI ports when initializing dbc

2022-08-12 Thread Marek Marczykowski-Górecki
Reset ports, to force host system to re-enumerate devices. Otheriwse it will require the cable to be re-plugged, or will wait in the "configuring" state indefinitely. Trick and code copied from Linux: drivers/usb/early/xhci-dbc.c:xdbc_start()->xdbc_reset_debug_port() Signed-off-by: Marek

[PATCH v4 10/11] drivers/char: add RX support to the XHCI driver

2022-08-12 Thread Marek Marczykowski-Górecki
Add another work ring buffer for received data, and point IN TRB at it. Ensure there is always at least one pending IN TRB, so the controller has a way to send incoming data to the driver. Note that both "success" and "short packet" completion codes are okay - in fact it will be "short packet"

[PATCH v4 08/11] IOMMU/AMD: wire common device reserved memory API

2022-08-12 Thread Marek Marczykowski-Górecki
Register common device reserved memory similar to how ivmd= parameter is handled. Signed-off-by: Marek Marczykowski-Górecki Acked-by: Jan Beulich --- Changes in v3: - use variable initializer - use pfn_to_paddr() --- xen/drivers/passthrough/amd/iommu_acpi.c | 21 + 1 file

[PATCH v4 06/11] IOMMU: add common API for device reserved memory

2022-08-12 Thread Marek Marczykowski-Górecki
Add API similar to rmrr= and ivmd= arguments, but in a common code. This will allow drivers to register reserved memory regardless of the IOMMU vendor. The direct reason for this API is xhci-dbc console driver (aka xue), that needs to use DMA. But future change may unify command line arguments for

[PATCH v4 03/11] drivers/char: add support for selecting specific xhci

2022-08-12 Thread Marek Marczykowski-Górecki
Handle parameters similar to dbgp=ehci. Implement this by not resettting dbc->sbdf again in dbc_init_xhc(), but using a value found there if non-zero. Additionally, add xue->xhc_num to select n-th controller. Signed-off-by: Marek Marczykowski-Górecki Reviewed-by: Jan Beulich --- Changes in v4:

[PATCH] add SPDX to arch/arm/*.c

2022-08-12 Thread Stefano Stabellini
Add SPDX license information to all the *.c files under arch/arm. Signed-off-by: Stefano Stabellini --- We need to start from somewhere and I thought arch/arm/*.c would be a good place to start. diff --git a/xen/arch/arm/alternative.c b/xen/arch/arm/alternative.c index f03cd943c6..8115f89408

[ovmf test] 172455: regressions - FAIL

2022-08-12 Thread osstest service owner
flight 172455 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172455/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 172136 build-amd64-libvirt

[qemu-mainline test] 172435: regressions - FAIL

2022-08-12 Thread osstest service owner
flight 172435 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/172435/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 172123

[ovmf test] 172449: regressions - FAIL

2022-08-12 Thread osstest service owner
flight 172449 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172449/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 172136 build-amd64-libvirt

[linux-5.4 test] 172422: regressions - FAIL

2022-08-12 Thread osstest service owner
flight 172422 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/172422/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 172128 build-amd64-libvirt

[xen-unstable-smoke test] 172446: tolerable FAIL - PUSHED

2022-08-12 Thread osstest service owner
flight 172446 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/172446/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a build-amd64-libvirt 6

[PATCH 8/8] xen/arm32: traps: Dump more information for hypervisor data abort

2022-08-12 Thread Julien Grall
From: Julien Grall Unlike arm64, on arm32 there are no extra information dumped (e.g. page table walk) for hypervisor data abort. For data abort, the HSR will be set properly and so replace the call to do_unexpected_trap() with do_trap_hyp_sync() to dispatch the error. Signed-off-by: Julien

[PATCH 7/7] xen/arm32: traps: Dump more information for hypervisor data abort

2022-08-12 Thread Julien Grall
From: Julien Grall Unlike arm64, on arm32 there are no extra information dumped (e.g. page table walk) for hypervisor data abort. For data abort, the HSR will be set properly and so replace the call to do_unexpected_trap() with do_trap_hyp_sync() to dispatch the error. Signed-off-by: Julien

[PATCH 6/7] xen/arm: Tweak the dump page-table walk output

2022-08-12 Thread Julien Grall
From: Julien Grall Currently the output is looking like: (XEN) 1ST[0x1] = 0x4015ff7f (XEN) 2ND[0x1f] = 0x0050bfe00f7d The content of the entries are not aligned making a bit trickier to read (I appreciate this is a matter of taste). Align the values by forcing the index to be

[PATCH 5/7] xen/arm32: head: Move earlyprintk messages to .rodata.str

2022-08-12 Thread Julien Grall
From: Julien Grall At the moment, the strings are in text right after each use because the instruction 'adr' has specific requirement on the location and the compiler will forbid cross section label. The macro 'adr_l' was recently reworked so the caller doesn't need to know whether the MMU is

[PATCH 4/7] xen/arm32: heap: Rework adr_l so it doesn't rely on where Xen is loaded

2022-08-12 Thread Julien Grall
From: Julien Grall At the moment, the macro addr_l needs to know whether the caller is running with the MMU on. This is fine today because there are only two possible cases: 1) MMU off 2) MMU on and linked to the virtual address This is still cumbersome to use for the developer as they need

[PATCH 2/7] xen/arm64: head: Introduce get_table_slot() and use it

2022-08-12 Thread Julien Grall
From: Julien Grall There are a few places in the code that need to find the slot at a given page-table level. So create a new macro get_table_slot() for that. This will reduce the effort to figure out whether the code is doing the right thing. Take the opportunity to use 'ubfx'. The only

[PATCH 1/7] xen/arm64: head: Don't set x22 and update the documentation

2022-08-12 Thread Julien Grall
From: Julien Grall Since commit 7e14a47e7c73 ("xen/arm64: head Rework and document launch()"), the boot code is setting x22 but not read it. So remove the two instructions setting x22 and update the documentation to show x22 has no specific purpose. Signed-off-by: Julien Grall ---

[PATCH 7/8] patch arm32-tweak-enable-mmu.patch

2022-08-12 Thread Julien Grall
From: Julien Grall --- xen/arch/arm/arm32/head.S | 50 +++ 1 file changed, 30 insertions(+), 20 deletions(-) diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S index a558c2a6876e..a914ffab98a5 100644 --- a/xen/arch/arm/arm32/head.S +++

[PATCH 3/7] xen/arm32: head: Introduce get_table_slot() and use it

2022-08-12 Thread Julien Grall
From: Julien Grall There are a few places in the code that need to find the slot at a given page-table level. So create a new macro get_table_slot() for that. This will reduce the effort to figure out whether the code is doing the right thing. The new macro is using 'ubfx' (or 'lsr' for the

[PATCH 0/7] xen/arm: More clean-ups and improvement

2022-08-12 Thread Julien Grall
From: Julien Grall Hi all, This is another collection of patches that I accumulated while reworking the boot code. I am not planning to target Xen 4.17 for the boot code (still working on it and it is risky). But I the clean-ups and improvement patches could be. Cheers, Julien Grall (7):

[PATCH] xen/arm: Add xen/arch/arm/efi/stub.c in .gitignore

2022-08-12 Thread Julien Grall
From: Julien Grall Xen build system the symbolic link xen/arch/arm/efi/stub.c. So we want to ignore it. Fixes: 7f96859b0d00 ("xen: reuse x86 EFI stub functions for Arm") Signed-off-by: Julien Grall --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore

[ovmf test] 172443: regressions - FAIL

2022-08-12 Thread osstest service owner
flight 172443 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172443/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 172136 build-amd64-libvirt

[PATCH] x86/traps: Make nmi_show_execution_state() more useful

2022-08-12 Thread Andrew Cooper
* Always emit current. It's critically important. * Do not render () for the symbol in guest context. It's just line-noise. Instead, explicitly identify which Xen vs guest context. * Try to tabulate the data, because there is often lots of it. Signed-off-by: Andrew Cooper

Re: [PATCH v3 5/5] tools/xenstore: add migration stream extensions for new features

2022-08-12 Thread Julien Grall
Hi Juergen, On 12/08/2022 11:56, Juergen Gross wrote: On 12.08.22 11:13, Julien Grall wrote: Hi Juergen, On 08/08/2022 12:31, Juergen Gross wrote: On 08.08.22 13:00, Julien Grall wrote: This would break the use of xenstore-stubdom for such a setup. I am not sure why it would break the use

[xen-unstable-smoke test] 172431: tolerable FAIL - PUSHED

2022-08-12 Thread osstest service owner
flight 172431 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/172431/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a build-amd64-libvirt 6

[linux-linus test] 172414: regressions - FAIL

2022-08-12 Thread osstest service owner
flight 172414 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/172414/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 172133

[linux-5.4 bisection] complete build-i386-libvirt

2022-08-12 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job build-i386-libvirt testid libvirt-build Tree: libvirt git://xenbits.xen.org/libvirt.git Tree: libvirt_keycodemapdb https://gitlab.com/keycodemap/keycodemapdb.git Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tree: qemu

[ovmf test] 172438: regressions - FAIL

2022-08-12 Thread osstest service owner
flight 172438 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172438/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 172136 build-amd64-libvirt

[xen-unstable test] 172408: tolerable FAIL - PUSHED

2022-08-12 Thread osstest service owner
flight 172408 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/172408/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1

Re: [XEN PATCH v4 02/32] tools/firmware/hvmloader: rework Makefile

2022-08-12 Thread Anthony PERARD
On Fri, Aug 12, 2022 at 03:36:12PM +0200, Jan Beulich wrote: > On 11.08.2022 18:48, Anthony PERARD wrote: > > Setup proper dependencies with libacpi so we don't need to run "make > > hvmloader" in the "all" target. ("build.o" new prerequisite isn't > > exactly proper but a side effect of building

[ovmf test] 172429: regressions - FAIL

2022-08-12 Thread osstest service owner
flight 172429 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172429/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 172136 build-amd64-libvirt

[qemu-mainline test] 172405: regressions - FAIL

2022-08-12 Thread osstest service owner
flight 172405 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/172405/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 172123

Re: [XEN PATCH v4 03/32] tools/fuzz/x86_instruction_emulator: rework makefile

2022-08-12 Thread Jan Beulich
On 11.08.2022 18:48, Anthony PERARD wrote: > Rework dependencies of all objects. We don't need to add dependencies > for headers that $(CC) is capable of generating, we only need to > include $(DEPS_INCLUDE). Some dependencies are still needed so make > knows to generate symlinks for them. > > We

Re: [XEN PATCH v4 02/32] tools/firmware/hvmloader: rework Makefile

2022-08-12 Thread Jan Beulich
On 11.08.2022 18:48, Anthony PERARD wrote: > Setup proper dependencies with libacpi so we don't need to run "make > hvmloader" in the "all" target. ("build.o" new prerequisite isn't > exactly proper but a side effect of building the $(DSDT_FILES) is to > generate the "ssdt_*.h" needed by

Re: [PATCH v2 2/3] x86/build: Don't convert boot/{cmdline,head}.bin back to .S

2022-08-12 Thread Jan Beulich
On 12.08.2022 14:55, Andrew Cooper wrote: > There's no point wasting time converting binaries back to asm source. Just > use .incbin directly. Explain in head.S what these binaries are. > > Also, explicitly align the blobs. They contain 4-byte objects, and happen to > be 4-byte aligned

[PATCH v2 2/3] x86/build: Don't convert boot/{cmdline,head}.bin back to .S

2022-08-12 Thread Andrew Cooper
There's no point wasting time converting binaries back to asm source. Just use .incbin directly. Explain in head.S what these binaries are. Also, explicitly align the blobs. They contain 4-byte objects, and happen to be 4-byte aligned currently because of the position of `lret` and the size of

[ovmf test] 172424: regressions - FAIL

2022-08-12 Thread osstest service owner
flight 172424 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172424/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 172136 build-amd64-libvirt

Re: Enable audio virtualization in Xen

2022-08-12 Thread Oleksandr
On 12.08.22 12:27, SHARMA, JYOTIRMOY wrote: [AMD Official Use Only - General] Hello Christopher, Hello Jyotirmoy, Christopher Just spotted that libxenbe and snd_be were mentioned ... Thank you so much for your reply. I will execute your steps and first try to enable pulse audio as

[libvirt test] 172409: regressions - FAIL

2022-08-12 Thread osstest service owner
flight 172409 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/172409/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-armhf-libvirt

Re: [PATCH v9 8/8] xen: retrieve reserved pages on populate_physmap

2022-08-12 Thread Jan Beulich
On 12.08.2022 11:53, Bertrand Marquis wrote: >> On 9 Aug 2022, at 09:58, Penny Zheng wrote: >>> -Original Message- >>> From: Jan Beulich >>> Sent: Tuesday, August 9, 2022 4:27 PM >>> >>> On 09.08.2022 10:07, Penny Zheng wrote: > -Original Message- > From: Jan Beulich

[qemu-mainline bisection] complete build-armhf-libvirt

2022-08-12 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job build-armhf-libvirt testid libvirt-build Tree: libvirt git://xenbits.xen.org/libvirt.git Tree: libvirt_keycodemapdb https://gitlab.com/keycodemap/keycodemapdb.git Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tree: qemuu

Re: [PATCH v3 5/5] tools/xenstore: add migration stream extensions for new features

2022-08-12 Thread Juergen Gross
On 12.08.22 11:13, Julien Grall wrote: Hi Juergen, On 08/08/2022 12:31, Juergen Gross wrote: On 08.08.22 13:00, Julien Grall wrote: This would break the use of xenstore-stubdom for such a setup. I am not sure why it would break the use of xenstore-stubdom. An application will already need

Re: [PATCH v3 5/5] tools/xenstore: add migration stream extensions for new features

2022-08-12 Thread Julien Grall
Hi Juergen, On 08/08/2022 12:31, Juergen Gross wrote: And even with using an ID you'd have the same problem again, but without having the possibility to add variant specific quota Fair enough. (remember that there already has been a statement that doing a live update from C to OCAML or

Re: [PATCH] x86/msi: Switch msi_info to using pci_sbdf_t

2022-08-12 Thread Andrew Cooper
On 12/08/2022 07:45, Jan Beulich wrote: > On 11.08.2022 18:37, Andrew Cooper wrote: >> This reorders the fields in msi_info, but removes all the under-the-hood >> parameter shuffling required to call pci_get_pdev(). >> >> No functional change. >> >> Signed-off-by: Andrew Cooper > Oh, you've made

[xen-unstable-smoke test] 172415: tolerable FAIL - PUSHED

2022-08-12 Thread osstest service owner
flight 172415 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/172415/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a build-amd64-libvirt 6

Re: [PATCH v4 0/3] xen-blk{back,front}: Fix two bugs in 'feature_persistent'

2022-08-12 Thread Juergen Gross
On 16.07.22 00:51, SeongJae Park wrote: Introduction of 'feature_persistent' made two bugs. First one is wrong overwrite of 'vbd->feature_gnt_persistent' in 'blkback' due to wrong parameter value caching position, and the second one is unintended behavioral change that could break previous

Re: [PATCH 2/2] x86/svm: Keep the RAS balanced for guests

2022-08-12 Thread Andrew Cooper
On 12/08/2022 08:29, Jan Beulich wrote: > On 11.08.2022 21:59, Andrew Cooper wrote: >> One source of lost performance was that fact that to protect Xen from a >> malicious guests, we had to flush the RAS. >> >> It turns out that CET Shadow Stacks give us enough architectural guarantees >> to >>

[ovmf test] 172416: regressions - FAIL

2022-08-12 Thread osstest service owner
flight 172416 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172416/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 172136 build-amd64-libvirt

Re: [PATCH v9 8/8] xen: retrieve reserved pages on populate_physmap

2022-08-12 Thread Bertrand Marquis
Hi Penny, > On 9 Aug 2022, at 09:58, Penny Zheng wrote: > > Hi jan > >> -Original Message- >> From: Jan Beulich >> Sent: Tuesday, August 9, 2022 4:27 PM >> To: Penny Zheng >> Cc: Wei Chen ; Andrew Cooper >> ; George Dunlap ; >> Julien Grall ; Stefano Stabellini ; >> Wei Liu ;

Re: Enable audio virtualization in Xen

2022-08-12 Thread SHARMA, JYOTIRMOY
[AMD Official Use Only - General] Hello Christopher, Thank you so much for your reply. I will execute your steps and first try to enable pulse audio as you have mentioned. Later I will try to enable ALSA which is my final requirement. Meanwhile, I was reading up on virtio-snd and found some

[linux-5.4 test] 172398: regressions - FAIL

2022-08-12 Thread osstest service owner
flight 172398 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/172398/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 172128 build-amd64-libvirt

Re: [PATCH v2] xen/arm: smmu: Set s2cr to type fault when the devices are deassigned

2022-08-12 Thread Julien Grall
Hi Rahul, On 11/08/2022 16:42, Rahul Singh wrote: When devices are deassigned/assigned, SMMU global fault is observed because SMEs are freed in detach function and not allocated again when the device is assigned back to the guest. Don't free the SMEs when devices are deassigned, set the s2cr

[PATCH v2] x86: help inlining of functions involving alternative_call()

2022-08-12 Thread Jan Beulich
The involved asm() expands to large enough a construct that often the compiler would decide against inlining when a containing function is used more than once in a CU. Use the "inline" keyword when supported by the compiler in conjunction with asm(). The INIT_SECTIONS_ONLY dependency is because

Re: [PATCH v3 5/5] tools/xenstore: add migration stream extensions for new features

2022-08-12 Thread Julien Grall
Hi Juergen, On 08/08/2022 12:31, Juergen Gross wrote: On 08.08.22 13:00, Julien Grall wrote: This would break the use of xenstore-stubdom for such a setup. I am not sure why it would break the use of xenstore-stubdom. An application will already need to cope with the case Xenstored doesn't

[PATCH v2] x86: show_hvm_stack() requires enabled interrupts

2022-08-12 Thread Jan Beulich
show_hvm_stack() requires interrupts to be enabled to avoid triggering the consistency check in check_lock() for the p2m lock. Add a respective check. To avoid this check triggering when coming through spurious_interrupt() requires adding reentrancy protection / handling there alongside

Re: [PATCH 7/8] x86/mm: adjust type check around _get_page_type()'s TLB flush

2022-08-12 Thread Jan Beulich
On 27.07.2022 20:25, Andrew Cooper wrote: > On 26/07/2022 17:06, Jan Beulich wrote: >> While "type" can include PGT_pae_xen_l2, "x" can't, as the bit is >> cleared upon de-validation (see also the respective assertion earlier in >> the function). > > While this statement is true, it doesn't

Re: [PATCH 2/4] xen: remove XEN_SCRUB_PAGES in xen.config

2022-08-12 Thread Juergen Gross
On 10.08.22 07:07, Lukas Bulwahn wrote: Commit 197ecb3802c0 ("xen/balloon: add runtime control for scrubbing ballooned out pages") changed config XEN_SCRUB_PAGES to config XEN_SCRUB_PAGES_DEFAULT. As xen.config sets 'XEN_BALLOON=y' and XEN_SCRUB_PAGES_DEFAULT defaults to yes, there is no further

Re: [PATCH] xen/pciback: Fix comment typo

2022-08-12 Thread Juergen Gross
On 11.08.22 14:09, Jason Wang wrote: The double `the' is duplicated in the comment, remove one. Signed-off-by: Jason Wang Reviewed-by: Juergen Gross Juergen OpenPGP_0xB0DE9DD628BF132F.asc Description: OpenPGP public key OpenPGP_signature Description: OpenPGP digital signature

Re: [PATCH 4/4] MAINTAINERS: add xen config fragments to XEN HYPERVISOR sections

2022-08-12 Thread Juergen Gross
On 10.08.22 07:07, Lukas Bulwahn wrote: Make changes to the xen config fragments reach the XEN HYPERVISOR maintainers and mailing list. Signed-off-by: Lukas Bulwahn Reviewed-by: Juergen Gross Juergen OpenPGP_0xB0DE9DD628BF132F.asc Description: OpenPGP public key OpenPGP_signature

Re: [XEN PATCH v4 00/32] Toolstack build system improvement, toward non-recursive makefiles

2022-08-12 Thread Christian Lindig
On 11 Aug 2022, at 17:48, Anthony PERARD mailto:anthony.per...@citrix.com>> wrote: Patch series available in this git branch: https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.toolstack-build-system-v4 Changes in v4: - several new patches - some changes to other patches

[PATCH v3 4/4] x86/P2M: allow 2M superpage use for shadowed guests

2022-08-12 Thread Jan Beulich
For guests in shadow mode the P2M table gets used only by software. The only place where it matters whether superpages in the P2M can be dealt with is sh_unshadow_for_p2m_change(): The table is never made accessible to hardware for address translation, and the only checks of _PAGE_PSE in P2M

[PATCH v3 3/4] x86/shadow: slightly consolidate sh_unshadow_for_p2m_change() (part III)

2022-08-12 Thread Jan Beulich
In preparation for reactivating the presently dead 2M page path of the function, also deal with the case of replacing an L1 page table all in one go. Note that the prior comparing of MFNs to bypass the removal of shadows was insufficient (but kind of benign, for being dead code so far) - at the

[PATCH v3 2/4] x86/shadow: slightly consolidate sh_unshadow_for_p2m_change() (part II)

2022-08-12 Thread Jan Beulich
Pull common checks out of the switch(). This includes extending a _PAGE_PRESENT check to L1 as well, which presumably was deemed redundant with p2m_is_valid() || p2m_is_grant(), but I think we are better off being explicit in all cases. Note that for L2 (or higher) the grant check isn't strictly

[PATCH v3 1/4] x86/shadow: slightly consolidate sh_unshadow_for_p2m_change() (part I)

2022-08-12 Thread Jan Beulich
Replace a p2m_is_ram() check in the 2M case by an explicit _PAGE_PRESENT one, to make more obvious that the subsequent l1e_get_mfn() actually retrieves something that really is an MFN. It doesn't really matter whether it's RAM, as the subsequent comparison with the original MFN is going to lead to

[PATCH v3 0/4] x86/P2M: allow 2M superpage use for shadowed guests

2022-08-12 Thread Jan Beulich
I did notice this anomaly in the context of IOMMU side work. 1: shadow: slightly consolidate sh_unshadow_for_p2m_change() (part I) 2: shadow: slightly consolidate sh_unshadow_for_p2m_change() (part II) 3: shadow: slightly consolidate sh_unshadow_for_p2m_change() (part III) 4: P2M: allow 2M

Re: [PATCH 2/2] x86/svm: Keep the RAS balanced for guests

2022-08-12 Thread Jan Beulich
On 11.08.2022 21:59, Andrew Cooper wrote: > One source of lost performance was that fact that to protect Xen from a > malicious guests, we had to flush the RAS. > > It turns out that CET Shadow Stacks give us enough architectural guarantees to > construct a lower overhead mitigation, which keeps

Re: [PATCH 1/2] x86/svm: Remove regs param from asm-called functions

2022-08-12 Thread Jan Beulich
On 11.08.2022 21:59, Andrew Cooper wrote: > A optimisation is going to want to conditionally have extra data on the stack > around VMExit. > > We could alternative between `mov %rsp, %rdi` and `lea 8(%rsp), %rdi`, but it > is easier just to make the functions void and let the compiler do the (not

Re: [PATCH] x86/msi: Switch msi_info to using pci_sbdf_t

2022-08-12 Thread Jan Beulich
On 11.08.2022 18:37, Andrew Cooper wrote: > This reorders the fields in msi_info, but removes all the under-the-hood > parameter shuffling required to call pci_get_pdev(). > > No functional change. > > Signed-off-by: Andrew Cooper Oh, you've made the requested change yourself - thanks!

[ovmf test] 172406: regressions - FAIL

2022-08-12 Thread osstest service owner
flight 172406 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172406/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 172136 build-amd64-libvirt

[linux-linus test] 172395: regressions - trouble: blocked/broken/fail/pass

2022-08-12 Thread osstest service owner
flight 172395 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/172395/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit2 broken test-armhf-armhf-xl-credit2 5

Re: [PATCH 0/2] templates/linux_xen: Properly handle multiple initrd files

2022-08-12 Thread Juergen Gross
On 11.08.22 21:10, Mauricio Faria de Oliveira wrote: Adding the xen-devel list as requested in grub-devel [0]: On Thu, Aug 11, 2022 at 1:51 PM Daniel Kiper wrote: In general patches LGTM. However, I would prefer to hear an opinion from Xen folks too. So, please repost the patch set and add