Re: [PATCH v3 3/3] xen/cppcheck: globally suppress unusedStructMember

2023-03-03 Thread Luca Fancellu
> On 3 Mar 2023, at 20:55, Stefano Stabellini wrote: > > On Fri, 3 Mar 2023, Luca Fancellu wrote: >> unusedStructMember warnings from cppcheck are not reliable and >> are causing a lot of false positives, suppress the checker >> globally for now. >> >> Signed-off-by: Luca Fancellu > >

[xen-unstable test] 179067: tolerable trouble: fail/pass/starved

2023-03-03 Thread osstest service owner
flight 179067 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/179067/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-migrupgrade 10 xen-install/src_host fail in 179018 pass in 179067 test-amd64-amd64-xl-qcow2

Re: IRQ affinity not working on Xen pci-platform device

2023-03-03 Thread Thomas Gleixner
David! On Fri, Mar 03 2023 at 16:54, David Woodhouse wrote: > On Fri, 2023-03-03 at 17:51 +0100, Thomas Gleixner wrote: >> > >> > [    0.577173] ACPI: \_SB_.LNKC: Enabled at IRQ 11 >> > [    0.578149] The affinity mask was 0-3 >> > [    0.579081] The affinity mask is 0-3 and the handler is on 2

[PATCH v2 2/2] automation: introduce a dom0less test run on Xilinx hardware

2023-03-03 Thread Stefano Stabellini
From: Stefano Stabellini The test prepares dom0 and domU binaries and boot artifacts, similarly to the existing QEMU test. (TBD: share preparation steps with the regular QEMU tests.) However, instead of running the test inside QEMU as usual, it copies the binaries to the tftp server root,

[PATCH v2 1/2] automation: add Ubuntu container for Xilinx hardware tests

2023-03-03 Thread Stefano Stabellini
From: Stefano Stabellini This container is only run on the controller PC (x86) to trigger the test on a connected Xilinx ZCU102 physical board. Signed-off-by: Stefano Stabellini --- .../build/ubuntu/xenial-xilinx.dockerfile | 25 +++ 1 file changed, 25 insertions(+)

[PATCH v2 0/2] automation: introduce a Xilinx hardware test

2023-03-03 Thread Stefano Stabellini
Hi all, This short patch series introduces the first Xen gitlab-ci test run on real hardware: a physical Xilinx ZCU102 board. The gitlab container is run on a workstation physically connected to a ZCU102 board. The test script looks very similar to a regular QEMU test script, except that at the

[xen-4.16-testing test] 179065: tolerable trouble: fail/pass/starved - PUSHED

2023-03-03 Thread osstest service owner
flight 179065 xen-4.16-testing real [real] flight 179130 xen-4.16-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/179065/ http://logs.test-lab.xenproject.org/osstest/logs/179130/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking):

Re: [PATCH v3 3/3] xen/cppcheck: globally suppress unusedStructMember

2023-03-03 Thread Stefano Stabellini
On Fri, 3 Mar 2023, Luca Fancellu wrote: > unusedStructMember warnings from cppcheck are not reliable and > are causing a lot of false positives, suppress the checker > globally for now. > > Signed-off-by: Luca Fancellu Reviewed-by: Stefano Stabellini This is great! Results are much cleaner.

Re: [PATCH v3 1/3] xen/cppcheck: add a way to exclude files from the scan

2023-03-03 Thread Stefano Stabellini
On Fri, 3 Mar 2023, Luca Fancellu wrote: > Add a way to exclude files from the scan, in this way we can skip > some findings from the report on those files that Xen doesn't own. > > To do that, introduce the exclude-list.json file under docs/misra, > this file will be populated with relative path

Re: [RFC XEN PATCH 0/7] automation, RFC prototype, Have GitLab CI built its own containers

2023-03-03 Thread Stefano Stabellini
On Fri, 3 Mar 2023, Anthony PERARD wrote: > On Thu, Mar 02, 2023 at 06:48:35PM -0800, Stefano Stabellini wrote: > > On Thu, 2 Mar 2023, Anthony PERARD wrote: > > > Patch series available in this git branch: > > > https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git > > >

Re: [XEN PATCH] automation: Use --no-install-recommends and -slim base for debian/unstable

2023-03-03 Thread Stefano Stabellini
On Fri, 3 Mar 2023, Anthony PERARD wrote: > Use "--no-install-recommends" to avoid installing many packages that > aren't needed, many are *-doc packages. Also start using the -slim > base image as they remove a few unused files/directories, like docs/. > > Explicitly install "ca-certificates" as

Re: [PATCH] automation: Drop sles11sp4 dockerfile

2023-03-03 Thread Stefano Stabellini
On Fri, 3 Mar 2023, Michal Orzel wrote: > It has reached EOL and there are no jobs using it on any branch. > > Signed-off-by: Michal Orzel Reviewed-by: Stefano Stabellini > --- > We can also safely remove sles containers from registry. > --- > automation/build/suse/sles11sp4.dockerfile | 20

[xen-4.17-testing test] 179062: tolerable trouble: fail/pass/starved - PUSHED

2023-03-03 Thread osstest service owner
flight 179062 xen-4.17-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/179062/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 178227

Re: [PATCH 1/2] x86/cpuid: Infrastructure for leaves 7:1{ecx,edx}

2023-03-03 Thread Andrew Cooper
On 03/03/2023 7:23 am, Jan Beulich wrote: > On 04.01.2023 12:11, Andrew Cooper wrote: >> --- a/xen/include/public/arch-x86/cpufeatureset.h >> +++ b/xen/include/public/arch-x86/cpufeatureset.h >> @@ -288,6 +288,9 @@ XEN_CPUFEATURE(NSCB, 11*32+ 6) /*A Null >> Selector Clears Base

Re: [PATCH 4/7] md: simplify sysctl registration

2023-03-03 Thread Song Liu
On Thu, Mar 2, 2023 at 12:46 PM Luis Chamberlain wrote: > > register_sysctl_table() is a deprecated compatibility wrapper. > register_sysctl() can do the directory creation for you so just use > that. > > Signed-off-by: Luis Chamberlain Acked-by: Song Liu Thanks!

Re: [XEN PATCH v7 17/20] xen/arm: ffa: add ABI structs for sharing memory

2023-03-03 Thread Jens Wiklander
Hi Bertrand, On Fri, Mar 3, 2023 at 3:20 PM Bertrand Marquis wrote: > > Hi Jens, > > > On 22 Feb 2023, at 16:33, Jens Wiklander wrote: > > > > Adds the ABI structs used by function FFA_MEM_SHARE and friends for > > sharing memory. > > > > Signed-off-by: Jens Wiklander > > All the structures

Re: [RFC XEN PATCH 0/7] automation, RFC prototype, Have GitLab CI built its own containers

2023-03-03 Thread Anthony PERARD
On Thu, Mar 02, 2023 at 06:48:35PM -0800, Stefano Stabellini wrote: > On Thu, 2 Mar 2023, Anthony PERARD wrote: > > Patch series available in this git branch: > > https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git > > br.gitlab-containers-auto-rebuild-v1 > > > > Hi, > > > > I have

Re: IRQ affinity not working on Xen pci-platform device

2023-03-03 Thread David Woodhouse
On Fri, 2023-03-03 at 17:51 +0100, Thomas Gleixner wrote: > David! > > On Fri, Mar 03 2023 at 15:16, David Woodhouse wrote: > > I added the 'xen_no_vector_callback' kernel parameter a while back > > (commit b36b0fe96af) to ensure we could test that more for Linux > > guests. > > > > Most of my

[XEN PATCH] automation: Use --no-install-recommends and -slim base for debian/unstable

2023-03-03 Thread Anthony PERARD
Use "--no-install-recommends" to avoid installing many packages that aren't needed, many are *-doc packages. Also start using the -slim base image as they remove a few unused files/directories, like docs/. Explicitly install "ca-certificates" as it is only recommended for "wget". Explicitly

Re: IRQ affinity not working on Xen pci-platform device

2023-03-03 Thread Thomas Gleixner
David! On Fri, Mar 03 2023 at 15:16, David Woodhouse wrote: > I added the 'xen_no_vector_callback' kernel parameter a while back > (commit b36b0fe96af) to ensure we could test that more for Linux > guests. > > Most of my testing at the time was done with just two CPUs, and I > happened to just

Re: [XEN PATCH v7 16/20] xen/arm: ffa: add defines for sharing memory

2023-03-03 Thread Jens Wiklander
Hi Bertrand, On Fri, Mar 3, 2023 at 2:38 PM Bertrand Marquis wrote: > > Hi Jens, > > > On 22 Feb 2023, at 16:33, Jens Wiklander wrote: > > > > Adds defines needed for sharing using the function FFA_MEM_SHARE and > > friends. > > > > Signed-off-by: Jens Wiklander > > --- > >

RE : Weekly meeting - Xen Gitlab Issues Review

2023-03-03 Thread Marc Ungeschikts
 2023-03-03 Report minutes Xen Gitlab Issues review meeting: https://cryptpad.fr/pad/#/2/pad/edit/GBcZpfFD5WELm7mdE2C-anKD/  For next Week 2023-03-10 14 :00 UTC : https://cryptpad.fr/pad/#/2/pad/edit/HkzaJDwKHunUzETuQRTswj6F/ and https://meet.jit.si/XenIssuesReview Marc

Backports for stable branches

2023-03-03 Thread Andrew Cooper
Hello, Two python bugfixes which definitely qualify for backport: 897257ba49d0 tools/python: change 's#' size type for Python >= 3.10 3a59443c1d5a tools/xenmon: Fix xenmon.py for with python3.x Next, I'm going to argue for taking: f7d07619d2ae x86/vmx: implement VMExit based guest Bus Lock

Re: [XEN PATCH v7 14/20] xen/arm: ffa: support guest FFA_PARTITION_INFO_GET

2023-03-03 Thread Jens Wiklander
Hi, On Fri, Mar 3, 2023 at 2:50 PM Bertrand Marquis wrote: > > > > > On 3 Mar 2023, at 14:17, Jens Wiklander wrote: > > > > Hi Bertrand, > > > > On Fri, Mar 3, 2023 at 10:51 AM Bertrand Marquis > > wrote: > >> > >> Hi Jens, > >> > >>> On 22 Feb 2023, at 16:33, Jens Wiklander > >>> wrote: >

Re: [XEN PATCH backport for-4.15] tools: Drop gettext as a build dependency

2023-03-03 Thread Andrew Cooper
On 03/03/2023 2:55 pm, Anthony PERARD wrote: > From: Andrew Cooper > > It has not been a dependency since at least 4.13. Remove its mandatory check > from ./configure. > > Annotate the dependency in the CI dockerfiles, and drop them from CirrusCI and > TravisCI. > > Signed-off-by: Andrew Cooper

IRQ affinity not working on Xen pci-platform device

2023-03-03 Thread David Woodhouse
I added the 'xen_no_vector_callback' kernel parameter a while back (commit b36b0fe96af) to ensure we could test that more for Linux guests. Most of my testing at the time was done with just two CPUs, and I happened to just test it with four. It fails, because the IRQ isn't actually affine to

[libvirt test] 179049: tolerable trouble: pass/starved - PUSHED

2023-03-03 Thread osstest service owner
flight 179049 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/179049/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt-xsm 15 migrate-support-checkfail never pass test-amd64-i386-libvirt-xsm 15

[XEN PATCH backport for-4.15] tools: Drop gettext as a build dependency

2023-03-03 Thread Anthony PERARD
From: Andrew Cooper It has not been a dependency since at least 4.13. Remove its mandatory check from ./configure. Annotate the dependency in the CI dockerfiles, and drop them from CirrusCI and TravisCI. Signed-off-by: Andrew Cooper Acked-by: Roger Pau Monné (cherry picked from commit

Re: [XEN PATCH v7 17/20] xen/arm: ffa: add ABI structs for sharing memory

2023-03-03 Thread Bertrand Marquis
Hi Jens, > On 22 Feb 2023, at 16:33, Jens Wiklander wrote: > > Adds the ABI structs used by function FFA_MEM_SHARE and friends for > sharing memory. > > Signed-off-by: Jens Wiklander All the structures are coherent with the spec. Just one small question after but independent if you choose

Re: [XEN PATCH v7 14/20] xen/arm: ffa: support guest FFA_PARTITION_INFO_GET

2023-03-03 Thread Bertrand Marquis
> On 3 Mar 2023, at 14:17, Jens Wiklander wrote: > > Hi Bertrand, > > On Fri, Mar 3, 2023 at 10:51 AM Bertrand Marquis > wrote: >> >> Hi Jens, >> >>> On 22 Feb 2023, at 16:33, Jens Wiklander wrote: >>> >>> Adds support in the mediator to handle FFA_PARTITION_INFO_GET requests >>> from a

Re: [XEN PATCH v7 16/20] xen/arm: ffa: add defines for sharing memory

2023-03-03 Thread Bertrand Marquis
Hi Jens, > On 22 Feb 2023, at 16:33, Jens Wiklander wrote: > > Adds defines needed for sharing using the function FFA_MEM_SHARE and > friends. > > Signed-off-by: Jens Wiklander > --- > xen/arch/arm/tee/ffa.c | 57 ++ > 1 file changed, 57 insertions(+) >

[linux-linus test] 179044: regressions - trouble: fail/pass/starved

2023-03-03 Thread osstest service owner
flight 179044 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/179044/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 178042

Re: [XEN PATCH v7 15/20] xen/arm: move regpair_to_uint64() and uint64_to_regpair() to regs.h

2023-03-03 Thread Jens Wiklander
On Fri, Mar 3, 2023 at 11:51 AM Bertrand Marquis wrote: > > Hi Jens, > > > On 22 Feb 2023, at 16:33, Jens Wiklander wrote: > > > > Moves the two helper functions regpair_to_uint64() and > > uint64_to_regpair() from xen/arch/arm/tee/optee.c to the common arm > > specific regs.h. This enables

Re: [XEN PATCH v7 14/20] xen/arm: ffa: support guest FFA_PARTITION_INFO_GET

2023-03-03 Thread Jens Wiklander
Hi Bertrand, On Fri, Mar 3, 2023 at 10:51 AM Bertrand Marquis wrote: > > Hi Jens, > > > On 22 Feb 2023, at 16:33, Jens Wiklander wrote: > > > > Adds support in the mediator to handle FFA_PARTITION_INFO_GET requests > > from a guest. The requests are forwarded to the SPMC and the response is > >

Re: [PATCH] automation: Drop sles11sp4 dockerfile

2023-03-03 Thread Andrew Cooper
On 03/03/2023 12:53 pm, Michal Orzel wrote: > It has reached EOL and there are no jobs using it on any branch. > > Signed-off-by: Michal Orzel Acked-by: Andrew Cooper I'll drop the registry tags when I commit this.

[PATCH] automation: Drop sles11sp4 dockerfile

2023-03-03 Thread Michal Orzel
It has reached EOL and there are no jobs using it on any branch. Signed-off-by: Michal Orzel --- We can also safely remove sles containers from registry. --- automation/build/suse/sles11sp4.dockerfile | 20 1 file changed, 20 deletions(-) delete mode 100644

Re: [PATCH] automation: Add missing and drop obsoleted aliases from containerize

2023-03-03 Thread Michal Orzel
On 03/03/2023 13:21, Michal Orzel wrote: > > > On 03/03/2023 13:13, Andrew Cooper wrote: >> >> >> On 03/03/2023 12:09 pm, Michal Orzel wrote: >>> >>> On 03/03/2023 12:59, Andrew Cooper wrote: On 01/03/2023 9:06 am, Michal Orzel wrote: > Add missing aliases for: > -

Re: [PATCH] automation: Add missing and drop obsoleted aliases from containerize

2023-03-03 Thread Michal Orzel
On 03/03/2023 13:13, Andrew Cooper wrote: > > > On 03/03/2023 12:09 pm, Michal Orzel wrote: >> >> On 03/03/2023 12:59, Andrew Cooper wrote: >>> >>> On 01/03/2023 9:06 am, Michal Orzel wrote: Add missing aliases for: - debian:unstable-cppcheck -

Re: [PATCH] automation: Add missing and drop obsoleted aliases from containerize

2023-03-03 Thread Andrew Cooper
On 03/03/2023 12:09 pm, Michal Orzel wrote: > > On 03/03/2023 12:59, Andrew Cooper wrote: >> >> On 01/03/2023 9:06 am, Michal Orzel wrote: >>> Add missing aliases for: >>> - debian:unstable-cppcheck >>> - debian:unstable-arm64v8-arm32-gcc >>> - ubuntu:bionic >>> >>> Remove aliases for no longer

Re: [PATCH] automation: Add missing and drop obsoleted aliases from containerize

2023-03-03 Thread Michal Orzel
On 03/03/2023 12:59, Andrew Cooper wrote: > > > On 01/03/2023 9:06 am, Michal Orzel wrote: >> Add missing aliases for: >> - debian:unstable-cppcheck >> - debian:unstable-arm64v8-arm32-gcc >> - ubuntu:bionic >> >> Remove aliases for no longer used containers: >> - centos:7.2 >> -

Re: [PATCH] automation: Add missing and drop obsoleted aliases from containerize

2023-03-03 Thread Andrew Cooper
On 01/03/2023 9:06 am, Michal Orzel wrote: > Add missing aliases for: > - debian:unstable-cppcheck > - debian:unstable-arm64v8-arm32-gcc > - ubuntu:bionic > > Remove aliases for no longer used containers: > - centos:7.2 > - debian:unstable-arm32-gcc > > Modify docs to refer to CentOS 7

Re: [PATCH v5 3/4] xen/arm: switch ARM to use generic implementation of bug.h

2023-03-03 Thread Oleksii
On Fri, 2023-03-03 at 12:29 +0100, Jan Beulich wrote: > On 03.03.2023 11:38, Oleksii Kurochko wrote: > > The following changes were made: > > * make GENERIC_BUG_FRAME mandatory for ARM > > * As do_bug_frame() returns -EINVAL in case something goes wrong > >   otherwise id of bug frame. Thereby

Re: [PATCH v2 4/6] docs/about/deprecated: Deprecate the qemu-system-arm binary

2023-03-03 Thread Daniel P . Berrangé
On Fri, Mar 03, 2023 at 12:31:42PM +0100, Thomas Huth wrote: > On 03/03/2023 12.16, Peter Maydell wrote: > > On Thu, 2 Mar 2023 at 16:31, Thomas Huth wrote: > > > > > > qemu-system-aarch64 is a proper superset of qemu-system-arm, > > > and the latter was mainly still required for 32-bit KVM

Re: [PATCH v2 4/6] docs/about/deprecated: Deprecate the qemu-system-arm binary

2023-03-03 Thread Thomas Huth
On 03/03/2023 12.16, Peter Maydell wrote: On Thu, 2 Mar 2023 at 16:31, Thomas Huth wrote: qemu-system-aarch64 is a proper superset of qemu-system-arm, and the latter was mainly still required for 32-bit KVM support. But this 32-bit KVM arm support has been dropped in the Linux kernel a couple

Re: [PATCH v5 3/4] xen/arm: switch ARM to use generic implementation of bug.h

2023-03-03 Thread Jan Beulich
On 03.03.2023 11:38, Oleksii Kurochko wrote: > The following changes were made: > * make GENERIC_BUG_FRAME mandatory for ARM > * As do_bug_frame() returns -EINVAL in case something goes wrong > otherwise id of bug frame. Thereby 'if' cases where do_bug_frame() was > updated to check if the

Re: [PATCH v2 0/6] Deprecate support for 32-bit x86 and arm hosts

2023-03-03 Thread Peter Maydell
On Fri, 3 Mar 2023 at 11:09, John Paul Adrian Glaubitz wrote: > > Hello! > > On Fri, 2023-03-03 at 10:48 +0100, Thomas Huth wrote: > > x86 ==> deprecate both, user and system emulation support on > > 32-bit hosts > > arm ==> deprecate only system emulation on 32-bit hosts. > > I would

Re: [PATCH v2 0/6] Deprecate support for 32-bit x86 and arm hosts

2023-03-03 Thread Thomas Huth
On 03/03/2023 12.09, John Paul Adrian Glaubitz wrote: Hello! On Fri, 2023-03-03 at 10:48 +0100, Thomas Huth wrote: x86 ==> deprecate both, user and system emulation support on 32-bit hosts arm ==> deprecate only system emulation on 32-bit hosts. I would recommend against dropping

Re: [PATCH v2 4/6] docs/about/deprecated: Deprecate the qemu-system-arm binary

2023-03-03 Thread Peter Maydell
On Thu, 2 Mar 2023 at 16:31, Thomas Huth wrote: > > qemu-system-aarch64 is a proper superset of qemu-system-arm, > and the latter was mainly still required for 32-bit KVM support. > But this 32-bit KVM arm support has been dropped in the Linux > kernel a couple of years ago already, so we don't

Re: [PATCH v3 3/3] xen/riscv: initialize .bss section

2023-03-03 Thread Oleksii
On Fri, 2023-03-03 at 10:53 +, Andrew Cooper wrote: > On 03/03/2023 10:42 am, Oleksii wrote: > > On Fri, 2023-03-03 at 10:33 +, Andrew Cooper wrote: > > > On 03/03/2023 10:24 am, Oleksii Kurochko wrote: > > > > Signed-off-by: Oleksii Kurochko > > > Reviewed-by: Andrew Cooper > > > > > >

Re: [PATCH v3 3/3] xen/riscv: initialize .bss section

2023-03-03 Thread Andrew Cooper
On 03/03/2023 10:42 am, Oleksii wrote: > On Fri, 2023-03-03 at 10:33 +, Andrew Cooper wrote: >> On 03/03/2023 10:24 am, Oleksii Kurochko wrote: >>> Signed-off-by: Oleksii Kurochko >> Reviewed-by: Andrew Cooper >> >>> diff --git a/xen/arch/riscv/riscv64/head.S >>>

Re: [XEN PATCH v7 15/20] xen/arm: move regpair_to_uint64() and uint64_to_regpair() to regs.h

2023-03-03 Thread Bertrand Marquis
Hi Jens, > On 22 Feb 2023, at 16:33, Jens Wiklander wrote: > > Moves the two helper functions regpair_to_uint64() and > uint64_to_regpair() from xen/arch/arm/tee/optee.c to the common arm > specific regs.h. This enables reuse of these functions in the FF-A > mediator in a subsequent patch. > >

Re: [PATCH v3 2/3] xen/riscv: read/save hart_id and dtb_base passed by bootloader

2023-03-03 Thread Oleksii
On Fri, 2023-03-03 at 10:27 +, Andrew Cooper wrote: > On 03/03/2023 10:24 am, Oleksii Kurochko wrote: > > Signed-off-by: Oleksii Kurochko > > Reviewed-by: Andrew Cooper , although it > occurs to me... > > > diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c > > index

Re: [PATCH v3 3/3] xen/riscv: initialize .bss section

2023-03-03 Thread Oleksii
On Fri, 2023-03-03 at 10:33 +, Andrew Cooper wrote: > On 03/03/2023 10:24 am, Oleksii Kurochko wrote: > > Signed-off-by: Oleksii Kurochko > > Reviewed-by: Andrew Cooper > > > diff --git a/xen/arch/riscv/riscv64/head.S > > b/xen/arch/riscv/riscv64/head.S > > index adf5d6c74a..8887f0cbd4

[PATCH v5 3/4] xen/arm: switch ARM to use generic implementation of bug.h

2023-03-03 Thread Oleksii Kurochko
The following changes were made: * make GENERIC_BUG_FRAME mandatory for ARM * As do_bug_frame() returns -EINVAL in case something goes wrong otherwise id of bug frame. Thereby 'if' cases where do_bug_frame() was updated to check if the returned value is less than 0 * Switch ARM's

[PATCH v5 1/4] xen: introduce CONFIG_GENERIC_BUG_FRAME

2023-03-03 Thread Oleksii Kurochko
A large part of the content of the bug.h is repeated among all architectures, so it was decided to create a new config CONFIG_GENERIC_BUG_FRAME. The version of from x86 was taken as the base version. The patch introduces the following stuff: * common bug.h header * generic implementation of

[PATCH v5 4/4] xen/x86: switch x86 to use generic implemetation of bug.h

2023-03-03 Thread Oleksii Kurochko
The following changes were made: * Make GENERIC_BUG_FRAME mandatory for X86 * Update asm/bug.h using generic implementation in * Change prototype of debugger_trap_fatal() in asm/debugger.h to align it with generic prototype in . * Update do_invalid_op using generic do_bug_frame()

[PATCH v5 2/4] xen: change to

2023-03-03 Thread Oleksii Kurochko
The idea of the patch is to change all to and keep Xen compilable with adding only minimal amount of changes: 1. It was added "#include " to ARM's "" as it uses uint_{16,32}t in 'struct bug_frame'. 2. It was added '#define BUG_FRAME_STRUCT' which means that ARM hasn't been switched to

[PATCH v5 0/4] introduce generic implementation of macros from bug.h

2023-03-03 Thread Oleksii Kurochko
A large part of the content of the bug.h is repeated among all architectures (especially x86 and RISCV have the same implementation), so it was created a new config CONFIG_GENERIC_BUG_FRAME which is used to introduce generic implementation of do_bug_frame() and move x86's to with the following

Re: [PATCH v3 3/3] xen/riscv: initialize .bss section

2023-03-03 Thread Andrew Cooper
On 03/03/2023 10:24 am, Oleksii Kurochko wrote: > Signed-off-by: Oleksii Kurochko Reviewed-by: Andrew Cooper > diff --git a/xen/arch/riscv/riscv64/head.S b/xen/arch/riscv/riscv64/head.S > index adf5d6c74a..8887f0cbd4 100644 > --- a/xen/arch/riscv/riscv64/head.S > +++

Re: [PATCH v6 3/5] xen/arm64: mm: Introduce helpers to prepare/enable/disable the identity mapping

2023-03-03 Thread Bertrand Marquis
Hi Julien, > On 2 Mar 2023, at 15:59, Julien Grall wrote: > > From: Julien Grall > > In follow-up patches we will need to have part of Xen identity mapped in > order to safely switch the TTBR. > > On some platform, the identity mapping may have to start at 0. If we always > keep the identity

Re: [PATCH v3 2/3] xen/riscv: read/save hart_id and dtb_base passed by bootloader

2023-03-03 Thread Andrew Cooper
On 03/03/2023 10:24 am, Oleksii Kurochko wrote: > Signed-off-by: Oleksii Kurochko Reviewed-by: Andrew Cooper , although it occurs to me... > diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c > index 1c87899e8e..d9723fe1c0 100644 > --- a/xen/arch/riscv/setup.c > +++

Re: [PATCH v3 1/3] xen/riscv: disable fpu

2023-03-03 Thread Andrew Cooper
On 03/03/2023 10:24 am, Oleksii Kurochko wrote: > Disable FPU to detect illegal usage of floating point in kernel > space. > > Signed-off-by: Oleksii Kurochko Acked-by: Andrew Cooper

[PATCH v3 3/3] xen/riscv: initialize .bss section

2023-03-03 Thread Oleksii Kurochko
Signed-off-by: Oleksii Kurochko --- xen/arch/riscv/riscv64/head.S | 9 + xen/arch/riscv/setup.c| 8 2 files changed, 17 insertions(+) diff --git a/xen/arch/riscv/riscv64/head.S b/xen/arch/riscv/riscv64/head.S index adf5d6c74a..8887f0cbd4 100644 ---

[PATCH v3 2/3] xen/riscv: read/save hart_id and dtb_base passed by bootloader

2023-03-03 Thread Oleksii Kurochko
Signed-off-by: Oleksii Kurochko --- Changes since v2: * Add the comment for start() function with the explanation what and how OpenSBI pass to start() function. * Clean up start() code related to read hart_id & dtb_base. --- Changes since v1: * read/save/pass of hart_id and dtb_base

[PATCH v3 0/3] Do basic initialization things

2023-03-03 Thread Oleksii Kurochko
The patch series groups and updates the following patches: 1. xen/riscv: disable fpu 2. xen/riscv: initialize .bss section 3. xen/riscv: read/save hart_id and dtb_base passed by bootloader --- Changes since v2: * Patch [xen/riscv: disable fpu] was moved to the start of start() function to

[PATCH v3 1/3] xen/riscv: disable fpu

2023-03-03 Thread Oleksii Kurochko
Disable FPU to detect illegal usage of floating point in kernel space. Signed-off-by: Oleksii Kurochko --- xen/arch/riscv/riscv64/head.S | 7 +++ 1 file changed, 7 insertions(+) diff --git a/xen/arch/riscv/riscv64/head.S b/xen/arch/riscv/riscv64/head.S index ffd95f9f89..52fa41c778 100644

Re: [XEN PATCH v7 13/20] xen/arm: ffa: support mapping guest RX/TX buffers

2023-03-03 Thread Jens Wiklander
Hi, On Fri, Mar 3, 2023 at 9:16 AM Bertrand Marquis wrote: > > Hi Jens, > > > On 3 Mar 2023, at 08:41, Jens Wiklander wrote: > > > > Hi Bertrand, > > > > On Thu, Mar 2, 2023 at 4:05 PM Bertrand Marquis > > wrote: > >> > >> Hi Jens, > >> > >>> On 22 Feb 2023, at 16:33, Jens Wiklander > >>>

Re: [PATCH v3 3/6] gitlab-ci.d/crossbuilds: Drop the i386 jobs

2023-03-03 Thread Philippe Mathieu-Daudé
On 3/3/23 11:14, Thomas Huth wrote: Hardly anybody still uses 32-bit x86 environments for running QEMU, so let's stop wasting our scarce CI minutes with these jobs. (There are still the 32-bit MinGW and TCI jobs around for having some compile test coverage on 32-bit, and the dockerfile can stay

[PATCH v3 5/6] docs/about/deprecated: Deprecate the qemu-system-arm binary

2023-03-03 Thread Thomas Huth
qemu-system-aarch64 is a proper superset of qemu-system-arm, and the latter was mainly still required for 32-bit KVM support. But this 32-bit KVM arm support has been dropped in the Linux kernel a couple of years ago already, so we don't really need qemu-system-arm anymore, thus deprecated it now.

[PATCH v3 4/6] docs/about/deprecated: Deprecate 32-bit arm hosts for system emulation

2023-03-03 Thread Thomas Huth
For running QEMU in system emulation mode, the user needs a rather strong host system, i.e. not only an embedded low-frequency controller. All recent beefy arm host machines should support 64-bit now, it's unlikely that anybody is still seriously using QEMU on a 32-bit arm CPU, so we deprecate the

[PATCH v3 6/6] gitlab-ci.d/crossbuilds: Drop the 32-bit arm system emulation jobs

2023-03-03 Thread Thomas Huth
Hardly anybody still uses 32-bit arm environments for running QEMU, so let's stop wasting our scarce CI minutes with these jobs. Reviewed-by: Daniel P. Berrangé Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Wilfred Mallawa Signed-off-by: Thomas Huth --- .gitlab-ci.d/crossbuilds.yml | 14

[PATCH v3 0/6] Deprecate support for 32-bit x86 and arm hosts

2023-03-03 Thread Thomas Huth
We're struggling quite badly with our CI minutes on the shared gitlab runners, so we urgently need to think of ways to cut down our supported build and target environments. qemu-system-i386 and qemu-system-arm are not really required anymore, since nobody uses KVM on the corresponding systems for

[PATCH v3 1/6] docs/about/deprecated: Deprecate 32-bit x86 hosts

2023-03-03 Thread Thomas Huth
Hardly anybody still uses 32-bit x86 hosts today, so we should start deprecating them to stop wasting our time and CI minutes here. For example, there are also still some unresolved problems with these: When emulating 64-bit binaries in user mode, TCG does not honor atomicity for 64-bit accesses,

[PATCH v3 2/6] docs/about/deprecated: Deprecate the qemu-system-i386 binary

2023-03-03 Thread Thomas Huth
Aside from not supporting KVM on 32-bit hosts, the qemu-system-x86_64 binary is a proper superset of the qemu-system-i386 binary. With the 32-bit host support being deprecated, it is now also possible to deprecate the qemu-system-i386 binary. With regards to 32-bit KVM support in the x86 Linux

[PATCH v3 3/6] gitlab-ci.d/crossbuilds: Drop the i386 jobs

2023-03-03 Thread Thomas Huth
Hardly anybody still uses 32-bit x86 environments for running QEMU, so let's stop wasting our scarce CI minutes with these jobs. (There are still the 32-bit MinGW and TCI jobs around for having some compile test coverage on 32-bit, and the dockerfile can stay in case someone wants to reproduce a

Re: [PATCH 1/2] automation: arm64: Create a test job for testing static heap on qemu

2023-03-03 Thread Michal Orzel
Hi Jiamei, On 03/03/2023 10:13, Jiamei Xie wrote: > > > Hi Michal, > >> -Original Message- >> From: Michal Orzel >> Sent: Friday, March 3, 2023 3:47 PM >> To: Jiamei Xie ; Stefano Stabellini >> >> Cc: xen-devel@lists.xenproject.org; Wei Chen ; >> Bertrand Marquis ; Doug Goldstein >>

Re: [XEN PATCH v7 14/20] xen/arm: ffa: support guest FFA_PARTITION_INFO_GET

2023-03-03 Thread Bertrand Marquis
Hi Jens, > On 22 Feb 2023, at 16:33, Jens Wiklander wrote: > > Adds support in the mediator to handle FFA_PARTITION_INFO_GET requests > from a guest. The requests are forwarded to the SPMC and the response is > translated according to the FF-A version in use by the guest. > > Using

Re: [PATCH v2 0/6] Deprecate support for 32-bit x86 and arm hosts

2023-03-03 Thread Thomas Huth
On 02/03/2023 23.07, Philippe Mathieu-Daudé wrote: On 2/3/23 17:31, Thomas Huth wrote: We're struggling quite badly with our CI minutes on the shared gitlab runners, so we urgently need to think of ways to cut down our supported build and target environments. qemu-system-i386 and

[PATCH v3 3/3] xen/cppcheck: globally suppress unusedStructMember

2023-03-03 Thread Luca Fancellu
unusedStructMember warnings from cppcheck are not reliable and are causing a lot of false positives, suppress the checker globally for now. Signed-off-by: Luca Fancellu --- Changes from v2: - New patch --- xen/scripts/xen_analysis/cppcheck_analysis.py | 3 +++ 1 file changed, 3 insertions(+)

[PATCH v3 0/3] xen/misra: create exclusion file list

2023-03-03 Thread Luca Fancellu
This serie is introducing an exclusion list for the misra analysis, at the moment only cppcheck can benefit from it because it's the tool where we control every step and configuration. Exclude a file from the analysis is the last step we should do, but sometime it is unavoidable because we can't

[PATCH v3 1/3] xen/cppcheck: add a way to exclude files from the scan

2023-03-03 Thread Luca Fancellu
Add a way to exclude files from the scan, in this way we can skip some findings from the report on those files that Xen doesn't own. To do that, introduce the exclude-list.json file under docs/misra, this file will be populated with relative path to the files/folder to be excluded. Introduce a

[PATCH v3 2/3] xen/misra: add entries to exclude-list.json

2023-03-03 Thread Luca Fancellu
Add entries to the exclude-list.json for those files that need to be excluded from the analysis scan. Signed-off-by: Luca Fancellu Signed-off-by: Michal Orzel Reviewed-by: Stefano Stabellini --- This list is originated from Michal's work here:

RE: [PATCH 1/2] automation: arm64: Create a test job for testing static heap on qemu

2023-03-03 Thread Jiamei Xie
Hi Michal, > -Original Message- > From: Michal Orzel > Sent: Friday, March 3, 2023 3:47 PM > To: Jiamei Xie ; Stefano Stabellini > > Cc: xen-devel@lists.xenproject.org; Wei Chen ; > Bertrand Marquis ; Doug Goldstein > > Subject: Re: [PATCH 1/2] automation: arm64: Create a test job for

Re: [PATCH v2 1/3] xen/riscv: read/save hart_id and dtb_base passed by bootloader

2023-03-03 Thread Oleksii
On Thu, 2023-03-02 at 18:58 +, Andrew Cooper wrote: > On 02/03/2023 2:53 pm, Oleksii wrote: > > On Thu, 2023-03-02 at 14:02 +, Andrew Cooper wrote: > > > On 02/03/2023 1:23 pm, Oleksii Kurochko wrote: > > > > + > > > > +    /* > > > > + * DTB base is passed by a bootloader > >

Re: [XEN PATCH v7 13/20] xen/arm: ffa: support mapping guest RX/TX buffers

2023-03-03 Thread Bertrand Marquis
Hi Jens, > On 3 Mar 2023, at 08:41, Jens Wiklander wrote: > > Hi Bertrand, > > On Thu, Mar 2, 2023 at 4:05 PM Bertrand Marquis > wrote: >> >> Hi Jens, >> >>> On 22 Feb 2023, at 16:33, Jens Wiklander wrote: >>> >>> Adds support in the mediator to map and unmap the RX and TX buffers >>>

Re: [XEN PATCH v7 07/20] xen/arm: ffa: add defines for framework direct request/response messages

2023-03-03 Thread Bertrand Marquis
HI Jens, > On 3 Mar 2023, at 08:01, Jens Wiklander wrote: > > Hi Bertrand, > > On Fri, Feb 24, 2023 at 10:39 AM Bertrand Marquis > wrote: >> >> Hi Jens, >> >>> On 22 Feb 2023, at 16:33, Jens Wiklander wrote: >>> >>> Adds defines for framework direct request/response messages. >>> >>>

Re: [virtio-dev] [RFC QEMU] docs: vhost-user: Add custom memory mapping support

2023-03-03 Thread Viresh Kumar
On 01-03-23, 10:47, Stefan Hajnoczi wrote: > Resend - for some reason my email didn't make it out. How about this (will send a formal patch later). Author: Viresh Kumar Date: Tue Feb 21 14:36:30 2023 +0530 docs: vhost-user: Add Xen specific memory mapping support The current model