Re: [PATCH v3 2/2] automation: introduce a dom0less test run on Xilinx hardware

2023-03-06 Thread Michal Orzel
Hi Stefano, On 07/03/2023 00:33, Stefano Stabellini wrote: > > > From: Stefano Stabellini > > The test prepares dom0 and domU binaries and boot artifacts, similarly > to the existing QEMU test. (TBD: share preparation steps with the > regular QEMU tests.) > > However, instead of running the

[linux-linus test] 179417: regressions - trouble: broken/fail/pass/starved

2023-03-06 Thread osstest service owner
flight 179417 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/179417/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-coresched-amd64-xl broken test-amd64-amd64-xl-pvshim 14

[PATCH 2/2] xen: update CONFIG_DEBUG_INFO help text

2023-03-06 Thread Juergen Gross
Update the help text of the CONFIG_DEBUG_INFO option to be a little bit more specific. Signed-off-by: Juergen Gross --- xen/Kconfig.debug | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/xen/Kconfig.debug b/xen/Kconfig.debug index a2691f4239..20c73ee55a 100644 ---

[PATCH 1/2] xen: move CONFIG_DEBUG_INFO out of EXPERT section

2023-03-06 Thread Juergen Gross
In order to support hypervisor analysis of crash dumps, xen-syms needs to contain debug_info. It should be allowed to configure the hypervisor to be built with CONFIG_DEBUG_INFO in non-debug builds without having to enable EXPERT. Using a rather oldish gcc (7.5) it was verified that code

[PATCH 0/2] xen: some CONFIG_DEBUG_INFO changes

2023-03-06 Thread Juergen Gross
Enabling crash dump analysis of the hypervisor requires the hypervisor having been built with CONFIG_DEBUG_INFO enabled. Today this requires either CONFIG_DEBUG or CONFIG_EXPERT set, which are both not security supported. This small series changes that in order to allow security supported Xen

Re: [PATCH V2] docs: vhost-user: Add Xen specific memory mapping support

2023-03-06 Thread Viresh Kumar
On 06-03-23, 10:34, Stefan Hajnoczi wrote: > On Mon, Mar 06, 2023 at 04:40:24PM +0530, Viresh Kumar wrote: > > +Xen mmap description > > + > > + > > ++---+---+ > > +| flags | domid | > > ++---+---+ > > + > > +:flags: 64-bit bit field > > + > > +- Bit 0 is set

Re: [PATCH v4 4/5] docs/about/deprecated: Deprecate 32-bit arm hosts for system emulation

2023-03-06 Thread Richard Henderson
On 3/6/23 00:46, Thomas Huth wrote: +continuous to be supported on 32-bit arm hosts, too) "continues" Acked-by: Richard Henderson r~

[xen-unstable test] 179392: tolerable trouble: fail/pass/starved - PUSHED

2023-03-06 Thread osstest service owner
flight 179392 xen-unstable real [real] flight 179435 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/179392/ http://logs.test-lab.xenproject.org/osstest/logs/179435/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking):

[PATCH v3 2/2] automation: introduce a dom0less test run on Xilinx hardware

2023-03-06 Thread Stefano Stabellini
From: Stefano Stabellini The test prepares dom0 and domU binaries and boot artifacts, similarly to the existing QEMU test. (TBD: share preparation steps with the regular QEMU tests.) However, instead of running the test inside QEMU as usual, it copies the binaries to the tftp server root,

[PATCH v3 1/2] automation: add Ubuntu container for Xilinx hardware tests

2023-03-06 Thread Stefano Stabellini
From: Stefano Stabellini This container is only run on the controller PC (x86) to trigger the test on a connected Xilinx ZCU102 physical board. Signed-off-by: Stefano Stabellini Reviewed-by: Michal Orzel --- Changes in v3: - improve in-code comment - add reviewed-by ---

[PATCH v3 0/2] automation: introduce a Xilinx hardware test

2023-03-06 Thread Stefano Stabellini
Hi all, This short patch series introduces the first Xen gitlab-ci test run on real hardware: a physical Xilinx ZCU102 board. The gitlab container is run on a workstation physically connected to a ZCU102 board. The test script looks very similar to a regular QEMU test script, except that at the

Re: [PATCH v2 2/2] automation: introduce a dom0less test run on Xilinx hardware

2023-03-06 Thread Stefano Stabellini
On Mon, 6 Mar 2023, Michal Orzel wrote: > Hi Stefano, > > On 04/03/2023 00:57, Stefano Stabellini wrote: > > > > > > From: Stefano Stabellini > > > > The test prepares dom0 and domU binaries and boot artifacts, similarly > > to the existing QEMU test. (TBD: share preparation steps with the >

Re: [PATCH v2 2/2] automation: introduce a dom0less test run on Xilinx hardware

2023-03-06 Thread Stefano Stabellini
On Mon, 6 Mar 2023, Andrew Cooper wrote: > On 03/03/2023 11:57 pm, Stefano Stabellini wrote: > > + only: > > +variables: > > + - $XILINX_JOBS == "true" && $CI_COMMIT_REF_PROTECTED == "true" > > We don't want to protect every branch of a tree that only a select > number of people can

[PATCH v4 3/3] xl/libxl: Add OEM string support to smbios

2023-03-06 Thread Jason Andryuk
Add support for OEM strings in the SMBIOS type 11. hvmloader checks them sequentially, so hide the implementation detail. Allow multiple plain oem= items and assign the numeric values internally. Signed-off-by: Jason Andryuk --- v3: Add } from patch 2 to parse_config_data Use EXIT_FAILURE Print

[PATCH v4 2/3] xl/libxl: Add ability to specify SMBIOS strings

2023-03-06 Thread Jason Andryuk
hvm_xs_strings.h specifies xenstore entries which can be used to set or override smbios strings. hvmloader has support for reading them, but xl/libxl support is not wired up. Allow specifying the strings with the new xl.cfg option: smbios=["bios_vendor=Xen Project","system_version=1.0"] In

[PATCH v4 0/3] libxl smbios support

2023-03-06 Thread Jason Andryuk
hvm_xs_strings.h specifies xenstore entries which can be used to set or override smbios strings. hvmloader has support for reading them, but xl/libxl support is not wired up. This patches adds a new xl.cfg option and libxl support to write the xenstore strings. The xl syntax looks like:

[PATCH v4 1/3] golang/xenlight: Extend KeyedUnion to support Arrays

2023-03-06 Thread Jason Andryuk
Generation for KeyedUnion types doesn't support Arrays. The smbios support will place an smbios array inside the hvm KeyedUnion, and gentotypes doesn't generate buildable Go code. Have KeyedUnion add an idl.Array check and issue the approriate xenlight_golang_array_to_C and

[linux-linus test] 179372: regressions - trouble: fail/pass/starved

2023-03-06 Thread osstest service owner
flight 179372 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/179372/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-pvshim 14 guest-start fail REGR. vs. 178042

[PATCH v4 05/12] x86/xen: set MTRR state when running as Xen PV initial domain

2023-03-06 Thread Juergen Gross
When running as Xen PV initial domain (aka dom0), MTRRs are disabled by the hypervisor, but the system should nevertheless use correct cache memory types. This has always kind of worked, as disabled MTRRs resulted in disabled PAT, too, so that the kernel avoided code paths resulting in

[PATCH v4 00/12] x86/mtrr: fix handling with PAT but without MTRR

2023-03-06 Thread Juergen Gross
This series tries to fix the rather special case of PAT being available without having MTRRs (either due to CONFIG_MTRR being not set, or because the feature has been disabled e.g. by a hypervisor). The main use cases are Xen PV guests and SEV-SNP guests running under Hyper-V. Instead of trying

[PATCH] tools/tests: remove vhpet tests

2023-03-06 Thread Juergen Gross
tools/tests/vhpet tests don't build since ages (at least since 4.10) and they can't be activated from outside of tools/tests/vhpet. Remove them as they seem to be irrelevant. Signed-off-by: Juergen Gross --- Andrew seems to remember that Roger wanted to keep those tests, but this information

Re: [PATCH V2] docs: vhost-user: Add Xen specific memory mapping support

2023-03-06 Thread Stefan Hajnoczi
On Mon, Mar 06, 2023 at 04:40:24PM +0530, Viresh Kumar wrote: > The current model of memory mapping at the back-end works fine where a > standard call to mmap() (for the respective file descriptor) is enough > before the front-end can start accessing the guest memory. > > There are other complex

Re: [PATCH 3/7] hv: simplify sysctl registration

2023-03-06 Thread Wei Liu
On Thu, Mar 02, 2023 at 12:46:08PM -0800, Luis Chamberlain wrote: > register_sysctl_table() is a deprecated compatibility wrapper. > register_sysctl() can do the directory creation for you so just use > that. > > Signed-off-by: Luis Chamberlain Reviewed-by: Wei Liu

Re: [PATCH v4 2/5] docs/about/deprecated: Deprecate the qemu-system-i386 binary

2023-03-06 Thread Daniel P . Berrangé
On Mon, Mar 06, 2023 at 02:25:46PM +, Daniel P. Berrangé wrote: > On Mon, Mar 06, 2023 at 03:18:23PM +0100, Thomas Huth wrote: > > On 06/03/2023 15.06, Daniel P. Berrangé wrote: > > > On Mon, Mar 06, 2023 at 02:48:16PM +0100, Thomas Huth wrote: > > > > On 06/03/2023 10.27, Daniel P. Berrangé

Re: [PATCH v4 2/5] docs/about/deprecated: Deprecate the qemu-system-i386 binary

2023-03-06 Thread Philippe Mathieu-Daudé
On 6/3/23 15:06, Daniel P. Berrangé wrote: On Mon, Mar 06, 2023 at 02:48:16PM +0100, Thomas Huth wrote: On 06/03/2023 10.27, Daniel P. Berrangé wrote: On Mon, Mar 06, 2023 at 09:46:55AM +0100, Thomas Huth wrote: [...] If a 32-bit CPU guest +environment should be enforced, you can switch off

Re: [OSSTEST PATCH] ap-common: Fix qemu.git URL

2023-03-06 Thread Andrew Cooper
On 06/03/2023 1:57 pm, Anthony PERARD wrote: > Cloning from "git://git.qemu.org/qemu.git" haven't work for maybe a > month. > > While "https://git.qemu.org/qemu.git; seems to work, it only redirects > to gitlab.com. > > qemu.org website point to a repo hosted by gitlab.com. > > So, switch to

Re: [PATCH v4 2/5] docs/about/deprecated: Deprecate the qemu-system-i386 binary

2023-03-06 Thread Daniel P . Berrangé
On Mon, Mar 06, 2023 at 03:18:23PM +0100, Thomas Huth wrote: > On 06/03/2023 15.06, Daniel P. Berrangé wrote: > > On Mon, Mar 06, 2023 at 02:48:16PM +0100, Thomas Huth wrote: > > > On 06/03/2023 10.27, Daniel P. Berrangé wrote: > > > > On Mon, Mar 06, 2023 at 09:46:55AM +0100, Thomas Huth wrote: >

Re: API/ABIs: Re: [RFC PATCH v2 0/2] Add a new acquire resource to query vcpu statistics

2023-03-06 Thread Matias Ezequiel Vara Larsen
Hello Andrew and thanks for the comments, please find my comments below. On Thu, Feb 23, 2023 at 07:56:28PM +, Andrew Cooper wrote: > A discussion about forward extensible APIs and ABIs here. > > First, its important to say that this should be "domain stats" and not > just "vcpu stats". 

Re: [PATCH v4 2/5] docs/about/deprecated: Deprecate the qemu-system-i386 binary

2023-03-06 Thread Thomas Huth
On 06/03/2023 15.06, Daniel P. Berrangé wrote: On Mon, Mar 06, 2023 at 02:48:16PM +0100, Thomas Huth wrote: On 06/03/2023 10.27, Daniel P. Berrangé wrote: On Mon, Mar 06, 2023 at 09:46:55AM +0100, Thomas Huth wrote: [...] If a 32-bit CPU guest +environment should be enforced, you can switch

Re: [PATCH v4 2/5] docs/about/deprecated: Deprecate the qemu-system-i386 binary

2023-03-06 Thread Daniel P . Berrangé
On Mon, Mar 06, 2023 at 02:48:16PM +0100, Thomas Huth wrote: > On 06/03/2023 10.27, Daniel P. Berrangé wrote: > > On Mon, Mar 06, 2023 at 09:46:55AM +0100, Thomas Huth wrote: > > > [...] If a 32-bit CPU guest > > > +environment should be enforced, you can switch off the "long mode" CPU > > >

[OSSTEST PATCH] ap-common: Fix qemu.git URL

2023-03-06 Thread Anthony PERARD
Cloning from "git://git.qemu.org/qemu.git" haven't work for maybe a month. While "https://git.qemu.org/qemu.git; seems to work, it only redirects to gitlab.com. qemu.org website point to a repo hosted by gitlab.com. So, switch to "https://gitlab.com/qemu-project/qemu.git;. Signed-off-by:

Re: [PATCH v4 2/5] docs/about/deprecated: Deprecate the qemu-system-i386 binary

2023-03-06 Thread Thomas Huth
On 06/03/2023 10.27, Daniel P. Berrangé wrote: On Mon, Mar 06, 2023 at 09:46:55AM +0100, Thomas Huth wrote: [...] If a 32-bit CPU guest +environment should be enforced, you can switch off the "long mode" CPU +flag, e.g. with ``-cpu max,lm=off``. I had the idea to check this today and this is

[xen-unstable-smoke test] 179381: tolerable trouble: pass/starved - PUSHED

2023-03-06 Thread osstest service owner
flight 179381 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/179381/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: Backports for stable branches

2023-03-06 Thread Andrew Cooper
On 06/03/2023 7:28 am, Jan Beulich wrote: > On 03.03.2023 16:56, Andrew Cooper wrote: >> Two python bugfixes which definitely qualify for backport: >> >> 897257ba49d0 tools/python: change 's#' size type for Python >= 3.10 >> 3a59443c1d5a tools/xenmon: Fix xenmon.py for with python3.x > Queued. I

[PATCH V2] docs: vhost-user: Add Xen specific memory mapping support

2023-03-06 Thread Viresh Kumar
The current model of memory mapping at the back-end works fine where a standard call to mmap() (for the respective file descriptor) is enough before the front-end can start accessing the guest memory. There are other complex cases though where the back-end needs more information and simple mmap()

[xen-unstable test] 179344: tolerable trouble: fail/pass/starved

2023-03-06 Thread osstest service owner
flight 179344 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/179344/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-libvirt-raw 7 xen-installfail pass in 179244 test-amd64-amd64-libvirt-vhd 19

Re: [PATCH v3 0/4] tools: use xen-tools/libs.h for common definitions

2023-03-06 Thread Christian Lindig
> On 6 Mar 2023, at 07:21, Juergen Gross wrote: > > There are some macros defined multiple times in tools. Use only > a single header file for defining those macros and drop the copies. > > V2: > - add patch 1 (Andrew Cooper) > > V3: > - address comments > > Juergen Gross (4): > tools:

Re: [PATCH v5 1/4] xen: introduce CONFIG_GENERIC_BUG_FRAME

2023-03-06 Thread Jan Beulich
On 03.03.2023 11:38, Oleksii Kurochko wrote: > +int do_bug_frame(struct cpu_user_regs *regs, unsigned long pc) > +{ > +const struct bug_frame *bug = NULL; > +const struct virtual_region *region; > +const char *prefix = "", *filename, *predicate; > +unsigned long fixup; > +

Re: [PATCH v5 4/4] xen/x86: switch x86 to use generic implemetation of bug.h

2023-03-06 Thread Jan Beulich
On 03.03.2023 11:38, Oleksii Kurochko wrote: > The following changes were made: > * Make GENERIC_BUG_FRAME mandatory for X86 > * Update asm/bug.h using generic implementation in > * Change prototype of debugger_trap_fatal() in asm/debugger.h > to align it with generic prototype in . Is this

Re: [PATCH v2 2/2] automation: introduce a dom0less test run on Xilinx hardware

2023-03-06 Thread Andrew Cooper
On 03/03/2023 11:57 pm, Stefano Stabellini wrote: > + only: > +variables: > + - $XILINX_JOBS == "true" && $CI_COMMIT_REF_PROTECTED == "true" We don't want to protect every branch of a tree that only a select number of people can push to, nor (for this, or others configured with the

Re: [PATCH v5 2/4] xen: change to

2023-03-06 Thread Jan Beulich
On 03.03.2023 11:38, Oleksii Kurochko wrote: > The idea of the patch is to change all to and > keep Xen compilable with adding only minimal amount of changes: > 1. It was added "#include " to ARM's "" as it > uses uint_{16,32}t in 'struct bug_frame'. > 2. It was added '#define

Re: [PATCH v5 1/4] xen: introduce CONFIG_GENERIC_BUG_FRAME

2023-03-06 Thread Jan Beulich
On 03.03.2023 11:38, Oleksii Kurochko wrote: > --- a/xen/common/Kconfig > +++ b/xen/common/Kconfig > @@ -28,6 +28,9 @@ config ALTERNATIVE_CALL > config ARCH_MAP_DOMAIN_PAGE > bool > > +config GENERIC_BUG_FRAME > + bool With Arm now also going to use the generic logic, do we actually

Re: [PATCH v4 2/5] docs/about/deprecated: Deprecate the qemu-system-i386 binary

2023-03-06 Thread Daniel P . Berrangé
On Mon, Mar 06, 2023 at 10:54:15AM +0100, Thomas Huth wrote: > On 06/03/2023 10.27, Daniel P. Berrangé wrote: > > On Mon, Mar 06, 2023 at 09:46:55AM +0100, Thomas Huth wrote: > > > Aside from not supporting KVM on 32-bit hosts, the qemu-system-x86_64 > > > binary is a proper superset of the

Re: [PATCH v4 2/5] docs/about/deprecated: Deprecate the qemu-system-i386 binary

2023-03-06 Thread Thomas Huth
On 06/03/2023 10.27, Daniel P. Berrangé wrote: On Mon, Mar 06, 2023 at 09:46:55AM +0100, Thomas Huth wrote: Aside from not supporting KVM on 32-bit hosts, the qemu-system-x86_64 binary is a proper superset of the qemu-system-i386 binary. With the 32-bit host support being deprecated, it is now

Re: [PATCH v4 2/5] docs/about/deprecated: Deprecate the qemu-system-i386 binary

2023-03-06 Thread Daniel P . Berrangé
On Mon, Mar 06, 2023 at 09:46:55AM +0100, Thomas Huth wrote: > Aside from not supporting KVM on 32-bit hosts, the qemu-system-x86_64 > binary is a proper superset of the qemu-system-i386 binary. With the > 32-bit host support being deprecated, it is now also possible to > deprecate the

Re: [PATCH v4 4/5] docs/about/deprecated: Deprecate 32-bit arm hosts for system emulation

2023-03-06 Thread Philippe Mathieu-Daudé
On 6/3/23 09:46, Thomas Huth wrote: For running QEMU in system emulation mode, the user needs a rather strong host system, i.e. not only an embedded low-frequency controller. All recent beefy arm host machines should support 64-bit now, it's unlikely that anybody is still seriously using QEMU on

Re: [PATCH v2 2/2] automation: introduce a dom0less test run on Xilinx hardware

2023-03-06 Thread Michal Orzel
Hi Stefano, On 04/03/2023 00:57, Stefano Stabellini wrote: > > > From: Stefano Stabellini > > The test prepares dom0 and domU binaries and boot artifacts, similarly > to the existing QEMU test. (TBD: share preparation steps with the > regular QEMU tests.) > > However, instead of running the

Re: [PATCH v4 3/5] gitlab-ci.d/crossbuilds: Drop the i386 system emulation job

2023-03-06 Thread Philippe Mathieu-Daudé
On 6/3/23 09:46, Thomas Huth wrote: Hardly anybody still uses 32-bit x86 environments for running QEMU with full system emulation, so let's stop wasting our scarce CI minutes with this job. (There are still the 32-bit MinGW and TCI jobs around for having some compile test coverage on 32-bit)

[PATCH v4 5/5] gitlab-ci.d/crossbuilds: Drop the 32-bit arm system emulation jobs

2023-03-06 Thread Thomas Huth
Hardly anybody still uses 32-bit arm environments for running QEMU, so let's stop wasting our scarce CI minutes with these jobs. Reviewed-by: Daniel P. Berrangé Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Wilfred Mallawa Signed-off-by: Thomas Huth --- .gitlab-ci.d/crossbuilds.yml | 14

[PATCH v4 0/5] Deprecate system emulation support for 32-bit x86 and arm hosts

2023-03-06 Thread Thomas Huth
We're struggling quite badly with our CI minutes on the shared gitlab runners, so we urgently need to think of ways to cut down our supported build and target environments. Hardly anybody uses QEMU system emulation on 32-bit x86 and arm hosts anymore, so it's time to deprecate these environments

[PATCH v4 4/5] docs/about/deprecated: Deprecate 32-bit arm hosts for system emulation

2023-03-06 Thread Thomas Huth
For running QEMU in system emulation mode, the user needs a rather strong host system, i.e. not only an embedded low-frequency controller. All recent beefy arm host machines should support 64-bit now, it's unlikely that anybody is still seriously using QEMU on a 32-bit arm CPU, so we deprecate the

[PATCH v4 2/5] docs/about/deprecated: Deprecate the qemu-system-i386 binary

2023-03-06 Thread Thomas Huth
Aside from not supporting KVM on 32-bit hosts, the qemu-system-x86_64 binary is a proper superset of the qemu-system-i386 binary. With the 32-bit host support being deprecated, it is now also possible to deprecate the qemu-system-i386 binary. With regards to 32-bit KVM support in the x86 Linux

[PATCH v4 3/5] gitlab-ci.d/crossbuilds: Drop the i386 system emulation job

2023-03-06 Thread Thomas Huth
Hardly anybody still uses 32-bit x86 environments for running QEMU with full system emulation, so let's stop wasting our scarce CI minutes with this job. (There are still the 32-bit MinGW and TCI jobs around for having some compile test coverage on 32-bit) Reviewed-by: Daniel P. Berrangé

[PATCH v4 1/5] docs/about/deprecated: Deprecate 32-bit x86 hosts for system emulation

2023-03-06 Thread Thomas Huth
Hardly anybody still uses 32-bit x86 hosts today, so we should start deprecating them to stop wasting our time and CI minutes here. For example, there are also still some unresolved problems with these: When emulating 64-bit binaries in user mode, TCG does not honor atomicity for 64-bit accesses,

Re: [PATCH v2] x86/paravirt: merge activate_mm and dup_mmap callbacks

2023-03-06 Thread Borislav Petkov
On Thu, Feb 23, 2023 at 04:05:51PM +0100, Juergen Gross wrote: > x86 maintainers, I think this patch should be carried via the tip tree. You missed a spot. I'll whack it. diff --git a/arch/x86/include/asm/mmu_context.h b/arch/x86/include/asm/mmu_context.h index a8b323266179..c3ad8a526378 100644

Re: [PATCH v2 1/2] automation: add Ubuntu container for Xilinx hardware tests

2023-03-06 Thread Michal Orzel
Hi Stefano, On 04/03/2023 00:57, Stefano Stabellini wrote: > > > From: Stefano Stabellini > > This container is only run on the controller PC (x86) to trigger the > test on a connected Xilinx ZCU102 physical board. > > Signed-off-by: Stefano Stabellini > --- >

[ovmf test] 179364: all pass - PUSHED

2023-03-06 Thread osstest service owner
flight 179364 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/179364/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf a1d595fc9c049874b972a371fe6090738a176f5b baseline version: ovmf

Re: [PATCH 7/7] xen: simplify sysctl registration for balloon

2023-03-06 Thread Juergen Gross
On 02.03.23 21:46, Luis Chamberlain wrote: register_sysctl_table() is a deprecated compatibility wrapper. register_sysctl_init() can do the directory creation for you so just use that. Signed-off-by: Luis Chamberlain Reviewed-by: Juergen Gross Juergen OpenPGP_0xB0DE9DD628BF132F.asc

Re: [PATCH v3 4/4] tools: add offsetof() to xen-tools/common-macros.h

2023-03-06 Thread Juergen Gross
On 06.03.23 09:00, Jan Beulich wrote: On 06.03.2023 08:21, Juergen Gross wrote: --- a/tools/include/xen-tools/common-macros.h +++ b/tools/include/xen-tools/common-macros.h @@ -80,4 +80,8 @@ typeof( ((type *)0)->member ) *__mptr = (ptr);\ (type *)( (char *)__mptr -

[linux-linus test] 179339: regressions - trouble: fail/pass/starved

2023-03-06 Thread osstest service owner
flight 179339 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/179339/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-pvshim 14 guest-start fail REGR. vs. 178042

Re: [PATCH v3 1/4] tools: rename xen-tools/libs.h file to common-macros.h

2023-03-06 Thread Juergen Gross
On 06.03.23 08:52, Jan Beulich wrote: On 06.03.2023 08:21, Juergen Gross wrote: In order to better reflect the contents of the header and to make it more appropriate to use it for different runtime environments like programs, libraries, and firmware, rename the libs.h include file to

Re: [PATCH v3 4/4] tools: add offsetof() to xen-tools/common-macros.h

2023-03-06 Thread Jan Beulich
On 06.03.2023 08:21, Juergen Gross wrote: > --- a/tools/include/xen-tools/common-macros.h > +++ b/tools/include/xen-tools/common-macros.h > @@ -80,4 +80,8 @@ > typeof( ((type *)0)->member ) *__mptr = (ptr);\ > (type *)( (char *)__mptr - offsetof(type,member) );}) > > +#ifndef