[linux-5.4 test] 184334: regressions - FAIL

2024-01-12 Thread osstest service owner
flight 184334 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/184334/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail REGR. vs. 184192 Tests which are

[linux-linus test] 184332: regressions - FAIL

2024-01-12 Thread osstest service owner
flight 184332 linux-linus real [real] flight 184336 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/184332/ http://logs.test-lab.xenproject.org/osstest/logs/184336/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be

Re: [PATCH 0/4] x86emul: support further AVX extensions

2024-01-12 Thread Andrew Cooper
On 07/08/2023 4:18 pm, Jan Beulich wrote: > Covers the smaller recently announced extensions, but not AVX10 (and > even less so APX). Obviously CPUID aspects are taken care of alongside > the actual emulator additions. > > 1: support AVX-VNNI-INT16 > 2: support SHA512 > 3: support SM3 > 4: support

[PATCH v12.1 09/15] vpci/header: program p2m with guest BAR view

2024-01-12 Thread Stewart Hildebrand
From: Oleksandr Andrushchenko Take into account guest's BAR view and program its p2m accordingly: gfn is guest's view of the BAR and mfn is the physical BAR value. This way hardware domain sees physical BAR values and guest sees emulated ones. Hardware domain continues getting the BARs identity

Re: [PATCH v12 09/15] vpci/header: program p2m with guest BAR view

2024-01-12 Thread Stewart Hildebrand
On 1/12/24 10:06, Roger Pau Monné wrote: > On Tue, Jan 09, 2024 at 04:51:24PM -0500, Stewart Hildebrand wrote: >> From: Oleksandr Andrushchenko >> >> Take into account guest's BAR view and program its p2m accordingly: >> gfn is guest's view of the BAR and mfn is the physical BAR value. >> This

[PATCH] xen/xenbus: document will_handle argument for xenbus_watch_path()

2024-01-12 Thread SeongJae Park
Commit 2e85d32b1c86 ("xen/xenbus: Add 'will_handle' callback support in xenbus_watch_path()") added will_handle argument to xenbus_watch_path() and its wrapper, xenbus_watch_pathfmt(), but didn't document it on the kerneldoc comments of the function. This is causing warnings that reported by

[PATCH v12.1 01/15] vpci: use per-domain PCI lock to protect vpci structure

2024-01-12 Thread Stewart Hildebrand
From: Oleksandr Andrushchenko Use the per-domain PCI read/write lock to protect the presence of the pci device vpci field. This lock can be used (and in a few cases is used right away) so that vpci removal can be performed while holding the lock in write mode. Previously such removal could race

[libvirt test] 184329: tolerable all pass - PUSHED

2024-01-12 Thread osstest service owner
flight 184329 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/184329/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail blocked in 184316 test-armhf-armhf-libvirt 16

[xen-unstable test] 184330: tolerable trouble: fail/pass/starved

2024-01-12 Thread osstest service owner
flight 184330 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/184330/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stopfail like 184311 test-armhf-armhf-libvirt 16

Re: [PATCH v12 01/15] vpci: use per-domain PCI lock to protect vpci structure

2024-01-12 Thread Stewart Hildebrand
On 1/12/24 08:48, Roger Pau Monné wrote: > On Tue, Jan 09, 2024 at 04:51:16PM -0500, Stewart Hildebrand wrote: >> From: Oleksandr Andrushchenko >> >> Use a previously introduced per-domain read/write lock to check >> whether vpci is present, so we are sure there are no accesses to the >> contents

Re: [PATCH v3 16/33] tools/libs/light: add backend type for 9pfs PV devices

2024-01-12 Thread Anthony PERARD
On Thu, Jan 04, 2024 at 10:00:38AM +0100, Juergen Gross wrote: > diff --git a/tools/libs/light/libxl_9pfs.c b/tools/libs/light/libxl_9pfs.c > index 5ab0d3aa21..486bc4326e 100644 > --- a/tools/libs/light/libxl_9pfs.c > +++ b/tools/libs/light/libxl_9pfs.c > @@ -33,20 +33,159 @@ static int

[linux-5.4 test] 184327: regressions - FAIL

2024-01-12 Thread osstest service owner
flight 184327 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/184327/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail REGR. vs. 184192 Tests which are

[xen-unstable-smoke test] 184333: tolerable all pass - PUSHED

2024-01-12 Thread osstest service owner
flight 184333 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/184333/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: [PATCH net-next 16/24] net: netkit, veth, tun, virt*: Use nested-BH locking for XDP redirect.

2024-01-12 Thread Sebastian Andrzej Siewior
On 2023-12-18 09:52:05 [+0100], Daniel Borkmann wrote: > Hi Sebastian, Hi Daniel, > Please exclude netkit from this set given it does not support XDP, but > instead only accepts tc BPF typed programs. okay, thank you. > Thanks, > Daniel Sebastian

Re: [PATCH v2] x86/hvm: don't expose XENFEAT_hvm_pirqs by default

2024-01-12 Thread Roger Pau Monné
On Fri, Jan 12, 2024 at 02:40:35PM +, Anthony PERARD wrote: > On Wed, Jan 10, 2024 at 01:42:02PM +0100, Roger Pau Monne wrote: > > The HVM pirq feature allows routing interrupts from both physical and > > emulated > > devices over event channels, this was done a performance improvement. > >

Re: [PATCH v12 09/15] vpci/header: program p2m with guest BAR view

2024-01-12 Thread Roger Pau Monné
On Tue, Jan 09, 2024 at 04:51:24PM -0500, Stewart Hildebrand wrote: > From: Oleksandr Andrushchenko > > Take into account guest's BAR view and program its p2m accordingly: > gfn is guest's view of the BAR and mfn is the physical BAR value. > This way hardware domain sees physical BAR values and

Re: [PATCH v2] x86/hvm: don't expose XENFEAT_hvm_pirqs by default

2024-01-12 Thread Anthony PERARD
On Wed, Jan 10, 2024 at 01:42:02PM +0100, Roger Pau Monne wrote: > The HVM pirq feature allows routing interrupts from both physical and emulated > devices over event channels, this was done a performance improvement. However > its usage is fully undocumented, and the only reference

Re: [PATCH v12 11/15] vpci: add initial support for virtual PCI bus topology

2024-01-12 Thread Stewart Hildebrand
On 1/12/24 06:46, George Dunlap wrote: > On Tue, Jan 9, 2024 at 9:54 PM Stewart Hildebrand > wrote: >> diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h >> index 37f5922f3206..b58a822847be 100644 >> --- a/xen/include/xen/sched.h >> +++ b/xen/include/xen/sched.h >> @@ -484,6 +484,14

Re: [PATCH v12 01/15] vpci: use per-domain PCI lock to protect vpci structure

2024-01-12 Thread Roger Pau Monné
On Tue, Jan 09, 2024 at 04:51:16PM -0500, Stewart Hildebrand wrote: > From: Oleksandr Andrushchenko > > Use a previously introduced per-domain read/write lock to check > whether vpci is present, so we are sure there are no accesses to the > contents of the vpci struct if not. Nit: isn't this

Re: [PATCH v2 2/2] xen/arm32: head: Improve logging in head.S

2024-01-12 Thread Julien Grall
Hi Michal, On 12/01/2024 11:25, Michal Orzel wrote: On 12/01/2024 11:58, Julien Grall wrote: On 12/01/2024 08:49, Michal Orzel wrote: Hi Julien, Hi Michal, On 11/01/2024 19:34, Julien Grall wrote: From: Julien Grall The sequence to enable the MMU on arm32 is quite complex as we

Re: [PATCH v12 11/15] vpci: add initial support for virtual PCI bus topology

2024-01-12 Thread George Dunlap
On Tue, Jan 9, 2024 at 9:54 PM Stewart Hildebrand wrote: > diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h > index 37f5922f3206..b58a822847be 100644 > --- a/xen/include/xen/sched.h > +++ b/xen/include/xen/sched.h > @@ -484,6 +484,14 @@ struct domain > * 2. pdev->vpci->lock >

[ovmf test] 184331: all pass - PUSHED

2024-01-12 Thread osstest service owner
flight 184331 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/184331/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf cfe48465724293abd0a7d92c2a72f8ee3cf15628 baseline version: ovmf

Re: [PATCH v2 2/2] xen/arm32: head: Improve logging in head.S

2024-01-12 Thread Michal Orzel
On 12/01/2024 11:58, Julien Grall wrote: > > > On 12/01/2024 08:49, Michal Orzel wrote: >> Hi Julien, > > Hi Michal, > >> On 11/01/2024 19:34, Julien Grall wrote: >>> >>> >>> From: Julien Grall >>> >>> The sequence to enable the MMU on arm32 is quite complex as we may need >>> to jump to a

Re: [PATCH v2 3/3] x86/vmx: Disallow the use of inactivity states

2024-01-12 Thread Andrew Cooper
On 12/01/2024 11:04 am, Jan Beulich wrote: > On 12.01.2024 11:43, Andrew Cooper wrote: >> On 12/01/2024 10:37 am, Jan Beulich wrote: >>> On 12.01.2024 00:13, Andrew Cooper wrote: --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -1551,7 +1551,10 @@ static void

[PATCH v4] x86/intel: ensure Global Performance Counter Control is setup correctly

2024-01-12 Thread Roger Pau Monne
When Architectural Performance Monitoring is available, the PERF_GLOBAL_CTRL MSR contains per-counter enable bits that is ANDed with the enable bit in the counter EVNTSEL MSR in order for a PMC counter to be enabled. So far the watchdog code seems to have relied on the PERF_GLOBAL_CTRL enable

Re: [PATCH v3 21/34] xen/riscv: introduce p2m.h

2024-01-12 Thread Julien Grall
Hi Jan, On 12/01/2024 11:06, Jan Beulich wrote: On 12.01.2024 11:39, Julien Grall wrote: On 22/12/2023 15:13, Oleksii Kurochko wrote: Signed-off-by: Oleksii Kurochko --- Changes in V3: - add SPDX - drop unneeded for now p2m types. - return false in all functions implemented with

Re: [PATCH v3 21/34] xen/riscv: introduce p2m.h

2024-01-12 Thread Jan Beulich
On 12.01.2024 11:39, Julien Grall wrote: > On 22/12/2023 15:13, Oleksii Kurochko wrote: >> Signed-off-by: Oleksii Kurochko >> --- >> Changes in V3: >> - add SPDX >> - drop unneeded for now p2m types. >> - return false in all functions implemented with BUG() inside. >> - update the commit

Re: [PATCH] x86/hvm: don't expose XENFEAT_hvm_pirqs by default

2024-01-12 Thread Roger Pau Monné
On Thu, Jan 11, 2024 at 05:47:30PM +, David Woodhouse wrote: > On Wed, 2024-01-10 at 11:26 +0100, Jan Beulich wrote: > > On 10.01.2024 10:53, Roger Pau Monne wrote: > > > The HVM pirq feature allows routing interrupts from both physical and > > > emulated > > > devices over event channels,

Re: [PATCH v2] xen/arm: bootfdt: Harden handling of malformed mem reserve map

2024-01-12 Thread Julien Grall
Hi, On 12/01/2024 08:56, Michal Orzel wrote: On 12/01/2024 00:24, Shawn Anastasio wrote: The early_print_info routine in bootfdt.c incorrectly stores the result of a call to fdt_num_mem_rsv() in an unsigned int, which results in the negative error code being interpreted incorrectly in a

Re: [PATCH v2] xen/common: Don't dereference overlay_node after checking that it is NULL

2024-01-12 Thread Julien Grall
Hi Javi, On 11/01/2024 12:09, Javi Merino wrote: In remove_nodes(), overlay_node is dereferenced when printing the error message even though it is known to be NULL. Return without printing as an error message is already printed by the caller. The semantic patch that spots this code is

Re: [PATCH v2 3/3] x86/vmx: Disallow the use of inactivity states

2024-01-12 Thread Jan Beulich
On 12.01.2024 11:43, Andrew Cooper wrote: > On 12/01/2024 10:37 am, Jan Beulich wrote: >> On 12.01.2024 00:13, Andrew Cooper wrote: >>> --- a/xen/arch/x86/hvm/vmx/vmx.c >>> +++ b/xen/arch/x86/hvm/vmx/vmx.c >>> @@ -1551,7 +1551,10 @@ static void cf_check vmx_set_nonreg_state(struct >>> vcpu *v,

Re: [PATCH v2 2/2] xen/arm32: head: Improve logging in head.S

2024-01-12 Thread Julien Grall
On 12/01/2024 08:49, Michal Orzel wrote: Hi Julien, Hi Michal, On 11/01/2024 19:34, Julien Grall wrote: From: Julien Grall The sequence to enable the MMU on arm32 is quite complex as we may need to jump to a temporary mapping to map Xen. Recently, we had one bug in the logic (see

Re: [PATCH v2 1/2] xen/arm32: head: Rework how the fixmap and early UART mapping are prepared

2024-01-12 Thread Julien Grall
Hi Michal, On 12/01/2024 07:46, Michal Orzel wrote: On 11/01/2024 19:34, Julien Grall wrote: From: Julien Grall Since commit 5e213f0f4d2c ("xen/arm32: head: Widen the use of the temporary mapping"), boot_second (used to cover regions like Xen and the fixmap) will not be mapped if the

Re: [PATCH v2 3/3] x86/vmx: Disallow the use of inactivity states

2024-01-12 Thread Andrew Cooper
On 12/01/2024 10:37 am, Jan Beulich wrote: > On 12.01.2024 00:13, Andrew Cooper wrote: >> Right now, vvmx will blindly copy L12's ACTIVITY_STATE into the L02 VMCS and >> enter the vCPU. Luckily for us, nested-virt is explicitly unsupported for >> security bugs. >> >> The inactivity states are

Re: [PATCH v4 03/11] xen/arm: add Dom0 cache coloring support

2024-01-12 Thread Michal Orzel
On 12/01/2024 10:24, Michal Orzel wrote: > > > Hi Carlo, > > On 23/01/2023 16:47, Carlo Nonato wrote: >> >> >> From: Luca Miccio >> >> This commit allows the user to set the cache coloring configuration for >> Dom0 via a command line parameter. >> Since cache coloring and static memory are

Re: [PATCH v3 21/34] xen/riscv: introduce p2m.h

2024-01-12 Thread Julien Grall
Hi Oleksii, On 22/12/2023 15:13, Oleksii Kurochko wrote: Signed-off-by: Oleksii Kurochko --- Changes in V3: - add SPDX - drop unneeded for now p2m types. - return false in all functions implemented with BUG() inside. - update the commit message --- Changes in V2: - Nothing changed.

Re: [PATCH v2 3/3] x86/vmx: Disallow the use of inactivity states

2024-01-12 Thread Jan Beulich
On 12.01.2024 00:13, Andrew Cooper wrote: > Right now, vvmx will blindly copy L12's ACTIVITY_STATE into the L02 VMCS and > enter the vCPU. Luckily for us, nested-virt is explicitly unsupported for > security bugs. > > The inactivity states are HLT, SHUTDOWN and WAIT-FOR-SIPI, and as noted by the

Re: [PATCH v2 2/3] x86/vmx: Fix IRQ handling for EXIT_REASON_INIT

2024-01-12 Thread Jan Beulich
On 12.01.2024 00:13, Andrew Cooper wrote: > When receiving an INIT, a prior bugfix tried to ignore the INIT and continue > onwards. > > Unfortunately it's not safe to return at that point in vmx_vmexit_handler(). > Just out of context in the first hunk is a local_irqs_enabled() which is >

Re: [PATCH v2 1/3] x86/vmx: Collect all emtpy VMExit cases together

2024-01-12 Thread Jan Beulich
On 12.01.2024 00:13, Andrew Cooper wrote: > ... rather than having them spread out. Explain consicely why each is empty. > > No functional change. > > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich

Re: [PATCH v1-alt] xen/livepatch: Make check_for_livepatch_work() faster in the common case

2024-01-12 Thread Jan Beulich
On 11.01.2024 21:11, Andrew Cooper wrote: > When livepatching is enabled, this function is used all the time. Really do > check the fastpath first, and annotate it likely() as this is the right answer > 100% of the time (to many significant figures). This cuts out 3 pointer > dereferences in the

Re: [PATCH v5 08/13] xen/page_alloc: introduce preserved page flags macro

2024-01-12 Thread Jan Beulich
On 12.01.2024 11:01, Carlo Nonato wrote: > On Mon, Jan 8, 2024 at 6:08 PM Jan Beulich wrote: >> On 02.01.2024 10:51, Carlo Nonato wrote: >>> PGC_static and PGC_extra are flags that needs to be preserved when assigning >>> a page. Define a new macro that groups those flags and use it instead of

Re: [PATCH v2] x86/intel: ensure Global Performance Counter Control is setup correctly

2024-01-12 Thread Jan Beulich
On 12.01.2024 11:08, Roger Pau Monné wrote: > On Fri, Jan 12, 2024 at 08:42:27AM +0100, Jan Beulich wrote: >> On 11.01.2024 17:53, Roger Pau Monné wrote: >>> On Thu, Jan 11, 2024 at 04:52:04PM +0100, Jan Beulich wrote: On 11.01.2024 15:15, Roger Pau Monné wrote: > On Thu, Jan 11, 2024 at

[linux-linus test] 184324: regressions - FAIL

2024-01-12 Thread osstest service owner
flight 184324 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/184324/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-pvhv2-intel 20 guest-localmigrate/x10 fail REGR. vs. 184270

Re: [PATCH v2] x86/intel: ensure Global Performance Counter Control is setup correctly

2024-01-12 Thread Roger Pau Monné
On Fri, Jan 12, 2024 at 08:42:27AM +0100, Jan Beulich wrote: > On 11.01.2024 17:53, Roger Pau Monné wrote: > > On Thu, Jan 11, 2024 at 04:52:04PM +0100, Jan Beulich wrote: > >> On 11.01.2024 15:15, Roger Pau Monné wrote: > >>> On Thu, Jan 11, 2024 at 03:01:01PM +0100, Jan Beulich wrote: > On

Re: [PATCH v5 08/13] xen/page_alloc: introduce preserved page flags macro

2024-01-12 Thread Carlo Nonato
Hi Jan, On Mon, Jan 8, 2024 at 6:08 PM Jan Beulich wrote: > > On 02.01.2024 10:51, Carlo Nonato wrote: > > PGC_static and PGC_extra are flags that needs to be preserved when assigning > > a page. Define a new macro that groups those flags and use it instead of > > or'ing every time. > > > > The

Re: [PATCH v5 07/13] xen/page_alloc: introduce init_free_page_fields() helper

2024-01-12 Thread Carlo Nonato
Hi Jan, On Tue, Jan 9, 2024 at 11:36 AM Jan Beulich wrote: > > On 02.01.2024 10:51, Carlo Nonato wrote: > > Introduce a new helper to initialize fields that have different uses for > > free pages. > > > > Signed-off-by: Carlo Nonato > > Signed-off-by: Marco Solieri > > I might in principle ack

Re: [PATCH v4 03/11] xen/arm: add Dom0 cache coloring support

2024-01-12 Thread Michal Orzel
Hi Carlo, On 23/01/2023 16:47, Carlo Nonato wrote: > > > From: Luca Miccio > > This commit allows the user to set the cache coloring configuration for > Dom0 via a command line parameter. > Since cache coloring and static memory are incompatible, direct mapping > Dom0 isn't possible when

Re: [PATCH v2] xen/arm: bootfdt: Harden handling of malformed mem reserve map

2024-01-12 Thread Michal Orzel
On 12/01/2024 00:24, Shawn Anastasio wrote: > > > The early_print_info routine in bootfdt.c incorrectly stores the result > of a call to fdt_num_mem_rsv() in an unsigned int, which results in the > negative error code being interpreted incorrectly in a subsequent loop > in the case where the

Re: [PATCH v2 2/2] xen/arm32: head: Improve logging in head.S

2024-01-12 Thread Michal Orzel
Hi Julien, On 11/01/2024 19:34, Julien Grall wrote: > > > From: Julien Grall > > The sequence to enable the MMU on arm32 is quite complex as we may need > to jump to a temporary mapping to map Xen. > > Recently, we had one bug in the logic (see f5a49eb7f8b3 ("xen/arm32: > head: Add mising