Re: [PATCH v2 5/5] xen/memory, tools: Make init-dom0less consume XEN_DOMCTL_get_mem_map

2024-03-11 Thread Henry Wang
Hi Jan, On 3/12/2024 1:07 AM, Jan Beulich wrote: I'm afraid the title doesn't really say what the patch actually means to achieve. On 08.03.2024 02:54, Henry Wang wrote: Previous commits enable the toolstack to get the domain memory map, therefore instead of hardcoding the guest magic pages

Re: [PATCH v2 4/5] xen/arm: Find unallocated spaces for magic pages of direct-mapped domU

2024-03-11 Thread Henry Wang
Hi Michal, On 3/11/2024 9:46 PM, Michal Orzel wrote: Hi Henry, diff --git a/xen/arch/arm/dom0less-build.c b/xen/arch/arm/dom0less-build.c index 1e1c8d83ae..99447bfb0c 100644 --- a/xen/arch/arm/dom0less-build.c +++ b/xen/arch/arm/dom0less-build.c @@ -682,6 +682,49 @@ static int __init

Re: [PATCH v2 3/5] xen/domctl, tools: Introduce a new domctl to get guest memory map

2024-03-11 Thread Henry Wang
Hi Jan, On 3/12/2024 12:58 AM, Jan Beulich wrote: On 08.03.2024 02:54, Henry Wang wrote: --- a/xen/include/public/domctl.h +++ b/xen/include/public/domctl.h @@ -946,6 +946,25 @@ struct xen_domctl_paging_mempool { uint64_aligned_t size; /* Size in bytes. */ }; +#define

Release signing key still uses SHA1

2024-03-11 Thread Marek Marczykowski-Górecki
Hi, The key used to sign release tarballs and git tags still uses SHA1 for its self-signature. Is updated key somewhere already? SHA1 is starting to be rejected by some tools already, for example sequoia-sq: $ sq inspect xen.pub xen.pub: OpenPGP Certificate. Fingerprint:

4.17.3 download is missing on the website

2024-03-11 Thread Marek Marczykowski-Górecki
Hi, https://xenproject.org/xen-project-archives/ doesn't include 4.17.3. -- Best Regards, Marek Marczykowski-Górecki Invisible Things Lab signature.asc Description: PGP signature

[xen-unstable test] 184996: tolerable FAIL - PUSHED

2024-03-11 Thread osstest service owner
flight 184996 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/184996/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail blocked in 184927

[PATCH] drivers/char: mark XHCI DMA buffers reserved in memory map

2024-03-11 Thread Marek Marczykowski-Górecki
The IOMMU driver checks if RMRR/IVMD are marked as reserved in memory map. This should be true for addresses coming from the firmware, but when extra pages used by Xen itself are included in the mapping, those are taken from usable RAM used. Mark those pages as reserved too. Not marking the pages

Re: [PATCH 3/3] x86/PVH: Support relocatable dom0 kernels

2024-03-11 Thread Jason Andryuk
On 2024-03-11 12:53, Jan Beulich wrote: On 06.03.2024 19:50, Jason Andryuk wrote: --- a/xen/arch/x86/hvm/dom0_build.c +++ b/xen/arch/x86/hvm/dom0_build.c @@ -537,6 +537,109 @@ static paddr_t __init find_memory( return INVALID_PADDR; } +static bool __init check_load_address( +

Re: [PATCH v2 2/5] xen/domain.h: Centrialize is_domain_direct_mapped()

2024-03-11 Thread Shawn Anastasio
Hi Henry, On 3/7/24 7:54 PM, Henry Wang wrote: > Currently direct mapped domain is only supported by the Arm > architecture at the domain creation time by setting the CDF_directmap > flag. There is not a need for every non-Arm architecture, i.e. x86, > RISC-V and PPC, to define a stub

[xen-unstable test] 184992: regressions - FAIL

2024-03-11 Thread osstest service owner
flight 184992 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/184992/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-livepatch 13 livepatch-runfail REGR. vs. 184927

Re: [OSSTEST PATCH] ap-common: Switch to Linux 6.1 by default on x86 + drop dom0 i386

2024-03-11 Thread Roger Pau Monné
On Wed, Mar 06, 2024 at 11:47:41AM +, Anthony PERARD wrote: > linux-4.19 branch in xenbits is outdated, it haven't been updated and > tested since 2020 as it has been disabled in osstest. Also, this 4.19 > branch doesn't build on Bookworm. > > So we will start to use a newer version of Linux.

Re: [OSSTEST PATCH] ap-common: Switch to Linux 6.1 by default on x86 + drop dom0 i386

2024-03-11 Thread Anthony PERARD
On Wed, Mar 06, 2024 at 11:47:41AM +, Anthony PERARD wrote: > linux-4.19 branch in xenbits is outdated, it haven't been updated and > tested since 2020 as it has been disabled in osstest. Also, this 4.19 > branch doesn't build on Bookworm. > > So we will start to use a newer version of Linux.

Re: [PATCH v2 5/5] xen/memory, tools: Make init-dom0less consume XEN_DOMCTL_get_mem_map

2024-03-11 Thread Jan Beulich
I'm afraid the title doesn't really say what the patch actually means to achieve. On 08.03.2024 02:54, Henry Wang wrote: > Previous commits enable the toolstack to get the domain memory map, > therefore instead of hardcoding the guest magic pages region, use > the XEN_DOMCTL_get_mem_map domctl to

Re: [PATCH v2 3/5] xen/domctl, tools: Introduce a new domctl to get guest memory map

2024-03-11 Thread Jan Beulich
On 08.03.2024 02:54, Henry Wang wrote: > --- a/xen/include/public/domctl.h > +++ b/xen/include/public/domctl.h > @@ -946,6 +946,25 @@ struct xen_domctl_paging_mempool { > uint64_aligned_t size; /* Size in bytes. */ > }; > > +#define XEN_MAX_MEM_REGIONS 1 > + > +struct xen_mem_region { > +

Re: [PATCH 3/3] x86/PVH: Support relocatable dom0 kernels

2024-03-11 Thread Jan Beulich
On 06.03.2024 19:50, Jason Andryuk wrote: > --- a/xen/arch/x86/hvm/dom0_build.c > +++ b/xen/arch/x86/hvm/dom0_build.c > @@ -537,6 +537,109 @@ static paddr_t __init find_memory( > return INVALID_PADDR; > } > > +static bool __init check_load_address( > +const struct domain *d, const

[xen-unstable-smoke test] 184995: tolerable all pass - PUSHED

2024-03-11 Thread osstest service owner
flight 184995 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/184995/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: [XEN PATCH] xen/compiler: deviate the inline macro for MISRA C Rule 20.4

2024-03-11 Thread Jan Beulich
On 11.03.2024 16:48, Nicola Vetrini wrote: > On 2024-03-11 08:32, Jan Beulich wrote: >> On 08.03.2024 09:10, Nicola Vetrini wrote: >>> --- a/docs/misra/safe.json >>> +++ b/docs/misra/safe.json >>> @@ -28,6 +28,14 @@ >>> }, >>> { >>> "id": "SAF-3-safe", >>> +

Re: [PATCH v2] x86/PoD: move increment of entry count

2024-03-11 Thread George Dunlap
On Tue, Jan 4, 2022 at 10:58 AM Jan Beulich wrote: > When not holding the PoD lock across the entire region covering P2M > update and stats update, the entry count should indicate too large a > value in preference to a too small one, to avoid functions bailing early > when they find the count is

Re: [XEN PATCH] xen/compiler: deviate the inline macro for MISRA C Rule 20.4

2024-03-11 Thread Nicola Vetrini
On 2024-03-11 08:32, Jan Beulich wrote: On 08.03.2024 09:10, Nicola Vetrini wrote: Rule 20.4 states: "A macro shall not be defined with the same name as a keyword". Defining this macro with the same name as the inline keyword allows for additionally checking that out-of-lined static inline

Re: [XEN PATCH v3 03/16] misra: add deviations for direct inclusion guards

2024-03-11 Thread Simone Ballarin
On 11/03/24 14:56, Jan Beulich wrote: On 11.03.2024 13:00, Simone Ballarin wrote: On 11/03/24 11:08, Jan Beulich wrote: On 11.03.2024 09:59, Simone Ballarin wrote: --- a/xen/arch/arm/include/asm/hypercall.h +++ b/xen/arch/arm/include/asm/hypercall.h @@ -1,3 +1,4 @@ +/* SAF-5-safe direct

Re: [XEN PATCH v3 04/16] xen/arm: address violations of MISRA C:2012 Directive 4.10

2024-03-11 Thread Jan Beulich
On 11.03.2024 13:07, Simone Ballarin wrote: > On 11/03/24 11:10, Jan Beulich wrote: >> On 11.03.2024 09:59, Simone Ballarin wrote: >>> --- a/xen/arch/arm/efi/efi-boot.h >>> +++ b/xen/arch/arm/efi/efi-boot.h >>> @@ -3,6 +3,10 @@ >>>* is intended to be included by common/efi/boot.c _only_, and

Re: [XEN PATCH v3 03/16] misra: add deviations for direct inclusion guards

2024-03-11 Thread Jan Beulich
On 11.03.2024 13:00, Simone Ballarin wrote: > On 11/03/24 11:08, Jan Beulich wrote: >> On 11.03.2024 09:59, Simone Ballarin wrote: >>> --- a/xen/arch/arm/include/asm/hypercall.h >>> +++ b/xen/arch/arm/include/asm/hypercall.h >>> @@ -1,3 +1,4 @@ >>> +/* SAF-5-safe direct inclusion guard before */

Re: [PATCH v2 4/5] xen/arm: Find unallocated spaces for magic pages of direct-mapped domU

2024-03-11 Thread Michal Orzel
On 11/03/2024 14:46, Michal Orzel wrote: > > > Hi Henry, > > On 08/03/2024 02:54, Henry Wang wrote: >> For 1:1 direct-mapped dom0less DomUs, the magic pages should not clash >> with any RAM region. To find a proper region for guest magic pages, >> we can reuse the logic of finding domain

Re: [PATCH v2 4/5] xen/arm: Find unallocated spaces for magic pages of direct-mapped domU

2024-03-11 Thread Michal Orzel
Hi Henry, On 08/03/2024 02:54, Henry Wang wrote: > For 1:1 direct-mapped dom0less DomUs, the magic pages should not clash > with any RAM region. To find a proper region for guest magic pages, > we can reuse the logic of finding domain extended regions. > > Extract the logic of finding domain

[linux-linus test] 184991: tolerable FAIL - PUSHED

2024-03-11 Thread osstest service owner
flight 184991 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/184991/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 184987 test-amd64-amd64-xl-qemut-win7-amd64

Re: [XEN PATCH v3 00/16] xen: address violation of MISRA C:2012 Directive 4.10

2024-03-11 Thread Jan Beulich
On 11.03.2024 12:41, Simone Ballarin wrote: > On 11/03/24 10:59, Jan Beulich wrote: >> On 11.03.2024 09:59, Simone Ballarin wrote: >>> The Xen sources contain violations of MISRA C:2012 Directive 4.10 whose >>> headline states: >>> "Precautions shall be taken in order to prevent the contents of a

[PATCH v2 1/3] x86/svm: Drop the _enabled suffix from vmcb bits

2024-03-11 Thread Vaishali Thakkar
The suffix is redundant for np/sev/sev-es bits. Drop it to avoid adding extra code volume. While we're here, drop the double negations in one of the instances of _np bit and replace 0/1 with false/true in the use cases of _np. Suggested-by: Andrew Cooper Signed-off-by: Vaishali Thakkar

[PATCH v2 3/3] x86/svmdebug: Print sev and sev_es vmcb bits

2024-03-11 Thread Vaishali Thakkar
While sev and sev_es bits are not yet enabled in xen, including their status in the VMCB dump could be informational.Therefore, print it via svmdebug. Signed-off-by: Vaishali Thakkar --- Changes since v1: - Pretty printing --- xen/arch/x86/hvm/svm/svmdebug.c | 7 +-- 1 file changed,

[PATCH v2 2/3] x86/svm: Drop the suffix _guest from vmcb bit

2024-03-11 Thread Vaishali Thakkar
The suffix _guest is redundant for asid bit. Drop it to avoid adding extra code volume. Suggested-by: Andrew Cooper Signed-off-by: Vaishali Thakkar --- Changes since v1: - This patch wasn't part of v1. It's been added to address Andrew's suggestion. ---

[PATCH v2 0/3] x86/svm : Misc changes for few vmcb bits

2024-03-11 Thread Vaishali Thakkar
Hi, In this patchset, first & second patch removes the unnecessary suffix from a bunch of vmcb bits. Third patch is about printing the status of sev and sev-es bits while dumping VMCB. Changes since v1: - Address comments from Andrew and Jan - Add extrapatch to drop the suffix _guest as per

Re: [PATCH v6 13/15] xen/arm: make consider_modules() available for xen relocation

2024-03-11 Thread Ayan Kumar Halder
On 09/03/2024 06:44, Henry Wang wrote: Hi Julien, Hi Julien/Henry, On 3/9/2024 6:30 AM, Julien Grall wrote: (+ Ayan + Henry) (- my old email address + the new one) Hi Carlo, On 29/01/2024 17:18, Carlo Nonato wrote: Cache coloring must physically relocate Xen in order to color the

[xen-unstable-smoke test] 184993: tolerable all pass - PUSHED

2024-03-11 Thread osstest service owner
flight 184993 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/184993/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: [XEN PATCH v3 04/16] xen/arm: address violations of MISRA C:2012 Directive 4.10

2024-03-11 Thread Simone Ballarin
On 11/03/24 11:10, Jan Beulich wrote: On 11.03.2024 09:59, Simone Ballarin wrote: --- a/xen/arch/arm/efi/efi-boot.h +++ b/xen/arch/arm/efi/efi-boot.h @@ -3,6 +3,10 @@ * is intended to be included by common/efi/boot.c _only_, and * therefore can define arch specific global variables. */

Re: [XEN PATCH v3 03/16] misra: add deviations for direct inclusion guards

2024-03-11 Thread Simone Ballarin
On 11/03/24 11:08, Jan Beulich wrote: On 11.03.2024 09:59, Simone Ballarin wrote: Add deviation comments to address violations of MISRA C:2012 Directive 4.10 ("Precautions shall be taken in order to prevent the contents of a header file being included more than once"). Inclusion guards must

Re: [PATCH] do_multicall and MISRA Rule 8.3

2024-03-11 Thread Julien Grall
Hi, On 11/03/2024 11:32, George Dunlap wrote: On Sat, Mar 9, 2024 at 1:59 AM Stefano Stabellini wrote: I would like to resurrect this thread and ask other opinions. On Thu, 23 Nov 2023, Jan Beulich wrote: On 22.11.2023 22:46, Stefano Stabellini wrote: Two out of three do_multicall

Re: [XEN PATCH v3 00/16] xen: address violation of MISRA C:2012 Directive 4.10

2024-03-11 Thread Simone Ballarin
On 11/03/24 10:59, Jan Beulich wrote: On 11.03.2024 09:59, Simone Ballarin wrote: The Xen sources contain violations of MISRA C:2012 Directive 4.10 whose headline states: "Precautions shall be taken in order to prevent the contents of a header file being included more than once". As stated in

Re: [PATCH] do_multicall and MISRA Rule 8.3

2024-03-11 Thread George Dunlap
On Sat, Mar 9, 2024 at 1:59 AM Stefano Stabellini wrote: > > I would like to resurrect this thread and ask other opinions. > > > On Thu, 23 Nov 2023, Jan Beulich wrote: > > On 22.11.2023 22:46, Stefano Stabellini wrote: > > > Two out of three do_multicall definitions/declarations use uint32_t as

Re: [PATCH] x86/mm: fix detection of last L1 entry in modify_xen_mappings_lite()

2024-03-11 Thread Jan Beulich
On 11.03.2024 11:54, Roger Pau Monne wrote: > The current logic to detect when to switch to the next L1 table is incorrectly > using l2_table_offset() in order to notice when the last entry on the current > L1 table has been reached. > > It should instead use l1_table_offset() to check whether

Re: [PATCH] x86/mm: fix detection of last L1 entry in modify_xen_mappings_lite()

2024-03-11 Thread Alejandro Vallejo
On 11/03/2024 11:01, Andrew Cooper wrote: > On 11/03/2024 10:54 am, Roger Pau Monne wrote: >> The current logic to detect when to switch to the next L1 table is >> incorrectly >> using l2_table_offset() in order to notice when the last entry on the current >> L1 table has been reached. >> >> It

Re: xen | Failed pipeline for staging | e90089db

2024-03-11 Thread Andrew Cooper
On 11/03/2024 10:15 am, Jan Beulich wrote: > On 11.03.2024 11:00, GitLab wrote: >> >> Pipeline #1208433952 has failed! >> >> Project: xen ( https://gitlab.com/xen-project/hardware/xen ) >> Branch: staging ( >> https://gitlab.com/xen-project/hardware/xen/-/commits/staging ) >> >> Commit: e90089db

Re: [PATCH] x86/mm: fix detection of last L1 entry in modify_xen_mappings_lite()

2024-03-11 Thread Andrew Cooper
On 11/03/2024 10:54 am, Roger Pau Monne wrote: > The current logic to detect when to switch to the next L1 table is incorrectly > using l2_table_offset() in order to notice when the last entry on the current > L1 table has been reached. > > It should instead use l1_table_offset() to check whether

Re: xen | Failed pipeline for staging | 1396892d

2024-03-11 Thread Andrew Cooper
On 11/03/2024 10:20 am, Jan Beulich wrote: > On 11.03.2024 11:09, GitLab wrote: >> >> Pipeline #1208444169 has failed! >> >> Project: xen ( https://gitlab.com/xen-project/hardware/xen ) >> Branch: staging ( >> https://gitlab.com/xen-project/hardware/xen/-/commits/staging ) >> >> Commit: 1396892d

[PATCH] x86/mm: fix detection of last L1 entry in modify_xen_mappings_lite()

2024-03-11 Thread Roger Pau Monne
The current logic to detect when to switch to the next L1 table is incorrectly using l2_table_offset() in order to notice when the last entry on the current L1 table has been reached. It should instead use l1_table_offset() to check whether the index has wrapped to point to the first entry, and

Re: [XEN PATCH] xen/evtchn: address violations of MISRA C:2012 Rules 16.3 and 16.4

2024-03-11 Thread Federico Serafini
On 11/03/24 10:51, Jan Beulich wrote: On 11.03.2024 10:02, Federico Serafini wrote: On 11/03/24 08:40, Jan Beulich wrote: On 08.03.2024 12:51, Federico Serafini wrote: --- a/xen/common/event_channel.c +++ b/xen/common/event_channel.c @@ -130,9 +130,12 @@ static bool virq_is_global(unsigned

Re: xen | Failed pipeline for staging | 1396892d

2024-03-11 Thread Jan Beulich
On 11.03.2024 11:09, GitLab wrote: > > > Pipeline #1208444169 has failed! > > Project: xen ( https://gitlab.com/xen-project/hardware/xen ) > Branch: staging ( > https://gitlab.com/xen-project/hardware/xen/-/commits/staging ) > > Commit: 1396892d ( >

Re: xen | Failed pipeline for staging | e90089db

2024-03-11 Thread Jan Beulich
On 11.03.2024 11:00, GitLab wrote: > > > Pipeline #1208433952 has failed! > > Project: xen ( https://gitlab.com/xen-project/hardware/xen ) > Branch: staging ( > https://gitlab.com/xen-project/hardware/xen/-/commits/staging ) > > Commit: e90089db ( >

Re: [XEN PATCH v3 04/16] xen/arm: address violations of MISRA C:2012 Directive 4.10

2024-03-11 Thread Jan Beulich
On 11.03.2024 09:59, Simone Ballarin wrote: > --- a/xen/arch/arm/efi/efi-boot.h > +++ b/xen/arch/arm/efi/efi-boot.h > @@ -3,6 +3,10 @@ > * is intended to be included by common/efi/boot.c _only_, and > * therefore can define arch specific global variables. > */ > + > +#ifndef

Re: [XEN PATCH v3 03/16] misra: add deviations for direct inclusion guards

2024-03-11 Thread Jan Beulich
On 11.03.2024 09:59, Simone Ballarin wrote: > Add deviation comments to address violations of > MISRA C:2012 Directive 4.10 ("Precautions shall be taken in order > to prevent the contents of a header file being included more than > once"). > > Inclusion guards must appear at the beginning of the

Re: [XEN PATCH v3 01/16] misra: add deviation for headers that explicitly avoid guards

2024-03-11 Thread Jan Beulich
On 11.03.2024 09:59, Simone Ballarin wrote: > Some headers, under specific circumstances (documented in a comment at > the beginning of the file), explicitly avoid inclusion guards: the caller > is responsible for including them correctly. > > These files are not supposed to comply with Directive

Re: [XEN PATCH v3 00/16] xen: address violation of MISRA C:2012 Directive 4.10

2024-03-11 Thread Jan Beulich
On 11.03.2024 09:59, Simone Ballarin wrote: > The Xen sources contain violations of MISRA C:2012 Directive 4.10 whose > headline states: > "Precautions shall be taken in order to prevent the contents of a header file > being included more than once". > > As stated in v2, the following naming

Re: [XEN PATCH] xen/evtchn: address violations of MISRA C:2012 Rules 16.3 and 16.4

2024-03-11 Thread Jan Beulich
On 11.03.2024 10:02, Federico Serafini wrote: > On 11/03/24 08:40, Jan Beulich wrote: >> On 08.03.2024 12:51, Federico Serafini wrote: >>> --- a/xen/common/event_channel.c >>> +++ b/xen/common/event_channel.c >>> @@ -130,9 +130,12 @@ static bool virq_is_global(unsigned int virq) >>> >>>

Re: [PATCH v2 3/5] xen/domctl, tools: Introduce a new domctl to get guest memory map

2024-03-11 Thread Henry Wang
Hi Michal, On 3/11/2024 5:10 PM, Michal Orzel wrote: Hi Henry, diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c index 5e7a7f3e7e..54f3601ab0 100644 --- a/xen/arch/arm/domain.c +++ b/xen/arch/arm/domain.c @@ -696,6 +696,7 @@ int arch_domain_create(struct domain *d, { unsigned

Re: [PATCH v2 3/5] xen/domctl, tools: Introduce a new domctl to get guest memory map

2024-03-11 Thread Michal Orzel
Hi Henry, On 08/03/2024 02:54, Henry Wang wrote: > There are some use cases where the toolstack needs to know the guest > memory map. For example, the toolstack helper application > "init-dom0less" needs to know the guest magic page regions for 1:1 > direct-mapped dom0less DomUs to allocate magic

Re: [XEN PATCH] xen/evtchn: address violations of MISRA C:2012 Rules 16.3 and 16.4

2024-03-11 Thread Federico Serafini
On 11/03/24 08:40, Jan Beulich wrote: On 08.03.2024 12:51, Federico Serafini wrote: --- a/xen/common/event_channel.c +++ b/xen/common/event_channel.c @@ -130,9 +130,12 @@ static bool virq_is_global(unsigned int virq) case VIRQ_ARCH_0 ... VIRQ_ARCH_7: return

[XEN PATCH v3 15/16] x86/mtrr: address violations of MISRA C:2012 Directive 4.10

2024-03-11 Thread Simone Ballarin
From: Maria Celeste Cesario Add inclusion guard to address violations of MISRA C:2012 Directive 4.10 ("Precautions shall be taken in order to prevent the contents of a header file being included more than once"). Mechanical change. --- Commit introduced in v3 Signed-off-by: Maria Celeste

[XEN PATCH v3 12/16] xen: address violations of MISRA C:2012 Directive 4.10

2024-03-11 Thread Simone Ballarin
From: Maria Celeste Cesario Modify creation rule for asm-offsets.h to conform to the new standard and to not generate conflicting guards between architectures (which is a violation of the directive). Modify generic-y creation rule to generate code without violations and to conform to the new

[XEN PATCH v3 09/16] xen: address violations of MISRA C:2012 Directive 4.10

2024-03-11 Thread Simone Ballarin
Amend inclusion guards to address violations of MISRA C:2012 Directive 4.10 ("Precautions shall be taken in order to prevent the contents of a header file being included more than once"). Inclusion guards must appear at the beginning of the headers (comments are permitted anywhere) and the #if

[XEN PATCH v3 11/16] xen/arm: address violations of MISRA C:2012 Directive 4.10

2024-03-11 Thread Simone Ballarin
From: Maria Celeste Cesario Add or modify inclusion guards to address violations of MISRA C:2012 Directive 4.10 ("Precautions shall be taken in order to prevent the contents of a header file being included more than once"). Mechanical change. --- Commit introduced in v3 Signed-off-by: Maria

[XEN PATCH v3 07/16] xen/common: address violations of MISRA C:2012 Directive 4.10

2024-03-11 Thread Simone Ballarin
Add inclusion guards to address violations of MISRA C:2012 Directive 4.10 ("Precautions shall be taken in order to prevent the contents of a header file being included more than once"). Mechanical change. Signed-off-by: Simone Ballarin Signed-off-by: Maria Celeste Cesario --- Changes in v3:

[XEN PATCH v3 03/16] misra: add deviations for direct inclusion guards

2024-03-11 Thread Simone Ballarin
Add deviation comments to address violations of MISRA C:2012 Directive 4.10 ("Precautions shall be taken in order to prevent the contents of a header file being included more than once"). Inclusion guards must appear at the beginning of the headers (comments are permitted anywhere). This patch

[XEN PATCH v3 05/16] xen/x86: address violations of MISRA C:2012 Directive 4.10

2024-03-11 Thread Simone Ballarin
Add or move inclusion guards to address violations of MISRA C:2012 Directive 4.10 ("Precautions shall be taken in order to prevent the contents of a header file being included more than once"). Inclusion guards must appear at the beginning of the headers (comments are permitted anywhere).

[XEN PATCH v3 02/16] misra: modify deviations for empty and generated headers

2024-03-11 Thread Simone Ballarin
This patch modifies deviations for Directive 4.10: "Precautions shall be taken in order to prevent the contents of a header file being included more than once" This patch avoids the file-based deviation for empty headers, and replaces it with a comment-based one using the format specified in

[XEN PATCH v3 14/16] xen/x86: address violations of MISRA C:2012 Directive 4.10

2024-03-11 Thread Simone Ballarin
From: Maria Celeste Cesario Edit inclusion guards to address violations of MISRA C:2012 Directive 4.10 ("Precautions shall be taken in order to prevent the contents of a header file being included more than once"). Mechanical change. --- Commit introduced in v3 Signed-off-by: Maria Celeste

[XEN PATCH v3 16/16] xen/lz4: address violations of MISRA C:2012 Directive 4.10

2024-03-11 Thread Simone Ballarin
From: Maria Celeste Cesario Add inclusion guard to address violations of MISRA C:2012 Directive 4.10 ("Precautions shall be taken in order to prevent the contents of a header file being included more than once"). Mechanical change. --- Commit introduced in v3 Signed-off-by: Maria Celeste

[XEN PATCH v3 13/16] xen: add deviations for MISRA C.2012 Directive 4.10

2024-03-11 Thread Simone Ballarin
From: Maria Celeste Cesario Add safe deviation for *.c files, as estabilished in past discussion. Add SAF deviation for files that need an #include directive before guard. Signed-off-by: Maria Celeste Cesario Signed-off-by: Simone Ballarin --- Commit introduced in v3 Link to the discussion

[XEN PATCH v3 10/16] x86/asm: address violations of MISRA C:2012 Directive 4.10

2024-03-11 Thread Simone Ballarin
Amend generation script, add inclusion guards to address violations of MISRA C:2012 Directive 4.10 ("Precautions shall be taken in order to prevent the contents of a header file being included more than once"). This patch amends the Makefile adding the required inclusion guards for xlat.h. Add

[XEN PATCH v3 06/16] x86/EFI: address violations of MISRA C:2012 Directive 4.10

2024-03-11 Thread Simone Ballarin
Add inclusion guard to address violations of MISRA C:2012 Directive 4.10 ("Precautions shall be taken in order to prevent the contents of a header file being included more than once"). Mechanical change. Signed-off-by: Simone Ballarin Signed-off-by: Maria Celeste Cesario --- Changes in v3: -

[XEN PATCH v3 01/16] misra: add deviation for headers that explicitly avoid guards

2024-03-11 Thread Simone Ballarin
Some headers, under specific circumstances (documented in a comment at the beginning of the file), explicitly avoid inclusion guards: the caller is responsible for including them correctly. These files are not supposed to comply with Directive 4.10: "Precautions shall be taken in order to prevent

[XEN PATCH v3 00/16] xen: address violation of MISRA C:2012 Directive 4.10

2024-03-11 Thread Simone Ballarin
The Xen sources contain violations of MISRA C:2012 Directive 4.10 whose headline states: "Precautions shall be taken in order to prevent the contents of a header file being included more than once". As stated in v2, the following naming convention has been estabilished: - arch/.../include/asm/

[XEN PATCH v3 08/16] xen/efi: address violations of MISRA C:2012 Directive 4.10

2024-03-11 Thread Simone Ballarin
Add inclusion guards to address violations of MISRA C:2012 Directive 4.10 ("Precautions shall be taken in order to prevent the contents of a header file being included more than once"). Mechanical change. Signed-off-by: Simone Ballarin Signed-off-by: Maria Celeste Cesario --- Changes in v3:

[XEN PATCH v3 04/16] xen/arm: address violations of MISRA C:2012 Directive 4.10

2024-03-11 Thread Simone Ballarin
Add inclusion guard to address violations of MISRA C:2012 Directive 4.10 ("Precautions shall be taken in order to prevent the contents of a header file being included more than once"). Mechanical change. Signed-off-by: Simone Ballarin Signed-off-by: Maria Celeste Cesario --- Changes in v3: -

Re: [PATCH 1/2] xen/arm: Add imx8q{m,x} platform glue

2024-03-11 Thread John Ernberg
Hi Julien, On 3/8/24 15:04, Julien Grall wrote: > Hi John, > > Thank you for the reply. > > On 08/03/2024 13:40, John Ernberg wrote: >> On 3/7/24 00:07, Julien Grall wrote: >>>   > Ping on the watchdog discussion bits. >>> >>> Sorry for the late reply. >>> >>> On 06/03/2024 13:13, John Ernberg

Re: [XEN PATCH v2 3/7] xen/list: address violations of MISRA C Rule 20.7

2024-03-11 Thread Nicola Vetrini
On 2024-03-11 08:48, Jan Beulich wrote: On 08.03.2024 12:21, Nicola Vetrini wrote: --- a/xen/include/xen/list.h +++ b/xen/include/xen/list.h @@ -479,9 +479,9 @@ static inline void list_splice_init(struct list_head *list, * @n: another list_head to use as temporary storage * @head:

Re: Regression with xhci console

2024-03-11 Thread Jan Beulich
On 11.03.2024 03:18, Marek Marczykowski-Górecki wrote: > On Thu, Feb 01, 2024 at 06:01:56PM +0100, Roger Pau Monne wrote: >> The current code that parses the IVMD blocks is relaxed with regard to the >> restriction that such unity regions should always fall into memory ranges >> marked as reserved

Re: [XEN PATCH v2 6/7] x86/irq: parenthesize negative constants

2024-03-11 Thread Jan Beulich
On 09.03.2024 02:54, Stefano Stabellini wrote: > On Fri, 8 Mar 2024, Nicola Vetrini wrote: >> These constants are parenthesized to avoid them from >> possibly influencing the semantics of the constructs where it is used, >> especially inside macros invocations. >> >> This also resolves some

Re: [XEN PATCH v2 3/7] xen/list: address violations of MISRA C Rule 20.7

2024-03-11 Thread Jan Beulich
On 08.03.2024 12:21, Nicola Vetrini wrote: > --- a/xen/include/xen/list.h > +++ b/xen/include/xen/list.h > @@ -479,9 +479,9 @@ static inline void list_splice_init(struct list_head > *list, > * @n: another list_head to use as temporary storage > * @head: the head for your list. > */

Re: [XEN PATCH] xen/evtchn: address violations of MISRA C:2012 Rules 16.3 and 16.4

2024-03-11 Thread Jan Beulich
On 08.03.2024 12:51, Federico Serafini wrote: > --- a/xen/common/event_channel.c > +++ b/xen/common/event_channel.c > @@ -130,9 +130,12 @@ static bool virq_is_global(unsigned int virq) > > case VIRQ_ARCH_0 ... VIRQ_ARCH_7: > return arch_virq_is_global(virq); > + > +default: > +

Re: [XEN PATCH] xen/compiler: deviate the inline macro for MISRA C Rule 20.4

2024-03-11 Thread Jan Beulich
On 08.03.2024 09:10, Nicola Vetrini wrote: > Rule 20.4 states: "A macro shall not be defined with the same name > as a keyword". > > Defining this macro with the same name as the inline keyword > allows for additionally checking that out-of-lined static inline > functions end up in the correct

[xen-unstable test] 184989: regressions - FAIL

2024-03-11 Thread osstest service owner
flight 184989 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/184989/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-livepatch 13 livepatch-runfail REGR. vs. 184927