20_linux_xen now uses "xen_hypervisor" and "xen_module" in place of
"multiboot2?" and "module2?" when generating a config file for
arm64-uefi.
Signed-off-by: Anthony PERARD
---
Osstest/Debian.pm | 8
1 file changed, 4 insertions(+), 4 deleti
;xenpolicy-*(XSM enabled)" and fail.
Signed-off-by: Anthony PERARD
(upstream commit:
https://git.savannah.gnu.org/cgit/grub.git/commit/?id=db1faedccdce3cf83336155a95c04a8db03744c5)
---
overlay-bookworm/etc/grub.d/20_linux_xen | 18 +-
1 file changed, 9 insertions(+), 9 deletio
The default wait time of 3 seconds isn't always enough get an IP from
the DHCP, give more time to the installer to find a NIC that works.
Signed-off-by: Anthony PERARD
---
Osstest/Debian.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/Osstest/Debian.pm b/Osstest/Debian.pm
index 14ec2293
ian-install, as
they use the initrd from dom0, so the interface in the guest will be
renamed according to default policy (which rename eth0 to enX0).
Signed-off-by: Anthony PERARD
---
Osstest/Debian.pm | 22 ++
ts-host-install | 16
2 files changed, 38 i
ts-xtf-run does run ./xtf-runner, which run `python` in its shebang.
So install a `python` symlink to `python3`.
Signed-off-by: Anthony PERARD
---
ts-xtf-install | 6 ++
1 file changed, 6 insertions(+)
diff --git a/ts-xtf-install b/ts-xtf-install
index a64fd329..fea737ff 100755
--- a/ts
with a list
of all disk, but that would mean knowing all the disk before starting
the machine.
This new shell script in /lib/partman/finish.d/ should work in all
debian, so replace the script in ts-host-install by this new one.
Signed-off-by: Anthony PERARD
---
Osstest/Debian.pm | 21 +
-by: Anthony PERARD
---
Osstest/Debian.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Osstest/Debian.pm b/Osstest/Debian.pm
index 7d6f9778..36c05551 100644
--- a/Osstest/Debian.pm
+++ b/Osstest/Debian.pm
@@ -1305,7 +1305,7 @@ for sd in sd hd; do
udevadm settle
log
python-dev:
It doesn't exist on bookworm, and python2 shouldn't be needed
anymore.
libsdl-dev:
On buster this already select "libsdl1.2-dev", but to not change
buster installation we will only use the new package name on
Bookworm.
Signed-off-by: Anthony PERARD
-
libc6-xen packaged have been removed from Debian Bookworm.
Signed-off-by: Anthony PERARD
---
ts-xen-install | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ts-xen-install b/ts-xen-install
index bf55d4e5..3a913fce 100755
--- a/ts-xen-install
+++ b/ts-xen-install
@@ -64,7
Signed-off-by: Anthony PERARD
---
mg-debian-installer-update | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/mg-debian-installer-update b/mg-debian-installer-update
index 4fb4bc21..31b8a192 100755
--- a/mg-debian-installer-update
+++ b/mg-debian-installer-update
Newer version of Debian and thus git would use this automatically, no
need to force it.
Signed-off-by: Anthony PERARD
---
Osstest/TestSupport.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm
index f0e087aa..0dded9b2 100644
t on the few machine tested so far. But, we will change to a "mac"
name policy in a follow-up commit.
Signed-off-by: Anthony PERARD
---
Osstest/Debian.pm | 12 +++-
ts-host-install | 2 +-
2 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/Osstest/Debian.pm b/Os
Otherwise, the change to the config file isn't taken into account
until the next reboot.
Signed-off-by: Anthony PERARD
---
ts-host-install | 5 +
1 file changed, 5 insertions(+)
diff --git a/ts-host-install b/ts-host-install
index 00277485..43ed9285 100755
--- a/ts-host-install
+++ b/ts
Signed-off-by: Anthony PERARD
---
production-config | 2 ++
1 file changed, 2 insertions(+)
diff --git a/production-config b/production-config
index 2c44805c..6345c40c 100644
--- a/production-config
+++ b/production-config
@@ -101,6 +101,8 @@ DebianImageVersion_jessie 8.2.0
grub-installer on arndale-* machine fails with Debian Bookworm. It
tries to install "grub-pc" which doesn't exist. Skip installation.
Somehow, cubietruck-* installation works fine.
Signed-off-by: Anthony PERARD
---
Osstest/Debian.pm | 8
1 file changed, 8 insertions(+)
$@ expand to two or more words, but fail() only take one argument.
So if there's more than one argument left, fail() only shows the first
one, and don't event display "not found".
Signed-off-by: Anthony PERARD
---
mgi-common | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Instead of "grub-installer/no-nvram" proposed in Debian bug #789798,
we have "grub-installer/update-nvram". Make use of it, and remove
workaround.
Signed-off-by: Anthony PERARD
---
Osstest/Debian.pm | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git
Signed-off-by: Anthony PERARD
---
ts-host-install | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/ts-host-install b/ts-host-install
index f79a1beb..61433e64 100755
--- a/ts-host-install
+++ b/ts-host-install
@@ -151,7 +151,13 @@ END
my $ntpserver
The Debian #778564 bug report is still open, the ntp.conf file doesn't
contain the setting from NtpServer after installation, so we still
need to edit ntp.conf on Bookworm.
Signed-off-by: Anthony PERARD
---
ts-host-install | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ts
, but hopefully nothing breaks.
Cheers,
Anthony PERARD (36):
production-config: Add bookworm debian install media filename
ts-xen-build-prep: Only force git protocol v2 on buster
mgi-common: Fix fetch_debian_package error message
mg-debian-installer-update: Download non-free firmware from ne
On Mon, Mar 18, 2024 at 11:42:43AM +0100, Roger Pau Monné wrote:
> On Fri, Mar 15, 2024 at 03:48:46PM +0000, Anthony PERARD wrote:
> > Anthony PERARD (3):
> > make-fligh: Fix freebsd guest test test-id
> > mfi-common: Rework toolstack-disk_format test matrix
> >
64-amd64-libvirt-vhd
+ test-amd64-amd64-qemuu-freebsd11-amd64
+ test-amd64-amd64-qemuu-freebsd12-amd64
+ test-amd64-amd64-xl-qcow2
+ test-amd64-amd64-xl-raw
+ test-armhf-armhf-libvirt-vhd
+ test-armhf-armhf-xl-qcow2
+ test-armhf-armhf-xl-raw
Anthony PERARD (3):
make-fligh: Fix freebsd guest test
t-armhf-armhf-libvirt-qcow2
- test-armhf-armhf-libvirt-raw
- test-armhf-armhf-xl-vhd
+ test-armhf-armhf-libvirt-vhd
+ test-armhf-armhf-xl-qcow2
+ test-armhf-armhf-xl-raw
Signed-off-by: Anthony PERARD
---
Notes:
Putting i386 in second or later in dom0arches mean that the freebsd10
jobs
test-amd64-amd64-freebsd12-amd64
+test-amd64-amd64-qemuu-freebsd11-amd64
+test-amd64-amd64-qemuu-freebsd12-amd64
This patch will have the benefit to avoid the opposite changes in all the other
branches as we are going to make some changes to job generation.
Signed-off-by: Anthony PERARD
---
make-
d64-i386-libvirt-qcow2
- test-amd64-i386-libvirt-raw
- test-amd64-i386-xl-vhd
+ test-amd64-amd64-libvirt-qcow2
+ test-amd64-amd64-libvirt-raw
+ test-amd64-amd64-xl-vhd
In any case, the list of test would be the same as for the existing
branch "linux-linus" or "linux-6.1" branc
On Wed, Mar 13, 2024 at 11:48:11AM +0100, Roger Pau Monné wrote:
> On Tue, Mar 12, 2024 at 05:19:46PM +0000, Anthony PERARD wrote:
> > On Mon, Mar 11, 2024 at 06:27:52PM +0100, Roger Pau Monné wrote:
> > > On Wed, Mar 06, 2024 at 11:47:41AM +0000, Anthony PERARD wrote:
> >
On Mon, Mar 11, 2024 at 06:27:52PM +0100, Roger Pau Monné wrote:
> On Wed, Mar 06, 2024 at 11:47:41AM +0000, Anthony PERARD wrote:
> > Gone, but replaced by a new test-amd64-amd64-*:
> > - test-amd64-i386-libvirt-raw
> > - test-amd64-i386-xl-vhd
> >
> > Some te
On Wed, Mar 06, 2024 at 11:47:41AM +, Anthony PERARD wrote:
> linux-4.19 branch in xenbits is outdated, it haven't been updated and
> tested since 2020 as it has been disabled in osstest. Also, this 4.19
> branch doesn't build on Bookworm.
>
> So we will start to use a newer v
_PCI,
> @@ -759,8 +759,8 @@ static void xen_pt_destroy(PCIDevice *d) {
> memory_listener_unregister(>io_listener);
> s->listener_set = false;
> }
> -if (!xen_host_pci_device_closed(>real_device)) {
> -xen_host_pci_device_put(>real_device);
&
e to me but I don't have any x86
> Xen HW to test this one. Are the x86 maintainers happy to take this on?
Yes. It looks like it works well with both SeaBIOS and OVMF, so the
patch is good.
> FWIW:
>
> Reviewed-by: Alex Bennée
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
e: Acquire the mutex first, invoke strerror(), copy
> the string from strerror() to the designated buffer and then drop the
> mutex.
>
> Fixes: f4900d6d69b5 ("9pfsd: allow building with old glibc")
> Signed-off-by: Henry Wang
> Reviewed-by: Jan Beulich
Acked-by: Anthony PERARD
--
Anthony PERARD
memory contents and vCPU contexts
> intact. This will allow the domain to start over and set up all Xen specific
> interfaces again.
> +
> +=back
> +
> +=back
> +
> =item B
This entry is now a duplicate of "sc", I think we can remove it. And
probably keep the explanation.
> The domain has crashed, which is always a violent ending. Usually
Thanks,
--
Anthony PERARD
> part of filtering.
>
> Signed-off-by: Jan Beulich
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
istine build.
>
> As per dd40177c1bc8 ("x86-64/EFI: add CFLAGS to check compile") dropping
> the use of $(CFLAGS) altogether isn't an option, though. Hence remove
> the problematic options only.
>
> Signed-off-by: Jan Beulich
In any case, patch looks fine:
Reviewed-
houldn't be a problem, seeing that various
> > other tools/ components do so, too.
> >
> > Signed-off-by: Jan Beulich
>
> Fine with me.
>
> Reviewed-by: Juergen Gross
Acked-by: Anthony PERARD
Thanks,
--
Anthony PERARD
: Fouad Hilly
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
+ test-amd64-amd64-libvirt-qcow2
+ test-amd64-amd64-libvirt-raw
+ test-amd64-amd64-xl-vhd
In any case, the list of test would be the same as for the existing
branch "linux-linus" or "linux-6.1" branches.
Signed-off-by: Anthony PERARD
---
ap-common | 2 +-
mfi-common | 2 +-
colors;
> +
> +ret = do_domctl(xch, );
> +
> +if ( local )
> +xc_hypercall_buffer_free(xch, local);
It doesn't looks like you need to check if "local != NULL" before
calling xc_hypercall_buffer_free(), it should work even with
local==NULL. This is even used multiple time in xc_kexec.
> +
> +return ret;
> +}
Thanks,
--
Anthony PERARD
I'm not
sure it's such a good idea to change it.
But maybe it's ok to change the path because xl devd is expected add
then remove this path? And that pid isn't going to be useful to anything
else?
I'd rather not change the path, but if you still think it's ok, we can
go for it. Thought?
Thanks,
--
Anthony PERARD
ig. This skips the QMP queries
> for chardevs and VNC, but this xenpv QEMU instance isn't expected to
> provide those - only qdisk (or 9pfs backends after an upcoming change).
>
> Signed-off-by: Jason Andryuk
Acked-by: Anthony PERARD
Thanks,
--
Anthony PERARD
total_ticks;
> + uint64_t write_reqs_submitted;
> + uint64_t write_reqs_completed;
> + uint64_t write_sectors;
> + uint64_t write_total_ticks;
> + uint64_t io_errors;
> + uint64_t flags;
> +};
Is that a binary interface for an external project? I'm asking because
`__pad` would seems useless otherwise.
If it is part of an interface, please add a comment about it, add a link
to the project/source where this interface is described, and where is
the canonical location? Also, is there an header we could maybe just
use if it's in the system or an header we could import into the
repository?
Thanks,
--
Anthony PERARD
On Mon, Feb 26, 2024 at 10:23:37AM +0100, Jan Beulich wrote:
> On 20.02.2024 15:07, Anthony PERARD wrote:
> > --- a/automation/scripts/build-test.sh
> > +++ b/automation/scripts/build-test.sh
> > @@ -9,6 +9,37 @@
> > # Set NON_SYMBOLIC_REF=1 if you want to use t
On Thu, Feb 22, 2024 at 07:22:45AM +, Chen, Jiqian wrote:
> On 2024/2/21 23:03, Anthony PERARD wrote:
> > On Fri, Jan 12, 2024 at 02:13:17PM +0800, Jiqian Chen wrote:
> >> diff --git a/tools/libs/light/libxl_pci.c b/tools/libs/light/libxl_pci.c
> >> index a1c6e8
r unfinished jobs
Yeah, that happens from time to time. My plan to fix this is to
upgrade to a newer version of Debian, it just takes time.
Cheers,
--
Anthony PERARD
arczykowski-Górecki
>
> Reviewed-by: Jason Andryuk
Acked-by: Anthony PERARD
Thanks,
--
Anthony PERARD
libxl__device_add(gc, domid, __vkb_devtype,
> + _config->vkbs[i]);
While there, could you check the return value of that function? That
would be having:
ret = libxl__device_add();
if (ret) goto error_out;
With that: Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
Gross
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
On Tue, Feb 20, 2024 at 01:20:16PM +0100, Jan Beulich wrote:
> On 20.02.2024 12:18, Anthony PERARD wrote:
> > On Tue, Feb 20, 2024 at 09:43:56AM +0100, Jan Beulich wrote:
> >> Because of using "-include", failure to (re)build auto.conf (with
> >> auto.conf.cmd
, irq);
> }
> -rc = xc_domain_irq_permission(ctx->xch, domid, irq, 0);
> +if ( has_gsi )
> +rc = xc_domain_gsi_permission(ctx->xch, domid, irq, 0);
Why do you use the xc_domain_gsi_permission() with "irq" here, but not
in pci_add_dm_done() ?
> +if ( !has_gsi || rc == -EOPNOTSUPP )
> +rc = xc_domain_irq_permission(ctx->xch, domid, irq, 0);
> if (rc < 0) {
> LOGED(ERROR, domid, "xc_domain_irq_permission irq=%d", irq);
> }
These changes to libxl are quite confusing, there's a mixed up between
"gsi" and "irq", it's hard to follow.
Thanks,
--
Anthony PERARD
ng to
work, as the error check on fopen() will produce the same error message.
;-)
And without that else part, the code could be simplified to:
/* If /gsi path doesn't exist, fallback to /irq */
if (r && errno == ENOENT)
sysfs_path = "/irq";
And those comments also apply to the changes in pci_remove_detached().
Thanks,
--
Anthony PERARD
date regulary.
So switch to 6.1. This will change the default Linux tree for all Arm
jobs that aren't on "linux-*" osstest branches.
Signed-off-by: Anthony PERARD
---
Notes:
I plan to also change to use Linux 6.1 on X86 a bit later.
ap-common | 2 +-
1 file changed, 1 insertion
n error.
This patch also make use of a GitLab feature, "log sections", which we
will collapse by default. One section per commit been built.
There's a bit of colour added to the logs.
Signed-off-by: Anthony PERARD
---
Notes:
Examples:
- on success:
https://gitlab.com/
config/auto.conf" instead of using "$*".
"syncconfig" is going to generate "auto.conf" and not "$*.conf". And it
would make easier to find the "rm" command via "grep".
> $(Q)$(MAKE) $(build)=tools/kconfig syncconfig
>
Thanks,
--
Anthony PERARD
On Wed, Feb 14, 2024 at 06:06:38PM +, Andrew Cooper wrote:
> On 14/02/2024 6:00 pm, Anthony PERARD wrote:
> > The `which` command is not standard, may not exist on the build host,
> > or may not behave as expected by the build system. It is recommended
> > to use `co
debug log from libxl__disk_from_xenstore(),
> correct coding style
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
move the sanity checking
> > of 9pfs parameters from xl to libxl, too.
> >
> > Signed-off-by: Juergen Gross
> > Reviewed-by: Jason Andryuk
>
> Sorry Anthony, just found your R-b: in my spam folder :-(
I wonder if my @cloud.com email address would work better, and be less
broken.
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
? With a much shorter message
like "Don't ignore Kconfig error anymore".
Cheers,
--
Anthony PERARD
Std 1003.1-2008, but was optional before).
Signed-off-by: Anthony PERARD
Tested-by: Marek Marczykowski-Górecki
---
Notes:
v2:
- also replace it in xen/build.mk
- mention that it's a mandatory feature since edition 2008.
- some other rework of the commit message.
xen/Makefile | 4
On Wed, Feb 14, 2024 at 11:18:18AM +0100, Jürgen Groß wrote:
> On 13.02.24 19:03, Anthony PERARD wrote:
> > On Thu, Feb 08, 2024 at 05:55:39PM +0100, Juergen Gross wrote:
> > > +struct libxl__aop9_state {
> > > +libxl__spawn_state spawn;
> &g
ed.
>
> Signed-off-by: Juergen Gross
> Reviewed-by: Jason Andryuk
> Reviewed-by: Julien Grall
Acked-by: Anthony PERARD
Thanks,
--
Anthony PERARD
uffix from the define, but
it's ok to keep it as well, just to avoid a round trip.
In any case, patch looks good:
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
- test max_files and max_open_files, too (Jason Andryuk)
> V4:
> - fix man page to use the "xen_9pfsd" type due to idl limitation
> (Jason Andryuk)
> - set (most of) the defaults in libxl (Anthony Perard)
Patch looks good to me now:
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
The `which` command is not standard, may not exist on the build host,
or may not behave as expected. It is recommanded to use `command -v`
to find out if a command exist and have it's path, and it's part of a
POSIX shell standard.
Signed-off-by: Anthony PERARD
---
xen/Makefile | 4 ++--
1 file
.idl
> @@ -34,6 +34,7 @@ libxl__device_kind = Enumeration("device_kind", [
> (16, "VINPUT"),
> (17, "VIRTIO_DISK"),
> (18, "VIRTIO"),
> +(19, "XEN_9PFS"),
That's going to need to be rebased ;-).
Patch looks fine otherwise: Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
On Thu, Feb 08, 2024 at 05:55:25PM +0100, Juergen Gross wrote:
> Add the basic access macros for unaligned data to common-macros.h.
>
> Signed-off-by: Juergen Gross
> Acked-by: Andrew Cooper
Acked-by: Anthony PERARD
Thanks,
--
Anthony PERARD
0.
>
> Signed-off-by: Cyril Rébert (zithro)
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
t_usage, strtoul(tmp, NULL, 0));
Per coding style, it's better to have both side of an if..else to have
{}-block or none of them. So could you add a {} block in the else, or
remove the {} from the true side if we remove the LOG()?
Thanks,
--
Anthony PERARD
688 ("tools/[lib]xl: Add vmtrace_buf_size parameter")
Otherwise, patch looks fine, so with the SOB: Acked-by: Anthony PERARD
Thanks,
--
Anthony PERARD
The build information isn't readily available and won't exist in
> some call trees, so it isn't usable either.)
>
> Let disk_try_backend() allow format empty for Phy cdrom drives.
>
> Signed-off-by: Jason Andryuk
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
e trouble with an empty params
> field.
>
> This works for non-stubdom HVMs as well.
>
> Signed-off-by: Jason Andryuk
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
RAY_MOVED', 'data': {'device': 'ide-5632', 'tray-open':
True, 'id': 'ide-5632'}
Cheers,
--
Anthony PERARD
gt; +if (cis->retries++ < 10 ) {
> +LOGD(DEBUG, qmp->domid, "Retrying QMP cdrom change\n");
> +rc = libxl__ev_time_register_rel(ao, >timeout_retry,
> + cdrom_insert_addfd_retry, 100);
> +if (rc) goto out;
>
> -rc = libxl__device_from_disk(gc, domid, disk, );
> +return;
> +} else {
> +goto out;
> +}
> +}
> +
> +rc = libxl__device_from_disk(gc, cis->disk_domid, disk, );
> if (rc) goto out;
> be_path = libxl__device_backend_path(gc, );
> libxl_path = libxl__device_libxl_path(gc, );
> @@ -1257,7 +1500,10 @@ static void cdrom_insert_done(libxl__egc *egc,
> {
> EGC_GC;
>
> +LOGD(DEBUG, cis->domid, "rc=%d", rc);
I don't think this is useful because libxl__ao_complete() will print rc
as well.
> libxl__ev_time_deregister(gc, >time);
> +libxl__ev_time_deregister(gc, >timeout_retry);
> libxl__ev_qmp_dispose(gc, >qmp);
> if (cis->qmp.payload_fd >= 0) close(cis->qmp.payload_fd);
> libxl__ev_slowlock_unlock(gc, >qmp_lock);
--
Anthony PERARD
minimal changes to work with libxl:
> https://github.com/xapi-project/blktap/pull/394
It might be nice to have an entry in the ChangeLog. But it's looks like
the blktap project isn't ready yet, so we might need to point that out.
Cheers,
--
Anthony PERARD
locally.");
Here, the coding style call to have both side of the if..else to have { }
or none of them. Could you add {}-block for the else side?
Beside that, patch looks fine to me:
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
/null
> +local minor
> +local pid
> +
> +claim_lock "block"
> +
> +if tap_shared ; then
> +return
> +fi
> +
> +minor=$( xenstore_read "$XENBUS_PATH/minor" )
> +pid=$( xenstore_read "$XENBUS_PATH/pid" )
> +
> +[ -n "$minor" ] || fatal "minor missing"
> +[ -n "$pid" ] || fatal "pid missing"
> +do_or_die tap-ctl close -p "$pid" -m "$minor" > /dev/null
> +do_or_die tap-ctl detach -p "$pid" -m "$minor" > /dev/null
Should we also call `tap-ctl free`, like `tap-ctl destroy` seems to do?
> +
> +release_lock "block"
> }
>
> command=$1
Thanks,
--
Anthony PERARD
vm
> 'vdev=xvdf,backendtype=tap,format=vhd,target=/srv/target.vhd'
>
> Format raw also works to run an "aio:" tapdisk.
>
> Signed-off-by: Jason Andryuk
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
I look at
both version).
Thanks,
--
Anthony PERARD
On Tue, Feb 06, 2024 at 03:38:05PM +0100, zithro wrote:
> On 05 Feb 2024 18:27, Anthony PERARD wrote:
> > On Wed, Jan 31, 2024 at 06:51:34PM +0100, Cyril Rébert wrote:
> > > Add a command line option to xentop to be able to display dom0 first, on
> > > top of the list.
On Wed, Feb 7, 2024 at 2:55 PM Andrew Cooper wrote:
>
> On 07/02/2024 2:34 pm, Anthony PERARD wrote:
> > On Wed, Feb 7, 2024 at 2:24 PM Andrew Cooper
> > wrote:
> >>>> Stage: test
> >>>> Name: qemu-smoke-riscv64-gcc
> >>> I have to adm
er than expected?
I could try to setup gitlab-runner/docker to have the containers
running on a single node, since my guess is Linux doesn't do that well
enough.
Cheers,
--
Anthony PERARD
gt; /vm/844dea4e-44f8-4e3e-8145-325132a31ca5 = 'No other target' -o 'No target' =
> 'No other target' ']'
>
> Signed-off-by: Jason Andryuk
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
On Mon, Feb 05, 2024 at 04:52:16PM +, Oleksandr Tyshchenko wrote:
> On 05.02.24 17:10, Anthony PERARD wrote:
> > On Fri, Feb 02, 2024 at 12:49:03PM +0200, Oleksandr Tyshchenko wrote:
> >> +grant_usage=1,? { libxl_defbool_set(>disk->grant_usage,
> >
-off-by: Cyril Rébert (zithro)
Looks like this wants:
Fixes: 91c3e3dc91d6 ("tools/xentop: Display '-' when stats are not available.")
Otherwise, patch looks fine:
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
te the man page? Here "docs/man/xentop.1.pod""
Thanks,
--
Anthony PERARD
Fixes: 024e7131be5c ("tools: don't expose XENFEAT_hvm_pirqs by default")
Signed-off-by: Anthony PERARD
---
tools/golang/xenlight/helpers.gen.go | 6 ++
tools/golang/xenlight/types.gen.go | 1 +
2 files changed, 7 insertions(+)
diff --git a/tools/golang/xenlight/helpers.gen.g
ant_usage", libxl_path));
> +if (!tmp) {
> +LOG(ERROR, "Missing xenstore node %s/grant_usage", libxl_path);
> +goto cleanup;
I wonder if it's such a good idea to make this node mandatory. Could we
just apply the default value if the path is missing? I don't think the
value is going to be used anyway because I don't think from_xenstore() is
used during guest creation, and it looks like "grant_usage" is only
useful during guest creation. Also, the "grant_usage" node isn't
mandatory in "libxl_virtio.c", so no need to do something different
for disk.
> +}
> +libxl_defbool_set(>grant_usage, strtoul(tmp, NULL, 0));
> }
>
> disk->vdev = xs_read(ctx->xsh, XBT_NULL,
Thanks,
--
Anthony PERARD
On Wed, Jan 31, 2024 at 04:18:43PM +0100, Jürgen Groß wrote:
> On 12.01.24 17:55, Anthony PERARD wrote:
> > On Thu, Jan 04, 2024 at 10:00:38AM +0100, Juergen Gross wrote:
> > > +static int xen9pfsd_spawn(libxl__egc *egc, uint32_t domid,
> &g
I've started an osstest flight with this patch series and your other
ocaml patch series, and so far osstest seems happy with it. The flight
isn't finished but all build jobs succeed, and a lot of the tests jobs
as well.
So:
Acked-by: Anthony PERARD
Thanks,
--
Anthony PERARD
section renaming and we should be able
> to run the coverage.
>
> Fixes: e321576f4047 ("xen/build: start using if_changed")
> Signed-off-by: Michal Orzel
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
On Mon, Jan 22, 2024 at 10:54:13AM +, Anthony PERARD wrote:
> On Mon, Jan 22, 2024 at 11:04:41AM +0100, Jan Beulich wrote:
> > On 19.01.2024 16:25, Anthony PERARD wrote:
> > > On Fri, Jan 19, 2024 at 09:43:30AM +0100, Michal Orzel wrote:
> > >> Is my understan
On Mon, Jan 22, 2024 at 11:04:41AM +0100, Jan Beulich wrote:
> On 19.01.2024 16:25, Anthony PERARD wrote:
> > On Fri, Jan 19, 2024 at 09:43:30AM +0100, Michal Orzel wrote:
> >> Is my understanding correct that by switching from extra-y to targets we
> >> a
ncludes
"libelf-temp.o" and for example "libelf-dominfo.o". So the only thing
preventing $(COV_FLAGS) from been added when building "libelf-tools.o"
for example is that we set `COV_FLAGS:=` for "libelf.o".
Cheers,
--
Anthony PERARD
ake all "libelf-*.o" is
different: `make --shuffle=reverse V=2`.
So, adding extra object to $(nocov-y) is a workaround, but I think a
better fix would be to add those objects to $(targets) instead of
$(extra-y). I think I've made a mistake by using $(extra-y) instead of
$(targets) in that original commit.
Cheers,
--
Anthony PERARD
Without this, building "ioemu-stubdom" fails on Debian Buster or
Bookworm, with:
/home/osstest/build.184372.build-amd64/xen/stubdom/mini-os-x86_64-ioemu/mini-os.o:
in function `xenfb_pv_display_init':
ungetc.c:(.text+0x43533): undefined reference to `pt_base'
Signed-off-by: Anth
mostly in the subject only.
>
> Can be fixed on commit, because some of them look like they're otherwise
> ready to go in.
For all these patch, with the subject fixed:
Acked-by: Anthony PERARD
Cheers,
--
Anthony PERARD
;
> +
> +if (rc == 0)
> +libxl__device_add_async(egc, domid, __p9_devtype, p9, aodev);
> +
> +aodev->rc = rc;
> +if (rc)
> +aodev->callback(egc, aodev);
> +}
> +
Cheers,
--
Anthony PERARD
rameters
without having to change the function prototype.
These functions tend to be called "libxl_device_*_add()", is it possible
to follow the same schema? In particular, I don't see anything xenstore
specific in the function.
Thanks,
--
Anthony PERARD
{
> +char *path;
> +
> +xasprintf(, XEN_LOG_DIR "/guests/%s", c_info->name);
> + replace_string(>path, path);
> +free(path);
> +}
> +}
Thanks,
--
Anthony PERARD
r %c = qw(
> HostProp_GenEtherPrefixBase 5e:36:0e:f5
>
> HostDiskESP300
> -HostDiskBoot 300
> +HostDiskBoot 1000
Did you tried this change on the arm32 machine as well? If so:
Acked-by: Anthony PERARD
(Or I guess we can find out the result of the test on commit.)
Thanks,
--
Anthony PERARD
8bd5d216..82565c4c10 100644
> --- a/tools/libs/light/libxl_types.idl
> +++ b/tools/libs/light/libxl_types.idl
> @@ -150,6 +150,12 @@ libxl_nic_type = Enumeration("nic_type", [
> (2, "VIF"),
> ])
>
> +libxl_p9_type = Enumeration("p9_type", [
> +(0, "unknown"),
> +(1, "qemu"),
> +(2, "xen_9pfsd"),
> +])
> +
> libxl_action_on_shutdown = Enumeration("action_on_shutdown", [
> (1, "DESTROY"),
>
> @@ -942,6 +948,11 @@ libxl_device_p9 = Struct("device_p9", [
> ("path", string),
> ("security_model", string),
> ("devid",libxl_devid),
> +("type", libxl_p9_type),
> +("max_space",integer),
> +("max_files",integer),
> +("max_open_files", integer),
> +("auto_delete", bool),
These additional fields and options probably a
LIBXL_HAVE_XEN_9PFS macro in libxl.h.
Thanks,
--
Anthony PERARD
101 - 200 of 2963 matches
Mail list logo
