n reported local
> APIC
> hardware virtualization active.
>
> Link: https://github.com/QubesOS/qubes-issues/issues/7971
> Signed-off-by: Roger Pau Monné
Should we have an entry in the changelog about this patch?
With the patch, we will need to regenerate the golang binding, at least
o
(a) avoid probing Xen
> for sizes, and (b) trivially have knowledge of the actual size of the
> buffer.
>
> While at it, fix xc_cpu_policy_destroy() to preserve errno accross free()
>
> Signed-off-by: Alejandro Vallejo
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
->leaves.buf )
> +free(policy->leaves.buf);
> +if ( policy->msrs.buf )
> +free(policy->msrs.buf);
FYI: free() already check for NULL, so the extra if() is unnecessary.
Otherwise, patch looks fine:
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
It works fine for me.
Thanks,
--
Anthony PERARD
On Tue, Dec 12, 2023 at 12:00:12PM +0100, Roger Pau Monné wrote:
> On Fri, Dec 08, 2023 at 04:02:23PM +0000, Anthony PERARD wrote:
> > CONFIG_X86_GENERIC=y and fixes around arch specific config values.
> >
> > Thanks,
> >
> > Anthony PERARD (3):
&
s/184123/
> test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsmpass
> test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass
So overall, patch looks fine to me:
Acked-by: Anthony PERARD
Thanks,
--
Anthony PERARD
On Tue, Dec 12, 2023 at 03:35:50PM +, Volodymyr Babchuk wrote:
> Hi Anthony
>
> Anthony PERARD writes:
>
> > On Fri, Dec 08, 2023 at 02:49:27PM -0800, Stefano Stabellini wrote:
> >> On Fri, 8 Dec 2023, Daniel P. Berrangé wrote:
> >> > On Thu, Dec 07,
nds them self, as seen by
a guest aren't going to change, and are not legacy. Also, a few month
ago, "qnic" would have been part of the list. Maybe a description like
"Xen backends based on legacy support" might be more appropriate. I'm
not sure listing the different backend in the description is a good
idea, as we will have to remember to change it whenever one of those
backend is been upgraded.
Cheers,
--
Anthony PERARD
pass I think.
Building qemu with something like:
./configure --enable-xen --cpu=x86_64
used to work. Can we fix that? It still works with v8.1.0.
At least, it works on x86, I never really try to build qemu for arm.
Notice that there's no "--target-list" on the configure command line.
I don't know if --cpu is useful here.
Looks like the first commit where the build doesn't work is
7899f6589b78 ("xen_arm: Add virtual PCIe host bridge support").
Could we get that fixed?
I'm sure distribution will appreciate to be able to build a single qemu
package for xen and other, rather than having a dedicated qemu-xen
package.
Cheers,
--
Anthony PERARD
On Tue, Dec 12, 2023 at 09:48:46AM +0100, Juergen Gross wrote:
> On 12.12.23 09:38, Roger Pau Monné wrote:
> > On Fri, Dec 08, 2023 at 04:02:25PM +, Anthony PERARD wrote:
> > > This is following a failure to build "arch/x86/xen/enlighten.c" in
> >
pygrub is deprecated")
So, I don't think more than that is needed. At least, now they would
also get an error saying /usr/bin/pygrub wasn't found, I think.
Cheers,
--
Anthony PERARD
ate things.
> Take it out fully now, 11 years later.
>
> Signed-off-by: Andrew Cooper
Beside the commit message that could call for a better commit, patch
looks good:
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
t,
I'm pretty sure that can be done with an hand-crafted "systemd.service"
file. One probably need to have something like "OOMPolicy=" or
"OOMScoreAdjust=" in their service file, and start the `xenstored`
daemon of their choice directly, even with -N as systemd can detect when
the daemon is ready because we use sd_notify() (at least in cxenstored).
So, I think we should keep -N.
Cheers,
--
Anthony PERARD
This is following a failure to build "arch/x86/xen/enlighten.c" in
build-i386-pvops jobs with linux 968f35f4ab1c ("Merge tag
'v6.7-rc3-smb3-client-fixes' of git://git.samba.org/sfrench/cifs-2.6")
in linux-linus branch.
Suggested-by: Juergen Gross
Signed-off-by: Anthony PER
CONFIG_X86_GENERIC=y and fixes around arch specific config values.
Thanks,
Anthony PERARD (3):
create_build_jobs: Set reset pvops_kconfig_overrides
create_build_jobs: Enable X86_GENERIC for i386 kernel pvops jobs.
ts-kernel-build: Remove use of $XEN_TARGET_ARCH
mfi-common | 12
osstest doesn't set $XEN_TARGET_ARCH, and this is a Xen build
variable, not a Linux build one. So, this code have been running with
an empty $XEN_TARGET_ARCH for a while which mean none of those
`setopt` has run in a while.
Signed-off-by: Anthony PERARD
---
ts-kernel-build | 13 -
1
by setting default values for the variables before the
`case` command.
This changes Linux arm64 builds which will not have "CONFIG_EXT4_FS=y"
anymore, but should get "CONFIG_EXT4_FS=m" instead from
`ts-kernel-build`. But resulting build still have "CONFIG_EXT4_FS=y",
so no
+ setopt CONFIG_X86_GENERIC y
It would be nice if that was working, but XEN_TARGET_ARCH is never set,
so the change isn't going to work.
I'm preparing patches to set X86_GENERIC on i386 builds, and fixing some
issues.
Thanks,
--
Anthony PERARD
nstored: remove the "-R" command line option
> tools/xenstored: remove "-N" command line option
Should we have en entry in the changelog about all these removals? Who
knows if they are used by someone or not...
Thanks,
--
Anthony PERARD
an x86 hvm guest with qdisk.
Error from guest kernel:
"2 reading backend fields at /local/domain/0/backend/qdisk/23/768"
It seems that "sector-size" is missing for the disk.
Thanks,
--
Anthony PERARD
>
> Also remove the -Wno-declaration-after-statement in some subdirectory
> as the flag is now unnecessary.
>
> Part of the commit message was take from Alexander's first proposal:
>
> Link:
> https://lore.kernel.org/xen-devel/20231128174729.3880113-1-a...@linutronix.de/
&
ssor for the kernel.
>
> We should do a 32-bit build using a more recent processor model.
That's Linux doing, that's the default model. osstest doesn't change it
or select anything in particular.
Cheers,
--
Anthony PERARD
Signed-off-by: Alejandro Vallejo
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
akefile I hope.
> Anthony/Juergen, do you have any concern if the tools are built without
> -Wdeclaration-after-statement?
I don't, and as you said, there's already quite a few
-Wno-declaration-after-statement.
It can be nice to add a new variable in the middle of a function, it's
like creating a new scope without adding extra indentation (if we wanted
a new scope, we would need {} thus the intend).
Cheers,
--
Anthony PERARD
packages have unmet dependencies:
> dconf-service : Depends: default-dbus-session-bus or
> dbus-session-bus
So, remove that new package and its dependencies before moving on.
While here, add `set -x` to help debugging.
Signed-off-by: Anthony PERARD
---
Note
On Wed, Nov 15, 2023 at 03:04:59PM +, Anthony PERARD wrote:
> On Wed, Nov 15, 2023 at 11:11:30AM +0100, Jan Beulich wrote:
> > On 14.11.2023 21:26, GitLab wrote:
> > > Pipeline #1072370735 (
> > > https://gitlab.com/xen-project/xen/-/pipelines/1072370735 ) trigge
nsuse-leap-gcc-debug
>
> Here it's unclear, as the log referenced ends too early.
I had to log into the runner to find out, because no artifact as been
uploaded to gitlab (which would have a more complete log).
Turns out that this runner also got into a "no space left" situation.
This time, runner is "gitlab-docker-swift".
Cheers,
--
Anthony PERARD
One thing I've notice when using --platform is that, if for example I
use the container "--platform=linux/amd64 alpine:3" then
"--platform=linux/arm/v6 alpine:3"; later when I only specify
"alpine:3", it's going to be the armv6, and I think docker is going to
complain if I try tu use "--platform=linux/amd64 alpine:3" without
"docker pull" first (or I guess docker build --pull).
Hope that help.
So I guess using containers "amd64/*" or "arm64v8/*" is fine, but
sometime will need to use "--platform=*".
Cheers,
--
Anthony PERARD
On Thu, Nov 09, 2023 at 04:52:36PM +, Andrew Cooper wrote:
> On 09/11/2023 3:49 pm, Anthony PERARD wrote:
> > Currently, the test rely on QEMU and Xen finishing the boot in under
> > two seconds. That's both very long and very short. Xen usually managed
> > to print "
st a different kind of language than shell is?
Also, `grep -q` doesn't wait for EOF, and just exit as soon as it found
the pattern.
Cheers,
--
Anthony PERARD
versions.
>
> The patch also removes PHYSDEV_OP from there, as that seems to be an old
> dead macro.
>
> Signed-off-by: Alejandro Vallejo
Reviewed-by: Anthony PERARD
Thanks.
Next step, reword some of those to read something like:
struct xen_sysctl sysctl = {
.cmd
both `tail` will simply exit,
resulting in a failure.
If the line we are looking for is never printed, the `timeout` on the
second `tail` will force the test to exit with an error.
Signed-off-by: Anthony PERARD
---
Notes:
The "machine might be busy" bits refere to having a gitlab-ru
oes the both depends on each other, somehow?
Is guest creation going to fails if we set XEN_DOMCTL_CONFIG_PCI_VPCI
without HAS_VPCI_GUEST_SUPPORT ?
Is the guest is going to fail to run, or fail at creation if the
hypervisor HAS_VPCI_GUEST_SUPPORT, but we didn't set
XEN_DOMCTL_CONFIG_PCI_VPCI?
Thanks,
--
Anthony PERARD
-1-anthony.per...@citrix.com/
But looks like I need to update the patch.
I think it's a bit late for 3.18, but I should be able to update the
patch for next release.
Cheers,
--
Anthony PERARD
.18. This is CI infrastructure, not part of the regular build.
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
> Signed-off-by: George Dunlap
Acked-by: Anthony PERARD
Thanks,
--
Anthony PERARD
on. This results
> in output that looks like this:
>
> ```
>89d29656 :2 1.21%
>89d298b6 :1 0.61%
>89d298c0 : 1 0.61%
> ```
>
> Signed-off-by: George Dunlap
Acked-by: Anthony PERARD
Thanks,
--
Anthony PERARD
On Mon, Oct 09, 2023 at 01:51:35PM +0100, George Dunlap wrote:
> Neither vmx nor svm trace anything, nor is there anything obvious
> worth tracing.
>
> Signed-off-by: George Dunlap
Acked-by: Anthony PERARD
Thanks,
--
Anthony PERARD
ontinue to stuff data about all exits
> into that one exit, even though we only show it in one place.
>
> Instead, refator things to only allow a single exit reason to be
> accumulated into any given event.
>
> Also put a comment explaining what's going on, and how to fix it.
>
On Mon, Oct 09, 2023 at 01:51:34PM +0100, George Dunlap wrote:
> Just like Intel's PENDING_VIRT_INTR, AMD's VINTR doesn't need an HVM
> trace record. Expect that.
>
> Signed-off-by: George Dunlap
Acked-by: Anthony PERARD
Thanks,
--
Anthony PERARD
emails.
Signed-off-by: Anthony PERARD
---
Notes:
Soon, the RISCV section might be the first (I think) section without
maintainer and without been nested in another section other than THE
REST.
Tests by checking that the following comnands returns the expected emails
mment to the makefile
> - printf instead of echo
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
e to revoke in pci_remove_detached()
> * Add a comment on top of the PIRQ unbind error path
> * Use goto to deal with errors.
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
of QEMU do you use, which work
with this patch?
What toolstack do you use to boot a guest?
Thanks,
--
Anthony PERARD
On Thu, Aug 24, 2023 at 06:27:12PM +0100, Julien Grall wrote:
> On 24/08/2023 17:58, Anthony PERARD wrote:
> > On Thu, Aug 24, 2023 at 05:46:45PM +0100, Julien Grall wrote:
> > > On 24/08/2023 17:34, Anthony PERARD wrote:
> > > > On Thu, Aug 24, 2023 at 12:15:
gt;type == XEN_BLOCK_VDEV_TYPE_HD) ?
>"hd" :
>"sd",
> - name, vdev->partition);
> -g_free(name);
> + vbd_name, vdev->partition);
> + g_free(vbd_name);
> break;
> }
> default:
Acked-by: Anthony PERARD
Thanks,
--
Anthony PERARD
!/usr/bin/env python3
Beside this shebang change, the patch looks good.
With the shebang change reverted: Acked-by: Anthony PERARD
Thanks,
--
Anthony PERARD
hell used or
the echo binary used, the "\n" would write a or justs "\n".
Bash just write "\n" for example, while dash does write a .
But, you can use `printf` instead:
printf "/*\n\n" > $@.tmp
> + sed -e 's|\*/|*//*|g' $< >> $@.tmp
> + echo "\n*/" >> $@.tmp
Same here.
Thanks,
--
Anthony PERARD
Also, there's another change needed as we've got this error:
vpci.c:344:29: error: ‘dom_xen’ undeclared (first use in this function)
344 | pdev = pci_get_pdev(dom_xen, sbdf);
Otherwise, patch looks fine to me.
Thanks,
--
Anthony PERARD
ed to say "$(src)/Makefile" now instead of Kbuild.
Beside this, patch looks fine to me:
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
ich
> ---
> v3: Unfold, for F: not being handled as originally expected.
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
re around the rule for $(TARGET), maybe
just after the rule "_distclean".
Cheers,
--
Anthony PERARD
r is calling
"Makefile.asm-generic", or "Rules.mk" is other cases.
In this patch, you can see $(obj) been set in "xen/Makefile":
$(MAKE) -f $(srctree)/scripts/Makefile.asm-generic
obj=arch/$(SRCARCH)/include/generated/asm
Another thing to know, `make` runs from the build directory, so in
Oleksii second case, `make` is running in "xen/xen_build", so $(obj) point
to a directory within the build directory.
For the CFLAGS, we can use $(objtree) (even if it is just "."), which
always point to the top directory of the build tree.
I hope that clarifies things.
Cheers,
--
Anthony PERARD
"$(unwanted)" variable, which is
used to remove old wrapper when an header is removed from "generic-y".
But instead of the "-include $(kbuild-file)", could you include
"$(src)/Makefile" instead like we do in "Rules.mk"? We don't have
$(kbuild-file) ma
On Wed, Sep 06, 2023 at 02:50:22PM +0200, Jan Beulich wrote:
> On 06.09.2023 14:40, Anthony PERARD wrote:
> > On Thu, Aug 31, 2023 at 08:15:13AM +0200, Jan Beulich wrote:
> >> If the F: description is to be trusted, the two xen/arch/x86/hvm/
> >> lines were fully
MEMORY MANAGEMENT
- X86 ARCHITECTURE
(see ./scripts/get_maintainer.pl --sections -f xen/arch/x86/mm/mem_access.c)
Also, now "xen/include/xen/monitor.h" is only "THE REST".
On the other hand, there's no change for "xen/common/monitor.c", so the
pattern works for this particular file.
Cheers,
--
Anthony PERARD
gt; overlay support")
> Reported-by: Jan Beulich
> Signed-off-by: Michal Orzel
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
On Thu, Aug 24, 2023 at 05:46:45PM +0100, Julien Grall wrote:
> Hi Anthony,
>
> On 24/08/2023 17:34, Anthony PERARD wrote:
> > On Thu, Aug 24, 2023 at 12:15:39PM +0100, Julien Grall wrote:
> > > On 18/08/2023 18:04, Anthony PERARD wrote:
> > > > So, this new pc
On Thu, Aug 24, 2023 at 12:15:39PM +0100, Julien Grall wrote:
> On 18/08/2023 18:04, Anthony PERARD wrote:
> > So, this new pci_revoke_permissions() function been place before
> > do_pci_remove() will make it harder to follow what do_pci_remove() does.
> > Does it need to b
On Thu, Aug 24, 2023 at 10:51:20AM +0100, Andrew Cooper wrote:
> On 24/08/2023 9:52 am, Anthony PERARD wrote:
> > On Wed, Aug 23, 2023 at 07:05:56PM +0100, Andrew Cooper wrote:
> >> On 23/08/2023 4:23 pm, Anthony PERARD wrote:
> >>> On failure of "build&qu
On Wed, Aug 23, 2023 at 07:05:56PM +0100, Andrew Cooper wrote:
> On 23/08/2023 4:23 pm, Anthony PERARD wrote:
> > On failure of "build"-each-commit script, the next command that move
> > the log back into the build directory isn't executed. Fix that by
> > using
On failure of "build"-each-commit script, the next command that move
the log back into the build directory isn't executed. Fix that by
using "after_script" which is always executed even if the main
"script" fails. (We would still miss the log when the jobs times
ever downloaded or created during build,
> the related actions can be dropped.
>
> Fixes: bdd516dc6b2f ("vtpm/vtpmmgr and required libs to stubdom/Makefile")
> Signed-off-by: Juergen Gross
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
On Wed, Aug 23, 2023 at 09:21:26AM +0200, Jan Beulich wrote:
> Two entries were left in place by d638fe233cb3 ("libxl: use the cpuid
> feature names from cpufeatureset.h"), despite matching the generated
> names.
>
> Signed-off-by: Jan Beulich
Acked-by: Anthony PERARD
tant (2023-08-22 18:12:34)
> when the failures were detected in all three cases.
It was the same machine used for all builds, godello0.
I don't know what happened to the machine, osstest rebooted it to
gather log, but nothing useful in it.
Cheers,
--
Anthony PERARD
going to write a
C file in this directory, run `make clean` and lost their source. Or,
copy this makefile somewhere else. Would it be ok to just spell out all
the .c files that are expected to be generated by this makefile?
Cheers,
--
Anthony PERARD
gt; few uses, but then likely not merely to combine multiple commands'
> output.)
Maybe using `{ } > out` might be better that using `( ) > out`. I think
it would result in one less fork of the shell, without changing the
resulting file, so always good to take.
You should add also `set -e` at the beginning, to take care of the `sed`
command failing.
Or just use a temporary file.
--
Anthony PERARD
On Wed, Aug 16, 2023 at 08:06:52AM +0200, Jan Beulich wrote:
> On 11.08.2023 15:48, Anthony PERARD wrote:
> > But isn't it doing doing pattern matching on an error message going to
> > lead sometime to false positive? Linux's build system seems to works
> > fine by just
his patch at [1], there's been no reply
and the patch hasn't changed.
[1]
https://lore.kernel.org/xen-devel/9975f41c-c149-445a-8122-c15cfe5511b0@perard/
Did this fell through the cracks?
Cheers,
--
Anthony PERARD
+ b/tools/xs-clients/Makefile
I'm tempted to ask for the targets "clients-install" and
"clients-uninstall" to be removed from this makefile. Nothing is calling
them in our build system and something outside the git tree that rely on
that would need to be adjusted to the new directory. But maybe that can
be done in a followup patch as it would help with reverting it if the
targets are actually useful.
In any case, the patch is already good:
Acked-by: Anthony PERARD
Thanks,
--
Anthony PERARD
gt; the two confusing names within the same function. They are left
> unchanged for now.
>
> No functional changes intented.
>
> Signed-off-by: Julien Grall
Acked-by: Anthony PERARD
Thanks,
--
Anthony PERARD
= 0;
> +
> out_fail:
> pci_remove_detached(egc, prs, rc); /* must be last */
> }
> @@ -2242,6 +2258,8 @@ static void pci_remove_detached(libxl__egc *egc,
> if (rc && !prs->force)
> goto out;
>
> +pci_revoke_permissions(egc, prs);
> +
> isstubdom = libxl_is_stubdom(CTX, domid, );
>
> /* don't do multiple resets while some functions are still passed
> through */
Thanks,
--
Anthony PERARD
file, so line should
be a `str`. `universal_newlines` is available on python 2.7. A new
alias `text` is only available in python 3.7.
Signed-off-by: Anthony PERARD
---
Notes:
I've only tested the patch on Debian Bookworm, with python-is-python3
package (python symlink) as osste
On Tue, Aug 15, 2023 at 04:44:57PM +0200, Jan Beulich wrote:
> On 15.08.2023 16:28, Andrew Cooper wrote:
> > On 15/08/2023 3:26 pm, Anthony PERARD wrote:
> >> On Tue, Aug 15, 2023 at 02:35:55PM +0200, Jan Beulich wrote:
> >>> The "cpuid_empty" label is al
ecb747b ("libxl: introduce MSR data in libxl_cpuid_policy")
> Signed-off-by: Jan Beulich
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
bably remove XEN_RUN_STORED from
"config/Paths.mk.in".
In any case, patch looks fine:
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
ething
after the fact. So we can end up with a build of Xen with an embedded
.config which says X86_64_V3 where in fact it's only a build with the
baseline ABI.
Can't we just fail the build right here instead?
I don't see any need to let Kconfig know if the compiler can do
x86-64-vX or not, besi
ut executable stacks")
> Signed-off-by: Jan Beulich
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
he exit value. They've got a few trick to deal with
-Wno-* and with clang.
For -Wno-$(warning), they test -W$(warning) instead. For clang, they've
enable additional warnings:
-Werror=unknown-warning-option
-Werror=ignored-optimization-argument
-Werror=option-ignored
-Werror=unused-command-line-argument
In any case, the patch is fine.
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
out this patch, but I guess we kind of expect pygrub to be
built at the same time as `xl'. And it still allow to use "pygrub" if
one specify the full path to it. So,
Acked-by: Anthony PERARD
Thanks,
--
Anthony PERARD
ge. The default is
> on if pygrub is being built, and off if it isn't. Without pygrub the
> build of libfsimage can be enabled via --enable-libfsimage.
>
> Signed-off-by: Juergen Gross
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
to use pygrub is thus a step towards a reduction of attack surface.
>
> Default is still to build and install pygrub.
>
> Signed-off-by: Juergen Gross
Acked-by: Anthony PERARD
Thanks,
--
Anthony PERARD
+])
> +AS_IF([test "x$enable_libfsimage" = "xyes"], [libfsimage=y], [libfsimage=n])
> +AC_SUBST(libfsimage)
> +
Should we issue an error if one does "--disable-libfsimage
--enable-pygrub" ? Or just let the build of pygrub fails?
Also, "--disable-libfsimage" alone will keep "pygrub" enabled, so we
should probably check.
Thanks,
--
Anthony PERARD
> to use pygrub is thus a step towards more security.
>
> Default is still to build and install pygrub.
>
> Signed-off-by: Juergen Gross
Acked-by: Anthony PERARD
Thanks,
--
Anthony PERARD
the later fields.
I think the author of the comment meant that they couldn't create a
regex that locate the interface name, and instead used strpbrk(). But if
the comment is confusing, it's not helpful.
> Signed-off-by: Jan Beulich
Acked-by: Anthony PERARD
Thanks,
--
Anthony PERARD
t; to "if ( hwp )" and re-org code.
> Use %PRIu32 instead of %u - this lengthens some strings past 80 chars
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
of(typeof(*sys_para), u.cppc_para));
> +BUILD_BUG_ON(offsetof(typeof(*user_para), turbo_enabled) !=
> + offsetof(typeof(*sys_para), turbo_enabled));
These could have been done by defining a temporary macro to avoid
repeating the fields name twice, but this sanity check is good and
should prevent anyone from changing one struct without changing the
other one.
Thanks.
Reviewed-by: Anthony PERARD
Cheers,
--
Anthony PERARD
and ramdisk on
this jobs is now about 42MB, so not enough space in /var/run.
So, to avoid writing a big binairy in ramfs, we will use /var/lib
instead, like we already do when saving the device model state on
migration.
Reported-by: Jan Beulich
Signed-off-by: Anthony PERARD
---
tools/libs/light
wed-by: Henry Wang
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
On Mon, Jul 31, 2023 at 02:15:35PM +0200, Jens Wiklander wrote:
> Adds a new "ffa" value to the Enumeration "tee_type" to indicate if a
> guest is trusted to use FF-A.
>
> Signed-off-by: Jens Wiklander
> Reviewed-by: Bertrand Marquis
> Reviewed-by: Henry Wa
On Thu, Jul 27, 2023 at 11:05:33AM -0400, Jason Andryuk wrote:
> On Thu, Jul 27, 2023 at 6:27 AM Anthony PERARD
> wrote:
> >
> > On Wed, Jul 26, 2023 at 01:09:34PM -0400, Jason Andryuk wrote:
> > > Add a union and struct so that most of the scaling variables of struct
fd, escape
> +NULL, // list terminator - do not use
So, you are going back and forth between C and C++ comment style, any
reason? The preferred style is '/* comment */' so previous patch was
better in that regards.
With the comment style fixed: Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
On Thu, Jul 27, 2023 at 12:00:54PM +0100, Anthony PERARD wrote:
> On Wed, Jul 26, 2023 at 01:09:38PM -0400, Jason Andryuk wrote:
> > diff --git a/tools/misc/xenpm.c b/tools/misc/xenpm.c
> > index 1c474c3b59..21c93386de 100644
> > --- a/tools/misc/xenpm.c
> > +++ b/tools
On Thu, Jul 27, 2023 at 09:54:17AM -0400, Jason Andryuk wrote:
> On Thu, Jul 27, 2023 at 7:32 AM Anthony PERARD
> wrote:
> >
> > On Wed, Jul 26, 2023 at 01:09:41PM -0400, Jason Andryuk wrote:
> > > @@ -772,6 +812,32 @@ static void print_cpufreq_para(int cpuid, struct
will replace ?= by an equivalent but with immediate expansion.
Reported-by: Jason Andryuk
Signed-off-by: Anthony PERARD
---
Notes:
v3:
- replace evaluation on first use construct by immediate expansion which
isn't likely to break and is clearer.
Config.mk | 8 ++--
1 file changed, 6
function
So to avoid having these command been run more than necessary, we
will replace ?= by an equivalent but with immediate expansion.
Reported-by: Jason Andryuk
Signed-off-by: Anthony PERARD
---
Notes:
v3:
- replace evaluation on first use construct by immediate expansion which
e-effects (such as the info or eval or similar
> functions) then these side-effects will be seen every time a command is
> invoked.
The issue was reported on IRC by jandryuk.
So, I've locate a few obvious candidate to fix, maybe there's more $(shell) to
change?
Anthony PERARD
On Thu, Jul 27, 2023 at 10:38:03AM +, Oleksandr Tyshchenko wrote:
>
>
> On 27.07.23 12:50, Anthony PERARD wrote:
>
> Hello Anthony
>
> > On Wed, Jul 26, 2023 at 05:14:59PM +0300, Oleksandr Tyshchenko wrote:
> >> From: Oleksandr Tyshchenko
> >&
param:val arguments as explained in the usage description.
>
> Parameter names are just checked to the first 3 characters to shorten
> typing.
>
> Some options are hardware dependent, and ranges can be found in
> get-cpufreq-para.
>
> Signed-off-by: Jason Andryuk
> Ac
>lowest_nonlinear);
All these %u should be %"PRIu32", right? Even if the rest of the
function is bogus... and even if it's probably be a while before %PRIu32
is different from %u.
Thanks,
--
Anthony PERARD
201 - 300 of 2963 matches
Mail list logo
