inted with this, there's going to
be some kind of hidden bug (even if probably easy to spot during
development).
> {
> +printf("scaling_avail_gov: %s\n",
> + p_cpufreq->scaling_available_governors);
Thanks,
--
Anthony PERARD
ther fields inside op->u.get_para.u.s.u.* won't be
> used for hwp, so this will simplify the change when hwp support is
> introduced and re-indents these lines all together.
>
> Signed-off-by: Jason Andryuk
> Acked-by: Jan Beulich
Acked-by: Anthony PERARD
Thanks,
--
Anthony PERARD
er CHECK_* macro, but that
would be a lot of work. (xen/include/xen/compat.h and how it's used in
xen/include/compat/xlat.h)
Unless you feel like adding more build check, I guess the patch is good
enough like that:
Acked-by: Anthony PERARD
Thanks,
--
Anthony PERARD
guration:
skip because "update_config" is NULL.
So, I think the patch is fine, adding virtio to the device_type_tbl
array is good for completeness, but the patch description may be
misleading.
Did I miss something?
Thanks,
--
Anthony PERARD
On Fri, Jun 23, 2023 at 10:07:02AM +0200, Jan Beulich wrote:
> On 22.06.2023 17:30, Anthony PERARD wrote:
> > --- a/xen/Makefile
> > +++ b/xen/Makefile
> > @@ -11,10 +11,10 @@ export XEN_FULLVERSION =
> > $(XEN_VERSION).$(XEN_SUBVERSION)$(XEN_EXTRAVERSION
xec libxl_primary_console_exec_0x041800
> +
Also, could you add the extra NULL argument in the function call of both
"libxl_console_exec_0x040700()" and
"libxl_primary_console_exec_0x040700()" ?
Thanks,
--
Anthony PERARD
ehavior
> using DEFAULT_ESCAPE_SEQUENCE.
>
> Signed-off-by: Peter Hoyes
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
ect_is_array(o)) {
I think a comment here would useful to point out that we are parsing the
format from previous version of Xen.
> +co = o;
> +cpuid_only = true;
> +goto parse_cpuid;
> + }
Otherwise, the patch looks good now:
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
> + json_parse_type="JSON_MAP",
> check_default_fn="libxl__cpuid_policy_is_empty",
Maybe we should have json_parse_type as either "JSON_ARRAY | JSON_MAP"
or just "JSON_ANY" since nothing beside libxl is supposed to do
something with it, and when migrating from a previous version, we are
going to have an array.
I don't think anything is using json_parse_type for this
libxl_cpuid_policy_list, so I don't think it matter which type we use.
Thanks,
--
Anthony PERARD
change it on commit or should I send a v2?
I've pushed the patch to "pretest" with this modification.
If osstest is happy with the patch (that is no regression with a
"xen-unstable" flight), it will be committed.
Thanks,
--
Anthony PERARD
On Mon, Jul 17, 2023 at 04:46:25PM +0200, Roger Pau Monné wrote:
> On Thu, Jul 13, 2023 at 11:39:53AM +0100, Anthony PERARD wrote:
> > On Tue, Jul 11, 2023 at 11:22:30AM +0200, Roger Pau Monne wrote:
> > > diff --git a/tools/libs/light/libxl_cpuid.c
> > > b/too
On Mon, Jul 17, 2023 at 04:36:11PM +0200, Roger Pau Monné wrote:
> On Wed, Jul 12, 2023 at 05:39:01PM +0100, Anthony PERARD wrote:
> > On Tue, Jul 11, 2023 at 11:22:27AM +0200, Roger Pau Monne wrote:
> > > Add a new array field to libxl_cpuid_policy in order to store the
But git on buster still use v1 by default. Force it to
use v2.
This needs a git-cache-proxy version that can allow to switch to v2 of
the protocol. A bug is open upstream to track this change:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1040476
Signed-off-by: Anthony PERARD
---
Notes:
On Tue, Jul 04, 2023 at 11:56:54AM +0200, Roger Pau Monné wrote:
> On Tue, Jul 04, 2023 at 10:37:38AM +0100, Anthony PERARD wrote:
> > On Wed, Jun 28, 2023 at 02:31:39PM +0200, Roger Pau Monné wrote:
> > > On Fri, Jun 23, 2023 at 03:04:21PM +, osstest service owner wrote:
>
us statement kind
of useful.
> +policy->msr[i + 1].index = XC_MSR_INPUT_UNUSED;
> +
> +return >msr[i];
> +}
Thanks,
--
Anthony PERARD
t some
> new cpuid features will be available as a result of the change.
>
> While there constify cpuid_flags name field.
>
> Signed-off-by: Roger Pau Monné
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
ed.
>
> Signed-off-by: Roger Pau Monné
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
id_dispose(libxl_cpuid_policy_list *pl)
> free(policy->cpuid);
> }
>
> +if (policy->msr)
You don't need to test for NULL, you can call free() in this case as
well.
> + free(policy->msr);
> +
> free(policy);
> *pl = NULL;
> return;
--
Anthony PERARD
}
This looks like a lot of work. We could just call
free(cpuid_list[i].policy[j]) and that's all, as cpuid_list will be gone
right after the loop.
Also, please add {} for the second "for ()" loop.
> +}
> +free(policy->cpuid);
> }
Beside some the coding style pointing out, the patch looks fine:
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
> +{
> +PERROR("Failed to set d%d's policy (err leaf %#x, subleaf %#x, msr
> %#x)",
> + domid, err_leaf, err_subleaf, err_msr);
> +rc = -errno;
> +goto fail;
> +}
> +
> +/* Success! */
> +
> + fail:
Even if this label is only used on "fail", the code path is also use on
success. So a label named "out" might be more appropriate.
> +free(cur);
> +free(def);
> +free(host);
> +
> +return rc;
> +}
> +
In any case, patch looks fine to me:
Acked-by: Anthony PERARD
Thanks,
--
Anthony PERARD
-- a/tools/xl/xl_cmdtable.c
> +++ b/tools/xl/xl_cmdtable.c
> @@ -141,7 +141,8 @@ const struct cmd_spec cmd_table[] = {
>"Attach to domain's console",
>"[options] \n"
>"-tconsole type, pv , serial or vuart\n"
> - "-n console number"
> + "-n console number\n"
> + "-e escape character"
Could you also update "docs/man/xl.1.pod.in" with this new option?
Thanks,
--
Anthony PERARD
ctive = 1;
> break;
> + case 'e':
> + if (optarg[0] == '^')
> + escape_character = optarg[1] & 0x1f;
> + else
> + escape_character = optarg[0];
> + break;
Could you check that `optarg` actually contains a valid escape
character sequence? Either only 1 character, or '^' followed by only one
char.
(If one want to use the NUL char to escape, it should set ^@, not '' or
'^'.)
Thanks,
--
Anthony PERARD
From: Anthony PERARD
Commit 189829399070 ("xen-block: Use specific blockdev driver")
introduced a new error path, without taking care of allocated
resources.
So only allocate the qdicts after the error check, and free both
`filename` and `driver` when we are about to return and thus t
ies handling for Arm")
> Signed-off-by: Luca Fancellu
> Reported-by: Andrew Cooper
Acked-by: Anthony PERARD
Thanks,
--
Anthony PERARD
so with QEMU 7.2, as testing with upstream QEMU is blocked
> ATM, so there's a chance it has already been fixed upstream.
>
> Thanks, Roger.
So, I've run a test with the latest QEMU and I can still reproduce the
issue. The test also fails with QEMU 7.1.0.
But, QEMU 7.0 seems to pass the test, even with a start-stop loop of 200
iteration. So I'll try to find out if something change in that range.
Or try to find out why would the thread pool be not initialised
properly.
Cheers,
--
Anthony PERARD
ist of trivial patch maintainers)
some maintainers prefer ping by mail, other are ok with ping by irc.
TODO: add "ping committers on irc" on beginner's page.
there's a committers@
TODO: discussion at community call.
--
Anthony PERARD
a construct to evaluate on first use.
Reported-by: Jason Andryuk
Signed-off-by: Anthony PERARD
Tested-by: Jason Andryuk
---
Config.mk | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Config.mk b/Config.mk
index c529b1ba19..5fbdbc4500 100644
--- a/Config.mk
+++ b
function
So, to avoid having these command been run more than necessery, we
will use a construct to evaluate on first use.
Reported-by: Jason Andryuk
Signed-off-by: Anthony PERARD
Tested-by: Jason Andryuk
---
xen/Makefile | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git
The same command is used to generate the value of both $(TARGET_ARCH)
and $(SRCARCH), as $(ARCH) is an alias for $(XEN_TARGET_ARCH).
Signed-off-by: Anthony PERARD
---
Notes:
v2:
- new patch
xen/Makefile | 18 +++---
xen/Rules.mk | 2 +-
xen/arch/riscv
Signed-off-by: Anthony PERARD
---
Notes:
v2:
- new patch
xen/Makefile | 3 +--
xen/build.mk | 2 +-
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/xen/Makefile b/xen/Makefile
index 78d176f04e..bc639a1f80 100644
--- a/xen/Makefile
+++ b/xen/Makefile
@@ -234,7 +234,7
of these:
Makefile:39: not recursively expanding SRCARCH to export to shell function
Makefile:38: not recursively expanding ARCH to export to shell function
Reported-by: Jason Andryuk
Signed-off-by: Anthony PERARD
Tested-by: Jason Andryuk
---
Notes:
v2:
- change quoting style
- change
hese side-effects will be seen every time a command is
> invoked.
The issue was reported on IRC by jandryuk.
So, I've locate a few obvious candidate to fix, maybe there's more $(shell) to
change?
Anthony PERARD (5):
build: define ARCH and SRCARCH later
build: remove TARGET_SUBARCH, a
On Thu, Jun 22, 2023 at 10:15:42AM +0200, Jan Beulich wrote:
> On 21.06.2023 18:25, Andrew Cooper wrote:
> > On 21/06/2023 5:19 pm, Anthony PERARD wrote:
> >> +
> >> +ARCH := $(XEN_TARGET_ARCH)
> >> +SRCARCH := $(shell echo $(ARCH) | \
> >> +
function
So, to avoid having these command been run more than necessery, we
will use a construct to evaluate on first use.
Reported-by: Jason Andryuk
Signed-off-by: Anthony PERARD
---
xen/Makefile | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/xen/Makefile b/xen
a construct to evaluate on first use.
Reported-by: Jason Andryuk
Signed-off-by: Anthony PERARD
---
Config.mk | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Config.mk b/Config.mk
index c529b1ba19cd..5fbdbc4500d2 100644
--- a/Config.mk
+++ b/Config.mk
@@ -19,13 +19,13
ted on IRC by jandryuk.
So, I've locate a few obvious candidate to fix, maybe there's more $(shell) to
change?
Anthony PERARD (3):
build: define ARCH and SRCARCH later
build: evaluate XEN_BUILD_* and XEN_DOMAIN on first use
Config.mk: evaluate XEN_COMPILE_ARCH and XEN_OS on first use
Confi
of these:
Makefile:39: not recursively expanding SRCARCH to export to shell function
Makefile:38: not recursively expanding ARCH to export to shell function
Reported-by: Jason Andryuk
Signed-off-by: Anthony PERARD
---
xen/Makefile | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff
o use the live mirror, we need to update the debian-installer as
there's a newer version of the kernel. Otherwise, installation fails
with the installer not able to find the disk.
Signed-off-by: Anthony PERARD
---
Notes:
I've tested this with just the *armhf* jobs, which works. So I'm going
stallation fails with "Invalid
Release signature" when the debian install script check the signature of
the "Release" file from the repo.
I'm looking at it.
Cheers,
--
Anthony PERARD
Since QEMU commit 74a1b256d775 ("configure: Bump minimum Clang version
to 10.0"), or QEMU v8.0, Clang 10.0 is now the minimum to build QEMU.
QEMU 8.0 fails to build on Ubuntu Bionic.
Signed-off-by: Anthony PERARD
---
Notes:
I've tested that change here, with QEMU v8.0.2:
Update to OVMF's latest stable tag.
This is been prompt by trying to build Xen on Debian Bookworm,
where edk2-stable202108 doesn't build. Also, it's been too long since
the last update.
Signed-off-by: Anthony PERARD
---
I've tested it in osstest, so the update should be fine:
http://logs.test
it the for loop and introduce a `goto out` instead of `goto out_unmap`
there's just a potential leak rather than potential use-after-free or
double-free, so I guess that better.
So:
Acked-by: Anthony PERARD
Cheers,
--
Anthony PERARD
On Tue, Jun 13, 2023 at 06:08:16PM +0200, Jan Beulich wrote:
> On 13.06.2023 18:03, Anthony PERARD wrote:
> > On Mon, Jun 12, 2023 at 01:46:40PM +0200, Jan Beulich wrote:
> >> The function returns immediately after the enclosing if().
> >>
> >> Coverity ID: 1532
e")
> Signed-off-by: Jan Beulich
Acked-by: Anthony PERARD
Thanks,
--
Anthony PERARD
u_policy()")
> Signed-off-by: Jan Beulich
Acked-by: Anthony PERARD
Thanks,
--
Anthony PERARD
((mask >> shift) << shift);
> }
Do we have to remove this assignment? What if someone adds code later
and reuse the content of the variable `ptes`? Or what if someone adds
codes after the loop, and handle an error with `goto out`, we would have
a double-munmap().
--
Anthony PERARD
Beulich
Acked-by: Anthony PERARD
Thanks,
--
Anthony PERARD
bvious.
> >
> > Coverity ID: 1532310
> > Fixes: ae763e422430 ("tools/misc: introduce xen-mfndump")
> > Signed-off-by: Jan Beulich
>
> Reviewed-by: Jason Andryuk
Acked-by: Anthony PERARD
Thanks,
--
Anthony PERARD
On Tue, Jun 13, 2023 at 01:01:47PM +0200, Roger Pau Monné wrote:
> On Tue, Jun 13, 2023 at 11:44:51AM +0100, Anthony PERARD wrote:
> > On Mon, Jun 05, 2023 at 12:36:57PM +0200, Roger Pau Monne wrote:
> > > diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in
> &
he usage of $RPM_BUILD_ROOT with
> %buildroot, and use pushd/popd pairs.
>
> Signed-off-by: Olaf Hering
> ---
>
> v2: remove bogus pushd/popd pair, use pipe as delimiter for s command for
> consistency
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
> - Print "0" or "1" in xenstore instead of "True" or "False" for grant_usage.
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
r. */
> +char *name = strndup(str, sep - str);
> +
> +if (name == NULL)
> +return 4;
out-of-memory are usually fatal in libxl. Any reason to use `strndup`
instead of `libxl__strndup`? I guess we don't have any libxl_ctx, so we
can't use the libxl function.
So, instead of returning an arbitrary integer that isn't returned yet by
the function, could you return ERROR_NOMEM?
I wonder if it would be possible to use a buffer on the stack instead,
but it might not be worth the effort to find the right size.
Thanks,
--
Anthony PERARD
tring like "True" or
"False" in xenstore when a simple integer would work. Also I'm pretty
sure all other bool are written as "0" or "1", for false or true.
Could you change to write "0" or "1" instead of using
libxl_defbool_to_string() ?
Beside this, patch looks good to me.
Cheers,
--
Anthony PERARD
ype.set_default() from
> libxl__domain_config_setdefault(), in a similar way as other devices
> like disk, etc.
>
> Suggested-by: Anthony PERARD
> Signed-off-by: Viresh Kumar
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
the xenstore nodes. They can be removed.
>
> While at it, also add a comment to the libxl_virtio.c file.
>
> Signed-off-by: Viresh Kumar
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
md = XEN_SYSCTL_dt_overlay,
.u.dt_overlay = {
.overlay_op = overlay_op,
.overlay_fdt_size = overlay_fdt_size,
}
};
With that, I don't think there would be need to set a value for "pad",
it would default to 0. And it maybe looks cleaner?
With that: Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
m -rf %buildroot
> +mkdir -p %buildroot
> +pushd %_xenroot
> +dist/install.sh %buildroot
> +
> +pushd %buildroot
> +popd
Are these 2 lines left over from testing? They don't appear to do
anything useful.
Beside that, patch looks fine:
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
uggest for you to pick up the patches. But as it
> > >>happens I'll have to likely send another pull request in a week or two
> > >>and I can add these patches to it.
> > >>
> > >>Let me know your preference and I am happy to follow it.
> > >
> > >Hi Stefano,
> > >
> > >Michael's PR was merged last week. How about including this series into
> > >your PR then?
> >
> > Ping
>
> Sorry for the late reply, it looks like patch #3 breaks the build:
Hi Stefano,
Sorry I forgot to reply to these mails. I've sent a pull request for
this earlier this week (along with other patches I had to send), so the
series should be applied now.
I guess the build issue is due to trying to apply the same patch again.
Cheers,
--
Anthony PERARD
From: Anthony PERARD
Backtrace:
qemu_lockcnt_lock (lockcnt=0xb4) at ../util/lockcnt.c:238
aio_set_fd_handler (ctx=0x0, fd=51, is_external=true, io_read=0x0,
io_write=0x0, io_poll=0x0, io_poll_ready=0x0, opaque=0x0) at
../util/aio-posix.c:119
xen_device_unbind_event_channel (xendev
Jan Beulich
> > Signed-off-by: Juergen Gross
>
> Anthony, Wei,
>
> since this is taking away things from an area you're the maintainers for,
> I think it would best be acked by you.
Acked-by: Anthony PERARD
Thanks,
--
Anthony PERARD
On Thu, May 25, 2023 at 02:04:00PM +0200, Jan Beulich wrote:
> On 23.05.2023 18:38, Anthony PERARD wrote:
> > Make use of filechk mean that we don't have to use
>
> I think you mean "Making use of filechk means ...", or else it reads as
> if you're changing how
On Thu, May 25, 2023 at 01:56:53PM +0200, Jan Beulich wrote:
> On 23.05.2023 18:38, Anthony PERARD wrote:
> > Whether or not the linker can do build id is only used by the
> > hypervisor build, so move that there.
> >
> > Rename $(build_id_linker
On Wed, May 24, 2023 at 09:17:09AM +0200, Jan Beulich wrote:
> On 23.05.2023 18:38, Anthony PERARD wrote:
> > Make the gzip command generic and use -9 which wasn't use for
> > config.gz. (xen.gz does use -9)
>
> You mention xen.gz here, but you don't make its rule use
On Wed, May 24, 2023 at 09:11:10AM +0200, Jan Beulich wrote:
> On 23.05.2023 18:38, Anthony PERARD wrote:
> > --- a/xen/xsm/flask/Makefile
> > +++ b/xen/xsm/flask/Makefile
> > @@ -48,10 +48,15 @@ targets += flask-policy.S
> > FLASK_BUILD_DIR := $(abs_objt
On Wed, May 24, 2023 at 04:16:54PM +0200, Jan Beulich wrote:
> On 23.05.2023 18:37, Anthony PERARD wrote:
> > We are adding %.lnk to .PRECIOUS or make treat them as intermediate
> > targets and remove them.
>
> What's wrong with them getting removed? Note also that's no diffe
On Wed, May 24, 2023 at 04:09:39PM +0200, Jan Beulich wrote:
> On 23.05.2023 18:37, Anthony PERARD wrote:
> > Use $(if_changed_dep, ) macro to generate "asm-offsets.s" and remove
> > the use of $(move-if-changes,). That mean that "asm-offset.s" will be
>
On Tue, May 23, 2023 at 08:43:24AM +0100, Luca Fancellu wrote:
> Add sve parameter in XL configuration to allow guests to use
> SVE feature.
>
> Signed-off-by: Luca Fancellu
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
We don't want the AFLAGS from the environment, they are usually meant
to build user space application and not for the hypervisor.
Config.mk doesn't provied any $(AFLAGS) so we can start a fresh
$(XEN_AFLAGS).
Signed-off-by: Anthony PERARD
---
xen/Makefile | 10 ++
xen/arch/x86
-by: Anthony PERARD
---
Notes:
There's still $(EXTRA_CFLAGS_XEN_CORE) which allows to add more CFLAGS
if someone building Xen needs to add more CFLAGS to the hypervisor
build.
xen/Makefile | 11 ++-
xen/arch/arm/arch.mk | 4
xen/arch/x86/arch.mk | 2 ++
3 files
st in case. it's only used in xen/Makefile,
which includes Config.mk and so has already the fallback.)
Signed-off-by: Anthony PERARD
---
Notes:
Removing Config.mk benefit:
Rebuild on my computer is aboud 1 second faster overall.
Save maybe 3 seconds of user time
s
On Mon, May 22, 2023 at 08:34:52PM +0100, Julien Grall wrote:
> On 19/05/2023 17:24, Anthony PERARD wrote:
> > diff --git a/tools/configure.ac b/tools/configure.ac
> > index 3cccf41960..0f0983f6b7 100644
> > --- a/tools/configure.ac
> > +++ b/tools/configure.ac
> >
use it without
including Config.mk and thus without having to recalculate some CFLAGS
which would be ignored.
Signed-off-by: Anthony PERARD
---
Config.mk | 27 +--
config/compiler-testing.mk | 25 +
xen/Rules.mk | 1
This is a preparatory patch. A future patch will not even use
$(CFLAGS) to seed $(XEN_CFLAGS).
Signed-off-by: Anthony PERARD
---
xen/Makefile | 41 ++---
xen/arch/arm/arch.mk | 4 +--
xen/arch/riscv/arch.mk | 4 +--
xen/arch/x86/arch.mk | 58
Make the gzip command generic and use -9 which wasn't use for
config.gz. (xen.gz does use -9)
Signed-off-by: Anthony PERARD
---
xen/Rules.mk| 5 +
xen/common/Makefile | 8
2 files changed, 9 insertions(+), 4 deletions(-)
diff --git a/xen/Rules.mk b/xen/Rules.mk
index
CFLAGS is just from Config.mk, instead use the flags used to build
Xen.
Signed-off-by: Anthony PERARD
---
Notes:
I don't know if CFLAGS is even useful there, just --version without the
flags might produce the same result.
xen/build.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion
uppress Kconfig prompts for silent build")
Signed-off-by: Anthony PERARD
---
xen/Makefile | 1 +
xen/tools/kconfig/Makefile | 14 +++---
2 files changed, 8 insertions(+), 7 deletions(-)
diff --git a/xen/Makefile b/xen/Makefile
index 4dc960df2c..127c0e40b5 100644
---
mestamp.
While there, replace `grep -v` by `sed '//d'` to avoid an extra
fork and pipe when building.
Signed-off-by: Anthony PERARD
---
xen/include/Makefile | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/xen/include/Makefile b/xen/include/Makefile
index 96d5f6f3c
Signed-off-by: Anthony PERARD
---
xen/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/Makefile b/xen/Makefile
index e89fc461fc..27f70d2200 100644
--- a/xen/Makefile
+++ b/xen/Makefile
@@ -339,7 +339,7 @@ filechk_kconfig_allconfig = \
:
.allconfig.tmp
We are adding %.lnk to .PRECIOUS or make treat them as intermediate
targets and remove them.
Signed-off-by: Anthony PERARD
---
xen/arch/x86/boot/Makefile | 16
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/xen/arch/x86/boot/Makefile b/xen/arch/x86/boot/Makefile
h/x86/boot/ CFLAGS_x86_32
Beside a reordering of the command line where CFLAGS is used, there
shouldn't be any other changes.
Signed-off-by: Anthony PERARD
---
Config.mk | 12
xen/Makefile| 12
xen/arch/arm/Makefile | 2 +-
xen/
Instead, show only when "policy.bin" is been updated.
We still have the full command from the flask/policy Makefile, but we
can't change that Makefile.
Signed-off-by: Anthony PERARD
---
xen/xsm/flask/Makefile | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git
Change of directory to xen/lib/x86 isn't needed to be shown. If
something gets updated, make will print the command line.
Signed-off-by: Anthony PERARD
---
xen/include/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/include/Makefile b/xen/include/Makefile
index
removes the inclusion of Config.mk from xen/Rules.mk, as this slow
down the build unnecessarily. xen/Makefile should do everything necessary to
setup the build of the hypervisor, and is its only entry point.
Thanks,
Anthony PERARD (15):
build: hide that we are updating xen/lib/x86
build: rework
ad of regenerating "asm-offsets.h" every time "asm-offsets.s"
change, we will use "$(filechk, )" to only update the ".h" when the
output change. Also, with "$(filechk, )", the file does get
regenerated when the rule change in the makefile.
Thi
Since QEMU commit 81e2b198a8cb ("configure: create a python venv
unconditionally"), a python venv is always created and this new package
is needed on Debian.
Signed-off-by: Anthony PERARD
---
ts-xen-build-prep | 1 +
1 file changed, 1 insertion(+)
diff --git a/ts-xen-build-prep b/ts
On Mon, May 08, 2023 at 08:23:43AM +0200, Jan Beulich wrote:
> On 05.05.2023 18:08, Anthony PERARD wrote:
> > On Wed, Mar 15, 2023 at 03:58:59PM +0100, Jan Beulich wrote:
> >> With in-tree builds Config.mk includes a .config file (if present) from
> >> the t
, with the unsupported steps skipped.
Also in sysconfig.xendomains, change "Default" to "Example" as the
real default is an empty value.
Reported-by: Peter Hoyes
Signed-off-by: Anthony PERARD
---
Peter, what do you think of this approach?
For reference, there's also a way t
On Thu, Apr 06, 2023 at 03:57:12PM +0100, Peter Hoyes wrote:
> On 04/04/2023 17:28, Anthony PERARD wrote:
> > On Wed, Mar 22, 2023 at 01:58:00PM +, Peter Hoyes wrote:
> > > From: Peter Hoyes
> > >
> > > Saving, restoring and migrating domains are
On Mon, May 01, 2023 at 03:30:31PM -0400, Jason Andryuk wrote:
> Add xc_set_cpufreq_hwp to allow calling xen_systctl_pm_op
> SET_CPUFREQ_HWP.
>
> Signed-off-by: Jason Andryuk
Acked-by: Anthony PERARD
Thanks,
--
Anthony PERARD
On Mon, May 01, 2023 at 03:30:28PM -0400, Jason Andryuk wrote:
> Expose the hwp_para fields through libxc.
>
> Signed-off-by: Jason Andryuk
Acked-by: Anthony PERARD
Thanks,
--
Anthony PERARD
On Tue, May 02, 2023 at 04:36:50PM -0700, Vikram Garhwal wrote:
> Signed-off-by: Vikram Garhwal
Reviewed-by: Anthony PERARD
--
Anthony PERARD
On Tue, May 02, 2023 at 04:36:49PM -0700, Vikram Garhwal wrote:
> Signed-off-by: Vikram Garhwal
Reviewed-by: Anthony PERARD
--
Anthony PERARD
On Tue, May 02, 2023 at 04:36:48PM -0700, Vikram Garhwal wrote:
> xc_dt_overlay() sends the device tree binary overlay, size of .dtbo and
> overlay
> operation type i.e. add or remove to xen.
>
> Signed-off-by: Vikram Garhwal
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
because the doc change is at the end of the patch
series and this patch at the beginning.
I feel like this patch would be better at the end of the series, just
before the doc change, when the hypervisor is ready for it.
In any case:
Acked-by: Anthony PERARD
Thanks,
--
Anthony PERARD
On Mon, May 15, 2023 at 05:36:00PM +0530, Viresh Kumar wrote:
> On 12-05-23, 11:43, Anthony PERARD wrote:
> > On Thu, May 11, 2023 at 01:20:43PM +0530, Viresh Kumar wrote:
> > > diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in
> > > index 24ac92
LUDE_LIBUTIL_H in libxl_bootloader.c, it is already
> covered by inclusion of libxl_osdep.h.
>
> Remove usage of PTYFUNCS_LIBS in libxl/Makefile, it is already covered
> by UTIL_LIBS from config/StdGNU.mk.
>
> Signed-off-by: Olaf Hering
Reviewed-by: Anthony PERARD
Obvious
UN_DIR instead of hardcoded paths.
>
> XEN_RUN_STORED is covered by XEN_RUN_DIR because xenstored is usually
> started afterwards.
>
> Reported-by: Jason Andryuk
> Tested-by: Jason Andryuk
> Signed-off-by: Olaf Hering
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
event_channel() at the moment
so I don't know if other implementation making use of this API will want
to call set_event_channel_context or not.)
> +xen_block_dataplane_attach(dataplane);
> +}
>
> return;
>
--
Anthony PERARD
xternal() API.
>
> Signed-off-by: Stefan Hajnoczi
Acked-by: Anthony PERARD
Thanks,
--
Anthony PERARD
safe.
>
> It's safer to register BlockDevOps after the dataplane instance has been
> created. The BlockDevOps .drained_begin/end() callbacks depend on the
> dataplane instance, so move the blk_set_dev_ops() call after
> xen_block_dataplane_create().
>
> Signed-off-by: Stefan Hajnoczi
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
301 - 400 of 2963 matches
Mail list logo
