Hi George
Could you give a ack or review this patch?
Thanks,
On Thu, Aug 11, 2022 at 05:48:21PM +0100, Anthony PERARD wrote:
> Remove "build" targets.
>
> Use "$(TARGETS)" to list binary to be built.
>
> Cleanup "clean" rule.
>
> Also drop c
Hi Elena,
Could you give a ack or review this patch?
Thanks,
On Thu, Aug 11, 2022 at 05:48:14PM +0100, Anthony PERARD wrote:
> gdbsx/:
> - Make use of subdir facility for the "clean" target.
> - No need to remove the *.a, they aren't in this dir.
> - Avoid calling
;, do you think this libvirt patch could
be committed?
Thanks,
--
Anthony PERARD
re.
>
> Coverity ID: 1509374
> Signed-off-by: Jan Beulich
> ---
> v2: Properly use %.0f everywhere.
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
On Thu, Aug 18, 2022 at 04:06:20PM +0200, Jan Beulich wrote:
> "int" is not a suitable type to hold time()'s return value.
>
> Coverity ID: 1509376
> Signed-off-by: Jan Beulich
Acked-by: Anthony PERARD
Thanks,
--
Anthony PERARD
me ? rec_count / run_time : 0);
>
> -printf("woke up %d times in %d seconds (%ld per second)\n",
> - wakeups, (int) run_time,
> - run_time ? (long)(wakeups/run_time) : 0L);
> +printf("woke up %d times in %0f seconds (%0f per second)\n",
> + wakeups, run_time, run_time ? wakeups / run_time : 0);
>
> check_gotten_sum();
> }
>
--
Anthony PERARD
On Thu, Aug 18, 2022 at 04:07:16PM +0200, Jan Beulich wrote:
> "int" is not a suitable type to hold / receive "time_t" values.
>
> The parameter is presently unused, so no functional change.
>
> Coverity ID: 1509377
> Signed-off-by: Jan Beulich
Acked-b
directory" with the same directory.
The comment and location in the Makefile are copied from Linux.
Reported-by: Andrew Cooper
Signed-off-by: Anthony PERARD
---
xen/Makefile | 5 +
1 file changed, 5 insertions(+)
diff --git a/xen/Makefile b/xen/Makefile
index 69b4dc960f..106aff6a07 10064
On Wed, Aug 17, 2022 at 12:38:36PM +0200, Jan Beulich wrote:
> On 17.08.2022 11:15, Anthony PERARD wrote:
> > --- a/xen/common/efi/efi-common.mk
> > +++ b/xen/common/efi/efi-common.mk
> > @@ -9,9 +9,9 @@ CFLAGS-y += -iquote $(srcdir)
> > # e.g.: It transforms &quo
euse x86 EFI stub functions for Arm")
Reported-by: Andrew Cooper
Signed-off-by: Anthony PERARD
---
Notes:
v2:
- instead of renaming common/efi/stub.c to common_stub.c; we rename
arch/*/efi/stub.c to stub.h and include it from common/stub.c
- update .gitignore
CC: J
On Tue, Aug 16, 2022 at 03:02:10PM +0200, Jan Beulich wrote:
> On 16.08.2022 12:30, Anthony PERARD wrote:
> > We can't have a source file with the same name that exist in both the
> > common code and in the arch specific code for efi/. This can lead to
> > comfusion in ma
I am thinking to drop my patch [1] which update .gitignore as this
> will become moot with this change. Let me know what you think.
Sound good,
Thanks,
--
Anthony PERARD
other files are also listed in other sections so would have a
maintainer. There's probably a few Makefiles in subdirectory that
would have CC THE REST but won't with this new section.
Signed-off-by: Anthony PERARD
---
I'm not sure if adding a maintainers would be needed, but maybe Jan?
I could look
This patch probably need a slight better subject, as the issue is only
with out-of-tree build. So new subject:
build: Fix x86 out-of-tree build without EFI
--
Anthony PERARD
oid using $(EFIOBJ-y) as an alias for $(clean-files), add
common_stub.c directly to $(clean-files).
Fixes: 7f96859b0d00 ("xen: reuse x86 EFI stub functions for Arm")
Reported-by: Andrew Cooper
Signed-off-by: Anthony PERARD
---
For the cflag addition in non-ARM_EFI, I was tempted to a
On Fri, Aug 12, 2022 at 03:36:12PM +0200, Jan Beulich wrote:
> On 11.08.2022 18:48, Anthony PERARD wrote:
> > Setup proper dependencies with libacpi so we don't need to run "make
> > hvmloader" in the "all" target. ("build.o" new prerequisite isn't
>
And provide an option to ./configure to disable it.
A follow-up patch will remove -Werror from every other Makefile in
tools/. ("tools: Remove -Werror everywhere else")
Signed-off-by: Anthony PERARD
Reviewed-by: Luca Fancellu
---
tools/configure.ac | 1 +
tools/Rules.mk | 4 ++
. for checking for dependencies).
Signed-off-by: Anthony PERARD
Reviewed-by: Juergen Gross
---
tools/Rules.mk | 16 ++--
tools/libs/libs.mk | 2 +-
2 files changed, 15 insertions(+), 3 deletions(-)
diff --git a/tools/Rules.mk b/tools/Rules.mk
index 23979ed254..ce77dd2eb1 100644
Signed-off-by: Anthony PERARD
---
Notes:
v4:
- new patch
tools/configure.ac | 1 +
tools/hotplug/common/Makefile | 10 ++
tools/configure| 3 ++-
tools/hotplug/common/hotplugpath.sh.in | 16
4 files changed
Signed-off-by: Anthony PERARD
Reviewed-by: Luca Fancellu
---
tools/console/client/Makefile | 3 +--
tools/console/daemon/Makefile | 6 +-
2 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/tools/console/client/Makefile b/tools/console/client/Makefile
index 44176c6d93..e2f2554f92
gentypes.py".
Signed-off-by: Anthony PERARD
---
Notes:
v4:
- new patch
tools/libs/light/Makefile | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/tools/libs/light/Makefile b/tools/libs/light/Makefile
index 4a8b0f7bcf..9329055c98 100644
--- a/tools/libs/light/M
Use $(TARGETS) to collect targets. Use := for the first target instead
of +=.
Collect library to link against in $(LDLIBS).
Remove extra "-f" flags that is already part of $(RM).
Signed-off-by: Anthony PERARD
Reviewed-by: Luca Fancellu
Tested-by: Luca Fancellu
---
Notes:
v4:
the "all" target.
Signed-off-by: Anthony PERARD
---
Alternatively, we could remove the need for to generate a
version-script, but that would mean the exported symbols won't have a
version anymore (like before, a few versions of Xen ago). Or, we could
use --default-symver, but the symb
been run from tools/ rather than tools/firmware/.
Signed-off-by: Anthony PERARD
---
Notes:
v4:
- new patch
scripts/git-checkout.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/git-checkout.sh b/scripts/git-checkout.sh
index 20ae31ff23..fd4425ac4e 1007
This avoid the need to open-coding the list of flags needed to link
with an in-tree Xen library when using -lxen*.
Signed-off-by: Anthony PERARD
Reviewed-by: Henry Wang
---
tools/golang/xenlight/Makefile | 2 +-
tools/Rules.mk | 8
2 files changed, 9 insertions(+), 1
yet but it will when for example
the script will be run from tools/ to generate the targets.
Signed-off-by: Anthony PERARD
---
Notes:
v4:
- new patch
tools/golang/xenlight/Makefile | 6 --
tools/golang/xenlight/gengotypes.py | 10 +-
2 files changed, 13 insertions(+),
ird "$(eval stem =" in the middle of a recipe and use
a make automatic variable "$(*F)" instead.
Signed-off-by: Anthony PERARD
---
Notes:
v4:
- new patch
tools/libs/light/Makefile | 16 +++-
tools/libs/light/libxl_x86_acpi.c | 2 +-
2 files changed,
Remove "build" targets.
Use "$(TARGETS)" to list binary to be built.
Cleanup "clean" rule.
Also drop conditional install of $(BIN) and $(LIBBIN) as those two
variables are now always populated.
Signed-off-by: Anthony PERARD
---
Notes:
v4:
- also use :=
nformation available in
"libacpi/Makefile" at this time.
Also avoid duplicating the "acpi" target for Arm, and unique one for
both architecture. And move the "acpi" target to be with other targets
rather than in the middle of the source listing. For the same reason,
m
Patch "tools: Add -Werror by default to all tools/" have added
"-Werror" to CFLAGS in tools/Rules.mk, remove it from every other
makefiles as it is now duplicated.
Signed-off-by: Anthony PERARD
Acked-by: Christian Lindig
---
tools/console/client/Makefile | 1 -
tools/con
uot;dist" target which was the only one existing in tools/.
Signed-off-by: Anthony PERARD
---
Notes:
v4:
- new patch
tools/include/Makefile | 28 +++-
1 file changed, 15 insertions(+), 13 deletions(-)
diff --git a/tools/include/Makefile b/tools/include/Make
, libxenlight_test.so might failed to build if the version script
doesn't exist yet.
For these reasons, avoid changing the generic $(SHLIB_LDFLAGS) flags,
and add the flag directly on the command line.
Signed-off-by: Anthony PERARD
---
Notes:
v4:
- new patch
tools/libs/libs.mk | 4 +---
1 file changed
This doesn't matter yet but it will when for example the script will
be run from tools/ to generate files tools/libs/light/.
Signed-off-by: Anthony PERARD
---
Notes:
v4:
- new patch
tools/libs/light/gentypes.py | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git
Remove -I. from CFLAGS, it isn't necessary.
Removed $(AUTOSRCS), it isn't used.
Signed-off-by: Anthony PERARD
Reviewed-by: Juergen Gross
Reviewed-by: Bertrand Marquis
---
tools/libs/util/Makefile | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/tools/libs/util/Makefile b
rs will still be generated as needed.
"testidl.c" doesn't depends on "libxl.h" but "testidl.o" does. Also
use automatic variables $< and $@.
Signed-off-by: Anthony PERARD
---
Notes:
v4:
- new patch
tools/libs/light/Makefile | 29 +
$(SHDEPS_libxen*).
In libs.mk, we don't need to $(sort ) SHLIB_lib* anymore as this was used
to remove duplicates and they are no more duplicates.
Signed-off-by: Anthony PERARD
Reviewed-by: Juergen Gross
---
tools/Rules.mk | 29 -
tools/libs/libs.mk | 2 +-
2 files
There is no need to call the "headers.chk" target when it isn't
wanted, so it never need to be .PHONY.
Also, there is no more reason to separate the prerequisites from the
recipe.
Signed-off-by: Anthony PERARD
Reviewed-by: Juergen Gross
Reviewed-by: Bertrand Marquis
---
tools/li
We can simply use $(PKG_CONFIG) to set the parameters, and add it to
$(TARGETS) as necessary.
Signed-off-by: Anthony PERARD
Reviewed-by: Juergen Gross
Reviewed-by: Bertrand Marquis
---
tools/libs/libs.mk | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/tools
t;.)
Make use if "-iquote" instead of a plain "-I".
For "roms.inc" target, use "$(SHELL)" instead of plain "sh". And use
full path to "mkhex" instead of a relative one. Lastly, add "-f" flag
to "mv" to avoid a prom
- Rename $(SRCS) to $(OBJS-y), we don't need to collect sources.
- Rename $(IBINS) to $(TARGETS)
- Stop cleaning "xen" and non-set variable $(LIB).
Signed-off-by: Anthony PERARD
Reviewed-by: Luca Fancellu
---
tools/xenpaging/Makefile | 24
1 file changed, 12
Signed-off-by: Anthony PERARD
Reviewed-by: Juergen Gross
Reviewed-by: Bertrand Marquis
---
Notes:
v2:
- move new .gitignore entries to the one in tools/libs/
.gitignore| 26 --
tools/libs/.gitignore | 2 ++
2 files changed, 2 insertions(+), 26
Signed-off-by: Anthony PERARD
Reviewed-by: Henry Wang
---
tools/flask/utils/Makefile | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/tools/flask/utils/Makefile b/tools/flask/utils/Makefile
index db567b13dc..6be134142a 100644
--- a/tools/flask/utils/Makefile
+++ b
Some reindentation.
FreeBSD, "hotplugpath.sh" is already installed by common/.
Signed-off-by: Anthony PERARD
Reviewed-by: Luca Fancellu
---
tools/hotplug/FreeBSD/Makefile | 11 +++
tools/hotplug/Linux/Makefile | 16 ++--
tools/hotplug/Linux/systemd/Makef
a symlink exist, always regenerate the
symlink. So if the source tree changed location, the symlink is
updated.
Since we are creating a new .gitignore for the symlink, also move the
entry to it.
Signed-off-by: Anthony PERARD
Reviewed-by: Luca Fancellu
---
Notes:
v4:
- Use pattern rules to link sou
the .*.d dependency files,
and iso9660.h already exist.
Signed-off-by: Anthony PERARD
Reviewed-by: Luca Fancellu
---
tools/libfsimage/common/Makefile | 11 +++
tools/libfsimage/ext2fs-lib/Makefile | 9 -
tools/libfsimage/ext2fs/Makefile | 9 -
tools/lib
Signed-off-by: Anthony PERARD
Reviewed-by: Juergen Gross
Reviewed-by: Bertrand Marquis
---
tools/libs/libs.mk | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/tools/libs/libs.mk b/tools/libs/libs.mk
index 58d8166b09..e02f91f95e 100644
--- a/tools/libs/libs.mk
+++ b
-system-v1-wip-extra
With that branch, you could tried something like:
./configure; cd tools/xl; make
and `xl` should be built as well as all the xen library needed.
Also, things like `make clean` or rebuild should be faster in the all tools/
directory.
Cheers,
Anthony PERARD (32):
tool
bsx", make will recurse even when both *.a already exist.
- List target in $(TARGETS).
gdbsx/*/:
- Fix dependency on *.h.
- Remove some dead code.
- List targets in $(TARGETS).
- Remove "build" target.
- Cleanup "clean" targets.
- remove comments about th
program name.
In the "clean" rule, use $(RM) and remove all "*.o" instead of just
one object.
Signed-off-by: Anthony PERARD
Reviewed-by: Luca Fancellu
---
Notes:
v2:
- use $(RM) in clean.
- remove all *.o instead of just one object in "clean" rule.
On Tue, Aug 09, 2022 at 08:17:49AM -0400, Jason Andryuk wrote:
> On Mon, Aug 8, 2022 at 7:06 AM Anthony PERARD
> wrote:
> > diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in
> > index 6d98d73d76..b2901e04cf 100644
> > --- a/docs/man/xl.cfg.5.pod.in
>
On Fri, Jul 22, 2022 at 01:30:53PM +, Luca Fancellu wrote:
> > On 24 Jun 2022, at 17:04, Anthony PERARD wrote:
> > .PHONY: uninstall
> > uninstall:
> > rm -f $(addprefix $(DESTDIR)$(LIBEXEC_BIN)/, $(LIBBIN))
> > rm -f $(addprefix $(DESTDIR)$(bindi
se QEMU crash when trying to add it to a Xen domain.
Also, it wouldn't work with "-device" might need to be "-machine
pcspk-audiodev=default" instead.
Signed-off-by: Anthony PERARD
---
docs/man/xl.cfg.5.pod.in | 6 +++---
tools/libs/light/libxl_types_internal.
, use "-display sdl", available since 1472a95bab1e ("Introduce
-display argument"), before QEMU v1.0.
Signed-off-by: Anthony PERARD
---
tools/libs/light/libxl_dm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/libs/light/libxl_dm.c b/tools/libs/light
them already existed in QEMU 1.0, so all the version QEMU upstream that we
could possible use as device model.
Thanks,
Anthony PERARD (2):
tools/libxl: Replace deprecated -sdl option on QEMU command line
tools/libxl: Replace deprecated -soundhw on QEMU command line
docs/man/xl.cfg.5.pod.in
(At least, I hope using -device instead -soundhw is going to
work the same way.)
--
Anthony PERARD
On Wed, Aug 03, 2022 at 03:37:19PM +, Edwin Torok wrote:
> > On 3 Aug 2022, at 14:46, Anthony PERARD wrote:
> > On Fri, Jul 29, 2022 at 06:53:27PM +0100, Edwin Török wrote:
> >> +.PHONY: build-tools-oxenstored-prepare
> >> +build-tools-oxenstored-prepa
ch 4.02.3) (profile release)))
> diff --git a/tools/ocaml/dune-workspace.in b/tools/ocaml/dune-workspace.in
> new file mode 100644
> index 000000..c963a6e599
> --- /dev/null
> +++ b/tools/ocaml/dune-workspace.in
> @@ -0,0 +1,18 @@
> +(lang dune 2.1)
> +
> +(env
> + ; we need to support older compilers so don't make deprecation warnings
> fatal
> + (dev
> + (flags (:standard -w -3))
> + (env-vars
> +(LD_LIBRARY_PATH @LIBRARY_PATH@)
> +(LIBRARY_PATH @LIBRARY_PATH@)
> + ))
> + (release
> + (env-vars
> + (OCAMLRUNPARAM b)
> +(LD_LIBRARY_PATH @LIBRARY_PATH@)
Shouldn't this line (and the next) been aligned with the previous one?
> +(LIBRARY_PATH @LIBRARY_PATH@)
> + )
> + (flags (:standard -strict-sequence -strict-formats -principal -w @18))
> + (ocamlopt_flags -nodynlink)))
Thanks,
--
Anthony PERARD
On Tue, Jun 14, 2022 at 05:22:48PM +0100, Anthony PERARD wrote:
> The get-fields.sh which generate all the include/compat/.xlat/*.h
> headers is quite slow. It takes for example nearly 3 seconds to
> generate platform.h on a recent machine, or 2.3 seconds for memory.h.
>
> Since
On Wed, Aug 03, 2022 at 01:58:34PM +0200, Jan Beulich wrote:
> On 03.08.2022 12:57, Anthony PERARD wrote:
> > On Wed, Aug 03, 2022 at 10:24:26AM +, Edwin Torok wrote:
> >>
> >> -ifneq ($(MAKECMDGOALS),clean)
> >> +ifeq (,$(findstring clean,$(MAKECMDGOALS)))
ne doesn't seems related to dune, why is it in this patch?
Also, can you sort the lines in this .gitignore?
Thanks,
--
Anthony PERARD
ep.make" and failing when not needed.
> endif
> --
> 2.34.1
--
Anthony PERARD
On Wed, Aug 03, 2022 at 07:56:34AM +0200, Jan Beulich wrote:
> On 02.08.2022 19:09, Anthony PERARD wrote:
> > On Mon, Jul 11, 2022 at 04:08:55PM +0200, Jan Beulich wrote:
> >> Can you confirm things to work when
> >> building locally in just this subdir, e.g. via
> &
On Mon, Jul 11, 2022 at 04:08:55PM +0200, Jan Beulich wrote:
> On 24.06.2022 18:04, Anthony PERARD wrote:
> > --- a/tools/fuzz/x86_instruction_emulator/Makefile
> > +++ b/tools/fuzz/x86_instruction_emulator/Makefile
> > @@ -8,33 +8,27 @@ else
> > x86-insn-fuzz-all:
On Tue, Aug 02, 2022 at 01:27:19PM +0100, Ian Jackson wrote:
> Anthony PERARD writes ("[OSSTEST PATCH 1/2] TestSupport: Add support for
> installing from backport repo"):
> > We are going to need to install package from the debian backport
> > repository in order
of libxl. But I don't think that should prevent us from adding
new enum values.
Cheers,
--
Anthony PERARD
We are going to need to install package from the debian backport
repository in order to do a build.
Signed-off-by: Anthony PERARD
---
Osstest/TestSupport.pm | 27 +--
1 file changed, 25 insertions(+), 2 deletions(-)
diff --git a/Osstest/TestSupport.pm b/Osstest
to find out if Meson is used or not, we'll check if the
"autogen.sh" script is missing. And in the build dir, we will look for
a "Makefile".
Signed-off-by: Anthony PERARD
---
ts-libvirt-build | 70 +--
ts-xen-build-prep | 8 +
libvirt now use meson+ninja instead of autoconf, so teach osstest to use that.
I ran a flight with that, here is the result:
"tolerable all pass"
http://logs.test-lab.xenproject.org/osstest/logs/172068/
Thanks,
Anthony PERARD (2):
TestSupport: Add support for installing from bac
-403. The environment variable is now in upper case, like one
would expect, and now a value of "0" as the same meaning as the variable
been absent. Also, there's a bit of documentation in `man xl`.
Thanks,
--
Anthony PERARD
is passed into the frontend so it
can take the appropriate measures.
This is part of XSA-403.
Signed-off-by: Roger Pau Monné
Signed-off-by: Anthony PERARD
---
changes:
- envvar now upper case
- documentation in xl man page
- value "0" also mean "trusted"
---
docs/man/xl.1.
ic devices.
This is part of XSA-403.
Signed-off-by: Anthony PERARD
---
docs/man/xl.1.pod.in | 24
tools/libs/light/libxl_disk.c | 6 +-
tools/libs/light/libxl_nic.c | 5 -
3 files changed, 33 insertions(+), 2 deletions(-)
diff --git a/docs/man/xl.1.pod.in b/doc
/xen/hypercall-defs.h: $(obj)/hypercall-defs.i
> $(srctree)/scripts/gen_hypercall.awk FORCE
> $(call if_changed,genhyp)
>
> -targets += xen/hypercall-defs.h
> +targets += hypercall-defs.i xen/hypercall-defs.h
Do you want to remove "hypercall-defs.i" from $(c
On Thu, Jul 21, 2022 at 01:14:41PM +, Andrew Cooper wrote:
> On 21/07/2022 14:09, Anthony PERARD wrote:
> > On Thu, Jul 21, 2022 at 01:03:41PM +, Andrew Cooper wrote:
> >> On 21/07/2022 13:45, Anthony Perard wrote:
> >>> Patch series available i
On Thu, Jul 21, 2022 at 01:03:41PM +, Andrew Cooper wrote:
> On 21/07/2022 13:45, Anthony Perard wrote:
> > Patch series available in this git branch:
> > https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git
> > br.gitlab-ci-improvement-v2
> >
> >
Share the same "except" as the one used for tests.
Signed-off-by: Anthony PERARD
---
Notes:
v2:
- rebased, to include "qemu-system-aarch64-6.0.0-arm32-export".
automation/gitlab-ci/build.yaml | 18 --
1 file changed, 12 insertions(+), 6 dele
Like with "dependencies", the jobs will get artifacts from the jobs
listed in "needs". But the test jobs can run as soon as the build jobs
listed have finished.
Signed-off-by: Anthony PERARD
---
Notes:
v2:
- rebased, to include "qemu-smoke-arm32-gcc".
The name of the field doesn't matter because it's use as a YAML achor,
but it's nicer to have the proper spelling.
Signed-off-by: Anthony PERARD
---
automation/gitlab-ci/build.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/automation/gitlab-ci/build.yaml b/automation
Allow to set common configuration from a single place for all tests
jobs.
Signed-off-by: Anthony PERARD
---
Notes:
v2:
- rebased, to include "qemu-smoke-arm32-gcc".
automation/gitlab-ci/test.yaml | 81 --
1 file changed, 18 insertions(+), 63
t jobs
aren't runned.
Anthony PERARD (4):
automation: fix typo in .gcc-tmpl
automation: add a templates for test jobs
automation: only run test artifact jobs when needed
automation: use "needs" instead of "dependencies" for test jobs
automation/gitlab-ci/build.yaml | 20
t for the domain to shutdown
or die. When we run `xl create`, before exiting there's a fork/exec of
xl which handle a few domain events, so it looks like this stack trace
is expected (and look like the one I have). So it don't looks like to be
the xl process that hangs.
--
Anthony PERARD
>
> Signed-off-by: Oleksandr Tyshchenko
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
o work
> on Xen (Arm), as for every Virtio device (including disk) we need
> to allocate Virtio MMIO params (IRQ and memory region) and pass
> them to the backend, also update Guest device-tree. The subsequent
> patch will add these missing bits. For the current patch,
> the default "irq" and "base" are just written to the Xenstore.
> This is not an ideal splitting, but this way we avoid breaking
> the bisectability.
>
> Signed-off-by: Oleksandr Tyshchenko
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
t I don't know why this commit fixed it.
$(debug) controls the level of optimisation of the compilation to make
it easier to debug.
So, with debug=y, we have libxenstore having issue with killing the
its reading thread? :-(
Maybe that reading thread is doing something that can't be stopped,
maybe it's waiting for a lock. Could you try to print a back trace of
that thread (or even all thread in `xl`)? ("thread apply all bt full" in gdb)
Thanks,
--
Anthony PERARD
From: Anthony PERARD
The macro "xen_mb()" needs to be a full memory barrier, that is it
needs to also prevent stores from been reorder after loads which an
x86 CPU can do (as I understand from reading [1]). So this patch makes
use of "mfence" instruction.
Currently, t
ed-off-by: Jan Beulich
> Tested-by: Henry Wang
> Tested-by: Wei Chen # arm
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
, rather than
> as "timed out".
>
> Signed-off-by: Jan Beulich
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
"other" is not unambiguous, then maybe we could choose "daemon" to
> >> describe arbitrary user-level backends, any thought?
> >
> > Unfortunately I didn’t have time to dig into this; I’m just going to
> > have to withdraw my objection, and let you & Juergen decide what to
> > call it.
>
> George, thanks for letting me know. Juergen proposed to use "standalone"
> for the new backendtype name which is far more specific. I agree with that.
>
>
> Anthony, would you be happy with that renaming?
I tried to figure out what backendtype is supposed to mean, how it's
used. I feel it's quite messy at the moment.
Man page xl-disk-configuration says it's a backend implementation to
use. Beside 'phy', which I guess is the kernel or blkback, the two other
point to QEMU ('qdisk') and tapdisk ('tap').
The, backendtype is used throughout libxl to deal with the different
backend implementation, and the value is stored in the xenstore key
"type". From "blkif.h", "type" should be 'file' or 'phy' or 'tap', but
we store 'qdisk' for 'qdisk'... so the "type" note in xenstore is
probably useless for qdisk, but maybe useful for 'phy'? (This "type"
node is only for the backend, so probably useless for a front end.)
Anyway, it seems to me that backendtype should be the name of the
implementation of the backend we want to use. It is just a parameter
to tell libxl how to communicate with the backend. At the moment libxl
uses xenstore to communicates with all backends even if that's not
required, because libxl works this way and it's hard to change. (We
could communicate with QEMU via QMP rather than xenstore for example.)
So I guess either you have a name for your implementation, or something
generic will do. So "standalone" is fine.
(We probably want to document somewhere that this new type would
simply mean "only-relying-on-xenstore-data" like Juergen is putting
it, and isn't blkback or QEMU.)
Thanks,
--
Anthony PERARD
convert the value
before using it in awk.
Fixes: 4d037425dc ("x86: Build check for embedded endbr64 instructions")
Reported-by: Luca Fancellu
Reported-by: Mathieu Tarral
Signed-off-by: Anthony PERARD
---
xen/tools/check-endbr.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
dif
Signed-off-by: Anthony PERARD
---
xen/tools/check-endbr.sh | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/xen/tools/check-endbr.sh b/xen/tools/check-endbr.sh
index 64fa9a56b7..523797a15f 100755
--- a/xen/tools/check-endbr.sh
+++ b/xen/tools/check-endbr.sh
@@ -10,6 +10,7
Patch series available in this git branch:
https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git
br.check-endbr-fix-v1
Hi.
Anthony PERARD (2):
xen: Fix check-endbr with mawk
xen: Introduce $AWK in check-endbr
xen/tools/check-endbr.sh | 5 +++--
1 file changed, 3 insertions
On Tue, Jul 12, 2022 at 09:01:48AM +0200, Jan Beulich wrote:
> On 11.07.2022 18:21, Anthony PERARD wrote:
> > On Fri, Jul 08, 2022 at 03:39:38PM +0200, Jan Beulich wrote:
> >> While in principle possible also under other conditions as long as other
> >> parallel opera
igned-off-by: Juergen Gross
> ---
> V2:
> - don't change mmio area settings (Anthony Perard)
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
d0227 ("xen: generate hypercall interface related code")
> Signed-off-by: Juergen Gross
> ---
> V2:
> - remove headers*.chk from clean-files, too (Anthony Perard)
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
On Mon, Jul 11, 2022 at 03:52:52PM +0200, Jan Beulich wrote:
> On 24.06.2022 18:04, Anthony PERARD wrote:
> > Setup proper dependencies with libacpi so we don't need to run "make
> > hvmloader" in the "all" target. ("build.o" new prerequisite isn't
>
title is a bit too broad and only correct a recent patch. It
doesn't really matter I think if `rm -f` tries to remove the same file
twice, but maybe this patch should actually do what it is explained in
the description ;-).
There is also "headers*.chk" that is listed in both $(targets) and
it wouldn't better
> be moved to the middle of the loop, immediately after "return true".
> That way having reached the goal on the last iteration would be reported
> as success to the caller, rather than as "timed out".
That would sound like a good improvement to the patch.
Thanks,
--
Anthony PERARD
On Thu, Jul 07, 2022 at 05:01:38PM +0200, Juergen Gross wrote:
> On 07.07.22 16:45, Anthony PERARD wrote:
> > On Fri, Jun 24, 2022 at 11:28:06AM +0200, Juergen Gross wrote:
> > > In case of maxmem != memsize the E820 map of the PVH stubdom is wrong,
> > > as it is mi
On Fri, Jul 08, 2022 at 03:39:00PM +, Luca Fancellu wrote:
> > On 24 Jun 2022, at 17:04, Anthony PERARD wrote:
[...]
> > For "roms.inc" target, use "$(SHELL)" instead of plain "sh". And use
> > full path to "mkhex" instead of
f4 ("libxl: add 'name' field to 'libxl_device_pci' in the
IDL...")
Signed-off-by: Anthony PERARD
---
Hi G.R., you've reported a segv in name2bdf(), and that the only
potential segv I've found. I hope it's the same one as you've
experienced!
---
tools/libs/light/libxl_pci.c | 2 +-
1 file
commit info, shouldn't the LAPIC address part of
`dom->mmio_start, dom->mmio_size`? (I don't know how dom->mmio_start is
used, yet, but maybe it's used by Xen or xen libraries to avoid
allocations in the wrong places)
Thanks,
--
Anthony PERARD
701 - 800 of 2964 matches
Mail list logo
