reminding me of how things looked
> for me before I adjusted TB configuration accordingly. I'd be fine
> hand-editing the patch while committing, if no other need arises for
> a v2 (and of course once a maintainer ack has been provided).
Acked-by: Anthony PERARD
Thanks,
--
Anthony PERARD
hat are uint64_t
> > types, so change "%lu" to "%"PRIu64 to handle it properly when
> > building on arm32 and arm64.
> >
> > Signed-off-by: Luca Fancellu
> Reviewed-by: Bertrand Marquis
Acked-by: Anthony PERARD
Thanks,
--
Anthony PERARD
t; for this to make progress.
Hi Jan,
Are you looking for a ack for the "docs/man" changes? If so, I guess
I'll have to make it more explicit next time that a review for "tools"
also mean review of the changes in their respective man pages.
Or are you looking for a ack for
. for checking for dependencies).
Signed-off-by: Anthony PERARD
---
tools/Rules.mk | 16 ++--
tools/libs/libs.mk | 2 +-
2 files changed, 15 insertions(+), 3 deletions(-)
diff --git a/tools/Rules.mk b/tools/Rules.mk
index 23979ed254..ce77dd2eb1 100644
--- a/tools/Rules.mk
+++ b
Missing prototype of asprintf() without _GNU_SOURCE.
Signed-off-by: Anthony PERARD
---
tools/helpers/xen-init-dom0.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/helpers/xen-init-dom0.c b/tools/helpers/xen-init-dom0.c
index 37eff8868f..764f837887 100644
--- a/tools/helpers/xen
Remove "build" targets.
Use "$(TARGETS)" to list binary to be built.
Cleanup "clean" rule.
Also drop conditional install of $(BIN) and $(LIBBIN) as those two
variables are now always populated.
Signed-off-by: Anthony PERARD
---
Notes:
v2:
- fix typo i
Patch "tools: Add -Werror by default to all tools/" have added
"-Werror" to CFLAGS in tools/Rules.mk, remove it from every other
makefiles as it is now duplicated.
Signed-off-by: Anthony PERARD
---
tools/console/client/Makefile | 1 -
tools/console/daemon/Makefile | 1 -
And provide an option to ./configure to disable it.
A follow-up patch will remove -Werror from every other Makefile in
tools/. ("tools: Remove -Werror everywhere else")
Signed-off-by: Anthony PERARD
---
tools/configure.ac | 1 +
tools/Rules.mk | 4
config/Tools.mk.in |
This avoid the need to open-coding the list of flags needed to link
with an in-tree Xen library when using -lxen*.
Signed-off-by: Anthony PERARD
---
tools/golang/xenlight/Makefile | 2 +-
tools/Rules.mk | 8
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git
$(SHDEPS_libxen*).
In libs.mk, we don't need to $(sort ) SHLIB_lib* anymore as this was used
to remove duplicates and they are no more duplicates.
Signed-off-by: Anthony PERARD
---
tools/Rules.mk | 29 -
tools/libs/libs.mk | 2 +-
2 files changed, 17 insertions(+), 14
Signed-off-by: Anthony PERARD
---
tools/console/client/Makefile | 3 +--
tools/console/daemon/Makefile | 6 +-
2 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/tools/console/client/Makefile b/tools/console/client/Makefile
index 44176c6d93..e2f2554f92 100644
--- a/tools/console
Signed-off-by: Anthony PERARD
---
tools/flask/utils/Makefile | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/tools/flask/utils/Makefile b/tools/flask/utils/Makefile
index db567b13dc..6be134142a 100644
--- a/tools/flask/utils/Makefile
+++ b/tools/flask/utils
Use $(TARGETS) to collect targets.
Collect library to link against in $(LDLIBS).
Remove extra "-f" flags that is already part of $(RM).
Signed-off-by: Anthony PERARD
---
Notes:
v3:
- apply changes to the new "init-dom0less" helper.
- make use of the new ma
We can simply use $(PKG_CONFIG) to set the parameters, and add it to
$(TARGETS) as necessary.
Signed-off-by: Anthony PERARD
---
tools/libs/libs.mk | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/tools/libs/libs.mk b/tools/libs/libs.mk
index e02f91f95e..7aee449370
Some reindentation.
FreeBSD, "hotplugpath.sh" is already installed by common/.
Signed-off-by: Anthony PERARD
---
tools/hotplug/FreeBSD/Makefile | 11 +++
tools/hotplug/Linux/Makefile | 16 ++--
tools/hotplug/Linux/systemd/Makefile | 16 +++-
t
There is no need to call the "headers.chk" target when it isn't
wanted, so it never need to be .PHONY.
Also, there is no more reason to separate the prerequisites from the
recipe.
Signed-off-by: Anthony PERARD
---
tools/libs/libs.mk | 10 --
1 file changed, 4 insertions(+), 6
Signed-off-by: Anthony PERARD
---
tools/libs/libs.mk | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/tools/libs/libs.mk b/tools/libs/libs.mk
index 58d8166b09..e02f91f95e 100644
--- a/tools/libs/libs.mk
+++ b/tools/libs/libs.mk
@@ -23,9 +23,9 @@ LDLIBS += $(foreach lib
Signed-off-by: Anthony PERARD
---
Notes:
v2:
- move new .gitignore entries to the one in tools/libs/
.gitignore| 26 --
tools/libs/.gitignore | 2 ++
2 files changed, 2 insertions(+), 26 deletions(-)
diff --git a/.gitignore b/.gitignore
index
program name.
In the "clean" rule, use $(RM) and remove all "*.o" instead of just
one object.
Signed-off-by: Anthony PERARD
---
Notes:
v2:
- use $(RM) in clean.
- remove all *.o instead of just one object in "clean" rule.
- in "install" rule,
t;.)
Make use if "-iquote" instead of a plain "-I".
For "roms.inc" target, use "$(SHELL)" instead of plain "sh". And use
full path to "mkhex" instead of a relative one. Lastly, add "-f" flag
to "mv", in case the tar
; make
and `xl` should be built as well as all the xen library needed.
Also, things like `make clean` or rebuild should be faster in the all tools/
directory.
Cheers,
Anthony PERARD (25):
tools/console: have one Makefile per program/directory
tools/debugger/gdbsx: Fix and cleanup makefile
are creating a new .gitignore for the links, also move the
existing entry to it.
Signed-off-by: Anthony PERARD
---
Notes:
v2:
- create a per-directory .gitignore to add new entry and existing one
tools/fuzz/libelf/Makefile | 21 ++---
.gitignore | 1 -
too
Remove -I. from CFLAGS, it isn't necessary.
Removed $(AUTOSRCS), it isn't used.
Signed-off-by: Anthony PERARD
---
tools/libs/util/Makefile | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/tools/libs/util/Makefile b/tools/libs/util/Makefile
index ffe507b379..493d2e00be
bsx", make will recurse even when both *.a already exist.
- List target in $(TARGETS).
gdbsx/*/:
- Fix dependency on *.h.
- Remove some dead code.
- List targets in $(TARGETS).
- Remove "build" target.
- Cleanup "clean" targets.
- remove comments about the
:
Remove the unused $(LDLIBS_xenconsole)
Signed-off-by: Anthony PERARD
---
Notes:
v2:
- create per-directory .gitignore
tools/console/Makefile | 49 ++--
tools/console/client/Makefile | 39 +
tools/console/daemon/Makefile
build" target.
Add an empty line after the first comment. The comment isn't about
$(XEN_READMES), it is about the makefile as a whole.
Signed-off-by: Anthony PERARD
---
Notes:
v2:
- remove existing loops in install targets and use a single call to
$(INSTALL_DATA) to install mult
a symlink exist, always regenerate the
symlink. So if the source tree changed location, the symlink is
updated.
Since we are creating a new .gitignore for the symlink, also move the
entry to it.
Signed-off-by: Anthony PERARD
---
Notes:
v2:
- create a new per-directory .gitignore to
- Rename $(SRCS) to $(OBJS-y), we don't need to collect sources.
- Rename $(IBINS) to $(TARGETS)
- Stop cleaning "xen" and non-set variable $(LIB).
Signed-off-by: Anthony PERARD
---
tools/xenpaging/Makefile | 24
1 file changed, 12 insertions(+), 12 deletion
the .*.d dependency files,
and iso9660.h already exist.
Signed-off-by: Anthony PERARD
---
tools/libfsimage/common/Makefile | 11 +++
tools/libfsimage/ext2fs-lib/Makefile | 9 -
tools/libfsimage/ext2fs/Makefile | 9 -
tools/libfsimage/fat/Makefile|
irq" and "base" are just written to the Xenstore.
> This is not an ideal splitting, but this way we avoid breaking
> the bisectability.
>
> Signed-off-by: Oleksandr Tyshchenko
> ---
> Changes V10 -> V10.1:
>- fix small coding style issue in libxl__device_disk_get_path()
>
mapped into the guest's memory. Also, move the comment
> about trapping 0xfc for the Intel OpRegion where it belongs after
> applying this patch.
>
> Signed-off-by: Chuck Zmudzinski
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
n/include: use if_changed")
Signed-off-by: Anthony PERARD
Reviewed-by: Bertrand Marquis
---
Notes:
v3:
- add one more pattern to avoid a possible empty body for "case"
- use $() instead of `` to execute get_prereq()
- also convert headers99_chk
- convert some 't
On Wed, Jun 15, 2022 at 08:11:10AM +0200, Jan Beulich wrote:
> On 14.06.2022 18:22, Anthony PERARD wrote:
> > --- a/xen/Makefile
> > +++ b/xen/Makefile
> > @@ -22,6 +22,7 @@ PYTHON_INTERPRETER:= $(word 1,$(shell which
> > python3 python python2 2>
On Wed, Jun 15, 2022 at 07:32:54PM +0300, Oleksandr wrote:
> On 15.06.22 17:23, Anthony PERARD wrote:
> > On Mon, Jun 13, 2022 at 09:05:20PM +0300, Oleksandr Tyshchenko wrote:
> > > diff --git a/tools/xl/xl_block.c b/tools/xl/xl_block.c
> > > index 70eed43..f2b0ff5
o that QEMU know if
it have to do the hypercall or not, and thus newer version of QEMU could
also deal with older version of libxl.
(There's maybe some example like that in both QEMU and libxl, when doing
live migration, dm_state_save_to_fdset() in libxl as a pointer)
Cheers,
--
Anthony PERARD
> +s->real_device.vendor_id != PCI_VENDOR_ID_INTEL) {
> +continue;
> + }
> reg_grp_offset = XEN_PCI_INTEL_OPREGION;
> }
Thanks,
--
Anthony PERARD
ing that the Linux guest never completes the boot process.
>
> Fixes: 2e87512eccf3
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1061
> Buglink: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=988333
>
> Signed-off-by: Chuck Zmudzinski
Reviewed-by: Anthony P
using new Makefile.common
28: stubdom: xenlibs linkfarm, ignore non-regular files
29: tools/ocaml: fix build dependency target
(I didn't a run with them on our gitlab ci, and no build issue.)
Thanks,
--
Anthony PERARD
recall correctly, libxl__add_disks() is
called instead at guest creation. So maybe it is possible to do
something in libxl_device_disk_add(), but that a function defined by a
macro, and the macro is using the same libxl__device_disk_add() that
libxl_device_disk_add(). On the other hand, there is a "hotplug"
parameter to libxl__device_disk_setdefault(), maybe that could be use?
Cheers,
--
Anthony PERARD
On Wed, Jun 15, 2022 at 08:37:42AM +0200, Jan Beulich wrote:
> On 14.06.2022 18:22, Anthony PERARD wrote:
> > diff --git a/xen/include/Makefile b/xen/include/Makefile
> > index 6d9bcc19b0..49c75a78f9 100644
> > --- a/xen/include/Makefile
> > +++ b/xen/include/Make
OSIX shell don't allow to work with associative array or
variables with "/".
Reported-by: Bertrand Marquis
Fixes: 28e13c7f43 ("build: xen/include: use if_changed")
Signed-off-by: Anthony PERARD
Reviewed-by: Bertrand Marquis
---
Notes:
v2:
- fix typo in commit messa
-off-by: Anthony PERARD
---
Notes:
v2:
- Add .pl extension to the perl script
- remove "-w" from the shebang as it is duplicate of "use warning;"
- Add a note in the commit message that the "headers generated are
identical".
xen/include/Makefile
We are going to use it in a moment.
Also update README about Perl requirement.
Signed-off-by: Anthony PERARD
---
Notes:
v2:
- update ./README
xen/Makefile | 1 +
README | 1 +
2 files changed, 2 insertions(+)
diff --git a/xen/Makefile b/xen/Makefile
index 82f5310b12
Now that the command line generating "xlat.h" is check on rebuild, the
header will be regenerated whenever the list of xlat headers changes
due to change in ".config". We don't need to force a regeneration for
every changes in ".config".
Signed-off-by: Anthony
saves about 2.0 seconds (out of ~37s).
Thanks.
Anthony PERARD (4):
build,include: rework shell script for headers++.chk
build: remove auto.conf prerequisite from compat/xlat.h target
build: set PERL
build: replace get-fields.sh by a perl script
xen/Makefile| 1 +
x
ning make as 2nd time would lead to
> successful building of xen/.
>
> While this wasn't a problem until several weeks back, I've not been able
> to identify which exact commit would have caused the breakage. Hence no
> Fixes: tag.
Reviewed-by: Anthony PERARD
Looks like this happened
looks fine.
> ---
> !!! This patch is based on non upstreamed yet “Virtio support for toolstack
> on Arm” V8 series which is on review now:
> https://lore.kernel.org/xen-devel/1651598763-12162-1-git-send-email-olekst...@gmail.com/
With the patch added to the series it depends on: Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
clashed
> ones.
>
> Signed-off-by: Julien Grall
> Signed-off-by: Oleksandr Tyshchenko
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
n implementation of get_path() which may return
a different answer depending on thing outside of libxl's full control.
So, could you at least make it much harder to have libxl's view of a
guest in a weird state? I mean:
- always check both xenstore paths
-> if both exist, return an error
-> if only one exist, return that one.
-> default to the "vbd" kind, otherwise.
That would be better than the current implementation which returns the
"virtio" path by default.
Thanks,
--
Anthony PERARD
On Tue, May 31, 2022 at 06:25:13PM -0700, Elliott Mitchell wrote:
> On Fri, May 20, 2022 at 03:12:46PM +0100, Anthony PERARD wrote:
> > On Tue, Apr 19, 2022 at 06:23:41PM -0700, Elliott Mitchell wrote:
> > > JSON is currently used when saving domains to mass storage. Being able
and related to
PCIIDEState and IDEBus rather than piix.
Therefore, move this function to xen_platform, unexport it, and drop the
"piix3" in the function name as well.
Signed-off-by: Bernhard Beschow
Reviewed-by: Paul Durrant
Acked-by: Anthony PERARD
Reviewed-by: Philippe Mathieu-Daud
-tested on a 2nd system without seeing an
> > issue.
>
> I have the problem only when building using Yocto, I did a normal build and
> the
> issue is not coming.
>
Will the following patch help?
>From 0f32f749304b233c0d5574dc6b14f66e8709feba Mon Sep 17 00:00:00 2001
From: Anthony PERAR
On Wed, Jun 01, 2022 at 10:32:10AM -0700, Elliott Mitchell wrote:
> On Wed, Jun 01, 2022 at 05:59:08PM +0100, Anthony PERARD wrote:
> > diff --git a/xen/tools/compat-xlat-header b/xen/tools/compat-xlat-header
> > new file mode 100755
> > index 00..f1f42a9dde
> >
On Thu, Jun 02, 2022 at 11:01:30AM +0200, Jan Beulich wrote:
> On 01.06.2022 18:59, Anthony PERARD wrote:
> > --- a/xen/Makefile
> > +++ b/xen/Makefile
> > @@ -22,6 +22,7 @@ PYTHON_INTERPRETER:= $(word 1,$(shell which
> > python3 python python2 2>
On Thu, Jun 02, 2022 at 11:11:15AM +0200, Jan Beulich wrote:
> On 01.06.2022 18:59, Anthony PERARD wrote:
> > Use "define" for the headers*_chk commands as otherwise the "#"
> > is interpreted as a comment and make can't find the end of
> > $(foreach,).
&g
On Wed, Jun 01, 2022 at 05:17:36PM +, Andrew Cooper wrote:
> On 01/06/2022 17:59, Anthony PERARD wrote:
> > Patch series available in this git branch:
> > https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git
> > br.build-system-xen-include-rework-v1
> >
make the generation of those file a lot
faster.
I tried to keep a similar look for the code, to keep the code similar
between the shell and perl, and to ease review. So some code in perl
might look weird or could be written better.
Signed-off-by: Anthony PERARD
---
xen/include/Makefile
Now that the command line generating "xlat.h" is check on rebuild, the
header will be regenerated whenever the list of xlat headers changes
due to change in ".config". We don't need to force a regeneration for
every changes in ".config".
Signed-off-by: Anthony PER
We are going to use it in a moment.
Signed-off-by: Anthony PERARD
---
xen/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/xen/Makefile b/xen/Makefile
index 82f5310b12..a6650a2acc 100644
--- a/xen/Makefile
+++ b/xen/Makefile
@@ -22,6 +22,7 @@ PYTHON_INTERPRETER:= $(word 1
if the target exist in order to decide whether to recreate the
target.
Removing the call to `mkdir` from the commands. Those aren't needed
anymore because a rune in Rules.mk creates the directory for each
$(targets).
Remove "export PYTHON" as it is already exported.
Signed-off-by: An
at headers less verbose
and to have the command line part of the decision to rebuild the headers.
Second one is to replace one slow script by a much faster one, and save time
when generating the headers.
Thanks.
Anthony PERARD (4):
build: xen/include: use if_changed
build: set PERL
build: r
Suggested-by: Andrew Cooper
> Signed-off-by: Luca Fancellu
Acked-by: Anthony PERARD
Thanks,
--
Anthony PERARD
out;
> +libxl_fd_set_cloexec(CTX, CTX->sigchld_selfpipe[0], 1);
> +libxl_fd_set_cloexec(CTX, CTX->sigchld_selfpipe[1], 1);
These ones should be also ok, as the pipe is only used for the SIGCHLD
handler so not shared outside of libxl.
So the patch looks good, and hopefully we don't break libvirt.
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
ccurately
> reflect what the hypervisor expects.
>
> Signed-off-by: Tamas K Lengyel
Is exposing do_memory_op necessary? This kind of looks like a revert of
35e135f116 ("libxc: make xc_memory_op library private"). Anyway, if
there isn't a better alternative: Acked-by: Anthony PE
int it again? Also, if we have strerror(), what the point of
printing "errno"?
Also, I'm not sure the extra indentation in the error message is really
useful, but that doesn't really matter.
> +
> +if ( (size >> XC_PAGE_SHIFT) != nr_frames )
> +err(1, "Fail: Get size: expected %u frames, got %zu\n",
> +nr_frames, size >> XC_PAGE_SHIFT);
err() prints strerror(errno), maybe errx() is better here.
Thanks,
--
Anthony PERARD
On Thu, May 19, 2022 at 08:16:16PM +0300, Oleksandr wrote:
> On 18.05.22 14:05, Anthony PERARD wrote:
> > On Tue, May 03, 2022 at 08:26:03PM +0300, Oleksandr Tyshchenko wrote:
> > > +for (i = 0; i < d_config->num_disks; i++) {
> > > +libxl_dev
would need documentation about the new option, about the
format. The man page need to be edited.
An example of a config file written in json would be nice as well.
Thanks,
--
Anthony PERARD
move the dryrun element of domain_create as that has been displaced
> by the global "dryrun_only" variable.
>
> Signed-off-by: Elliott Mitchell
Reviewed-by: Anthony PERARD
Thanks for the clean up.
--
Anthony PERARD
On Tue, Apr 19, 2022 at 06:56:03PM -0700, Elliott Mitchell wrote:
> Hopefully simplify future changes by sorting options lists for
> `xl create`. While at it, declare the options list constant.
>
> Signed-off-by: Elliott Mitchell
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
how
> Reviewed-by: Paul Durrant
Acked-by: Anthony PERARD
Thanks,
--
Anthony PERARD
d-unplug.pandoc
> + */
> int pci_piix3_xen_ide_unplug(DeviceState *dev, bool aux)
> {
> PCIIDEState *pci_ide;
That comments seems to focus on 'aux', but it also gives some pointer on
what calls the function. So it looks fine.
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
chow
Creating a guest and migrating a guest seems to work fine without
"piix3-ide-xen", and I can't find this name used outside of QEMU. So I
guess it's fine to remove it.
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
;
> Adjust the related comments and documentation accordingly.
>
> Signed-off-by: Juergen Gross
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
"BaseTools: Upgrade the version of NASM tool")
Signed-off-by: Anthony PERARD
---
production-config | 2 ++
ts-xen-build-prep | 2 ++
2 files changed, 4 insertions(+)
diff --git a/production-config b/production-config
index 9d2e7e0ee492..b77763a19443 100644
--- a/production-config
+++
}
>
> +
> +static int make_virtio_mmio_node(libxl__gc *gc, void *fdt,
> + uint64_t base, uint32_t irq)
> +{
> +int res;
> +gic_interrupt intr;
> +/* Placeholder for virtio@ + a 64-bit number + \0 */
> +char buf[24];
> +
> +snprintf(buf, sizeof(buf), "virtio@%"PRIx64, base);
Could you use GCSPRINTF() here instead of using a buffer of a static
size calculated by hand which is potentially wrong? Also, the return
value of snprintf isn't checked so the string could be truncated without
warning. So I think GCSPRINTF is better than a static buffer.
The rest of the patch looks fine.
Thanks,
--
Anthony PERARD
h = GCSPRINTF("%s/device/%s",
> + libxl__xs_libxl_path(gc, domid),
> +
> libxl__device_kind_to_string(LIBXL__DEVICE_KIND_VIRTIO_DISK));
> +
> +rc = libxl__xs_read_checked(gc, XBT_NULL, *path, );
> +if (rc)
> +return rc;
> +
> +return 0;
> +}
> +
> int libxl_vdev_to_device_disk(libxl_ctx *ctx, uint32_t domid,
>const char *vdev, libxl_device_disk *disk)
> {
> diff --git a/tools/libs/light/libxl_types.idl
> b/tools/libs/light/libxl_types.idl
> index 2a42da2..f783cac 100644
> --- a/tools/libs/light/libxl_types.idl
> +++ b/tools/libs/light/libxl_types.idl
> @@ -704,6 +716,10 @@ libxl_device_disk = Struct("device_disk", [
> ("is_cdrom", integer),
> ("direct_io_safe", bool),
> ("discard_enable", libxl_defbool),
> +("specification", libxl_disk_specification),
> +("transport", libxl_disk_transport),
Could you add a comment here about "irq" and "base", that say that they
are for internal use by libxl and can't be modified? Is it possible
that in the future, an application like libvirt could potentially change
those two values and have libxl use them?
> +("irq", uint32),
> +("base", uint64),
> # Note that the COLO configuration settings should be considered
> unstable.
> # They may change incompatibly in future versions of Xen.
> ("colo_enable", libxl_defbool),
Thanks,
--
Anthony PERARD
On Fri, May 13, 2022 at 02:35:34PM +0100, Anthony PERARD wrote:
> Recent versions of OVMF now need a version of NASM that is newer
> than the one available on Debian oldstable/buster. They want to use
> NASM 2.15.05 [1], which is available in Debian stable/bullseye. The
> need to
"BaseTools: Upgrade the version of NASM tool")
Signed-off-by: Anthony PERARD
---
ts-xen-build-prep | 9 +
1 file changed, 9 insertions(+)
diff --git a/ts-xen-build-prep b/ts-xen-build-prep
index 67b3eae62155..38d4a8e79451 100755
--- a/ts-xen-build-prep
+++ b/ts-xen-build-prep
@@ -
bxenguest.a] Error 2
make: *** [Makefile:73: build-stubdom] Error 2
Cheers,
--
Anthony PERARD
Signed-off-by: Anthony PERARD
---
docs/features/migration.pandoc | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/docs/features/migration.pandoc b/docs/features/migration.pandoc
index 719925818e..5334536d48 100644
--- a/docs/features/migration.pandoc
+++ b/docs/features
ably not going to go smoothly.
> Adjust the related comments and documentation accordingly.
>
> Signed-off-by: Juergen Gross
> ---
> V2:
> - adjust comments and docs (Anthony Perard)
Maybe `man xl` should be updated as well. In the section about `xl
mem-max`, there is:
"
ted_x{2}apic options are not part of
> the migration stream, unless explicitly set in the respective
> configuration files. Default settings of assisted_x{2}apic done
> internally by the toolstack, based on host capabilities at create
> time, are not migrated.
>
> Suggested-by: Andrew Cooper
>
t be done on a common interface.
>
> Suggested-by: Andrew Cooper
> Signed-off-by: Jane Malalane
> Reviewed-by: "Roger Pau Monné"
No changes in the tools since v9, so my tag still stand:
Reviewed-by: Anthony PERARD # tools
--
Anthony PERARD
opts, "create", 0) {
> case 'A':
> vnc = vncautopass = 1;
> break;
> case 'F':
> daemonize = 0;
> break;
> +case 'J':
> +dom_info.format = FORMAT_LEGACY;
> +break;
> case 'V':
> vnc = 1;
> break;
> @@ -1212,6 +1218,9 @@ int main_create(int argc, char **argv)
> case 'i':
> ignore_masks = 1;
> break;
> +case 'j':
> +dom_info.format = FORMAT_JSON;
This setting is ignored, as "dom_info" is reset later.
> +break;
> case 'n':
> dryrun_only = 1;
> break;
Thanks,
--
Anthony PERARD
uot;, 0) {
> -case 'f':
> -filename = optarg;
> + SWITCH_FOREACH_OPT(opt, "Ffnq:AVcdeip", opts, "create", 0) {
The list of short options aren't really sorted here. Also -q doesn't
take an argument, but -f should keep requiring one.
Thanks,
--
Anthony PERARD
libxl_get_required_shadow_memory).
> + * libxl__get_required_paging_memory).
I think in this comment, the "caller" is an application using libxl,
which might set shadow_memkb with a value from
libxl_get_required_shadow_memory(). So I don't think there's a need to
change the comment
On Wed, Apr 27, 2022 at 03:31:56PM +0200, Thomas Huth wrote:
> The Xen hypervisor is only available on x86 and arm - thus let's
> limit the related options to these targets.
>
> Signed-off-by: Thomas Huth
Acked-by: Anthony PERARD
Thanks,
--
Anthony PERARD
et's avoid this situation by fencing the parameter with the
> CONFIG_XEN_BACKEND switch.
>
> Signed-off-by: Thomas Huth
Acked-by: Anthony PERARD
Thanks,
--
Anthony PERARD
nd path by reading the appropriate value from the backend.
>
> Also change use of `...` to $(...) for a consistent style in the script.
>
> Signed-off-by: James Dingwall
Reviewed-by: Anthony PERARD
Thanks!
> diff --git a/tools/hotplug/Linux/xen-network-common.sh
to >= 68. I can
> resubmit the original patch if either of these are a problem.
The style change is fine, but I'd rather have the change to the
mtu check in a different patch.
Otherwise, the patch looks better, thanks.
--
Anthony PERARD
g.
>
> Signed-off-by: Jason Andryuk
> ---
> v2:
> Only retry when a stubdom is present.
> Move pci_add_timeout initialization.
> Use pas->aodev->ao directly.
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
|\( [aUw]
> \)\|\(\.\.ng$$\)\|\(LASH[RL]DI\)' > System.map
>
> %.o %.i %.s: %.c tools_fixdep FORCE
Thanks,
--
Anthony PERARD
On Thu, Apr 14, 2022 at 12:47:08PM +0100, Andrew Cooper wrote:
> There are no .S intermediate files, so rework in terms of head-bin-objs.
>
> No functional change.
>
> Signed-off-by: Andrew Cooper
The patch looks fine.
Reviewed-by: Anthony PERARD
> ---
> I'm slightl
g "head.o". The .d files wouldn't
exist on a first build. I don't think a comment about that isn't really
necessary, but if there's one it should be about telling `make` to build
cmdline.bin and head.bin first.
Otherwise, the patch looks good.
Thanks,
--
Anthony PERARD
aning of this line is described in the file CONTRIBUTING, section
"Developer's Certificate of Origin".
Thanks,
--
Anthony PERARD
Hi Ross,
Could you also ack this livpatch change?
Thanks.
On Tue, Mar 22, 2022 at 11:22:38AM +, Anthony PERARD wrote:
> This implement out-of-tree support, there's two ways to create an
> out-of-tree build tree (after that, `make` in that new directory
> works):
>
t; longer print the unpopulated fields.
>
> Signed-off-by: Roger Pau Monné
Acked-by: Anthony PERARD
> ---
> We should find a way for those tests to be run as part of osstest, or
> else they will go stale again sooner or later.
I guess having those two tests case in "tools/tests/" w
retry logic only for the
second do_pci_add() call? So that guests without stubdom aren't impacted
as I don't think retrying in this case would be useful and would just
delay the error.
Cheers,
--
Anthony PERARD
entry using xen-init-dom0
> helper with the usual convention: Pool-.
>
> Given the change, remove the check for poolid == 0 from
> libxl_cpupoolid_to_name(...).
>
> Signed-off-by: Luca Fancellu
> ---
> Changes in v6:
> - Reworked loop to have only one error path (Anth
R, domid, "Couldn't set %s/memory/static-max, rc=%d\n",
> + dompath, rc);
> +goto out;
So, I don't know whether increasing "static-max" is fine or not, but
according to the documentation, it isn't expected.
Is a guest fine with "static-max" been changed?
If yes, there's documentation and comments that needs to change with the
code change.
Thanks,
--
Anthony PERARD
801 - 900 of 2963 matches
Mail list logo
