Re: [PATCH] libxl: Fix handling XenStore errors in device creation

2024-05-10 Thread Demi Marie Obenour
On Fri, May 10, 2024 at 07:00:49PM +0100, Andrew Cooper wrote: > On 10/05/2024 9:05 am, Jürgen Groß wrote: > > On 27.04.24 04:17, Demi Marie Obenour wrote: > >> If xenstored runs out of memory it is possible for it to fail operations > >> that should succeed. 

[PATCH] libxl: Fix handling XenStore errors in device creation

2024-04-26 Thread Demi Marie Obenour
not be able to run xenstored out of memory, but it still needs to be fixed. Add the missing error checks to ensure that all errors are properly handled and that at no point can a guest make the TTY path of its frontend directory writable. Signed-off-by: Demi Marie Obenour --- tools/libs/light

Re: Linux 6.7-rc1+: WARNING at drivers/xen/evtchn.c:167 evtchn_interrupt

2024-03-12 Thread Demi Marie Obenour
>"Interrupt for port %u, but apparently not enabled; per-user %p\n", >evtchn->port, u); > @@ -421,6 +426,7 @@ static void evtchn_unbind_from_user(struct per_user_data > *u, > > BUG_ON(irq < 0); > > + evtchn->unbinding = true; >

Re: Sketch of an idea for handling the "mixed workload" problem

2024-01-23 Thread Demi Marie Obenour
On Mon, Jan 22, 2024 at 11:54:14AM +, George Dunlap wrote: > On Mon, Jan 22, 2024 at 12:31 AM Demi Marie Obenour > wrote: > > > > On Fri, Sep 29, 2023 at 05:42:16PM +0100, George Dunlap wrote: > > > The basic credit2 algorithm goes something like this: >

Re: Sketch of an idea for handling the "mixed workload" problem

2024-01-21 Thread Demi Marie Obenour
t credits can be set by dom0 via a hypercall. The advantage of this approach is that it keeps almost all policy out of Xen. The only exception is the boosting when an interrupt is received, but a well-behaved guest will deboost itself very quickly (by enabling interrupts) if the boost was not actual

Re: Sketch of an idea for handling the "mixed workload" problem

2024-01-21 Thread Demi Marie Obenour
On Mon, Oct 02, 2023 at 12:20:31PM +0100, George Dunlap wrote: > On Sun, Oct 1, 2023 at 12:28 AM Demi Marie Obenour > wrote: > > > > On Fri, Sep 29, 2023 at 05:42:16PM +0100, George Dunlap wrote: > > > The basic credit2 algorithm goes something like this: >

Re: Sketch of an idea for handling the "mixed workload" problem

2023-09-30 Thread Demi Marie Obenour
tify dom0 so that a warning can be displayed to the user. Additionally, a certain amount of CPU time (such as 10%) should be reserved for dom0, so that the system remains responsive. Qubes OS could also help here. If a VM is allowed to record audio, it (and the VMs providing network to it, transitively)

Re: [oss-security] Xen Security Advisory 439 v1 (CVE-2023-20588) - x86/AMD: Divide speculative information leak

2023-09-26 Thread Demi Marie Obenour
en. It's hard to trust a hypervisor (KVM) that will not issue them, for then one has no way to know if a particular problem got fixed. I'm CCing KVM here to make sure they have a fix. From their Git commit history, I am almost certain that seL4 does not. I'm CCing the seL4 developers to alert them

Re: [PATCH v2 for-4.18?] x86: support data operand independent timing mode

2023-09-14 Thread Demi Marie Obenour
> and Kconfig control in common files. > > > > > > > > [1] > > > > https://www.intel.com/content/www/us/en/developer/articles/technical/software-security-guidance/best-practices/data-operand-independent-timing-isa-guidance.html > > > > > >

[PATCH v4] xen: speed up grant-table reclaim

2023-07-26 Thread Demi Marie Obenour
. The default is still 10, but it can be overridden via a module parameter. This is Cc: stable because (when combined with appropriate userspace changes) it fixes a severe performance and stability problem for Qubes OS users. Cc: sta...@vger.kernel.org Signed-off-by: Demi Marie Obenour

Re: [PATCH v3] xen: speed up grant-table reclaim

2023-07-04 Thread Demi Marie Obenour
On Tue, Jul 04, 2023 at 02:07:47PM +0200, Jan Beulich wrote: > On 27.06.2023 19:22, Demi Marie Obenour wrote: > > When a grant entry is still in use by the remote domain, Linux must put > > it on a deferred list. Normally, this list is very short, because > > the PV networ

[PATCH v3] xen: speed up grant-table reclaim

2023-06-27 Thread Demi Marie Obenour
users. Cc: sta...@vger.kernel.org Signed-off-by: Demi Marie Obenour --- drivers/xen/grant-table.c | 40 --- 1 file changed, 29 insertions(+), 11 deletions(-) Changes since v2: - use atomic_inc_return(x) and atomic_dec_return(x) instead of atomic_add_return(1, x

[PATCH v3] xen: speed up grant-table reclaim

2023-06-24 Thread Demi Marie Obenour
users. Cc: sta...@vger.kernel.org Signed-off-by: Demi Marie Obenour --- drivers/xen/grant-table.c | 40 --- 2 files changed, 41 insertions(+), 11 deletions(-) diff --git a/drivers/xen/grant-table.c b/drivers/xen/grant-table.c index

Re: [PATCH v2 13/16] xen-blkback: Implement diskseq checks

2023-06-20 Thread Demi Marie Obenour
On Mon, Jun 12, 2023 at 10:09:39AM +0200, Roger Pau Monné wrote: > On Fri, Jun 09, 2023 at 12:55:39PM -0400, Demi Marie Obenour wrote: > > On Fri, Jun 09, 2023 at 05:13:45PM +0200, Roger Pau Monné wrote: > > > On Thu, Jun 08, 2023 at 11:33:26AM -0400, Demi Marie Obenour wrote: &

Re: [PATCH] xen: speed up grant-table reclaim

2023-06-13 Thread Demi Marie Obenour
On Tue, Jun 13, 2023 at 08:45:31AM +0200, Juergen Gross wrote: > On 12.06.23 22:09, Demi Marie Obenour wrote: > > On Mon, Jun 12, 2023 at 08:27:59AM +0200, Juergen Gross wrote: > > > On 10.06.23 17:32, Demi Marie Obenour wrote: > > > > When a grant entry is still in u

Re: [PATCH v3 1/4] limits.h: add UCHAR_MAX, SCHAR_MAX, and SCHAR_MIN

2023-06-12 Thread Demi Marie Obenour
On Mon, Jun 12, 2023 at 05:31:51PM +0100, Vincenzo Frascino wrote: > Hi Demi, > > On 6/10/23 21:40, Demi Marie Obenour wrote: > > Some drivers already defined these, and they will be used by sscanf() > > for overflow checks later. Also add SSIZE_MIN to limits.h, which wi

Re: [PATCH] xen: speed up grant-table reclaim

2023-06-12 Thread Demi Marie Obenour
On Mon, Jun 12, 2023 at 08:27:59AM +0200, Juergen Gross wrote: > On 10.06.23 17:32, Demi Marie Obenour wrote: > > When a grant entry is still in use by the remote domain, Linux must put > > it on a deferred list. > > This lacks quite some context. > > The main prob

[PATCH v3 4/4] Reject NUL bytes in xenstore nodes

2023-06-10 Thread Demi Marie Obenour
This rejects bogus xenstore node values that include interior NUL bytes. These would be truncated by functions that expect NUL-terminated strings. Signed-off-by: Demi Marie Obenour --- drivers/xen/xenbus/xenbus_xs.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff

[PATCH v3 3/4] vsscanf(): do not skip spaces

2023-06-10 Thread Demi Marie Obenour
Passing spaces before e.g. an integer is usually not intended. This was suggested by Christoph in https://lore.kernel.org/lkml/ziqrohcizoj4b...@infradead.org/. Suggested-by: Christoph Hellwig Signed-off-by: Demi Marie Obenour --- lib/vsprintf.c | 8 +--- 1 file changed, 1 insertion(+), 7

[PATCH v3 1/4] limits.h: add UCHAR_MAX, SCHAR_MAX, and SCHAR_MIN

2023-06-10 Thread Demi Marie Obenour
Some drivers already defined these, and they will be used by sscanf() for overflow checks later. Also add SSIZE_MIN to limits.h, which will also be needed later. Signed-off-by: Demi Marie Obenour --- .../media/atomisp/pci/hive_isp_css_include/platform_support.h | 1 - include/linux/limits.h

[PATCH v3 2/4] vsscanf(): Integer overflow is a conversion failure

2023-06-10 Thread Demi Marie Obenour
of unsigned conversions by default, though, as in at least some cases accepting negative numbers is _not_ intended. Suggested-By: Linus Torvalds Signed-off-by: Demi Marie Obenour --- lib/vsprintf.c | 90 ++ 1 file changed, 69 insertions(+), 21 deletions

[PATCH v3 0/4] Make sscanf() stricter

2023-06-10 Thread Demi Marie Obenour
the first patch (removal of simple_strtoll()) as it breaks bcache. - Stop skipping spaces in vsscanf() instead of adding a separate vsscanf_strict() function. Demi Marie Obenour (4): limits.h: add UCHAR_MAX, SCHAR_MAX, and SCHAR_MIN vsscanf(): Integer overflow is a conversion failure vsscanf

[PATCH v2 3/3] Strict XenStore entry parsing

2023-06-10 Thread Demi Marie Obenour
This rejects bogus xenstore node values that include e.g. leading spaces or overflow the expected integer type. Signed-off-by: Demi Marie Obenour --- drivers/xen/xenbus/xenbus_xs.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/drivers/xen/xenbus

[PATCH v2 2/3] vsscanf(): do not skip spaces

2023-06-10 Thread Demi Marie Obenour
Passing spaces before e.g. an integer is usually not intended. This was suggested by Christoph in https://lore.kernel.org/lkml/ziqrohcizoj4b...@infradead.org/. Suggested-by: Christoph Hellwig Signed-off-by: Demi Marie Obenour --- lib/vsprintf.c | 8 +--- 1 file changed, 1 insertion(+), 7

[PATCH v2 0/3] Make sscanf() stricter

2023-06-10 Thread Demi Marie Obenour
+ include/linux/mfd/wl1273-core.h | 3 - include/vdso/limits.h | 3 + lib/vsprintf.c| 90 +-- 6 files changed, 80 insertions(+), 35 deletions(-) -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things

[PATCH v2 1/3] vsscanf(): Integer overflow is a conversion failure

2023-06-10 Thread Demi Marie Obenour
of unsigned conversions by default, though, as in at least some cases accepting negative numbers is _not_ intended. Suggested-By: Linus Torvalds Signed-off-by: Demi Marie Obenour --- .../hive_isp_css_include/platform_support.h | 1 - include/linux/limits.h| 1 + include

[PATCH] xen: speed up grant-table reclaim

2023-06-10 Thread Demi Marie Obenour
. The default is still 10, but it can be overridden at compile-time (via Kconfig), boot-time (via a kernel command-line option), or runtime (via sysfs). Fixes: 569ca5b3f94c ("xen/gnttab: add deferred freeing logic") Cc: sta...@vger.kernel.org Signed-off-by: Demi Marie Obenour --- d

[PATCH 3/4] Add strict version of vsscanf()

2023-06-09 Thread Demi Marie Obenour
Signed-off-by: Demi Marie Obenour --- include/linux/kernel.h | 4 lib/vsprintf.c | 43 +++--- 2 files changed, 44 insertions(+), 3 deletions(-) diff --git a/include/linux/kernel.h b/include/linux/kernel.h index

[PATCH 4/4] Strict XenStore entry parsing

2023-06-09 Thread Demi Marie Obenour
This uses the newly-introduced strict version of sscanf(). Signed-off-by: Demi Marie Obenour --- drivers/xen/xenbus/xenbus_xs.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/drivers/xen/xenbus/xenbus_xs.c b/drivers/xen/xenbus/xenbus_xs.c index

[PATCH 1/4] Rip out simple_strtoll()

2023-06-09 Thread Demi Marie Obenour
It is not used anywhere but its own unit tests. Signed-off-by: Demi Marie Obenour --- Documentation/dev-tools/checkpatch.rst | 9 - Documentation/process/deprecated.rst | 5 ++--- .../translations/it_IT/process/deprecated.rst | 9

[PATCH 2/4] vsscanf(): Return -ERANGE on integer overflow

2023-06-09 Thread Demi Marie Obenour
Userspace sets errno to ERANGE, but the kernel can't do that. Signed-off-by: Demi Marie Obenour --- include/linux/limits.h | 1 + include/linux/mfd/wl1273-core.h | 3 -- include/vdso/limits.h | 3 ++ lib/vsprintf.c | 80 - 4

Re: [PATCH v2 13/16] xen-blkback: Implement diskseq checks

2023-06-09 Thread Demi Marie Obenour
On Fri, Jun 09, 2023 at 05:13:45PM +0200, Roger Pau Monné wrote: > On Thu, Jun 08, 2023 at 11:33:26AM -0400, Demi Marie Obenour wrote: > > On Thu, Jun 08, 2023 at 10:29:18AM +0200, Roger Pau Monné wrote: > > > On Wed, Jun 07, 2023 at 12:14:46PM -0400, Demi Marie Obenour wrote: &

Re: [PATCH v2 13/16] xen-blkback: Implement diskseq checks

2023-06-08 Thread Demi Marie Obenour
On Thu, Jun 08, 2023 at 10:29:18AM +0200, Roger Pau Monné wrote: > On Wed, Jun 07, 2023 at 12:14:46PM -0400, Demi Marie Obenour wrote: > > On Wed, Jun 07, 2023 at 10:20:08AM +0200, Roger Pau Monné wrote: > > > On Tue, Jun 06, 2023 at 01:01:20PM -0400, Demi Marie Obenour wrote: &

Re: [PATCH v2 16/16] xen-blkback: Inform userspace that device has been opened

2023-06-08 Thread Demi Marie Obenour
On Thu, Jun 08, 2023 at 12:08:55PM +0200, Roger Pau Monné wrote: > On Tue, May 30, 2023 at 04:31:16PM -0400, Demi Marie Obenour wrote: > > Set "opened" to "0" before the hotplug script is called. Once the > > device node has been opened, set "opened"

Re: [PATCH v2 16/16] xen-blkback: Inform userspace that device has been opened

2023-06-08 Thread Demi Marie Obenour
On Thu, Jun 08, 2023 at 11:11:44AM +0200, Roger Pau Monné wrote: > On Wed, Jun 07, 2023 at 12:29:26PM -0400, Demi Marie Obenour wrote: > > On Wed, Jun 07, 2023 at 10:44:48AM +0200, Roger Pau Monné wrote: > > > On Tue, Jun 06, 2023 at 01:31:25PM -0400, Demi Marie Obenour wrote: &

Re: [PATCH v2 16/16] xen-blkback: Inform userspace that device has been opened

2023-06-07 Thread Demi Marie Obenour
On Wed, Jun 07, 2023 at 10:44:48AM +0200, Roger Pau Monné wrote: > On Tue, Jun 06, 2023 at 01:31:25PM -0400, Demi Marie Obenour wrote: > > On Tue, Jun 06, 2023 at 11:15:37AM +0200, Roger Pau Monné wrote: > > > On Tue, May 30, 2023 at 04:31:16PM -0400, Demi Marie Obenour wrote: &

Re: [PATCH v2 13/16] xen-blkback: Implement diskseq checks

2023-06-07 Thread Demi Marie Obenour
On Wed, Jun 07, 2023 at 10:20:08AM +0200, Roger Pau Monné wrote: > On Tue, Jun 06, 2023 at 01:01:20PM -0400, Demi Marie Obenour wrote: > > On Tue, Jun 06, 2023 at 10:25:47AM +0200, Roger Pau Monné wrote: > > > On Tue, May 30, 2023 at 04:31:13PM -0400, Demi Marie Obenour wrote: &

Re: [PATCH 2/2] xen-blkback: Inform userspace that device has been opened

2023-06-07 Thread Demi Marie Obenour
; > +is called. Once the device node has been opened, blkback sets "opened" > > +to "1". > > This is a really odd comment style, and a really strange place for it. > To me it feels like this should just be a file in Documentation as it > relates to how to use the dri

Re: [PATCH 1/2] xen-blkback: Implement diskseq checks

2023-06-07 Thread Demi Marie Obenour
On Wed, Jun 07, 2023 at 12:44:22AM -0700, Christoph Hellwig wrote: > On Thu, Jun 01, 2023 at 05:48:22PM -0400, Demi Marie Obenour wrote: > > + if (diskseq) { > > + struct gendisk *disk = bdev->bd_disk; > > + > > + if (unlikely(disk == NULL)) {

Re: [PATCH v2 16/16] xen-blkback: Inform userspace that device has been opened

2023-06-06 Thread Demi Marie Obenour
On Tue, Jun 06, 2023 at 11:15:37AM +0200, Roger Pau Monné wrote: > On Tue, May 30, 2023 at 04:31:16PM -0400, Demi Marie Obenour wrote: > > Set "opened" to "0" before the hotplug script is called. Once the > > device node has been opened, set "opened"

Re: [PATCH v2 13/16] xen-blkback: Implement diskseq checks

2023-06-06 Thread Demi Marie Obenour
On Tue, Jun 06, 2023 at 10:25:47AM +0200, Roger Pau Monné wrote: > On Tue, May 30, 2023 at 04:31:13PM -0400, Demi Marie Obenour wrote: > > This allows specifying a disk sequence number in XenStore. If it does > > not match the disk sequence number of the underlying dev

[PATCH 1/2] xen-blkback: Implement diskseq checks

2023-06-01 Thread Demi Marie Obenour
not support the new syntax, but a later patch will allow userspace to discover that the new syntax is supported. Signed-off-by: Demi Marie Obenour --- drivers/block/xen-blkback/xenbus.c | 112 +++-- 1 file changed, 89 insertions(+), 23 deletions(-) diff --git a/drivers/block

[PATCH 2/2] xen-blkback: Inform userspace that device has been opened

2023-06-01 Thread Demi Marie Obenour
opened", "1"); + if (err) { + xenbus_dev_fatal(dev, err, "%s: notifying userspace device has been opened", +dev->nodename); + goto free_vbd; + } + err = xenvbd_sysfs_addif(dev); if (err) { xenbus_dev_fatal(dev, err, "creating sysfs entries"); -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab

[PATCH 0/2] xen/blkback: support delete-on-close block devices

2023-06-01 Thread Demi Marie Obenour
These two patches allow userspace to provide an expected diskseq of a block device and discover when blkback has opened the device. Together, these features allow using blkback with delete-on-close block devices, such as loop devices with autoclear set. Demi Marie Obenour (2): xen-blkback

[PATCH v2 16/16] xen-blkback: Inform userspace that device has been opened

2023-05-30 Thread Demi Marie Obenour
h as loop devices with the autoclear flag set or device-mapper devices with the deferred-remove flag set. Signed-off-by: Demi Marie Obenour --- drivers/block/xen-blkback/xenbus.c | 35 ++ 1 file changed, 35 insertions(+) diff --git a/drivers/

[PATCH v2 13/16] xen-blkback: Implement diskseq checks

2023-05-30 Thread Demi Marie Obenour
not support the new syntax, but a later patch will allow userspace to discover that the new syntax is supported. Signed-off-by: Demi Marie Obenour --- drivers/block/xen-blkback/xenbus.c | 112 +++-- 1 file changed, 89 insertions(+), 23 deletions(-) diff --git a/drivers/block

[PATCH v2 15/16] xen-blkback: Minor cleanups

2023-05-30 Thread Demi Marie Obenour
This adds a couple of BUILD_BUG_ON()s and moves some arithmetic after the validation code that checks the arithmetic’s preconditions. The previous code was correct but could potentially trip sanitizers that check for unsigned integer wraparound. Signed-off-by: Demi Marie Obenour --- drivers

[PATCH v2 12/16] device-mapper: inform caller about already-existing device

2023-05-30 Thread Demi Marie Obenour
Not only is this helpful for debugging, it also saves the caller an ioctl in the case where a device should be used if it exists or created otherwise. To ensure existing userspace is not broken, this feature is only enabled in strict mode. Signed-off-by: Demi Marie Obenour --- drivers/md/dm

[PATCH v2 14/16] block, loop: Increment diskseq when releasing a loop device

2023-05-30 Thread Demi Marie Obenour
. Export the inc_diskseq() function to make this possible. Signed-off-by: Demi Marie Obenour --- I considered destroying the loop device altogether instead of bumping its diskseq, but was not able to accomplish that. Suggestions welcome. --- block/genhd.c| 1 + drivers/block/loop.c | 6

[PATCH v2 10/16] device-mapper: Refuse to create device named "control"

2023-05-30 Thread Demi Marie Obenour
Typical userspace setups create a symlink under /dev/mapper with the name of the device, but /dev/mapper/control is reserved for the control device. Therefore, trying to create such a device is almost certain to be a userspace bug. Signed-off-by: Demi Marie Obenour --- drivers/md/dm-ioctl.c

[PATCH v2 11/16] device-mapper: "." and ".." are not valid symlink names

2023-05-30 Thread Demi Marie Obenour
M_CONTROL_NODE) == 0 || + strcmp(name, ".") == 0 || + strcmp(name, "..") == 0) { + DMERR("device name cannot be \"%s\", \".\", or \"..\"", DM_CONTROL_NODE); return -EINVAL; } -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab

[PATCH v2 09/16] device-mapper: Allow userspace to suppress uevent generation

2023-05-30 Thread Demi Marie Obenour
Userspace can use this to avoid spamming udev with events that udev should ignore. Signed-off-by: Demi Marie Obenour --- drivers/md/dm-core.h | 2 + drivers/md/dm-ioctl.c | 78 ++- drivers/md/dm.c | 5 ++- include/linux/device

[PATCH v2 08/16] device-mapper: Allow userspace to provide expected diskseq

2023-05-30 Thread Demi Marie Obenour
This can be used to avoid race conditions in which a device is destroyed and recreated with the same major/minor, name, or UUID. diskseqs are only honored if strict parameter checking is on, to avoid any risk of breaking old userspace. Signed-off-by: Demi Marie Obenour --- drivers/md/dm

[PATCH v2 07/16] device-mapper: Allow userspace to opt-in to strict parameter checks

2023-05-30 Thread Demi Marie Obenour
that are not supported by the ioctl, as well as nonzero padding and names and UUIDs that are not NUL-terminated. New flags will only be recognized if major version 5 is used. Kernels without this patch return -EINVAL if the major version is 5, so this is backwards compatible. Signed-off-by: Demi Marie Obenour

[PATCH v2 06/16] device-mapper: Avoid double-fetch of version

2023-05-30 Thread Demi Marie Obenour
a problem if future patches start relying on the version field. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: sta...@vger.kernel.org Signed-off-by: Demi Marie Obenour --- drivers/md/dm-ioctl.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/md/dm

[PATCH v2 05/16] device-mapper: Target parameters must not overlap next target spec

2023-05-30 Thread Demi Marie Obenour
The NUL terminator for each target parameter string must preceed the following 'struct dm_target_spec'. Otherwise, dm_split_args() might corrupt this struct. Signed-off-by: Demi Marie Obenour Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: sta...@vger.kernel.org --- drivers/md/dm-io

[PATCH v2 04/16] device-mapper: Better error message for too-short target spec

2023-05-30 Thread Demi Marie Obenour
Previously the error was "unable to find target", which is not helpful. Signed-off-by: Demi Marie Obenour --- drivers/md/dm-ioctl.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/md/dm-ioctl.c b/drivers/md/dm-ioc

[PATCH v2 01/16] device-mapper: Check that target specs are sufficiently aligned

2023-05-30 Thread Demi Marie Obenour
Otherwise subsequent code will dereference a misaligned `struct dm_target_spec *`, which is undefined behavior. Signed-off-by: Demi Marie Obenour Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: sta...@vger.kernel.org --- drivers/md/dm-ioctl.c | 7 +++ 1 file changed, 7 insertion

[PATCH v2 02/16] device-mapper: Avoid pointer arithmetic overflow

2023-05-30 Thread Demi Marie Obenour
Especially on 32-bit systems, it is possible for the pointer arithmetic to overflow and cause a userspace pointer to be dereferenced in the kernel. Signed-off-by: Demi Marie Obenour Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: sta...@vger.kernel.org --- drivers/md/dm-io

[PATCH v2 03/16] device-mapper: do not allow targets to overlap 'struct dm_ioctl'

2023-05-30 Thread Demi Marie Obenour
This prevents dm_split_args() from corrupting this struct. Signed-off-by: Demi Marie Obenour Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: sta...@vger.kernel.org --- drivers/md/dm-ioctl.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/md/dm-ioctl.c b/drivers/md/

[PATCH v2 00/16] Diskseq support in loop, device-mapper, and blkback

2023-05-30 Thread Demi Marie Obenour
or "control". Since device-mapper devices are often accessed via /dev/mapper/NAME, such names would likely greatly confuse userspace. I consider this to be an extension of the existing check that prohibits device mapper names or UUIDs from containing '/'. Demi Marie Obenour (16): de

Removing Linux memory hotplug limitations

2023-05-19 Thread Demi Marie Obenour
short, there is a very clear, nearly linear relationship between the amount of cold-plugged memory and the amount of memory that can be hotplugged later. -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab signature.asc Description: PGP signature

Re: [PATCH] configure: Drop --enable-githttp

2023-03-24 Thread Demi Marie Obenour
On Fri, Mar 24, 2023 at 08:14:04PM +, Andrew Cooper wrote: > Following Demi's work to use HTTPS everywhere, all users of GIT_HTTP have > been removed from the build system. Drop the configure knob. > > Signed-off-by: Andrew Cooper Reviewed-by: Demi Marie Obenour > --

[PATCH v6 5/5] Automation and CI: Replace git:// and http:// with https://

2023-03-21 Thread Demi Marie Obenour
Obtaining code over an insecure transport is a terrible idea for blatently obvious reasons. Even for non-executable data, insecure transports are considered deprecated. This patch enforces the use of secure transports in automation and CI. All URLs are known to work. Signed-off-by: Demi Marie

[PATCH v6 4/5] Build system: Replace git:// and http:// with https://

2023-03-21 Thread Demi Marie Obenour
them with the URLs that were redirected to. Signed-off-by: Demi Marie Obenour --- stubdom/configure | 12 ++-- stubdom/configure.ac | 12 ++-- tools/firmware/etherboot/Makefile | 6 +- 3 files changed, 13 insertions(+), 17 deletions(-) diff --git

[PATCH v6 3/5] Build system: Do not try to use broken links

2023-03-21 Thread Demi Marie Obenour
The upstream URLs for zlib, PolarSSL, and the TPM emulator do not work anymore, so do not attempt to use them. Signed-off-by: Demi Marie Obenour --- m4/stubdom.m4| 5 +++-- stubdom/configure| 21 +++-- stubdom/configure.ac | 6 +++--- 3 files changed, 9 insertions

[PATCH v6 2/5] Change remaining xenbits.xen.org link to HTTPS

2023-03-21 Thread Demi Marie Obenour
and are known to work. Signed-off-by: Demi Marie Obenour --- Config.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Config.mk b/Config.mk index 75f1975e5e78af44d36c2372cba6e89b425267a5..b2bef45b059976d5a6320eabada6073004eb22ee 100644 --- a/Config.mk +++ b/Config.mk @@ -191,7 +191,7

[PATCH v6 1/5] Use HTTPS for all xenbits.xen.org Git repos

2023-03-21 Thread Demi Marie Obenour
shell script: git ls-files -z | xargs -0 -- sed -Ei -- 's@(git://xenbits\.xen\.org|http://xenbits\.xen\.org/git-http)/@https://xenbits.xen.org/git-http/@g' All altered links have been tested and are known to work. Signed-off-by: Demi Marie Obenour --- Config.mk

[PATCH v6 0/5] Stop using insecure transports

2023-03-21 Thread Demi Marie Obenour
to review. - Ensure that no links are broken, and fail with an error instead of trying to use links that *are* broken. Demi Marie Obenour (5): Use HTTPS for all xenbits.xen.org Git repos Change remaining xenbits.xen.org link to HTTPS Build system: Do not try to use broken links Build

Re: [PATCH v5 4/5] Build system: Replace git:// and http:// with https://

2023-02-27 Thread Demi Marie Obenour
On Mon, Feb 27, 2023 at 09:42:24AM +0100, Jan Beulich wrote: > On 25.02.2023 21:37, Demi Marie Obenour wrote: > > --- a/stubdom/configure > > +++ b/stubdom/configure > > @@ -3545,7 +3545,7 @@ if test "x$LIBPCI_URL" = "x"; then : > > if tes

Re: [PATCH v4 2/3] Build system: Replace git:// and http:// with https://

2023-02-27 Thread Demi Marie Obenour
On Mon, Feb 27, 2023 at 09:25:32AM +0100, Jan Beulich wrote: > On 24.02.2023 23:55, Demi Marie Obenour wrote: > > On Tue, Feb 21, 2023 at 11:07:58AM +0100, Jan Beulich wrote: > >> On 19.02.2023 03:46, Demi Marie Obenour wrote: > >>> --- a/stubdom/configure

Re: [PATCH v5 2/5] Change remaining xenbits.xen.org links to HTTPS

2023-02-27 Thread Demi Marie Obenour
On Mon, Feb 27, 2023 at 09:35:51AM +0100, Jan Beulich wrote: > On 25.02.2023 21:37, Demi Marie Obenour wrote: > > --- a/Config.mk > > +++ b/Config.mk > > @@ -191,7 +191,7 @@ APPEND_CFLAGS += $(foreach i, $(APPEND_INCLUDES), > > -I$(i)) > > EMBEDDED_EXTRA_CFLAGS

[PATCH v5 4/5] Build system: Replace git:// and http:// with https://

2023-02-25 Thread Demi Marie Obenour
them with the URLs that were redirected to. Signed-off-by: Demi Marie Obenour --- stubdom/configure | 12 ++-- stubdom/configure.ac | 12 ++-- tools/firmware/etherboot/Makefile | 6 +- 3 files changed, 13 insertions(+), 17 deletions(-) diff --git

[PATCH v5 5/5] Automation and CI: Replace git:// and http:// with https://

2023-02-25 Thread Demi Marie Obenour
/releases/armhf/alpine-minirootfs-3.15.1-armhf.tar.gz -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab

[PATCH v5 3/5] Build system: Do not try to use broken links

2023-02-25 Thread Demi Marie Obenour
The upstream URLs for zlib, PolarSSL, and the TPM emulator do not work anymore, so do not attempt to use them. Signed-off-by: Demi Marie Obenour --- m4/stubdom.m4| 5 +++-- stubdom/configure| 21 +++-- stubdom/configure.ac | 6 +++--- 3 files changed, 9 insertions

[PATCH v5 2/5] Change remaining xenbits.xen.org links to HTTPS

2023-02-25 Thread Demi Marie Obenour
Also fix an old xenbits.xenproject.org link. Signed-off-by: Demi Marie Obenour --- Config.mk| 2 +- tools/misc/mkrpm | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Config.mk b/Config.mk index 75f1975e5e78af44d36c2372cba6e89b425267a5

[PATCH v5 1/5] Use HTTPS for all xenbits.xen.org Git repos

2023-02-25 Thread Demi Marie Obenour
shell script: git ls-files -z | xargs -0 -- sed -Ei -- 's@(git://xenbits\.xen\.org|http://xenbits\.xen\.org/git-http)/@https://xenbits.xen.org/git-http/@g' All altered links have been tested and are known to work. Signed-off-by: Demi Marie Obenour --- Config.mk

[PATCH v5 0/5] Stop using insecure transports

2023-02-25 Thread Demi Marie Obenour
+--- tools/misc/mkrpm| 2 +- 12 files changed, 37 insertions(+), 63 deletions(-) -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab

Re: [PATCH v4 2/3] Build system: Replace git:// and http:// with https://

2023-02-24 Thread Demi Marie Obenour
On Tue, Feb 21, 2023 at 11:07:58AM +0100, Jan Beulich wrote: > On 19.02.2023 03:46, Demi Marie Obenour wrote: > > --- a/stubdom/configure > > +++ b/stubdom/configure > > @@ -3535,7 +3535,7 @@ if test "x$ZLIB_URL" = "x"; then : > > if t

[PATCH] Call SetVirtualAddressMap() by default

2023-02-22 Thread Demi Marie Obenour
EVE ship it as well. Mark EFI_SET_VIRTUAL_ADDRESS_MAP as SUPPORTED and enable it by default. Signed-off-by: Demi Marie Obenour --- What is necessary for this patch to be accepted? xen/common/Kconfig | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/xen/common/Kconfig b/x

[PATCH v4 3/3] Automation and CI: Replace git:// and http:// with https://

2023-02-18 Thread Demi Marie Obenour
Obtaining code over an insecure transport is a terrible idea for blatently obvious reasons. Even for non-executable data, insecure transports are considered deprecated. This patch enforces the use of secure transports in automation and CI. All URLs are known to work. Signed-off-by: Demi Marie

[PATCH v4 1/3] Use HTTPS for all xenbits.xen.org Git repos

2023-02-18 Thread Demi Marie Obenour
shell script: git ls-files -z | xargs -0 -- sed -Ei -- 's@(git://xenbits\.xen\.org|http://xenbits\.xen\.org/git-http)/@https://xenbits.xen.org/git-http/@g' All altered links have been tested and are known to work. Signed-off-by: Demi Marie Obenour --- Config.mk

[PATCH v4 2/3] Build system: Replace git:// and http:// with https://

2023-02-18 Thread Demi Marie Obenour
them with the URLs that were redirected to. Signed-off-by: Demi Marie Obenour --- Config.mk | 2 +- stubdom/configure | 18 +- stubdom/configure.ac | 18 +- tools/firmware/etherboot/Makefile | 6 +- 4 files

[PATCH v4 0/3] Stop using insecure transports

2023-02-18 Thread Demi Marie Obenour
urgent and hardest to review. - Ensure that no links are broken, and fail with an error instead of trying to use links that *are* broken. Demi Marie Obenour (3): Use HTTPS for all xenbits.xen.org Git repos Build system: Replace git:// and http:// with https:// Automation and CI: Replace git

[PATCH v3 4/4] Rip out HyperTransport

2023-02-17 Thread Demi Marie Obenour
It is not used and the website is gone. Signed-off-by: Demi Marie Obenour --- xen/include/xen/pci_regs.h | 37 - 1 file changed, 37 deletions(-) diff --git a/xen/include/xen/pci_regs.h b/xen/include/xen/pci_regs.h index

[PATCH v3 3/4] Automation and CI: Replace git:// and http:// with https://

2023-02-17 Thread Demi Marie Obenour
Obtaining code over an insecure transport is a terrible idea for blatently obvious reasons. Even for non-executable data, insecure transports are considered deprecated. This patch enforces the use of secure transports in automation and CI. All URLs are known to work. Signed-off-by: Demi Marie

[PATCH v3 2/4] Build system: Replace git:// and http:// with https://

2023-02-17 Thread Demi Marie Obenour
original URLs. Therefore, configure will now error out instead of trying to download them. Signed-off-by: Demi Marie Obenour --- Config.mk | 2 +- stubdom/configure | 24 +++- stubdom/configure.ac | 24

[PATCH v3 1/4] Use HTTPS for all xenbits.xen.org Git repos

2023-02-17 Thread Demi Marie Obenour
shell script: git ls-files -z | xargs -0 -- sed -Ei -- 's@(git://xenbits\.xen\.org|http://xenbits\.xen\.org/git-http)/@https://xenbits.xen.org/git-http/@g' All altered links have been tested and are known to work. Signed-off-by: Demi Marie Obenour --- Config.mk

[PATCH v3 0/4] Stop using insecure transports

2023-02-17 Thread Demi Marie Obenour
urgent and hardest to review. - Ensure that no links are broken, and fail with an error instead of trying to use links that *are* broken. Demi Marie Obenour (4): Use HTTPS for all xenbits.xen.org Git repos Build system: Replace git:// and http:// with https:// Automation and CI: Replace git

Re: [PATCH] xen: speed up grant-table reclaim

2023-02-14 Thread Demi Marie Obenour
On Tue, Feb 14, 2023 at 08:51:09AM +0100, Juergen Gross wrote: > On 13.02.23 22:01, Demi Marie Obenour wrote: > > On Mon, Feb 13, 2023 at 10:26:11AM +0100, Juergen Gross wrote: > > > On 07.02.23 03:10, Demi Marie Obenour wrote: > > > > When a grant entry is still in u

Re: [PATCH] xen: speed up grant-table reclaim

2023-02-13 Thread Demi Marie Obenour
On Mon, Feb 13, 2023 at 10:26:11AM +0100, Juergen Gross wrote: > On 07.02.23 03:10, Demi Marie Obenour wrote: > > When a grant entry is still in use by the remote domain, Linux must put > > it on a deferred list. Normally, this list is very short, because > > the PV networ

Re: [PATCH v2 3/4] Miscellaneous and documentation: Only use TLS-protected transports

2023-02-09 Thread Demi Marie Obenour
On Thu, Feb 09, 2023 at 02:25:07PM +, George Dunlap wrote: > On Wed, Feb 8, 2023 at 8:59 PM Demi Marie Obenour < > d...@invisiblethingslab.com> wrote: > > > Obtaining code over an insecure transport is a terrible idea for > > blatently obvious reasons. Even for no

Re: [PATCH v2 1/4] Build system: Replace git:// and http:// with https://

2023-02-09 Thread Demi Marie Obenour
On Thu, Feb 09, 2023 at 02:01:52PM +, George Dunlap wrote: > On Wed, Feb 8, 2023 at 8:58 PM Demi Marie Obenour < > d...@invisiblethingslab.com> wrote: > > > Obtaining code over an insecure transport is a terrible idea for > > blatently obvious reasons. Even for no

Re: [PATCH v2 2/4] Automation and CI: Replace git:// and http:// with https://

2023-02-09 Thread Demi Marie Obenour
On Thu, Feb 09, 2023 at 02:03:34PM +, George Dunlap wrote: > On Wed, Feb 8, 2023 at 8:59 PM Demi Marie Obenour < > d...@invisiblethingslab.com> wrote: > > > Obtaining code over an insecure transport is a terrible idea for > > blatently obvious reasons. Even for no

Re: [PATCH v2 4/4] GPL License Boilerplate: Switch from HTTP to HTTPS

2023-02-08 Thread Demi Marie Obenour
On Wed, Feb 08, 2023 at 02:58:38PM -0800, Stefano Stabellini wrote: > On Wed, 8 Feb 2023, Demi Marie Obenour wrote: > > Obtaining code over an insecure transport is a terrible idea for > > blatently obvious reasons. Even for non-executable data, insecure > > transports are

[PATCH v2 3/4] Miscellaneous and documentation: Only use TLS-protected transports

2023-02-08 Thread Demi Marie Obenour
-off-by: Demi Marie Obenour --- COPYING | 4 ++-- CREDITS | 2 +- README| 4 ++-- SUPPORT.md| 2 +- docs/features/feature-levelling.pandoc

[PATCH v2 2/4] Automation and CI: Replace git:// and http:// with https://

2023-02-08 Thread Demi Marie Obenour
Obtaining code over an insecure transport is a terrible idea for blatently obvious reasons. Even for non-executable data, insecure transports are considered deprecated. This patch enforces the use of secure transports in automation and CI. Signed-off-by: Demi Marie Obenour --- README

[PATCH v2 1/4] Build system: Replace git:// and http:// with https://

2023-02-08 Thread Demi Marie Obenour
Obtaining code over an insecure transport is a terrible idea for blatently obvious reasons. Even for non-executable data, insecure transports are considered deprecated. This patch enforces the use of secure transports in the build system. Signed-off-by: Demi Marie Obenour --- Config.mk

[PATCH v2 0/4] Stop using insecure transports

2023-02-08 Thread Demi Marie Obenour
Obtaining code over an insecure transport is a terrible idea for blatently obvious reasons. Even for non-executable data, insecure transports are considered deprecated. Demi Marie Obenour (4): Build system: Replace git:// and http:// with https:// Automation and CI: Replace git:// and http

Re: [PATCH 4/4] GPL License Boilerplate: Switch from HTTP to HTTPS

2023-02-08 Thread Demi Marie Obenour
On Wed, Feb 08, 2023 at 08:26:37AM +, Julien Grall wrote: > Hi, > > On 08/02/2023 07:40, Jan Beulich wrote: > > On 08.02.2023 05:51, Demi Marie Obenour wrote: > > > --- a/xen/drivers/passthrough/pci.c > > > +++ b/xen/drivers/passthrough/pci.c > > >

  1   2   3   4   5   >