[PATCH] MAINTAINERS: add me as scheduer maintainer

2024-06-05 Thread Juergen Gross
I've been active in the scheduling code since many years now. Add me as a maintainer. Signed-off-by: Juergen Gross --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 6ba7d2765f..cc40c0be9d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -490,6

[PATCH] MAINTAINERS: add an entry for tools/9pfsd

2024-06-05 Thread Juergen Gross
Add me as the maintainer for the tools/9pfsd directory. Signed-off-by: Juergen Gross --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 076cf1e141..28fb35582b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -206,6 +206,12 @@ Maintainers List

Re: CVE-2021-47377: kernel: xen/balloon: use a kernel thread instead a workqueue

2024-05-27 Thread Juergen Gross
Hi, I'd like to dispute CVE-2021-47377: the issue fixed by upstream commit 8480ed9c2bbd56fc86524998e5f2e3e22f5038f6 can in no way be triggered by an unprivileged user or by a remote attack of the system, as it requires initiation of memory ballooning of the running system. This can be done only

Re: [PATCH v3 2/4] xen/arm: Alloc XenStore page for Dom0less DomUs from hypervisor

2024-05-24 Thread Juergen Gross
On 24.05.24 16:30, Jürgen Groß wrote: On 24.05.24 15:58, Julien Grall wrote: Hi Henry, + Juergen as the Xenstore maintainers. I'd like his opinion on the approach. The documentation of the new logic is in: https://lore.kernel.org/xen-devel/20240517032156.1490515-5-xin.wa...@amd.com/ FWIW I

[GIT PULL] xen: branch for v6.10-rc1

2024-05-24 Thread Juergen Gross
Linus, Please git pull the following tag: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-6.10a-rc1-tag xen: branch for v6.10-rc1 It contains the following patches: - a small cleanup in the drivers/xen/xenbus Makefile - a fix of the Xen xenstore driver to improve

Re: [PATCH 5/5] x86/pvh: Add 64bit relocation page tables

2024-05-23 Thread Juergen Gross
On 10.04.24 21:48, Jason Andryuk wrote: The PVH entry point is 32bit. For a 64bit kernel, the entry point must switch to 64bit mode, which requires a set of page tables. In the past, PVH used init_top_pgt. This works fine when the kernel is loaded at LOAD_PHYSICAL_ADDR, as the page tables are

Re: [PATCH 4/5] x86/kernel: Move page table macros to new header

2024-05-23 Thread Juergen Gross
On 10.04.24 21:48, Jason Andryuk wrote: The PVH entry point will need an additional set of prebuild page tables. Move the macros and defines to a new header so they can be re-used. Signed-off-by: Jason Andryuk With the one nit below addressed: Reviewed-by: Juergen Gross ... diff --git

[PATCH] xen/sched: set all sched_resource data inside locked region for new cpu

2024-05-15 Thread Juergen Gross
[] F common/softirq.c#__do_softirq+0x94/0xbe (XEN)[] F do_softirq+0x13/0x15 (XEN)[] F arch/x86/domain.c#idle_loop+0x92/0xe6 Reported-by: Andrew Cooper Fixes: a8c6c623192e ("sched: clarify use cases of schedule_cpu_switch()") Signed-off-by: Juergen Gross --- xen/common/sched/co

[PATCH v7] xen: allow up to 16383 cpus

2024-05-10 Thread Juergen Gross
2 * CONFIG_NR_CPUS. Add a support limit of physical CPUs to SUPPORT.md (4096 on x86, 128 on ARM). Signed-off-by: Juergen Gross Acked-by: Jan Beulich --- V5: - new patch (Jan Beulich) V7: - add SUPPORT.md and CHANGELOG.md entries --- CHANGELOG.md | 2 ++ SUPPORT.md | 5 + xen/arch

Re: [RFC KERNEL PATCH v6 2/3] xen/pvh: Setup gsi for passthrough device

2024-05-10 Thread Juergen Gross
On 19.04.24 05:36, Jiqian Chen wrote: In PVH dom0, the gsis don't get registered, but the gsi of a passthrough device must be configured for it to be able to be mapped into a domU. When assign a device to passthrough, proactively setup the gsi of the device during that process.

Re: [PATCH v1 1/1] xen/xenbus: Use *-y instead of *-objs in Makefile

2024-05-10 Thread Juergen Gross
Acked-by: Juergen Gross Juergen OpenPGP_0xB0DE9DD628BF132F.asc Description: OpenPGP public key OpenPGP_signature.asc Description: OpenPGP digital signature

Re: [PATCH v6 8/8] xen: allow up to 16383 cpus

2024-05-06 Thread Juergen Gross
13:04, Julien Grall wrote: Hi Juergen, Sorry for the late reply. On 29/04/2024 11:33, Juergen Gross wrote: On 08.04.24 09:10, Jan Beulich wrote: On 27.03.2024 16:22, Juergen Gross wrote: With lock handling now allowing up to 16384 cpus (spinlocks can handle 65535 cpus, rwlocks can handle 16384

[GIT PULL] xen: branch for v6.9-rc7

2024-05-03 Thread Juergen Gross
. Juergen arch/x86/xen/enlighten_pv.c | 11 ++- arch/x86/xen/smp_pv.c | 4 ++-- 2 files changed, 12 insertions(+), 3 deletions(-) Juergen Gross (1): x86/xen: return a sane initial apic id when running as PV guest Thomas Gleixner (1): x86/xen/smp_pv: Register the boot CPU

[PATCH] tools/tests: don't let test-xenstore write nodes exceeding default size

2024-05-02 Thread Juergen Gross
. Fixes: 3afc5e4a5b75 ("tools/tests: add xenstore testing framework") Signed-off-by: Juergen Gross --- tools/tests/xenstore/test-xenstore.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/tests/xenstore/test-xenstore.c b/tools/tests/xenstore/test-xensto

[PATCH] tools/tests: let test-xenstore exit with non-0 status in case of error

2024-05-02 Thread Juergen Gross
In case a test is failing in test-xenstore, let the tool exit with an exit status other than 0. Fix a typo in an error message. Reported-by: Andrew Cooper Fixes: 3afc5e4a5b75 ("tools/tests: add xenstore testing framework") Signed-off-by: Juergen Gross --- tools/tests/xenstore/test-

Re: CVE-2024-26908: x86/xen: Add some null pointer checking to smp.c

2024-04-29 Thread Juergen Gross
Hi, I'd like to dispute CVE-2024-26908: the issue fixed by upstream commit 3693bb4465e6e32a204a5b86d3ec7e6b9f7e67c2 can in no way be triggered by an unprivileged user or by a remote attack of the system, as it requires hotplug of (virtual) cpus to the running system. This can be done only by

Re: [PATCH v6 8/8] xen: allow up to 16383 cpus

2024-04-29 Thread Juergen Gross
On 08.04.24 09:10, Jan Beulich wrote: On 27.03.2024 16:22, Juergen Gross wrote: With lock handling now allowing up to 16384 cpus (spinlocks can handle 65535 cpus, rwlocks can handle 16384 cpus), raise the allowed limit for the number of cpus to be configured to 16383. The new limit is imposed

[PATCH] Mini-OS: add some macros for asm statements

2024-04-16 Thread Juergen Gross
Instead of having #ifdefs sprinkled around in x86 code, add some macros defining constants for asm statements to address differences between 32- and 64-bit mode. Modify existing code to use those macros. Signed-off-by: Juergen Gross --- arch/x86/sched.c | 32

[PATCH] x86/pat: fix W^X violation false-positives when running as Xen PV guest

2024-04-09 Thread Juergen Gross
ranslation entries and evaluate those as well in verify_rwx() and show_fault_oops(). Fixes: 652c5bf380ad ("x86/mm: Refuse W^X violations") Reported-by: Jason Andryuk Signed-off-by: Juergen Gross --- arch/x86/include/asm/pgtable_types.h | 2 +- arch/x86/kernel/sev.c| 3 +-

Re: Linux Xen PV CPA W^X violation false-positives

2024-04-09 Thread Juergen Gross
On 08.04.24 12:22, Anthony PERARD wrote: On Thu, Mar 28, 2024 at 02:00:14PM +0100, Jürgen Groß wrote: Hi Jason, On 28.03.24 02:24, Jason Andryuk wrote: On Wed, Mar 27, 2024 at 7:46 AM Jürgen Groß wrote: On 24.01.24 17:54, Jason Andryuk wrote: + + return new; +

[PATCH 0/2] x86: Two fixes related to Xen PV guest mode

2024-04-05 Thread Juergen Gross
These are 2 fixes for issues introduced by topology related changes added in the 6.9 merge window. Juergen Gross (2): x86/cpu: fix BSP detection when running as Xen PV guest x86/xen: return a sane initial apic id when running as PV guest arch/x86/kernel/cpu/topology.c | 2 +- arch/x86/xen

[PATCH 2/2] x86/xen: return a sane initial apic id when running as PV guest

2024-04-05 Thread Juergen Gross
the warnings by synthesizing the CPUID data to contain the same initial APIC ID as xen_pv_smp_config() is using for registering the APIC IDs of all CPUs. Fixes: 52128a7a21f7 ("86/cpu/topology: Make the APIC mismatch warnings complete") Signed-off-by: Juergen Gross --- arch/x86/xen/enlighten

Re: [PATCH v6 1/8] xen/spinlock: add explicit non-recursive locking functions

2024-04-04 Thread Juergen Gross
On 27.03.24 16:22, Juergen Gross wrote: In order to prepare a type-safe recursive spinlock structure, add explicitly non-recursive locking functions to be used for non-recursive locking of spinlocks, which are used recursively, too. Signed-off-by: Juergen Gross Acked-by: Jan Beulich Could

[PATCH] xen/include: move definition of ASM_INT() to xen/linkage.h

2024-04-03 Thread Juergen Gross
sources via tools/binfile to include the new home of ASM_INT(). Signed-off-by: Juergen Gross --- xen/arch/arm/include/asm/asm_defns.h | 3 --- xen/arch/x86/include/asm/asm_defns.h | 3 --- xen/include/xen/linkage.h| 2 ++ xen/tools/binfile| 2 +- 4 files changed, 3

Re: [PATCH v7 02/19] xen/riscv: disable unnecessary configs

2024-04-03 Thread Juergen Gross
On 03.04.24 13:47, Jan Beulich wrote: On 03.04.2024 13:18, Juergen Gross wrote: On 03.04.24 12:54, Oleksii wrote: On Wed, 2024-04-03 at 12:28 +0200, Jan Beulich wrote: On 03.04.2024 12:19, Oleksii Kurochko wrote: This patch disables unnecessary configs for two cases: 1. By utilizing

Re: [PATCH v7 02/19] xen/riscv: disable unnecessary configs

2024-04-03 Thread Juergen Gross
On 03.04.24 12:54, Oleksii wrote: On Wed, 2024-04-03 at 12:28 +0200, Jan Beulich wrote: On 03.04.2024 12:19, Oleksii Kurochko wrote: This patch disables unnecessary configs for two cases: 1. By utilizing EXTRA_FIXED_RANDCONFIG for randconfig builds (GitLab CI jobs). 2. By using

[PATCH v6 8/8] xen: allow up to 16383 cpus

2024-03-27 Thread Juergen Gross
2 * CONFIG_NR_CPUS. Signed-off-by: Juergen Gross --- V5: - new patch (Jan Beulich) --- xen/arch/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/Kconfig b/xen/arch/Kconfig index 67ba38f32f..308ce129a8 100644 --- a/xen/arch/Kconfig +++ b/xen/arch/Kconfig @@ -6,7

[PATCH v6 6/8] xen/spinlock: support higher number of cpus

2024-03-27 Thread Juergen Gross
. There are machines available with more cpus than the current Xen limit, so it makes sense to have the possibility to use more cpus. Signed-off-by: Juergen Gross --- V5: - keep previous recursion limit (Julien Grall) V6: - use unsigned int instead of uint32_t (Jan Beulich) --- xen/common/spinlock.c | 2

[PATCH v6 7/8] xen/rwlock: raise the number of possible cpus

2024-03-27 Thread Juergen Gross
. While at it calculate _QW_CPUMASK and _QR_SHIFT from _QW_SHIFT and add a sanity check for not overflowing the atomic_t data type. Signed-off-by: Juergen Gross --- V5: - new patch V6: - add comment to _can_read_lock() (Jan Beulich) --- xen/include/xen/rwlock.h | 23 +++ 1

[PATCH v6 4/8] xen/spinlock: split recursive spinlocks from normal ones

2024-03-27 Thread Juergen Gross
for recursive spinlocks only, and switch recursive spinlock functions to require pointers to this new struct. This allows to check the correct usage at build time. Signed-off-by: Juergen Gross Reviewed-by: Jan Beulich --- V2: - use shorter names (Jan Beulich) - don't embed spinlock_t

[PATCH v6 2/8] xen/spinlock: add another function level

2024-03-27 Thread Juergen Gross
Add another function level in spinlock.c hiding the spinlock_t layout from the low level locking code. This is done in preparation of introducing rspinlock_t for recursive locks without having to duplicate all of the locking code. Signed-off-by: Juergen Gross Reviewed-by: Jan Beulich --- V2

[PATCH v6 5/8] xen/spinlock: let all is_locked and trylock variants return bool

2024-03-27 Thread Juergen Gross
Switch the remaining trylock and is_locked variants to return bool. Signed-off-by: Juergen Gross Reviewed-by: Jan Beulich --- V5: - new patch (Jan Beulich) --- xen/common/spinlock.c | 4 ++-- xen/include/xen/spinlock.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH v6 0/8] xen/spinlock: make recursive spinlocks a dedicated type

2024-03-27 Thread Juergen Gross
issue in patch 1 Changes in V5: - new patches 1 + 10 + 12 + 13 - due to the recent Ghost-race patches the macro layer for calling spinlock functions is kept - addressed comments Changes in V6: - patches 1-5 of V5 have been committed already - addressed comments Juergen Gross (8): xen/spinlock

[PATCH v6 3/8] xen/spinlock: add missing rspin_is_locked() and rspin_barrier()

2024-03-27 Thread Juergen Gross
Add rspin_is_locked() and rspin_barrier() in order to prepare differing spinlock_t and rspinlock_t types. Signed-off-by: Juergen Gross --- V2: - partially carved out from V1 patch, partially new V5: - let rspin_is_locked() return bool (Jan Beulich) V6: - Re-add comment to _spin_is_locked() (Jan

[PATCH v6 1/8] xen/spinlock: add explicit non-recursive locking functions

2024-03-27 Thread Juergen Gross
In order to prepare a type-safe recursive spinlock structure, add explicitly non-recursive locking functions to be used for non-recursive locking of spinlocks, which are used recursively, too. Signed-off-by: Juergen Gross Acked-by: Jan Beulich --- V2: - rename functions (Jan Beulich) - get rid

[GIT PULL] xen: branch for v6.9-rc1

2024-03-19 Thread Juergen Gross
+++- drivers/xen/evtchn.c | 6 drivers/xen/grant-dma-iommu.c | 6 ++-- 10 files changed, 143 insertions(+), 59 deletions(-) Juergen Gross (2): xen/evtchn: avoid WARN() when unbinding an event channel xen/events: increment refcnt only if event channel

Re: [OSSTEST PATCH v2 3/3] ap-common: Switch to Linux 6.1 by default on x86 + drop dom0 i386

2024-03-15 Thread Juergen Gross
x-linus" or "linux-6.1" branches. Signed-off-by: Anthony PERARD Acked-by: Juergen Gross ... knowing this is kind of meaningless given that I'm no maintainer of OSStest, but I'd like to document that I'm fine with the intention of the change. :-) Juergen Op

[PATCH v5 10/13] xen/spinlock: let all is_locked and trylock variants return bool

2024-03-14 Thread Juergen Gross
Switch the remaining trylock and is_locked variants to return bool. Signed-off-by: Juergen Gross --- V5: - new patch (Jan Beulich) --- xen/common/spinlock.c | 4 ++-- xen/include/xen/spinlock.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/xen/common/spinlock.c b

[PATCH v5 12/13] xen/rwlock: raise the number of possible cpus

2024-03-14 Thread Juergen Gross
. While at it calculate _QW_CPUMASK and _QR_SHIFT from _QW_SHIFT and add a sanity check for not overflowing the atomic_t data type. Signed-off-by: Juergen Gross --- V5: - new patch --- xen/include/xen/rwlock.h | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git

[PATCH v5 09/13] xen/spinlock: split recursive spinlocks from normal ones

2024-03-14 Thread Juergen Gross
for recursive spinlocks only, and switch recursive spinlock functions to require pointers to this new struct. This allows to check the correct usage at build time. Signed-off-by: Juergen Gross --- V2: - use shorter names (Jan Beulich) - don't embed spinlock_t in rspinlock_t (Jan Beulich) V5

[PATCH v5 13/13] xen: allow up to 16383 cpus

2024-03-14 Thread Juergen Gross
2 * CONFIG_NR_CPUS. Signed-off-by: Juergen Gross --- V5: - new patch (Jan Beulich) --- xen/arch/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/Kconfig b/xen/arch/Kconfig index 67ba38f32f..308ce129a8 100644 --- a/xen/arch/Kconfig +++ b/xen/arch/Kconfig @@ -6,7

[PATCH v5 11/13] xen/spinlock: support higher number of cpus

2024-03-14 Thread Juergen Gross
. There are machines available with more cpus than the current Xen limit, so it makes sense to have the possibility to use more cpus. Signed-off-by: Juergen Gross --- V5: - keep previous recursion limit (Julien Grall) --- xen/common/spinlock.c | 2 ++ xen/include/xen/spinlock.h | 20 ++-- 2

[PATCH v5 08/13] xen/spinlock: add missing rspin_is_locked() and rspin_barrier()

2024-03-14 Thread Juergen Gross
Add rspin_is_locked() and rspin_barrier() in order to prepare differing spinlock_t and rspinlock_t types. Signed-off-by: Juergen Gross --- V2: - partially carved out from V1 patch, partially new V5: - let rspin_is_locked() return bool (Jan Beulich) --- xen/arch/x86/mm/p2m-pod.c | 2 +- xen

[PATCH v5 06/13] xen/spinlock: add explicit non-recursive locking functions

2024-03-14 Thread Juergen Gross
In order to prepare a type-safe recursive spinlock structure, add explicitly non-recursive locking functions to be used for non-recursive locking of spinlocks, which are used recursively, too. Signed-off-by: Juergen Gross Acked-by: Jan Beulich --- V2: - rename functions (Jan Beulich) - get rid

[PATCH v5 07/13] xen/spinlock: add another function level

2024-03-14 Thread Juergen Gross
Add another function level in spinlock.c hiding the spinlock_t layout from the low level locking code. This is done in preparation of introducing rspinlock_t for recursive locks without having to duplicate all of the locking code. Signed-off-by: Juergen Gross --- V2: - new patch V5: - don't

[PATCH v5 04/13] xen/spinlock: add rspin_[un]lock_irq[save|restore]()

2024-03-14 Thread Juergen Gross
Instead of special casing rspin_lock_irqsave() and rspin_unlock_irqrestore() for the console lock, add those functions to spinlock handling and use them where needed. Signed-off-by: Juergen Gross --- V2: - new patch V5: - avoid MISRA violation (Julien Grall) - keep wrapper functions (Jan Beulich

[PATCH v5 05/13] xen/spinlock: make struct lock_profile rspinlock_t aware

2024-03-14 Thread Juergen Gross
the slow path with slightly less performant code. Note that this requires a cast when printing the value in order to be format compliant. Signed-off-by: Juergen Gross Acked-by: Alejandro Vallejo Acked-by: Julien Grall --- V2: - new patch V5: - use bool for is_rlock (Julien Grall) - use unsigned

[PATCH v5 03/13] xen/spinlock: rename recursive lock functions

2024-03-14 Thread Juergen Gross
Rename the recursive spin_lock() functions by replacing the trailing "_recursive" with a leading "r". Switch the parameter to be a pointer to rspinlock_t. Suggested-by: Jan Beulich Signed-off-by: Juergen Gross Acked-by: Julien Grall Acked-by: Jan Beulich --- V2: -

[PATCH v5 00/13] xen/spinlock: make recursive spinlocks a dedicated type

2024-03-14 Thread Juergen Gross
issue in patch 1 Changes in V5: - new patches 1 + 10 + 12 + 13 - due to the recent Ghost-race patches the macro layer for calling spinlock functions is kept - addressed comments Juergen Gross (13): xen/spinlock: remove misra rule 21.1 violations xen/spinlock: introduce new type for recursive

[PATCH v5 02/13] xen/spinlock: introduce new type for recursive spinlocks

2024-03-14 Thread Juergen Gross
rs and use them where appropriate. Signed-off-by: Juergen Gross Acked-by: Julien Grall --- V2: - carved out from V1 patch V5: - avoid MISRA violation (Julien Grall) --- xen/arch/x86/include/asm/mm.h | 2 +- xen/arch/x86/mm/mm-locks.h| 2 +- xen/common/domain.c | 4 ++-- xen/comm

[PATCH v5 01/13] xen/spinlock: remove misra rule 21.1 violations

2024-03-14 Thread Juergen Gross
In xen spinlock code there are several violations of MISRA rule 21.1 (identifiers starting with "__" or "_[A-Z]"). Fix them by using trailing underscores instead. Signed-off-by: Juergen Gross --- V5: - new patch (Julien Grall) --- xen/include/xen/spinlock.h | 28 +++

Re: [PATCH RFC] x86/xen: attempt to inflate the memory balloon on PVH

2024-03-13 Thread Juergen Gross
in EXTRA_MEM_RATIO to RAM, while reserving them using xen_add_extra_mem() (which is also moved so it's no longer tied to CONFIG_PV). Signed-off-by: Roger Pau Monné Reviewed-by: Juergen Gross Juergen OpenPGP_0xB0DE9DD628BF132F.asc Description: OpenPGP public key OpenPGP_signature.asc

[PATCH 1/2] xen/evtchn: avoid WARN() when unbinding an event channel

2024-03-13 Thread Juergen Gross
er. Fixes: 9e90e58c11b7 ("xen: evtchn: Allow shared registration of IRQ handers") Reported-by: Demi Marie Obenour Tested-by: Demi Marie Obenour Signed-off-by: Juergen Gross --- drivers/xen/evtchn.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/xen/evtchn.c b/driver

[PATCH 2/2] xen/events: increment refcnt only if event channel is refcounted

2024-03-13 Thread Juergen Gross
: 9e90e58c11b7 ("xen: evtchn: Allow shared registration of IRQ handers") Signed-off-by: Juergen Gross --- drivers/xen/events/events_base.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/drivers/xen/events/events_base.c b/drivers/xen/events/eve

[PATCH 0/2] xen: two fixes related to event channels

2024-03-13 Thread Juergen Gross
Two patches fixing one seen problem and another potential one. Both have been introduced in the 6.7 kernel. Juergen Gross (2): xen/evtchn: avoid WARN() when unbinding an event channel xen/events: increment refcnt only if event channel is refcounted drivers/xen/events/events_base.c | 22

Re: [PATCH 3/3] x86/PVH: Support relocatable dom0 kernels

2024-03-08 Thread Juergen Gross
On 07.03.24 18:01, Jason Andryuk wrote: On 2024-03-07 04:30, Roger Pau Monné wrote: On Wed, Mar 06, 2024 at 01:50:32PM -0500, Jason Andryuk wrote: Xen tries to load a PVH dom0 kernel at the fixed guest physical address from the elf headers.  For Linux, this defaults to 0x100 (16MB), but it

Re: [PATCH v2] tools/9pfsd: Fix build error caused by strerror_r()

2024-03-07 Thread Juergen Gross
On 07.03.24 11:38, Henry Wang wrote: Below error can be seen when doing Yocto build of the toolstack: | io.c: In function 'p9_error': | io.c:684:5: error: ignoring return value of 'strerror_r' declared with attribute 'warn_unused_result' [-Werror=unused-result] | 684 | strerror_r(err,

Re: [PATCH v2] tools/9pfsd: Fix build error caused by strerror_r()

2024-03-07 Thread Juergen Gross
On 07.03.24 11:38, Henry Wang wrote: Below error can be seen when doing Yocto build of the toolstack: | io.c: In function 'p9_error': | io.c:684:5: error: ignoring return value of 'strerror_r' declared with attribute 'warn_unused_result' [-Werror=unused-result] | 684 | strerror_r(err,

[PATCH] SUPPORT.md: add xen-9pfsd

2024-03-06 Thread Juergen Gross
Add a support statement for the new xen-9pfsd backend. Set it to "Experimental", as some functionality for Linux guests is missing (only tested to work with Xenstore-stubdom). Signed-off-by: Juergen Gross --- SUPPORT.md | 1 + 1 file changed, 1 insertion(+) diff --git a/SUPPORT.md b/

[PATCH] CHANGELOG: add an entry for 9pfsd

2024-03-06 Thread Juergen Gross
Add an entry to CHANGELOG.md regarding the new xen-9pfsd daemon. Signed-off-by: Juergen Gross --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index f9874f9bb0..93fda73c00 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -18,6 +18,8 @@ The format

[PATCH] MAINTAINERS: add an entry for tools/9pfsd

2024-03-06 Thread Juergen Gross
Add me as the maintainer for the tools/9pfsd directory. Signed-off-by: Juergen Gross --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 076cf1e141..28fb35582b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -206,6 +206,12 @@ Maintainers List

Re: [PATCH v4 10/12] xen/spinlock: split recursive spinlocks from normal ones

2024-03-01 Thread Juergen Gross
On 29.02.24 16:32, Jan Beulich wrote: On 12.12.2023 10:47, Juergen Gross wrote: +#define nrspin_lock_irqsave(l, f) \ +({ \ +BUILD_BUG_ON(sizeof(f) != sizeof(unsigned long)); \ +((f

Re: [PATCH v4 12/12] xen/spinlock: support higher number of cpus

2024-02-29 Thread Juergen Gross
On 29.02.24 17:31, Jan Beulich wrote: On 29.02.2024 17:29, Jürgen Groß wrote: On 29.02.24 16:46, Jan Beulich wrote: On 12.12.2023 10:47, Juergen Gross wrote: Allow 16 bits per cpu number, which is the limit imposed by spinlock_tickets_t. This will allow up to 65535 cpus, while increasing

Re: [PATCH v4 07/12] xen/spinlock: add explicit non-recursive locking functions

2024-02-29 Thread Juergen Gross
On 29.02.24 14:49, Jan Beulich wrote: On 12.12.2023 10:47, Juergen Gross wrote: In order to prepare a type-safe recursive spinlock structure, add explicitly non-recursive locking functions to be used for non-recursive locking of spinlocks, which are used recursively, too. Signed-off

[PATCH v9 6/6] tools/xenstored: have a single do_control_memreport()

2024-02-29 Thread Juergen Gross
With 9pfs now available in Xenstore-stubdom, there is no reason to have distinct do_control_memreport() variants for the daemon and the stubdom implementations. Signed-off-by: Juergen Gross Reviewed-by: Jason Andryuk --- tools/xenstored/control.c | 27 +++ 1 file

[PATCH v9 4/6] tools/xenstored: add helpers for filename handling

2024-02-29 Thread Juergen Gross
() (used e.g. for saving the state file in case of live update - needs to be unchanged in the daemon case, but should result in /var/lib/xen/xenstore for stubdom) Signed-off-by: Juergen Gross Reviewed-by: Jason Andryuk Reviewed-by: Julien Grall --- V3: - make absolute_filename() return a pointer

[PATCH v9 5/6] tools/xenstored: support complete log capabilities in stubdom

2024-02-29 Thread Juergen Gross
With 9pfs being fully available in Xenstore-stubdom now, there is no reason to not fully support all logging capabilities in stubdom. Open the logfile on stubdom only after the 9pfs file system has been mounted. Signed-off-by: Juergen Gross Reviewed-by: Jason Andryuk Reviewed-by: Julien Grall

[PATCH v9 2/6] stubdom: extend xenstore stubdom configs

2024-02-29 Thread Juergen Gross
Extend the config files of the Xenstore stubdoms to include XENBUS and 9PFRONT items in order to support file based logging. Signed-off-by: Juergen Gross Reviewed-by: Jason Andryuk --- stubdom/xenstore-minios.cfg| 2 +- stubdom/xenstorepvh-minios.cfg | 2 +- 2 files changed, 2 insertions

[PATCH v9 0/6] tools: enable xenstore-stubdom to use 9pfs

2024-02-29 Thread Juergen Gross
- xenlogd->xen-9pfsd rename - addressed review comments - fixed some bugs Juergen Gross (6): config: update Mini-OS commit stubdom: extend xenstore stubdom configs tools/xenstored: mount 9pfs device in stubdom tools/xenstored: add helpers for filename handling tools/xenstored: support compl

[PATCH v9 3/6] tools/xenstored: mount 9pfs device in stubdom

2024-02-29 Thread Juergen Gross
Mount the 9pfs device in stubdom enabling it to use files. This has to happen in a worker thread in order to allow the main thread handling the required Xenstore accesses in parallel. Signed-off-by: Juergen Gross Reviewed-by: Jason Andryuk Reviewed-by: Julien Grall --- V3: - add logging

[PATCH v9 1/6] config: update Mini-OS commit

2024-02-29 Thread Juergen Gross
Update the Mini-OS upstream revision. Signed-off-by: Juergen Gross --- V9: - new patch --- Config.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Config.mk b/Config.mk index 6f6e0425ba..a962f095ca 100644 --- a/Config.mk +++ b/Config.mk @@ -224,7 +224,7

[PATCH] Mini-OS: add symbol exports for xenstore stubdom

2024-02-26 Thread Juergen Gross
Xenstore stubdom needs some more symbols exported. Signed-off-by: Juergen Gross --- xenbus.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xenbus.c b/xenbus.c index eb9af055..686428a4 100644 --- a/xenbus.c +++ b/xenbus.c @@ -45,6 +45,7 @@ #endif struct xenstore_domain_interface

Re: [PATCH v8 3/8] stubdom: extend xenstore stubdom configs

2024-02-22 Thread Juergen Gross
On 16.02.24 17:31, Juergen Gross wrote: Extend the config files of the Xenstore stubdoms to include XENBUS and 9PFRONT items in order to support file based logging. Signed-off-by: Juergen Gross Reviewed-by: Jason Andryuk Samuel, are you fine with this patch? Juergen --- stubdom

Re: Stats on Xen tarball downloads

2024-02-22 Thread Juergen Gross
On 22.02.24 10:49, Roger Pau Monné wrote: On Wed, Feb 21, 2024 at 10:53:49PM +, Julien Grall wrote: Hi George, On 21/02/2024 02:55, George Dunlap wrote: On Mon, Feb 19, 2024 at 6:38 PM Jan Beulich wrote: On 19.02.2024 11:31, Roger Pau Monné wrote: On Mon, Feb 19, 2024 at 06:01:54PM

Re: [linux-linus test] 184722: regressions - FAIL

2024-02-22 Thread Juergen Gross
On 22.02.24 09:21, osstest service owner wrote: flight 184722 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/184722/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-pvops 6 kernel-build

[PATCH] tools/9pfsd: add missing va_end() in fill_data()

2024-02-19 Thread Juergen Gross
In xen-9pfsd fill_data() va_end() needs to be called before returning. Coverity Id CID 1592145 Fixes: bcec59cf7ff4 ("tools/xen-9pfsd: add 9pfs version request support") Signed-off-by: Juergen Gross --- tools/9pfsd/io.c | 29 - 1 file changed, 16 inserti

[PATCH v8 8/8] tools/xenstored: have a single do_control_memreport()

2024-02-16 Thread Juergen Gross
With 9pfs now available in Xenstore-stubdom, there is no reason to have distinct do_control_memreport() variants for the daemon and the stubdom implementations. Signed-off-by: Juergen Gross Reviewed-by: Jason Andryuk --- tools/xenstored/control.c | 27 +++ 1 file

[PATCH v8 5/8] tools/xenstored: mount 9pfs device in stubdom

2024-02-16 Thread Juergen Gross
Mount the 9pfs device in stubdom enabling it to use files. This has to happen in a worker thread in order to allow the main thread handling the required Xenstore accesses in parallel. Signed-off-by: Juergen Gross Reviewed-by: Jason Andryuk Reviewed-by: Julien Grall --- V3: - add logging

[PATCH v8 7/8] tools/xenstored: support complete log capabilities in stubdom

2024-02-16 Thread Juergen Gross
With 9pfs being fully available in Xenstore-stubdom now, there is no reason to not fully support all logging capabilities in stubdom. Open the logfile on stubdom only after the 9pfs file system has been mounted. Signed-off-by: Juergen Gross Reviewed-by: Jason Andryuk Reviewed-by: Julien Grall

[PATCH v8 6/8] tools/xenstored: add helpers for filename handling

2024-02-16 Thread Juergen Gross
() (used e.g. for saving the state file in case of live update - needs to be unchanged in the daemon case, but should result in /var/lib/xen/xenstore for stubdom) Signed-off-by: Juergen Gross Reviewed-by: Jason Andryuk Reviewed-by: Julien Grall --- V3: - make absolute_filename() return a pointer

[PATCH v8 3/8] stubdom: extend xenstore stubdom configs

2024-02-16 Thread Juergen Gross
Extend the config files of the Xenstore stubdoms to include XENBUS and 9PFRONT items in order to support file based logging. Signed-off-by: Juergen Gross Reviewed-by: Jason Andryuk --- stubdom/xenstore-minios.cfg| 2 +- stubdom/xenstorepvh-minios.cfg | 2 +- 2 files changed, 2 insertions

[PATCH v8 4/8] tools: add 9pfs device to xenstore-stubdom

2024-02-16 Thread Juergen Gross
don't limit allowed file space or number of files. Add a new libxl function for adding it similar to the function for adding the console device. Signed-off-by: Juergen Gross Reviewed-by: Jason Andryuk Reviewed-by: Anthony PERARD --- V2: - add security_model parameter to new libxl functi

[PATCH v8 1/8] tools/libs/light: add backend type for 9pfs PV devices

2024-02-16 Thread Juergen Gross
For convenience "auto-delete" is available to let the backend delete the oldest file of the guest in case otherwise "max-space" or "max-files" would be violated. The xen-9pfsd daemon will be started by libxenlight automatically when the first "xen_9pfs" device

[PATCH v8 2/8] tools/xl: support new 9pfs backend xen_9pfsd

2024-02-16 Thread Juergen Gross
he domain name isn't available in the related 9pfs specific function. Settings the defaults in libxl requires to move the sanity checking of 9pfs parameters from xl to libxl, too. Signed-off-by: Juergen Gross Reviewed-by: Jason Andryuk Reviewed-by: Anthony PERARD --- V2: - test max_files and max_open

[PATCH v8 0/8] tools: enable xenstore-stubdom to use 9pfs

2024-02-16 Thread Juergen Gross
was applied - added support of reading directories - addressed review comments Changes in V3: - new patches 1, 23-25 - addressed review comments Changes in V2: - support of multiple rings per device - xenlogd->xen-9pfsd rename - addressed review comments - fixed some bugs Juergen Gross

Re: [PATCH v7 03/21] tools/xen-9pfsd: add transport layer

2024-02-15 Thread Juergen Gross
On 15.02.24 14:04, Juergen Gross wrote: Add the transport layer of 9pfs. This is basically the infrastructure to receive requests from the frontend and to send the related answers via the rings. Signed-off-by: Juergen Gross Reviewed-by: Jason Andryuk Acked-by: Anthony PERARD Seems CI

[GIT PULL] xen: branch for v6.8-rc5

2024-02-15 Thread Juergen Gross
Linus, Please git pull the following tag: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-6.8a-rc5-tag xen: branch for v6.8-rc5 It contains the following fixes and simple cleanups: - A fix using a proper flexible array instead of a one-element array in order to avoid

[PATCH v7 18/21] tools/xenstored: mount 9pfs device in stubdom

2024-02-15 Thread Juergen Gross
Mount the 9pfs device in stubdom enabling it to use files. This has to happen in a worker thread in order to allow the main thread handling the required Xenstore accesses in parallel. Signed-off-by: Juergen Gross Reviewed-by: Jason Andryuk Reviewed-by: Julien Grall --- V3: - add logging

[PATCH v7 13/21] tools/xen-9pfsd: add 9pfs read request support

2024-02-15 Thread Juergen Gross
Add the read request of the 9pfs protocol. Signed-off-by: Juergen Gross Reviewed-by: Jason Andryuk Acked-by: Anthony PERARD --- V2: - make error check more readable (Jason Andryuk) V4: - add directory read support V5: - rewinddir() if reading a directory and offset is 0 (Jason Andryuk

[PATCH v7 10/21] tools/xen-9pfsd: add 9pfs create request support

2024-02-15 Thread Juergen Gross
Add the create request of the 9pfs protocol. Signed-off-by: Juergen Gross Acked-by: Anthony PERARD Reviewed-by: Jason Andryuk --- V2: - set permissions correctly (Jason Andryuk) V3: - use opendirat() etc. (Jason Andryuk) - rework error handling a little bit --- tools/9pfsd/io.c | 151

[PATCH v7 15/21] tools/xl: support new 9pfs backend xen_9pfsd

2024-02-15 Thread Juergen Gross
he domain name isn't available in the related 9pfs specific function. Settings the defaults in libxl requires to move the sanity checking of 9pfs parameters from xl to libxl, too. Signed-off-by: Juergen Gross Reviewed-by: Jason Andryuk Reviewed-by: Anthony PERARD --- V2: - test max_files and max_open

[PATCH v7 21/21] tools/xenstored: have a single do_control_memreport()

2024-02-15 Thread Juergen Gross
With 9pfs now available in Xenstore-stubdom, there is no reason to have distinct do_control_memreport() variants for the daemon and the stubdom implementations. Signed-off-by: Juergen Gross Reviewed-by: Jason Andryuk --- tools/xenstored/control.c | 27 +++ 1 file

[PATCH v7 11/21] tools/xen-9pfsd: add 9pfs stat request support

2024-02-15 Thread Juergen Gross
Add the stat request of the 9pfs protocol. Signed-off-by: Juergen Gross Acked-by: Anthony PERARD Reviewed-by: Jason Andryuk --- V3: - use fstatat() (Jason Andryuk) V4: - add "s" format to fill_buffer() as a preparation for reading dirs --- tools/9pfsd/

[PATCH v7 12/21] tools/xen-9pfsd: add 9pfs write request support

2024-02-15 Thread Juergen Gross
Add the write request of the 9pfs protocol. Signed-off-by: Juergen Gross Reviewed-by: Jason Andryuk Acked-by: Anthony PERARD --- tools/9pfsd/io.c | 54 1 file changed, 54 insertions(+) diff --git a/tools/9pfsd/io.c b/tools/9pfsd/io.c index

[PATCH v7 19/21] tools/xenstored: add helpers for filename handling

2024-02-15 Thread Juergen Gross
() (used e.g. for saving the state file in case of live update - needs to be unchanged in the daemon case, but should result in /var/lib/xen/xenstore for stubdom) Signed-off-by: Juergen Gross Reviewed-by: Jason Andryuk Reviewed-by: Julien Grall --- V3: - make absolute_filename() return a pointer

[PATCH v7 17/21] tools: add 9pfs device to xenstore-stubdom

2024-02-15 Thread Juergen Gross
don't limit allowed file space or number of files. Add a new libxl function for adding it similar to the function for adding the console device. Signed-off-by: Juergen Gross --- V2: - add security_model parameter to new libxl function (Jason Andryuk) V4: - rename function to libxl_device_9pfs_add()

[PATCH v7 16/21] stubdom: extend xenstore stubdom configs

2024-02-15 Thread Juergen Gross
Extend the config files of the Xenstore stubdoms to include XENBUS and 9PFRONT items in order to support file based logging. Signed-off-by: Juergen Gross Reviewed-by: Jason Andryuk --- stubdom/xenstore-minios.cfg| 2 +- stubdom/xenstorepvh-minios.cfg | 2 +- 2 files changed, 2 insertions

[PATCH v7 20/21] tools/xenstored: support complete log capabilities in stubdom

2024-02-15 Thread Juergen Gross
With 9pfs being fully available in Xenstore-stubdom now, there is no reason to not fully support all logging capabilities in stubdom. Open the logfile on stubdom only after the 9pfs file system has been mounted. Signed-off-by: Juergen Gross Reviewed-by: Jason Andryuk Reviewed-by: Julien Grall

[PATCH v7 14/21] tools/libs/light: add backend type for 9pfs PV devices

2024-02-15 Thread Juergen Gross
For convenience "auto-delete" is available to let the backend delete the oldest file of the guest in case otherwise "max-space" or "max-files" would be violated. The xen-9pfsd daemon will be started by libxenlight automatically when the first "xen_9pfs" device

[PATCH v7 09/21] tools/xen-9pfsd: add 9pfs clunk request support

2024-02-15 Thread Juergen Gross
Add the clunk request of the 9pfs protocol. Signed-off-by: Juergen Gross Acked-by: Anthony PERARD Reviewed-by: Jason Andryuk --- V3: - use unlinkat() (Jason Andryuk) --- tools/9pfsd/io.c | 43 +++ 1 file changed, 43 insertions(+) diff --git a/tools

  1   2   3   4   5   6   7   8   9   10   >