Fri, 26 Apr 2024 15:32:31 +0100 George Dunlap :
> Simple remove xentrace_format, and point people to xenalyze instead.
Acked-by: Olaf Hering
Olaf
pgpysdnaunS_g.pgp
Description: Digitale Signatur von OpenPGP
Fri, 23 Feb 2024 15:22:38 -0800 (PST) Stefano Stabellini
:
> Do you have a successful gitlab pipeline with this patch applied that
> you can give me as proof of testing and success?
Yes, all of them since the patch went out.
Olaf
pgpzXM2EomBWs.pgp
Description: Digitale Signatur von OpenPGP
https://build.opensuse.org/request/show/1126240
Signed-off-by: Olaf Hering
---
automation/build/suse/opensuse-tumbleweed.dockerfile | 2 --
1 file changed, 2 deletions(-)
diff --git a/automation/build/suse/opensuse-tumbleweed.dockerfile
b/automation/build/suse/opensuse-tumbleweed.dockerfile
Fri, 24 Nov 2023 13:47:53 +0100 Juergen Gross :
> As Olaf has said already: this wouldn't cover actions e.g. by libvirt.
Jim pointed me to /etc/libvirt/libxl.conf. So from this perspective both
xl and libvirt is covered. Now it just takes someone to implement it.
Olaf
pgpHB9JoF7AJr.pgp
Wed, 22 Nov 2023 20:46:15 + Andrew Cooper :
> But that entirely depends on whether you think anyone is using it or not.
We never got any bugreport, nor have we any indication for actual usage.
The script was in the sources. Python3 is supposed to be the default
interpreter since a number of
Wed, 22 Nov 2023 20:30:59 + Andrew Cooper :
> Does this mean there are SLES/OpenSUSE users of xenpvboot ?
We do not know. It is gone by now, in 4.18:
https://build.opensuse.org/request/show/1126897
Olaf
pgp4eQYvj2jrR.pgp
Description: Digitale Signatur von OpenPGP
Wed, 15 Nov 2023 12:16:32 + Julien Grall :
> +++ b/SUPPORT.md
...
> Release Notes
> : href="https://wiki.xenproject.org/wiki/Xen_Project_X.YY_Release_Notes;>RN
This X.YY needs to be adjusted as well. Hopefully this detail is mentioned in
the release-process.txt.
Olaf
Thu, 16 Nov 2023 09:21:06 + Luca Fancellu :
> I see your patch is handling this issue but maybe was not meant to be
> upstreamed,
> so I would like to ask if you are willing to make it upstream-able or if it’s
> not planned
> to do so.
Right now I do not have the time to work on this.
Thu, 16 Nov 2023 08:45:43 +0100 Jan Beulich :
> Did you ever submit it?
Likely not.
I think the approach to use a xenstore entry was used to avoid
ABI incompatibilities due to changed .idl files.
In case anyone really wants up upstream such change, a global
per-device timeout should not go
Wed, 15 Nov 2023 15:29:09 + Divin Raj :
> LIBXL_HOTPLUG_TIMEOUT
This is already solved by "libxl.LIBXL_HOTPLUG_TIMEOUT.patch" from
https://build.opensuse.org/package/show/openSUSE:Factory/xen
Up to now it was not considered important enough for xen.git#staging.
Olaf
pgpNn3pRObDgi.pgp
Mon, 6 Nov 2023 08:19:46 + Alejandro Vallejo :
> +struct xen_sysctl sysctl = {0};
What is that zero doing here? I think a plain {} will do it as well.
Olaf
pgpGz9ugvYO7u.pgp
Description: Digitale Signatur von OpenPGP
Some awk binary is used in many places during build,
make sure it is part of the image.
Signed-off-by: Olaf Hering
---
automation/build/suse/opensuse-leap.dockerfile | 1 +
automation/build/suse/opensuse-tumbleweed.dockerfile | 1 +
2 files changed, 2 insertions(+)
diff --git
Fri, 28 Jul 2023 21:35:54 +0100 George Dunlap :
> Everything looks good (including adding the missing strings), except for
> the removal of the fixed array size. Call me paranoid, but if we define it
> as REASON_MAX length, then there will never be any way that a value less
> than REASON_MAX
Fri, 28 Jul 2023 17:47:11 +0100 George Dunlap :
> Just a couple of notes on the whole series. First, you didn't CC me on 0/7
> or 1/7. Secondly, patch 7 seems to be corrupted (see e.g., Patchew's
> attempt to apply the series [1]).
The cover letter can not be easily fixed, this is a bug in git
ice, instead of the expected uhci device.
Here a byte size request is expected, and a value of ~0 is returned. As
a result the UCHI driver sees an error state in the register, and turns
off the UHCI controller.
Signed-off-by: Olaf Hering
---
hw/i386/xen/xen_platform.c | 7 ---
1 file change
Fri, 30 Jun 2023 08:05:29 + Bernhard Beschow :
> Yes. Have a look for piix3/piix4 here:
> https://www.intel.com/design/archives/chipsets/440/index.htm
This is hidden behind a login or whatever.
I should be able to come up with a commit message without hardware specs being
available.
Wed, 28 Jun 2023 09:27:16 + Bernhard Beschow :
> Would you mind sending a patch fixing the BMIBA register to be reset as 32
> bit?
Will do so next week.
Are the specs for this chipset available, does this address really need
to be accessed in quantities of u32, or is perhaps u16 required?
Tue, 27 Jun 2023 10:12:50 + Bernhard Beschow :
> The BAR is a 32 bit register whose default value is 0x0001. I think
> what's supposed to happen here is a pci_set_long() rather than a
> pci_set_byte().
Indeed, the u32 at that address changes from c121 to c101 with the current code.
Tue, 27 Jun 2023 10:12:50 + Bernhard Beschow :
> Bits 4..15 represent the BAR address, and pci_set_byte() only clears bits
> 4..7, leaving bits 8..15 unchanged. Perhaps this causes the BAR to be moved
> into the UHCI region? Does changing the call to pci_set_long() fix the
> problem?
Mon, 26 Jun 2023 23:19:01 +0200 Olaf Hering :
> So far I was unable to decipher how the pci_set_word calls can
> possibly affect the outcome and the owner of memory_region_ops_read.
It is enough to return from piix_ide_reset right after
pci_set_word(pci_conf + PCI_COMMAND, 0) to t
able to decipher how the pci_set_word calls can
possibly affect the outcome and the owner of memory_region_ops_read.
Thanks,
Olaf
Wed, 10 May 2023 00:58:27 +0200 Olaf Hering :
> Resuming this old thread about an unfixed bug, which was introduced in
> qemu-4.2:
>
> qemu ends up in piix
There are just two callers of this function. It is identical to the
checks done in __trace_var.
The commit message of 9a86ac1aa3d2ebe1be05dc7fe78dd6759aa3241d
("xentrace 5/7: Additional tracing for the shadow code.") gives no
indication what the benefit of this function is.
Signed-of
Fri, 16 Jun 2023 17:08:25 +0100 Andrew Cooper :
> XENMEM_acquire_resource is a new mapping interface with far more sane
> semantics which, amongst other things, will work in PVH guests too.
Does that indicate xentrace will not work in a PVH dom0?
I will have a look how XENMEM_acquire_resource
Fri, 16 Jun 2023 15:22:24 +0100 George Dunlap :
> I agree; the clear implication is that with smt=0, you might have
> num_online_cpus() return 4, but cpuids that look like {1, 3, 5, 7}; so you
> need the trace buffer array to be of size 8.
I have tested the patch below with this cmdline:
Fri, 16 Jun 2023 15:22:24 +0100 George Dunlap :
> I agree; the clear implication is that with smt=0, you might have
> num_online_cpus() return 4, but cpuids that look like {1, 3, 5, 7}; so you
> need the trace buffer array to be of size 8.
I see. Apparently some remapping is required to map a
The single caller of next_record already checked for
tb_init_done. The functions are called with t_lock
held. The call stack look like this:
__trace_var
tb_init_done?
insert_wrap_record
insert_lost_records
__insert_record
next_record
tb_init_done?
Signed-off-by: Olaf
Wed, 31 May 2023 11:05:52 +0200 Jan Beulich :
> As said before, num_online_cpus() will under-report for the purpose
> here, as CPUs may have been brought offline, and may be brought online
> again later (independent of the use of "maxcpus=").
It turned out, commit
Fri, 16 Jun 2023 12:07:20 +0200 Jan Beulich :
> ... you're removing the line that's actually verifying this is the case.
Yeah, because it disappeared. I think the other approach is to teach
the python tool about __attribute__(()).
Let me know which way is preferred.
Olaf
pgpghOyGFRHEO.pgp
Wed, 14 Jun 2023 11:49:35 +0200 Jan Beulich :
> However, if you're after adding packed attributes, and if you're
> meaning to only communicate between Xen and the tool stack, then
> the requirement above doesn't exist. Yet then I would also wonder
> whether you need any compat translation in the
Wed, 14 Jun 2023 11:49:35 +0200 Jan Beulich :
> So perhaps we could arrange for your additions to be excluded
> from the compat translation machinery?
Is there maybe a place for headers which are not public,
but which are visible for tools/ and xen/? I think the trace
functionality would be a
I would like to share code between the hypervisor and xenalyze, so that
every definition comes from a single place and is not duplicated in xen
and xenalyze. This works as long as simple constructs like struct x {};
are used. Depending on the data to be stored into the trace buffer, having
support
es
from an installed filesystem.rpm. This works on a SUSE system, and
will likely work on a RedHat based system as well.
Take the opportunity to replace the usage of $RPM_BUILD_ROOT with
%buildroot, and use pushd/popd pairs.
Signed-off-by: Olaf Hering
---
v2: remove bogus pushd/popd pair, use pip
Mon, 12 Jun 2023 13:44:34 +0200 Jan Beulich :
> On 12.06.2023 13:35, Olaf Hering wrote:
> > I will send v2 without these two lines.
> I'd be fine dropping them while committing.
Another cosmetic change in such v2 would be the usage of | instead of @
in the last sed call, for
Mon, 12 Jun 2023 11:40:55 +0100 Anthony PERARD :
> On Tue, May 30, 2023 at 01:18:07PM +0200, Olaf Hering wrote:
> > +pushd %buildroot
> > +popd
> Are these 2 lines left over from testing? They don't appear to do
> anything useful.
I think the intention was to te
Signed-off-by: Olaf Hering
---
tools/xentrace/xenalyze.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/xentrace/xenalyze.c b/tools/xentrace/xenalyze.c
index d2e6c77590..88c3d5f873 100644
--- a/tools/xentrace/xenalyze.c
+++ b/tools/xentrace/xenalyze.c
@@ -467,7
Copy and use more constants from vmx.h, to turn numbers into strings.
Adjust the REASON_MAX value accordingly.
Remove the size constraint from string array, the compiler will grow it
as needed.
Signed-off-by: Olaf Hering
---
tools/xentrace/xenalyze.c | 28
1 file
Signed-off-by: Olaf Hering
---
tools/xentrace/xenalyze.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/xentrace/xenalyze.c b/tools/xentrace/xenalyze.c
index 88c3d5f873..9635ff453a 100644
--- a/tools/xentrace/xenalyze.c
+++ b/tools/xentrace/xenalyze.c
@@ -479,7
The documented option --usage worked because every unknown option
showed the help.
Signed-off-by: Olaf Hering
---
docs/man/xentrace.8.pod | 4
1 file changed, 4 deletions(-)
diff --git a/docs/man/xentrace.8.pod b/docs/man/xentrace.8.pod
index 69aef05f65..4c174a84c0 100644
--- a/docs/man
Signed-off-by: Olaf Hering
---
tools/xentrace/xenalyze.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/xentrace/xenalyze.c b/tools/xentrace/xenalyze.c
index 1cae055ef4..d2e6c77590 100644
--- a/tools/xentrace/xenalyze.c
+++ b/tools/xentrace/xenalyze.c
@@ -466,7
Signed-off-by: Olaf Hering
---
tools/xentrace/xenalyze.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/xentrace/xenalyze.c b/tools/xentrace/xenalyze.c
index a50538e9a8..1cae055ef4 100644
--- a/tools/xentrace/xenalyze.c
+++ b/tools/xentrace/xenalyze.c
@@ -447,7
The input values were always 32bit.
Fixes 55ee5dea32 ("xentrace: add TRC_HVM_EMUL")
Signed-off-by: Olaf Hering
---
tools/xentrace/formats | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/xentrace/formats b/tools/xentrace/formats
index 0fcc327a40..afb5ee0
Olaf Hering (7):
xentrace: remove unimplemented option from man page
xentrace: use correct output format for pit and rtc
xenalyze: sync with vmx.h, use EXIT_REASON_PENDING_VIRT_INTR
xenalyze: sync with vmx.h, use EXIT_REASON_VMXOFF
xenalyze: sync with vmx.h, use EXIT_REASON_VMXON
Thu, 1 Jun 2023 10:17:17 +0200 Jan Beulich :
> Is this any different from the v1 sent on May 26th?
Yeah, this one still has the bogus commit message.
I forgot that this patch was already sent earlier.
Please ignore this one.
Olaf
pgpLWnjH0JCfF.pgp
Description: Digitale Signatur von OpenPGP
These defines are not used by xenalyze.
NR_CPUS will not match what was used for building Xen itself.
Signed-off-by: Olaf Hering
---
tools/xentrace/analyze.h | 13 -
1 file changed, 13 deletions(-)
diff --git a/tools/xentrace/analyze.h b/tools/xentrace/analyze.h
index 6fefa19639
the getopt value for help. The char '?' is returned for unknown
options. Returning 'h' instead of '?' makes it allows to handle --help.
Signed-off-by: Olaf Hering
---
tools/xentrace/xentrace.c | 20
1 file changed, 12 insertions(+), 8 deletions(-)
diff --git a/tools/xentrace
Tue, 30 May 2023 09:46:54 +0200 Olaf Hering :
> Did osstest actually spot any HVM error?
> To me it looks like 180992 shows many failures, but nothing fatal.
I think osstest does not run Xen with xentrace enabled,
so it can not spot the failure I'm seeing.
Olaf
pgpxSe3PNFiwF.pgp
Descr
Tue, 30 May 2023 10:41:07 +0200 Jan Beulich :
> Using this N would be correct afaict, but that N isn't num_online_cpus().
> CPUs may have been offlined by the time trace buffers are initialized, so
> without looking too closely I think it would be num_present_cpus() that
> you're after.
In my
es
from an installed filesystem.rpm.
Take the opportunity to replace the usage of $RPM_BUILD_ROOT with
%buildroot, and use pushd/popd pairs.
Fixes: 438c5ffa4 ("rpmball: Adjust to new rpm, do not require --force")
Signed-off-by: Olaf Hering
---
tools/misc/mkrpm | 33 +++
While looking again through calculate_tbuf_size after a very long time,
I was wondering why the code uses nr_cpu_ids instead of num_online_cpus.
In case Xen was booted with maxcpus=N, would it be safe to use N as
upper limit? I think this would increase the per-cpu buffer size for
each active
For some reason the staging branch fails to create HVM domUs for me.
It seems there was some breakage introduced between 20230522T161155.c7908869
and 20230526T091957.40cd186b. I was hoping that osstest will spot this
failure and do the bisect for me, but apparently there is no report yet.
Did
value for help. The char '?' is returned for unknown
options. Returning 'h' instead of '?' allows to handle --help.
Signed-off-by: Olaf Hering
---
tools/xentrace/xentrace.c | 20
1 file changed, 12 insertions(+), 8 deletions(-)
diff --git a/tools/xentrace/xentrace.c b/tools
Fri, 26 May 2023 11:11:58 +0100 George Dunlap :
> With that change:
> Reviewed-by: George Dunlap
> If that sounds OK to you I'll modify it on check-in.
Yes, sounds good. Thank you.
Olaf
pgpKoa3nTL64Q.pgp
Description: Digitale Signatur von OpenPGP
Signed-off-by: Olaf Hering
---
tools/xentrace/xentrace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/xentrace/xentrace.c b/tools/xentrace/xentrace.c
index a073cab26d..3548255123 100644
--- a/tools/xentrace/xentrace.c
+++ b/tools/xentrace/xentrace.c
@@ -794,7 +794,6
The output file is optional. In case it is missing, xentrace is supposed
to write to stdout - unless it is a tty, which is checked prior using it.
Signed-off-by: Olaf Hering
---
tools/xentrace/xentrace.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/tools/xentrace
Olaf Hering (3):
xentrace: allow xentrace to write to stdout
xentrace: remove return value from monitor_tbufs
xentrace: close output file in the function which opened it
tools/xentrace/xentrace.c | 19 +++
1 file changed, 7 insertions(+), 12 deletions(-)
The function always returns zero.
Signed-off-by: Olaf Hering
---
tools/xentrace/xentrace.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/tools/xentrace/xentrace.c b/tools/xentrace/xentrace.c
index b81abe8a51..a073cab26d 100644
--- a/tools/xentrace/xentrace.c
+++ b
Introduced in commit 6ddfaabceeec3c31bc97a7208c46f581de55f71d
("x86/hvm/ioreq: simplify code and use consistent naming").
Signed-off-by: Olaf Hering
---
xen/arch/x86/hvm/ioreq.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/xen/arch/x86/hvm/ioreq.c b/xen/arch/x86/hvm/ior
Signed-off-by: Olaf Hering
---
xen/include/public/hvm/dm_op.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/include/public/hvm/dm_op.h b/xen/include/public/hvm/dm_op.h
index acdf91693d..fa98551914 100644
--- a/xen/include/public/hvm/dm_op.h
+++ b/xen/include/public/hvm
Hello,
please backport d66ba6dc1cce914673bd8a89fca30a7715ea70d1 to
qemu-xen.git to allow building it with gcc13.
Thanks,
Olaf
pgpN4YcYzn_NI.pgp
Description: Digitale Signatur von OpenPGP
Calling build twice in the same environment will fail because the
directory 'binaries' was already created before. Use mkdir -p to ignore
an existing directory and move on to the actual build.
Signed-off-by: Olaf Hering
---
automation/scripts/build | 2 +-
1 file changed, 1 insertion(+), 1
Am Tue, 16 May 2023 13:38:42 -0400
schrieb John Snow :
> I haven't touched IDE or block code in quite a long while now -- I
> don't think I can help land this fix, but I won't get in anyone's way,
> either. Maybe just re-submit the patches with an improved commit
> message / cover letter that
Am Tue, 16 May 2023 11:46:00 -0700 (PDT)
schrieb Stefano Stabellini :
> I think you have a point that automation/build/README.md should also
> describe how to do what gitlab-ci does but locally (i.e. call
> automation/scripts/build). It should not only describe
> automation/scripts/containerize.
Hello,
as shown in 'build.log' at
https://gitlab.com/xen-project/xen/-/jobs/4284741850/artifacts/browse
there is a logic error spotted by gcc 13.
crypto/rsa.c: In function 'rsa_private':
crypto/rsa.c:56:7: error: the comparison will always evaluate as 'true' for the
address of 'p' will never be
should not be a tty, which disables colors from
meson and interactive questions from kconfig.
Signed-off-by: Olaf Hering
---
automation/build/README.md | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/automation/build/README.md b/automation/build/README.md
index 2d07cafe0e
Am Mon, 15 May 2023 16:03:01 -0700 (PDT)
schrieb Stefano Stabellini :
> Given that opensuse-tumbleweed is still broken (doesn't complete the
> Xen build successfully) even after these patches, I suggest we use a
> different example?
I think the example in automation/build/README.md needs to be
Am Mon, 15 May 2023 16:03:01 -0700 (PDT)
schrieb Stefano Stabellini :
> Given that opensuse-tumbleweed is still broken (doesn't complete the
> Xen build successfully) even after these patches, I suggest we use a
> different example?
For some reason it succeeded for me locally.
Does it fail for
in libxl/Makefile, it is already covered
by UTIL_LIBS from config/StdGNU.mk.
Signed-off-by: Olaf Hering
---
v2: remove consumers of the macros
config/Tools.mk.in | 2 --
m4/ptyfuncs.m4 | 35 -
tools/configure.ac | 2
Tue, 9 May 2023 17:47:33 +0100 Anthony PERARD :
> That change isn't enough. And I'm not convinced that it needs to be
> removed.
You are right, the provided functions must be removed as well.
My build scripts do not run autoreconf, perhaps it is about time to
change that.
> First,
afterwards.
Reported-by: Jason Andryuk
Tested-by: Jason Andryuk
Signed-off-by: Olaf Hering
---
v3: use variables, and quote variables, drop -m0700 from one mkdir call
tools/Makefile | 2 --
tools/hotplug/FreeBSD/rc.d/xencommons.in | 1 +
tools/hotplug
Fri, 12 May 2023 12:22:08 +0100 Andrew Cooper :
> Does this allow for making any of these files no longer
> preprocessed by ./configure ? (i.e. cease being .in files)
The path to hotplugpath.sh is variable, so each consumer needs to be a .in file.
Olaf
pgpSPFRUGSANB.pgp
Description:
Tue, 9 May 2023 13:47:11 +0100 Andrew Cooper :
> Why is this 700, and the others just using regular perms?
> Also, doesn't it want quoting like the other examples too?
It is not clear why there is a single mkdir -m 0700 in the tree.
Most likely it will not give any extra security.
The scripts
Wed, 10 May 2023 00:58:27 +0200 Olaf Hering :
> In my debugging (with v8.0.0) it turned out the three pci_set_word
> causes the domU to hang. In fact, it is just the last one:
>
>pci_set_byte(pci_conf + 0x20, 0x01); /* BMIBA: 20-23h */
>
> It changes the value from 0x
(rev 03)
00:02.0 Unassigned class [ff80]: XenSource, Inc. Xen Platform Device (rev 01)
00:03.0 VGA compatible controller: Cirrus Logic GD 5446
Thanks,
Olaf
On Thu, Mar 25, Paolo Bonzini wrote:
> On 25/03/21 12:12, Olaf Hering wrote:
> > Am Mon, 22 Mar 2021 18:09:17 -0400
> > sc
Tue, 9 May 2023 13:47:11 +0100 Andrew Cooper :
> > +++ b/tools/hotplug/Linux/init.d/xendriverdomain.in
> > @@ -49,6 +49,7 @@ fi
> >
> > do_start () {
> > echo Starting xl devd...
> > + mkdir -m700 -p @XEN_RUN_DIR@
>
> Why is this 700, and the others just using regular perms?
I think
Wed, 26 Apr 2023 09:31:44 -0400 Jason Andryuk :
> On Wed, Apr 26, 2023 at 6:40 AM Olaf Hering wrote:
> > +++ b/tools/hotplug/Linux/init.d/xendriverdomain.in
> > @@ -49,6 +49,7 @@ fi
> >
> > do_start () {
> > echo Starting xl devd...
> > + mkd
populating /var/run/xen during make install.
The directory is already created by some scripts. Adjust all remaining
scripts to create XEN_RUN_DIR at runtime.
XEN_RUN_STORED is covered by XEN_RUN_DIR because xenstored is usually
started afterwards.
Reported-by: Jason Andryuk
Signed-off-by: Olaf Hering
clang complains about the signed type:
implicit truncation from 'int' to a one-bit wide bit-field changes value from 1
to -1 [-Wsingle-bit-bitfield-constant-conversion]
The potential ABI change in libxenvchan is covered by the Xen version based
SONAME.
Signed-off-by: Olaf Hering
---
v2
Mon, 8 May 2023 13:23:27 +0200 Juergen Gross :
> I have found 18 lines using "unsigned int" for bitfields in this file.
There is indeed a mix of both variants in this file.
I scrolled just down to line 6999, only looking for ':1'.
Olaf
pgpdfK1WmN2vQ.pgp
Description: Digitale Signatur von
Mon, 8 May 2023 11:06:11 +0200 Juergen Gross :
> > -int short_summary_done:1, prealloc_unpin:1, wrmap_bf:1;
> > +unsigned short_summary_done:1, prealloc_unpin:1, wrmap_bf:1;
> Please use "unsigned int" instead of a pure "unsigned".
The entire file uses just 'unsigned' for bitfields.
pattern in that file.
Signed-off-by: Olaf Hering
---
tools/include/libxenvchan.h | 6 +++---
tools/xentrace/xenalyze.c | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/tools/include/libxenvchan.h b/tools/include/libxenvchan.h
index 30cc73cf97..3d3b8aa8dd 100644
the conditionals to include the required header.
Remove the bogus m4 file to fix build with clang, which complains about
calls to undeclared functions.
Signed-off-by: Olaf Hering
---
m4/ptyfuncs.m4 | 35 ---
tools/configure.ac | 1 -
2 files changed, 36
Signed-off-by: Olaf Hering
---
automation/build/README.md | 6 ++
1 file changed, 6 insertions(+)
diff --git a/automation/build/README.md b/automation/build/README.md
index 2d07cafe0e..8ad89a259a 100644
--- a/automation/build/README.md
+++ b/automation/build/README.md
@@ -12,6 +12,12 @@ can
The upcoming Leap 15.5 will come without a binary named 'python'.
Prepare the suse images for that change.
Starting with Xen 4.14 python3 can be used for build.
Signed-off-by: Olaf Hering
---
automation/build/suse/opensuse-leap.dockerfile | 2 --
automation/build/suse/opensuse
Tue, 2 May 2023 14:41:25 +0100 Andrew Cooper :
> Does this improve things for you?
./checker: /lib64/libc.so.6: version `GLIBC_2.34' not found (required by
./checker)
make[2]: *** [Makefile:24: check-headers] Error 1
I think as soon as tools/ or stubdom/ is built, more issues like that will
Tue, 2 May 2023 15:44:41 +0200 Jan Beulich :
> How would an out-of-tree build help (which for the hypervisor we now
> have support for)? An incremental build there will hit exactly the same
> issue afaict.
Each container target will use a separate output directory. The Leap container
will only
Tue, 2 May 2023 15:29:19 +0200 Jan Beulich :
> Getting this to work automatically is a continued subject of discussion.
I think the only real solution is an out-of-tree build. Essentially every
single component needs to detect a toolchain change. This is unrealistic.
Olaf
pgpjSDzLmeFs3.pgp
Tue, 2 May 2023 13:33:13 +0200 Olaf Hering :
> I will investigate why it failed to build for me.
This happens if one builds first with the Tumbleweed container, and later with
the Leap container, without a 'git clean -dffx' in between.
Is there a way to invalidate everything if the toolch
Tue, 2 May 2023 09:31:56 +0200 Jan Beulich :
> How does 2.37 vs 2.39 matter? CET-IBT support is present in gas as of 2.29.
I have no idea. It turned out, the previous Leap image was based on 15.3, while
the current one will be 15.4.
If I run this manually, it appears the error is produced
The next push to xen.git#staging will trigger a build failure in the refreshed
Leap docker image.
For some reason HAS_CC_CET_IBT will evaluate to true. I think the significant
change is the binutils upgrade from 2.37 to 2.39 in November 2022.
The comment indicates the combination of gcc7 and
The diffutils package is a hard requirement for building xen.
It was dropped from the Tumbleweed base image in the past 12 months.
Building with --enable-docs does now require the gs tool.
Add both packages to the suse dockerfiles.
Signed-off-by: Olaf Hering
---
automation/build/suse/opensuse
eed #include .
[ 460s] - Implicit *recv* functions need #include .
[ 460s] E: xen implicit-fortify-decl
../../../../newlib-1.16.0/newlib/doc/makedoc.c:1147
Signed-off-by: Olaf Hering
---
Depends on newlib-cygmon-gmon.patch
stubdom/Makefile | 1 +
stubdom/newlib-makedoc.pa
returns random data in a function
E: xen no-return-in-nonvoid-function
../../../../newlib-1.16.0/libgloss/i386/cygmon-gmon.c:362
Signed-off-by: Olaf Hering
---
stubdom/Makefile | 1 +
stubdom/newlib-cygmon-gmon.patch | 60
2 files changed, 61
Wed, 26 Apr 2023 11:07:17 +0200 Jan Beulich :
> On 26.04.2023 10:47, Olaf Hering wrote:
> > XEN_RUN_DIR and most likely also XEN_RUN_STORED have to be removed from
> > make install.
> ... this suggests to me that you really mean the change doesn't go far
> enough, but
Wed, 26 Apr 2023 10:28:38 +0200 Jan Beulich :
> Is this to be translated to Reviewed-by: ?
It was a Nack, in case such thing exists, and if it has any meaning if sent by
me.
There are a few places already which do a mkdir -p XEN_RUN_DIR prior usage.
But a few are missing.
XEN_RUN_DIR and most
Tue, 25 Apr 2023 15:46:20 -0400 Jason Andryuk :
> Skip populating /var/run/xen when systemd is being used.
It was wrong to do it like that from day one.
Such directory has to be populated on demand at runtime.
Olaf
pgpScH1_9_YpA.pgp
Description: Digitale Signatur von OpenPGP
Use a snapshot which includes commit
b0ded89e917b48b73097d3b8b88dfa3afb264ed0 ("[build] Disable dangling
pointer checking for GCC"), which fixes build with gcc12.
Signed-off-by: Olaf Hering
---
tools/firmware/etherboot/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
=1210570
Signed-off-by: Olaf Hering
---
tools/libs/guest/xg_offline_page.c | 16 ++--
1 file changed, 6 insertions(+), 10 deletions(-)
diff --git a/tools/libs/guest/xg_offline_page.c
b/tools/libs/guest/xg_offline_page.c
index ccd0299f0f..8f0a252417 100644
--- a/tools/libs/guest
Fri, 21 Oct 2022 20:53:36 -0700 Denton Liu :
> Thanks for the feedback, it should be an absolute path. I can submit a
> new version of the patch later. However, before I do so, are you still
> a NAK on the general idea?
It is not clear to me how useful it will be in practice.
In the end I have
Tue, 18 Oct 2022 21:53:32 -0700 Denton Liu :
> On Tue, Oct 18, 2022 at 04:18:21PM +0200, Olaf Hering wrote:
> > Maybe the patch description lacks a specific example how the proposed
> > change is supposed to be used in your environment.
> My patch description says:
Tue, 18 Oct 2022 06:57:36 -0700 Denton Liu :
> If I'm understanding correctly, what you're proposing is a mechanism for
> setting the default entry. If I'm not mistaken, this seems like an
> orthogonal discussion to me. My patch proposes a method of setting the
> top-level menu entry while this
1 - 100 of 903 matches
Mail list logo
