oper
>
> Reviewed-by: Jan Beulich
Acked-by: Stefano Stabellini
nstant_p and always_inline to
docs/misra/C-language-toolchain.rst as they don't seem to be currently
documented and they are not part of the C standard
Patch welcome :-)
Reviewed-by: Stefano Stabellini
> ---
> CC: Jan Beulich
> CC: Roger Pau Monné
> CC: Wei Liu
> CC: Stefano Stabe
if generic_f?sl() are
> > used
> > elsewhere in Xen.
> >
> > Signed-off-by: Andrew Cooper
>
> Reviewed-by: Jan Beulich
> with a suggestion and a question.
Acked-by: Stefano Stabellini
> > I suspect we want to swap CONFIG_DEBUG for CONFIG_BOOT_UNIT_TESTS in due
> > course. These ought to be able to be used in a release build too.
>
> +1
+1
On Fri, 24 May 2024, Andrew Cooper wrote:
> This is in order to maintain bisectability through the subsequent changes, as
> the order of definitions is altered.
>
> Signed-off-by: Andrew Cooper
Acked-by: Stefano Stabellini
On Thu, 30 May 2024, Marek Marczykowski-Górecki wrote:
> On Wed, May 29, 2024 at 03:19:43PM +0100, Andrew Cooper wrote:
> > This restriction doesn't provide any security because anyone with suitable
> > permissions on the HW runners can bypass it with this local patch.
> >
> > Requiring branches
On Wed, 29 May 2024, Andrew Cooper wrote:
> Have PPC put serial to stdout like all other tests, so it shows up in the main
> job log.
>
> Signed-off-by: Andrew Cooper
Reviewed-by: Stefano Stabellini
> ---
> CC: Roger Pau Monné
> CC: Stefano Stabellini
> CC: M
On Wed, 29 May 2024, Michal Orzel wrote:
> Hi Andrew,
>
> On 29/05/2024 16:19, Andrew Cooper wrote:
> >
> >
> > ... like the other hardware tests. This gets more value out of the testing.
> >
> > Signed-off-by: Andrew Cooper
> > ---
> > CC:
On Wed, 29 May 2024, Andrew Cooper wrote:
> ... like the other hardware tests. This gets more value out of the testing.
>
> Signed-off-by: Andrew Cooper
Acked-by: Stefano Stabellini
> ---
> CC: Roger Pau Monné
> CC: Stefano Stabellini
> CC: Michal Orzel
> CC: Ma
s. I fixed it on commit:
Acked-by: Stefano Stabellini
> > Signed-off-by: Nicola Vetrini
> > ---
> > automation/eclair_analysis/ECLAIR/deviations.ecl | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/automation/eclair_anal
On Wed, 15 May 2024, Stefano Stabellini wrote:
> On Wed, 15 May 2024, Jan Beulich wrote:
> > On 15.05.2024 01:15, Stefano Stabellini wrote:
> > > Add D4.12 with the same explanation as the rules of the R21 series.
> > > D4.12 refers to the standard library
On Mon, 27 May 2024, Jürgen Groß wrote:
> On 25.05.24 01:19, Stefano Stabellini wrote:
> > On Fri, 24 May 2024, Jürgen Groß wrote:
> > > On 24.05.24 15:58, Julien Grall wrote:
> > > > Hi Henry,
> > > >
> > > > + Juergen as the Xenstore mai
On Fri, 24 May 2024, Jürgen Groß wrote:
> On 24.05.24 15:58, Julien Grall wrote:
> > Hi Henry,
> >
> > + Juergen as the Xenstore maintainers. I'd like his opinion on the approach.
> > The documentation of the new logic is in:
> >
> >
On Fri, 24 May 2024, Julien Grall wrote:
> Hi Stefano,
>
> On 24/05/2024 23:49, Stefano Stabellini wrote:
> > On Fri, 24 May 2024, Julien Grall wrote:
> > > Hi Henry,
> > >
> > > + Juergen as the Xenstore maintainers. I'd like his opinion on the
> >
ec Kwapis
Suggested-by: Daniel P. Smith
Signed-off-by: Henry Wang
Signed-off-by: Stefano Stabellini
---
xen/arch/arm/dom0less-build.c | 55 ++-
1 file changed, 54 insertions(+), 1 deletion(-)
diff --git a/xen/arch/arm/dom0less-build.c b/xen/arch/arm/dom0less-buil
From: Henry Wang
Currently the GUEST_MAGIC_BASE in the init-dom0less application is
hardcoded, which will lead to failures for 1:1 direct-mapped Dom0less
DomUs.
Since the guest magic region allocation from init-dom0less is for
XenStore, and the XenStore page is now allocated from the
Hi all,
This series is trying to fix the reported guest magic region alloc
issue for 11 Dom0less domUs, an error message can seen from the
init-dom0less application on 1:1 direct-mapped Dom0less DomUs:
```
Allocating magic pages
memory.c:238:d0v0 mfn 0x39000 doesn't belong to d1
Error on alloc
From: Henry Wang
With the new allocation strategy of Dom0less DomUs XenStore page,
update the doc of the late XenStore init protocol accordingly.
Signed-off-by: Henry Wang
---
docs/features/dom0less.pandoc | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git
be direct-mapped for direct-mapped domains. Check the
host physical address to be matched with guest physical address when
parsing the device tree. Document this restriction in the doc.
Signed-off-by: Henry Wang
Signed-off-by: Stefano Stabellini
Acked-by: Michal Orzel
---
docs/misc/arm/device-tree
ents when possible.
> >
> > Reported-by: Alec Kwapis
> > Signed-off-by: Henry Wang
>
> Reviewed-by: Jason Andryuk
Reviewed-by: Stefano Stabellini
On Fri, 17 May 2024, Henry Wang wrote:
> With the new allocation strategy of Dom0less DomUs XenStore page,
> update the doc of the late XenStore init protocol accordingly.
>
> Signed-off-by: Henry Wang
Reviewed-by: Stefano Stabellini
> ---
> v3:
> - Wording change
On Fri, 24 May 2024, Julien Grall wrote:
> Hi Henry,
>
> + Juergen as the Xenstore maintainers. I'd like his opinion on the approach.
> The documentation of the new logic is in:
>
> https://lore.kernel.org/xen-devel/20240517032156.1490515-5-xin.wa...@amd.com/
>
> FWIW I am happy in principle
On Tue, 21 May 2024, Henry Wang wrote:
> Hi Michal,
>
> On 5/21/2024 12:09 AM, Michal Orzel wrote:
> > > > > Thanks. I will take the tag if you are ok with above diff (for the
> > > > > case
> > > > > if this series goes in later than Luca's).
> > > > I would move this check to process_shm()
From: Vikram Garhwal
Signed-off-by: Vikram Garhwal
Signed-off-by: Stefano Stabellini
Signed-off-by: Henry Wang
---
docs/misc/arm/overlay.txt | 82 +++
1 file changed, 82 insertions(+)
create mode 100644 docs/misc/arm/overlay.txt
diff --git a/docs/misc
for not-1:1 mapped domains.
Signed-off-by: Henry Wang
Signed-off-by: Vikram Garhwal
Signed-off-by: Stefano Stabellini
---
xen/arch/arm/domctl.c| 3 +
xen/common/dt-overlay.c | 211 ++-
xen/include/public/domctl.h | 16 ++-
xen/include/public/sysctl.h
ttach. Slightly rework
the command option parsing logic.
Signed-off-by: Henry Wang
Signed-off-by: Stefano Stabellini
Reviewed-by: Jason Andryuk
Reviewed-by: Stefano Stabellini
---
tools/include/libxl.h | 15 +++
tools/include/xenctrl.h | 3 +++
tools/libs/ctrl/
: 61765a07e3d8 ("tools/xl: Add new xl command overlay for device tree
overlay support")
Suggested-by: Anthony PERARD
Signed-off-by: Henry Wang
Reviewed-by: Jason Andryuk
Reviewed-by: Stefano Stabellini
---
tools/xl/xl_cmdtable.c | 2 +-
tools/xl/xl_vmcontrol.c | 6 +++---
2 fil
From: Henry Wang
There are some use cases in which the dom0less domUs need to have
the XEN_DOMCTL_CDF_iommu set at the domain construction time. For
example, the dynamic dtbo feature allows the domain to be assigned
a device that is behind the IOMMU at runtime. For these use cases,
we need to
to provide a method for
user to decide the number of SPIs. This would help to avoid
bumping the `config->arch.nr_spis` in libxl everytime there is a
new platform with increased SPI numbers.
Update the doc and the golang bindings accordingly.
Signed-off-by: Henry Wang
Signed-off-by: Stefano Stabell
this
will introduce interrupt state unsync issues for cases when the
interrupt is active or pending in the guest, therefore for these
cases we simply reject the operation. Do it for both new and old
vGIC implementations.
Signed-off-by: Henry Wang
Signed-off-by: Stefano Stabellini
Reviewed-by: Julien Grall
Hi all,
This is the remaining series for the full functional "dynamic node
programming using overlay dtbo" feature. The first part [1] has
already been merged.
Quoting from the original series, the first part has already made
Xen aware of new device tree node which means updating the dt_host
On Fri, 24 May 2024, Julien Grall wrote:
> Hi Stefano,
>
> On 24/05/2024 03:18, Stefano Stabellini wrote:
> > From: Vikram Garhwal
> >
> > Signed-off-by: Vikram Garhwal
> > Signed-off-by: Stefano Stabellini
> > Signed-off-by: Henry Wang
>
On Fri, 24 May 2024, Julien Grall wrote:
> Hi Stefano,
>
> On 24/05/2024 03:18, Stefano Stabellini wrote:
> > From: Henry Wang
> >
> > With the XEN_DOMCTL_dt_overlay DOMCTL added, users should be able to
> > attach (in the future also detach) devices from the p
On Fri, 24 May 2024, Julien Grall wrote:
> Hi Stefano,
>
> On 24/05/2024 03:18, Stefano Stabellini wrote:
> > From: Henry Wang
> >
> > In order to support the dynamic dtbo device assignment to a running
> > VM, the add/remove of the DT overlay and the attach/det
On Fri, 23 May 2024, Julien Grall wrote:
> Hi,
>
> On 24/05/2024 03:18, Stefano Stabellini wrote:
> > From: Henry Wang
> >
> > Currently, the number of SPIs allocated to the domain is only
> > configurable for Dom0less DomUs. Xen domains are supposed to be
>
On Fri, 24 May 2024, Julien Grall wrote:
> Hi Henry,
>
> On 23/05/2024 08:40, Henry Wang wrote:
> > Currently, the number of SPIs allocated to the domain is only
> > configurable for Dom0less DomUs. Xen domains are supposed to be
> > platform agnostics and therefore the numbers of SPIs for libxl
On Thu, 23 May 2024, Julien Grall wrote:
> Hi Henry,
>
> On 23/05/2024 08:40, Henry Wang wrote:
> > In order to support the dynamic dtbo device assignment to a running
> > VM, the add/remove of the DT overlay and the attach/detach of the
> > device from the DT overlay should happen separately.
On Thu, 23 May 2024, Julien Grall wrote:
> Hi Henry,
>
> On 23/05/2024 08:40, Henry Wang wrote:
> > From: Vikram Garhwal
> >
> > Signed-off-by: Vikram Garhwal
> > Signed-off-by: Stefano Stabellini
> > Signed-off-by: Henry Wang
> > ---
> > v
a new set of "xl dt-overlay" commands and
> > related documentation, i.e. "xl dt-overlay {attach,detach}". Slightly
> > rework the command option parsing logic.
> >
> > Signed-off-by: Henry Wang
> > Reviewed-by: Jason Andryuk
Reviewed-by: St
From: Vikram Garhwal
Signed-off-by: Vikram Garhwal
Signed-off-by: Stefano Stabellini
Signed-off-by: Henry Wang
---
docs/misc/arm/overlay.txt | 82 +++
1 file changed, 82 insertions(+)
create mode 100644 docs/misc/arm/overlay.txt
diff --git a/docs/misc
: 61765a07e3d8 ("tools/xl: Add new xl command overlay for device tree
overlay support")
Suggested-by: Anthony PERARD
Signed-off-by: Henry Wang
Reviewed-by: Jason Andryuk
Reviewed-by: Stefano Stabellini
---
tools/xl/xl_cmdtable.c | 2 +-
tools/xl/xl_vmcontrol.c | 6 +++---
2 fil
in the overlay are
assigned to a single domain.
Also take the opportunity to make one coding style fix in sysctl.h.
xen,reg is to be used to handle non-1:1 mappings but it is currently
unsupported.
Signed-off-by: Henry Wang
Signed-off-by: Vikram Garhwal
Signed-off-by: Stefano Stabellini
---
xen
this
will introduce interrupt state unsync issues for cases when the
interrupt is active or pending in the guest, therefore for these
cases we simply reject the operation. Do it for both new and old
vGIC implementations.
Signed-off-by: Henry Wang
Signed-off-by: Stefano Stabellini
Reviewed-by: Julien Grall
ttach. Slightly rework
the command option parsing logic.
Signed-off-by: Henry Wang
Signed-off-by: Stefano Stabellini
Reviewed-by: Jason Andryuk
Reviewed-by: Stefano Stabellini
---
tools/include/libxl.h | 15 +++
tools/include/xenctrl.h | 3 +++
tools/libs/ctrl/
to provide a method for
user to decide the number of SPIs. This would help to avoid
bumping the `config->arch.nr_spis` in libxl everytime there is a
new platform with increased SPI numbers.
Update the doc and the golang bindings accordingly.
Signed-off-by: Henry Wang
Signed-off-by: Stefano Stabell
From: Henry Wang
There are some use cases in which the dom0less domUs need to have
the XEN_DOMCTL_CDF_iommu set at the domain construction time. For
example, the dynamic dtbo feature allows the domain to be assigned
a device that is behind the IOMMU at runtime. For these use cases,
we need to
Hi all,
This is the remaining series for the full functional "dynamic node
programming using overlay dtbo" feature. The first part [1] has
already been merged.
Quoting from the original series, the first part has already made
Xen aware of new device tree node which means updating the dt_host
and, use EXIT_FAILURE
> instead of ERROR_FAIL.
>
> Fixes: 61765a07e3d8 ("tools/xl: Add new xl command overlay for device tree
> overlay support")
> Suggested-by: Anthony PERARD
> Signed-off-by: Henry Wang
> Reviewed-by: Jason Andryuk
Reviewed-by: Stefano Stabellini
>
On Thu, 23 May 2024, Jan Beulich wrote:
> On 23.05.2024 15:07, Sergiy Kibrik wrote:
> > 16.05.24 14:12, Jan Beulich:
> >> On 15.05.2024 11:12, Sergiy Kibrik wrote:
> >>> --- a/xen/arch/x86/include/asm/cpufeature.h
> >>> +++ b/xen/arch/x86/include/asm/cpufeature.h
> >>> @@ -81,7 +81,8 @@ static
using grants
> >are expected to initialize the xen_grants MR and map it
> >into their address-map accordingly.
> >
> >Signed-off-by: Edgar E. Iglesias
> >Reviewed-by: Stefano Stabellini
> >---
> > hw/xen/xen-hvm-common.c | 12 +
tools/ocaml/libs/xc/xenctrl_stubs.c | 2 +-
> > xen/arch/arm/domain.c | 6 ++
>
> Could I get an Ack from one of the Arm maintainers for the trivial Arm
> change?
Acked-by: Stefano Stabellini
This patch adds a bunch of rules to rules.rst that are uncontroversial
and have zero violations in Xen. As such, they have been approved for
adoption.
All the ones that regard the standard library have the link to the
existing footnote in the notes.
Signed-off-by: Stefano Stabellini
diff --git
an Beulich
Reviewed-by: Stefano Stabellini
> ---
> changes in v4:
> - return 0 instead of -ENODEV and put a comment
> - update description a bit
> ---
> xen/arch/x86/cpu/mcheck/non-fatal.c | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/xen/arch/
On Tue, 21 May 2024, Jan Beulich wrote:
> On 17.05.2024 22:28, Stefano Stabellini wrote:
> > On Fri, 17 May 2024, Jan Beulich wrote:
> >> On 17.05.2024 03:21, Stefano Stabellini wrote:
> >>> On Thu, 16 May 2024, Jan Beulich wrote:
> >>>> 1) In the d
On Tue, 21 May 2024, Andrew Cooper wrote:
> Neither text_poke() nor watchdog_setup() have return value consulted. Switch
> them to being void.
>
> Signed-off-by: Andrew Cooper
Reviewed-by: Stefano Stabellini
> ---
> CC: George Dunlap
> CC: Jan Beulich
> CC:
On Tue, 21 May 2024, Andrew Cooper wrote:
> These are all either completely unused, or do nothing useful.
>
> Signed-off-by: Andrew Cooper
Reviewed-by: Stefano Stabellini
> ---
> CC: George Dunlap
> CC: Jan Beulich
> CC: Stefano Stabellini
> CC: Julien Grall
>
he compiled binary.
>
> Signed-off-by: Andrew Cooper
Reviewed-by: Stefano Stabellini
> ---
> CC: George Dunlap
> CC: Jan Beulich
> CC: Stefano Stabellini
> CC: Julien Grall
> CC: Roberto Bagnara
> CC: consult...@bugseng.com
> CC: Oleksii Kurochko
> ---
>
On Wed, 22 May 2024, Henry Wang wrote:
> Hi Julien,
>
> On 5/21/2024 8:30 PM, Julien Grall wrote:
> > Hi,
> >
> > On 21/05/2024 05:35, Henry Wang wrote:
> > > diff --git a/xen/arch/arm/gic-vgic.c b/xen/arch/arm/gic-vgic.c
> > > index 56490dbc43..956c11ba13 100644
> > > ---
y.
>
> Signed-off-by: Nicola Vetrini
Acked-by: Stefano Stabellini
> ---
> .../eclair_analysis/ECLAIR/monitored.ecl | 17
> automation/eclair_analysis/ECLAIR/tagging.ecl | 78 ++-
> 2 files changed, 94 insertions(+), 1 deletion(-)
>
> diff
On Mon, 20 May 2024, Julien Grall wrote:
> Hi Henry,
>
> On 20/05/2024 02:01, Henry Wang wrote:
> > Hi Julien,
> >
> > On 5/19/2024 7:08 PM, Julien Grall wrote:
> > > Hi,
> > >
> > > On 17/05/2024 07:03, Henry Wang wrote:
> > > > > @@ -444,14 +444,18 @@ int vgic_connect_hw_irq(struct domain *d,
With the caveat that if we do tftp boot this might have to change:
Acked-by: Stefano Stabellini
> ---
> automation/gitlab-ci/test.yaml | 8
> automation/scripts/qubes-x86-64.sh | 30 +-
> 2 files changed, 33 insertions(+), 5 deletions(-)
>
>
On Thu, 16 May 2024, Marek Marczykowski-Górecki wrote:
> Add minimal linux-stubdom smoke test. It starts a simple HVM with
> linux-stubdom. The actual stubdom implementation is taken from Qubes OS
> and then stripped off Qubes-specific code. In particular, the remaining
> code does _not_ support:
86_64 builds, switch Alpine version everywhere for uniformity.
> Note this bumps kernel version requirement on docker runners -
> dracut-install uses faccessat2() syscall which was introduced in Linux
> 5.8.
>
> Signed-off-by: Marek Marczykowski-Górecki
Reviewed-by: Stefano Stabellini
ff-by: Marek Marczykowski-Górecki
Reviewed-by: Stefano Stabellini
> ---
> automation/gitlab-ci/build.yaml | 4 +-
> automation/gitlab-ci/test.yaml | 2 +-
> automation/tests-artifacts/kernel/6.1.19.dockerfile | 40 +--
>
On Thu, 16 May 2024, Marek Marczykowski-Górecki wrote:
> And start collecting qemu log earlier, so it isn't lost in case of a
> timeout during domain startup.
>
> Signed-off-by: Marek Marczykowski-Górecki
Acked-by: Stefano Stabellini
> ---
> automation/scripts/qemu-alpin
On Thu, 16 May 2024, Marek Marczykowski-Górecki wrote:
> It fails on larger initramfs (~250MB one), let Linux do it.
>
> Signed-off-by: Marek Marczykowski-Górecki
Acked-by: Stefano Stabellini
> ---
> automation/scripts/qubes-x86-64.sh | 2 +-
> 1 file changed, 1 insert
On Thu, 16 May 2024, Marek Marczykowski-Górecki wrote:
> Fedora 29 is long EOL
>
> Signed-off-by: Marek Marczykowski-Górecki
Acked-by: Stefano Stabellini
> ---
> automation/build/fedora/29.dockerfile | 46 +
> automation/build/fedora/
On Thu, 16 May 2024, Marek Marczykowski-Górecki wrote:
> Signed-off-by: Marek Marczykowski-Górecki
Acked-by: Stefano Stabellini
> ---
> automation/scripts/qubes-x86-64.sh | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/automation/scripts/qubes-x86-64.sh
>
On Fri, 17 May 2024, Nicola Vetrini wrote:
> This rule has no more violations in the codebase, so it can be
> set as clean.
>
> No functional change.
>
> Signed-off-by: Nicola Vetrini
Reviewed-by: Stefano Stabellini
> ---
> automation/eclair_analysis/ECLAIR/tagg
On Fri, 17 May 2024, Jan Beulich wrote:
> On 17.05.2024 03:21, Stefano Stabellini wrote:
> > On Thu, 16 May 2024, Jan Beulich wrote:
> >> 1) In the discussion George claimed that exposing status information in
> >> an uncontrolled manner is okay. I'm afraid I have t
("xen: add support for initializing xenstore later as HVM
> domain")
> Signed-off-by: Henry Wang
> Signed-off-by: Michal Orzel
Reviewed-by: Stefano Stabellini
> ---
> v2:
> - Use -EINVAL for the memremap() check. (Stefano)
> - Add Fixes: tag. (Stefano)
> - Rework
On Thu, 16 May 2024, Jan Beulich wrote:
> 1) In the discussion George claimed that exposing status information in
> an uncontrolled manner is okay. I'm afraid I have to disagree, seeing
> how a similar assumption by CPU designers has led to a flood of
> vulnerabilities over the last 6+ years.
On Thu, 16 May 2024, Henry Wang wrote:
> Hi Stefano,
>
> On 5/16/2024 6:30 AM, Stefano Stabellini wrote:
> > On Wed, 15 May 2024, Henry Wang wrote:
> > > Currently, the late XenStore init protocol is only triggered properly
> > > for the case that HVM_
> Signed-off-by: Edgar E. Iglesias
Reviewed-by: Stefano Stabellini
On Thu, 16 May 2024, Jan Beulich wrote:
> On 16.05.2024 02:54, Stefano Stabellini wrote:
> > On Wed, 15 May 2024, Sergiy Kibrik wrote:
> >> VMX posted interrupts support can now be excluded from x86 build along with
> >> VMX code itself, but still we may want to keep the
On Thu, 16 May 2024, Andrew Cooper wrote:
> We are about to import code licensed under MIT-0. It's compatible for us to
> use, so identify it as a permitted license.
>
> Signed-off-by: Andrew Cooper
Reviewed-by: Stefano Stabellini
> ---
> CC: Anthony PERARD
> CC
On Thu, 16 May 2024, Chen, Jiqian wrote:
> On 2024/5/16 06:42, Stefano Stabellini wrote:
> > On Wed, 15 May 2024, Jiqian Chen wrote:
> >> In PVH dom0, it uses the linux local interrupt mechanism,
> >> when it allocs irq for a gsi, it is dynamic, and follow
> >
options depend on HVM and
> default to value of HVM.
>
> To prevent users from unknowingly disabling virtualization support, make the
> controls user selectable only if EXPERT is enabled.
>
> No functional change intended.
>
> Signed-off-by: Xenia Ragiadakou
> Signed-off-by: Sergiy Kibrik
Reviewed-by: Stefano Stabellini
On Wed, 15 May 2024, Sergiy Kibrik wrote:
> VMX posted interrupts support can now be excluded from x86 build along with
> VMX code itself, but still we may want to keep the possibility to use
> VT-d IOMMU driver in non-HVM setups.
> So we guard vmx_pi_hooks_{assign/deassign} with some checks for
;
> No functional change intended.
>
> Signed-off-by: Xenia Ragiadakou
> Signed-off-by: Sergiy Kibrik
Reviewed-by: Stefano Stabellini
On Wed, 15 May 2024, Sergiy Kibrik wrote:
> There're several places in common code, outside of arch/x86/hvm/vmx,
> where cpu_has_vmx_* get accessed without checking if VMX present first.
> We may want to guard these macros, as they read global variables defined
> inside vmx-specific files -- so
>
> Signed-off-by: Sergiy Kibrik
Reviewed-by: Stefano Stabellini
>
> Signed-off-by: Sergiy Kibrik
Nice!
Reviewed-by: Stefano Stabellini
On Wed, 15 May 2024, Sergiy Kibrik wrote:
> If VMX/SVM disabled in the build, we may still want to have vPMU drivers for
> PV guests. Yet some calls to vmx/svm-related routines needs to be guarded
> then.
>
> Signed-off-by: Sergiy Kibrik
Question to the x86 maintainers: are we sure we want to
have to add extra #ifdef-s to check whether svm/vmx has been enabled,
> while DCE cleans up calls to vmx/svm functions, if their code not being built.
>
> Signed-off-by: Sergiy Kibrik
> CC: Jan Beulich
Reviewed-by: Stefano Stabellini
On Wed, 15 May 2024, Sergiy Kibrik wrote:
> Instead of using generic CONFIG_HVM option switch to a bit more specific
> CONFIG_ALTP2M option for altp2m support. Also guard altp2m routines, so that
> they can be disabled completely in the build -- when target platform does not
> actually support
; No functional change intended.
>
> Signed-off-by: Sergiy Kibrik
> CC: Tamas K Lengyel
> CC: Jan Beulich
Reviewed-by: Stefano Stabellini
> ---
> changes in v2:
> - no double blank lines
> - no unrelated re-formatting
> - header #include-s ordering
> - chang
On Wed, 15 May 2024, Sergiy Kibrik wrote:
> Add new option to make altp2m code inclusion optional.
> Currently altp2m support provided for VT-d only, so option is dependant on
> VMX.
>
> No functional change intended.
>
> Signed-off-by: Sergiy Kibrik
> CC: Tamas K Lengyel
> ---
>
mm/p2m-ept.c
> @@ -986,7 +986,7 @@ out:
> if ( is_epte_present(_entry) )
> ept_free_entry(p2m, _entry, target);
>
> -if ( entry_written && p2m_is_hostp2m(p2m) )
> +if ( entry_written && p2m_is_hostp2m(p2m) && hvm_altp2m_supported())
> {
> ret = p2m_altp2m_propagate_change(d, _gfn(gfn), mfn, order, p2mt,
> p2ma);
> if ( !rc )
This is a matter of taste but I would put hvm_altp2m_supported() first.
Reviewed-by: Stefano Stabellini
altp2m support and
> exclude its code from the build completely, when not supported by target
> platform (as of now it's supported for VT-d only).
>
> Signed-off-by: Sergiy Kibrik
> CC: Tamas K Lengyel
> CC: Jan Beulich
Reviewed-by: Stefano Stabellini
> ---
> change
On Sat, 4 May 2024, Edgar E. Iglesias wrote:
> From: "Edgar E. Iglesias"
>
> Use the generic xen/linkage.h macros to annotate code symbols
> and add missing annotations.
>
> Signed-off-by: Edgar E. Iglesias
Reviewed-by: Stefano Stabellini
> ---
>
On Sat, 4 May 2024, Edgar E. Iglesias wrote:
> From: "Edgar E. Iglesias"
>
> Use the generic xen/linkage.h macros to annotate code symbols
> and add missing annotations.
>
> Signed-off-by: Edgar E. Iglesias
Reviewed-by: Stefano Stabellini
> ---
>
On Sat, 4 May 2024, Edgar E. Iglesias wrote:
> From: "Edgar E. Iglesias"
>
> Use the generic xen/linkage.h macros to annotate code symbols
> and add missing annotations.
>
> Signed-off-by: Edgar E. Iglesias
Reviewed-by: Stefano Stabellini
> ---
&
On Sat, 4 May 2024, Edgar E. Iglesias wrote:
> From: "Edgar E. Iglesias"
>
> Use the generic xen/linkage.h macros to annotate code symbols
> and add missing annotations.
>
> Signed-off-by: Edgar E. Iglesias
Reviewed-by: Stefano Stabellini
> ---
&g
rrent and future users will be safe with respect to expansions that
> can possibly alter the semantics of the passed-in macro parameter.
>
> No functional change.
>
> Signed-off-by: Nicola Vetrini
Reviewed-by: Stefano Stabellini
rrent and future users will be safe with respect to expansions that
> can possibly alter the semantics of the passed-in macro parameter.
>
> xlat_malloc_init is touched for consistency, despite the construct
> being already deviated.
>
> No functional change.
>
> Signed-off-by: Nicola Vetrini
Reviewed-by: Stefano Stabellini
rrent and future users will be safe with respect to expansions that
> can possibly alter the semantics of the passed-in macro parameter.
>
> No functional change.
>
> Signed-off-by: Nicola Vetrini
Reviewed-by: Stefano Stabellini
> ---
> xen/arch/x86/hvm/mtrr.c | 2 +-
rrent and future users will be safe with respect to expansions that
> can possibly alter the semantics of the passed-in macro parameter.
>
> No functional change.
>
> Signed-off-by: Nicola Vetrini
Reviewed-by: Stefano Stabellini
> ---
> xen/arch/x86/cpu/vpmu_amd.c | 4 ++--
>
> Like with foreign mappings (xen_memory), machines using grants
> are expected to initialize the xen_grants MR and map it
> into their address-map accordingly.
>
> Signed-off-by: Edgar E. Iglesias
Reviewed-by: Stefano Stabellini
On Fri, 3 May 2024, Edgar E. Iglesias wrote:
> From: "Edgar E. Iglesias"
>
> Pass the ram_addr offset to xen_map_cache.
> This is in preparation for adding grant mappings that need
> to compute the address within the RAMBlock.
>
> No functional changes.
>
> Signed-off-by: Edgar E. Iglesias
>
The value returned by __toupper is used in arithmetic operations causing
MISRA C 10.2 violations. Cast to plain char in the toupper macro. Also
do the same in tolower for consistency.
Signed-off-by: Stefano Stabellini
---
Changes in v2:
- fix the toupper macro instead
diff --git a/xen/include
1 - 100 of 6336 matches
Mail list logo
