Re: [PATCH] Xen Keyboard: don't advertise every key known to man

2021-05-18 Thread Phillip Susi
Phillip Susi writes: > Dmitry Torokhov writes: > >> By doing this you are stopping delivery of all key events from this >> device. Hrm... I don't have very many "interesting" keys to test, but when I hit the menu key, I see KEY_COMPOSE, which is > KEY_MIN_INTERESTING. When I press the button

Re: [PATCH] Xen Keyboard: don't advertise every key known to man

2021-05-18 Thread Phillip Susi
Dmitry Torokhov writes: > By doing this you are stopping delivery of all key events from this > device. It does? How does the PS/2 keyboard driver work then? It has no way of knowning what keys the keyboard has other than waiting to see what scan codes are emitted. If the keys must be

Re: [PATCH] Xen Keyboard: don't advertise every key known to man

2021-05-06 Thread Dmitry Torokhov
On Thu, May 06, 2021 at 02:36:54PM +, Phillip Susi wrote: > For reasons I still don't understand, the input subsystem allows > input devices to advertise what keys they have, and adds this > information to the modalias for the device. The Xen Virtual > Keyboard was advertising every known

[PATCH] Xen Keyboard: don't advertise every key known to man

2021-05-06 Thread Phillip Susi
For reasons I still don't understand, the input subsystem allows input devices to advertise what keys they have, and adds this information to the modalias for the device. The Xen Virtual Keyboard was advertising every known key, which resulted in a modalias string over 2 KiB in length, which