Re: [PATCH] build/xen: fail to rebuild if Kconfig fails

2024-02-19 Thread Jan Beulich
On 16.02.2024 11:51, Roger Pau Monné wrote: > On Fri, Feb 16, 2024 at 11:04:46AM +0100, Jan Beulich wrote: >> On 15.02.2024 18:23, Roger Pau Monné wrote: >>> On Thu, Feb 15, 2024 at 05:22:00PM +0100, Jan Beulich wrote: On 15.02.2024 17:08, Roger Pau Monné wrote: > On Thu, Feb 15, 2024 at

Re: [PATCH] build/xen: fail to rebuild if Kconfig fails

2024-02-16 Thread Roger Pau Monné
On Fri, Feb 16, 2024 at 11:04:46AM +0100, Jan Beulich wrote: > On 15.02.2024 18:23, Roger Pau Monné wrote: > > On Thu, Feb 15, 2024 at 05:22:00PM +0100, Jan Beulich wrote: > >> On 15.02.2024 17:08, Roger Pau Monné wrote: > >>> On Thu, Feb 15, 2024 at 02:02:41PM +0100, Jan Beulich wrote: > ---

Re: [PATCH] build/xen: fail to rebuild if Kconfig fails

2024-02-16 Thread Jan Beulich
On 15.02.2024 18:23, Roger Pau Monné wrote: > On Thu, Feb 15, 2024 at 05:22:00PM +0100, Jan Beulich wrote: >> On 15.02.2024 17:08, Roger Pau Monné wrote: >>> On Thu, Feb 15, 2024 at 02:02:41PM +0100, Jan Beulich wrote: --- a/xen/Rules.mk +++ b/xen/Rules.mk @@ -15,7 +15,11 @@ srcdir

Re: [PATCH] build/xen: fail to rebuild if Kconfig fails

2024-02-15 Thread Roger Pau Monné
On Thu, Feb 15, 2024 at 05:22:00PM +0100, Jan Beulich wrote: > On 15.02.2024 17:08, Roger Pau Monné wrote: > > On Thu, Feb 15, 2024 at 02:02:41PM +0100, Jan Beulich wrote: > >> --- a/xen/Rules.mk > >> +++ b/xen/Rules.mk > >> @@ -15,7 +15,11 @@ srcdir := $(srctree)/$(src) > >> PHONY := __build >

Re: [PATCH] build/xen: fail to rebuild if Kconfig fails

2024-02-15 Thread Jan Beulich
On 15.02.2024 17:08, Roger Pau Monné wrote: > On Thu, Feb 15, 2024 at 02:02:41PM +0100, Jan Beulich wrote: >> --- a/xen/Rules.mk >> +++ b/xen/Rules.mk >> @@ -15,7 +15,11 @@ srcdir := $(srctree)/$(src) >> PHONY := __build >> __build: >> >> --include $(objtree)/include/config/auto.conf >> +ifneq

Re: [PATCH] build/xen: fail to rebuild if Kconfig fails

2024-02-15 Thread Roger Pau Monné
On Thu, Feb 15, 2024 at 02:02:41PM +0100, Jan Beulich wrote: > On 15.02.2024 12:04, Roger Pau Monné wrote: > > On Thu, Feb 15, 2024 at 11:43:02AM +0100, Jan Beulich wrote: > >> On 15.02.2024 11:28, Roger Pau Monné wrote: > >>> On Thu, Feb 15, 2024 at 10:49:31AM +0100, Jan Beulich wrote: > On

Re: [PATCH] build/xen: fail to rebuild if Kconfig fails

2024-02-15 Thread Jan Beulich
On 15.02.2024 12:04, Roger Pau Monné wrote: > On Thu, Feb 15, 2024 at 11:43:02AM +0100, Jan Beulich wrote: >> On 15.02.2024 11:28, Roger Pau Monné wrote: >>> On Thu, Feb 15, 2024 at 10:49:31AM +0100, Jan Beulich wrote: On 15.02.2024 10:30, Roger Pau Monne wrote: > --- a/xen/Makefile >

Re: [PATCH] build/xen: fail to rebuild if Kconfig fails

2024-02-15 Thread Jan Beulich
On 15.02.2024 13:11, Jan Beulich wrote: > On 15.02.2024 12:04, Roger Pau Monné wrote: >> On Thu, Feb 15, 2024 at 11:43:02AM +0100, Jan Beulich wrote: >>> On 15.02.2024 11:28, Roger Pau Monné wrote: Without the reordering the include of include/config/auto.conf will always succeed on

Re: [PATCH] build/xen: fail to rebuild if Kconfig fails

2024-02-15 Thread Jan Beulich
On 15.02.2024 12:04, Roger Pau Monné wrote: > On Thu, Feb 15, 2024 at 11:43:02AM +0100, Jan Beulich wrote: >> On 15.02.2024 11:28, Roger Pau Monné wrote: >>> Without the reordering the include of include/config/auto.conf will >>> always succeed on rebuilds, because the include is done before >>>

Re: [PATCH] build/xen: fail to rebuild if Kconfig fails

2024-02-15 Thread Roger Pau Monné
On Thu, Feb 15, 2024 at 10:32:57AM +, Anthony PERARD wrote: > On Thu, Feb 15, 2024 at 10:30:02AM +0100, Roger Pau Monne wrote: > > When doing a rebuild with an xen/include/config/auto.conf already present in > > the tree, failures from Kconfig are ignored since the target is present: > > > >

Re: [PATCH] build/xen: fail to rebuild if Kconfig fails

2024-02-15 Thread Roger Pau Monné
On Thu, Feb 15, 2024 at 11:43:02AM +0100, Jan Beulich wrote: > On 15.02.2024 11:28, Roger Pau Monné wrote: > > On Thu, Feb 15, 2024 at 10:49:31AM +0100, Jan Beulich wrote: > >> On 15.02.2024 10:30, Roger Pau Monne wrote: > >>> --- a/xen/Makefile > >>> +++ b/xen/Makefile > >>> @@ -358,10 +358,10 @@

Re: [PATCH] build/xen: fail to rebuild if Kconfig fails

2024-02-15 Thread Jan Beulich
On 15.02.2024 11:28, Roger Pau Monné wrote: > On Thu, Feb 15, 2024 at 10:49:31AM +0100, Jan Beulich wrote: >> On 15.02.2024 10:30, Roger Pau Monne wrote: >>> --- a/xen/Makefile >>> +++ b/xen/Makefile >>> @@ -358,10 +358,10 @@ config: tools_fixdep outputmakefile FORCE >>> else # !config-build >>>

Re: [PATCH] build/xen: fail to rebuild if Kconfig fails

2024-02-15 Thread Jan Beulich
On 15.02.2024 11:32, Anthony PERARD wrote: > On Thu, Feb 15, 2024 at 10:30:02AM +0100, Roger Pau Monne wrote: >> When doing a rebuild with an xen/include/config/auto.conf already present in >> the tree, failures from Kconfig are ignored since the target is present: >> >> gmake -C xen install >>

Re: [PATCH] build/xen: fail to rebuild if Kconfig fails

2024-02-15 Thread Anthony PERARD
On Thu, Feb 15, 2024 at 10:30:02AM +0100, Roger Pau Monne wrote: > When doing a rebuild with an xen/include/config/auto.conf already present in > the tree, failures from Kconfig are ignored since the target is present: > > gmake -C xen install > gmake[1]: Entering directory '/root/src/xen/xen' >

Re: [PATCH] build/xen: fail to rebuild if Kconfig fails

2024-02-15 Thread Roger Pau Monné
On Thu, Feb 15, 2024 at 10:49:31AM +0100, Jan Beulich wrote: > On 15.02.2024 10:30, Roger Pau Monne wrote: > > --- a/xen/Makefile > > +++ b/xen/Makefile > > @@ -358,10 +358,10 @@ config: tools_fixdep outputmakefile FORCE > > else # !config-build > > > > ifeq ($(need-config),y) > > --include

Re: [PATCH] build/xen: fail to rebuild if Kconfig fails

2024-02-15 Thread Jan Beulich
On 15.02.2024 10:30, Roger Pau Monne wrote: > --- a/xen/Makefile > +++ b/xen/Makefile > @@ -358,10 +358,10 @@ config: tools_fixdep outputmakefile FORCE > else # !config-build > > ifeq ($(need-config),y) > --include include/config/auto.conf > # Read in dependencies to all Kconfig* files, make

[PATCH] build/xen: fail to rebuild if Kconfig fails

2024-02-15 Thread Roger Pau Monne
When doing a rebuild with an xen/include/config/auto.conf already present in the tree, failures from Kconfig are ignored since the target is present: gmake -C xen install gmake[1]: Entering directory '/root/src/xen/xen' tools/kconfig/conf --syncconfig Kconfig common/Kconfig:2: syntax error