Re: [PATCH] tools/libxc: use uint32_t for pirq in xc_domain_irq_permission

2021-07-12 Thread Julien Grall
Hi Igor, On 08/07/2021 03:06, Igor Druzhinin wrote: On 07/07/2021 14:21, Julien Grall wrote: On 07/07/2021 14:14, Jan Beulich wrote: On 07.07.2021 14:59, Julien Grall wrote: On 07/07/2021 13:54, Jan Beulich wrote: On 07.07.2021 14:51, Julien Grall wrote: On 07/07/2021 02:02, Igor Druzhinin

Re: [PATCH] tools/libxc: use uint32_t for pirq in xc_domain_irq_permission

2021-07-07 Thread Igor Druzhinin
On 07/07/2021 14:21, Julien Grall wrote: On 07/07/2021 14:14, Jan Beulich wrote: On 07.07.2021 14:59, Julien Grall wrote: On 07/07/2021 13:54, Jan Beulich wrote: On 07.07.2021 14:51, Julien Grall wrote: On 07/07/2021 02:02, Igor Druzhinin wrote: Current unit8_t for pirq argument in this

Re: [PATCH] tools/libxc: use uint32_t for pirq in xc_domain_irq_permission

2021-07-07 Thread Igor Druzhinin
On 08/07/2021 02:26, Andrew Cooper wrote: On 08/07/2021 02:14, Igor Druzhinin wrote: On 08/07/2021 02:11, Andrew Cooper wrote: On 08/07/2021 02:08, Igor Druzhinin wrote: On 07/07/2021 10:19, Andrew Cooper wrote: On 07/07/2021 08:46, Jan Beulich wrote: --- a/tools/include/xenctrl.h +++

Re: [PATCH] tools/libxc: use uint32_t for pirq in xc_domain_irq_permission

2021-07-07 Thread Andrew Cooper
On 08/07/2021 02:14, Igor Druzhinin wrote: > On 08/07/2021 02:11, Andrew Cooper wrote: >> On 08/07/2021 02:08, Igor Druzhinin wrote: >>> On 07/07/2021 10:19, Andrew Cooper wrote: On 07/07/2021 08:46, Jan Beulich wrote: >> --- a/tools/include/xenctrl.h >> +++ b/tools/include/xenctrl.h

Re: [PATCH] tools/libxc: use uint32_t for pirq in xc_domain_irq_permission

2021-07-07 Thread Igor Druzhinin
On 08/07/2021 02:11, Andrew Cooper wrote: On 08/07/2021 02:08, Igor Druzhinin wrote: On 07/07/2021 10:19, Andrew Cooper wrote: On 07/07/2021 08:46, Jan Beulich wrote: --- a/tools/include/xenctrl.h +++ b/tools/include/xenctrl.h @@ -1385,7 +1385,7 @@ int xc_domain_ioport_permission(xc_interface

Re: [PATCH] tools/libxc: use uint32_t for pirq in xc_domain_irq_permission

2021-07-07 Thread Andrew Cooper
On 08/07/2021 02:08, Igor Druzhinin wrote: > On 07/07/2021 10:19, Andrew Cooper wrote: >> On 07/07/2021 08:46, Jan Beulich wrote: --- a/tools/include/xenctrl.h +++ b/tools/include/xenctrl.h @@ -1385,7 +1385,7 @@ int xc_domain_ioport_permission(xc_interface *xch,     int

Re: [PATCH] tools/libxc: use uint32_t for pirq in xc_domain_irq_permission

2021-07-07 Thread Igor Druzhinin
On 07/07/2021 10:19, Andrew Cooper wrote: On 07/07/2021 08:46, Jan Beulich wrote: --- a/tools/include/xenctrl.h +++ b/tools/include/xenctrl.h @@ -1385,7 +1385,7 @@ int xc_domain_ioport_permission(xc_interface *xch, int xc_domain_irq_permission(xc_interface *xch,

Re: [PATCH] tools/libxc: use uint32_t for pirq in xc_domain_irq_permission

2021-07-07 Thread Jan Beulich
On 07.07.2021 15:21, Julien Grall wrote: > On 07/07/2021 14:14, Jan Beulich wrote: >> On 07.07.2021 14:59, Julien Grall wrote: >>> The alternative suggestion is to keep a unsigned type but check the bit >>> 31 is not set. >> >> Why? Why not bit 30 or bit 27? There's nothing special about >> bit 31

Re: [PATCH] tools/libxc: use uint32_t for pirq in xc_domain_irq_permission

2021-07-07 Thread Julien Grall
On 07/07/2021 14:14, Jan Beulich wrote: On 07.07.2021 14:59, Julien Grall wrote: On 07/07/2021 13:54, Jan Beulich wrote: On 07.07.2021 14:51, Julien Grall wrote: On 07/07/2021 02:02, Igor Druzhinin wrote: Current unit8_t for pirq argument in this interface is too restrictive causing

Re: [PATCH] tools/libxc: use uint32_t for pirq in xc_domain_irq_permission

2021-07-07 Thread Jan Beulich
On 07.07.2021 14:59, Julien Grall wrote: > On 07/07/2021 13:54, Jan Beulich wrote: >> On 07.07.2021 14:51, Julien Grall wrote: >>> On 07/07/2021 02:02, Igor Druzhinin wrote: Current unit8_t for pirq argument in this interface is too restrictive causing failures on modern hardware with

Re: [PATCH] tools/libxc: use uint32_t for pirq in xc_domain_irq_permission

2021-07-07 Thread Julien Grall
On 07/07/2021 13:54, Jan Beulich wrote: On 07.07.2021 14:51, Julien Grall wrote: On 07/07/2021 02:02, Igor Druzhinin wrote: Current unit8_t for pirq argument in this interface is too restrictive causing failures on modern hardware with lots of GSIs. That extends down to

Re: [PATCH] tools/libxc: use uint32_t for pirq in xc_domain_irq_permission

2021-07-07 Thread Jan Beulich
On 07.07.2021 14:51, Julien Grall wrote: > On 07/07/2021 02:02, Igor Druzhinin wrote: >> Current unit8_t for pirq argument in this interface is too restrictive >> causing failures on modern hardware with lots of GSIs. That extends down to >> XEN_DOMCTL_irq_permission ABI structure where it needs

Re: [PATCH] tools/libxc: use uint32_t for pirq in xc_domain_irq_permission

2021-07-07 Thread Julien Grall
Hi Igor, On 07/07/2021 02:02, Igor Druzhinin wrote: Current unit8_t for pirq argument in this interface is too restrictive causing failures on modern hardware with lots of GSIs. That extends down to XEN_DOMCTL_irq_permission ABI structure where it needs to be fixed up as well. Internal Xen

Re: [PATCH] tools/libxc: use uint32_t for pirq in xc_domain_irq_permission

2021-07-07 Thread Andrew Cooper
On 07/07/2021 08:46, Jan Beulich wrote: >> --- a/tools/include/xenctrl.h >> +++ b/tools/include/xenctrl.h >> @@ -1385,7 +1385,7 @@ int xc_domain_ioport_permission(xc_interface *xch, >> >> int xc_domain_irq_permission(xc_interface *xch, >> uint32_t domid, >> -

Re: [PATCH] tools/libxc: use uint32_t for pirq in xc_domain_irq_permission

2021-07-07 Thread Christian Lindig
On 7 Jul 2021, at 02:02, Igor Druzhinin mailto:igor.druzhi...@citrix.com>> wrote: Current unit8_t for pirq argument in this interface is too restrictive causing failures on modern hardware with lots of GSIs. That extends down to XEN_DOMCTL_irq_permission ABI structure where it needs to be

Re: [PATCH] tools/libxc: use uint32_t for pirq in xc_domain_irq_permission

2021-07-07 Thread Jan Beulich
On 07.07.2021 03:02, Igor Druzhinin wrote: > Current unit8_t for pirq argument in this interface is too restrictive > causing failures on modern hardware with lots of GSIs. That extends down to > XEN_DOMCTL_irq_permission ABI structure where it needs to be fixed up > as well. Internal Xen

[PATCH] tools/libxc: use uint32_t for pirq in xc_domain_irq_permission

2021-07-06 Thread Igor Druzhinin
Current unit8_t for pirq argument in this interface is too restrictive causing failures on modern hardware with lots of GSIs. That extends down to XEN_DOMCTL_irq_permission ABI structure where it needs to be fixed up as well. Internal Xen structures appear to be fine. Existing users of the