Re: [PATCH] x86/entry: shrink insn size for some of our EFLAGS manipulation

2024-03-06 Thread Jan Beulich
On 06.03.2024 12:14, Andrew Cooper wrote: > On 06/03/2024 10:49 am, Jan Beulich wrote: >> On 06.03.2024 11:33, Andrew Cooper wrote: >>> On 05/03/2024 2:04 pm, Jan Beulich wrote: --- a/xen/arch/x86/x86_64/entry.S +++ b/xen/arch/x86/x86_64/entry.S @@ -52,7 +52,7 @@

Re: [PATCH] x86/entry: shrink insn size for some of our EFLAGS manipulation

2024-03-06 Thread Andrew Cooper
On 06/03/2024 10:49 am, Jan Beulich wrote: > On 06.03.2024 11:33, Andrew Cooper wrote: >> On 05/03/2024 2:04 pm, Jan Beulich wrote: >>> --- a/xen/arch/x86/x86_64/entry.S >>> +++ b/xen/arch/x86/x86_64/entry.S >>> @@ -52,7 +52,7 @@ UNLIKELY_END(syscall_no_callback) >>> movq

Re: [PATCH] x86/entry: shrink insn size for some of our EFLAGS manipulation

2024-03-06 Thread Jan Beulich
On 06.03.2024 11:33, Andrew Cooper wrote: > On 05/03/2024 2:04 pm, Jan Beulich wrote: >> --- a/xen/arch/x86/x86_64/entry.S >> +++ b/xen/arch/x86/x86_64/entry.S >> @@ -52,7 +52,7 @@ UNLIKELY_END(syscall_no_callback) >> movq %rax,TRAPBOUNCE_eip(%rdx) >> movb

Re: [PATCH] x86/entry: shrink insn size for some of our EFLAGS manipulation

2024-03-06 Thread Andrew Cooper
On 05/03/2024 2:04 pm, Jan Beulich wrote: > --- a/xen/arch/x86/x86_64/entry.S > +++ b/xen/arch/x86/x86_64/entry.S > @@ -52,7 +52,7 @@ UNLIKELY_END(syscall_no_callback) > movq %rax,TRAPBOUNCE_eip(%rdx) > movb %cl,TRAPBOUNCE_flags(%rdx) > call create_bounce_frame > -

[PATCH] x86/entry: shrink insn size for some of our EFLAGS manipulation

2024-03-05 Thread Jan Beulich
Much like was recently done for setting entry vector, and along the lines of what we already had in handle_exception_saved, avoid 32-bit immediates where 8-bit ones do. Reduces .text.entry size by 16 bytes in my non-CET reference build, while in my CET reference build section size doesn't change